Passed
Pull Request — master (#19)
by Tim
05:32
created

89 +46 Covered Lines

170 +37 Total Lines

52.4 % +20% Code Coverage

PHP Classes Changes

 
0%
ImpressionThreshold added
 
0%
SystemRandomIntegerGenerator added
 
0%
EmptyBannerSelectionData added
 
0%
ActiveBannerSelectionData added
0%
100%
BannerSelectionController improved
0%
100%
BannerSelectionUseCase improved
100%
0%
Banner got worse
88.89%
73.91%
Campaign got worse
100%
85.71%
Bucket got worse
0%
 
TrafficImpressionThreshold removed
0%
 
BannerSelection removed

CRAP Changes

 
2
BannerSelectionUseCase::getCurrentCampaign() added
 
2
ActiveBannerSelectionData::getCampaignEnd() added
 
2
ActiveBannerSelectionData::getBannerIdentifier() added
 
2
ImpressionThreshold::__construct() added
 
2
ActiveBannerSelectionData::getVisitorData() added
 
2
ImpressionThreshold::isThresholdReached() added
 
2
ActiveBannerSelectionData::__construct() added
 
2
ActiveBannerSelectionData::displayBanner() added
 
2
Campaign::getEnd() added
 
2
Campaign::getDisplayPercentage() added
view more  
2
1
BannerSelectionController::__construct() improved
2
1
BannerSelectionController::buildValuesFromRequest(... improved
2
1
BannerSelectionUseCase::__construct() improved
6
5
BannerSelectionUseCase::provideBannerRequest() improved
1
2
Banner::__construct() got worse
1
2
Banner::getIdentifier() got worse
1
2
Bucket::getIdentifier() got worse
1
2
Campaign::getIdentifier() got worse
6
3
BannerSelectionController::selectBanner() improved
6
 
TrafficImpressionThreshold::getIsOverThreshold() removed
2
 
TrafficImpressionThreshold::__construct() removed
2
 
TrafficImpressionThreshold::isImpressionLimitReach... removed
2
 
TrafficImpressionThreshold::isTrafficLimited() removed
2
 
BannerSelection::getCampaignEnd() removed
2
 
BannerSelection::__construct() removed
2
 
BannerSelection::getVisitorData() removed
2
 
BannerSelection::displayBanner() removed
2
 
BannerSelection::createEmptySelection() removed
2
 
BannerSelection::createBannerSelection() removed
view more