Completed
Pull Request — master (#21)
by Tim
03:04
created
src/UseCase/BannerSelection/CampaignConfigurationLoader.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare( strict_types = 1 );
3
+declare(strict_types=1);
4 4
 
5 5
 namespace WMDE\BannerServer\UseCase\BannerSelection;
6 6
 
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 			return Yaml::parseFile( $this->configFile );
91 91
 		}
92 92
 		catch ( ParseException $exception ) {
93
-			$this->logger->critical( 'Unable to read banner server config file.', [ 'exception' => $exception ] );
93
+			$this->logger->critical( 'Unable to read banner server config file.', ['exception' => $exception] );
94 94
 			return [];
95 95
 		}
96 96
 	}
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,8 +88,7 @@
 block discarded – undo
88 88
 	private function parseConfiguration(): array {
89 89
 		try {
90 90
 			return Yaml::parseFile( $this->configFile );
91
-		}
92
-		catch ( ParseException $exception ) {
91
+		} catch ( ParseException $exception ) {
93 92
 			$this->logger->critical( 'Unable to read banner server config file.', [ 'exception' => $exception ] );
94 93
 			return [];
95 94
 		}
Please login to merge, or discard this patch.
tests/Unit/UseCase/BannerSelection/CampaignConfigurationLoaderTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare( strict_types = 1 );
3
+declare(strict_types=1);
4 4
 
5 5
 namespace WMDE\BannerServer\Tests\Unit\UseCase\BannerSelection;
6 6
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 	public function test_given_invalid_campaign_file_then_empty_campaign_configuration_is_returned() {
43 43
 		$testHandler = new TestHandler();
44 44
 		$loader = new CampaignConfigurationLoader(
45
-			new Logger( 'TestLogger', [ $testHandler ] ),
45
+			new Logger( 'TestLogger', [$testHandler] ),
46 46
 			'SOME_INVALID_PATH/' . self::TEST_CAMPAIGN_CONFIGURATION_FILE
47 47
 		);
48 48
 		$this->assertEquals( new CampaignCollection(), $loader->getCampaignCollection() );
Please login to merge, or discard this patch.