View GitHub Repository banner-server

Schedule Inspection
Subscribe
Completed
Pull Request — master (#19)
by Tim
03:07
created

134 +91 Covered Lines

160 +27 Total Lines

83.8 % +51.4% Code Coverage

PHP Classes Changes

 
 ⇢
100%
RandomInteger added
 
 ⇢
100%
ImpressionThreshold added
0%
 ↗
100%
 BannerSelectionController improved
0%
 ↗
100%
 Visitor improved
0%
 ↗
100%
 BannerSelection improved
0%
 ↗
100%
 BannerSelectionUseCase improved
88.89%
 ↗
100%
 Campaign improved
0%
 ↛
 
 TrafficImpressionThreshold removed

CRAP Changes

 
 ⇢
2
BannerSelectionUseCase::getCurrentCampaign() added
 
 ⇢
1
Campaign::isRatioLimited() added
 
 ⇢
1
Campaign::getEnd() added
 
 ⇢
1
RandomInteger::getRandomInteger() added
 
 ⇢
1
BannerSelectionController::getBannerUrl() added
 
 ⇢
1
BannerSelectionController::getCookies() added
 
 ⇢
1
ImpressionThreshold::__construct() added
 
 ⇢
1
ImpressionThreshold::isThresholdReached() added
2
 ↘
1
 Visitor::getTotalImpressionCount() improved
2
 ↘
1
 Visitor::getBucketIdentifier() improved
2
 ↘
1
 Visitor::__construct() improved
2
 ↘
1
 BannerSelectionController::__construct() improved
2
 ↘
1
 BannerSelectionController::buildValuesFromRequest(... improved
2
 ↘
1
 BannerSelectionUseCase::__construct() improved
2
 ↘
1
 Visitor::hasDonated() improved
2
 ↘
1
 BannerSelection::getCampaignEnd() improved
2
 ↘
1
 BannerSelection::__construct() improved
2
 ↘
1
 BannerSelection::getVisitorData() improved
⋮ view more  
6
 ↛
 
 TrafficImpressionThreshold::getIsOverThreshold() removed
2
 ↛
 
 TrafficImpressionThreshold::__construct() removed
2
 ↛
 
 TrafficImpressionThreshold::isImpressionLimitReach... removed
2
 ↛
 
 TrafficImpressionThreshold::isTrafficLimited() removed
2
 ↛
 
 Campaign::getCampaignExpiration() removed