View GitHub Repository banner-server

Schedule Inspection
Subscribe
Test Setup Failed
Pull Request — master (#37)
by Gabriel
62:16
created
Status
Category
Toggle Patches
tests/Fixtures/VisitorFixture.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare( strict_types = 1 );
3 
+declare(strict_types=1);
4 4
5 5 
 namespace WMDE\BannerServer\Tests\Fixtures;
6 6 
 
@@ -22,7 +22,7 @@  discard block
 
 block discarded – undo
22 22 
 			[
23 23 
 				BannerSelectionController::IMPRESSION_COUNT_COOKIE => self::VISITOR_TEST_IMPRESSION_COUNT,
24 24 
 				BannerSelectionController::BUCKET_COOKIE => self::VISITOR_TEST_BUCKET,
25 
-				BannerSelectionController::CATEGORY_COOKIE => self::VISITOR_TEST_DONATION_CATEGORY ]
25 
+				BannerSelectionController::CATEGORY_COOKIE => self::VISITOR_TEST_DONATION_CATEGORY]
26 26 
 		);
27 27 
 	}
28 28
Please login to merge, or discard this patch.
src/Controller/DonationFinishedController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare( strict_types = 1 );
3 
+declare(strict_types=1);
4 4
5 5 
 namespace WMDE\BannerServer\Controller;
6 6 
 
@@ -42,7 +42,7 @@  discard block
 
 block discarded – undo
42 42 
 	private function newHtmlResponse( string $message, int $status = Response::HTTP_OK ): Response {
43 43 
 		$html = "<!DOCTYPE html><html lang='en'><head><title>WMDE Banner Server</title>" .
44 44 
 			"<meta charset=utf-8></head><body>$message</body></html>";
45 
-		return new Response( $html, $status, [ 'content-type' => 'text/html' ] );
45 
+		return new Response( $html, $status, ['content-type' => 'text/html'] );
46 46 
 	}
47 47
48 48 
 	private function isImageRequest( Request $request ): bool {
Please login to merge, or discard this patch.
tests/Unit/Controller/DonationFinishedControllerTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare( strict_types = 1 );
3 
+declare(strict_types=1);
4 4
5 5 
 namespace WMDE\BannerServer\Tests\Unit\Controller;
6 6 
 
@@ -37,7 +37,7 @@  discard block
 
 block discarded – undo
37 37
38 38 
 		$this->assertSame( Response::HTTP_OK, $response->getStatusCode() );
39 39 
 		$firstCookie = $response->headers->getCookies( ResponseHeaderBag::COOKIES_FLAT )[0];
40 
-		$expectedDate =( new \DateTime() )->add( new \DateInterval( 'P180D' ) );
40 
+		$expectedDate = ( new \DateTime() )->add( new \DateInterval( 'P180D' ) );
41 41
42 42 
 		$this->assertSame( 'fundraising,fundraising_next', $firstCookie->getValue() );
43 43 
 		$this->assertEqualsWithDelta( $expectedDate->getTimestamp(), $firstCookie->getExpiresTime(), 5 );
Please login to merge, or discard this patch.