Passed
Push — master ( 7d7cf1...424d8c )
by Gabriel
37s queued 10s
created

139 +96 Covered Lines

141 +8 Total Lines

98.6 % +66.3% Code Coverage

PHP Classes Changes

 
0%
SystemRandomIntegerGenerator added
 
100%
ImpressionThreshold added
 
100%
EmptyBannerSelectionData added
 
100%
ActiveBannerSelectionData added
0%
100%
BannerSelectionController improved
0%
100%
Visitor improved
0%
100%
BannerSelectionUseCase improved
88.89%
100%
Campaign improved
0%
 
TrafficImpressionThreshold removed
0%
 
BannerSelection removed

CRAP Changes

 
5
BannerSelectionUseCase::selectBanner() added
 
2
SystemRandomIntegerGenerator::getRandomInteger() added
 
2
BannerSelectionUseCase::getCurrentCampaign() added
 
1
ActiveBannerSelectionData::getCampaignEnd() added
 
1
ActiveBannerSelectionData::getBannerIdentifier() added
 
1
ActiveBannerSelectionData::getVisitorData() added
 
1
BannerSelectionController::getBannerUrl() added
 
1
ActiveBannerSelectionData::__construct() added
 
1
BannerSelectionController::getCookies() added
 
1
ActiveBannerSelectionData::displayBanner() added
view more  
2
1
Visitor::getTotalImpressionCount() improved
2
1
Visitor::getBucketIdentifier() improved
2
1
Visitor::__construct() improved
2
1
BannerSelectionController::__construct() improved
2
1
BannerSelectionController::buildValuesFromRequest(... improved
2
1
BannerSelectionUseCase::__construct() improved
2
1
Visitor::hasDonated() improved
6
3
BannerSelectionController::selectBanner() improved
6
 
TrafficImpressionThreshold::getIsOverThreshold() removed
6
 
BannerSelectionUseCase::provideBannerRequest() removed
2
 
TrafficImpressionThreshold::__construct() removed
2
 
TrafficImpressionThreshold::isImpressionLimitReach... removed
2
 
TrafficImpressionThreshold::isTrafficLimited() removed
2
 
BannerSelection::getCampaignEnd() removed
2
 
BannerSelection::__construct() removed
2
 
BannerSelection::getVisitorData() removed
2
 
BannerSelection::displayBanner() removed
2
 
BannerSelection::createEmptySelection() removed
view more