wmde / FundraisingFrontend

src/Validation/PersonNameValidator.php

Spacing +15 added lines, -15 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\Validation;
 
@@ -13,28 +13,28 @@ 
 class PersonNameValidator {
 	use CanValidateField;
 
-	public function validate( DonorName $name ): ValidationResult {
-		if ( $name->getPersonType() === DonorName::PERSON_PRIVATE ) {
-			return $this->validatePrivatePerson( $name );
+	public function validate(DonorName $name): ValidationResult {
+		if ($name->getPersonType() === DonorName::PERSON_PRIVATE) {
+			return $this->validatePrivatePerson($name);
 		}
 
-		return $this->validateCompanyPerson( $name );
+		return $this->validateCompanyPerson($name);
 	}
 
-	private function validatePrivatePerson( DonorName $instance ): ValidationResult {
+	private function validatePrivatePerson(DonorName $instance): ValidationResult {
 		$validator = new RequiredFieldValidator();
 
-		return new ValidationResult( ...array_filter( [
-			$this->getFieldViolation( $validator->validate( $instance->getSalutation() ), 'salutation' ),
-			$this->getFieldViolation( $validator->validate( $instance->getFirstName() ), 'firstName' ),
-			$this->getFieldViolation( $validator->validate( $instance->getLastName() ), 'lastName' )
-		] ) );
+		return new ValidationResult(...array_filter([
+			$this->getFieldViolation($validator->validate($instance->getSalutation()), 'salutation'),
+			$this->getFieldViolation($validator->validate($instance->getFirstName()), 'firstName'),
+			$this->getFieldViolation($validator->validate($instance->getLastName()), 'lastName')
+		]));
 	}
 
-	private function validateCompanyPerson( DonorName $instance ): ValidationResult {
-		return new ValidationResult( ...array_filter( [
-			$this->getFieldViolation( ( new RequiredFieldValidator() )->validate( $instance->getCompanyName() ), 'company' )
-		] ) );
+	private function validateCompanyPerson(DonorName $instance): ValidationResult {
+		return new ValidationResult(...array_filter([
+			$this->getFieldViolation((new RequiredFieldValidator())->validate($instance->getCompanyName()), 'company')
+		]));
 	}
 
 }

src/MembershipApplicationContext/Domain/Model/MembershipApplicant.php

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\Domain\Model;
 
@@ -18,8 +18,8 @@ 
 	private $phone;
 	private $dateOfBirth;
 
-	public function __construct( ApplicantName $name, PhysicalAddress $address, EmailAddress $email,
-		PhoneNumber $phone, \DateTime $dateOfBirth = null ) {
+	public function __construct(ApplicantName $name, PhysicalAddress $address, EmailAddress $email,
+		PhoneNumber $phone, \DateTime $dateOfBirth = null) {
 
 		$this->personName = $name;
 		$this->physicalAddress = $address;
@@ -47,7 +47,7 @@ 
 		return $this->dateOfBirth;
 	}
 
-	public function changeEmailAddress( EmailAddress $email ) {
+	public function changeEmailAddress(EmailAddress $email) {
 		$this->email = $email;
 	}
 

src/MembershipApplicationContext/DataAccess/DoctrineMembershipApplicationRepository.php

Spacing +79 added lines, -79 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\DataAccess;
 
@@ -29,102 +29,102 @@ 
 
 	private $entityManager;
 
-	public function __construct( EntityManager $entityManager ) {
+	public function __construct(EntityManager $entityManager) {
 		$this->entityManager = $entityManager;
 	}
 
-	public function storeApplication( MembershipApplication $application ) {
-		if ( $application->hasId() ) {
-			$this->updateApplication( $application );
+	public function storeApplication(MembershipApplication $application) {
+		if ($application->hasId()) {
+			$this->updateApplication($application);
 		}
 		else {
-			$this->insertApplication( $application );
+			$this->insertApplication($application);
 		}
 	}
 
-	private function insertApplication( MembershipApplication $application ) {
+	private function insertApplication(MembershipApplication $application) {
 		$doctrineApplication = new DoctrineApplication();
-		$this->updateDoctrineApplication( $doctrineApplication, $application );
+		$this->updateDoctrineApplication($doctrineApplication, $application);
 
 		try {
-			$this->entityManager->persist( $doctrineApplication );
+			$this->entityManager->persist($doctrineApplication);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreMembershipApplicationException($ex);
 		}
 
-		$application->assignId( $doctrineApplication->getId() );
+		$application->assignId($doctrineApplication->getId());
 	}
 
-	private function updateApplication( MembershipApplication $application ) {
-		$doctrineApplication = $this->getDoctrineApplicationById( $application->getId() );
+	private function updateApplication(MembershipApplication $application) {
+		$doctrineApplication = $this->getDoctrineApplicationById($application->getId());
 
-		if ( $doctrineApplication === null ) {
+		if ($doctrineApplication === null) {
 			throw new StoreMembershipApplicationException();
 		}
 
-		$this->updateDoctrineApplication( $doctrineApplication, $application );
+		$this->updateDoctrineApplication($doctrineApplication, $application);
 
 		try {
-			$this->entityManager->persist( $doctrineApplication );
+			$this->entityManager->persist($doctrineApplication);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreMembershipApplicationException($ex);
 		}
 	}
 
-	private function updateDoctrineApplication( DoctrineApplication $doctrineApplication, MembershipApplication $application ) {
-		$doctrineApplication->setId( $application->getId() );
-		$doctrineApplication->setMembershipType( $application->getType() );
+	private function updateDoctrineApplication(DoctrineApplication $doctrineApplication, MembershipApplication $application) {
+		$doctrineApplication->setId($application->getId());
+		$doctrineApplication->setMembershipType($application->getType());
 
-		$this->setApplicantFields( $doctrineApplication, $application->getApplicant() );
-		$this->setPaymentFields( $doctrineApplication, $application->getPayment() );
+		$this->setApplicantFields($doctrineApplication, $application->getApplicant());
+		$this->setPaymentFields($doctrineApplication, $application->getPayment());
 
-		$doctrineApplication->setStatus( $this->getDoctrineStatus( $application ) );
+		$doctrineApplication->setStatus($this->getDoctrineStatus($application));
 	}
 
-	private function setApplicantFields( DoctrineApplication $application, MembershipApplicant $applicant ) {
-		$application->setApplicantFirstName( $applicant->getName()->getFirstName() );
-		$application->setApplicantLastName( $applicant->getName()->getLastName() );
-		$application->setApplicantSalutation( $applicant->getName()->getSalutation() );
-		$application->setApplicantTitle( $applicant->getName()->getTitle() );
+	private function setApplicantFields(DoctrineApplication $application, MembershipApplicant $applicant) {
+		$application->setApplicantFirstName($applicant->getName()->getFirstName());
+		$application->setApplicantLastName($applicant->getName()->getLastName());
+		$application->setApplicantSalutation($applicant->getName()->getSalutation());
+		$application->setApplicantTitle($applicant->getName()->getTitle());
 
-		$application->setApplicantDateOfBirth( $applicant->getDateOfBirth() );
+		$application->setApplicantDateOfBirth($applicant->getDateOfBirth());
 
-		$application->setApplicantEmailAddress( $applicant->getEmailAddress()->getFullAddress() );
-		$application->setApplicantPhoneNumber( $applicant->getPhoneNumber()->__toString() );
+		$application->setApplicantEmailAddress($applicant->getEmailAddress()->getFullAddress());
+		$application->setApplicantPhoneNumber($applicant->getPhoneNumber()->__toString());
 
 		$address = $applicant->getPhysicalAddress();
 
-		$application->setCity( $address->getCity() );
-		$application->setCountry( $address->getCountryCode() );
-		$application->setPostcode( $address->getPostalCode() );
-		$application->setAddress( $address->getStreetAddress() );
+		$application->setCity($address->getCity());
+		$application->setCountry($address->getCountryCode());
+		$application->setPostcode($address->getPostalCode());
+		$application->setAddress($address->getStreetAddress());
 	}
 
-	private function setPaymentFields( DoctrineApplication $application, MembershipPayment $payment ) {
-		$application->setPaymentIntervalInMonths( $payment->getIntervalInMonths() );
-		$application->setPaymentAmount( (int)$payment->getAmount()->getEuroFloat() );
+	private function setPaymentFields(DoctrineApplication $application, MembershipPayment $payment) {
+		$application->setPaymentIntervalInMonths($payment->getIntervalInMonths());
+		$application->setPaymentAmount((int)$payment->getAmount()->getEuroFloat());
 
 		$bankData = $payment->getBankData();
 
-		$application->setPaymentBankAccount( $bankData->getAccount() );
-		$application->setPaymentBankCode( $bankData->getBankCode() );
-		$application->setPaymentBankName( $bankData->getBankName() );
-		$application->setPaymentBic( $bankData->getBic() );
-		$application->setPaymentIban( $bankData->getIban()->toString() );
+		$application->setPaymentBankAccount($bankData->getAccount());
+		$application->setPaymentBankCode($bankData->getBankCode());
+		$application->setPaymentBankName($bankData->getBankName());
+		$application->setPaymentBic($bankData->getBic());
+		$application->setPaymentIban($bankData->getIban()->toString());
 	}
 
-	private function getDoctrineStatus( MembershipApplication $application ): int {
+	private function getDoctrineStatus(MembershipApplication $application): int {
 		$status = DoctrineApplication::STATUS_NEUTRAL;
 
-		if ( $application->needsModeration() ) {
+		if ($application->needsModeration()) {
 			$status += DoctrineApplication::STATUS_MODERATION;
 		}
 
-		if ( $application->isCancelled() ) {
+		if ($application->isCancelled()) {
 			$status += DoctrineApplication::STATUS_CANCELED;
 		}
 
@@ -137,19 +137,19 @@ 
 	 * @return \WMDE\Fundraising\Frontend\MembershipApplicationContext\Domain\Model\MembershipApplication|null
 	 * @throws \WMDE\Fundraising\Frontend\MembershipApplicationContext\Domain\Repositories\GetMembershipApplicationException
 	 */
-	public function getApplicationById( int $id ) {
+	public function getApplicationById(int $id) {
 		try {
-			$application = $this->getDoctrineApplicationById( $id );
+			$application = $this->getDoctrineApplicationById($id);
 		}
-		catch ( ORMException $ex ) {
-			throw new GetMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new GetMembershipApplicationException($ex);
 		}
 
-		if ( $application === null ) {
+		if ($application === null) {
 			return null;
 		}
 
-		return $this->newApplicationDomainEntity( $application );
+		return $this->newApplicationDomainEntity($application);
 	}
 
 	/**
@@ -157,61 +157,61 @@ 
 	 * @return DoctrineApplication|null
 	 * @throws ORMException
 	 */
-	public function getDoctrineApplicationById( int $id ) {
-		return $this->entityManager->find( DoctrineApplication::class, $id );
+	public function getDoctrineApplicationById(int $id) {
+		return $this->entityManager->find(DoctrineApplication::class, $id);
 	}
 
-	private function newApplicationDomainEntity( DoctrineApplication $application ): MembershipApplication {
+	private function newApplicationDomainEntity(DoctrineApplication $application): MembershipApplication {
 		return new MembershipApplication(
 			$application->getId(),
 			$application->getMembershipType(),
 			new MembershipApplicant(
-				$this->newPersonName( $application ),
-				$this->newAddress( $application ),
-				new EmailAddress( $application->getApplicantEmailAddress() ),
-				new PhoneNumber( $application->getApplicantPhoneNumber() ),
+				$this->newPersonName($application),
+				$this->newAddress($application),
+				new EmailAddress($application->getApplicantEmailAddress()),
+				new PhoneNumber($application->getApplicantPhoneNumber()),
 				$application->getApplicantDateOfBirth()
 			),
 			new MembershipPayment(
 				$application->getPaymentIntervalInMonths(),
-				Euro::newFromFloat( $application->getPaymentAmount() ),
-				$this->newBankData( $application )
+				Euro::newFromFloat($application->getPaymentAmount()),
+				$this->newBankData($application)
 			),
 			$application->needsModeration(),
 			$application->isCancelled()
 		);
 	}
 
-	private function newPersonName( DoctrineApplication $application ): ApplicantName {
+	private function newPersonName(DoctrineApplication $application): ApplicantName {
 		$personName = ApplicantName::newPrivatePersonName();
 
-		$personName->setFirstName( $application->getApplicantFirstName() );
-		$personName->setLastName( $application->getApplicantLastName() );
-		$personName->setSalutation( $application->getApplicantSalutation() );
-		$personName->setTitle( $application->getApplicantTitle() );
+		$personName->setFirstName($application->getApplicantFirstName());
+		$personName->setLastName($application->getApplicantLastName());
+		$personName->setSalutation($application->getApplicantSalutation());
+		$personName->setTitle($application->getApplicantTitle());
 
 		return $personName->freeze()->assertNoNullFields();
 	}
 
-	private function newAddress( DoctrineApplication $application ): PhysicalAddress {
+	private function newAddress(DoctrineApplication $application): PhysicalAddress {
 		$address = new PhysicalAddress();
 
-		$address->setCity( $application->getCity() );
-		$address->setCountryCode( $application->getCountry() );
-		$address->setPostalCode( $application->getPostcode() );
-		$address->setStreetAddress( $application->getAddress() );
+		$address->setCity($application->getCity());
+		$address->setCountryCode($application->getCountry());
+		$address->setPostalCode($application->getPostcode());
+		$address->setStreetAddress($application->getAddress());
 
 		return $address->freeze()->assertNoNullFields();
 	}
 
-	private function newBankData( DoctrineApplication $application ): BankData {
+	private function newBankData(DoctrineApplication $application): BankData {
 		$bankData = new BankData();
 
-		$bankData->setAccount( $application->getPaymentBankAccount() );
-		$bankData->setBankCode( $application->getPaymentBankCode() );
-		$bankData->setBankName( $application->getPaymentBankName() );
-		$bankData->setBic( $application->getPaymentBic() );
-		$bankData->setIban( new Iban( $application->getPaymentIban() ) );
+		$bankData->setAccount($application->getPaymentBankAccount());
+		$bankData->setBankCode($application->getPaymentBankCode());
+		$bankData->setBankName($application->getPaymentBankName());
+		$bankData->setBic($application->getPaymentBic());
+		$bankData->setIban(new Iban($application->getPaymentIban()));
 
 		return $bankData->freeze()->assertNoNullFields();
 	}

src/MembershipApplicationContext/UseCases/ApplyForMembership/MembershipApplicationBuilder.php

Spacing +26 added lines, -26 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\UseCases\ApplyForMembership;
 
@@ -21,60 +21,60 @@ 
 
 	const COMPANY_APPLICANT_TYPE = 'firma';
 
-	public function newApplicationFromRequest( ApplyForMembershipRequest $request ): MembershipApplication {
+	public function newApplicationFromRequest(ApplyForMembershipRequest $request): MembershipApplication {
 		return MembershipApplication::newApplication(
 			$request->getMembershipType(),
-			$this->newApplicant( $request ),
-			$this->newPayment( $request )
+			$this->newApplicant($request),
+			$this->newPayment($request)
 		);
 	}
 
-	private function newApplicant( ApplyForMembershipRequest $request ): MembershipApplicant {
+	private function newApplicant(ApplyForMembershipRequest $request): MembershipApplicant {
 		return new MembershipApplicant(
-			$this->newPersonName( $request ),
-			$this->newAddress( $request ),
-			new EmailAddress( $request->getApplicantEmailAddress() ),
-			new PhoneNumber( $request->getApplicantPhoneNumber() ),
-			( $request->getApplicantDateOfBirth() === '' ) ? null : new \DateTime( $request->getApplicantDateOfBirth() )
+			$this->newPersonName($request),
+			$this->newAddress($request),
+			new EmailAddress($request->getApplicantEmailAddress()),
+			new PhoneNumber($request->getApplicantPhoneNumber()),
+			($request->getApplicantDateOfBirth() === '') ? null : new \DateTime($request->getApplicantDateOfBirth())
 		);
 	}
 
-	private function newPersonName( ApplyForMembershipRequest $request ): ApplicantName {
-		$personName = $this->newBasePersonName( $request );
+	private function newPersonName(ApplyForMembershipRequest $request): ApplicantName {
+		$personName = $this->newBasePersonName($request);
 
-		$personName->setFirstName( $request->getApplicantFirstName() );
-		$personName->setLastName( $request->getApplicantLastName() );
-		$personName->setSalutation( $request->getApplicantSalutation() );
-		$personName->setTitle( $request->getApplicantTitle() );
+		$personName->setFirstName($request->getApplicantFirstName());
+		$personName->setLastName($request->getApplicantLastName());
+		$personName->setSalutation($request->getApplicantSalutation());
+		$personName->setTitle($request->getApplicantTitle());
 
 		return $personName->freeze()->assertNoNullFields();
 	}
 
-	private function newBasePersonName( ApplyForMembershipRequest $request ): ApplicantName {
-		if ( $request->isCompanyApplication() ) {
+	private function newBasePersonName(ApplyForMembershipRequest $request): ApplicantName {
+		if ($request->isCompanyApplication()) {
 			$personName = ApplicantName::newCompanyName();
-			$personName->setCompanyName( $request->getApplicantCompanyName() );
+			$personName->setCompanyName($request->getApplicantCompanyName());
 			return $personName;
 		}
 
 		return ApplicantName::newPrivatePersonName();
 	}
 
-	private function newAddress( ApplyForMembershipRequest $request ): PhysicalAddress {
+	private function newAddress(ApplyForMembershipRequest $request): PhysicalAddress {
 		$address = new PhysicalAddress();
 
-		$address->setCity( $request->getApplicantCity() );
-		$address->setCountryCode( $request->getApplicantCountryCode() );
-		$address->setPostalCode( $request->getApplicantPostalCode() );
-		$address->setStreetAddress( $request->getApplicantStreetAddress() );
+		$address->setCity($request->getApplicantCity());
+		$address->setCountryCode($request->getApplicantCountryCode());
+		$address->setPostalCode($request->getApplicantPostalCode());
+		$address->setStreetAddress($request->getApplicantStreetAddress());
 
 		return $address->freeze()->assertNoNullFields();
 	}
 
-	private function newPayment( ApplyForMembershipRequest $request ): MembershipPayment {
+	private function newPayment(ApplyForMembershipRequest $request): MembershipPayment {
 		return new MembershipPayment(
 			$request->getPaymentIntervalInMonths(),
-			Euro::newFromString( $request->getPaymentAmountInEuros() ),
+			Euro::newFromString($request->getPaymentAmountInEuros()),
 			$request->getPaymentBankData()
 		);
 	}

src/DonatingContext/Domain/Model/Donor.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonatingContext\Domain\Model;
 
@@ -16,7 +16,7 @@ 
 	private $physicalAddress;
 	private $emailAddress;
 
-	public function __construct( DonorName $name, PhysicalAddress $address, string $emailAddress ) {
+	public function __construct(DonorName $name, PhysicalAddress $address, string $emailAddress) {
 		$this->personName = $name;
 		$this->physicalAddress = $address;
 		$this->emailAddress = $emailAddress;

src/DonatingContext/DataAccess/DoctrineDonationRepository.php

Spacing +169 added lines, -169 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonatingContext\DataAccess;
 
@@ -40,113 +40,113 @@ 
 
 	private $entityManager;
 
-	public function __construct( EntityManager $entityManager ) {
+	public function __construct(EntityManager $entityManager) {
 		$this->entityManager = $entityManager;
 	}
 
-	public function storeDonation( Donation $donation ) {
-		if ( $donation->getId() === null ) {
-			$this->insertDonation( $donation );
+	public function storeDonation(Donation $donation) {
+		if ($donation->getId() === null) {
+			$this->insertDonation($donation);
 		}
 		else {
-			$this->updateDonation( $donation );
+			$this->updateDonation($donation);
 		}
 	}
 
-	private function insertDonation( Donation $donation ) {
+	private function insertDonation(Donation $donation) {
 		$doctrineDonation = new DoctrineDonation();
-		$this->updateDonationEntity( $doctrineDonation, $donation );
+		$this->updateDonationEntity($doctrineDonation, $donation);
 
 		try {
-			$this->entityManager->persist( $doctrineDonation );
+			$this->entityManager->persist($doctrineDonation);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreDonationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreDonationException($ex);
 		}
 
-		$donation->assignId( $doctrineDonation->getId() );
+		$donation->assignId($doctrineDonation->getId());
 	}
 
-	private function updateDonation( Donation $donation ) {
-		$doctrineDonation = $this->getDoctrineDonationById( $donation->getId() );
+	private function updateDonation(Donation $donation) {
+		$doctrineDonation = $this->getDoctrineDonationById($donation->getId());
 
-		if ( $doctrineDonation === null ) {
+		if ($doctrineDonation === null) {
 			throw new StoreDonationException();
 		}
 
-		$this->updateDonationEntity( $doctrineDonation, $donation );
+		$this->updateDonationEntity($doctrineDonation, $donation);
 
 		try {
-			$this->entityManager->persist( $doctrineDonation );
+			$this->entityManager->persist($doctrineDonation);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreDonationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreDonationException($ex);
 		}
 	}
 
-	private function updateDonationEntity( DoctrineDonation $doctrineDonation, Donation $donation ) {
-		$doctrineDonation->setId( $donation->getId() );
-		$this->updatePaymentInformation( $doctrineDonation, $donation );
-		$this->updateDonorInformation( $doctrineDonation, $donation->getDonor() );
-		$this->updateComment( $doctrineDonation, $donation->getComment() );
-		$doctrineDonation->setDonorOptsIntoNewsletter( $donation->getOptsIntoNewsletter() );
+	private function updateDonationEntity(DoctrineDonation $doctrineDonation, Donation $donation) {
+		$doctrineDonation->setId($donation->getId());
+		$this->updatePaymentInformation($doctrineDonation, $donation);
+		$this->updateDonorInformation($doctrineDonation, $donation->getDonor());
+		$this->updateComment($doctrineDonation, $donation->getComment());
+		$doctrineDonation->setDonorOptsIntoNewsletter($donation->getOptsIntoNewsletter());
 
-		$doctrineDonation->encodeAndSetData( array_merge(
+		$doctrineDonation->encodeAndSetData(array_merge(
 			$doctrineDonation->getDecodedData(),
-			$this->getDataMap( $donation )
-		) );
+			$this->getDataMap($donation)
+		));
 	}
 
-	private function updatePaymentInformation( DoctrineDonation $doctrineDonation, Donation $donation ) {
-		$doctrineDonation->setStatus( $donation->getStatus() );
-		$doctrineDonation->setAmount( $donation->getAmount()->getEuroString() );
-		$doctrineDonation->setPaymentIntervalInMonths( $donation->getPaymentIntervalInMonths() );
+	private function updatePaymentInformation(DoctrineDonation $doctrineDonation, Donation $donation) {
+		$doctrineDonation->setStatus($donation->getStatus());
+		$doctrineDonation->setAmount($donation->getAmount()->getEuroString());
+		$doctrineDonation->setPaymentIntervalInMonths($donation->getPaymentIntervalInMonths());
 
-		$doctrineDonation->setPaymentType( $donation->getPaymentType() );
-		$doctrineDonation->setBankTransferCode( $this->getBankTransferCode( $donation->getPaymentMethod() ) );
+		$doctrineDonation->setPaymentType($donation->getPaymentType());
+		$doctrineDonation->setBankTransferCode($this->getBankTransferCode($donation->getPaymentMethod()));
 	}
 
-	private function updateDonorInformation( DoctrineDonation $doctrineDonation, Donor $donor = null ) {
-		if ( $donor === null ) {
-			$doctrineDonation->setDonorFullName( 'Anonym' );
+	private function updateDonorInformation(DoctrineDonation $doctrineDonation, Donor $donor = null) {
+		if ($donor === null) {
+			$doctrineDonation->setDonorFullName('Anonym');
 		} else {
-			$doctrineDonation->setDonorCity( $donor->getPhysicalAddress()->getCity() );
-			$doctrineDonation->setDonorEmail( $donor->getEmailAddress() );
-			$doctrineDonation->setDonorFullName( $donor->getPersonName()->getFullName() );
+			$doctrineDonation->setDonorCity($donor->getPhysicalAddress()->getCity());
+			$doctrineDonation->setDonorEmail($donor->getEmailAddress());
+			$doctrineDonation->setDonorFullName($donor->getPersonName()->getFullName());
 		}
 	}
 
-	private function updateComment( DoctrineDonation $doctrineDonation, DonationComment $comment = null ) {
-		if ( $comment === null ) {
-			$doctrineDonation->setIsPublic( false );
-			$doctrineDonation->setComment( '' );
-			$doctrineDonation->setPublicRecord( '' );
+	private function updateComment(DoctrineDonation $doctrineDonation, DonationComment $comment = null) {
+		if ($comment === null) {
+			$doctrineDonation->setIsPublic(false);
+			$doctrineDonation->setComment('');
+			$doctrineDonation->setPublicRecord('');
 		} else {
-			$doctrineDonation->setIsPublic( $comment->isPublic() );
-			$doctrineDonation->setComment( $comment->getCommentText() );
-			$doctrineDonation->setPublicRecord( $comment->getAuthorDisplayName() );
+			$doctrineDonation->setIsPublic($comment->isPublic());
+			$doctrineDonation->setComment($comment->getCommentText());
+			$doctrineDonation->setPublicRecord($comment->getAuthorDisplayName());
 		}
 	}
 
-	private function getBankTransferCode( PaymentMethod $paymentMethod ): string {
-		if ( $paymentMethod instanceof BankTransferPayment ) {
+	private function getBankTransferCode(PaymentMethod $paymentMethod): string {
+		if ($paymentMethod instanceof BankTransferPayment) {
 			return $paymentMethod->getBankTransferCode();
 		}
 
 		return '';
 	}
 
-	private function getDataMap( Donation $donation ): array {
+	private function getDataMap(Donation $donation): array {
 		return array_merge(
-			$this->getDataFieldsFromTrackingInfo( $donation->getTrackingInfo() ),
-			$this->getDataFieldsForPaymentData( $donation->getPaymentMethod() ),
-			$this->getDataFieldsFromDonor( $donation->getDonor() )
+			$this->getDataFieldsFromTrackingInfo($donation->getTrackingInfo()),
+			$this->getDataFieldsForPaymentData($donation->getPaymentMethod()),
+			$this->getDataFieldsFromDonor($donation->getDonor())
 		);
 	}
 
-	private function getDataFieldsFromTrackingInfo( DonationTrackingInfo $trackingInfo ): array {
+	private function getDataFieldsFromTrackingInfo(DonationTrackingInfo $trackingInfo): array {
 		return [
 			'layout' => $trackingInfo->getLayout(),
 			'impCount' => $trackingInfo->getTotalImpressionCount(),
@@ -158,23 +158,23 @@ 
 		];
 	}
 
-	private function getDataFieldsForPaymentData( PaymentMethod $paymentMethod ): array {
-		if ( $paymentMethod instanceof DirectDebitPayment ) {
-			return $this->getDataFieldsFromBankData( $paymentMethod->getBankData() );
+	private function getDataFieldsForPaymentData(PaymentMethod $paymentMethod): array {
+		if ($paymentMethod instanceof DirectDebitPayment) {
+			return $this->getDataFieldsFromBankData($paymentMethod->getBankData());
 		}
 
-		if ( $paymentMethod instanceof PayPalPayment ) {
-			return $this->getDataFieldsFromPayPalData( $paymentMethod->getPayPalData() );
+		if ($paymentMethod instanceof PayPalPayment) {
+			return $this->getDataFieldsFromPayPalData($paymentMethod->getPayPalData());
 		}
 
-		if ( $paymentMethod instanceof CreditCardPayment ) {
-			return $this->getDataFieldsFromCreditCardData( $paymentMethod->getCreditCardData() );
+		if ($paymentMethod instanceof CreditCardPayment) {
+			return $this->getDataFieldsFromCreditCardData($paymentMethod->getCreditCardData());
 		}
 
 		return [];
 	}
 
-	private function getDataFieldsFromBankData( BankData $bankData ): array {
+	private function getDataFieldsFromBankData(BankData $bankData): array {
 		return [
 			'iban' => $bankData->getIban()->toString(),
 			'bic' => $bankData->getBic(),
@@ -184,19 +184,19 @@ 
 		];
 	}
 
-	private function getDataFieldsFromDonor( Donor $personalInfo = null ): array {
-		if ( $personalInfo === null ) {
-			return [ 'adresstyp' => 'anonym' ];
+	private function getDataFieldsFromDonor(Donor $personalInfo = null): array {
+		if ($personalInfo === null) {
+			return ['adresstyp' => 'anonym'];
 		}
 
 		return array_merge(
-			$this->getDataFieldsFromPersonName( $personalInfo->getPersonName() ),
-			$this->getDataFieldsFromAddress( $personalInfo->getPhysicalAddress() ),
-			[ 'email' => $personalInfo->getEmailAddress() ]
+			$this->getDataFieldsFromPersonName($personalInfo->getPersonName()),
+			$this->getDataFieldsFromAddress($personalInfo->getPhysicalAddress()),
+			['email' => $personalInfo->getEmailAddress()]
 		);
 	}
 
-	private function getDataFieldsFromPersonName( DonorName $name ) {
+	private function getDataFieldsFromPersonName(DonorName $name) {
 		return [
 			'adresstyp' => $name->getPersonType(),
 			'anrede' => $name->getSalutation(),
@@ -207,7 +207,7 @@ 
 		];
 	}
 
-	private function getDataFieldsFromAddress( PhysicalAddress $address ) {
+	private function getDataFieldsFromAddress(PhysicalAddress $address) {
 		return [
 			'strasse' => $address->getStreetAddress(),
 			'plz' => $address->getPostalCode(),
@@ -216,7 +216,7 @@ 
 		];
 	}
 
-	private function getDataFieldsFromPayPalData( PayPalData $payPalData ) {
+	private function getDataFieldsFromPayPalData(PayPalData $payPalData) {
 		return [
 			'paypal_payer_id' => $payPalData->getPayerId(),
 			'paypal_subscr_id' => $payPalData->getSubscriberId(),
@@ -238,11 +238,11 @@ 
 		];
 	}
 
-	private function getDataFieldsFromCreditCardData( CreditCardTransactionData $ccData ) {
+	private function getDataFieldsFromCreditCardData(CreditCardTransactionData $ccData) {
 		return [
 			'ext_payment_id' => $ccData->getTransactionId(),
 			'ext_payment_status' => $ccData->getTransactionStatus(),
-			'ext_payment_timestamp' => $ccData->getTransactionTimestamp()->format( \DateTime::ATOM ),
+			'ext_payment_timestamp' => $ccData->getTransactionTimestamp()->format(\DateTime::ATOM),
 			'mcp_amount' => $ccData->getAmount()->getEuroString(),
 			'ext_payment_account' => $ccData->getCustomerId(),
 			'mcp_sessionid' => $ccData->getSessionId(),
@@ -250,16 +250,16 @@ 
 			'mcp_title' => $ccData->getTitle(),
 			'mcp_country' => $ccData->getCountryCode(),
 			'mcp_currency' => $ccData->getCurrencyCode(),
-			'mcp_cc_expiry_date' => $this->getExpirationDateAsString( $ccData->getCardExpiry() )
+			'mcp_cc_expiry_date' => $this->getExpirationDateAsString($ccData->getCardExpiry())
 		];
 	}
 
-	private function getExpirationDateAsString( CreditCardExpiry $cardExpiry = null ): string {
-		if ( $cardExpiry === null ) {
+	private function getExpirationDateAsString(CreditCardExpiry $cardExpiry = null): string {
+		if ($cardExpiry === null) {
 			return '';
 		}
 
-		return implode( '/', [ $cardExpiry->getMonth(), $cardExpiry->getYear() ] );
+		return implode('/', [$cardExpiry->getMonth(), $cardExpiry->getYear()]);
 	}
 
 	/**
@@ -268,19 +268,19 @@ 
 	 * @return \WMDE\Fundraising\Frontend\DonatingContext\Domain\Model\Donation|null
 	 * @throws GetDonationException
 	 */
-	public function getDonationById( int $id ) {
+	public function getDonationById(int $id) {
 		try {
-			$donation = $this->getDoctrineDonationById( $id );
+			$donation = $this->getDoctrineDonationById($id);
 		}
-		catch ( ORMException $ex ) {
-			throw new GetDonationException( $ex );
+		catch (ORMException $ex) {
+			throw new GetDonationException($ex);
 		}
 
-		if ( $donation === null ) {
+		if ($donation === null) {
 			return null;
 		}
 
-		return $this->newDonationDomainObject( $donation );
+		return $this->newDonationDomainObject($donation);
 	}
 
 	/**
@@ -288,22 +288,22 @@ 
 	 * @return DoctrineDonation|null
 	 * @throws ORMException
 	 */
-	public function getDoctrineDonationById( int $id ) {
-		return $this->entityManager->getRepository( DoctrineDonation::class )->findOneBy( [
+	public function getDoctrineDonationById(int $id) {
+		return $this->entityManager->getRepository(DoctrineDonation::class)->findOneBy([
 			'id' => $id,
 			'deletionTime' => null
-		] );
+		]);
 	}
 
-	private function newDonationDomainObject( DoctrineDonation $dd ): Donation {
+	private function newDonationDomainObject(DoctrineDonation $dd): Donation {
 		return new Donation(
 			$dd->getId(),
 			$dd->getStatus(),
-			$this->getDonorFromEntity( $dd ),
-			$this->getPaymentFromEntity( $dd ),
+			$this->getDonorFromEntity($dd),
+			$this->getPaymentFromEntity($dd),
 			(bool)$dd->getDonorOptsIntoNewsletter(),
-			$this->getTrackingInfoFromEntity( $dd ),
-			$this->getCommentFromEntity( $dd )
+			$this->getTrackingInfoFromEntity($dd),
+			$this->getCommentFromEntity($dd)
 		);
 	}
 
@@ -312,70 +312,70 @@ 
 	 *
 	 * @return \WMDE\Fundraising\Frontend\DonatingContext\Domain\Model\Donor|null
 	 */
-	private function getDonorFromEntity( DoctrineDonation $dd ) {
-		if ( $dd->getDonorEmail() === null ) {
+	private function getDonorFromEntity(DoctrineDonation $dd) {
+		if ($dd->getDonorEmail() === null) {
 			return null;
 		}
 
 		return new Donor(
-			$this->getPersonNameFromEntity( $dd ),
-			$this->getPhysicalAddressFromEntity( $dd ),
+			$this->getPersonNameFromEntity($dd),
+			$this->getPhysicalAddressFromEntity($dd),
 			$dd->getDonorEmail()
 		);
 	}
 
-	private function getPaymentFromEntity( DoctrineDonation $dd ): DonationPayment {
+	private function getPaymentFromEntity(DoctrineDonation $dd): DonationPayment {
 		return new DonationPayment(
-			Euro::newFromString( $dd->getAmount() ),
+			Euro::newFromString($dd->getAmount()),
 			$dd->getPaymentIntervalInMonths(),
-			$this->getPaymentMethodFromEntity( $dd )
+			$this->getPaymentMethodFromEntity($dd)
 		);
 	}
 
-	private function getPaymentMethodFromEntity( DoctrineDonation $dd ): PaymentMethod {
-		if ( $dd->getPaymentType() === PaymentType::BANK_TRANSFER ) {
-			return new BankTransferPayment( $dd->getBankTransferCode() );
+	private function getPaymentMethodFromEntity(DoctrineDonation $dd): PaymentMethod {
+		if ($dd->getPaymentType() === PaymentType::BANK_TRANSFER) {
+			return new BankTransferPayment($dd->getBankTransferCode());
 		}
 
-		if ( $dd->getPaymentType() === PaymentType::DIRECT_DEBIT ) {
-			return new DirectDebitPayment( $this->getBankDataFromEntity( $dd ) );
+		if ($dd->getPaymentType() === PaymentType::DIRECT_DEBIT) {
+			return new DirectDebitPayment($this->getBankDataFromEntity($dd));
 		}
 
-		if ( $dd->getPaymentType() === PaymentType::PAYPAL ) {
-			return new PayPalPayment( $this->getPayPalDataFromEntity( $dd ) );
+		if ($dd->getPaymentType() === PaymentType::PAYPAL) {
+			return new PayPalPayment($this->getPayPalDataFromEntity($dd));
 		}
 
-		if ( $dd->getPaymentType() === PaymentType::CREDIT_CARD ) {
-			return new CreditCardPayment( $this->getCreditCardDataFromEntity( $dd ) );
+		if ($dd->getPaymentType() === PaymentType::CREDIT_CARD) {
+			return new CreditCardPayment($this->getCreditCardDataFromEntity($dd));
 		}
 
-		return new PaymentWithoutAssociatedData( $dd->getPaymentType() );
+		return new PaymentWithoutAssociatedData($dd->getPaymentType());
 	}
 
-	private function getPersonNameFromEntity( DoctrineDonation $dd ): DonorName {
+	private function getPersonNameFromEntity(DoctrineDonation $dd): DonorName {
 		$data = $dd->getDecodedData();
 
 		$name = $data['adresstyp'] === DonorName::PERSON_COMPANY
 			? DonorName::newCompanyName() : DonorName::newPrivatePersonName();
 
-		$name->setSalutation( $data['anrede'] );
-		$name->setTitle( $data['titel'] );
-		$name->setFirstName( $data['vorname'] );
-		$name->setLastName( $data['nachname'] );
-		$name->setCompanyName( $data['firma'] );
+		$name->setSalutation($data['anrede']);
+		$name->setTitle($data['titel']);
+		$name->setFirstName($data['vorname']);
+		$name->setLastName($data['nachname']);
+		$name->setCompanyName($data['firma']);
 
 		return $name->freeze()->assertNoNullFields();
 	}
 
-	private function getPhysicalAddressFromEntity( DoctrineDonation $dd ): PhysicalAddress {
+	private function getPhysicalAddressFromEntity(DoctrineDonation $dd): PhysicalAddress {
 		$data = $dd->getDecodedData();
 
 		$address = new PhysicalAddress();
 
-		$address->setStreetAddress( $data['strasse'] );
-		$address->setCity( $data['ort'] );
-		$address->setPostalCode( $data['plz'] );
-		$address->setCountryCode( $data['country'] );
+		$address->setStreetAddress($data['strasse']);
+		$address->setCity($data['ort']);
+		$address->setPostalCode($data['plz']);
+		$address->setCountryCode($data['country']);
 
 		return $address->freeze()->assertNoNullFields();
 	}
@@ -385,17 +385,17 @@ 
 	 *
 *@return \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\BankData|null
 	 */
-	private function getBankDataFromEntity( DoctrineDonation $dd ) {
+	private function getBankDataFromEntity(DoctrineDonation $dd) {
 		$data = $dd->getDecodedData();
 
-		if ( array_key_exists( 'iban', $data ) ) {
+		if (array_key_exists('iban', $data)) {
 			$bankData = new BankData();
 
-			$bankData->setIban( new Iban( $data['iban'] ) );
-			$bankData->setBic( $data['bic'] );
-			$bankData->setAccount( $data['konto'] );
-			$bankData->setBankCode( $data['blz'] );
-			$bankData->setBankName( $data['bankname'] );
+			$bankData->setIban(new Iban($data['iban']));
+			$bankData->setBic($data['bic']);
+			$bankData->setAccount($data['konto']);
+			$bankData->setBankCode($data['blz']);
+			$bankData->setBankName($data['bankname']);
 
 			return $bankData->freeze()->assertNoNullFields();
 		}
@@ -403,18 +403,18 @@ 
 		return null;
 	}
 
-	private function getTrackingInfoFromEntity( DoctrineDonation $dd ): DonationTrackingInfo {
+	private function getTrackingInfoFromEntity(DoctrineDonation $dd): DonationTrackingInfo {
 		$data = $dd->getDecodedData();
 
 		$trackingInfo = new DonationTrackingInfo();
 
-		$trackingInfo->setLayout( $data['layout'] );
-		$trackingInfo->setTotalImpressionCount( $data['impCount'] );
-		$trackingInfo->setSingleBannerImpressionCount( $data['bImpCount'] );
-		$trackingInfo->setTracking( $data['tracking'] );
-		$trackingInfo->setSkin( $data['skin'] );
-		$trackingInfo->setColor( $data['color'] );
-		$trackingInfo->setSource( $data['source'] );
+		$trackingInfo->setLayout($data['layout']);
+		$trackingInfo->setTotalImpressionCount($data['impCount']);
+		$trackingInfo->setSingleBannerImpressionCount($data['bImpCount']);
+		$trackingInfo->setTracking($data['tracking']);
+		$trackingInfo->setSkin($data['skin']);
+		$trackingInfo->setColor($data['color']);
+		$trackingInfo->setSource($data['source']);
 
 		return $trackingInfo->freeze()->assertNoNullFields();
 	}
@@ -423,26 +423,26 @@ 
 	 * @param DoctrineDonation $dd
 	 * @return PayPalData|null
 	 */
-	private function getPayPalDataFromEntity( DoctrineDonation $dd ) {
+	private function getPayPalDataFromEntity(DoctrineDonation $dd) {
 		$data = $dd->getDecodedData();
 
-		if ( array_key_exists( 'paypal_payer_id', $data ) ) {
-			return ( new PayPalData() )
-				->setPayerId( $data['paypal_payer_id'] )
-				->setSubscriberId( $data['paypal_subscr_id'] )
-				->setPayerStatus( $data['paypal_payer_status'] )
-				->setAddressStatus( $data['paypal_address_status'] )
-				->setAmount( Euro::newFromString( $data['paypal_mc_gross'] ) )
-				->setCurrencyCode( $data['paypal_mc_currency'] )
-				->setFee( Euro::newFromString( $data['paypal_mc_fee'] ) )
-				->setSettleAmount( Euro::newFromString( $data['paypal_settle_amount'] ) )
-				->setFirstName( $data['paypal_first_name'] )
-				->setLastName( $data['paypal_last_name'] )
-				->setAddressName( $data['paypal_address_name'] )
-				->setPaymentId( $data['ext_payment_id'] )
-				->setPaymentType( $data['ext_payment_type'] )
-				->setPaymentStatus( $data['ext_payment_status'] )
-				->setPaymentTimestamp( $data['ext_payment_timestamp'] )
+		if (array_key_exists('paypal_payer_id', $data)) {
+			return (new PayPalData())
+				->setPayerId($data['paypal_payer_id'])
+				->setSubscriberId($data['paypal_subscr_id'])
+				->setPayerStatus($data['paypal_payer_status'])
+				->setAddressStatus($data['paypal_address_status'])
+				->setAmount(Euro::newFromString($data['paypal_mc_gross']))
+				->setCurrencyCode($data['paypal_mc_currency'])
+				->setFee(Euro::newFromString($data['paypal_mc_fee']))
+				->setSettleAmount(Euro::newFromString($data['paypal_settle_amount']))
+				->setFirstName($data['paypal_first_name'])
+				->setLastName($data['paypal_last_name'])
+				->setAddressName($data['paypal_address_name'])
+				->setPaymentId($data['ext_payment_id'])
+				->setPaymentType($data['ext_payment_type'])
+				->setPaymentStatus($data['ext_payment_status'])
+				->setPaymentTimestamp($data['ext_payment_timestamp'])
 				->freeze()->assertNoNullFields();
 		}
 
@@ -453,22 +453,22 @@ 
 	 * @param DoctrineDonation $dd
 	 * @return CreditCardTransactionData|null
 	 */
-	private function getCreditCardDataFromEntity( DoctrineDonation $dd ) {
+	private function getCreditCardDataFromEntity(DoctrineDonation $dd) {
 		$data = $dd->getDecodedData();
 
-		if ( array_key_exists( 'mcp_auth', $data ) ) {
-			return ( new CreditCardTransactionData() )
-				->setTransactionId( $data['ext_payment_id'] )
-				->setTransactionStatus( $data['ext_payment_status'] )
-				->setTransactionTimestamp( new \DateTime( $data['ext_payment_timestamp'] ) )
-				->setAmount( Euro::newFromString( $data['mcp_amount'] ) )
-				->setCustomerId( $data['ext_payment_account'] )
-				->setSessionId( $data['mcp_sessionid'] )
-				->setAuthId( $data['mcp_auth'] )
-				->setCardExpiry( CreditCardExpiry::newFromString( $data['mcp_cc_expiry_date'] ) )
-				->setTitle( $data['mcp_title'] )
-				->setCountryCode( $data['mcp_country'] )
-				->setCurrencyCode( $data['mcp_currency'] )
+		if (array_key_exists('mcp_auth', $data)) {
+			return (new CreditCardTransactionData())
+				->setTransactionId($data['ext_payment_id'])
+				->setTransactionStatus($data['ext_payment_status'])
+				->setTransactionTimestamp(new \DateTime($data['ext_payment_timestamp']))
+				->setAmount(Euro::newFromString($data['mcp_amount']))
+				->setCustomerId($data['ext_payment_account'])
+				->setSessionId($data['mcp_sessionid'])
+				->setAuthId($data['mcp_auth'])
+				->setCardExpiry(CreditCardExpiry::newFromString($data['mcp_cc_expiry_date']))
+				->setTitle($data['mcp_title'])
+				->setCountryCode($data['mcp_country'])
+				->setCurrencyCode($data['mcp_currency'])
 				->freeze();
 		}
 
@@ -479,8 +479,8 @@ 
 	 * @param DoctrineDonation $dd
 	 * @return DonationComment|null
 	 */
-	private function getCommentFromEntity( DoctrineDonation $dd ) {
-		if ( $dd->getComment() === '' ) {
+	private function getCommentFromEntity(DoctrineDonation $dd) {
+		if ($dd->getComment() === '') {
 			return null;
 		}
 

src/DonatingContext/UseCases/HandlePayPalPaymentNotification/HandlePayPalPaymentNotificationUseCase.php

Spacing +90 added lines, -90 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonatingContext\UseCases\HandlePayPalPaymentNotification;
 
@@ -33,9 +33,9 @@ 
 	private $logger;
 	private $donationEventLogger;
 
-	public function __construct( DonationRepository $repository, DonationAuthorizer $authorizationService,
+	public function __construct(DonationRepository $repository, DonationAuthorizer $authorizationService,
 								 DonationConfirmationMailer $mailer, LoggerInterface $logger,
-								 DonationEventLogger $donationEventLogger ) {
+								 DonationEventLogger $donationEventLogger) {
 		$this->repository = $repository;
 		$this->authorizationService = $authorizationService;
 		$this->mailer = $mailer;
@@ -43,189 +43,189 @@ 
 		$this->donationEventLogger = $donationEventLogger;
 	}
 
-	public function handleNotification( PayPalNotificationRequest $request ): bool {
-		if ( !$this->requestCanBeHandled( $request ) ) {
+	public function handleNotification(PayPalNotificationRequest $request): bool {
+		if (!$this->requestCanBeHandled($request)) {
 			return false;
 		}
 
 		try {
-			$donation = $this->repository->getDonationById( $request->getDonationId() );
-		} catch ( GetDonationException $ex ) {
+			$donation = $this->repository->getDonationById($request->getDonationId());
+		} catch (GetDonationException $ex) {
 			return false;
 		}
 
-		if ( $donation === null ) {
-			return $this->handleRequestWithoutDonation( $request );
+		if ($donation === null) {
+			return $this->handleRequestWithoutDonation($request);
 		}
 
-		if ( $donation->isBooked() && $request->isRecurringPaymentCompletion() ) {
-			return $this->handleRequestWithoutDonation( $request );
+		if ($donation->isBooked() && $request->isRecurringPaymentCompletion()) {
+			return $this->handleRequestWithoutDonation($request);
 		}
 
-		return $this->handleRequestForDonation( $request, $donation );
+		return $this->handleRequestForDonation($request, $donation);
 	}
 
-	private function requestCanBeHandled( PayPalNotificationRequest $request ): bool {
-		if ( !$request->isSuccessfulPaymentNotification() ) {
-			$this->logUnhandledStatus( $request );
+	private function requestCanBeHandled(PayPalNotificationRequest $request): bool {
+		if (!$request->isSuccessfulPaymentNotification()) {
+			$this->logUnhandledStatus($request);
 			return false;
 		}
 
-		if ( $this->transactionIsSubscriptionRelatedButNotAPayment( $request ) ) {
-			$this->logUnhandledNonPayment( $request );
+		if ($this->transactionIsSubscriptionRelatedButNotAPayment($request)) {
+			$this->logUnhandledNonPayment($request);
 			return false;
 		}
 		return true;
 	}
 
-	private function handleRequestWithoutDonation( PayPalNotificationRequest $request ): bool {
-		$donation = $this->newDonationFromRequest( $request );
+	private function handleRequestWithoutDonation(PayPalNotificationRequest $request): bool {
+		$donation = $this->newDonationFromRequest($request);
 
 		try {
-			$this->repository->storeDonation( $donation );
-		} catch ( StoreDonationException $ex ) {
+			$this->repository->storeDonation($donation);
+		} catch (StoreDonationException $ex) {
 			return false;
 		}
 
-		$this->sendConfirmationEmailFor( $donation );
-		$this->donationEventLogger->log( $donation->getId(), 'paypal_handler: booked' );
+		$this->sendConfirmationEmailFor($donation);
+		$this->donationEventLogger->log($donation->getId(), 'paypal_handler: booked');
 
 		return true;
 	}
 
-	private function handleRequestForDonation( PayPalNotificationRequest $request, Donation $donation ): bool {
-		if ( !( $donation->getPayment()->getPaymentMethod() instanceof PayPalPayment ) ) {
+	private function handleRequestForDonation(PayPalNotificationRequest $request, Donation $donation): bool {
+		if (!($donation->getPayment()->getPaymentMethod() instanceof PayPalPayment)) {
 			return false;
 		}
 
-		if ( !$this->authorizationService->systemCanModifyDonation( $request->getDonationId() ) ) {
+		if (!$this->authorizationService->systemCanModifyDonation($request->getDonationId())) {
 			return false;
 		}
-		if ( $this->donationWasBookedWithDifferentTransactionId( $donation, $request ) ) {
-			$childDonation = $this->createChildDonation( $donation, $request );
+		if ($this->donationWasBookedWithDifferentTransactionId($donation, $request)) {
+			$childDonation = $this->createChildDonation($donation, $request);
 			return $childDonation !== null;
 		}
 
-		$donation->addPayPalData( $this->newPayPalDataFromRequest( $request ) );
+		$donation->addPayPalData($this->newPayPalDataFromRequest($request));
 
 		try {
 			$donation->confirmBooked();
-		} catch ( \RuntimeException $ex ) {
+		} catch (\RuntimeException $ex) {
 			return false;
 		}
 
 		try {
-			$this->repository->storeDonation( $donation );
+			$this->repository->storeDonation($donation);
 		}
-		catch ( StoreDonationException $ex ) {
+		catch (StoreDonationException $ex) {
 			return false;
 		}
 
-		$this->sendConfirmationEmailFor( $donation );
-		$this->donationEventLogger->log( $donation->getId(), 'paypal_handler: booked' );
+		$this->sendConfirmationEmailFor($donation);
+		$this->donationEventLogger->log($donation->getId(), 'paypal_handler: booked');
 
 		return true;
 	}
 
-	private function logUnhandledStatus( PayPalNotificationRequest $request ) {
+	private function logUnhandledStatus(PayPalNotificationRequest $request) {
 		$logContext = [
 			'payment_status' => $request->getPaymentStatus(),
 			'txn_id' => $request->getTransactionId()
 		];
-		$this->logger->info( 'Unhandled PayPal notification: ' . $request->getPaymentStatus(), $logContext );
+		$this->logger->info('Unhandled PayPal notification: ' . $request->getPaymentStatus(), $logContext);
 	}
 
-	private function logUnhandledNonPayment( PayPalNotificationRequest $request ) {
+	private function logUnhandledNonPayment(PayPalNotificationRequest $request) {
 		$logContext = [
 			'transaction_type' => $request->getTransactionType(),
 			'txn_id' => $request->getTransactionId()
 		];
-		$this->logger->info( 'Unhandled PayPal subscription notification: ' . $request->getTransactionType(), $logContext );
+		$this->logger->info('Unhandled PayPal subscription notification: ' . $request->getTransactionType(), $logContext);
 	}
 
-	private function sendConfirmationEmailFor( Donation $donation ) {
-		if ( $donation->getDonor() !== null ) {
+	private function sendConfirmationEmailFor(Donation $donation) {
+		if ($donation->getDonor() !== null) {
 			try {
-				$this->mailer->sendConfirmationMailFor( $donation );
-			} catch ( \RuntimeException $ex ) {
+				$this->mailer->sendConfirmationMailFor($donation);
+			} catch (\RuntimeException $ex) {
 				// no need to re-throw or return false, this is not a fatal error, only a minor inconvenience
 			}
 		}
 	}
 
-	private function transactionIsSubscriptionRelatedButNotAPayment( PayPalNotificationRequest $request ): bool {
+	private function transactionIsSubscriptionRelatedButNotAPayment(PayPalNotificationRequest $request): bool {
 		return $request->isForRecurringPayment() && !$request->isRecurringPaymentCompletion();
 	}
 
-	private function newPayPalDataFromRequest( PayPalNotificationRequest $request ): PayPalData {
-		return ( new PayPalData() )
-			->setPayerId( $request->getPayerId() )
-			->setSubscriberId( $request->getSubscriberId() )
-			->setPayerStatus( $request->getPayerStatus() )
-			->setAddressStatus( $request->getPayerAddressStatus() )
-			->setAmount( $request->getAmountGross() )
-			->setCurrencyCode( $request->getCurrencyCode() )
-			->setFee( $request->getTransactionFee() )
-			->setSettleAmount( $request->getSettleAmount() )
-			->setFirstName( $request->getPayerFirstName() )
-			->setLastName( $request->getPayerLastName() )
-			->setAddressName( $request->getPayerAddressName() )
-			->setPaymentId( $request->getTransactionId() )
-			->setPaymentType( $request->getPaymentType() )
-			->setPaymentStatus( implode( '/', [ $request->getPaymentStatus(), $request->getTransactionType() ] ) )
-			->setPaymentTimestamp( $request->getPaymentTimestamp() );
+	private function newPayPalDataFromRequest(PayPalNotificationRequest $request): PayPalData {
+		return (new PayPalData())
+			->setPayerId($request->getPayerId())
+			->setSubscriberId($request->getSubscriberId())
+			->setPayerStatus($request->getPayerStatus())
+			->setAddressStatus($request->getPayerAddressStatus())
+			->setAmount($request->getAmountGross())
+			->setCurrencyCode($request->getCurrencyCode())
+			->setFee($request->getTransactionFee())
+			->setSettleAmount($request->getSettleAmount())
+			->setFirstName($request->getPayerFirstName())
+			->setLastName($request->getPayerLastName())
+			->setAddressName($request->getPayerAddressName())
+			->setPaymentId($request->getTransactionId())
+			->setPaymentType($request->getPaymentType())
+			->setPaymentStatus(implode('/', [$request->getPaymentStatus(), $request->getTransactionType()]))
+			->setPaymentTimestamp($request->getPaymentTimestamp());
 	}
 
-	private function donationWasBookedWithDifferentTransactionId( Donation $donation,
-																  PayPalNotificationRequest $request ): bool {
+	private function donationWasBookedWithDifferentTransactionId(Donation $donation,
+																  PayPalNotificationRequest $request): bool {
 		/**
 		 * @var PayPalPayment $payment
 		 */
 		$payment = $donation->getPaymentMethod();
 
-		if ( !$donation->isBooked() ) {
+		if (!$donation->isBooked()) {
 			return false;
 		}
 
-		if ( $request->getTransactionId() === $payment->getPayPalData()->getPaymentId() ) {
+		if ($request->getTransactionId() === $payment->getPayPalData()->getPaymentId()) {
 			return false;
 		}
 
-		if ( $payment->getPayPalData()->hasChildPayment( $request->getTransactionId() ) ) {
+		if ($payment->getPayPalData()->hasChildPayment($request->getTransactionId())) {
 			return false;
 		}
 
 		return true;
 	}
 
-	private function createChildDonation( Donation $donation, PayPalNotificationRequest $request ) {
-		$childPaymentMethod = new PayPalPayment( $this->newPayPalDataFromRequest( $request ) );
+	private function createChildDonation(Donation $donation, PayPalNotificationRequest $request) {
+		$childPaymentMethod = new PayPalPayment($this->newPayPalDataFromRequest($request));
 		$payment = $donation->getPayment();
 		$childDonation = new Donation(
 			null,
 			Donation::STATUS_EXTERNAL_BOOKED,
 			$donation->getDonor(),
-			new DonationPayment( $payment->getAmount(), $payment->getIntervalInMonths(), $childPaymentMethod ),
+			new DonationPayment($payment->getAmount(), $payment->getIntervalInMonths(), $childPaymentMethod),
 			$donation->getOptsIntoNewsletter(), $donation->getTrackingInfo()
 		);
 		try {
-			$this->repository->storeDonation( $childDonation );
-		} catch ( StoreDonationException $ex ) {
+			$this->repository->storeDonation($childDonation);
+		} catch (StoreDonationException $ex) {
 			return null;
 		}
 		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $paymentMethod */
 		$paymentMethod = $payment->getPaymentMethod();
-		$paymentMethod->getPayPalData()->addChildPayment( $request->getTransactionId(), $childDonation->getId() );
+		$paymentMethod->getPayPalData()->addChildPayment($request->getTransactionId(), $childDonation->getId());
 		try {
-			$this->repository->storeDonation( $donation );
-		} catch ( StoreDonationException $ex ) {
+			$this->repository->storeDonation($donation);
+		} catch (StoreDonationException $ex) {
 			return null;
 		}
-		$this->logChildDonationCreatedEvent( $donation->getId(), $childDonation->getId() );
+		$this->logChildDonationCreatedEvent($donation->getId(), $childDonation->getId());
 		return $childDonation;
 	}
 
-	private function logChildDonationCreatedEvent( $parentId, $childId ) {
+	private function logChildDonationCreatedEvent($parentId, $childId) {
 		$this->donationEventLogger->log(
 			$parentId,
 			"paypal_handler: new transaction id to corresponding child donation: $childId"
@@ -236,43 +236,43 @@ 
 		);
 	}
 
-	private function newDonorFromRequest( PayPalNotificationRequest $request ): Donor {
+	private function newDonorFromRequest(PayPalNotificationRequest $request): Donor {
 		return new Donor(
-			$this->newPersonNameFromRequest( $request ),
-			$this->newPhysicalAddressFromRequest( $request ),
+			$this->newPersonNameFromRequest($request),
+			$this->newPhysicalAddressFromRequest($request),
 			$request->getPayerEmail()
 		);
 	}
 
-	private function newPersonNameFromRequest( PayPalNotificationRequest $request ): DonorName {
+	private function newPersonNameFromRequest(PayPalNotificationRequest $request): DonorName {
 		$name = DonorName::newPrivatePersonName();
-		$name->setFirstName( $request->getPayerFirstName() );
-		$name->setLastName( $request->getPayerLastName() );
+		$name->setFirstName($request->getPayerFirstName());
+		$name->setLastName($request->getPayerLastName());
 		$name->freeze();
 		return $name;
 	}
 
-	private function newPhysicalAddressFromRequest( PayPalNotificationRequest $request ): PhysicalAddress {
+	private function newPhysicalAddressFromRequest(PayPalNotificationRequest $request): PhysicalAddress {
 		$address = new PhysicalAddress();
-		$address->setStreetAddress( $request->getPayerAddressStreet() );
-		$address->setCity( $request->getPayerAddressCity() );
-		$address->setPostalCode( $request->getPayerAddressPostalCode() );
-		$address->setCountryCode( $request->getPayerAddressCountryCode() );
+		$address->setStreetAddress($request->getPayerAddressStreet());
+		$address->setCity($request->getPayerAddressCity());
+		$address->setPostalCode($request->getPayerAddressPostalCode());
+		$address->setCountryCode($request->getPayerAddressCountryCode());
 		$address->freeze();
 		return $address;
 	}
 
-	private function newDonationFromRequest( PayPalNotificationRequest $request ): Donation {
-		$payment = new DonationPayment( $request->getAmountGross(), 0, new PayPalPayment() );
+	private function newDonationFromRequest(PayPalNotificationRequest $request): Donation {
+		$payment = new DonationPayment($request->getAmountGross(), 0, new PayPalPayment());
 		$donation = new Donation(
 			null,
 			Donation::STATUS_EXTERNAL_BOOKED,
-			$this->newDonorFromRequest( $request ),
+			$this->newDonorFromRequest($request),
 			$payment,
 			Donation::DOES_NOT_OPT_INTO_NEWSLETTER,
 			new DonationTrackingInfo()
 		);
-		$donation->addPayPalData( $this->newPayPalDataFromRequest( $request ) );
+		$donation->addPayPalData($this->newPayPalDataFromRequest($request));
 		return $donation;
 	}
 }

src/DonatingContext/UseCases/AddDonation/AddDonationUseCase.php

Spacing +56 added lines, -56 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonatingContext\UseCases\AddDonation;
 
@@ -37,10 +37,10 @@ 
 	private $transferCodeGenerator;
 	private $tokenFetcher;
 
-	public function __construct( DonationRepository $donationRepository, AddDonationValidator $donationValidator,
+	public function __construct(DonationRepository $donationRepository, AddDonationValidator $donationValidator,
 								 AddDonationPolicyValidator $policyValidator, ReferrerGeneralizer $referrerGeneralizer,
 								 DonationConfirmationMailer $mailer, TransferCodeGenerator $transferCodeGenerator,
-								 DonationTokenFetcher $tokenFetcher ) {
+								 DonationTokenFetcher $tokenFetcher) {
 		$this->donationRepository = $donationRepository;
 		$this->donationValidator = $donationValidator;
 		$this->policyValidator = $policyValidator;
@@ -51,26 +51,26 @@ 
 		$this->tokenFetcher = $tokenFetcher;
 	}
 
-	public function addDonation( AddDonationRequest $donationRequest ): AddDonationResponse {
-		$validationResult = $this->donationValidator->validate( $donationRequest );
+	public function addDonation(AddDonationRequest $donationRequest): AddDonationResponse {
+		$validationResult = $this->donationValidator->validate($donationRequest);
 
-		if ( $validationResult->hasViolations() ) {
-			return AddDonationResponse::newFailureResponse( $validationResult->getViolations() );
+		if ($validationResult->hasViolations()) {
+			return AddDonationResponse::newFailureResponse($validationResult->getViolations());
 		}
 
-		$donation = $this->newDonationFromRequest( $donationRequest );
+		$donation = $this->newDonationFromRequest($donationRequest);
 
-		if ( $this->policyValidator->needsModeration( $donationRequest ) ) {
+		if ($this->policyValidator->needsModeration($donationRequest)) {
 			$donation->markForModeration();
 		}
 
 		// TODO: handle exceptions
-		$this->donationRepository->storeDonation( $donation );
+		$this->donationRepository->storeDonation($donation);
 
 		// TODO: handle exceptions
-		$tokens = $this->tokenFetcher->getTokens( $donation->getId() );
+		$tokens = $this->tokenFetcher->getTokens($donation->getId());
 
-		$this->sendDonationConfirmationEmail( $donation );
+		$this->sendDonationConfirmationEmail($donation);
 
 		return AddDonationResponse::newSuccessResponse(
 			$donation,
@@ -79,97 +79,97 @@ 
 		);
 	}
 
-	private function newDonationFromRequest( AddDonationRequest $donationRequest ): Donation {
+	private function newDonationFromRequest(AddDonationRequest $donationRequest): Donation {
 		return new Donation(
 			null,
-			$this->getInitialDonationStatus( $donationRequest->getPaymentType() ),
-			$this->getPersonalInfoFromRequest( $donationRequest ),
-			$this->getPaymentFromRequest( $donationRequest ),
+			$this->getInitialDonationStatus($donationRequest->getPaymentType()),
+			$this->getPersonalInfoFromRequest($donationRequest),
+			$this->getPaymentFromRequest($donationRequest),
 			$donationRequest->getOptIn() === '1',
-			$this->newTrackingInfoFromRequest( $donationRequest )
+			$this->newTrackingInfoFromRequest($donationRequest)
 		);
 	}
 
-	private function getPersonalInfoFromRequest( AddDonationRequest $request ) {
-		if ( $request->donorIsAnonymous() ) {
+	private function getPersonalInfoFromRequest(AddDonationRequest $request) {
+		if ($request->donorIsAnonymous()) {
 			return null;
 		}
 		return new Donor(
-			$this->getNameFromRequest( $request ),
-			$this->getPhysicalAddressFromRequest( $request ),
+			$this->getNameFromRequest($request),
+			$this->getPhysicalAddressFromRequest($request),
 			$request->getDonorEmailAddress()
 		);
 	}
 
-	private function getPhysicalAddressFromRequest( AddDonationRequest $request ): PhysicalAddress {
+	private function getPhysicalAddressFromRequest(AddDonationRequest $request): PhysicalAddress {
 		$address = new PhysicalAddress();
 
-		$address->setStreetAddress( $request->getDonorStreetAddress() );
-		$address->setPostalCode( $request->getDonorPostalCode() );
-		$address->setCity( $request->getDonorCity() );
-		$address->setCountryCode( $request->getDonorCountryCode() );
+		$address->setStreetAddress($request->getDonorStreetAddress());
+		$address->setPostalCode($request->getDonorPostalCode());
+		$address->setCity($request->getDonorCity());
+		$address->setCountryCode($request->getDonorCountryCode());
 
 		return $address->freeze()->assertNoNullFields();
 	}
 
-	private function getNameFromRequest( AddDonationRequest $request ): DonorName {
+	private function getNameFromRequest(AddDonationRequest $request): DonorName {
 		$name = $request->donorIsCompany() ? DonorName::newCompanyName() : DonorName::newPrivatePersonName();
 
-		$name->setSalutation( $request->getDonorSalutation() );
-		$name->setTitle( $request->getDonorTitle() );
-		$name->setCompanyName( $request->getDonorCompany() );
-		$name->setFirstName( $request->getDonorFirstName() );
-		$name->setLastName( $request->getDonorLastName() );
+		$name->setSalutation($request->getDonorSalutation());
+		$name->setTitle($request->getDonorTitle());
+		$name->setCompanyName($request->getDonorCompany());
+		$name->setFirstName($request->getDonorFirstName());
+		$name->setLastName($request->getDonorLastName());
 
 		return $name->freeze()->assertNoNullFields();
 	}
 
-	private function getInitialDonationStatus( string $paymentType ): string {
-		if ( $paymentType === PaymentType::DIRECT_DEBIT ) {
+	private function getInitialDonationStatus(string $paymentType): string {
+		if ($paymentType === PaymentType::DIRECT_DEBIT) {
 			return Donation::STATUS_NEW;
 		}
 
-		if ( $paymentType === PaymentType::BANK_TRANSFER ) {
+		if ($paymentType === PaymentType::BANK_TRANSFER) {
 			return Donation::STATUS_PROMISE;
 		}
 
 		return Donation::STATUS_EXTERNAL_INCOMPLETE;
 	}
 
-	private function getPaymentFromRequest( AddDonationRequest $donationRequest ): DonationPayment {
+	private function getPaymentFromRequest(AddDonationRequest $donationRequest): DonationPayment {
 		return new DonationPayment(
 			$donationRequest->getAmount(),
 			$donationRequest->getInterval(),
-			$this->getPaymentMethodFromRequest( $donationRequest )
+			$this->getPaymentMethodFromRequest($donationRequest)
 		);
 	}
 
-	private function getPaymentMethodFromRequest( AddDonationRequest $donationRequest ): PaymentMethod {
-		if ( $donationRequest->getPaymentType() === PaymentType::BANK_TRANSFER ) {
-			return new BankTransferPayment( $this->transferCodeGenerator->generateTransferCode() );
+	private function getPaymentMethodFromRequest(AddDonationRequest $donationRequest): PaymentMethod {
+		if ($donationRequest->getPaymentType() === PaymentType::BANK_TRANSFER) {
+			return new BankTransferPayment($this->transferCodeGenerator->generateTransferCode());
 		}
 
-		if ( $donationRequest->getPaymentType() === PaymentType::DIRECT_DEBIT ) {
-			return new DirectDebitPayment( $donationRequest->getBankData() );
+		if ($donationRequest->getPaymentType() === PaymentType::DIRECT_DEBIT) {
+			return new DirectDebitPayment($donationRequest->getBankData());
 		}
 
-		if ( $donationRequest->getPaymentType() === PaymentType::PAYPAL ) {
-			return new PayPalPayment( new PayPalData() );
+		if ($donationRequest->getPaymentType() === PaymentType::PAYPAL) {
+			return new PayPalPayment(new PayPalData());
 		}
 
-		return new PaymentWithoutAssociatedData( $donationRequest->getPaymentType() );
+		return new PaymentWithoutAssociatedData($donationRequest->getPaymentType());
 	}
 
-	private function newTrackingInfoFromRequest( AddDonationRequest $request ): DonationTrackingInfo {
+	private function newTrackingInfoFromRequest(AddDonationRequest $request): DonationTrackingInfo {
 		$trackingInfo = new DonationTrackingInfo();
 
-		$trackingInfo->setTracking( $request->getTracking() );
-		$trackingInfo->setSource( $this->referrerGeneralizer->generalize( $request->getSource() ) );
-		$trackingInfo->setTotalImpressionCount( $request->getTotalImpressionCount() );
-		$trackingInfo->setSingleBannerImpressionCount( $request->getSingleBannerImpressionCount() );
-		$trackingInfo->setColor( $request->getColor() );
-		$trackingInfo->setSkin( $request->getSkin() );
-		$trackingInfo->setLayout( $request->getLayout() );
+		$trackingInfo->setTracking($request->getTracking());
+		$trackingInfo->setSource($this->referrerGeneralizer->generalize($request->getSource()));
+		$trackingInfo->setTotalImpressionCount($request->getTotalImpressionCount());
+		$trackingInfo->setSingleBannerImpressionCount($request->getSingleBannerImpressionCount());
+		$trackingInfo->setColor($request->getColor());
+		$trackingInfo->setSkin($request->getSkin());
+		$trackingInfo->setLayout($request->getLayout());
 
 		return $trackingInfo->freeze()->assertNoNullFields();
 	}
@@ -180,9 +180,9 @@ 
 	 * @throws \RuntimeException
 	 * TODO: handle exception
 	 */
-	private function sendDonationConfirmationEmail( Donation $donation ) {
-		if ( $donation->getDonor() !== null && !$donation->hasExternalPayment() ) {
-			$this->mailer->sendConfirmationMailFor( $donation );
+	private function sendDonationConfirmationEmail(Donation $donation) {
+		if ($donation->getDonor() !== null && !$donation->hasExternalPayment()) {
+			$this->mailer->sendConfirmationMailFor($donation);
 		}
 	}
 }
\ No newline at end of file

src/MembershipApplicationContext/Domain/Model/ApplicantName.php

Spacing +10 added lines, -10 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\Domain\Model;
 
@@ -31,7 +31,7 @@ 
 		return new self();
 	}
 
-	public function setCompanyName( string $companyName ) {
+	public function setCompanyName(string $companyName) {
 		$this->assertIsWritable();
 		$this->companyName = $companyName;
 	}
@@ -40,7 +40,7 @@ 
 		return $this->salutation;
 	}
 
-	public function setSalutation( string $salutation ) {
+	public function setSalutation(string $salutation) {
 		$this->assertIsWritable();
 		$this->salutation = $salutation;
 	}
@@ -49,7 +49,7 @@ 
 		return $this->title;
 	}
 
-	public function setTitle( string $title ) {
+	public function setTitle(string $title) {
 		$this->assertIsWritable();
 		$this->title = $title;
 	}
@@ -58,7 +58,7 @@ 
 		return $this->firstName;
 	}
 
-	public function setFirstName( string $firstName ) {
+	public function setFirstName(string $firstName) {
 		$this->assertIsWritable();
 		$this->firstName = $firstName;
 	}
@@ -67,24 +67,24 @@ 
 		return $this->lastName;
 	}
 
-	public function setLastName( string $lastName ) {
+	public function setLastName(string $lastName) {
 		$this->assertIsWritable();
 		$this->lastName = $lastName;
 	}
 
 	public function getFullName(): string {
-		return join( ', ', array_filter( [
+		return join(', ', array_filter([
 			$this->getFullPrivatePersonName(),
 			$this->companyName
-		] ) );
+		]));
 	}
 
 	private function getFullPrivatePersonName(): string {
-		return join( ' ', array_filter( [
+		return join(' ', array_filter([
 			$this->getTitle(),
 			$this->getFirstName(),
 			$this->getLastName()
-		] ) );
+		]));
 	}
 
 }