wmde / FundraisingFrontend

contexts/DonationContext/src/Domain/Model/Donation.php

Spacing +36 added lines, -36 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonationContext\Domain\Model;
 
@@ -55,11 +55,11 @@ 
 	 *
 	 * @throws \InvalidArgumentException
 	 */
-	public function __construct( ?int $id, string $status, ?Donor $donor, DonationPayment $payment,
-		bool $optsIntoNewsletter, DonationTrackingInfo $trackingInfo, DonationComment $comment = null ) {
+	public function __construct(? int $id, string $status, ? Donor $donor, DonationPayment $payment,
+		bool $optsIntoNewsletter, DonationTrackingInfo $trackingInfo, DonationComment $comment = null) {
 
 		$this->id = $id;
-		$this->setStatus( $status );
+		$this->setStatus($status);
 		$this->donor = $donor;
 		$this->payment = $payment;
 		$this->optsIntoNewsletter = $optsIntoNewsletter;
@@ -67,15 +67,15 @@ 
 		$this->comment = $comment;
 	}
 
-	private function setStatus( string $status ) {
-		if ( !$this->isValidStatus( $status ) ) {
-			throw new \InvalidArgumentException( 'Invalid donation status' );
+	private function setStatus(string $status) {
+		if (!$this->isValidStatus($status)) {
+			throw new \InvalidArgumentException('Invalid donation status');
 		}
 
 		$this->status = $status;
 	}
 
-	private function isValidStatus( string $status ): bool {
+	private function isValidStatus(string $status): bool {
 		return in_array(
 			$status,
 			[
@@ -89,7 +89,7 @@ 
 		);
 	}
 
-	public function getId(): ?int {
+	public function getId(): ? int {
 		return $this->id;
 	}
 
@@ -97,9 +97,9 @@ 
 	 * @param int $id
 	 * @throws \RuntimeException
 	 */
-	public function assignId( int $id ) {
-		if ( $this->id !== null && $this->id !== $id ) {
-			throw new \RuntimeException( 'Id cannot be changed after initial assignment' );
+	public function assignId(int $id) {
+		if ($this->id !== null && $this->id !== $id) {
+			throw new \RuntimeException('Id cannot be changed after initial assignment');
 		}
 
 		$this->id = $id;
@@ -129,20 +129,20 @@ 
 	/**
 	 * Returns the Donor or null for anonymous donations.
 	 */
-	public function getDonor(): ?Donor {
+	public function getDonor(): ? Donor {
 		return $this->donor;
 	}
 
 	/**
 	 * Returns the DonationComment or null for when there is none.
 	 */
-	public function getComment(): ?DonationComment {
+	public function getComment(): ? DonationComment {
 		return $this->comment;
 	}
 
-	public function addComment( DonationComment $comment ) {
-		if ( $this->hasComment() ) {
-			throw new RuntimeException( 'Can only add a single comment to a donation' );
+	public function addComment(DonationComment $comment) {
+		if ($this->hasComment()) {
+			throw new RuntimeException('Can only add a single comment to a donation');
 		}
 
 		$this->comment = $comment;
@@ -164,12 +164,12 @@ 
 	 * @throws RuntimeException
 	 */
 	public function cancel() {
-		if ( $this->getPaymentType() !== PaymentType::DIRECT_DEBIT ) {
-			throw new RuntimeException( 'Can only cancel direct debit' );
+		if ($this->getPaymentType() !== PaymentType::DIRECT_DEBIT) {
+			throw new RuntimeException('Can only cancel direct debit');
 		}
 
-		if ( !$this->statusIsCancellable() ) {
-			throw new RuntimeException( 'Can only cancel new donations' );
+		if (!$this->statusIsCancellable()) {
+			throw new RuntimeException('Can only cancel new donations');
 		}
 
 		$this->status = self::STATUS_CANCELLED;
@@ -179,15 +179,15 @@ 
 	 * @throws RuntimeException
 	 */
 	public function confirmBooked() {
-		if ( !$this->hasExternalPayment() ) {
-			throw new RuntimeException( 'Only external payments can be confirmed as booked' );
+		if (!$this->hasExternalPayment()) {
+			throw new RuntimeException('Only external payments can be confirmed as booked');
 		}
 
-		if ( !$this->statusAllowsForBooking() ) {
-			throw new RuntimeException( 'Only incomplete donations can be confirmed as booked' );
+		if (!$this->statusAllowsForBooking()) {
+			throw new RuntimeException('Only incomplete donations can be confirmed as booked');
 		}
 
-		if ( $this->hasComment() && ( $this->needsModeration() || $this->isCancelled() ) ) {
+		if ($this->hasComment() && ($this->needsModeration() || $this->isCancelled())) {
 			$this->makeCommentPrivate();
 		}
 
@@ -215,7 +215,7 @@ 
 	}
 
 	public function notifyOfPolicyValidationFailure() {
-		if ( !$this->hasExternalPayment() ) {
+		if (!$this->hasExternalPayment()) {
 			$this->markForModeration();
 		}
 	}
@@ -232,14 +232,14 @@ 
 	 * @param PayPalData $payPalData
 	 * @throws RuntimeException
 	 */
-	public function addPayPalData( PayPalData $payPalData ) {
+	public function addPayPalData(PayPalData $payPalData) {
 		$paymentMethod = $this->payment->getPaymentMethod();
 
-		if ( !( $paymentMethod instanceof PayPalPayment ) ) {
-			throw new RuntimeException( 'Cannot set PayPal data on a non PayPal payment' );
+		if (!($paymentMethod instanceof PayPalPayment)) {
+			throw new RuntimeException('Cannot set PayPal data on a non PayPal payment');
 		}
 
-		$paymentMethod->addPayPalData( $payPalData );
+		$paymentMethod->addPayPalData($payPalData);
 	}
 
 	/**
@@ -247,14 +247,14 @@ 
 	 *
 	 * @throws RuntimeException
 	 */
-	public function addCreditCardData( CreditCardTransactionData $creditCardData ) {
+	public function addCreditCardData(CreditCardTransactionData $creditCardData) {
 		$paymentMethod = $this->payment->getPaymentMethod();
 
-		if ( !( $paymentMethod instanceof CreditCardPayment ) ) {
-			throw new RuntimeException( 'Cannot set credit card transaction data on a non credit card payment' );
+		if (!($paymentMethod instanceof CreditCardPayment)) {
+			throw new RuntimeException('Cannot set credit card transaction data on a non credit card payment');
 		}
 
-		$paymentMethod->addCreditCardTransactionData( $creditCardData );
+		$paymentMethod->addCreditCardTransactionData($creditCardData);
 	}
 
 	private function statusIsCancellable(): bool {
@@ -262,7 +262,7 @@ 
 	}
 
 	public function hasExternalPayment(): bool {
-		return in_array( $this->getPaymentType(), [ PaymentType::PAYPAL, PaymentType::CREDIT_CARD ] );
+		return in_array($this->getPaymentType(), [PaymentType::PAYPAL, PaymentType::CREDIT_CARD]);
 	}
 
 	private function isIncomplete(): bool {

contexts/DonationContext/src/UseCases/AddComment/AddCommentUseCase.php

Spacing +31 added lines, -31 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonationContext\UseCases\AddComment;
 
@@ -23,8 +23,8 @@ 
 	private $textPolicyValidator;
 	private $commentValidator;
 
-	public function __construct( DonationRepository $repository, DonationAuthorizer $authorizationService,
-		TextPolicyValidator $textPolicyValidator, AddCommentValidator $commentValidator ) {
+	public function __construct(DonationRepository $repository, DonationAuthorizer $authorizationService,
+		TextPolicyValidator $textPolicyValidator, AddCommentValidator $commentValidator) {
 
 		$this->donationRepository = $repository;
 		$this->authorizationService = $authorizationService;
@@ -32,72 +32,72 @@ 
 		$this->commentValidator = $commentValidator;
 	}
 
-	public function addComment( AddCommentRequest $addCommentRequest ): AddCommentResponse {
-		if ( !$this->requestIsAllowed( $addCommentRequest ) ) {
-			return AddCommentResponse::newFailureResponse( 'comment_failure_access_denied' );
+	public function addComment(AddCommentRequest $addCommentRequest): AddCommentResponse {
+		if (!$this->requestIsAllowed($addCommentRequest)) {
+			return AddCommentResponse::newFailureResponse('comment_failure_access_denied');
 		}
 
-		$validationResult = $this->commentValidator->validate( $addCommentRequest );
-		if ( !$validationResult->isSuccessful() ) {
-			return AddCommentResponse::newFailureResponse( $validationResult->getFirstViolation() );
+		$validationResult = $this->commentValidator->validate($addCommentRequest);
+		if (!$validationResult->isSuccessful()) {
+			return AddCommentResponse::newFailureResponse($validationResult->getFirstViolation());
 		}
 
 		try {
-			$donation = $this->donationRepository->getDonationById( $addCommentRequest->getDonationId() );
+			$donation = $this->donationRepository->getDonationById($addCommentRequest->getDonationId());
 		}
-		catch ( GetDonationException $ex ) {
-			return AddCommentResponse::newFailureResponse( 'comment_failure_donation_error' );
+		catch (GetDonationException $ex) {
+			return AddCommentResponse::newFailureResponse('comment_failure_donation_error');
 		}
 
-		if ( $donation === null ) {
-			return AddCommentResponse::newFailureResponse( 'comment_failure_donation_not_found' );
+		if ($donation === null) {
+			return AddCommentResponse::newFailureResponse('comment_failure_donation_not_found');
 		}
 
-		if ( $donation->getComment() !== null ) {
-			return AddCommentResponse::newFailureResponse( 'comment_failure_donation_has_comment' );
+		if ($donation->getComment() !== null) {
+			return AddCommentResponse::newFailureResponse('comment_failure_donation_has_comment');
 		}
 
 		$successMessage = 'comment_success_ok';
-		if ( $donation->needsModeration() ) {
+		if ($donation->needsModeration()) {
 			$successMessage = 'comment_success_needs_moderation';
 		}
 
-		$donation->addComment( $this->newCommentFromRequest( $addCommentRequest ) );
+		$donation->addComment($this->newCommentFromRequest($addCommentRequest));
 
-		if ( !$this->commentTextPassesValidation( $addCommentRequest->getCommentText() ) ) {
+		if (!$this->commentTextPassesValidation($addCommentRequest->getCommentText())) {
 			$donation->notifyOfCommentValidationFailure();
 			$successMessage = 'comment_success_needs_moderation';
 		}
 
 		try {
-			$this->donationRepository->storeDonation( $donation );
+			$this->donationRepository->storeDonation($donation);
 		}
-		catch ( StoreDonationException $ex ) {
-			return AddCommentResponse::newFailureResponse( 'comment_failure_save_error' );
+		catch (StoreDonationException $ex) {
+			return AddCommentResponse::newFailureResponse('comment_failure_save_error');
 		}
 
-		return AddCommentResponse::newSuccessResponse( $successMessage );
+		return AddCommentResponse::newSuccessResponse($successMessage);
 	}
 
-	private function requestIsAllowed( AddCommentRequest $addCommentRequest ): bool {
-		return $this->authorizationService->userCanModifyDonation( $addCommentRequest->getDonationId() );
+	private function requestIsAllowed(AddCommentRequest $addCommentRequest): bool {
+		return $this->authorizationService->userCanModifyDonation($addCommentRequest->getDonationId());
 	}
 
-	private function newCommentFromRequest( AddCommentRequest $request ): DonationComment {
+	private function newCommentFromRequest(AddCommentRequest $request): DonationComment {
 		return new DonationComment(
 			$request->getCommentText(),
-			$this->commentCanBePublic( $request ),
+			$this->commentCanBePublic($request),
 			$request->getAuthorDisplayName()
 		);
 	}
 
-	private function commentCanBePublic( AddCommentRequest $request ): bool {
+	private function commentCanBePublic(AddCommentRequest $request): bool {
 		return $request->isPublic()
-			&& $this->commentTextPassesValidation( $request->getCommentText() );
+			&& $this->commentTextPassesValidation($request->getCommentText());
 	}
 
-	private function commentTextPassesValidation( string $text ): bool {
-		return $this->textPolicyValidator->textIsHarmless( $text );
+	private function commentTextPassesValidation(string $text): bool {
+		return $this->textPolicyValidator->textIsHarmless($text);
 	}
 
 }
\ No newline at end of file

contexts/DonationContext/src/UseCases/AddDonation/AddDonationUseCase.php

Spacing +57 added lines, -57 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonationContext\UseCases\AddDonation;
 
@@ -37,10 +37,10 @@ 
 	private $transferCodeGenerator;
 	private $tokenFetcher;
 
-	public function __construct( DonationRepository $donationRepository, AddDonationValidator $donationValidator,
+	public function __construct(DonationRepository $donationRepository, AddDonationValidator $donationValidator,
 								 AddDonationPolicyValidator $policyValidator, ReferrerGeneralizer $referrerGeneralizer,
 								 DonationConfirmationMailer $mailer, TransferCodeGenerator $transferCodeGenerator,
-								 DonationTokenFetcher $tokenFetcher ) {
+								 DonationTokenFetcher $tokenFetcher) {
 		$this->donationRepository = $donationRepository;
 		$this->donationValidator = $donationValidator;
 		$this->policyValidator = $policyValidator;
@@ -51,31 +51,31 @@ 
 		$this->tokenFetcher = $tokenFetcher;
 	}
 
-	public function addDonation( AddDonationRequest $donationRequest ): AddDonationResponse {
-		$validationResult = $this->donationValidator->validate( $donationRequest );
+	public function addDonation(AddDonationRequest $donationRequest): AddDonationResponse {
+		$validationResult = $this->donationValidator->validate($donationRequest);
 
-		if ( $validationResult->hasViolations() ) {
-			return AddDonationResponse::newFailureResponse( $validationResult->getViolations() );
+		if ($validationResult->hasViolations()) {
+			return AddDonationResponse::newFailureResponse($validationResult->getViolations());
 		}
 
-		$donation = $this->newDonationFromRequest( $donationRequest );
+		$donation = $this->newDonationFromRequest($donationRequest);
 
-		if ( $this->policyValidator->needsModeration( $donationRequest ) ) {
+		if ($this->policyValidator->needsModeration($donationRequest)) {
 			$donation->notifyOfPolicyValidationFailure();
 		}
 
-		if ( $this->policyValidator->isAutoDeleted( $donationRequest ) ) {
+		if ($this->policyValidator->isAutoDeleted($donationRequest)) {
 			$donation->markAsDeleted();
 		}
 
 		// TODO: handle exceptions
-		$this->donationRepository->storeDonation( $donation );
+		$this->donationRepository->storeDonation($donation);
 
 		// TODO: handle exceptions
-		$tokens = $this->tokenFetcher->getTokens( $donation->getId() );
+		$tokens = $this->tokenFetcher->getTokens($donation->getId());
 
 		// TODO: handle exceptions
-		$this->sendDonationConfirmationEmail( $donation );
+		$this->sendDonationConfirmationEmail($donation);
 
 		return AddDonationResponse::newSuccessResponse(
 			$donation,
@@ -84,97 +84,97 @@ 
 		);
 	}
 
-	private function newDonationFromRequest( AddDonationRequest $donationRequest ): Donation {
+	private function newDonationFromRequest(AddDonationRequest $donationRequest): Donation {
 		return new Donation(
 			null,
-			$this->getInitialDonationStatus( $donationRequest->getPaymentType() ),
-			$this->getPersonalInfoFromRequest( $donationRequest ),
-			$this->getPaymentFromRequest( $donationRequest ),
+			$this->getInitialDonationStatus($donationRequest->getPaymentType()),
+			$this->getPersonalInfoFromRequest($donationRequest),
+			$this->getPaymentFromRequest($donationRequest),
 			$donationRequest->getOptIn() === '1',
-			$this->newTrackingInfoFromRequest( $donationRequest )
+			$this->newTrackingInfoFromRequest($donationRequest)
 		);
 	}
 
-	private function getPersonalInfoFromRequest( AddDonationRequest $request ) {
-		if ( $request->donorIsAnonymous() ) {
+	private function getPersonalInfoFromRequest(AddDonationRequest $request) {
+		if ($request->donorIsAnonymous()) {
 			return null;
 		}
 		return new Donor(
-			$this->getNameFromRequest( $request ),
-			$this->getPhysicalAddressFromRequest( $request ),
+			$this->getNameFromRequest($request),
+			$this->getPhysicalAddressFromRequest($request),
 			$request->getDonorEmailAddress()
 		);
 	}
 
-	private function getPhysicalAddressFromRequest( AddDonationRequest $request ): DonorAddress {
+	private function getPhysicalAddressFromRequest(AddDonationRequest $request): DonorAddress {
 		$address = new DonorAddress();
 
-		$address->setStreetAddress( $request->getDonorStreetAddress() );
-		$address->setPostalCode( $request->getDonorPostalCode() );
-		$address->setCity( $request->getDonorCity() );
-		$address->setCountryCode( $request->getDonorCountryCode() );
+		$address->setStreetAddress($request->getDonorStreetAddress());
+		$address->setPostalCode($request->getDonorPostalCode());
+		$address->setCity($request->getDonorCity());
+		$address->setCountryCode($request->getDonorCountryCode());
 
 		return $address->freeze()->assertNoNullFields();
 	}
 
-	private function getNameFromRequest( AddDonationRequest $request ): DonorName {
+	private function getNameFromRequest(AddDonationRequest $request): DonorName {
 		$name = $request->donorIsCompany() ? DonorName::newCompanyName() : DonorName::newPrivatePersonName();
 
-		$name->setSalutation( $request->getDonorSalutation() );
-		$name->setTitle( $request->getDonorTitle() );
-		$name->setCompanyName( $request->getDonorCompany() );
-		$name->setFirstName( $request->getDonorFirstName() );
-		$name->setLastName( $request->getDonorLastName() );
+		$name->setSalutation($request->getDonorSalutation());
+		$name->setTitle($request->getDonorTitle());
+		$name->setCompanyName($request->getDonorCompany());
+		$name->setFirstName($request->getDonorFirstName());
+		$name->setLastName($request->getDonorLastName());
 
 		return $name->freeze()->assertNoNullFields();
 	}
 
-	private function getInitialDonationStatus( string $paymentType ): string {
-		if ( $paymentType === PaymentType::DIRECT_DEBIT ) {
+	private function getInitialDonationStatus(string $paymentType): string {
+		if ($paymentType === PaymentType::DIRECT_DEBIT) {
 			return Donation::STATUS_NEW;
 		}
 
-		if ( $paymentType === PaymentType::BANK_TRANSFER ) {
+		if ($paymentType === PaymentType::BANK_TRANSFER) {
 			return Donation::STATUS_PROMISE;
 		}
 
 		return Donation::STATUS_EXTERNAL_INCOMPLETE;
 	}
 
-	private function getPaymentFromRequest( AddDonationRequest $donationRequest ): DonationPayment {
+	private function getPaymentFromRequest(AddDonationRequest $donationRequest): DonationPayment {
 		return new DonationPayment(
 			$donationRequest->getAmount(),
 			$donationRequest->getInterval(),
-			$this->getPaymentMethodFromRequest( $donationRequest )
+			$this->getPaymentMethodFromRequest($donationRequest)
 		);
 	}
 
-	private function getPaymentMethodFromRequest( AddDonationRequest $donationRequest ): PaymentMethod {
-		if ( $donationRequest->getPaymentType() === PaymentType::BANK_TRANSFER ) {
-			return new BankTransferPayment( $this->transferCodeGenerator->generateTransferCode() );
+	private function getPaymentMethodFromRequest(AddDonationRequest $donationRequest): PaymentMethod {
+		if ($donationRequest->getPaymentType() === PaymentType::BANK_TRANSFER) {
+			return new BankTransferPayment($this->transferCodeGenerator->generateTransferCode());
 		}
 
-		if ( $donationRequest->getPaymentType() === PaymentType::DIRECT_DEBIT ) {
-			return new DirectDebitPayment( $donationRequest->getBankData() );
+		if ($donationRequest->getPaymentType() === PaymentType::DIRECT_DEBIT) {
+			return new DirectDebitPayment($donationRequest->getBankData());
 		}
 
-		if ( $donationRequest->getPaymentType() === PaymentType::PAYPAL ) {
-			return new PayPalPayment( new PayPalData() );
+		if ($donationRequest->getPaymentType() === PaymentType::PAYPAL) {
+			return new PayPalPayment(new PayPalData());
 		}
 
-		return new PaymentWithoutAssociatedData( $donationRequest->getPaymentType() );
+		return new PaymentWithoutAssociatedData($donationRequest->getPaymentType());
 	}
 
-	private function newTrackingInfoFromRequest( AddDonationRequest $request ): DonationTrackingInfo {
+	private function newTrackingInfoFromRequest(AddDonationRequest $request): DonationTrackingInfo {
 		$trackingInfo = new DonationTrackingInfo();
 
-		$trackingInfo->setTracking( $request->getTracking() );
-		$trackingInfo->setSource( $this->referrerGeneralizer->generalize( $request->getSource() ) );
-		$trackingInfo->setTotalImpressionCount( $request->getTotalImpressionCount() );
-		$trackingInfo->setSingleBannerImpressionCount( $request->getSingleBannerImpressionCount() );
-		$trackingInfo->setColor( $request->getColor() );
-		$trackingInfo->setSkin( $request->getSkin() );
-		$trackingInfo->setLayout( $request->getLayout() );
+		$trackingInfo->setTracking($request->getTracking());
+		$trackingInfo->setSource($this->referrerGeneralizer->generalize($request->getSource()));
+		$trackingInfo->setTotalImpressionCount($request->getTotalImpressionCount());
+		$trackingInfo->setSingleBannerImpressionCount($request->getSingleBannerImpressionCount());
+		$trackingInfo->setColor($request->getColor());
+		$trackingInfo->setSkin($request->getSkin());
+		$trackingInfo->setLayout($request->getLayout());
 
 		return $trackingInfo->freeze()->assertNoNullFields();
 	}
@@ -184,9 +184,9 @@ 
 	 *
 	 * @throws \RuntimeException
 	 */
-	private function sendDonationConfirmationEmail( Donation $donation ) {
-		if ( $donation->getDonor() !== null && !$donation->hasExternalPayment() ) {
-			$this->mailer->sendConfirmationMailFor( $donation );
+	private function sendDonationConfirmationEmail(Donation $donation) {
+		if ($donation->getDonor() !== null && !$donation->hasExternalPayment()) {
+			$this->mailer->sendConfirmationMailFor($donation);
 		}
 	}
 

contexts/DonationContext/tests/Unit/Domain/Model/DonationTest.php

Spacing +47 added lines, -47 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonationContext\Tests\Unit\Domain\Model;
 
@@ -20,7 +20,7 @@ 
 	public function testGivenNonDirectDebitDonation_cancellationFails() {
 		$donation = ValidDonation::newBankTransferDonation();
 
-		$this->expectException( RuntimeException::class );
+		$this->expectException(RuntimeException::class);
 		$donation->cancel();
 	}
 
@@ -28,20 +28,20 @@ 
 		$donation = ValidDonation::newDirectDebitDonation();
 
 		$donation->cancel();
-		$this->assertSame( Donation::STATUS_CANCELLED, $donation->getStatus() );
+		$this->assertSame(Donation::STATUS_CANCELLED, $donation->getStatus());
 	}
 
 	/**
 	 * @dataProvider nonCancellableStatusProvider
 	 */
-	public function testGivenNonNewStatus_cancellationFails( $nonCancellableStatus ) {
-		$donation = $this->newDirectDebitDonationWithStatus( $nonCancellableStatus );
+	public function testGivenNonNewStatus_cancellationFails($nonCancellableStatus) {
+		$donation = $this->newDirectDebitDonationWithStatus($nonCancellableStatus);
 
-		$this->expectException( RuntimeException::class );
+		$this->expectException(RuntimeException::class);
 		$donation->cancel();
 	}
 
-	private function newDirectDebitDonationWithStatus( string $status ) {
+	private function newDirectDebitDonationWithStatus(string $status) {
 		return new Donation(
 			null,
 			$status,
@@ -54,10 +54,10 @@ 
 
 	public function nonCancellableStatusProvider() {
 		return [
-			[ Donation::STATUS_CANCELLED ],
-			[ Donation::STATUS_EXTERNAL_BOOKED ],
-			[ Donation::STATUS_EXTERNAL_INCOMPLETE ],
-			[ Donation::STATUS_PROMISE ],
+			[Donation::STATUS_CANCELLED],
+			[Donation::STATUS_EXTERNAL_BOOKED],
+			[Donation::STATUS_EXTERNAL_INCOMPLETE],
+			[Donation::STATUS_PROMISE],
 		];
 	}
 
@@ -65,14 +65,14 @@ 
 		$donation = ValidDonation::newDirectDebitDonation();
 
 		$donation->cancel();
-		$this->assertSame( Donation::STATUS_CANCELLED, $donation->getStatus() );
+		$this->assertSame(Donation::STATUS_CANCELLED, $donation->getStatus());
 	}
 
 	public function testModerationStatusCanBeQueried() {
 		$donation = ValidDonation::newDirectDebitDonation();
 
 		$donation->markForModeration();
-		$this->assertTrue( $donation->needsModeration() );
+		$this->assertTrue($donation->needsModeration());
 	}
 
 	public function testGivenModerationStatus_cancellationSucceeds() {
@@ -80,72 +80,72 @@ 
 
 		$donation->markForModeration();
 		$donation->cancel();
-		$this->assertSame( Donation::STATUS_CANCELLED, $donation->getStatus() );
+		$this->assertSame(Donation::STATUS_CANCELLED, $donation->getStatus());
 	}
 
 	public function testIdIsNullWhenNotAssigned() {
-		$this->assertNull( ValidDonation::newDirectDebitDonation()->getId() );
+		$this->assertNull(ValidDonation::newDirectDebitDonation()->getId());
 	}
 
 	public function testCanAssignIdToNewDonation() {
 		$donation = ValidDonation::newDirectDebitDonation();
 
-		$donation->assignId( 42 );
-		$this->assertSame( 42, $donation->getId() );
+		$donation->assignId(42);
+		$this->assertSame(42, $donation->getId());
 	}
 
 	public function testCannotAssignIdToDonationWithIdentity() {
 		$donation = ValidDonation::newDirectDebitDonation();
-		$donation->assignId( 42 );
+		$donation->assignId(42);
 
-		$this->expectException( RuntimeException::class );
-		$donation->assignId( 43 );
+		$this->expectException(RuntimeException::class);
+		$donation->assignId(43);
 	}
 
 	public function testGivenNonExternalPaymentType_confirmBookedThrowsException() {
 		$donation = ValidDonation::newDirectDebitDonation();
 
-		$this->expectException( RuntimeException::class );
-		$this->expectExceptionMessageRegExp( '/Only external payments/' );
+		$this->expectException(RuntimeException::class);
+		$this->expectExceptionMessageRegExp('/Only external payments/');
 		$donation->confirmBooked();
 	}
 
 	public function testAddingPayPalDataToNoPayPalDonationCausesException() {
 		$donation = ValidDonation::newDirectDebitDonation();
 
-		$this->expectException( RuntimeException::class );
-		$donation->addPayPalData( new PayPalData() );
+		$this->expectException(RuntimeException::class);
+		$donation->addPayPalData(new PayPalData());
 	}
 
 	/**
 	 * @dataProvider statusesThatDoNotAllowForBookingProvider
 	 */
-	public function testGivenStatusThatDoesNotAllowForBooking_confirmBookedThrowsException( Donation $donation ) {
-		$this->expectException( RuntimeException::class );
+	public function testGivenStatusThatDoesNotAllowForBooking_confirmBookedThrowsException(Donation $donation) {
+		$this->expectException(RuntimeException::class);
 		$donation->confirmBooked();
 	}
 
 	public function statusesThatDoNotAllowForBookingProvider() {
 		return [
-			[ ValidDonation::newBookedPayPalDonation() ],
-			[ ValidDonation::newBookedCreditCardDonation() ],
+			[ValidDonation::newBookedPayPalDonation()],
+			[ValidDonation::newBookedCreditCardDonation()],
 		];
 	}
 
 	/**
 	 * @dataProvider statusesThatAllowsForBookingProvider
 	 */
-	public function testGivenStatusThatAllowsForBooking_confirmBookedSetsBookedStatus( Donation $donation ) {
+	public function testGivenStatusThatAllowsForBooking_confirmBookedSetsBookedStatus(Donation $donation) {
 		$donation->confirmBooked();
-		$this->assertSame( Donation::STATUS_EXTERNAL_BOOKED, $donation->getStatus() );
+		$this->assertSame(Donation::STATUS_EXTERNAL_BOOKED, $donation->getStatus());
 	}
 
 	public function statusesThatAllowsForBookingProvider() {
 		return [
-			[ ValidDonation::newIncompletePayPalDonation() ],
-			[ ValidDonation::newIncompleteCreditCardDonation() ],
-			[ $this->newInModerationPayPalDonation() ],
-			[ ValidDonation::newCancelledPayPalDonation() ],
+			[ValidDonation::newIncompletePayPalDonation()],
+			[ValidDonation::newIncompleteCreditCardDonation()],
+			[$this->newInModerationPayPalDonation()],
+			[ValidDonation::newCancelledPayPalDonation()],
 		];
 	}
 
@@ -166,8 +166,8 @@ 
 			ValidDonation::newPublicComment()
 		);
 
-		$this->expectException( RuntimeException::class );
-		$donation->addComment( ValidDonation::newPublicComment() );
+		$this->expectException(RuntimeException::class);
+		$donation->addComment(ValidDonation::newPublicComment());
 	}
 
 	public function testAddCommentSetsWhenCommentNotSetYet() {
@@ -181,30 +181,30 @@ 
 			null
 		);
 
-		$donation->addComment( ValidDonation::newPublicComment() );
-		$this->assertEquals( ValidDonation::newPublicComment(), $donation->getComment() );
+		$donation->addComment(ValidDonation::newPublicComment());
+		$this->assertEquals(ValidDonation::newPublicComment(), $donation->getComment());
 	}
 
 	public function testWhenNoCommentHasBeenSet_getCommentReturnsNull() {
-		$this->assertNull( ValidDonation::newDirectDebitDonation()->getComment() );
+		$this->assertNull(ValidDonation::newDirectDebitDonation()->getComment());
 	}
 
 	public function testWhenCompletingBookingOfExternalPaymentInModeration_commentIsMadePrivate() {
 		$donation = $this->newInModerationPayPalDonation();
-		$donation->addComment( ValidDonation::newPublicComment() );
+		$donation->addComment(ValidDonation::newPublicComment());
 
 		$donation->confirmBooked();
 
-		$this->assertFalse( $donation->getComment()->isPublic() );
+		$this->assertFalse($donation->getComment()->isPublic());
 	}
 
 	public function testWhenCompletingBookingOfCancelledExternalPayment_commentIsMadePrivate() {
 		$donation = ValidDonation::newCancelledPayPalDonation();
-		$donation->addComment( ValidDonation::newPublicComment() );
+		$donation->addComment(ValidDonation::newPublicComment());
 
 		$donation->confirmBooked();
 
-		$this->assertFalse( $donation->getComment()->isPublic() );
+		$this->assertFalse($donation->getComment()->isPublic());
 	}
 
 	public function testWhenCompletingBookingOfCancelledExternalPayment_lackOfCommentCausesNoError() {
@@ -212,11 +212,11 @@ 
 
 		$donation->confirmBooked();
 
-		$this->assertFalse( $donation->hasComment() );
+		$this->assertFalse($donation->hasComment());
 	}
 
 	public function testWhenConstructingWithInvalidStatus_exceptionIsThrown() {
-		$this->expectException( \InvalidArgumentException::class );
+		$this->expectException(\InvalidArgumentException::class);
 
 		new Donation(
 			null,
@@ -232,13 +232,13 @@ 
 	public function testWhenNonExternalPaymentIsNotifiedOfPolicyValidationFailure_itIsPutInModeration() {
 		$donation = ValidDonation::newBankTransferDonation();
 		$donation->notifyOfPolicyValidationFailure();
-		$this->assertTrue( $donation->needsModeration() );
+		$this->assertTrue($donation->needsModeration());
 	}
 
 	public function testWhenExternalPaymentIsNotifiedOfPolicyValidationFailure_itIsNotPutInModeration() {
 		$donation = ValidDonation::newIncompletePayPalDonation();
 		$donation->notifyOfPolicyValidationFailure();
-		$this->assertFalse( $donation->needsModeration() );
+		$this->assertFalse($donation->needsModeration());
 	}
 
 }