wmde / FundraisingFrontend

contexts/MembershipContext/src/Domain/Repositories/ApplicationPurgedException.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Domain\Repositories;
 
@@ -11,7 +11,7 @@ 
 class ApplicationPurgedException extends GetMembershipApplicationException {
 
 	public function __construct() {
-		parent::__construct( 'Tried to access a purged Application' );
+		parent::__construct('Tried to access a purged Application');
 	}
 
 }

contexts/MembershipContext/src/Domain/Repositories/GetMembershipApplicationException.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Domain\Repositories;
 
@@ -10,7 +10,7 @@ 
  */
 class GetMembershipApplicationException extends \RuntimeException {
 
-	public function __construct( string $message = null, \Exception $previous = null ) {
+	public function __construct(string $message = null, \Exception $previous = null) {
 		parent::__construct(
 			$message ?? 'Could not get membership application',
 			0,

contexts/MembershipContext/src/DataAccess/DoctrineApplicationRepository.php

Spacing +129 added lines, -129 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\DataAccess;
 
@@ -36,108 +36,108 @@ 
 
 	private $entityManager;
 
-	public function __construct( EntityManager $entityManager ) {
+	public function __construct(EntityManager $entityManager) {
 		$this->entityManager = $entityManager;
 	}
 
-	public function storeApplication( Application $application ): void {
-		if ( $application->hasId() ) {
-			$this->updateApplication( $application );
+	public function storeApplication(Application $application): void {
+		if ($application->hasId()) {
+			$this->updateApplication($application);
 		}
 		else {
-			$this->insertApplication( $application );
+			$this->insertApplication($application);
 		}
 	}
 
-	private function insertApplication( Application $application ): void {
+	private function insertApplication(Application $application): void {
 		$doctrineApplication = new DoctrineApplication();
-		$this->updateDoctrineApplication( $doctrineApplication, $application );
+		$this->updateDoctrineApplication($doctrineApplication, $application);
 
 		try {
-			$this->entityManager->persist( $doctrineApplication );
+			$this->entityManager->persist($doctrineApplication);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreMembershipApplicationException($ex);
 		}
 
-		$application->assignId( $doctrineApplication->getId() );
+		$application->assignId($doctrineApplication->getId());
 	}
 
-	private function updateApplication( Application $application ): void {
-		$doctrineApplication = $this->getDoctrineApplicationById( $application->getId() );
+	private function updateApplication(Application $application): void {
+		$doctrineApplication = $this->getDoctrineApplicationById($application->getId());
 
-		if ( $doctrineApplication === null ) {
+		if ($doctrineApplication === null) {
 			throw new StoreMembershipApplicationException();
 		}
 
-		$this->updateDoctrineApplication( $doctrineApplication, $application );
+		$this->updateDoctrineApplication($doctrineApplication, $application);
 
 		try {
-			$this->entityManager->persist( $doctrineApplication );
+			$this->entityManager->persist($doctrineApplication);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreMembershipApplicationException($ex);
 		}
 	}
 
-	private function updateDoctrineApplication( DoctrineApplication $doctrineApplication, Application $application ): void {
-		$doctrineApplication->setId( $application->getId() );
-		$doctrineApplication->setMembershipType( $application->getType() );
+	private function updateDoctrineApplication(DoctrineApplication $doctrineApplication, Application $application): void {
+		$doctrineApplication->setId($application->getId());
+		$doctrineApplication->setMembershipType($application->getType());
 
-		$this->setApplicantFields( $doctrineApplication, $application->getApplicant() );
-		$this->setPaymentFields( $doctrineApplication, $application->getPayment() );
-		$doctrineApplication->setDonationReceipt( $application->getDonationReceipt() );
+		$this->setApplicantFields($doctrineApplication, $application->getApplicant());
+		$this->setPaymentFields($doctrineApplication, $application->getPayment());
+		$doctrineApplication->setDonationReceipt($application->getDonationReceipt());
 
-		$doctrineStatus = $this->getDoctrineStatus( $application );
-		$this->preserveDoctrineStatus( $doctrineApplication, $doctrineStatus );
-		$doctrineApplication->setStatus( $doctrineStatus );
+		$doctrineStatus = $this->getDoctrineStatus($application);
+		$this->preserveDoctrineStatus($doctrineApplication, $doctrineStatus);
+		$doctrineApplication->setStatus($doctrineStatus);
 	}
 
-	private function setApplicantFields( DoctrineApplication $application, Applicant $applicant ): void {
-		$application->setApplicantFirstName( $applicant->getName()->getFirstName() );
-		$application->setApplicantLastName( $applicant->getName()->getLastName() );
-		$application->setApplicantSalutation( $applicant->getName()->getSalutation() );
-		$application->setApplicantTitle( $applicant->getName()->getTitle() );
-		$application->setCompany( $applicant->getName()->getCompanyName() );
+	private function setApplicantFields(DoctrineApplication $application, Applicant $applicant): void {
+		$application->setApplicantFirstName($applicant->getName()->getFirstName());
+		$application->setApplicantLastName($applicant->getName()->getLastName());
+		$application->setApplicantSalutation($applicant->getName()->getSalutation());
+		$application->setApplicantTitle($applicant->getName()->getTitle());
+		$application->setCompany($applicant->getName()->getCompanyName());
 
-		$application->setApplicantDateOfBirth( $applicant->getDateOfBirth() );
+		$application->setApplicantDateOfBirth($applicant->getDateOfBirth());
 
-		$application->setApplicantEmailAddress( $applicant->getEmailAddress()->getFullAddress() );
-		$application->setApplicantPhoneNumber( $applicant->getPhoneNumber()->__toString() );
+		$application->setApplicantEmailAddress($applicant->getEmailAddress()->getFullAddress());
+		$application->setApplicantPhoneNumber($applicant->getPhoneNumber()->__toString());
 
 		$address = $applicant->getPhysicalAddress();
 
-		$application->setCity( $address->getCity() );
-		$application->setCountry( $address->getCountryCode() );
-		$application->setPostcode( $address->getPostalCode() );
-		$application->setAddress( $address->getStreetAddress() );
+		$application->setCity($address->getCity());
+		$application->setCountry($address->getCountryCode());
+		$application->setPostcode($address->getPostalCode());
+		$application->setAddress($address->getStreetAddress());
 	}
 
-	private function setPaymentFields( DoctrineApplication $application, Payment $payment ): void {
-		$application->setPaymentIntervalInMonths( $payment->getIntervalInMonths() );
-		$application->setPaymentAmount( (int)$payment->getAmount()->getEuroFloat() );
+	private function setPaymentFields(DoctrineApplication $application, Payment $payment): void {
+		$application->setPaymentIntervalInMonths($payment->getIntervalInMonths());
+		$application->setPaymentAmount((int)$payment->getAmount()->getEuroFloat());
 		$paymentMethod = $payment->getPaymentMethod();
 
-		$application->setPaymentType( $paymentMethod->getType() );
-		if ( $paymentMethod instanceof DirectDebitPayment ) {
-			$this->setBankDataFields( $application, $paymentMethod->getBankData() );
-		} elseif ( $paymentMethod instanceof PayPalPayment && $paymentMethod->getPayPalData() != new PayPalData() ) {
-			$this->setPayPalDataFields( $application, $paymentMethod->getPayPalData() );
+		$application->setPaymentType($paymentMethod->getType());
+		if ($paymentMethod instanceof DirectDebitPayment) {
+			$this->setBankDataFields($application, $paymentMethod->getBankData());
+		} elseif ($paymentMethod instanceof PayPalPayment && $paymentMethod->getPayPalData() != new PayPalData()) {
+			$this->setPayPalDataFields($application, $paymentMethod->getPayPalData());
 		}
 	}
 
-	private function setBankDataFields( DoctrineApplication $application, BankData $bankData ): void {
-		$application->setPaymentBankAccount( $bankData->getAccount() );
-		$application->setPaymentBankCode( $bankData->getBankCode() );
-		$application->setPaymentBankName( $bankData->getBankName() );
-		$application->setPaymentBic( $bankData->getBic() );
-		$application->setPaymentIban( $bankData->getIban()->toString() );
+	private function setBankDataFields(DoctrineApplication $application, BankData $bankData): void {
+		$application->setPaymentBankAccount($bankData->getAccount());
+		$application->setPaymentBankCode($bankData->getBankCode());
+		$application->setPaymentBankName($bankData->getBankName());
+		$application->setPaymentBic($bankData->getBic());
+		$application->setPaymentIban($bankData->getIban()->toString());
 	}
 
-	private function setPayPalDataFields( DoctrineApplication $application, PayPalData $payPalData ): void {
-		$application->encodeAndSetData( array_merge(
+	private function setPayPalDataFields(DoctrineApplication $application, PayPalData $payPalData): void {
+		$application->encodeAndSetData(array_merge(
 			$application->getDecodedData(),
 			[
 				'paypal_payer_id' => $payPalData->getPayerId(),
@@ -159,43 +159,43 @@ 
 				'ext_payment_timestamp' => $payPalData->getPaymentTimestamp(),
 				'first_payment_date' => $payPalData->getFirstPaymentDate()
 			]
-		) );
+		));
 	}
 
-	private function getDoctrineStatus( Application $application ): int {
+	private function getDoctrineStatus(Application $application): int {
 		$status = DoctrineApplication::STATUS_NEUTRAL;
 
-		if ( $application->needsModeration() ) {
+		if ($application->needsModeration()) {
 			$status += DoctrineApplication::STATUS_MODERATION;
 		}
 
-		if ( $application->isCancelled() ) {
+		if ($application->isCancelled()) {
 			$status += DoctrineApplication::STATUS_CANCELED;
 		}
 
-		if ( $application->isDeleted() ) {
+		if ($application->isDeleted()) {
 			$status += DoctrineApplication::STATUS_DELETED;
 		}
 
-		if ( $application->isConfirmed() || $this->isAutoConfirmed( $status, $application ) ) {
+		if ($application->isConfirmed() || $this->isAutoConfirmed($status, $application)) {
 			$status += DoctrineApplication::STATUS_CONFIRMED;
 		}
 
 		return $status;
 	}
 
-	private function isAutoConfirmed( int $status, Application $application ): bool {
-		return $status === DoctrineApplication::STATUS_NEUTRAL && $this->isDirectDebitPayment( $application );
+	private function isAutoConfirmed(int $status, Application $application): bool {
+		return $status === DoctrineApplication::STATUS_NEUTRAL && $this->isDirectDebitPayment($application);
 	}
 
-	private function isDirectDebitPayment( Application $application ): bool {
+	private function isDirectDebitPayment(Application $application): bool {
 		return $application->getPayment()->getPaymentMethod()->getType() === PaymentType::DIRECT_DEBIT;
 	}
 
-	private function preserveDoctrineStatus( DoctrineApplication $doctrineApplication, int $doctrineStatus ): void {
-		if ( $doctrineStatus < DoctrineApplication::STATUS_CONFIRMED ) {
-			$doctrineApplication->modifyDataObject( function ( MembershipApplicationData $data ): void {
-				$data->setPreservedStatus( DoctrineApplication::STATUS_CONFIRMED );
+	private function preserveDoctrineStatus(DoctrineApplication $doctrineApplication, int $doctrineStatus): void {
+		if ($doctrineStatus < DoctrineApplication::STATUS_CONFIRMED) {
+			$doctrineApplication->modifyDataObject(function(MembershipApplicationData $data): void {
+				$data->setPreservedStatus(DoctrineApplication::STATUS_CONFIRMED);
 			} );
 		}
 	}
@@ -206,20 +206,20 @@ 
 	 * @return Application|null
 	 * @throws GetMembershipApplicationException
 	 */
-	public function getApplicationById( int $id ): ?Application {
+	public function getApplicationById(int $id): ?Application {
 		try {
-			$application = $this->getDoctrineApplicationById( $id );
+			$application = $this->getDoctrineApplicationById($id);
 		}
-		catch ( ORMException $ex ) {
-			throw new GetMembershipApplicationException( null, $ex );
+		catch (ORMException $ex) {
+			throw new GetMembershipApplicationException(null, $ex);
 		}
 
-		if ( $application === null ) {
+		if ($application === null) {
 			return null;
 		}
 
-		if ( $application->getBackup() === null ) {
-			return $this->newApplicationDomainEntity( $application );
+		if ($application->getBackup() === null) {
+			return $this->newApplicationDomainEntity($application);
 		}
 
 		throw new ApplicationPurgedException();
@@ -230,25 +230,25 @@ 
 	 * @return DoctrineApplication|null
 	 * @throws ORMException
 	 */
-	public function getDoctrineApplicationById( int $id ): ?DoctrineApplication {
-		return $this->entityManager->find( DoctrineApplication::class, $id );
+	public function getDoctrineApplicationById(int $id): ?DoctrineApplication {
+		return $this->entityManager->find(DoctrineApplication::class, $id);
 	}
 
-	private function newApplicationDomainEntity( DoctrineApplication $application ): Application {
+	private function newApplicationDomainEntity(DoctrineApplication $application): Application {
 		return new Application(
 			$application->getId(),
 			$application->getMembershipType(),
 			new Applicant(
-				$this->newPersonName( $application ),
-				$this->newAddress( $application ),
-				new EmailAddress( $application->getApplicantEmailAddress() ),
-				new PhoneNumber( $application->getApplicantPhoneNumber() ),
+				$this->newPersonName($application),
+				$this->newAddress($application),
+				new EmailAddress($application->getApplicantEmailAddress()),
+				new PhoneNumber($application->getApplicantPhoneNumber()),
 				$application->getApplicantDateOfBirth()
 			),
 			new Payment(
 				$application->getPaymentIntervalInMonths(),
-				Euro::newFromFloat( $application->getPaymentAmount() ),
-				$this->newPaymentMethod( $application )
+				Euro::newFromFloat($application->getPaymentAmount()),
+				$this->newPaymentMethod($application)
 			),
 			$application->needsModeration(),
 			$application->isCancelled(),
@@ -258,77 +258,77 @@ 
 		);
 	}
 
-	private function newPersonName( DoctrineApplication $application ): ApplicantName {
-		if ( empty( $application->getCompany() ) ) {
+	private function newPersonName(DoctrineApplication $application): ApplicantName {
+		if (empty($application->getCompany())) {
 			$personName = ApplicantName::newPrivatePersonName();
-			$personName->setFirstName( $application->getApplicantFirstName() );
-			$personName->setLastName( $application->getApplicantLastName() );
-			$personName->setSalutation( $application->getApplicantSalutation() );
-			$personName->setTitle( $application->getApplicantTitle() );
+			$personName->setFirstName($application->getApplicantFirstName());
+			$personName->setLastName($application->getApplicantLastName());
+			$personName->setSalutation($application->getApplicantSalutation());
+			$personName->setTitle($application->getApplicantTitle());
 		} else {
 			$personName = ApplicantName::newCompanyName();
-			$personName->setCompanyName( $application->getCompany() );
-			$personName->setSalutation( $application->getApplicantSalutation() );
+			$personName->setCompanyName($application->getCompany());
+			$personName->setSalutation($application->getApplicantSalutation());
 		}
 
 		return $personName->freeze()->assertNoNullFields();
 	}
 
-	private function newAddress( DoctrineApplication $application ): ApplicantAddress {
+	private function newAddress(DoctrineApplication $application): ApplicantAddress {
 		$address = new ApplicantAddress();
 
-		$address->setCity( $application->getCity() );
-		$address->setCountryCode( $application->getCountry() );
-		$address->setPostalCode( $application->getPostcode() );
-		$address->setStreetAddress( $application->getAddress() );
+		$address->setCity($application->getCity());
+		$address->setCountryCode($application->getCountry());
+		$address->setPostalCode($application->getPostcode());
+		$address->setStreetAddress($application->getAddress());
 
 		return $address->freeze()->assertNoNullFields();
 	}
 
-	private function newPaymentMethod( DoctrineApplication $application ): PaymentMethod {
-		if ( $application->getPaymentType() === PaymentType::DIRECT_DEBIT ) {
-			return new DirectDebitPayment( $this->newBankData( $application ) );
+	private function newPaymentMethod(DoctrineApplication $application): PaymentMethod {
+		if ($application->getPaymentType() === PaymentType::DIRECT_DEBIT) {
+			return new DirectDebitPayment($this->newBankData($application));
 		}
 
-		if ( $application->getPaymentType() === PaymentType::PAYPAL ) {
-			return new PayPalPayment( $this->newPayPalData( $application ) );
+		if ($application->getPaymentType() === PaymentType::PAYPAL) {
+			return new PayPalPayment($this->newPayPalData($application));
 		}
 
-		throw new \RuntimeException( 'Unsupported payment type' );
+		throw new \RuntimeException('Unsupported payment type');
 	}
 
-	private function newBankData( DoctrineApplication $application ): BankData {
+	private function newBankData(DoctrineApplication $application): BankData {
 		$bankData = new BankData();
 
-		$bankData->setAccount( $application->getPaymentBankAccount() );
-		$bankData->setBankCode( $application->getPaymentBankCode() );
-		$bankData->setBankName( $application->getPaymentBankName() );
-		$bankData->setBic( $application->getPaymentBic() );
-		$bankData->setIban( new Iban( $application->getPaymentIban() ) );
+		$bankData->setAccount($application->getPaymentBankAccount());
+		$bankData->setBankCode($application->getPaymentBankCode());
+		$bankData->setBankName($application->getPaymentBankName());
+		$bankData->setBic($application->getPaymentBic());
+		$bankData->setIban(new Iban($application->getPaymentIban()));
 
 		return $bankData->freeze()->assertNoNullFields();
 	}
 
-	private function newPayPalData( DoctrineApplication $application ): ?PayPalData {
+	private function newPayPalData(DoctrineApplication $application): ?PayPalData {
 		$data = $application->getDecodedData();
 
-		return ( new PayPalData() )
-			->setPayerId( $data['paypal_payer_id'] ?? '' )
-			->setSubscriberId( $data['paypal_subscr_id'] ?? '' )
-			->setPayerStatus( $data['paypal_payer_status'] ?? '' )
-			->setAddressStatus( $data['paypal_address_status'] ?? '' )
-			->setAmount( Euro::newFromString( $data['paypal_mc_gross'] ?? '0' ) )
-			->setCurrencyCode( $data['paypal_mc_currency'] ?? '' )
-			->setFee( Euro::newFromString( $data['paypal_mc_fee'] ?? '0' ) )
-			->setSettleAmount( Euro::newFromString( $data['paypal_settle_amount'] ?? '0' ) )
-			->setFirstName( $data['paypal_first_name'] ?? '' )
-			->setLastName( $data['paypal_last_name'] ?? '' )
-			->setAddressName( $data['paypal_address_name'] ?? '' )
-			->setPaymentId( $data['ext_payment_id'] ?? '' )
-			->setPaymentType( $data['ext_payment_type'] ?? '' )
-			->setPaymentStatus( $data['ext_payment_status'] ?? '' )
-			->setPaymentTimestamp( $data['ext_payment_timestamp'] ?? '' )
-			->setFirstPaymentDate( $data['first_payment_date'] ?? '' )
+		return (new PayPalData())
+			->setPayerId($data['paypal_payer_id'] ?? '')
+			->setSubscriberId($data['paypal_subscr_id'] ?? '')
+			->setPayerStatus($data['paypal_payer_status'] ?? '')
+			->setAddressStatus($data['paypal_address_status'] ?? '')
+			->setAmount(Euro::newFromString($data['paypal_mc_gross'] ?? '0'))
+			->setCurrencyCode($data['paypal_mc_currency'] ?? '')
+			->setFee(Euro::newFromString($data['paypal_mc_fee'] ?? '0'))
+			->setSettleAmount(Euro::newFromString($data['paypal_settle_amount'] ?? '0'))
+			->setFirstName($data['paypal_first_name'] ?? '')
+			->setLastName($data['paypal_last_name'] ?? '')
+			->setAddressName($data['paypal_address_name'] ?? '')
+			->setPaymentId($data['ext_payment_id'] ?? '')
+			->setPaymentType($data['ext_payment_type'] ?? '')
+			->setPaymentStatus($data['ext_payment_status'] ?? '')
+			->setPaymentTimestamp($data['ext_payment_timestamp'] ?? '')
+			->setFirstPaymentDate($data['first_payment_date'] ?? '')
 			->freeze()->assertNoNullFields();
 	}
 

Braces +4 added lines, -8 removed lines

@@ -43,8 +43,7 @@ 
 	public function storeApplication( Application $application ): void {
 		if ( $application->hasId() ) {
 			$this->updateApplication( $application );
-		}
-		else {
+		} else {
 			$this->insertApplication( $application );
 		}
 	}
@@ -56,8 +55,7 @@ 
 		try {
 			$this->entityManager->persist( $doctrineApplication );
 			$this->entityManager->flush();
-		}
-		catch ( ORMException $ex ) {
+		} catch ( ORMException $ex ) {
 			throw new StoreMembershipApplicationException( $ex );
 		}
 
@@ -76,8 +74,7 @@ 
 		try {
 			$this->entityManager->persist( $doctrineApplication );
 			$this->entityManager->flush();
-		}
-		catch ( ORMException $ex ) {
+		} catch ( ORMException $ex ) {
 			throw new StoreMembershipApplicationException( $ex );
 		}
 	}
@@ -209,8 +206,7 @@ 
 	public function getApplicationById( int $id ): ?Application {
 		try {
 			$application = $this->getDoctrineApplicationById( $id );
-		}
-		catch ( ORMException $ex ) {
+		} catch ( ORMException $ex ) {
 			throw new GetMembershipApplicationException( null, $ex );
 		}
 

contexts/MembershipContext/src/UseCases/ShowApplicationConfirmation/ShowApplicationConfirmationResponse.php

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\UseCases\ShowApplicationConfirmation;
 
@@ -19,11 +19,11 @@ 
 		return new self();
 	}
 
-	public static function newValidResponse( Application $membershipApplication, string $updateToken ): self {
-		return new self( $membershipApplication, $updateToken );
+	public static function newValidResponse(Application $membershipApplication, string $updateToken): self {
+		return new self($membershipApplication, $updateToken);
 	}
 
-	private function __construct( Application $membershipApplication = null, string $updateToken = null ) {
+	private function __construct(Application $membershipApplication = null, string $updateToken = null) {
 		$this->membershipApplication = $membershipApplication;
 		$this->updateToken = $updateToken;
 	}

contexts/MembershipContext/src/UseCases/ShowApplicationConfirmation/ShowAppConfirmationRequest.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\UseCases\ShowApplicationConfirmation;
 
@@ -12,7 +12,7 @@ 
 
 	private $applicationId;
 
-	public function __construct( int $applicationId ) {
+	public function __construct(int $applicationId) {
 		$this->applicationId = $applicationId;
 	}
 

contexts/MembershipContext/tests/Integration/DataAccess/DoctrineMembershipApplicationRepositoryTest.php

Spacing +77 added lines, -77 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\DataAccess;
 
@@ -40,141 +40,141 @@ 
 	}
 
 	public function testValidMembershipApplicationGetPersisted(): void {
-		$this->newRepository()->storeApplication( ValidMembershipApplication::newDomainEntity() );
+		$this->newRepository()->storeApplication(ValidMembershipApplication::newDomainEntity());
 
 		$expectedDoctrineEntity = ValidMembershipApplication::newDoctrineEntity();
-		$expectedDoctrineEntity->setId( self::MEMBERSHIP_APPLICATION_ID );
+		$expectedDoctrineEntity->setId(self::MEMBERSHIP_APPLICATION_ID);
 
-		$this->assertDoctrineEntityIsInDatabase( $expectedDoctrineEntity );
+		$this->assertDoctrineEntityIsInDatabase($expectedDoctrineEntity);
 	}
 
 	private function newRepository(): ApplicationRepository {
-		return new DoctrineApplicationRepository( $this->entityManager );
+		return new DoctrineApplicationRepository($this->entityManager);
 	}
 
-	private function assertDoctrineEntityIsInDatabase( DoctrineApplication $expected ): void {
-		$actual = $this->getApplicationFromDatabase( $expected->getId() );
+	private function assertDoctrineEntityIsInDatabase(DoctrineApplication $expected): void {
+		$actual = $this->getApplicationFromDatabase($expected->getId());
 
-		$this->assertNotNull( $actual->getCreationTime() );
-		$actual->setCreationTime( null );
+		$this->assertNotNull($actual->getCreationTime());
+		$actual->setCreationTime(null);
 
-		$this->assertEquals( $expected->getDecodedData(), $actual->getDecodedData() );
+		$this->assertEquals($expected->getDecodedData(), $actual->getDecodedData());
 
-		$this->assertEquals( $expected, $actual );
+		$this->assertEquals($expected, $actual);
 	}
 
-	private function getApplicationFromDatabase( int $id ): DoctrineApplication {
-		$applicationRepo = $this->entityManager->getRepository( DoctrineApplication::class );
-		$donation = $applicationRepo->find( $id );
-		$this->assertInstanceOf( DoctrineApplication::class, $donation );
+	private function getApplicationFromDatabase(int $id): DoctrineApplication {
+		$applicationRepo = $this->entityManager->getRepository(DoctrineApplication::class);
+		$donation = $applicationRepo->find($id);
+		$this->assertInstanceOf(DoctrineApplication::class, $donation);
 		return $donation;
 	}
 
 	public function testIdGetsAssigned(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 
-		$this->newRepository()->storeApplication( $application );
+		$this->newRepository()->storeApplication($application);
 
-		$this->assertSame( self::MEMBERSHIP_APPLICATION_ID, $application->getId() );
+		$this->assertSame(self::MEMBERSHIP_APPLICATION_ID, $application->getId());
 	}
 
 	public function testWhenPersistenceFails_domainExceptionIsThrown(): void {
 		$donation = ValidMembershipApplication::newDomainEntity();
 
-		$repository = new DoctrineApplicationRepository( ThrowingEntityManager::newInstance( $this ) );
+		$repository = new DoctrineApplicationRepository(ThrowingEntityManager::newInstance($this));
 
-		$this->expectException( StoreMembershipApplicationException::class );
-		$repository->storeApplication( $donation );
+		$this->expectException(StoreMembershipApplicationException::class);
+		$repository->storeApplication($donation);
 	}
 
 	public function testWhenMembershipApplicationInDatabase_itIsReturnedAsMatchingDomainEntity(): void {
-		$this->storeDoctrineApplication( ValidMembershipApplication::newDoctrineEntity() );
+		$this->storeDoctrineApplication(ValidMembershipApplication::newDoctrineEntity());
 
 		$expected = ValidMembershipApplication::newAutoConfirmedDomainEntity();
-		$expected->assignId( self::MEMBERSHIP_APPLICATION_ID );
+		$expected->assignId(self::MEMBERSHIP_APPLICATION_ID);
 
 		$this->assertEquals(
 			$expected,
-			$this->newRepository()->getApplicationById( self::MEMBERSHIP_APPLICATION_ID )
+			$this->newRepository()->getApplicationById(self::MEMBERSHIP_APPLICATION_ID)
 		);
 	}
 
-	private function storeDoctrineApplication( DoctrineApplication $application ): void {
-		$this->entityManager->persist( $application );
+	private function storeDoctrineApplication(DoctrineApplication $application): void {
+		$this->entityManager->persist($application);
 		$this->entityManager->flush();
 	}
 
 	public function testWhenEntityDoesNotExist_getEntityReturnsNull(): void {
-		$this->assertNull( $this->newRepository()->getApplicationById( self::ID_OF_APPLICATION_NOT_IN_DB ) );
+		$this->assertNull($this->newRepository()->getApplicationById(self::ID_OF_APPLICATION_NOT_IN_DB));
 	}
 
 	public function testWhenReadFails_domainExceptionIsThrown(): void {
-		$repository = new DoctrineApplicationRepository( ThrowingEntityManager::newInstance( $this ) );
+		$repository = new DoctrineApplicationRepository(ThrowingEntityManager::newInstance($this));
 
-		$this->expectException( GetMembershipApplicationException::class );
-		$repository->getApplicationById( self::ID_OF_APPLICATION_NOT_IN_DB );
+		$this->expectException(GetMembershipApplicationException::class);
+		$repository->getApplicationById(self::ID_OF_APPLICATION_NOT_IN_DB);
 	}
 
 	public function testWhenApplicationAlreadyExists_persistingCausesUpdate(): void {
 		$repository = $this->newRepository();
 		$originalApplication = ValidMembershipApplication::newDomainEntity();
 
-		$repository->storeApplication( $originalApplication );
+		$repository->storeApplication($originalApplication);
 
 		// It is important a new instance is created here to test "detached entity" handling
 		$newApplication = ValidMembershipApplication::newDomainEntity();
-		$newApplication->assignId( $originalApplication->getId() );
-		$newApplication->getApplicant()->changeEmailAddress( new EmailAddress( 'chuck.norris@always.win' ) );
+		$newApplication->assignId($originalApplication->getId());
+		$newApplication->getApplicant()->changeEmailAddress(new EmailAddress('chuck.norris@always.win'));
 
-		$repository->storeApplication( $newApplication );
+		$repository->storeApplication($newApplication);
 
-		$doctrineApplication = $this->getApplicationFromDatabase( $newApplication->getId() );
+		$doctrineApplication = $this->getApplicationFromDatabase($newApplication->getId());
 
-		$this->assertSame( 'chuck.norris@always.win', $doctrineApplication->getApplicantEmailAddress() );
+		$this->assertSame('chuck.norris@always.win', $doctrineApplication->getApplicantEmailAddress());
 	}
 
 	public function testWriteAndReadRoundtrip(): void {
 		$repository = $this->newRepository();
 		$application = ValidMembershipApplication::newAutoConfirmedDomainEntity();
 
-		$repository->storeApplication( $application );
+		$repository->storeApplication($application);
 
 		$this->assertEquals(
 			$application,
-			$repository->getApplicationById( self::MEMBERSHIP_APPLICATION_ID )
+			$repository->getApplicationById(self::MEMBERSHIP_APPLICATION_ID)
 		);
 	}
 
 	public function testWhenPersistingDeletedApplication_exceptionIsThrown(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
-		$application->assignId( self::ID_OF_APPLICATION_NOT_IN_DB );
+		$application->assignId(self::ID_OF_APPLICATION_NOT_IN_DB);
 
 		$repository = $this->newRepository();
 
-		$this->expectException( StoreMembershipApplicationException::class );
-		$repository->storeApplication( $application );
+		$this->expectException(StoreMembershipApplicationException::class);
+		$repository->storeApplication($application);
 	}
 
 	public function testWhenPersistingApplicationWithModerationFlag_doctrineApplicationHasFlag(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->markForModeration();
 
-		$this->newRepository()->storeApplication( $application );
-		$doctrineApplication = $this->getApplicationFromDatabase( $application->getId() );
+		$this->newRepository()->storeApplication($application);
+		$doctrineApplication = $this->getApplicationFromDatabase($application->getId());
 
-		$this->assertTrue( $doctrineApplication->needsModeration() );
-		$this->assertFalse( $doctrineApplication->isCancelled() );
+		$this->assertTrue($doctrineApplication->needsModeration());
+		$this->assertFalse($doctrineApplication->isCancelled());
 	}
 
 	public function testWhenPersistingApplicationWithCancelledFlag_doctrineApplicationHasFlag(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->cancel();
 
-		$this->newRepository()->storeApplication( $application );
-		$doctrineApplication = $this->getApplicationFromDatabase( $application->getId() );
+		$this->newRepository()->storeApplication($application);
+		$doctrineApplication = $this->getApplicationFromDatabase($application->getId());
 
-		$this->assertFalse( $doctrineApplication->needsModeration() );
-		$this->assertTrue( $doctrineApplication->isCancelled() );
+		$this->assertFalse($doctrineApplication->needsModeration());
+		$this->assertTrue($doctrineApplication->isCancelled());
 	}
 
 	public function testWhenPersistingCancelledModerationApplication_doctrineApplicationHasFlags(): void {
@@ -182,76 +182,76 @@ 
 		$application->markForModeration();
 		$application->cancel();
 
-		$this->newRepository()->storeApplication( $application );
-		$doctrineApplication = $this->getApplicationFromDatabase( $application->getId() );
+		$this->newRepository()->storeApplication($application);
+		$doctrineApplication = $this->getApplicationFromDatabase($application->getId());
 
-		$this->assertTrue( $doctrineApplication->needsModeration() );
-		$this->assertTrue( $doctrineApplication->isCancelled() );
+		$this->assertTrue($doctrineApplication->needsModeration());
+		$this->assertTrue($doctrineApplication->isCancelled());
 	}
 
 	public function testGivenDoctrineApplicationWithModerationAndCancelled_domainEntityHasFlags(): void {
 		$doctrineApplication = ValidMembershipApplication::newDoctrineEntity();
-		$doctrineApplication->setStatus( DoctrineApplication::STATUS_CANCELED + DoctrineApplication::STATUS_MODERATION );
+		$doctrineApplication->setStatus(DoctrineApplication::STATUS_CANCELED + DoctrineApplication::STATUS_MODERATION);
 
-		$this->storeDoctrineApplication( $doctrineApplication );
-		$application = $this->newRepository()->getApplicationById( $doctrineApplication->getId() );
+		$this->storeDoctrineApplication($doctrineApplication);
+		$application = $this->newRepository()->getApplicationById($doctrineApplication->getId());
 
-		$this->assertTrue( $application->needsModeration() );
-		$this->assertTrue( $application->isCancelled() );
+		$this->assertTrue($application->needsModeration());
+		$this->assertTrue($application->isCancelled());
 	}
 
 	public function testGivenDoctrineApplicationWithModerationFlag_domainEntityHasFlag(): void {
 		$doctrineApplication = ValidMembershipApplication::newDoctrineEntity();
-		$doctrineApplication->setStatus( DoctrineApplication::STATUS_MODERATION );
+		$doctrineApplication->setStatus(DoctrineApplication::STATUS_MODERATION);
 
-		$this->storeDoctrineApplication( $doctrineApplication );
-		$application = $this->newRepository()->getApplicationById( $doctrineApplication->getId() );
+		$this->storeDoctrineApplication($doctrineApplication);
+		$application = $this->newRepository()->getApplicationById($doctrineApplication->getId());
 
-		$this->assertTrue( $application->needsModeration() );
-		$this->assertFalse( $application->isCancelled() );
+		$this->assertTrue($application->needsModeration());
+		$this->assertFalse($application->isCancelled());
 	}
 
 	public function testGivenDoctrineApplicationWithCancelledFlag_domainEntityHasFlag(): void {
 		$doctrineApplication = ValidMembershipApplication::newDoctrineEntity();
-		$doctrineApplication->setStatus( DoctrineApplication::STATUS_CANCELED );
+		$doctrineApplication->setStatus(DoctrineApplication::STATUS_CANCELED);
 
-		$this->storeDoctrineApplication( $doctrineApplication );
-		$application = $this->newRepository()->getApplicationById( $doctrineApplication->getId() );
+		$this->storeDoctrineApplication($doctrineApplication);
+		$application = $this->newRepository()->getApplicationById($doctrineApplication->getId());
 
-		$this->assertFalse( $application->needsModeration() );
-		$this->assertTrue( $application->isCancelled() );
+		$this->assertFalse($application->needsModeration());
+		$this->assertTrue($application->isCancelled());
 	}
 
 	public function testGivenDoctrineApplicationWithCancelledFlag_initialStatusIsPreserved(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->cancel();
 
-		$this->newRepository()->storeApplication( $application );
-		$doctrineApplication = $this->getApplicationFromDatabase( $application->getId() );
+		$this->newRepository()->storeApplication($application);
+		$doctrineApplication = $this->getApplicationFromDatabase($application->getId());
 
-		$this->assertSame( DoctrineApplication::STATUS_CONFIRMED, $doctrineApplication->getDataObject()->getPreservedStatus() );
+		$this->assertSame(DoctrineApplication::STATUS_CONFIRMED, $doctrineApplication->getDataObject()->getPreservedStatus());
 	}
 
 	public function testGivenCompanyApplication_companyNameIsPersisted(): void {
-		$this->newRepository()->storeApplication( ValidMembershipApplication::newCompanyApplication() );
+		$this->newRepository()->storeApplication(ValidMembershipApplication::newCompanyApplication());
 
 		$expectedDoctrineEntity = ValidMembershipApplication::newDoctrineCompanyEntity();
-		$expectedDoctrineEntity->setId( self::MEMBERSHIP_APPLICATION_ID );
+		$expectedDoctrineEntity->setId(self::MEMBERSHIP_APPLICATION_ID);
 
-		$this->assertDoctrineEntityIsInDatabase( $expectedDoctrineEntity );
+		$this->assertDoctrineEntityIsInDatabase($expectedDoctrineEntity);
 	}
 
 	public function testReadingPurgedApplication_purgedExceptionIsThrown(): void {
-		$this->storeDoctrineApplication( $this->newPurgedApplication() );
+		$this->storeDoctrineApplication($this->newPurgedApplication());
 
-		$this->expectException( ApplicationPurgedException::class );
+		$this->expectException(ApplicationPurgedException::class);
 
-		$this->newRepository()->getApplicationById( self::MEMBERSHIP_APPLICATION_ID );
+		$this->newRepository()->getApplicationById(self::MEMBERSHIP_APPLICATION_ID);
 	}
 
 	private function newPurgedApplication(): DoctrineApplication {
 		$application = ValidMembershipApplication::newDoctrineEntity();
-		$application->setBackup( new \DateTime() );
+		$application->setBackup(new \DateTime());
 		return $application;
 	}
 

contexts/MembershipContext/src/UseCases/ShowApplicationConfirmation/ShowApplicationConfirmationUseCase.php

Spacing +12 added lines, -12 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\UseCases\ShowApplicationConfirmation;
 
@@ -21,39 +21,39 @@ 
 	private $repository;
 	private $tokenFetcher;
 
-	public function __construct( ShowApplicationConfirmationPresenter $presenter, ApplicationAuthorizer $authorizer,
-		ApplicationRepository $repository, ApplicationTokenFetcher $tokenFetcher ) {
+	public function __construct(ShowApplicationConfirmationPresenter $presenter, ApplicationAuthorizer $authorizer,
+		ApplicationRepository $repository, ApplicationTokenFetcher $tokenFetcher) {
 		$this->presenter = $presenter;
 		$this->authorizer = $authorizer;
 		$this->repository = $repository;
 		$this->tokenFetcher = $tokenFetcher;
 	}
 
-	public function showConfirmation( ShowAppConfirmationRequest $request ): void {
-		if ( !$this->authorizer->canAccessApplication( $request->getApplicationId() ) ) {
+	public function showConfirmation(ShowAppConfirmationRequest $request): void {
+		if (!$this->authorizer->canAccessApplication($request->getApplicationId())) {
 			// TODO: show access error
-			$this->presenter->presentResponseModel( ShowApplicationConfirmationResponse::newNotAllowedResponse() );
+			$this->presenter->presentResponseModel(ShowApplicationConfirmationResponse::newNotAllowedResponse());
 			return;
 		}
 
 		try {
-			$application = $this->repository->getApplicationById( $request->getApplicationId() );
+			$application = $this->repository->getApplicationById($request->getApplicationId());
 		}
-		catch ( ApplicationPurgedException $ex ) {
+		catch (ApplicationPurgedException $ex) {
 			// TODO: show application was purged
-			$this->presenter->presentResponseModel( ShowApplicationConfirmationResponse::newNotAllowedResponse() );
+			$this->presenter->presentResponseModel(ShowApplicationConfirmationResponse::newNotAllowedResponse());
 			return;
 		}
-		catch ( GetMembershipApplicationException $ex ) {
+		catch (GetMembershipApplicationException $ex) {
 			// TODO: show technical error
-			$this->presenter->presentResponseModel( ShowApplicationConfirmationResponse::newNotAllowedResponse() );
+			$this->presenter->presentResponseModel(ShowApplicationConfirmationResponse::newNotAllowedResponse());
 			return;
 		}
 
 		$this->presenter->presentResponseModel(
 			ShowApplicationConfirmationResponse::newValidResponse(
 				$application, // TODO: use DTO instead of Entity (currently violates the architecture)
-				$this->tokenFetcher->getTokens( $request->getApplicationId() )->getUpdateToken()
+				$this->tokenFetcher->getTokens($request->getApplicationId())->getUpdateToken()
 			)
 		);
 	}

Braces +2 added lines, -4 removed lines

@@ -38,13 +38,11 @@
 
 		try {
 			$application = $this->repository->getApplicationById( $request->getApplicationId() );
-		}
-		catch ( ApplicationPurgedException $ex ) {
+		} catch ( ApplicationPurgedException $ex ) {
 			// TODO: show application was purged
 			$this->presenter->presentResponseModel( ShowApplicationConfirmationResponse::newNotAllowedResponse() );
 			return;
-		}
-		catch ( GetMembershipApplicationException $ex ) {
+		} catch ( GetMembershipApplicationException $ex ) {
 			// TODO: show technical error
 			$this->presenter->presentResponseModel( ShowApplicationConfirmationResponse::newNotAllowedResponse() );
 			return;

contexts/MembershipContext/tests/Integration/UseCases/ShowApplicationConfirmation/ShowApplicationConfirmationUseCaseTest.php

Spacing +11 added lines, -11 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\UseCases\ShowApplicationConfirmation;
 
@@ -54,11 +54,11 @@ 
 	public function testWhenExceptionIsThrown_failureResponseIsReturned() {
 		$this->repository->throwOnRead();
 
-		$request = new ShowAppConfirmationRequest( self::APPLICATION_ID );
-		$this->newUseCase()->showConfirmation( $request );
+		$request = new ShowAppConfirmationRequest(self::APPLICATION_ID);
+		$this->newUseCase()->showConfirmation($request);
 
-		$this->assertFalse( $this->presenter->getResponseModel()->accessIsPermitted() );
-		$this->assertNull( $this->presenter->getResponseModel()->getApplication() );
+		$this->assertFalse($this->presenter->getResponseModel()->accessIsPermitted());
+		$this->assertNull($this->presenter->getResponseModel()->getApplication());
 	}
 
 	private function newUseCase(): ShowApplicationConfirmationUseCase {
@@ -71,19 +71,19 @@ 
 	}
 
 	public function testHappyPath_successResponseWithApplicationIsReturned() {
-		$this->repository->storeApplication( $this->newApplication() );
+		$this->repository->storeApplication($this->newApplication());
 
-		$request = new ShowAppConfirmationRequest( self::APPLICATION_ID );
-		$this->newUseCase()->showConfirmation( $request );
+		$request = new ShowAppConfirmationRequest(self::APPLICATION_ID);
+		$this->newUseCase()->showConfirmation($request);
 
-		$this->assertTrue( $this->presenter->getResponseModel()->accessIsPermitted() );
-		$this->assertSame( self::APPLICATION_ID, $this->presenter->getResponseModel()->getApplication()->getId() );
+		$this->assertTrue($this->presenter->getResponseModel()->accessIsPermitted());
+		$this->assertSame(self::APPLICATION_ID, $this->presenter->getResponseModel()->getApplication()->getId());
 	}
 
 	private function newApplication(): Application {
 		$application = ValidMembershipApplication::newDomainEntity();
 
-		$application->assignId( self::APPLICATION_ID );
+		$application->assignId(self::APPLICATION_ID);
 
 		return $application;
 	}

contexts/MembershipContext/tests/Integration/UseCases/ShowApplicationConfirmation/FakeShowApplicationConfirmationPresenter.php

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\UseCases\ShowApplicationConfirmation;
 
@@ -15,9 +15,9 @@ 
 
 	private $responseModel;
 
-	public function presentResponseModel( ShowApplicationConfirmationResponse $response ): void {
-		if ( $this->responseModel !== null ) {
-			throw new \RuntimeException( 'Presenter should only be invoked once' );
+	public function presentResponseModel(ShowApplicationConfirmationResponse $response): void {
+		if ($this->responseModel !== null) {
+			throw new \RuntimeException('Presenter should only be invoked once');
 		}
 
 		$this->responseModel = $response;