View GitHub Repository FundraisingFrontend

Schedule Inspection
Completed
Pull Request — master (#1339)
by Gabriel
27:41
created

2,503 -11 Covered Lines

2,695 -7 Total Lines

92.9 % -0.166% Code Coverage

PHP Classes Changes

 
 ⇢
97.25%
ApplyForMembershipController added
79.31%
 ↘
68.97%
 ChoiceFactory got worse
100%
 ↘
95.24%
 ValidateFeeController got worse
93.9%
 ↘
93.86%
 Routes got worse
97.35%
 ↛
 
 ApplyForMembershipHandler removed

CRAP Changes

 
 ⇢
4.0961
ApplyForMembershipController::applyForMembership() added
 
 ⇢
3.0067
ApplyForMembershipController::newHttpResponse() added
 
 ⇢
3
ApplyForMembershipController::isSubmissionAllowed(... added
 
 ⇢
2
ApplyForMembershipController::createMembershipRequ... added
 
 ⇢
1
ApplyForMembershipController::callUseCase() added
 
 ⇢
1
ApplyForMembershipController::createBakData() added
 
 ⇢
1
ApplyForMembershipController::newDirectDebitRespon... added
 
 ⇢
1
ApplyForMembershipController::logSelectedBuckets() added
 
 ⇢
1
ApplyForMembershipController::newPayPalResponse() added
 
 ⇢
1
ApplyForMembershipController::addCookie() added
⋮ view more  
16.0581
 ↗
16.0592
 Routes::initializeRoutes() got worse
1
 ↗
2.0185
 ValidateFeeController::newJsonErrorResponse() got worse
4.25
 ↗
7.9062
 ChoiceFactory::isUsabilityImproved() got worse
4.128
 ↛
 
 ApplyForMembershipHandler::handle() removed
3.0067
 ↛
 
 ApplyForMembershipHandler::newHttpResponse() removed
3
 ↛
 
 ApplyForMembershipHandler::isSubmissionAllowed() removed
2
 ↛
 
 ApplyForMembershipHandler::createMembershipRequest... removed
1
 ↛
 
 ApplyForMembershipHandler::__construct() removed
1
 ↛
 
 ApplyForMembershipHandler::createBakData() removed
1
 ↛
 
 ApplyForMembershipHandler::addFeeToRequestModel() removed
1
 ↛
 
 ApplyForMembershipHandler::newPayPalResponse() removed
1
 ↛
 
 ApplyForMembershipHandler::addCookie() removed
1
 ↛
 
 ApplyForMembershipHandler::filterAutofillCommas() removed
⋮ view more