wmde / FundraisingFrontend

contexts/DonationContext/tests/Integration/UseCases/SofortPaymentNotification/SofortPaymentNotificationUseCaseTest.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use WMDE\Fundraising\Frontend\DonationContext\Tests\Fixtures\FakeDonationRepository;
 use WMDE\Fundraising\Frontend\DonationContext\Tests\Fixtures\SucceedingDonationAuthorizer;
 use WMDE\Fundraising\Frontend\DonationContext\UseCases\SofortPaymentNotification\SofortPaymentNotificationUseCase;
-use WMDE\Fundraising\Frontend\PaymentContext\RequestModel\SofortNotificationRequest;
 use WMDE\Fundraising\Frontend\Tests\Fixtures\ThrowingEntityManager;
 
 /**

Spacing +36 added lines, -36 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonationContext\Tests\Integration\UseCases\SofortPaymentNotification;
 
@@ -25,23 +25,23 @@ 
 
 	public function testWhenRepositoryThrowsException_errorResponseIsReturned(): void {
 		$useCase = new SofortPaymentNotificationUseCase(
-			new DoctrineDonationRepository( ThrowingEntityManager::newInstance( $this ) ),
+			new DoctrineDonationRepository(ThrowingEntityManager::newInstance($this)),
 			new SucceedingDonationAuthorizer(),
 			$this->getMailer()
 		);
 
 		$request = ValidSofortNotificationRequest::newInstantPayment();
 
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
-		$this->assertTrue( $response->hasErrors() );
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
+		$this->assertTrue($response->hasErrors());
 	}
 
 	/**
 	 * @return DonationConfirmationMailer|\PHPUnit_Framework_MockObject_MockObject
 	 */
 	private function getMailer(): DonationConfirmationMailer {
-		return $this->createMock( DonationConfirmationMailer::class );
+		return $this->createMock(DonationConfirmationMailer::class);
 	}
 
 	public function testWhenNotificationIsForNonExistingDonation_unhandledResponseIsReturned(): void {
@@ -51,14 +51,14 @@ 
 			$this->getMailer()
 		);
 
-		$request = ValidSofortNotificationRequest::newInstantPayment( 4711 );
+		$request = ValidSofortNotificationRequest::newInstantPayment(4711);
 
-		$this->assertFalse( $useCase->handleNotification( $request )->notificationWasHandled() );
+		$this->assertFalse($useCase->handleNotification($request)->notificationWasHandled());
 	}
 
 	public function testWhenAuthorizationFails_unhandledResponseIsReturned(): void {
 		$fakeRepository = new FakeDonationRepository();
-		$fakeRepository->storeDonation( ValidDonation::newIncompleteSofortDonation() );
+		$fakeRepository->storeDonation(ValidDonation::newIncompleteSofortDonation());
 
 		$useCase = new SofortPaymentNotificationUseCase(
 			$fakeRepository,
@@ -68,12 +68,12 @@ 
 
 		$request = ValidSofortNotificationRequest::newInstantPayment();
 
-		$this->assertFalse( $useCase->handleNotification( $request )->notificationWasHandled() );
+		$this->assertFalse($useCase->handleNotification($request)->notificationWasHandled());
 	}
 
 	public function testWhenAuthorizationSucceeds_successResponseIsReturned(): void {
 		$fakeRepository = new FakeDonationRepository();
-		$fakeRepository->storeDonation( ValidDonation::newIncompleteSofortDonation() );
+		$fakeRepository->storeDonation(ValidDonation::newIncompleteSofortDonation());
 
 		$useCase = new SofortPaymentNotificationUseCase(
 			$fakeRepository,
@@ -83,11 +83,11 @@ 
 
 		$request = ValidSofortNotificationRequest::newInstantPayment();
 
-		$this->assertTrue( $useCase->handleNotification( $request )->notificationWasHandled() );
+		$this->assertTrue($useCase->handleNotification($request)->notificationWasHandled());
 	}
 
 	public function testWhenAuthorizationSucceeds_donationIsStored(): void {
-		$repositorySpy = new DonationRepositorySpy( ValidDonation::newIncompleteSofortDonation() );
+		$repositorySpy = new DonationRepositorySpy(ValidDonation::newIncompleteSofortDonation());
 
 		$useCase = new SofortPaymentNotificationUseCase(
 			$repositorySpy,
@@ -97,13 +97,13 @@ 
 
 		$request = ValidSofortNotificationRequest::newInstantPayment();
 
-		$this->assertTrue( $useCase->handleNotification( $request )->notificationWasHandled() );
-		$this->assertCount( 1, $repositorySpy->getStoreDonationCalls() );
+		$this->assertTrue($useCase->handleNotification($request)->notificationWasHandled());
+		$this->assertCount(1, $repositorySpy->getStoreDonationCalls());
 	}
 
 	public function testWhenAuthorizationSucceeds_donationIsStillPromised(): void {
 		$donation = ValidDonation::newIncompleteSofortDonation();
-		$repository = new FakeDonationRepository( $donation );
+		$repository = new FakeDonationRepository($donation);
 
 		$useCase = new SofortPaymentNotificationUseCase(
 			$repository,
@@ -113,13 +113,13 @@ 
 
 		$request = ValidSofortNotificationRequest::newInstantPayment();
 
-		$this->assertTrue( $useCase->handleNotification( $request )->notificationWasHandled() );
-		$this->assertSame( Donation::STATUS_PROMISE, $repository->getDonationById( $donation->getId() )->getStatus() );
+		$this->assertTrue($useCase->handleNotification($request)->notificationWasHandled());
+		$this->assertSame(Donation::STATUS_PROMISE, $repository->getDonationById($donation->getId())->getStatus());
 	}
 
 	public function testWhenPaymentTypeIsNonSofort_unhandledResponseIsReturned(): void {
 		$fakeRepository = new FakeDonationRepository();
-		$fakeRepository->storeDonation( ValidDonation::newDirectDebitDonation() );
+		$fakeRepository->storeDonation(ValidDonation::newDirectDebitDonation());
 
 		$useCase = new SofortPaymentNotificationUseCase(
 			$fakeRepository,
@@ -129,19 +129,19 @@ 
 
 		$request = ValidSofortNotificationRequest::newInstantPayment();
 
-		$this->assertFalse( $useCase->handleNotification( $request )->notificationWasHandled() );
+		$this->assertFalse($useCase->handleNotification($request)->notificationWasHandled());
 	}
 
 	public function testWhenAuthorizationSucceeds_confirmationMailIsSent(): void {
 		$donation = ValidDonation::newIncompleteSofortDonation();
 		$fakeRepository = new FakeDonationRepository();
-		$fakeRepository->storeDonation( $donation );
+		$fakeRepository->storeDonation($donation);
 
 		$mailer = $this->getMailer();
 		$mailer
-			->expects( $this->once() )
-			->method( 'sendConfirmationMailFor' )
-			->with( $donation );
+			->expects($this->once())
+			->method('sendConfirmationMailFor')
+			->with($donation);
 
 		$useCase = new SofortPaymentNotificationUseCase(
 			$fakeRepository,
@@ -149,14 +149,14 @@ 
 			$mailer
 		);
 
-		$request = ValidSofortNotificationRequest::newInstantPayment( 1 );
-		$this->assertTrue( $useCase->handleNotification( $request )->notificationWasHandled() );
+		$request = ValidSofortNotificationRequest::newInstantPayment(1);
+		$this->assertTrue($useCase->handleNotification($request)->notificationWasHandled());
 
 	}
 
 	public function testWhenSendingConfirmationMailFails_handlerReturnsTrue(): void {
 		$fakeRepository = new FakeDonationRepository();
-		$fakeRepository->storeDonation( ValidDonation::newIncompleteSofortDonation() );
+		$fakeRepository->storeDonation(ValidDonation::newIncompleteSofortDonation());
 
 		$useCase = new SofortPaymentNotificationUseCase(
 			$fakeRepository,
@@ -166,7 +166,7 @@ 
 
 		$request = ValidSofortNotificationRequest::newInstantPayment();
 
-		$this->assertTrue( $useCase->handleNotification( $request )->notificationWasHandled() );
+		$this->assertTrue($useCase->handleNotification($request)->notificationWasHandled());
 	}
 
 	/**
@@ -175,9 +175,9 @@ 
 	private function newThrowingMailer() {
 		$mailer = $this->getMailer();
 
-		$mailer->expects( $this->once() )
-			->method( 'sendConfirmationMailFor' )
-			->willThrowException( new \RuntimeException( 'Oh noes!' ) );
+		$mailer->expects($this->once())
+			->method('sendConfirmationMailFor')
+			->willThrowException(new \RuntimeException('Oh noes!'));
 
 		return $mailer;
 	}
@@ -185,7 +185,7 @@ 
 	public function testGivenSetConfirmedAtForBookedDonation_unhandledResponseIsReturned(): void {
 
 		$fakeRepository = new FakeDonationRepository();
-		$fakeRepository->storeDonation( ValidDonation::newCompletedSofortDonation() );
+		$fakeRepository->storeDonation(ValidDonation::newCompletedSofortDonation());
 
 		$useCase = new SofortPaymentNotificationUseCase(
 			$fakeRepository,
@@ -195,10 +195,10 @@ 
 
 		$request = ValidSofortNotificationRequest::newInstantPayment();
 
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
-		$this->assertFalse( $response->hasErrors() );
-		$this->assertSame( 'Duplicate notification', $response->getContext()['message'] );
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
+		$this->assertFalse($response->hasErrors());
+		$this->assertSame('Duplicate notification', $response->getContext()['message']);
 	}
 
 }

contexts/DonationContext/src/UseCases/SofortPaymentNotification/SofortPaymentNotificationUseCase.php

Spacing +32 added lines, -32 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonationContext\UseCases\SofortPaymentNotification;
 
@@ -22,77 +22,77 @@ 
 	private $authorizationService;
 	private $mailer;
 
-	public function __construct( DonationRepository $repository, DonationAuthorizer $authorizationService,
-								 DonationConfirmationMailer $mailer ) {
+	public function __construct(DonationRepository $repository, DonationAuthorizer $authorizationService,
+								 DonationConfirmationMailer $mailer) {
 		$this->repository = $repository;
 		$this->authorizationService = $authorizationService;
 		$this->mailer = $mailer;
 	}
 
-	public function handleNotification( SofortNotificationRequest $request ): SofortNotificationResponse {
+	public function handleNotification(SofortNotificationRequest $request): SofortNotificationResponse {
 		try {
-			$donation = $this->repository->getDonationById( $request->getDonationId() );
-		} catch ( GetDonationException $ex ) {
-			return $this->createFailureResponse( $ex );
+			$donation = $this->repository->getDonationById($request->getDonationId());
+		} catch (GetDonationException $ex) {
+			return $this->createFailureResponse($ex);
 		}
 
-		if ( $donation === null ) {
-			return $this->createFailureResponse( new RuntimeException( 'Donation not found' ) );
+		if ($donation === null) {
+			return $this->createFailureResponse(new RuntimeException('Donation not found'));
 		}
 
-		return $this->handleRequestForDonation( $request, $donation );
+		return $this->handleRequestForDonation($request, $donation);
 	}
 
-	private function handleRequestForDonation( SofortNotificationRequest $request, Donation $donation ): SofortNotificationResponse {
+	private function handleRequestForDonation(SofortNotificationRequest $request, Donation $donation): SofortNotificationResponse {
 		$paymentMethod = $donation->getPayment()->getPaymentMethod();
 
-		if ( !( $paymentMethod instanceof SofortPayment ) ) {
-			return $this->createUnhandledResponse( 'Trying to handle notification for non-sofort donation' );
+		if (!($paymentMethod instanceof SofortPayment)) {
+			return $this->createUnhandledResponse('Trying to handle notification for non-sofort donation');
 		}
 
-		if ( !$this->authorizationService->systemCanModifyDonation( $donation->getId() ) ) {
-			return $this->createUnhandledResponse( 'Wrong access code for donation' );
+		if (!$this->authorizationService->systemCanModifyDonation($donation->getId())) {
+			return $this->createUnhandledResponse('Wrong access code for donation');
 		}
 
-		if ( $paymentMethod->isConfirmedPayment() ) {
-			return $this->createUnhandledResponse( 'Duplicate notification' );
+		if ($paymentMethod->isConfirmedPayment()) {
+			return $this->createUnhandledResponse('Duplicate notification');
 		}
 
-		$paymentMethod->setConfirmedAt( $request->getTime() );
+		$paymentMethod->setConfirmedAt($request->getTime());
 
 		try {
-			$this->repository->storeDonation( $donation );
+			$this->repository->storeDonation($donation);
 		}
-		catch ( StoreDonationException $ex ) {
-			return $this->createFailureResponse( $ex );
+		catch (StoreDonationException $ex) {
+			return $this->createFailureResponse($ex);
 		}
 
-		$this->sendConfirmationEmailFor( $donation );
+		$this->sendConfirmationEmailFor($donation);
 
 		return SofortNotificationResponse::newSuccessResponse();
 	}
 
-	private function createUnhandledResponse( string $reason ): SofortNotificationResponse {
-		return SofortNotificationResponse::newUnhandledResponse( [
+	private function createUnhandledResponse(string $reason): SofortNotificationResponse {
+		return SofortNotificationResponse::newUnhandledResponse([
 			'message' => $reason
-		] );
+		]);
 	}
 
-	private function sendConfirmationEmailFor( Donation $donation ): void {
-		if ( $donation->getDonor() !== null ) {
+	private function sendConfirmationEmailFor(Donation $donation): void {
+		if ($donation->getDonor() !== null) {
 			try {
-				$this->mailer->sendConfirmationMailFor( $donation );
-			} catch ( RuntimeException $ex ) {
+				$this->mailer->sendConfirmationMailFor($donation);
+			} catch (RuntimeException $ex) {
 				// no need to re-throw or return false, this is not a fatal error, only a minor inconvenience
 			}
 		}
 	}
 
-	private function createFailureResponse( RuntimeException $ex ): SofortNotificationResponse {
-		return SofortNotificationResponse::newFailureResponse( [
+	private function createFailureResponse(RuntimeException $ex): SofortNotificationResponse {
+		return SofortNotificationResponse::newFailureResponse([
 			'message' => $ex->getMessage(),
 			'stackTrace' => $ex->getTraceAsString()
-		] );
+		]);
 	}
 
 }

Braces +1 added lines, -2 removed lines

@@ -62,8 +62,7 @@
 
 		try {
 			$this->repository->storeDonation( $donation );
-		}
-		catch ( StoreDonationException $ex ) {
+		} catch ( StoreDonationException $ex ) {
 			return $this->createFailureResponse( $ex );
 		}
 

contexts/PaymentContext/src/RequestModel/SofortNotificationRequest.php

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\RequestModel;
 
@@ -21,20 +21,20 @@ 
 	 */
 	private $time;
 
-	public function getDonationId(): ?int {
+	public function getDonationId(): ? int {
 		return $this->donationId;
 	}
 
-	public function setDonationId( int $donationId ): self {
+	public function setDonationId(int $donationId): self {
 		$this->donationId = $donationId;
 		return $this;
 	}
 
-	public function getTransactionId(): ?string {
+	public function getTransactionId(): ? string {
 		return $this->transactionId;
 	}
 
-	public function setTransactionId( string $transactionId ): self {
+	public function setTransactionId(string $transactionId): self {
 		$this->transactionId = $transactionId;
 		return $this;
 	}
@@ -43,7 +43,7 @@ 
 		return $this->time;
 	}
 
-	public function setTime( DateTime $time ): self {
+	public function setTime(DateTime $time): self {
 		$this->time = $time;
 		return $this;
 	}

app/RouteHandlers/SofortNotificationHandler.php

Spacing +25 added lines, -25 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\App\RouteHandlers;
 
@@ -22,61 +22,61 @@ 
 	 */
 	private $request;
 
-	public function __construct( FunFunFactory $ffFactory ) {
+	public function __construct(FunFunFactory $ffFactory) {
 		$this->ffFactory = $ffFactory;
 	}
 
-	public function handle( Request $request ): Response {
+	public function handle(Request $request): Response {
 		$this->request = $request;
 
 		$useCaseRequest = $this->newUseCaseRequest();
 
-		if ( $useCaseRequest === null ) {
-			$this->logWebRequest( [ 'message' => 'Bad notification time' ], LogLevel::ERROR );
-			return new Response( 'Bad request', Response::HTTP_BAD_REQUEST );
+		if ($useCaseRequest === null) {
+			$this->logWebRequest(['message' => 'Bad notification time'], LogLevel::ERROR);
+			return new Response('Bad request', Response::HTTP_BAD_REQUEST);
 		}
 
-		$response = $this->newUseCase()->handleNotification( $useCaseRequest );
+		$response = $this->newUseCase()->handleNotification($useCaseRequest);
 
-		$this->logResponseIfNeeded( $response );
+		$this->logResponseIfNeeded($response);
 
-		if ( $response->hasErrors() ) {
-			return new Response( 'Error', Response::HTTP_INTERNAL_SERVER_ERROR );
+		if ($response->hasErrors()) {
+			return new Response('Error', Response::HTTP_INTERNAL_SERVER_ERROR);
 		}
 
-		if ( $response->notificationWasHandled() ) {
-			return new Response( 'Ok', Response::HTTP_OK );
+		if ($response->notificationWasHandled()) {
+			return new Response('Ok', Response::HTTP_OK);
 		}
 
-		return new Response( 'Bad request', Response::HTTP_BAD_REQUEST );
+		return new Response('Bad request', Response::HTTP_BAD_REQUEST);
 	}
 
 	private function newUseCase(): SofortPaymentNotificationUseCase {
-		return $this->ffFactory->newHandleSofortPaymentNotificationUseCase( $this->request->query->get( 'updateToken' ) );
+		return $this->ffFactory->newHandleSofortPaymentNotificationUseCase($this->request->query->get('updateToken'));
 	}
 
-	private function newUseCaseRequest(): ?SofortNotificationRequest {
+	private function newUseCaseRequest(): ? SofortNotificationRequest {
 		$time = $this->getTimeFromRequest();
 
-		if ( $time === false ) {
+		if ($time === false) {
 			return null;
 		}
 
 		$useCaseRequest = new SofortNotificationRequest();
 
-		$useCaseRequest->setTime( $time );
-		$useCaseRequest->setDonationId( $this->request->query->getInt( 'id' ) );
-		$useCaseRequest->setTransactionId( $this->request->request->get( 'transaction', '' ) );
+		$useCaseRequest->setTime($time);
+		$useCaseRequest->setDonationId($this->request->query->getInt('id'));
+		$useCaseRequest->setTransactionId($this->request->request->get('transaction', ''));
 
 		return $useCaseRequest;
 	}
 
 	private function getTimeFromRequest() {
-		return DateTime::createFromFormat( DateTime::ATOM, $this->request->request->get( 'time', '' ) );
+		return DateTime::createFromFormat(DateTime::ATOM, $this->request->request->get('time', ''));
 	}
 
-	private function logResponseIfNeeded( SofortNotificationResponse $response ) {
-		if ( $response->notificationWasHandled() ) {
+	private function logResponseIfNeeded(SofortNotificationResponse $response) {
+		if ($response->notificationWasHandled()) {
 			return;
 		}
 
@@ -86,13 +86,13 @@ 
 		);
 	}
 
-	private function logWebRequest( array $context, string $logLevel ) {
+	private function logWebRequest(array $context, string $logLevel) {
 		$message = $context['message'] ?? 'Sofort request not handled';
-		unset( $context['message'] );
+		unset($context['message']);
 
 		$context['post_vars'] = $this->request->request->all();
 		$context['query_vars'] = $this->request->query->all();
-		$this->ffFactory->getSofortLogger()->log( $logLevel, $message, $context );
+		$this->ffFactory->getSofortLogger()->log($logLevel, $message, $context);
 	}
 
 }

tests/EdgeToEdge/Routes/SofortPaymentNotificationRouteTest.php

Spacing +55 added lines, -55 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\Tests\EdgeToEdge\Routes;
 
@@ -24,9 +24,9 @@ 
 	private const VALID_TRANSACTION_TIME = '2010-04-14T19:01:08+02:00';
 
 	public function testGivenWrongPaymentType_applicationRefuses(): void {
-		$this->newEnvironment( function ( Client $client, FunFunFactory $factory ) {
+		$this->newEnvironment(function(Client $client, FunFunFactory $factory) {
 			$donation = ValidDonation::newIncompletePayPalDonation();
-			$factory->getDonationRepository()->storeDonation( $donation );
+			$factory->getDonationRepository()->storeDonation($donation);
 
 			$client->request(
 				Request::METHOD_POST,
@@ -37,33 +37,33 @@ 
 				]
 			);
 
-			$this->assertIsBadRequestResponse( $client->getResponse() );
+			$this->assertIsBadRequestResponse($client->getResponse());
 		} );
 	}
 
-	private function newEnvironment( callable $onEnvironmentCreated ): void {
+	private function newEnvironment(callable $onEnvironmentCreated): void {
 		$this->createEnvironment(
 			[],
-			function ( Client $client, FunFunFactory $factory ) use ( $onEnvironmentCreated ) {
-				$factory->setTokenGenerator( new FixedTokenGenerator(
+			function(Client $client, FunFunFactory $factory) use ($onEnvironmentCreated) {
+				$factory->setTokenGenerator(new FixedTokenGenerator(
 					self::VALID_TOKEN,
-					new DateTime( '2039-12-31 23:59:59Z' )
-				) );
+					new DateTime('2039-12-31 23:59:59Z')
+				));
 
-				$onEnvironmentCreated( $client, $factory );
+				$onEnvironmentCreated($client, $factory);
 			}
 		);
 	}
 
-	private function assertIsBadRequestResponse( Response $response ): void {
-		$this->assertSame( 'Bad request', $response->getContent() );
-		$this->assertSame( Response::HTTP_BAD_REQUEST, $response->getStatusCode() );
+	private function assertIsBadRequestResponse(Response $response): void {
+		$this->assertSame('Bad request', $response->getContent());
+		$this->assertSame(Response::HTTP_BAD_REQUEST, $response->getStatusCode());
 	}
 
 	public function testGivenWrongToken_applicationRefuses(): void {
-		$this->newEnvironment( function ( Client $client, FunFunFactory $factory ) {
+		$this->newEnvironment(function(Client $client, FunFunFactory $factory) {
 			$donation = ValidDonation::newIncompleteSofortDonation();
-			$factory->getDonationRepository()->storeDonation( $donation );
+			$factory->getDonationRepository()->storeDonation($donation);
 
 			$client->request(
 				Request::METHOD_POST,
@@ -74,14 +74,14 @@ 
 				]
 			);
 
-			$this->assertIsBadRequestResponse( $client->getResponse() );
+			$this->assertIsBadRequestResponse($client->getResponse());
 		} );
 	}
 
 	public function testGivenBadTimeFormat_applicationRefuses(): void {
-		$this->newEnvironment( function ( Client $client, FunFunFactory $factory ) {
+		$this->newEnvironment(function(Client $client, FunFunFactory $factory) {
 			$donation = ValidDonation::newIncompleteSofortDonation();
-			$factory->getDonationRepository()->storeDonation( $donation );
+			$factory->getDonationRepository()->storeDonation($donation);
 
 			$client->request(
 				Request::METHOD_POST,
@@ -92,14 +92,14 @@ 
 				]
 			);
 
-			$this->assertIsBadRequestResponse( $client->getResponse() );
+			$this->assertIsBadRequestResponse($client->getResponse());
 		} );
 	}
 
 	public function testGivenValidRequest_applicationIndicatesSuccess(): void {
-		$this->newEnvironment( function ( Client $client, FunFunFactory $factory ) {
+		$this->newEnvironment(function(Client $client, FunFunFactory $factory) {
 			$donation = ValidDonation::newIncompleteSofortDonation();
-			$factory->getDonationRepository()->storeDonation( $donation );
+			$factory->getDonationRepository()->storeDonation($donation);
 
 			$client->request(
 				Request::METHOD_POST,
@@ -110,22 +110,22 @@ 
 				]
 			);
 
-			$this->assertSame( 'Ok', $client->getResponse()->getContent() );
-			$this->assertSame( Response::HTTP_OK, $client->getResponse()->getStatusCode() );
+			$this->assertSame('Ok', $client->getResponse()->getContent());
+			$this->assertSame(Response::HTTP_OK, $client->getResponse()->getStatusCode());
 
-			$donation = $factory->getDonationRepository()->getDonationById( $donation->getId() );
+			$donation = $factory->getDonationRepository()->getDonationById($donation->getId());
 
-			$this->assertEquals( new DateTime( self::VALID_TRANSACTION_TIME ), $donation->getPaymentMethod()->getConfirmedAt() );
+			$this->assertEquals(new DateTime(self::VALID_TRANSACTION_TIME), $donation->getPaymentMethod()->getConfirmedAt());
 		} );
 	}
 
 	public function testGivenAlreadyConfirmedPayment_requestDataIsLogged(): void {
-		$this->newEnvironment( function ( Client $client, FunFunFactory $factory ) {
+		$this->newEnvironment(function(Client $client, FunFunFactory $factory) {
 			$logger = new LoggerSpy();
-			$factory->setSofortLogger( $logger );
+			$factory->setSofortLogger($logger);
 
 			$donation = ValidDonation::newCompletedSofortDonation();
-			$factory->getDonationRepository()->storeDonation( $donation );
+			$factory->getDonationRepository()->storeDonation($donation);
 
 			$client->request(
 				Request::METHOD_POST,
@@ -136,21 +136,21 @@ 
 				]
 			);
 
-			$this->assertIsBadRequestResponse( $client->getResponse() );
-			$this->assertErrorCauseIsLogged( $logger, 'Duplicate notification' );
-			$this->assertRequestVarsAreLogged( $logger );
-			$this->assertLogLevel( $logger, LogLevel::INFO );
+			$this->assertIsBadRequestResponse($client->getResponse());
+			$this->assertErrorCauseIsLogged($logger, 'Duplicate notification');
+			$this->assertRequestVarsAreLogged($logger);
+			$this->assertLogLevel($logger, LogLevel::INFO);
 		} );
 	}
 
-	private function assertErrorCauseIsLogged( LoggerSpy $logger, string $expectedMessage ): void {
+	private function assertErrorCauseIsLogged(LoggerSpy $logger, string $expectedMessage): void {
 		$this->assertSame(
-			[ $expectedMessage ],
+			[$expectedMessage],
 			$logger->getLogCalls()->getMessages()
 		);
 	}
 
-	private function assertRequestVarsAreLogged( LoggerSpy $logger ): void {
+	private function assertRequestVarsAreLogged(LoggerSpy $logger): void {
 		$this->assertSame(
 			self::VALID_TRANSACTION_ID,
 			$logger->getLogCalls()->getFirstCall()->getContext()['post_vars']['transaction']
@@ -162,46 +162,46 @@ 
 		);
 	}
 
-	private function assertLogLevel( LoggerSpy $logger, string $expectedLevel ): void {
-		$this->assertSame( $expectedLevel, $logger->getLogCalls()->getFirstCall()->getLevel() );
+	private function assertLogLevel(LoggerSpy $logger, string $expectedLevel): void {
+		$this->assertSame($expectedLevel, $logger->getLogCalls()->getFirstCall()->getLevel());
 	}
 
 	public function testGivenUnknownDonation_requestDataIsLogged(): void {
-		$this->newEnvironment( function ( Client $client, FunFunFactory $factory ) {
+		$this->newEnvironment(function(Client $client, FunFunFactory $factory) {
 			$logger = new LoggerSpy();
-			$factory->setSofortLogger( $logger );
+			$factory->setSofortLogger($logger);
 
 			$donation = ValidDonation::newCompletedSofortDonation();
-			$factory->getDonationRepository()->storeDonation( $donation );
+			$factory->getDonationRepository()->storeDonation($donation);
 
 			$client->request(
 				Request::METHOD_POST,
-				'/sofort-payment-notification?id=' . ( $donation->getId() + 1 ) . '&updateToken=' . self::VALID_TOKEN,
+				'/sofort-payment-notification?id=' . ($donation->getId() + 1) . '&updateToken=' . self::VALID_TOKEN,
 				[
 					'transaction' => self::VALID_TRANSACTION_ID,
 					'time' => self::VALID_TRANSACTION_TIME
 				]
 			);
 
-			$this->assertIsErrorResponse( $client->getResponse() );
-			$this->assertErrorCauseIsLogged( $logger, 'Donation not found' );
-			$this->assertRequestVarsAreLogged( $logger );
-			$this->assertLogLevel( $logger, LogLevel::ERROR );
+			$this->assertIsErrorResponse($client->getResponse());
+			$this->assertErrorCauseIsLogged($logger, 'Donation not found');
+			$this->assertRequestVarsAreLogged($logger);
+			$this->assertLogLevel($logger, LogLevel::ERROR);
 		} );
 	}
 
-	private function assertIsErrorResponse( Response $response ): void {
-		$this->assertSame( 'Error', $response->getContent() );
-		$this->assertSame( Response::HTTP_INTERNAL_SERVER_ERROR, $response->getStatusCode() );
+	private function assertIsErrorResponse(Response $response): void {
+		$this->assertSame('Error', $response->getContent());
+		$this->assertSame(Response::HTTP_INTERNAL_SERVER_ERROR, $response->getStatusCode());
 	}
 
 	public function testGivenBadTime_requestDataIsLogged(): void {
-		$this->newEnvironment( function ( Client $client, FunFunFactory $factory ) {
+		$this->newEnvironment(function(Client $client, FunFunFactory $factory) {
 			$logger = new LoggerSpy();
-			$factory->setSofortLogger( $logger );
+			$factory->setSofortLogger($logger);
 
 			$donation = ValidDonation::newCompletedSofortDonation();
-			$factory->getDonationRepository()->storeDonation( $donation );
+			$factory->getDonationRepository()->storeDonation($donation);
 
 			$client->request(
 				Request::METHOD_POST,
@@ -212,10 +212,10 @@ 
 				]
 			);
 
-			$this->assertIsBadRequestResponse( $client->getResponse() );
-			$this->assertErrorCauseIsLogged( $logger, 'Bad notification time' );
-			$this->assertRequestVarsAreLogged( $logger );
-			$this->assertLogLevel( $logger, LogLevel::ERROR );
+			$this->assertIsBadRequestResponse($client->getResponse());
+			$this->assertErrorCauseIsLogged($logger, 'Bad notification time');
+			$this->assertRequestVarsAreLogged($logger);
+			$this->assertLogLevel($logger, LogLevel::ERROR);
 		} );
 	}