wmde / FundraisingFrontend

tests/EdgeToEdge/WebRouteTestCase.php

Spacing +50 added lines, -50 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\Tests\EdgeToEdge;
 
@@ -32,16 +32,16 @@ 
 	 *
 	 * @return Client
 	 */
-	protected function createClient( array $config = [], callable $onEnvironmentCreated = null, bool $debug = true,
-								  array $serverConfig = [] ): Client {
-		$testEnvironment = TestEnvironment::newInstance( $config );
+	protected function createClient(array $config = [], callable $onEnvironmentCreated = null, bool $debug = true,
+								  array $serverConfig = []): Client {
+		$testEnvironment = TestEnvironment::newInstance($config);
 
-		if ( is_callable( $onEnvironmentCreated ) ) {
-			call_user_func( $onEnvironmentCreated, $testEnvironment->getFactory(), $testEnvironment->getConfig() );
+		if (is_callable($onEnvironmentCreated)) {
+			call_user_func($onEnvironmentCreated, $testEnvironment->getFactory(), $testEnvironment->getConfig());
 		}
 
 		return new Client(
-			$this->createApplication( $testEnvironment->getFactory(), $debug ),
+			$this->createApplication($testEnvironment->getFactory(), $debug),
 			$serverConfig
 		);
 	}
@@ -57,11 +57,11 @@ 
 	 * @param array $config
 	 * @param callable $onEnvironmentCreated
 	 */
-	protected function createEnvironment( array $config, callable $onEnvironmentCreated ): void {
-		$testEnvironment = TestEnvironment::newInstance( $config );
+	protected function createEnvironment(array $config, callable $onEnvironmentCreated): void {
+		$testEnvironment = TestEnvironment::newInstance($config);
 
 		$client = new Client(
-			$this->createApplication( $testEnvironment->getFactory(), self::ENABLE_DEBUG )
+			$this->createApplication($testEnvironment->getFactory(), self::ENABLE_DEBUG)
 		);
 
 		call_user_func(
@@ -83,11 +83,11 @@ 
 	 * @param array $config
 	 * @param callable $onEnvironmentCreated
 	 */
-	protected function createAppEnvironment( array $config, callable $onEnvironmentCreated ): void {
-		$testEnvironment = TestEnvironment::newInstance( $config );
+	protected function createAppEnvironment(array $config, callable $onEnvironmentCreated): void {
+		$testEnvironment = TestEnvironment::newInstance($config);
 
-		$application = $this->createApplication( $testEnvironment->getFactory(), self::ENABLE_DEBUG );
-		$client = new Client( $application );
+		$application = $this->createApplication($testEnvironment->getFactory(), self::ENABLE_DEBUG);
+		$client = new Client($application);
 
 		call_user_func(
 			$onEnvironmentCreated,
@@ -98,84 +98,84 @@ 
 	}
 
 	// @codingStandardsIgnoreStart
-	private function createApplication( FunFunFactory $ffFactory, bool $debug ): Application {
+	private function createApplication(FunFunFactory $ffFactory, bool $debug): Application {
 		// @codingStandardsIgnoreEnd
 		$app = require __DIR__ . ' /../../app/bootstrap.php';
 
-		if ( $debug ) {
+		if ($debug) {
 			$app['debug'] = true;
 			$app['session.test'] = true;
-			unset( $app['exception_handler'] );
+			unset($app['exception_handler']);
 		}
 
-		$ffFactory->setSkinTwigEnvironment( $app['twig'] );
+		$ffFactory->setSkinTwigEnvironment($app['twig']);
 
 		return $app;
 	}
 
 	protected function createSilexApplication(): Application {
-		$testEnvironment = TestEnvironment::newInstance( [] );
+		$testEnvironment = TestEnvironment::newInstance([]);
 
-		return $this->createApplication( $testEnvironment->getFactory(), self::ENABLE_DEBUG );
+		return $this->createApplication($testEnvironment->getFactory(), self::ENABLE_DEBUG);
 	}
 
-	protected function assert404( Response $response ): void {
-		$this->assertSame( 404, $response->getStatusCode() );
+	protected function assert404(Response $response): void {
+		$this->assertSame(404, $response->getStatusCode());
 	}
 
-	protected function assertJsonResponse( array $expected, Response $response ): void {
+	protected function assertJsonResponse(array $expected, Response $response): void {
 		$this->assertSame(
-			json_encode( $expected, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES ),
+			json_encode($expected, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES),
 			$response->getContent()
 		);
 	}
 
-	protected function assertJsonSuccessResponse( array $expected, Response $response ): void {
-		$this->assertTrue( $response->isSuccessful(), 'request is successful' );
-		$this->assertJson( $response->getContent(), 'response is json' );
-		$this->assertJsonResponse( $expected, $response );
+	protected function assertJsonSuccessResponse(array $expected, Response $response): void {
+		$this->assertTrue($response->isSuccessful(), 'request is successful');
+		$this->assertJson($response->getContent(), 'response is json');
+		$this->assertJsonResponse($expected, $response);
 	}
 
-	protected function assertGetRequestCausesMethodNotAllowedResponse( string $route, array $params ): void {
+	protected function assertGetRequestCausesMethodNotAllowedResponse(string $route, array $params): void {
 		$client = $this->createClient();
 
-		$this->expectException( MethodNotAllowedHttpException::class );
-		$client->request( 'GET', $route, $params );
+		$this->expectException(MethodNotAllowedHttpException::class);
+		$client->request('GET', $route, $params);
 	}
 
-	protected function assertErrorJsonResponse( Response $response ): void {
-		$responseData = $this->getJsonFromResponse( $response );
-		$this->assertArrayHasKey( 'status', $responseData );
-		$this->assertEquals( $responseData['status'], 'ERR' );
+	protected function assertErrorJsonResponse(Response $response): void {
+		$responseData = $this->getJsonFromResponse($response);
+		$this->assertArrayHasKey('status', $responseData);
+		$this->assertEquals($responseData['status'], 'ERR');
 		$this->assertThat(
 			$responseData,
 			$this->logicalOr(
-				$this->arrayHasKey( 'message' ),
-				$this->arrayHasKey( 'messages' )
+				$this->arrayHasKey('message'),
+				$this->arrayHasKey('messages')
 			)
 		);
 	}
 
-	protected function getJsonFromResponse( Response $response ): array {
-		$this->assertJson( $response->getContent(), 'response is json' );
-		return json_decode( $response->getContent(), true );
+	protected function getJsonFromResponse(Response $response): array {
+		$this->assertJson($response->getContent(), 'response is json');
+		return json_decode($response->getContent(), true);
 	}
 
-	protected function assertSuccessJsonResponse( Response $response ): void {
-		$responseData = $this->getJsonFromResponse( $response );
-		$this->assertArrayHasKey( 'status', $responseData );
-		$this->assertEquals( $responseData['status'], 'OK' );
-		$this->assertArrayHasKey( 'message', $responseData );
+	protected function assertSuccessJsonResponse(Response $response): void {
+		$responseData = $this->getJsonFromResponse($response);
+		$this->assertArrayHasKey('status', $responseData);
+		$this->assertEquals($responseData['status'], 'OK');
+		$this->assertArrayHasKey('message', $responseData);
 	}
 
-	protected function assertInitialFormValues( array $expected, Client $client ): void {
-		$initialFormValues = $client->getCrawler()->filter( 'script[data-initial-form-values]' );
+	protected function assertInitialFormValues(array $expected, Client $client): void {
+		$initialFormValues = $client->getCrawler()->filter('script[data-initial-form-values]');
 		$this->assertGreaterThan(
 			0,
 			$initialFormValues->count()
 		);
-		$json = $initialFormValues->attr( 'data-initial-form-values' );
-		$data = json_decode( $json, true );
-		$this->assertEquals( $expected, $data );
+		$json = $initialFormValues->attr('data-initial-form-values');
+		$data = json_decode($json, true);
+		$this->assertEquals($expected, $data);
 	}
 }

tests/EdgeToEdge/Routes/AddDonationRouteTest.php

Spacing +209 added lines, -209 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\Tests\EdgeToEdge\Routes;
 
@@ -28,10 +28,10 @@ 
 	const SOME_TOKEN = 'SomeToken';
 
 	public function testGivenValidRequest_donationGetsPersisted(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 
-			$client->setServerParameter( 'HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich' );
-			$client->followRedirects( false );
+			$client->setServerParameter('HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich');
+			$client->followRedirects(false);
 
 			$client->request(
 				'POST',
@@ -39,28 +39,28 @@ 
 				$this->newValidFormInput()
 			);
 
-			$this->assertIsExpectedDonation( $this->getDonationFromDatabase( $factory ) );
+			$this->assertIsExpectedDonation($this->getDonationFromDatabase($factory));
 		} );
 	}
 
 	public function testWhenDonationGetsPersisted_timestampIsStoredInCookie(): void {
 		$client = $this->createClient();
-		$client->followRedirects( true );
+		$client->followRedirects(true);
 		$client->request(
 			'POST',
 			'/donation/add',
 			$this->newValidFormInput()
 		);
 
-		$cookie = $client->getCookieJar()->get( 'donation_timestamp' );
-		$this->assertNotNull( $cookie );
-		$donationTimestamp = new \DateTime( $cookie->getValue() );
-		$this->assertEquals( time(), $donationTimestamp->getTimestamp(), 'Timestamp should be not more than 5 seconds old', 5.0 );
+		$cookie = $client->getCookieJar()->get('donation_timestamp');
+		$this->assertNotNull($cookie);
+		$donationTimestamp = new \DateTime($cookie->getValue());
+		$this->assertEquals(time(), $donationTimestamp->getTimestamp(), 'Timestamp should be not more than 5 seconds old', 5.0);
 	}
 
 	public function testWhenMultipleDonationFormSubmissions_requestGetsRejected(): void {
 		$client = $this->createClient();
-		$client->getCookieJar()->set( new Cookie( 'donation_timestamp', $this->getPastTimestamp() ) );
+		$client->getCookieJar()->set(new Cookie('donation_timestamp', $this->getPastTimestamp()));
 
 		$client->request(
 			'POST',
@@ -68,7 +68,7 @@ 
 			$this->newValidFormInput()
 		);
 
-		$this->assertContains( 'donation_rejected_limit', $client->getResponse()->getContent() );
+		$this->assertContains('donation_rejected_limit', $client->getResponse()->getContent());
 	}
 
 	public function testWhenMultipleDonationsInAccordanceToTimeLimit_requestIsNotRejected(): void {
@@ -76,7 +76,7 @@ 
 		$client->getCookieJar()->set(
 			new Cookie(
 				'donation_timestamp',
-				$this->getPastTimestamp( 'PT35M' )
+				$this->getPastTimestamp('PT35M')
 			)
 		);
 
@@ -86,11 +86,11 @@ 
 			$this->newValidFormInput()
 		);
 
-		$this->assertNotContains( 'donation_rejected_limit', $client->getResponse()->getContent() );
+		$this->assertNotContains('donation_rejected_limit', $client->getResponse()->getContent());
 	}
 
-	private function getPastTimestamp( string $interval = 'PT10S' ): string {
-		return ( new \DateTime() )->sub( new \DateInterval( $interval ) )->format( 'Y-m-d H:i:s' );
+	private function getPastTimestamp(string $interval = 'PT10S'): string {
+		return (new \DateTime())->sub(new \DateInterval($interval))->format('Y-m-d H:i:s');
 	}
 
 	private function newValidFormInput(): array {
@@ -125,39 +125,39 @@ 
 		];
 	}
 
-	private function assertIsExpectedDonation( Donation $donation ): void {
+	private function assertIsExpectedDonation(Donation $donation): void {
 		$data = $donation->getDecodedData();
-		$this->assertSame( '5.51', $donation->getAmount() );
-		$this->assertSame( 'BEZ', $donation->getPaymentType() );
-		$this->assertSame( 0, $donation->getPaymentIntervalInMonths() );
-		$this->assertSame( 'DE12500105170648489890', $data['iban'] );
-		$this->assertSame( 'INGDDEFFXXX', $data['bic'] );
-		$this->assertSame( '0648489890', $data['konto'] );
-		$this->assertSame( '50010517', $data['blz'] );
-		$this->assertSame( 'ING-DiBa', $data['bankname'] );
-		$this->assertSame( 'person', $data['adresstyp'] );
-		$this->assertSame( 'Frau', $data['anrede'] );
-		$this->assertSame( 'Prof. Dr.', $data['titel'] );
-		$this->assertSame( '', $data['firma'] );
-		$this->assertSame( 'Karla', $data['vorname'] );
-		$this->assertSame( 'Kennichnich', $data['nachname'] );
-		$this->assertSame( 'Prof. Dr. Karla Kennichnich', $donation->getDonorFullName() );
-		$this->assertSame( 'Lehmgasse 12', $data['strasse'] );
-		$this->assertSame( '12345', $data['plz'] );
-		$this->assertSame( 'Einort', $data['ort'] );
-		$this->assertSame( 'Einort', $donation->getDonorCity() );
-		$this->assertSame( 'DE', $data['country'] );
-		$this->assertSame( 'karla@kennichnich.de', $data['email'] );
-		$this->assertSame( 'karla@kennichnich.de', $donation->getDonorEmail() );
-		$this->assertSame( 'test/gelb', $data['tracking'] );
-		$this->assertSame( 3, $data['impCount'] );
-		$this->assertSame( 1, $data['bImpCount'] );
-		$this->assertSame( '', $data['layout'] );
-		$this->assertSame( '', $data['color'] );
-		$this->assertSame( '', $data['skin'] );
-		$this->assertSame( 'en.wikipedia.org', $data['source'] );
-		$this->assertSame( 'N', $donation->getStatus() );
-		$this->assertTrue( $donation->getDonorOptsIntoNewsletter() );
+		$this->assertSame('5.51', $donation->getAmount());
+		$this->assertSame('BEZ', $donation->getPaymentType());
+		$this->assertSame(0, $donation->getPaymentIntervalInMonths());
+		$this->assertSame('DE12500105170648489890', $data['iban']);
+		$this->assertSame('INGDDEFFXXX', $data['bic']);
+		$this->assertSame('0648489890', $data['konto']);
+		$this->assertSame('50010517', $data['blz']);
+		$this->assertSame('ING-DiBa', $data['bankname']);
+		$this->assertSame('person', $data['adresstyp']);
+		$this->assertSame('Frau', $data['anrede']);
+		$this->assertSame('Prof. Dr.', $data['titel']);
+		$this->assertSame('', $data['firma']);
+		$this->assertSame('Karla', $data['vorname']);
+		$this->assertSame('Kennichnich', $data['nachname']);
+		$this->assertSame('Prof. Dr. Karla Kennichnich', $donation->getDonorFullName());
+		$this->assertSame('Lehmgasse 12', $data['strasse']);
+		$this->assertSame('12345', $data['plz']);
+		$this->assertSame('Einort', $data['ort']);
+		$this->assertSame('Einort', $donation->getDonorCity());
+		$this->assertSame('DE', $data['country']);
+		$this->assertSame('karla@kennichnich.de', $data['email']);
+		$this->assertSame('karla@kennichnich.de', $donation->getDonorEmail());
+		$this->assertSame('test/gelb', $data['tracking']);
+		$this->assertSame(3, $data['impCount']);
+		$this->assertSame(1, $data['bImpCount']);
+		$this->assertSame('', $data['layout']);
+		$this->assertSame('', $data['color']);
+		$this->assertSame('', $data['skin']);
+		$this->assertSame('en.wikipedia.org', $data['source']);
+		$this->assertSame('N', $donation->getStatus());
+		$this->assertTrue($donation->getDonorOptsIntoNewsletter());
 	}
 
 	public function testGivenValidRequest_confirmationPageContainsEnteredData(): void {
@@ -171,16 +171,16 @@ 
 
 		$response = $client->getResponse()->getContent();
 
-		$this->assertContains( '5,51 €', $response );
-		$this->assertContains( 'donation.interval: 0', $response );
-		$this->assertContains( 'DE12500105170648489890', $response );
-		$this->assertContains( 'INGDDEFFXXX', $response );
-		$this->assertContains( 'ING-DiBa', $response );
-		$this->assertContains( 'Prof. Dr. Karla Kennichnich', $response );
-		$this->assertContains( 'Lehmgasse 12', $response );
-		$this->assertContains( '<span id="confirm-postcode">12345</span> <span id="confirm-city">Einort</span>', $response );
-		$this->assertContains( 'karla@kennichnich.de', $response );
-		$this->assertContains( 'send-info', $response );
+		$this->assertContains('5,51 €', $response);
+		$this->assertContains('donation.interval: 0', $response);
+		$this->assertContains('DE12500105170648489890', $response);
+		$this->assertContains('INGDDEFFXXX', $response);
+		$this->assertContains('ING-DiBa', $response);
+		$this->assertContains('Prof. Dr. Karla Kennichnich', $response);
+		$this->assertContains('Lehmgasse 12', $response);
+		$this->assertContains('<span id="confirm-postcode">12345</span> <span id="confirm-city">Einort</span>', $response);
+		$this->assertContains('karla@kennichnich.de', $response);
+		$this->assertContains('send-info', $response);
 	}
 
 	public function testGivenValidBankTransferRequest_donationGetsPersisted(): void {
@@ -189,10 +189,10 @@ 
 		 */
 		$factory = null;
 
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 
-			$client->setServerParameter( 'HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich' );
-			$client->followRedirects( false );
+			$client->setServerParameter('HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich');
+			$client->followRedirects(false);
 
 			$client->request(
 				'POST',
@@ -200,37 +200,37 @@ 
 				$this->newValidBankTransferInput()
 			);
 
-			$donation = $this->getDonationFromDatabase( $factory );
+			$donation = $this->getDonationFromDatabase($factory);
 
 			$data = $donation->getDecodedData();
-			$this->assertSame( '12.34', $donation->getAmount() );
-			$this->assertSame( 'UEB', $donation->getPaymentType() );
-			$this->assertSame( 0, $donation->getPaymentIntervalInMonths() );
-			$this->assertSame( 'person', $data['adresstyp'] );
-			$this->assertSame( 'Frau', $data['anrede'] );
-			$this->assertSame( 'Prof. Dr.', $data['titel'] );
-			$this->assertSame( '', $data['firma'] );
-			$this->assertSame( 'Karla', $data['vorname'] );
-			$this->assertSame( 'Kennichnich', $data['nachname'] );
-			$this->assertSame( 'Prof. Dr. Karla Kennichnich', $donation->getDonorFullName() );
-			$this->assertSame( 'Lehmgasse 12', $data['strasse'] );
-			$this->assertSame( '12345', $data['plz'] );
-			$this->assertSame( 'Einort', $data['ort'] );
-			$this->assertSame( 'Einort', $donation->getDonorCity() );
-			$this->assertSame( 'DE', $data['country'] );
-			$this->assertSame( 'karla@kennichnich.de', $data['email'] );
-			$this->assertSame( 'karla@kennichnich.de', $donation->getDonorEmail() );
-			$this->assertSame( 'test/gelb', $data['tracking'] );
-			$this->assertSame( 3, $data['impCount'] );
-			$this->assertSame( 1, $data['bImpCount'] );
-			$this->assertSame( '', $data['layout'] );
-			$this->assertSame( '', $data['color'] );
-			$this->assertSame( '', $data['skin'] );
-			$this->assertSame( 'en.wikipedia.org', $data['source'] );
-			$this->assertSame( true, $donation->getDonorOptsIntoNewsletter() );
-
-			$this->assertSame( 'Z', $donation->getStatus() );
-			$this->assertRegExp( '/W-Q-[A-Z]{6}-[A-Z]/', $donation->getBankTransferCode() );
+			$this->assertSame('12.34', $donation->getAmount());
+			$this->assertSame('UEB', $donation->getPaymentType());
+			$this->assertSame(0, $donation->getPaymentIntervalInMonths());
+			$this->assertSame('person', $data['adresstyp']);
+			$this->assertSame('Frau', $data['anrede']);
+			$this->assertSame('Prof. Dr.', $data['titel']);
+			$this->assertSame('', $data['firma']);
+			$this->assertSame('Karla', $data['vorname']);
+			$this->assertSame('Kennichnich', $data['nachname']);
+			$this->assertSame('Prof. Dr. Karla Kennichnich', $donation->getDonorFullName());
+			$this->assertSame('Lehmgasse 12', $data['strasse']);
+			$this->assertSame('12345', $data['plz']);
+			$this->assertSame('Einort', $data['ort']);
+			$this->assertSame('Einort', $donation->getDonorCity());
+			$this->assertSame('DE', $data['country']);
+			$this->assertSame('karla@kennichnich.de', $data['email']);
+			$this->assertSame('karla@kennichnich.de', $donation->getDonorEmail());
+			$this->assertSame('test/gelb', $data['tracking']);
+			$this->assertSame(3, $data['impCount']);
+			$this->assertSame(1, $data['bImpCount']);
+			$this->assertSame('', $data['layout']);
+			$this->assertSame('', $data['color']);
+			$this->assertSame('', $data['skin']);
+			$this->assertSame('en.wikipedia.org', $data['source']);
+			$this->assertSame(true, $donation->getDonorOptsIntoNewsletter());
+
+			$this->assertSame('Z', $donation->getStatus());
+			$this->assertRegExp('/W-Q-[A-Z]{6}-[A-Z]/', $donation->getBankTransferCode());
 		} );
 	}
 
@@ -262,10 +262,10 @@ 
 	}
 
 	public function testGivenComplementableBankData_donationStillGetsPersisted(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 
-			$client->setServerParameter( 'HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich' );
-			$client->followRedirects( false );
+			$client->setServerParameter('HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich');
+			$client->followRedirects(false);
 
 			$client->request(
 				'POST',
@@ -273,14 +273,14 @@ 
 				$this->newComplementableFormInput()
 			);
 
-			$donation = $this->getDonationFromDatabase( $factory );
+			$donation = $this->getDonationFromDatabase($factory);
 
 			$data = $donation->getDecodedData();
-			$this->assertSame( 'DE12500105170648489890', $data['iban'] );
-			$this->assertSame( 'INGDDEFFXXX', $data['bic'] );
-			$this->assertSame( '0648489890', $data['konto'] );
-			$this->assertSame( '50010517', $data['blz'] );
-			$this->assertSame( 'ING-DiBa', $data['bankname'] );
+			$this->assertSame('DE12500105170648489890', $data['iban']);
+			$this->assertSame('INGDDEFFXXX', $data['bic']);
+			$this->assertSame('0648489890', $data['konto']);
+			$this->assertSame('50010517', $data['blz']);
+			$this->assertSame('ING-DiBa', $data['bankname']);
 		} );
 	}
 
@@ -303,16 +303,16 @@ 
 		];
 	}
 
-	private function getDonationFromDatabase( FunFunFactory $factory ): Donation {
-		$donationRepo = $factory->getEntityManager()->getRepository( Donation::class );
-		$donation = $donationRepo->find( 1 );
-		$this->assertInstanceOf( Donation::class, $donation );
+	private function getDonationFromDatabase(FunFunFactory $factory): Donation {
+		$donationRepo = $factory->getEntityManager()->getRepository(Donation::class);
+		$donation = $donationRepo->find(1);
+		$this->assertInstanceOf(Donation::class, $donation);
 		return $donation;
 	}
 
 	public function testGivenValidPayPalData_redirectsToPayPal(): void {
 		$client = $this->createClient();
-		$client->followRedirects( false );
+		$client->followRedirects(false);
 
 		$client->request(
 			'POST',
@@ -321,13 +321,13 @@ 
 		);
 
 		$response = $client->getResponse();
-		$this->assertSame( 302, $response->getStatusCode() );
-		$this->assertContains( 'sandbox.paypal.com', $response->getContent() );
+		$this->assertSame(302, $response->getStatusCode());
+		$this->assertContains('sandbox.paypal.com', $response->getContent());
 	}
 
 	public function testWhenRedirectingToPayPal_translatedItemNameIsPassed(): void {
 		$client = $this->createClient();
-		$client->followRedirects( false );
+		$client->followRedirects(false);
 
 		$client->request(
 			'POST',
@@ -336,8 +336,8 @@ 
 		);
 
 		$response = $client->getResponse();
-		$this->assertSame( 302, $response->getStatusCode() );
-		$this->assertContains( 'item_name=item_name_donation', $response->getContent() );
+		$this->assertSame(302, $response->getStatusCode());
+		$this->assertContains('item_name=item_name_donation', $response->getContent());
 	}
 
 	private function newValidPayPalInput(): array {
@@ -358,36 +358,36 @@ 
 		);
 
 		$response = $client->getResponse();
-		$this->assertSame( 200, $response->getStatusCode() );
-		$this->assertContains( 'paytext_cc 3 12,34 € per Kreditkarte.', $response->getContent() );
-		$this->assertContains( 'thatother.paymentprovider.com', $response->getContent() );
+		$this->assertSame(200, $response->getStatusCode());
+		$this->assertContains('paytext_cc 3 12,34 € per Kreditkarte.', $response->getContent());
+		$this->assertContains('thatother.paymentprovider.com', $response->getContent());
 	}
 
 	public function testValidSofortInput_savesDonationAndRedirectsTo3rdPartyPage(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 			$response = new SofortResponse();
-			$response->setPaymentUrl( 'https://bankingpin.please' );
+			$response->setPaymentUrl('https://bankingpin.please');
 
-			$sofortClient = $this->createMock( SofortClient::class );
+			$sofortClient = $this->createMock(SofortClient::class);
 			$sofortClient
-				->method( 'get' )
-				->willReturn( $response );
-			$factory->setSofortClient( $sofortClient );
+				->method('get')
+				->willReturn($response);
+			$factory->setSofortClient($sofortClient);
 
 
-			$client->followRedirects( false );
+			$client->followRedirects(false);
 			$client->request(
 				'POST',
 				'/donation/add',
 				$this->newValidSofortInput()
 			);
 
-			$donation = $this->getDonationFromDatabase( $factory );
+			$donation = $this->getDonationFromDatabase($factory);
 
-			$this->assertSame( 'Z', $donation->getStatus() );
-			$this->assertRegExp( '/W-Q-[A-Z]{6}-[A-Z]/', $donation->getBankTransferCode() );
+			$this->assertSame('Z', $donation->getStatus());
+			$this->assertRegExp('/W-Q-[A-Z]{6}-[A-Z]/', $donation->getBankTransferCode());
 
-			$this->assertTrue( $client->getResponse()->isRedirect( 'https://bankingpin.please' ) );
+			$this->assertTrue($client->getResponse()->isRedirect('https://bankingpin.please'));
 		} );
 	}
 
@@ -419,23 +419,23 @@ 
 
 		$response = $client->getResponse()->getContent();
 
-		$this->assertContains( 'Amount: 0,00', $response );
-		$this->assertContains( 'Payment type: BEZ', $response );
-		$this->assertContains( 'Interval: 3', $response );
-		$this->assertContains( 'IBAN: DE12500105170648489890', $response );
-		$this->assertContains( 'BIC: INGDDEFFXXX', $response );
-		$this->assertContains( 'Bank name: ING-DiBa', $response );
-		$this->assertContains( 'Address type: person', $response );
-		$this->assertContains( 'Salutation: Frau', $response );
-		$this->assertContains( 'Title: Prof. Dr.', $response );
-		$this->assertContains( 'Company: ', $response );
-		$this->assertContains( 'First name: Karla', $response );
-		$this->assertContains( 'Last name: Kennichnich', $response );
-		$this->assertContains( 'Street: Lehmgasse 12', $response );
-		$this->assertContains( 'Postal code: 12345', $response );
-		$this->assertContains( 'City: Einort', $response );
-		$this->assertContains( 'Country code: DE', $response );
-		$this->assertContains( 'Email address: karla@kennichnich.de', $response );
+		$this->assertContains('Amount: 0,00', $response);
+		$this->assertContains('Payment type: BEZ', $response);
+		$this->assertContains('Interval: 3', $response);
+		$this->assertContains('IBAN: DE12500105170648489890', $response);
+		$this->assertContains('BIC: INGDDEFFXXX', $response);
+		$this->assertContains('Bank name: ING-DiBa', $response);
+		$this->assertContains('Address type: person', $response);
+		$this->assertContains('Salutation: Frau', $response);
+		$this->assertContains('Title: Prof. Dr.', $response);
+		$this->assertContains('Company: ', $response);
+		$this->assertContains('First name: Karla', $response);
+		$this->assertContains('Last name: Kennichnich', $response);
+		$this->assertContains('Street: Lehmgasse 12', $response);
+		$this->assertContains('Postal code: 12345', $response);
+		$this->assertContains('City: Einort', $response);
+		$this->assertContains('Country code: DE', $response);
+		$this->assertContains('Email address: karla@kennichnich.de', $response);
 	}
 
 	public function testGivenInvalidRequest_formStillContainsBannerTrackingData(): void {
@@ -451,8 +451,8 @@ 
 
 		$response = $client->getResponse()->getContent();
 
-		$this->assertContains( 'Impression Count: 12', $response );
-		$this->assertContains( 'Banner Impression Count: 3', $response );
+		$this->assertContains('Impression Count: 12', $response);
+		$this->assertContains('Banner Impression Count: 3', $response);
 	}
 
 	public function testGivenNegativeDonationAmount_formIsReloadedAndPrefilledWithZero(): void {
@@ -469,7 +469,7 @@ 
 
 		$response = $client->getResponse()->getContent();
 
-		$this->assertContains( 'Amount: 0,00', $response );
+		$this->assertContains('Amount: 0,00', $response);
 	}
 
 	private function newInvalidFormInput(): array {
@@ -514,10 +514,10 @@ 
 
 		$response = $client->getResponse()->getContent();
 
-		$this->assertContains( 'Amount: 0', $response );
-		$this->assertContains( 'Payment type: UEB', $response );
-		$this->assertContains( 'Interval: 1', $response );
-		$this->assertContains( 'Value of field "amount" violates rule: Amount too low', $response );
+		$this->assertContains('Amount: 0', $response);
+		$this->assertContains('Payment type: UEB', $response);
+		$this->assertContains('Interval: 1', $response);
+		$this->assertContains('Value of field "amount" violates rule: Amount too low', $response);
 	}
 
 	private function newAnonymousFormInput(): array {
@@ -530,11 +530,11 @@ 
 	}
 
 	public function testGivenValidRequest_tokensAreReturned(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
-			$factory->setTokenGenerator( new FixedTokenGenerator( self::SOME_TOKEN ) );
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
+			$factory->setTokenGenerator(new FixedTokenGenerator(self::SOME_TOKEN));
 
-			$client->setServerParameter( 'HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich' );
-			$client->followRedirects( false );
+			$client->setServerParameter('HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich');
+			$client->followRedirects(false);
 
 			$client->request(
 				'POST',
@@ -544,14 +544,14 @@ 
 
 			$response = $client->getResponse()->getContent();
 
-			$this->assertContains( self::SOME_TOKEN, $response );
+			$this->assertContains(self::SOME_TOKEN, $response);
 		} );
 	}
 
 	public function testGivenValidRequest_clientIsRedirected(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
-			$factory->setTokenGenerator( new FixedTokenGenerator( self::SOME_TOKEN ) );
-			$client->followRedirects( false );
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
+			$factory->setTokenGenerator(new FixedTokenGenerator(self::SOME_TOKEN));
+			$client->followRedirects(false);
 
 			$client->request(
 				'POST',
@@ -559,13 +559,13 @@ 
 				$this->newValidFormInput()
 			);
 
-			$this->assertTrue( $client->getResponse()->isRedirect() );
+			$this->assertTrue($client->getResponse()->isRedirect());
 		} );
 	}
 
 	public function testWhenTrackingCookieExists_valueIsPersisted(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
-			$client->getCookieJar()->set( new Cookie( 'spenden_tracking', 'test/blue' ) );
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
+			$client->getCookieJar()->set(new Cookie('spenden_tracking', 'test/blue'));
 
 			$client->request(
 				'POST',
@@ -573,15 +573,15 @@ 
 				$this->newComplementableFormInput()
 			);
 
-			$donation = $this->getDonationFromDatabase( $factory );
+			$donation = $this->getDonationFromDatabase($factory);
 			$data = $donation->getDecodedData();
 
-			$this->assertSame( 'test/blue', $data['tracking'] );
+			$this->assertSame('test/blue', $data['tracking']);
 		} );
 	}
 
 	public function testWhenTrackableInputDataIsSubmitted_theyAreStoredInSession(): void {
-		$this->createAppEnvironment( [], function ( Client $client, FunFunFactory $factory, Application $app ) {
+		$this->createAppEnvironment([], function(Client $client, FunFunFactory $factory, Application $app) {
 
 			$client->request(
 				'GET',
@@ -593,15 +593,15 @@ 
 				]
 			);
 
-			$piwikTracking = $app['session']->get( 'piwikTracking' );
-			$this->assertSame( 'BEZ', $piwikTracking['paymentType'] );
-			$this->assertSame( 3, $piwikTracking['paymentInterval'] );
-			$this->assertSame( '5,00', $piwikTracking['paymentAmount'] );
+			$piwikTracking = $app['session']->get('piwikTracking');
+			$this->assertSame('BEZ', $piwikTracking['paymentType']);
+			$this->assertSame(3, $piwikTracking['paymentInterval']);
+			$this->assertSame('5,00', $piwikTracking['paymentAmount']);
 		} );
 	}
 
 	public function testWhenTolstojNovelIsPassed_isIsNotStoredInSession(): void {
-		$this->createAppEnvironment( [], function ( Client $client, FunFunFactory $factory, Application $app ) {
+		$this->createAppEnvironment([], function(Client $client, FunFunFactory $factory, Application $app) {
 
 			$client->request(
 				'GET',
@@ -619,15 +619,15 @@ 
 				]
 			);
 
-			$piwikTracking = $app['session']->get( 'piwikTracking' );
-			$this->assertArrayNotHasKey( 'paymentType', $piwikTracking );
-			$this->assertSame( 3, $piwikTracking['paymentInterval'] );
-			$this->assertSame( '5,00', $piwikTracking['paymentAmount'] );
+			$piwikTracking = $app['session']->get('piwikTracking');
+			$this->assertArrayNotHasKey('paymentType', $piwikTracking);
+			$this->assertSame(3, $piwikTracking['paymentInterval']);
+			$this->assertSame('5,00', $piwikTracking['paymentAmount']);
 		} );
 	}
 
 	public function testWhenParameterIsOmitted_itIsNotStoredInSession(): void {
-		$this->createAppEnvironment( [], function ( Client $client, FunFunFactory $factory, Application $app ) {
+		$this->createAppEnvironment([], function(Client $client, FunFunFactory $factory, Application $app) {
 
 			$client->request(
 				'GET',
@@ -638,15 +638,15 @@ 
 				]
 			);
 
-			$piwikTracking = $app['session']->get( 'piwikTracking' );
-			$this->assertSame( 'BEZ', $piwikTracking['paymentType'] );
-			$this->assertSame( '5,00', $piwikTracking['paymentAmount'] );
-			$this->assertArrayNotHasKey( 'paymentInterval', $piwikTracking );
+			$piwikTracking = $app['session']->get('piwikTracking');
+			$this->assertSame('BEZ', $piwikTracking['paymentType']);
+			$this->assertSame('5,00', $piwikTracking['paymentAmount']);
+			$this->assertArrayNotHasKey('paymentInterval', $piwikTracking);
 		} );
 	}
 
 	public function testWhenInitiallyIntendedPaymentOptionsDifferFromActual_itIsReflectedInPiwikTrackingEvents(): void {
-		$client = $this->createClient( [] );
+		$client = $this->createClient([]);
 		$client->request(
 			'GET',
 			'/',
@@ -670,21 +670,21 @@ 
 		$client->followRedirect();
 
 		$responseContent = $client->getResponse()->getContent();
-		$this->assertContains( 'BEZ/UEB', $responseContent );
-		$this->assertContains( '5.00/12.34', $responseContent );
-		$this->assertContains( '12/0', $responseContent );
+		$this->assertContains('BEZ/UEB', $responseContent);
+		$this->assertContains('5.00/12.34', $responseContent);
+		$this->assertContains('12/0', $responseContent);
 	}
 
 	public function testWhenMobileTrackingIsRequested_piwikTrackerIsCalledForPaypalPayment(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 			$factory->setNullMessenger();
-			$client->followRedirects( false );
+			$client->followRedirects(false);
 
-			$tracker = $this->getMockBuilder( PageViewTracker::class )->disableOriginalConstructor()->getMock();
-			$tracker->expects( $this->once() )
-				->method( 'trackPaypalRedirection' )
-				->with( 'test', 'gelb', '10.1.2.3' );
-			$factory->setPageViewTracker( $tracker );
+			$tracker = $this->getMockBuilder(PageViewTracker::class)->disableOriginalConstructor()->getMock();
+			$tracker->expects($this->once())
+				->method('trackPaypalRedirection')
+				->with('test', 'gelb', '10.1.2.3');
+			$factory->setPageViewTracker($tracker);
 
 			$client->request(
 				'POST',
@@ -711,14 +711,14 @@ 
 	}
 
 	public function testWhenMobileTrackingIsRequested_piwikTrackerIsNotCalledForNonPaypalPayment(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 			$factory->setNullMessenger();
-			$client->followRedirects( false );
+			$client->followRedirects(false);
 
-			$tracker = $this->getMockBuilder( PageViewTracker::class )->disableOriginalConstructor()->getMock();
-			$tracker->expects( $this->never() )
-				->method( 'trackPaypalRedirection' );
-			$factory->setPageViewTracker( $tracker );
+			$tracker = $this->getMockBuilder(PageViewTracker::class)->disableOriginalConstructor()->getMock();
+			$tracker->expects($this->never())
+				->method('trackPaypalRedirection');
+			$factory->setPageViewTracker($tracker);
 
 			$client->request(
 				'POST',
@@ -734,10 +734,10 @@ 
 	}
 
 	public function testGivenCommasInStreetInput_donationGetsPersisted(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 
-			$client->setServerParameter( 'HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich' );
-			$client->followRedirects( false );
+			$client->setServerParameter('HTTP_REFERER', 'https://en.wikipedia.org/wiki/Karla_Kennichnich');
+			$client->followRedirects(false);
 
 			$formInput = $this->newValidFormInput();
 			$formInput['street'] = ',Lehmgasse, 12,';
@@ -748,12 +748,12 @@ 
 				$formInput
 			);
 
-			$this->assertIsExpectedDonation( $this->getDonationFromDatabase( $factory ) );
+			$this->assertIsExpectedDonation($this->getDonationFromDatabase($factory));
 		} );
 	}
 
 	public function testGivenSufficientForeignBankData_donationGetsPersisted(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 			$formInput = $this->newValidFormInput();
 			$formInput['iban'] = 'AT022050302101023600';
 			$formInput['bic'] = 'SPIHAT22XXX';
@@ -766,23 +766,23 @@ 
 				$formInput
 			);
 
-			$donation = $this->getDonationFromDatabase( $factory );
+			$donation = $this->getDonationFromDatabase($factory);
 			$data = $donation->getDecodedData();
 
-			$this->assertSame( 'AT022050302101023600', $data['iban'] );
-			$this->assertSame( 'SPIHAT22XXX', $data['bic'] );
-			$this->assertSame( '', $data['konto'] );
-			$this->assertSame( '', $data['blz'] );
-			$this->assertSame( '', $data['bankname'] );
+			$this->assertSame('AT022050302101023600', $data['iban']);
+			$this->assertSame('SPIHAT22XXX', $data['bic']);
+			$this->assertSame('', $data['konto']);
+			$this->assertSame('', $data['blz']);
+			$this->assertSame('', $data['bankname']);
 		} );
 	}
 
 	public function testCookieFlagsSecureAndHttpOnlyAreSet(): void {
 		$client = new Client(
 			$this->createSilexApplication(),
-			[ 'HTTPS' => true ]
+			['HTTPS' => true]
 		);
-		$client->followRedirects( true );
+		$client->followRedirects(true);
 
 		$client->request(
 			'POST',
@@ -791,10 +791,10 @@ 
 		);
 
 		$cookieJar = $client->getCookieJar();
-		$cookieJar->updateFromResponse( $client->getInternalResponse() );
-		$cookie = $cookieJar->get( ShowDonationConfirmationHandler::SUBMISSION_COOKIE_NAME );
-		$this->assertTrue( $cookie->isSecure() );
-		$this->assertTrue( $cookie->isHttpOnly() );
+		$cookieJar->updateFromResponse($client->getInternalResponse());
+		$cookie = $cookieJar->get(ShowDonationConfirmationHandler::SUBMISSION_COOKIE_NAME);
+		$this->assertTrue($cookie->isSecure());
+		$this->assertTrue($cookie->isHttpOnly());
 	}
 
 }

tests/EdgeToEdge/Routes/ApplyForMembershipRouteTest.php

Spacing +70 added lines, -70 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\Tests\EdgeToEdge\Routes;
 
@@ -31,30 +31,30 @@ 
 	public function testGivenGetRequestMembership_formIsShown(): void {
 		$client = $this->createClient();
 
-		$crawler = $client->request( 'GET', 'apply-for-membership' );
+		$crawler = $client->request('GET', 'apply-for-membership');
 
 		$this->assertCount(
 			1,
-			$crawler->filter( 'form#memForm[method="POST"][action="/apply-for-membership"]' )
+			$crawler->filter('form#memForm[method="POST"][action="/apply-for-membership"]')
 		);
 		$this->assertCount(
 			1,
-			$crawler->filter( 'input[name="showMembershipTypeOption"][type="hidden"][value="true"]' )
+			$crawler->filter('input[name="showMembershipTypeOption"][type="hidden"][value="true"]')
 		);
 	}
 
 	public function testGivenGetRequestSustainingMembership_formIsShown(): void {
 		$client = $this->createClient();
 
-		$crawler = $client->request( 'GET', 'apply-for-membership', ['type' => 'sustaining'] );
+		$crawler = $client->request('GET', 'apply-for-membership', ['type' => 'sustaining']);
 
 		$this->assertCount(
 			1,
-			$crawler->filter( 'form#memForm[method="POST"][action="/apply-for-membership"]' )
+			$crawler->filter('form#memForm[method="POST"][action="/apply-for-membership"]')
 		);
 		$this->assertCount(
 			1,
-			$crawler->filter( 'input[name="showMembershipTypeOption"][type="hidden"][value="false"]' )
+			$crawler->filter('input[name="showMembershipTypeOption"][type="hidden"][value="false"]')
 		);
 	}
 
@@ -99,7 +99,7 @@ 
 		$httpParameters = $this->newValidHttpParameters();
 		$httpParameters['membership_fee'] = '1.00'; // TODO: change to localized
 
-		$client->request( 'POST', 'apply-for-membership', $httpParameters );
+		$client->request('POST', 'apply-for-membership', $httpParameters);
 
 		$this->assertInitialFormValues(
 			[
@@ -140,13 +140,13 @@ 
 
 		$this->assertCount(
 			1,
-			$crawler->filter( 'input[type="hidden"][name="showMembershipTypeOption"][value="true"]' )
+			$crawler->filter('input[type="hidden"][name="showMembershipTypeOption"][value="true"]')
 		);
 	}
 
 	public function testGivenValidRequest_applicationIsPersisted(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
-			$factory->setPaymentDelayCalculator( $this->newFixedPaymentDelayCalculator() );
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
+			$factory->setPaymentDelayCalculator($this->newFixedPaymentDelayCalculator());
 
 			$client->request(
 				'POST',
@@ -154,20 +154,20 @@ 
 				$this->newValidHttpParameters()
 			);
 
-			$application = $factory->getMembershipApplicationRepository()->getApplicationById( 1 );
+			$application = $factory->getMembershipApplicationRepository()->getApplicationById(1);
 
-			$this->assertNotNull( $application );
+			$this->assertNotNull($application);
 
 			$expectedApplication = ValidMembershipApplication::newAutoConfirmedDomainEntity();
-			$expectedApplication->assignId( 1 );
+			$expectedApplication->assignId(1);
 
-			$this->assertEquals( $expectedApplication, $application );
+			$this->assertEquals($expectedApplication, $application);
 		} );
 	}
 
 	public function testGivenValidRequest_confirmationPageContainsCancellationParameters(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
-			$factory->setTokenGenerator( new FixedTokenGenerator( self::FIXED_TOKEN ) );
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
+			$factory->setTokenGenerator(new FixedTokenGenerator(self::FIXED_TOKEN));
 
 			$client->request(
 				'POST',
@@ -177,14 +177,14 @@ 
 
 			$responseContent = $client->getResponse()->getContent();
 
-			$this->assertContains( 'id=1', $responseContent );
-			$this->assertContains( 'accessToken=' . self::FIXED_TOKEN, $responseContent );
+			$this->assertContains('id=1', $responseContent);
+			$this->assertContains('accessToken=' . self::FIXED_TOKEN, $responseContent);
 		} );
 	}
 
 	public function testGivenValidRequest_requestIsRedirected(): void {
 		$client = $this->createClient();
-		$client->followRedirects( false );
+		$client->followRedirects(false);
 
 		$client->request(
 			'POST',
@@ -193,8 +193,8 @@ 
 		);
 
 		$response = $client->getResponse();
-		$this->assertTrue( $response->isRedirect() );
-		$this->assertContains( 'show-membership-confirmation', $response->headers->get( 'Location' ) );
+		$this->assertTrue($response->isRedirect());
+		$this->assertContains('show-membership-confirmation', $response->headers->get('Location'));
 	}
 
 	public function testWhenApplicationGetsPersisted_timestampIsStoredInCookie(): void {
@@ -205,15 +205,15 @@ 
 			$this->newValidHttpParameters()
 		);
 
-		$cookie = $client->getCookieJar()->get( 'memapp_timestamp' );
-		$this->assertNotNull( $cookie );
-		$donationTimestamp = new \DateTime( $cookie->getValue() );
-		$this->assertEquals( time(), $donationTimestamp->getTimestamp(), 'Timestamp should be not more than 5 seconds old', 5.0 );
+		$cookie = $client->getCookieJar()->get('memapp_timestamp');
+		$this->assertNotNull($cookie);
+		$donationTimestamp = new \DateTime($cookie->getValue());
+		$this->assertEquals(time(), $donationTimestamp->getTimestamp(), 'Timestamp should be not more than 5 seconds old', 5.0);
 	}
 
 	public function testWhenMultipleMembershipFormSubmissions_requestGetsRejected(): void {
 		$client = $this->createClient();
-		$client->getCookieJar()->set( new Cookie( 'memapp_timestamp', $this->getPastTimestamp() ) );
+		$client->getCookieJar()->set(new Cookie('memapp_timestamp', $this->getPastTimestamp()));
 
 		$client->request(
 			'POST',
@@ -221,12 +221,12 @@ 
 			$this->newValidHttpParameters()
 		);
 
-		$this->assertContains( 'membership_application_rejected_limit', $client->getResponse()->getContent() );
+		$this->assertContains('membership_application_rejected_limit', $client->getResponse()->getContent());
 	}
 
 	public function testWhenMultipleMembershipInAccordanceToTimeLimit_isNotRejected(): void {
 		$client = $this->createClient();
-		$client->getCookieJar()->set( new Cookie( 'memapp_timestamp', $this->getPastTimestamp( 'PT12M' ) ) );
+		$client->getCookieJar()->set(new Cookie('memapp_timestamp', $this->getPastTimestamp('PT12M')));
 
 		$client->request(
 			'POST',
@@ -234,16 +234,16 @@ 
 			$this->newValidHttpParameters()
 		);
 
-		$this->assertNotContains( 'membership_application_rejected_limit', $client->getResponse()->getContent() );
+		$this->assertNotContains('membership_application_rejected_limit', $client->getResponse()->getContent());
 	}
 
-	private function getPastTimestamp( string $interval = 'PT10S' ): string {
-		return ( new \DateTime() )->sub( new \DateInterval( $interval ) )->format( 'Y-m-d H:i:s' );
+	private function getPastTimestamp(string $interval = 'PT10S'): string {
+		return (new \DateTime())->sub(new \DateInterval($interval))->format('Y-m-d H:i:s');
 	}
 
 	public function testWhenTrackingCookieExists_valueIsPersisted(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
-			$client->getCookieJar()->set( new Cookie( 'spenden_tracking', 'test/blue' ) );
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
+			$client->getCookieJar()->set(new Cookie('spenden_tracking', 'test/blue'));
 
 			$client->request(
 				'POST',
@@ -251,21 +251,21 @@ 
 				$this->newValidHttpParameters()
 			);
 
-			$application = $this->getApplicationFromDatabase( $factory );
-			$this->assertSame( 'test/blue', $application->getTracking() );
+			$application = $this->getApplicationFromDatabase($factory);
+			$this->assertSame('test/blue', $application->getTracking());
 		} );
 	}
 
-	private function getApplicationFromDatabase( FunFunFactory $factory ): MembershipApplication {
-		$repository = $factory->getEntityManager()->getRepository( MembershipApplication::class );
-		$application = $repository->find( 1 );
-		$this->assertInstanceOf( MembershipApplication::class, $application );
+	private function getApplicationFromDatabase(FunFunFactory $factory): MembershipApplication {
+		$repository = $factory->getEntityManager()->getRepository(MembershipApplication::class);
+		$application = $repository->find(1);
+		$this->assertInstanceOf(MembershipApplication::class, $application);
 		return $application;
 	}
 
 	public function testGivenValidRequestUsingPayPal_applicationIsPersisted(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
-			$factory->setPaymentDelayCalculator( $this->newFixedPaymentDelayCalculator() );
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
+			$factory->setPaymentDelayCalculator($this->newFixedPaymentDelayCalculator());
 
 			$client->request(
 				'POST',
@@ -273,18 +273,18 @@ 
 				$this->newValidHttpParametersUsingPayPal()
 			);
 
-			$application = $factory->getMembershipApplicationRepository()->getApplicationById( 1 );
+			$application = $factory->getMembershipApplicationRepository()->getApplicationById(1);
 
-			$this->assertNotNull( $application );
+			$this->assertNotNull($application);
 
 			$payPalData = new PayPalData();
-			$payPalData->setFirstPaymentDate( self::FIRST_PAYMENT_DATE );
+			$payPalData->setFirstPaymentDate(self::FIRST_PAYMENT_DATE);
 			$payPalData->freeze();
 
-			$expectedApplication = ValidMembershipApplication::newDomainEntityUsingPayPal( $payPalData );
-			$expectedApplication->assignId( 1 );
+			$expectedApplication = ValidMembershipApplication::newDomainEntityUsingPayPal($payPalData);
+			$expectedApplication->assignId(1);
 
-			$this->assertEquals( $expectedApplication, $application );
+			$this->assertEquals($expectedApplication, $application);
 		} );
 	}
 
@@ -319,7 +319,7 @@ 
 
 	public function testGivenValidRequestUsingPayPal_requestIsRedirectedToPayPalUrl(): void {
 		$client = $this->createClient();
-		$client->followRedirects( false );
+		$client->followRedirects(false);
 
 		$client->request(
 			'POST',
@@ -328,13 +328,13 @@ 
 		);
 
 		$response = $client->getResponse();
-		$this->assertTrue( $response->isRedirect() );
-		$this->assertContains( 'sandbox.paypal.com', $response->headers->get( 'Location' ) );
+		$this->assertTrue($response->isRedirect());
+		$this->assertContains('sandbox.paypal.com', $response->headers->get('Location'));
 	}
 
 	public function testWhenRedirectingToPayPal_translatedItemNameIsPassed(): void {
 		$client = $this->createClient();
-		$client->followRedirects( false );
+		$client->followRedirects(false);
 
 		$client->request(
 			'POST',
@@ -343,12 +343,12 @@ 
 		);
 
 		$response = $client->getResponse();
-		$this->assertSame( 302, $response->getStatusCode() );
-		$this->assertContains( 'item_name=item_name_membership', $response->getContent() );
+		$this->assertSame(302, $response->getStatusCode());
+		$this->assertContains('item_name=item_name_membership', $response->getContent());
 	}
 
 	public function testCommasInStreetNamesAreRemoved(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 
 			$params = $this->newValidHttpParameters();
 			$params['strasse'] = 'Nyan, street, ';
@@ -358,20 +358,20 @@ 
 				$params
 			);
 
-			$application = $factory->getMembershipApplicationRepository()->getApplicationById( 1 );
+			$application = $factory->getMembershipApplicationRepository()->getApplicationById(1);
 
-			$this->assertNotNull( $application );
+			$this->assertNotNull($application);
 
 			$expectedApplication = ValidMembershipApplication::newDomainEntity();
-			$expectedApplication->assignId( 1 );
+			$expectedApplication->assignId(1);
 			$expectedApplication->confirm();
 
-			$this->assertEquals( $expectedApplication, $application );
+			$this->assertEquals($expectedApplication, $application);
 		} );
 	}
 
 	public function testWhenCompaniesApply_salutationIsSetToFixedValue(): void {
-		$this->createEnvironment( [], function ( Client $client, FunFunFactory $factory ) {
+		$this->createEnvironment([], function(Client $client, FunFunFactory $factory) {
 
 			$params = $this->newValidHttpParametersForCompanies();
 			$client->request(
@@ -380,15 +380,15 @@ 
 				$params
 			);
 
-			$application = $factory->getMembershipApplicationRepository()->getApplicationById( 1 );
+			$application = $factory->getMembershipApplicationRepository()->getApplicationById(1);
 
-			$this->assertNotNull( $application );
+			$this->assertNotNull($application);
 
 			$expectedApplication = ValidMembershipApplication::newCompanyApplication();
-			$expectedApplication->assignId( 1 );
+			$expectedApplication->assignId(1);
 			$expectedApplication->confirm();
 
-			$this->assertEquals( $expectedApplication, $application );
+			$this->assertEquals($expectedApplication, $application);
 		} );
 	}
 
@@ -422,14 +422,14 @@ 
 
 	private function newFixedPaymentDelayCalculator(): PaymentDelayCalculator {
 		return new FixedPaymentDelayCalculator(
-			new \DateTime( self::FIRST_PAYMENT_DATE )
+			new \DateTime(self::FIRST_PAYMENT_DATE)
 		);
 	}
 
 	public function testCookieFlagsSecureAndHttpOnlyAreSet(): void {
 		$client = new Client(
 			$this->createSilexApplication(),
-			[ 'HTTPS' => true ]
+			['HTTPS' => true]
 		);
 
 		$client->request(
@@ -439,11 +439,11 @@ 
 		);
 
 		$cookieJar = $client->getCookieJar();
-		$cookieJar->updateFromResponse( $client->getInternalResponse() );
-		$cookie = $cookieJar->get( ShowMembershipConfirmationHandler::SUBMISSION_COOKIE_NAME );
+		$cookieJar->updateFromResponse($client->getInternalResponse());
+		$cookie = $cookieJar->get(ShowMembershipConfirmationHandler::SUBMISSION_COOKIE_NAME);
 
-		$this->assertTrue( $cookie->isHttpOnly() );
-		$this->assertTrue( $cookie->isSecure() );
+		$this->assertTrue($cookie->isHttpOnly());
+		$this->assertTrue($cookie->isSecure());
 	}
 
 }