wmde / FundraisingFrontend

src/Factories/FunFunFactory.php

Spacing +159 added lines, -159 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\Factories;
 
@@ -169,7 +169,7 @@ 
 	 */
 	private $profiler = null;
 
-	public function __construct( array $config ) {
+	public function __construct(array $config) {
 		$this->config = $config;
 		$this->pimple = $this->newPimple();
 	}
@@ -177,113 +177,113 @@ 
 	private function newPimple(): \Pimple {
 		$pimple = new \Pimple();
 
-		$pimple['logger'] = $pimple->share( function() {
+		$pimple['logger'] = $pimple->share(function() {
 			return new NullLogger();
 		} );
 
-		$pimple['profiler_data_collector'] = $pimple->share( function() {
+		$pimple['profiler_data_collector'] = $pimple->share(function() {
 			return new ProfilerDataCollector();
 		} );
 
-		$pimple['dbal_connection'] = $pimple->share( function() {
-			return DriverManager::getConnection( $this->config['db'] );
+		$pimple['dbal_connection'] = $pimple->share(function() {
+			return DriverManager::getConnection($this->config['db']);
 		} );
 
-		$pimple['entity_manager'] = $pimple->share( function() {
-			$entityManager = ( new StoreFactory( $this->getConnection() ) )->getEntityManager();
-			if ( $this->addDoctrineSubscribers ) {
-				$entityManager->getEventManager()->addEventSubscriber( $this->newDoctrineDonationPrePersistSubscriber() );
-				$entityManager->getEventManager()->addEventSubscriber( $this->newDoctrineMembershipApplicationPrePersistSubscriber() );
+		$pimple['entity_manager'] = $pimple->share(function() {
+			$entityManager = (new StoreFactory($this->getConnection()))->getEntityManager();
+			if ($this->addDoctrineSubscribers) {
+				$entityManager->getEventManager()->addEventSubscriber($this->newDoctrineDonationPrePersistSubscriber());
+				$entityManager->getEventManager()->addEventSubscriber($this->newDoctrineMembershipApplicationPrePersistSubscriber());
 			}
 
 			return $entityManager;
 		} );
 
-		$pimple['subscription_repository'] = $pimple->share( function() {
+		$pimple['subscription_repository'] = $pimple->share(function() {
 			return new LoggingSubscriptionRepository(
-				new DoctrineSubscriptionRepository( $this->getEntityManager() ),
+				new DoctrineSubscriptionRepository($this->getEntityManager()),
 				$this->getLogger()
 			);
 		} );
 
-		$pimple['donation_repository'] = $pimple->share( function() {
+		$pimple['donation_repository'] = $pimple->share(function() {
 			return new LoggingDonationRepository(
-				new DoctrineDonationRepository( $this->getEntityManager() ),
+				new DoctrineDonationRepository($this->getEntityManager()),
 				$this->getLogger()
 			);
 		} );
 
-		$pimple['membership_application_repository'] = $pimple->share( function() {
+		$pimple['membership_application_repository'] = $pimple->share(function() {
 			return new LoggingApplicationRepository(
-				new DoctrineApplicationRepository( $this->getEntityManager() ),
+				new DoctrineApplicationRepository($this->getEntityManager()),
 				$this->getLogger()
 			);
 		} );
 
-		$pimple['comment_repository'] = $pimple->share( function() {
+		$pimple['comment_repository'] = $pimple->share(function() {
 			$finder = new LoggingCommentFinder(
-				new DoctrineCommentFinder( $this->getEntityManager() ),
+				new DoctrineCommentFinder($this->getEntityManager()),
 				$this->getLogger()
 			);
 
-			return $this->addProfilingDecorator( $finder, 'CommentFinder' );
+			return $this->addProfilingDecorator($finder, 'CommentFinder');
 		} );
 
-		$pimple['mail_validator'] = $pimple->share( function() {
-			return new EmailValidator( new InternetDomainNameValidator() );
+		$pimple['mail_validator'] = $pimple->share(function() {
+			return new EmailValidator(new InternetDomainNameValidator());
 		} );
 
-		$pimple['subscription_validator'] = $pimple->share( function() {
+		$pimple['subscription_validator'] = $pimple->share(function() {
 			return new SubscriptionValidator(
 				$this->getEmailValidator(),
-				$this->newTextPolicyValidator( 'fields' ),
+				$this->newTextPolicyValidator('fields'),
 				$this->newSubscriptionDuplicateValidator(),
 				$this->newHonorificValidator()
 			);
 		} );
 
-		$pimple['template_name_validator'] = $pimple->share( function() {
-			return new TemplateNameValidator( $this->getTwig() );
+		$pimple['template_name_validator'] = $pimple->share(function() {
+			return new TemplateNameValidator($this->getTwig());
 		} );
 
-		$pimple['contact_validator'] = $pimple->share( function() {
-			return new GetInTouchValidator( $this->getEmailValidator() );
+		$pimple['contact_validator'] = $pimple->share(function() {
+			return new GetInTouchValidator($this->getEmailValidator());
 		} );
 
-		$pimple['greeting_generator'] = $pimple->share( function() {
+		$pimple['greeting_generator'] = $pimple->share(function() {
 			return new GreetingGenerator();
 		} );
 
-		$pimple['mw_api'] = $pimple->share( function() {
+		$pimple['mw_api'] = $pimple->share(function() {
 			return new MediawikiApi(
 				$this->config['cms-wiki-api-url'],
 				$this->getGuzzleClient()
 			);
 		} );
 
-		$pimple['guzzle_client'] = $pimple->share( function() {
+		$pimple['guzzle_client'] = $pimple->share(function() {
 			$middlewareFactory = new MiddlewareFactory();
-			$middlewareFactory->setLogger( $this->getLogger() );
+			$middlewareFactory->setLogger($this->getLogger());
 
-			$handlerStack = HandlerStack::create( new CurlHandler() );
-			$handlerStack->push( $middlewareFactory->retry() );
+			$handlerStack = HandlerStack::create(new CurlHandler());
+			$handlerStack->push($middlewareFactory->retry());
 
-			$guzzle = new Client( [
+			$guzzle = new Client([
 				'cookies' => true,
 				'handler' => $handlerStack,
-				'headers' => [ 'User-Agent' => 'WMDE Fundraising Frontend' ],
-			] );
+				'headers' => ['User-Agent' => 'WMDE Fundraising Frontend'],
+			]);
 
-			return $this->addProfilingDecorator( $guzzle, 'Guzzle Client' );
+			return $this->addProfilingDecorator($guzzle, 'Guzzle Client');
 		} );
 
-		$pimple['translator'] = $pimple->share( function() {
+		$pimple['translator'] = $pimple->share(function() {
 			$translationFactory = new TranslationFactory();
 			$loaders = [
 				'json' => $translationFactory->newJsonLoader()
 			];
 			$locale = $this->config['locale'];
-			$translator = $translationFactory->create( $loaders, $locale );
+			$translator = $translationFactory->create($loaders, $locale);
 			$translator->addResource(
 				'json',
 				__DIR__ . '/../../app/translations/messages.' . $locale . '.json',
@@ -322,36 +322,36 @@ 
 		} );
 
 		// In the future, this could be locale-specific or filled from a DB table
-		$pimple['honorifics'] = $pimple->share( function() {
-			return new Honorifics( [
+		$pimple['honorifics'] = $pimple->share(function() {
+			return new Honorifics([
 				'' => 'Kein Titel',
 				'Dr.' => 'Dr.',
 				'Prof.' => 'Prof.',
 				'Prof. Dr.' => 'Prof. Dr.'
-			] );
+			]);
 		} );
 
-		$pimple['twig_factory'] = $pimple->share( function () {
+		$pimple['twig_factory'] = $pimple->share(function() {
 			// TODO: like this we end up with two Twig instance, one created here and on in the framework
-			return new TwigFactory( $this->config['twig'], $this->getCachePath() . '/twig' );
+			return new TwigFactory($this->config['twig'], $this->getCachePath() . '/twig');
 		} );
 
-		$pimple['twig'] = $pimple->share( function() {
+		$pimple['twig'] = $pimple->share(function() {
 			$twigFactory = $this->getTwigFactory();
-			$loaders = array_filter( [
+			$loaders = array_filter([
 				$twigFactory->newFileSystemLoader(),
 				$twigFactory->newArrayLoader(), // This is just a fallback for testing
-				$twigFactory->newWikiPageLoader( $this->newWikiPageRetriever() ),
-			] );
+				$twigFactory->newWikiPageLoader($this->newWikiPageRetriever()),
+			]);
 			$extensions = [
-				$twigFactory->newTranslationExtension( $this->getTranslator() ),
+				$twigFactory->newTranslationExtension($this->getTranslator()),
 				new Twig_Extensions_Extension_Intl()
 			];
 
-			return $twigFactory->create( $loaders, $extensions );
+			return $twigFactory->create($loaders, $extensions);
 		} );
 
-		$pimple['messenger'] = $pimple->share( function() {
+		$pimple['messenger'] = $pimple->share(function() {
 			return new Messenger(
 				new Swift_MailTransport(),
 				$this->getOperatorAddress(),
@@ -359,11 +359,11 @@ 
 			);
 		} );
 
-		$pimple['confirmation-page-selector'] = $pimple->share( function() {
-			return new DonationConfirmationPageSelector( $this->config['confirmation-pages'] );
+		$pimple['confirmation-page-selector'] = $pimple->share(function() {
+			return new DonationConfirmationPageSelector($this->config['confirmation-pages']);
 		} );
 
-		$pimple['paypal-payment-notification-verifier'] = $pimple->share( function() {
+		$pimple['paypal-payment-notification-verifier'] = $pimple->share(function() {
 			return new LoggingPaymentNotificationVerifier(
 				new PayPalPaymentNotificationVerifier(
 					new Client(),
@@ -373,7 +373,7 @@ 
 			);
 		} );
 
-		$pimple['credit-card-api-service'] = $pimple->share( function() {
+		$pimple['credit-card-api-service'] = $pimple->share(function() {
 			return new McpCreditCardService(
 				new TNvpServiceDispatcher(
 					'IMcpCreditcardService_v1_5',
@@ -384,14 +384,14 @@ 
 			);
 		} );
 
-		$pimple['token_generator'] = $pimple->share( function() {
+		$pimple['token_generator'] = $pimple->share(function() {
 			return new RandomTokenGenerator(
 				$this->config['token-length'],
-				new \DateInterval( $this->config['token-validity-timestamp'] )
+				new \DateInterval($this->config['token-validity-timestamp'])
 			);
 		} );
 
-		$pimple['page_cache'] = $pimple->share( function() {
+		$pimple['page_cache'] = $pimple->share(function() {
 			return new VoidCache();
 		} );
 
@@ -408,17 +408,17 @@ 
 
 	private function newDonationEventLogger(): DonationEventLogger {
 		return new BestEffortDonationEventLogger(
-			new DoctrineDonationEventLogger( $this->getEntityManager() ),
+			new DoctrineDonationEventLogger($this->getEntityManager()),
 			$this->getLogger()
 		);
 	}
 
 	public function newInstaller(): Installer {
-		return ( new StoreFactory( $this->getConnection() ) )->newInstaller();
+		return (new StoreFactory($this->getConnection()))->newInstaller();
 	}
 
 	public function newListCommentsUseCase(): ListCommentsUseCase {
-		return new ListCommentsUseCase( $this->getCommentFinder() );
+		return new ListCommentsUseCase($this->getCommentFinder());
 	}
 
 	public function newCommentListJsonPresenter(): CommentListJsonPresenter {
@@ -426,14 +426,14 @@ 
 	}
 
 	public function newCommentListRssPresenter(): CommentListRssPresenter {
-		return new CommentListRssPresenter( new TwigTemplate(
+		return new CommentListRssPresenter(new TwigTemplate(
 			$this->getTwig(),
 			'CommentList.rss.twig'
-		) );
+		));
 	}
 
 	public function newCommentListHtmlPresenter(): CommentListHtmlPresenter {
-		return new CommentListHtmlPresenter( $this->getLayoutTemplate( 'CommentList.html.twig', [ 'piwikGoals' => [ 1 ] ] ) );
+		return new CommentListHtmlPresenter($this->getLayoutTemplate('CommentList.html.twig', ['piwikGoals' => [1]]));
 	}
 
 	private function getCommentFinder(): CommentFinder {
@@ -444,7 +444,7 @@ 
 		return $this->pimple['subscription_repository'];
 	}
 
-	public function setSubscriptionRepository( SubscriptionRepository $subscriptionRepository ) {
+	public function setSubscriptionRepository(SubscriptionRepository $subscriptionRepository) {
 		$this->pimple['subscription_repository'] = $subscriptionRepository;
 	}
 
@@ -467,26 +467,26 @@ 
 	}
 
 	public function newDisplayPagePresenter(): DisplayPagePresenter {
-		return new DisplayPagePresenter( $this->getLayoutTemplate( 'DisplayPageLayout.twig' ) );
+		return new DisplayPagePresenter($this->getLayoutTemplate('DisplayPageLayout.twig'));
 	}
 
 	public function newAddSubscriptionHTMLPresenter(): AddSubscriptionHtmlPresenter {
-		return new AddSubscriptionHtmlPresenter( $this->getIncludeTemplate( 'Subscription_Form.twig' ), $this->getTranslator() );
+		return new AddSubscriptionHtmlPresenter($this->getIncludeTemplate('Subscription_Form.twig'), $this->getTranslator());
 	}
 
 	public function newConfirmSubscriptionHtmlPresenter(): ConfirmSubscriptionHtmlPresenter {
 		return new ConfirmSubscriptionHtmlPresenter(
-			$this->getLayoutTemplate( 'ConfirmSubscription.html.twig' ),
+			$this->getLayoutTemplate('ConfirmSubscription.html.twig'),
 			$this->getTranslator()
 		);
 	}
 
 	public function newAddSubscriptionJSONPresenter(): AddSubscriptionJsonPresenter {
-		return new AddSubscriptionJsonPresenter( $this->getTranslator() );
+		return new AddSubscriptionJsonPresenter($this->getTranslator());
 	}
 
 	public function newGetInTouchHTMLPresenter(): GetInTouchHtmlPresenter {
-		return new GetInTouchHtmlPresenter( $this->getIncludeTemplate( 'Kontaktformular.twig' ), $this->getTranslator() );
+		return new GetInTouchHtmlPresenter($this->getIncludeTemplate('Kontaktformular.twig'), $this->getTranslator());
 	}
 
 	public function getTwig(): Twig_Environment {
@@ -499,11 +499,11 @@ 
 	 * @param string $templateName
 	 * @return TwigTemplate
 	 */
-	private function getLayoutTemplate( string $templateName, array $context = [] ): TwigTemplate {
+	private function getLayoutTemplate(string $templateName, array $context = []): TwigTemplate {
 		 return new TwigTemplate(
 			$this->getTwig(),
 			$templateName,
-			array_merge( $this->getDefaultTwigVariables(), $context )
+			array_merge($this->getDefaultTwigVariables(), $context)
 		);
 	}
 
@@ -513,13 +513,13 @@ 
 	 * @param string $templateName Template to include
 	 * @return TwigTemplate
 	 */
-	private function getIncludeTemplate( string $templateName, array $context = [] ): TwigTemplate {
+	private function getIncludeTemplate(string $templateName, array $context = []): TwigTemplate {
 		return new TwigTemplate(
 			$this->getTwig(),
 			'IncludeInLayout.twig',
 			array_merge(
 				$this->getDefaultTwigVariables(),
-				[ 'main_template' => $templateName ],
+				['main_template' => $templateName],
 				$context
 			)
 		);
@@ -547,7 +547,7 @@ 
 		return $this->pimple['mw_api'];
 	}
 
-	public function setMediaWikiApi( MediawikiApi $api ) {
+	public function setMediaWikiApi(MediawikiApi $api) {
 		$this->pimple['mw_api'] = $api;
 	}
 
@@ -562,7 +562,7 @@ 
 			$this->config['cms-wiki-title-prefix']
 		);
 
-		return $this->addProfilingDecorator( $PageRetriever, 'PageRetriever' );
+		return $this->addProfilingDecorator($PageRetriever, 'PageRetriever');
 	}
 
 	private function newCachedPageRetriever(): PageRetriever {
@@ -575,7 +575,7 @@ 
 	private function newNonCachedApiPageRetriever(): PageRetriever {
 		return new ApiBasedPageRetriever(
 			$this->getMediaWikiApi(),
-			new ApiUser( $this->config['cms-wiki-user'], $this->config['cms-wiki-password'] ),
+			new ApiUser($this->config['cms-wiki-user'], $this->config['cms-wiki-password']),
 			$this->getLogger()
 		);
 	}
@@ -640,22 +640,22 @@ 
 			new TwigTemplate(
 					$this->getTwig(),
 					'Mail_Subscription_Confirmation.twig',
-					[ 'greeting_generator' => $this->getGreetingGenerator() ]
+					['greeting_generator' => $this->getGreetingGenerator()]
 			),
 			'mail_subject_membership'
 		);
 	}
 
-	private function newTemplateMailer( TwigTemplate $template, string $messageKey ): TemplateBasedMailer {
+	private function newTemplateMailer(TwigTemplate $template, string $messageKey): TemplateBasedMailer {
 		$mailer = new TemplateBasedMailer(
 			$this->getMessenger(),
 			$template,
-			$this->getTranslator()->trans( $messageKey )
+			$this->getTranslator()->trans($messageKey)
 		);
 
-		$mailer = new LoggingMailer( $mailer, $this->getLogger() );
+		$mailer = new LoggingMailer($mailer, $this->getLogger());
 
-		return $this->addProfilingDecorator( $mailer, 'Mailer' );
+		return $this->addProfilingDecorator($mailer, 'Mailer');
 	}
 
 	public function getGreetingGenerator() {
@@ -663,11 +663,11 @@ 
 	}
 
 	public function newCheckIbanUseCase(): CheckIbanUseCase {
-		return new CheckIbanUseCase( $this->newBankDataConverter() );
+		return new CheckIbanUseCase($this->newBankDataConverter());
 	}
 
 	public function newGenerateIbanUseCase(): GenerateIbanUseCase {
-		return new GenerateIbanUseCase( $this->newBankDataConverter() );
+		return new GenerateIbanUseCase($this->newBankDataConverter());
 	}
 
 	public function newIbanPresenter(): IbanPresenter {
@@ -675,14 +675,14 @@ 
 	}
 
 	public function newBankDataConverter() {
-		return new BankDataConverter( $this->config['bank-data-file'] );
+		return new BankDataConverter($this->config['bank-data-file']);
 	}
 
-	public function setSubscriptionValidator( SubscriptionValidator $subscriptionValidator ) {
+	public function setSubscriptionValidator(SubscriptionValidator $subscriptionValidator) {
 		$this->pimple['subscription_validator'] = $subscriptionValidator;
 	}
 
-	public function setPageTitlePrefix( string $prefix ) {
+	public function setPageTitlePrefix(string $prefix) {
 		$this->config['cms-wiki-title-prefix'] = $prefix;
 	}
 
@@ -696,7 +696,7 @@ 
 
 	private function newContactConfirmationMailer(): TemplateBasedMailer {
 		return $this->newTemplateMailer(
-			new TwigTemplate( $this->getTwig(), 'KontaktMailExtern.twig' ),
+			new TwigTemplate($this->getTwig(), 'KontaktMailExtern.twig'),
 			'mail_subject_getintouch'
 		);
 	}
@@ -714,12 +714,12 @@ 
 
 	private function newSubscriptionDuplicateCutoffDate(): \DateTime {
 		$cutoffDateTime = new \DateTime();
-		$cutoffDateTime->sub( new \DateInterval( $this->config['subscription-interval'] ) );
+		$cutoffDateTime->sub(new \DateInterval($this->config['subscription-interval']));
 		return $cutoffDateTime;
 	}
 
 	private function newHonorificValidator(): AllowedValuesValidator {
-		return new AllowedValuesValidator( $this->getHonorifics()->getKeys() );
+		return new AllowedValuesValidator($this->getHonorifics()->getKeys());
 	}
 
 	private function getHonorifics(): Honorifics {
@@ -728,47 +728,47 @@ 
 
 	public function newPurgeCacheUseCase(): PurgeCacheUseCase {
 		return new PurgeCacheUseCase(
-			new AllOfTheCachePurger( $this->getTwig(), $this->getPageCache() ),
+			new AllOfTheCachePurger($this->getTwig(), $this->getPageCache()),
 			$this->config['purging-secret']
 		);
 	}
 
 	private function newBankDataValidator(): BankDataValidator {
-		return new BankDataValidator( new IbanValidator( $this->newBankDataConverter() ) );
+		return new BankDataValidator(new IbanValidator($this->newBankDataConverter()));
 	}
 
 	private function getMessenger(): Messenger {
 		return $this->pimple['messenger'];
 	}
 
-	public function setMessenger( Messenger $messenger ) {
+	public function setMessenger(Messenger $messenger) {
 		$this->pimple['messenger'] = $messenger;
 	}
 
 	public function setNullMessenger() {
-		$this->setMessenger( new Messenger(
+		$this->setMessenger(new Messenger(
 			Swift_NullTransport::newInstance(),
 			$this->getOperatorAddress()
-		) );
+		));
 	}
 
 	public function getOperatorAddress() {
-		return new EmailAddress( $this->config['operator-email'] );
+		return new EmailAddress($this->config['operator-email']);
 	}
 
 	public function newInternalErrorHTMLPresenter(): InternalErrorHtmlPresenter {
-		return new InternalErrorHtmlPresenter( $this->getIncludeTemplate( 'ErrorPage.twig' ) );
+		return new InternalErrorHtmlPresenter($this->getIncludeTemplate('ErrorPage.twig'));
 	}
 
 	public function newAccessDeniedHTMLPresenter(): InternalErrorHtmlPresenter {
-		return new InternalErrorHtmlPresenter( $this->getLayoutTemplate( 'AccessDenied.twig' ) );
+		return new InternalErrorHtmlPresenter($this->getLayoutTemplate('AccessDenied.twig'));
 	}
 
 	public function getTranslator(): TranslatorInterface {
 		return $this->pimple['translator'];
 	}
 
-	public function setTranslator( TranslatorInterface $translator ) {
+	public function setTranslator(TranslatorInterface $translator) {
 		$this->pimple['translator'] = $translator;
 	}
 
@@ -776,25 +776,25 @@ 
 		return $this->pimple['twig_factory'];
 	}
 
-	private function newTextPolicyValidator( string $policyName ): TextPolicyValidator {
+	private function newTextPolicyValidator(string $policyName): TextPolicyValidator {
 		$contentProvider = $this->newWikiPageRetriever();
 		$textPolicyConfig = $this->config['text-policies'][$policyName];
 
 		return new TextPolicyValidator(
-			new PageRetrieverBasedStringList( $contentProvider, $textPolicyConfig['badwords'] ?? '' ),
-			new PageRetrieverBasedStringList( $contentProvider, $textPolicyConfig['whitewords'] ?? '' )
+			new PageRetrieverBasedStringList($contentProvider, $textPolicyConfig['badwords'] ?? ''),
+			new PageRetrieverBasedStringList($contentProvider, $textPolicyConfig['whitewords'] ?? '')
 		);
 	}
 
 	private function newCommentPolicyValidator(): TextPolicyValidator {
-		return $this->newTextPolicyValidator( 'comment' );
+		return $this->newTextPolicyValidator('comment');
 	}
 
-	public function newCancelDonationUseCase( string $updateToken ): CancelDonationUseCase {
+	public function newCancelDonationUseCase(string $updateToken): CancelDonationUseCase {
 		return new CancelDonationUseCase(
 			$this->getDonationRepository(),
 			$this->newCancelDonationMailer(),
-			$this->newDonationAuthorizer( $updateToken ),
+			$this->newDonationAuthorizer($updateToken),
 			$this->newDonationEventLogger()
 		);
 	}
@@ -804,7 +804,7 @@ 
 			new TwigTemplate(
 				$this->getTwig(),
 				'Mail_Donation_Cancellation_Confirmation.twig',
-				[ 'greeting_generator' => $this->getGreetingGenerator() ]
+				['greeting_generator' => $this->getGreetingGenerator()]
 			),
 			'mail_subject_confirm_cancellation'
 		);
@@ -862,19 +862,19 @@ 
 	}
 
 	public function newPayPalUrlGenerator() {
-		return new PayPalUrlGenerator( $this->getPayPalUrlConfig() );
+		return new PayPalUrlGenerator($this->getPayPalUrlConfig());
 	}
 
 	private function getPayPalUrlConfig() {
-		return PayPalUrlConfig::newFromConfig( $this->config['paypal'] );
+		return PayPalUrlConfig::newFromConfig($this->config['paypal']);
 	}
 
 	private function newCreditCardUrlGenerator() {
-		return new CreditCardUrlGenerator( $this->newCreditCardUrlConfig() );
+		return new CreditCardUrlGenerator($this->newCreditCardUrlConfig());
 	}
 
 	private function newCreditCardUrlConfig() {
-		return CreditCardUrlConfig::newFromConfig( $this->config['creditcard'] );
+		return CreditCardUrlConfig::newFromConfig($this->config['creditcard']);
 	}
 
 	public function getDonationRepository(): DonationRepository {
@@ -882,27 +882,27 @@ 
 	}
 
 	public function newAmountValidator(): AmountValidator {
-		return new AmountValidator( 1 );
+		return new AmountValidator(1);
 	}
 
 	private function newAmountFormatter(): AmountFormatter {
-		return new AmountFormatter( $this->config['locale'] );
+		return new AmountFormatter($this->config['locale']);
 	}
 
 	public function newDecimalNumberFormatter(): NumberFormatter {
-		return new NumberFormatter( $this->config['locale'], NumberFormatter::DECIMAL );
+		return new NumberFormatter($this->config['locale'], NumberFormatter::DECIMAL);
 	}
 
-	public function newAddCommentUseCase( string $updateToken ): AddCommentUseCase {
+	public function newAddCommentUseCase(string $updateToken): AddCommentUseCase {
 		return new AddCommentUseCase(
 			$this->getDonationRepository(),
-			$this->newDonationAuthorizer( $updateToken ),
+			$this->newDonationAuthorizer($updateToken),
 			$this->newCommentPolicyValidator(),
 			$this->newAddCommentValidator()
 		);
 	}
 
-	private function newDonationAuthorizer( string $updateToken = null, string $accessToken = null ): DonationAuthorizer {
+	private function newDonationAuthorizer(string $updateToken = null, string $accessToken = null): DonationAuthorizer {
 		return new DoctrineDonationAuthorizer(
 			$this->getEntityManager(),
 			$updateToken,
@@ -916,13 +916,13 @@ 
 
 	public function newDonationConfirmationPresenter() {
 		return new DonationConfirmationHtmlPresenter(
-			$this->getIncludeTemplate( 'DonationConfirmation.twig', [ 'piwikGoals' => [ 3 ] ] )
+			$this->getIncludeTemplate('DonationConfirmation.twig', ['piwikGoals' => [3]])
 		);
 	}
 
 	public function newCreditCardPaymentHtmlPresenter() {
 		return new CreditCardPaymentHtmlPresenter(
-			$this->getIncludeTemplate( 'CreditCardPaymentIframe.twig' ),
+			$this->getIncludeTemplate('CreditCardPaymentIframe.twig'),
 			$this->getTranslator(),
 			$this->newCreditCardUrlGenerator()
 		);
@@ -930,7 +930,7 @@ 
 
 	public function newCancelDonationHtmlPresenter() {
 		return new CancelDonationHtmlPresenter(
-			$this->getIncludeTemplate( 'Donation_Cancellation_Confirmation.twig' )
+			$this->getIncludeTemplate('Donation_Cancellation_Confirmation.twig')
 		);
 	}
 
@@ -950,7 +950,7 @@ 
 			new TwigTemplate(
 				$this->getTwig(),
 				'Mail_Membership_Application_Confirmation.twig',
-				[ 'greeting_generator' => $this->getGreetingGenerator() ]
+				['greeting_generator' => $this->getGreetingGenerator()]
 			),
 			'mail_subject_confirm_membership_application'
 		);
@@ -965,16 +965,16 @@ 
 	}
 
 	private function newMembershipApplicationTracker(): ApplicationTracker {
-		return new DoctrineApplicationTracker( $this->getEntityManager() );
+		return new DoctrineApplicationTracker($this->getEntityManager());
 	}
 
 	private function newMembershipApplicationPiwikTracker(): ApplicationPiwikTracker {
-		return new DoctrineApplicationPiwikTracker( $this->getEntityManager() );
+		return new DoctrineApplicationPiwikTracker($this->getEntityManager());
 	}
 
-	public function newCancelMembershipApplicationUseCase( string $updateToken ): CancelMembershipApplicationUseCase {
+	public function newCancelMembershipApplicationUseCase(string $updateToken): CancelMembershipApplicationUseCase {
 		return new CancelMembershipApplicationUseCase(
-			$this->newMembershipApplicationAuthorizer( $updateToken ),
+			$this->newMembershipApplicationAuthorizer($updateToken),
 			$this->getMembershipApplicationRepository(),
 			$this->newCancelMembershipApplicationMailer()
 		);
@@ -999,27 +999,27 @@ 
 			new TwigTemplate(
 				$this->getTwig(),
 				'Mail_Membership_Application_Cancellation_Confirmation.twig',
-				[ 'greeting_generator' => $this->getGreetingGenerator() ]
+				['greeting_generator' => $this->getGreetingGenerator()]
 			),
 			'mail_subject_confirm_membership_application_cancellation'
 		);
 	}
 
-	public function newMembershipApplicationConfirmationUseCase( string $accessToken ) {
+	public function newMembershipApplicationConfirmationUseCase(string $accessToken) {
 		return new ShowMembershipApplicationConfirmationUseCase(
-			$this->newMembershipApplicationAuthorizer( null, $accessToken ), $this->getMembershipApplicationRepository(),
+			$this->newMembershipApplicationAuthorizer(null, $accessToken), $this->getMembershipApplicationRepository(),
 			$this->newMembershipApplicationTokenFetcher()
 		);
 	}
 
-	public function newShowDonationConfirmationUseCase( string $accessToken ): ShowDonationConfirmationUseCase {
+	public function newShowDonationConfirmationUseCase(string $accessToken): ShowDonationConfirmationUseCase {
 		return new ShowDonationConfirmationUseCase(
-			$this->newDonationAuthorizer( null, $accessToken ),
+			$this->newDonationAuthorizer(null, $accessToken),
 			$this->getDonationRepository()
 		);
 	}
 
-	public function setDonationConfirmationPageSelector( DonationConfirmationPageSelector $selector ) {
+	public function setDonationConfirmationPageSelector(DonationConfirmationPageSelector $selector) {
 		$this->pimple['confirmation-page-selector'] = $selector;
 	}
 
@@ -1028,25 +1028,25 @@ 
 	}
 
 	public function newDonationFormViolationPresenter() {
-		$template = $this->getLayoutTemplate( 'DisplayPageLayout.twig' );
+		$template = $this->getLayoutTemplate('DisplayPageLayout.twig');
 		// TODO make this dependent on the 'form' value from the HTTP POST request
 		// (we need different form pages for A/B testing)
 		$template->context['main_template'] = 'DonationForm.twig';
-		return new DonationFormViolationPresenter( $template, $this->newAmountFormatter() );
+		return new DonationFormViolationPresenter($template, $this->newAmountFormatter());
 	}
 
 	public function newDonationFormPresenter() {
-		$template = $this->getLayoutTemplate( 'DisplayPageLayout.twig' );
+		$template = $this->getLayoutTemplate('DisplayPageLayout.twig');
 		// TODO make this dependent on the 'form' value from the HTTP POST request
 		// (we need different form pages for A/B testing)
 		$template->context['main_template'] = 'DonationForm.twig';
-		return new DonationFormPresenter( $template, $this->newAmountFormatter() );
+		return new DonationFormPresenter($template, $this->newAmountFormatter());
 	}
 
-	public function newHandlePayPalPaymentNotificationUseCase( string $updateToken ) {
+	public function newHandlePayPalPaymentNotificationUseCase(string $updateToken) {
 		return new HandlePayPalPaymentNotificationUseCase(
 			$this->getDonationRepository(),
-			$this->newDonationAuthorizer( $updateToken ),
+			$this->newDonationAuthorizer($updateToken),
 			$this->newDonationConfirmationMailer(),
 			$this->getLogger(),
 			$this->newDonationEventLogger()
@@ -1057,14 +1057,14 @@ 
 		return $this->pimple['paypal-payment-notification-verifier'];
 	}
 
-	public function setPayPalPaymentNotificationVerifier( PaymentNotificationVerifier $verifier ) {
+	public function setPayPalPaymentNotificationVerifier(PaymentNotificationVerifier $verifier) {
 		$this->pimple['paypal-payment-notification-verifier'] = $verifier;
 	}
 
-	public function newCreditCardNotificationUseCase( string $updateToken ) {
+	public function newCreditCardNotificationUseCase(string $updateToken) {
 		return new CreditCardNotificationUseCase(
 			$this->getDonationRepository(),
-			$this->newDonationAuthorizer( $updateToken ),
+			$this->newDonationAuthorizer($updateToken),
 			$this->getCreditCardService(),
 			$this->newDonationConfirmationMailer(),
 			$this->getLogger(),
@@ -1074,23 +1074,23 @@ 
 
 	public function newCancelMembershipApplicationHtmlPresenter() {
 		return new CancelMembershipApplicationHtmlPresenter(
-			$this->getIncludeTemplate( 'Membership_Application_Cancellation_Confirmation.twig' )
+			$this->getIncludeTemplate('Membership_Application_Cancellation_Confirmation.twig')
 		);
 	}
 
 	public function newMembershipApplicationConfirmationHtmlPresenter() {
 		return new MembershipApplicationConfirmationHtmlPresenter(
-			$this->getIncludeTemplate( 'MembershipApplicationConfirmation.twig' )
+			$this->getIncludeTemplate('MembershipApplicationConfirmation.twig')
 		);
 	}
 
 	public function newMembershipFormViolationPresenter() {
 		return new MembershipFormViolationPresenter(
-			$this->getIncludeTemplate( 'MembershipApplication.twig' )
+			$this->getIncludeTemplate('MembershipApplication.twig')
 		);
 	}
 
-	public function setCreditCardService( CreditCardService $ccService ) {
+	public function setCreditCardService(CreditCardService $ccService) {
 		$this->pimple['credit-card-api-service'] = $ccService;
 	}
 
@@ -1103,7 +1103,7 @@ 
 			new TwigTemplate(
 				$this->getTwig(),
 				'CreditCardPaymentNotification.twig',
-				[ 'returnUrl' => $this->config['creditcard']['return-url'] ]
+				['returnUrl' => $this->config['creditcard']['return-url']]
 			)
 		);
 	}
@@ -1124,7 +1124,7 @@ 
 		);
 	}
 
-	public function setTokenGenerator( TokenGenerator $tokenGenerator ) {
+	public function setTokenGenerator(TokenGenerator $tokenGenerator) {
 		$this->pimple['token_generator'] = $tokenGenerator;
 	}
 
@@ -1147,22 +1147,22 @@ 
 	private function newDonationPolicyValidator(): AddDonationPolicyValidator {
 		return new AddDonationPolicyValidator(
 			$this->newDonationAmountPolicyValidator(),
-			$this->newTextPolicyValidator( 'fields' )
+			$this->newTextPolicyValidator('fields')
 		);
 	}
 
 	private function newDonationAmountPolicyValidator(): AmountPolicyValidator {
 		// in the future, this might come from the configuration
-		return new AmountPolicyValidator( 1000, 200, 300 );
+		return new AmountPolicyValidator(1000, 200, 300);
 	}
 
 	public function getDonationTimeframeLimit() {
 		return $this->config['donation-timeframe-limit'];
 	}
 
-	public function newSystemMessageResponse( string $message ) {
-		$test = $this->getIncludeTemplate( 'System_Message.twig' );
-		return $test->render( [ 'message' => $message ] );
+	public function newSystemMessageResponse(string $message) {
+		$test = $this->getIncludeTemplate('System_Message.twig');
+		return $test->render(['message' => $message]);
 	}
 
 	public function getMembershipApplicationTimeframeLimit() {
@@ -1178,26 +1178,26 @@ 
 	}
 
 	public function enablePageCache() {
-		$this->pimple['page_cache'] = $this->pimple->share( function() {
-			return new FilesystemCache( $this->getCachePath() . '/pages' );
+		$this->pimple['page_cache'] = $this->pimple->share(function() {
+			return new FilesystemCache($this->getCachePath() . '/pages');
 		} );
 	}
 
-	private function addProfilingDecorator( $objectToDecorate, string $profilingLabel ) {
-		if ( $this->profiler === null ) {
+	private function addProfilingDecorator($objectToDecorate, string $profilingLabel) {
+		if ($this->profiler === null) {
 			return $objectToDecorate;
 		}
 
-		$builder = new ProfilingDecoratorBuilder( $this->profiler, $this->getProfilerDataCollector() );
+		$builder = new ProfilingDecoratorBuilder($this->profiler, $this->getProfilerDataCollector());
 
-		return $builder->decorate( $objectToDecorate, $profilingLabel );
+		return $builder->decorate($objectToDecorate, $profilingLabel);
 	}
 
-	public function setProfiler( Stopwatch $profiler ) {
+	public function setProfiler(Stopwatch $profiler) {
 		$this->profiler = $profiler;
 	}
 
-	public function setLogger( LoggerInterface $logger ) {
+	public function setLogger(LoggerInterface $logger) {
 		$this->pimple['logger'] = $logger;
 	}
 

src/MembershipApplicationContext/Infrastructure/LoggingApplicationRepository.php

Spacing +10 added lines, -10 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\Infrastructure;
 
@@ -23,7 +23,7 @@ 
 	private $logger;
 	private $logLevel;
 
-	public function __construct( ApplicationRepository $repository, LoggerInterface $logger ) {
+	public function __construct(ApplicationRepository $repository, LoggerInterface $logger) {
 		$this->repository = $repository;
 		$this->logger = $logger;
 		$this->logLevel = LogLevel::CRITICAL;
@@ -36,12 +36,12 @@ 
 	 *
 	 * @throws StoreMembershipApplicationException
 	 */
-	public function storeApplication( Application $application ) {
+	public function storeApplication(Application $application) {
 		try {
-			$this->repository->storeApplication( $application );
+			$this->repository->storeApplication($application);
 		}
-		catch ( StoreMembershipApplicationException $ex ) {
-			$this->logger->log( $this->logLevel, $ex->getMessage(), [ self::CONTEXT_EXCEPTION_KEY => $ex ] );
+		catch (StoreMembershipApplicationException $ex) {
+			$this->logger->log($this->logLevel, $ex->getMessage(), [self::CONTEXT_EXCEPTION_KEY => $ex]);
 			throw $ex;
 		}
 	}
@@ -54,12 +54,12 @@ 
 	 * @return Application|null
 	 * @throws GetMembershipApplicationException
 	 */
-	public function getApplicationById( int $id ) {
+	public function getApplicationById(int $id) {
 		try {
-			return $this->repository->getApplicationById( $id );
+			return $this->repository->getApplicationById($id);
 		}
-		catch ( GetMembershipApplicationException $ex ) {
-			$this->logger->log( $this->logLevel, $ex->getMessage(), [ self::CONTEXT_EXCEPTION_KEY => $ex ] );
+		catch (GetMembershipApplicationException $ex) {
+			$this->logger->log($this->logLevel, $ex->getMessage(), [self::CONTEXT_EXCEPTION_KEY => $ex]);
 			throw $ex;
 		}
 	}

src/MembershipApplicationContext/Domain/Model/Payment.php

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\Domain\Model;
 
@@ -21,17 +21,17 @@ 
 	 *
 	 * @throws \InvalidArgumentException
 	 */
-	public function __construct( int $intervalInMonths, Euro $amount, BankData $bankData ) {
-		$this->assertIsValidInterval( $intervalInMonths );
+	public function __construct(int $intervalInMonths, Euro $amount, BankData $bankData) {
+		$this->assertIsValidInterval($intervalInMonths);
 
 		$this->interval = $intervalInMonths;
 		$this->amount = $amount;
 		$this->bankData = $bankData;
 	}
 
-	private function assertIsValidInterval( int $intervalInMonths ) {
-		if ( !in_array( $intervalInMonths, [ 1, 3, 6, 12 ] ) ) {
-			throw new \InvalidArgumentException( 'Interval needs to be 1, 3, 6 or 12' );
+	private function assertIsValidInterval(int $intervalInMonths) {
+		if (!in_array($intervalInMonths, [1, 3, 6, 12])) {
+			throw new \InvalidArgumentException('Interval needs to be 1, 3, 6 or 12');
 		}
 	}
 
@@ -48,7 +48,7 @@ 
 	}
 
 	public function getYearlyAmount(): Euro {
-		return Euro::newFromCents( $this->amount->getEuroCents() * $this->getPaymentsPerYear() );
+		return Euro::newFromCents($this->amount->getEuroCents() * $this->getPaymentsPerYear());
 	}
 
 	private function getPaymentsPerYear(): int {

src/MembershipApplicationContext/Domain/Model/Application.php

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\Domain\Model;
 
@@ -30,7 +30,7 @@ 
 	private $needsModeration;
 	private $isCancelled;
 
-	public static function newApplication( string $type, Applicant $applicant, Payment $payment ): self {
+	public static function newApplication(string $type, Applicant $applicant, Payment $payment): self {
 		return new self(
 			null,
 			$type,
@@ -41,8 +41,8 @@ 
 		);
 	}
 
-	public function __construct( int $id = null, string $type, Applicant $applicant, Payment $payment,
-		bool $needsModeration, bool $isCancelled ) {
+	public function __construct(int $id = null, string $type, Applicant $applicant, Payment $payment,
+		bool $needsModeration, bool $isCancelled) {
 
 		$this->id = $id;
 		$this->type = $type;
@@ -79,9 +79,9 @@ 
 	 * @param int $id
 	 * @throws \RuntimeException
 	 */
-	public function assignId( int $id ) {
-		if ( $this->id !== null && $this->id !== $id ) {
-			throw new \RuntimeException( 'Id cannot be changed after initial assignment' );
+	public function assignId(int $id) {
+		if ($this->id !== null && $this->id !== $id) {
+			throw new \RuntimeException('Id cannot be changed after initial assignment');
 		}
 
 		$this->id = $id;

src/MembershipApplicationContext/Domain/Repositories/ApplicationRepository.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\Domain\Repositories;
 
@@ -21,7 +21,7 @@ 
 	 *
 	 * @throws StoreMembershipApplicationException
 	 */
-	public function storeApplication( Application $application );
+	public function storeApplication(Application $application);
 
 	/**
 	 * @param int $id
@@ -29,6 +29,6 @@ 
 	 * @return Application|null
 	 * @throws GetMembershipApplicationException
 	 */
-	public function getApplicationById( int $id );
+	public function getApplicationById(int $id);
 
 }

src/MembershipApplicationContext/DataAccess/DoctrineApplicationRepository.php

Spacing +79 added lines, -79 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\DataAccess;
 
@@ -29,102 +29,102 @@ 
 
 	private $entityManager;
 
-	public function __construct( EntityManager $entityManager ) {
+	public function __construct(EntityManager $entityManager) {
 		$this->entityManager = $entityManager;
 	}
 
-	public function storeApplication( Application $application ) {
-		if ( $application->hasId() ) {
-			$this->updateApplication( $application );
+	public function storeApplication(Application $application) {
+		if ($application->hasId()) {
+			$this->updateApplication($application);
 		}
 		else {
-			$this->insertApplication( $application );
+			$this->insertApplication($application);
 		}
 	}
 
-	private function insertApplication( Application $application ) {
+	private function insertApplication(Application $application) {
 		$doctrineApplication = new DoctrineApplication();
-		$this->updateDoctrineApplication( $doctrineApplication, $application );
+		$this->updateDoctrineApplication($doctrineApplication, $application);
 
 		try {
-			$this->entityManager->persist( $doctrineApplication );
+			$this->entityManager->persist($doctrineApplication);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreMembershipApplicationException($ex);
 		}
 
-		$application->assignId( $doctrineApplication->getId() );
+		$application->assignId($doctrineApplication->getId());
 	}
 
-	private function updateApplication( Application $application ) {
-		$doctrineApplication = $this->getDoctrineApplicationById( $application->getId() );
+	private function updateApplication(Application $application) {
+		$doctrineApplication = $this->getDoctrineApplicationById($application->getId());
 
-		if ( $doctrineApplication === null ) {
+		if ($doctrineApplication === null) {
 			throw new StoreMembershipApplicationException();
 		}
 
-		$this->updateDoctrineApplication( $doctrineApplication, $application );
+		$this->updateDoctrineApplication($doctrineApplication, $application);
 
 		try {
-			$this->entityManager->persist( $doctrineApplication );
+			$this->entityManager->persist($doctrineApplication);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreMembershipApplicationException($ex);
 		}
 	}
 
-	private function updateDoctrineApplication( DoctrineApplication $doctrineApplication, Application $application ) {
-		$doctrineApplication->setId( $application->getId() );
-		$doctrineApplication->setMembershipType( $application->getType() );
+	private function updateDoctrineApplication(DoctrineApplication $doctrineApplication, Application $application) {
+		$doctrineApplication->setId($application->getId());
+		$doctrineApplication->setMembershipType($application->getType());
 
-		$this->setApplicantFields( $doctrineApplication, $application->getApplicant() );
-		$this->setPaymentFields( $doctrineApplication, $application->getPayment() );
+		$this->setApplicantFields($doctrineApplication, $application->getApplicant());
+		$this->setPaymentFields($doctrineApplication, $application->getPayment());
 
-		$doctrineApplication->setStatus( $this->getDoctrineStatus( $application ) );
+		$doctrineApplication->setStatus($this->getDoctrineStatus($application));
 	}
 
-	private function setApplicantFields( DoctrineApplication $application, Applicant $applicant ) {
-		$application->setApplicantFirstName( $applicant->getName()->getFirstName() );
-		$application->setApplicantLastName( $applicant->getName()->getLastName() );
-		$application->setApplicantSalutation( $applicant->getName()->getSalutation() );
-		$application->setApplicantTitle( $applicant->getName()->getTitle() );
+	private function setApplicantFields(DoctrineApplication $application, Applicant $applicant) {
+		$application->setApplicantFirstName($applicant->getName()->getFirstName());
+		$application->setApplicantLastName($applicant->getName()->getLastName());
+		$application->setApplicantSalutation($applicant->getName()->getSalutation());
+		$application->setApplicantTitle($applicant->getName()->getTitle());
 
-		$application->setApplicantDateOfBirth( $applicant->getDateOfBirth() );
+		$application->setApplicantDateOfBirth($applicant->getDateOfBirth());
 
-		$application->setApplicantEmailAddress( $applicant->getEmailAddress()->getFullAddress() );
-		$application->setApplicantPhoneNumber( $applicant->getPhoneNumber()->__toString() );
+		$application->setApplicantEmailAddress($applicant->getEmailAddress()->getFullAddress());
+		$application->setApplicantPhoneNumber($applicant->getPhoneNumber()->__toString());
 
 		$address = $applicant->getPhysicalAddress();
 
-		$application->setCity( $address->getCity() );
-		$application->setCountry( $address->getCountryCode() );
-		$application->setPostcode( $address->getPostalCode() );
-		$application->setAddress( $address->getStreetAddress() );
+		$application->setCity($address->getCity());
+		$application->setCountry($address->getCountryCode());
+		$application->setPostcode($address->getPostalCode());
+		$application->setAddress($address->getStreetAddress());
 	}
 
-	private function setPaymentFields( DoctrineApplication $application, Payment $payment ) {
-		$application->setPaymentIntervalInMonths( $payment->getIntervalInMonths() );
-		$application->setPaymentAmount( (int)$payment->getAmount()->getEuroFloat() );
+	private function setPaymentFields(DoctrineApplication $application, Payment $payment) {
+		$application->setPaymentIntervalInMonths($payment->getIntervalInMonths());
+		$application->setPaymentAmount((int)$payment->getAmount()->getEuroFloat());
 
 		$bankData = $payment->getBankData();
 
-		$application->setPaymentBankAccount( $bankData->getAccount() );
-		$application->setPaymentBankCode( $bankData->getBankCode() );
-		$application->setPaymentBankName( $bankData->getBankName() );
-		$application->setPaymentBic( $bankData->getBic() );
-		$application->setPaymentIban( $bankData->getIban()->toString() );
+		$application->setPaymentBankAccount($bankData->getAccount());
+		$application->setPaymentBankCode($bankData->getBankCode());
+		$application->setPaymentBankName($bankData->getBankName());
+		$application->setPaymentBic($bankData->getBic());
+		$application->setPaymentIban($bankData->getIban()->toString());
 	}
 
-	private function getDoctrineStatus( Application $application ): int {
+	private function getDoctrineStatus(Application $application): int {
 		$status = DoctrineApplication::STATUS_NEUTRAL;
 
-		if ( $application->needsModeration() ) {
+		if ($application->needsModeration()) {
 			$status += DoctrineApplication::STATUS_MODERATION;
 		}
 
-		if ( $application->isCancelled() ) {
+		if ($application->isCancelled()) {
 			$status += DoctrineApplication::STATUS_CANCELED;
 		}
 
@@ -137,19 +137,19 @@ 
 	 * @return \WMDE\Fundraising\Frontend\MembershipApplicationContext\Domain\Model\Application|null
 	 * @throws \WMDE\Fundraising\Frontend\MembershipApplicationContext\Domain\Repositories\GetMembershipApplicationException
 	 */
-	public function getApplicationById( int $id ) {
+	public function getApplicationById(int $id) {
 		try {
-			$application = $this->getDoctrineApplicationById( $id );
+			$application = $this->getDoctrineApplicationById($id);
 		}
-		catch ( ORMException $ex ) {
-			throw new GetMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new GetMembershipApplicationException($ex);
 		}
 
-		if ( $application === null ) {
+		if ($application === null) {
 			return null;
 		}
 
-		return $this->newApplicationDomainEntity( $application );
+		return $this->newApplicationDomainEntity($application);
 	}
 
 	/**
@@ -157,61 +157,61 @@ 
 	 * @return DoctrineApplication|null
 	 * @throws ORMException
 	 */
-	public function getDoctrineApplicationById( int $id ) {
-		return $this->entityManager->find( DoctrineApplication::class, $id );
+	public function getDoctrineApplicationById(int $id) {
+		return $this->entityManager->find(DoctrineApplication::class, $id);
 	}
 
-	private function newApplicationDomainEntity( DoctrineApplication $application ): Application {
+	private function newApplicationDomainEntity(DoctrineApplication $application): Application {
 		return new Application(
 			$application->getId(),
 			$application->getMembershipType(),
 			new Applicant(
-				$this->newPersonName( $application ),
-				$this->newAddress( $application ),
-				new EmailAddress( $application->getApplicantEmailAddress() ),
-				new PhoneNumber( $application->getApplicantPhoneNumber() ),
+				$this->newPersonName($application),
+				$this->newAddress($application),
+				new EmailAddress($application->getApplicantEmailAddress()),
+				new PhoneNumber($application->getApplicantPhoneNumber()),
 				$application->getApplicantDateOfBirth()
 			),
 			new Payment(
 				$application->getPaymentIntervalInMonths(),
-				Euro::newFromFloat( $application->getPaymentAmount() ),
-				$this->newBankData( $application )
+				Euro::newFromFloat($application->getPaymentAmount()),
+				$this->newBankData($application)
 			),
 			$application->needsModeration(),
 			$application->isCancelled()
 		);
 	}
 
-	private function newPersonName( DoctrineApplication $application ): ApplicantName {
+	private function newPersonName(DoctrineApplication $application): ApplicantName {
 		$personName = ApplicantName::newPrivatePersonName();
 
-		$personName->setFirstName( $application->getApplicantFirstName() );
-		$personName->setLastName( $application->getApplicantLastName() );
-		$personName->setSalutation( $application->getApplicantSalutation() );
-		$personName->setTitle( $application->getApplicantTitle() );
+		$personName->setFirstName($application->getApplicantFirstName());
+		$personName->setLastName($application->getApplicantLastName());
+		$personName->setSalutation($application->getApplicantSalutation());
+		$personName->setTitle($application->getApplicantTitle());
 
 		return $personName->freeze()->assertNoNullFields();
 	}
 
-	private function newAddress( DoctrineApplication $application ): PhysicalAddress {
+	private function newAddress(DoctrineApplication $application): PhysicalAddress {
 		$address = new PhysicalAddress();
 
-		$address->setCity( $application->getCity() );
-		$address->setCountryCode( $application->getCountry() );
-		$address->setPostalCode( $application->getPostcode() );
-		$address->setStreetAddress( $application->getAddress() );
+		$address->setCity($application->getCity());
+		$address->setCountryCode($application->getCountry());
+		$address->setPostalCode($application->getPostcode());
+		$address->setStreetAddress($application->getAddress());
 
 		return $address->freeze()->assertNoNullFields();
 	}
 
-	private function newBankData( DoctrineApplication $application ): BankData {
+	private function newBankData(DoctrineApplication $application): BankData {
 		$bankData = new BankData();
 
-		$bankData->setAccount( $application->getPaymentBankAccount() );
-		$bankData->setBankCode( $application->getPaymentBankCode() );
-		$bankData->setBankName( $application->getPaymentBankName() );
-		$bankData->setBic( $application->getPaymentBic() );
-		$bankData->setIban( new Iban( $application->getPaymentIban() ) );
+		$bankData->setAccount($application->getPaymentBankAccount());
+		$bankData->setBankCode($application->getPaymentBankCode());
+		$bankData->setBankName($application->getPaymentBankName());
+		$bankData->setBic($application->getPaymentBic());
+		$bankData->setIban(new Iban($application->getPaymentIban()));
 
 		return $bankData->freeze()->assertNoNullFields();
 	}

src/MembershipApplicationContext/DataAccess/DoctrineApplicationPiwikTracker.php

Spacing +16 added lines, -16 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\DataAccess;
 
@@ -18,41 +18,41 @@ 
 
 	private $entityManager;
 
-	public function __construct( EntityManager $entityManager ) {
+	public function __construct(EntityManager $entityManager) {
 		$this->entityManager = $entityManager;
 	}
 
-	public function trackApplication( int $applicationId, string $trackingString ) {
-		$application = $this->getApplicationById( $applicationId );
+	public function trackApplication(int $applicationId, string $trackingString) {
+		$application = $this->getApplicationById($applicationId);
 
-		$application->setTracking( $trackingString );
+		$application->setTracking($trackingString);
 
-		$this->persistApplication( $application );
+		$this->persistApplication($application);
 	}
 
-	private function getApplicationById( int $applicationId ): MembershipApplication {
+	private function getApplicationById(int $applicationId): MembershipApplication {
 		try {
-			$application = $this->entityManager->find( MembershipApplication::class, $applicationId );
+			$application = $this->entityManager->find(MembershipApplication::class, $applicationId);
 		}
-		catch ( ORMException $ex ) {
+		catch (ORMException $ex) {
 			// TODO: might want to log failure here
-			throw new ApplicationPiwikTrackingException( 'Membership application could not be accessed' );
+			throw new ApplicationPiwikTrackingException('Membership application could not be accessed');
 		}
 
-		if ( $application === null ) {
-			throw new ApplicationPiwikTrackingException( 'Membership application does not exist' );
+		if ($application === null) {
+			throw new ApplicationPiwikTrackingException('Membership application does not exist');
 		}
 
 		return $application;
 	}
 
-	private function persistApplication( MembershipApplication $application ) {
+	private function persistApplication(MembershipApplication $application) {
 		try {
-			$this->entityManager->persist( $application );
+			$this->entityManager->persist($application);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new ApplicationPiwikTrackingException( 'Failed to persist membership application' );
+		catch (ORMException $ex) {
+			throw new ApplicationPiwikTrackingException('Failed to persist membership application');
 		}
 	}
 

src/MembershipApplicationContext/DataAccess/DoctrineApplicationTracker.php

Spacing +16 added lines, -16 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\DataAccess;
 
@@ -19,44 +19,44 @@ 
 
 	private $entityManager;
 
-	public function __construct( EntityManager $entityManager ) {
+	public function __construct(EntityManager $entityManager) {
 		$this->entityManager = $entityManager;
 	}
 
-	public function trackApplication( int $applicationId, MembershipApplicationTrackingInfo $trackingInfo ) {
-		$application = $this->getApplicationById( $applicationId );
+	public function trackApplication(int $applicationId, MembershipApplicationTrackingInfo $trackingInfo) {
+		$application = $this->getApplicationById($applicationId);
 
 		$data = $application->getDecodedData();
 		$data['confirmationPageCampaign'] = $trackingInfo->getCampaignCode();
 		$data['confirmationPage'] = $trackingInfo->getKeyword();
-		$application->encodeAndSetData( $data );
+		$application->encodeAndSetData($data);
 
-		$this->persistApplication( $application );
+		$this->persistApplication($application);
 	}
 
-	private function getApplicationById( int $applicationId ): MembershipApplication {
+	private function getApplicationById(int $applicationId): MembershipApplication {
 		try {
-			$application = $this->entityManager->find( MembershipApplication::class, $applicationId );
+			$application = $this->entityManager->find(MembershipApplication::class, $applicationId);
 		}
-		catch ( ORMException $ex ) {
+		catch (ORMException $ex) {
 			// TODO: might want to log failure here
-			throw new ApplicationTrackingException( 'Membership application could not be accessed' );
+			throw new ApplicationTrackingException('Membership application could not be accessed');
 		}
 
-		if ( $application === null ) {
-			throw new ApplicationTrackingException( 'Membership application does not exist' );
+		if ($application === null) {
+			throw new ApplicationTrackingException('Membership application does not exist');
 		}
 
 		return $application;
 	}
 
-	private function persistApplication( MembershipApplication $application ) {
+	private function persistApplication(MembershipApplication $application) {
 		try {
-			$this->entityManager->persist( $application );
+			$this->entityManager->persist($application);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new ApplicationTrackingException( 'Failed to persist membership application' );
+		catch (ORMException $ex) {
+			throw new ApplicationTrackingException('Failed to persist membership application');
 		}
 	}
 

src/MembershipApplicationContext/UseCases/ApplyForMembership/ApplyForMembershipUseCase.php

Spacing +18 added lines, -18 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipApplicationContext\UseCases\ApplyForMembership;
 
@@ -25,10 +25,10 @@ 
 	private $validator;
 	private $piwikTracker;
 
-	public function __construct( ApplicationRepository $repository,
+	public function __construct(ApplicationRepository $repository,
 		ApplicationTokenFetcher $tokenFetcher, TemplateBasedMailer $mailer,
 		MembershipApplicationValidator $validator, ApplicationTracker $tracker,
-		ApplicationPiwikTracker $piwikTracker ) {
+		ApplicationPiwikTracker $piwikTracker) {
 
 		$this->repository = $repository;
 		$this->tokenFetcher = $tokenFetcher;
@@ -38,33 +38,33 @@ 
 		$this->piwikTracker = $piwikTracker;
 	}
 
-	public function applyForMembership( ApplyForMembershipRequest $request ): ApplyForMembershipResponse {
-		$validationResult = $this->validator->validate( $request );
-		if ( !$validationResult->isSuccessful() ) {
+	public function applyForMembership(ApplyForMembershipRequest $request): ApplyForMembershipResponse {
+		$validationResult = $this->validator->validate($request);
+		if (!$validationResult->isSuccessful()) {
 			// TODO: return failures (note that we have infrastructure failures that are not ConstraintViolations)
-			return ApplyForMembershipResponse::newFailureResponse( $validationResult );
+			return ApplyForMembershipResponse::newFailureResponse($validationResult);
 		}
 
-		$application = $this->newApplicationFromRequest( $request );
+		$application = $this->newApplicationFromRequest($request);
 
-		if ( $this->applicationNeedsModeration( $application ) ) {
+		if ($this->applicationNeedsModeration($application)) {
 			$application->markForModeration();
 		}
 
 		// TODO: handle exceptions
-		$this->repository->storeApplication( $application );
+		$this->repository->storeApplication($application);
 
 		// TODO: handle exceptions
-		$this->membershipApplicationTracker->trackApplication( $application->getId(), $request->getTrackingInfo() );
+		$this->membershipApplicationTracker->trackApplication($application->getId(), $request->getTrackingInfo());
 
 		// TODO: handle exceptions
-		$this->piwikTracker->trackApplication( $application->getId(), $request->getPiwikTrackingString() );
+		$this->piwikTracker->trackApplication($application->getId(), $request->getPiwikTrackingString());
 
 		// TODO: handle exceptions
-		$this->sendConfirmationEmail( $application );
+		$this->sendConfirmationEmail($application);
 
 		// TODO: handle exceptions
-		$tokens = $this->tokenFetcher->getTokens( $application->getId() );
+		$tokens = $this->tokenFetcher->getTokens($application->getId());
 
 		return ApplyForMembershipResponse::newSuccessResponse(
 			$tokens->getAccessToken(),
@@ -73,11 +73,11 @@ 
 		);
 	}
 
-	private function newApplicationFromRequest( ApplyForMembershipRequest $request ): Application {
-		return ( new MembershipApplicationBuilder() )->newApplicationFromRequest( $request );
+	private function newApplicationFromRequest(ApplyForMembershipRequest $request): Application {
+		return (new MembershipApplicationBuilder())->newApplicationFromRequest($request);
 	}
 
-	private function sendConfirmationEmail( Application $application ) {
+	private function sendConfirmationEmail(Application $application) {
 		$this->mailer->sendMail(
 			$application->getApplicant()->getEmailAddress(),
 			[
@@ -91,7 +91,7 @@ 
 		);
 	}
 
-	private function applicationNeedsModeration( Application $application ): bool {
+	private function applicationNeedsModeration(Application $application): bool {
 		return
 			$application->getPayment()->getYearlyAmount()->getEuroFloat()
 			> self::YEARLY_PAYMENT_MODERATION_THRESHOLD_IN_EURO;