Inspection of "Undefined const" - wmde/FundraisingFrontend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#850)

by Jeroen De

created 2017-03-24 21:55 UTC

Status

Spacing +44 added lines, -44 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonationContext\Tests\Data;
 
@@ -43,40 +43,40 @@  discard block
 block discarded – undo
 	public const PAYMENT_STATUS_PENDING = 'Pending';
 	public const DONATION_ID = null; /// FIXME
 
-	public static function newInstantPayment( int $dataSetId ): PayPalPaymentNotificationRequest {
+	public static function newInstantPayment(int $dataSetId): PayPalPaymentNotificationRequest {
 		return self::newBaseRequest()
-			->setInternalId( $dataSetId )
-			->setTransactionType( 'express_checkout' )
-			->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED );
+			->setInternalId($dataSetId)
+			->setTransactionType('express_checkout')
+			->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED);
 	}
 
-	public static function newDuplicatePayment( int $dataSetId, string $transactionid ): PayPalPaymentNotificationRequest {
+	public static function newDuplicatePayment(int $dataSetId, string $transactionid): PayPalPaymentNotificationRequest {
 		return self::newBaseRequest()
-			->setInternalId( $dataSetId )
-			->setTransactionType( 'express_checkout' )
-			->setTransactionId( $transactionid )
-			->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED );
+			->setInternalId($dataSetId)
+			->setTransactionType('express_checkout')
+			->setTransactionId($transactionid)
+			->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED);
 	}
 
 	public static function newPendingPayment(): PayPalPaymentNotificationRequest {
 		return self::newBaseRequest()
-			->setInternalId( self::DATA_SET_ID )
-			->setTransactionType( 'express_checkout' )
-			->setPaymentStatus( self::PAYMENT_STATUS_PENDING );
+			->setInternalId(self::DATA_SET_ID)
+			->setTransactionType('express_checkout')
+			->setPaymentStatus(self::PAYMENT_STATUS_PENDING);
 	}
 
 	public static function newSubscriptionModification(): PayPalPaymentNotificationRequest {
 		return self::newBaseRequest()
-			->setInternalId( self::DATA_SET_ID )
-			->setTransactionType( 'subscr_modify' )
-			->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED );
+			->setInternalId(self::DATA_SET_ID)
+			->setTransactionType('subscr_modify')
+			->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED);
 	}
 
-	public static function newRecurringPayment( int $dataSetId ): PayPalPaymentNotificationRequest {
+	public static function newRecurringPayment(int $dataSetId): PayPalPaymentNotificationRequest {
 		return self::newBaseRequest()
-			->setInternalId( $dataSetId )
-			->setTransactionType( 'subscr_payment' )
-			->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED );
+			->setInternalId($dataSetId)
+			->setTransactionType('subscr_payment')
+			->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED);
 	}
 
 	public static function newHttpParamsForSubscriptionModification(): array {
@@ -96,10 +96,10 @@  discard block
 block discarded – undo
 			'address_name' => self::PAYER_ADDRESS_NAME,
 			'item_name' => self::ITEM_NAME,
 			'item_number' => self::ITEM_NUMBER,
-			'custom' => json_encode( [
+			'custom' => json_encode([
 				'id' => self::DONATION_ID,
 				'utoken' => self::TOKEN
-			] ),
+			]),
 			'txn_id' => self::TRANSACTION_ID,
 			'payment_type' => self::PAYMENT_TYPE,
 			'txn_type' => 'subscr_modify',
@@ -108,28 +108,28 @@  discard block
 block discarded – undo
 	}
 
 	private static function newBaseRequest(): PayPalPaymentNotificationRequest {
-		return ( new PayPalPaymentNotificationRequest() )
-			->setTransactionId( self::TRANSACTION_ID )
-			->setPayerId( self::PAYER_ID )
-			->setSubscriptionId( self::SUBSCRIBER_ID )
-			->setPayerEmail( self::PAYER_EMAIL )
-			->setPayerStatus( self::PAYER_STATUS )
-			->setPayerFirstName( self::PAYER_FIRST_NAME )
-			->setPayerLastName( self::PAYER_LAST_NAME )
-			->setPayerAddressName( self::PAYER_ADDRESS_NAME )
-			->setPayerAddressStreet( self::PAYER_ADDRESS_STREET )
-			->setPayerAddressPostalCode( self::PAYER_ADDRESS_POSTAL_CODE )
-			->setPayerAddressCity( self::PAYER_ADDRESS_CITY )
-			->setPayerAddressCountryCode( self::PAYER_ADDRESS_COUNTRY_CODE )
-			->setPayerAddressStatus( self::PAYER_ADDRESS_STATUS )
-			->setToken( self::TOKEN )
-			->setCurrencyCode( self::CURRENCY_CODE )
-			->setTransactionFee( self::TRANSACTION_FEE_EURO_STRING )
-			->setAmountGross( Euro::newFromCents( self::AMOUNT_GROSS_CENTS ) )
-			->setSettleAmount( Euro::newFromCents( self::SETTLE_AMOUNT_CENTS ) )
-			->setPaymentTimestamp( self::PAYMENT_TIMESTAMP )
-			->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED )
-			->setPaymentType( self::PAYMENT_TYPE );
+		return (new PayPalPaymentNotificationRequest())
+			->setTransactionId(self::TRANSACTION_ID)
+			->setPayerId(self::PAYER_ID)
+			->setSubscriptionId(self::SUBSCRIBER_ID)
+			->setPayerEmail(self::PAYER_EMAIL)
+			->setPayerStatus(self::PAYER_STATUS)
+			->setPayerFirstName(self::PAYER_FIRST_NAME)
+			->setPayerLastName(self::PAYER_LAST_NAME)
+			->setPayerAddressName(self::PAYER_ADDRESS_NAME)
+			->setPayerAddressStreet(self::PAYER_ADDRESS_STREET)
+			->setPayerAddressPostalCode(self::PAYER_ADDRESS_POSTAL_CODE)
+			->setPayerAddressCity(self::PAYER_ADDRESS_CITY)
+			->setPayerAddressCountryCode(self::PAYER_ADDRESS_COUNTRY_CODE)
+			->setPayerAddressStatus(self::PAYER_ADDRESS_STATUS)
+			->setToken(self::TOKEN)
+			->setCurrencyCode(self::CURRENCY_CODE)
+			->setTransactionFee(self::TRANSACTION_FEE_EURO_STRING)
+			->setAmountGross(Euro::newFromCents(self::AMOUNT_GROSS_CENTS))
+			->setSettleAmount(Euro::newFromCents(self::SETTLE_AMOUNT_CENTS))
+			->setPaymentTimestamp(self::PAYMENT_TIMESTAMP)
+			->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED)
+			->setPaymentType(self::PAYMENT_TYPE);
 	}
 
 }

Please login to merge, or discard this patch.

		@@ -1,6 +1,6 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-declare( strict_types = 1 );
	3	+declare(strict_types = 1);
4	4
5	5	namespace WMDE\Fundraising\Frontend\DonationContext\Tests\Data;
6	6
		@@ -43,40 +43,40 @@ discard block
		block discarded – undo
43	43	public const PAYMENT_STATUS_PENDING = 'Pending';
44	44	public const DONATION_ID = null; /// FIXME
45	45
46		- public static function newInstantPayment( int $dataSetId ): PayPalPaymentNotificationRequest {
	46	+ public static function newInstantPayment(int $dataSetId): PayPalPaymentNotificationRequest {
47	47	return self::newBaseRequest()
48		- ->setInternalId( $dataSetId )
49		- ->setTransactionType( 'express_checkout' )
50		- ->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED );
	48	+ ->setInternalId($dataSetId)
	49	+ ->setTransactionType('express_checkout')
	50	+ ->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED);
51	51	}
52	52
53		- public static function newDuplicatePayment( int $dataSetId, string $transactionid ): PayPalPaymentNotificationRequest {
	53	+ public static function newDuplicatePayment(int $dataSetId, string $transactionid): PayPalPaymentNotificationRequest {
54	54	return self::newBaseRequest()
55		- ->setInternalId( $dataSetId )
56		- ->setTransactionType( 'express_checkout' )
57		- ->setTransactionId( $transactionid )
58		- ->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED );
	55	+ ->setInternalId($dataSetId)
	56	+ ->setTransactionType('express_checkout')
	57	+ ->setTransactionId($transactionid)
	58	+ ->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED);
59	59	}
60	60
61	61	public static function newPendingPayment(): PayPalPaymentNotificationRequest {
62	62	return self::newBaseRequest()
63		- ->setInternalId( self::DATA_SET_ID )
64		- ->setTransactionType( 'express_checkout' )
65		- ->setPaymentStatus( self::PAYMENT_STATUS_PENDING );
	63	+ ->setInternalId(self::DATA_SET_ID)
	64	+ ->setTransactionType('express_checkout')
	65	+ ->setPaymentStatus(self::PAYMENT_STATUS_PENDING);
66	66	}
67	67
68	68	public static function newSubscriptionModification(): PayPalPaymentNotificationRequest {
69	69	return self::newBaseRequest()
70		- ->setInternalId( self::DATA_SET_ID )
71		- ->setTransactionType( 'subscr_modify' )
72		- ->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED );
	70	+ ->setInternalId(self::DATA_SET_ID)
	71	+ ->setTransactionType('subscr_modify')
	72	+ ->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED);
73	73	}
74	74
75		- public static function newRecurringPayment( int $dataSetId ): PayPalPaymentNotificationRequest {
	75	+ public static function newRecurringPayment(int $dataSetId): PayPalPaymentNotificationRequest {
76	76	return self::newBaseRequest()
77		- ->setInternalId( $dataSetId )
78		- ->setTransactionType( 'subscr_payment' )
79		- ->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED );
	77	+ ->setInternalId($dataSetId)
	78	+ ->setTransactionType('subscr_payment')
	79	+ ->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED);
80	80	}
81	81
82	82	public static function newHttpParamsForSubscriptionModification(): array {
		@@ -96,10 +96,10 @@ discard block
		block discarded – undo
96	96	'address_name' => self::PAYER_ADDRESS_NAME,
97	97	'item_name' => self::ITEM_NAME,
98	98	'item_number' => self::ITEM_NUMBER,
99		- 'custom' => json_encode( [
	99	+ 'custom' => json_encode([
100	100	'id' => self::DONATION_ID,
101	101	'utoken' => self::TOKEN
102		- ] ),
	102	+ ]),
103	103	'txn_id' => self::TRANSACTION_ID,
104	104	'payment_type' => self::PAYMENT_TYPE,
105	105	'txn_type' => 'subscr_modify',
		@@ -108,28 +108,28 @@ discard block
		block discarded – undo
108	108	}
109	109
110	110	private static function newBaseRequest(): PayPalPaymentNotificationRequest {
111		- return ( new PayPalPaymentNotificationRequest() )
112		- ->setTransactionId( self::TRANSACTION_ID )
113		- ->setPayerId( self::PAYER_ID )
114		- ->setSubscriptionId( self::SUBSCRIBER_ID )
115		- ->setPayerEmail( self::PAYER_EMAIL )
116		- ->setPayerStatus( self::PAYER_STATUS )
117		- ->setPayerFirstName( self::PAYER_FIRST_NAME )
118		- ->setPayerLastName( self::PAYER_LAST_NAME )
119		- ->setPayerAddressName( self::PAYER_ADDRESS_NAME )
120		- ->setPayerAddressStreet( self::PAYER_ADDRESS_STREET )
121		- ->setPayerAddressPostalCode( self::PAYER_ADDRESS_POSTAL_CODE )
122		- ->setPayerAddressCity( self::PAYER_ADDRESS_CITY )
123		- ->setPayerAddressCountryCode( self::PAYER_ADDRESS_COUNTRY_CODE )
124		- ->setPayerAddressStatus( self::PAYER_ADDRESS_STATUS )
125		- ->setToken( self::TOKEN )
126		- ->setCurrencyCode( self::CURRENCY_CODE )
127		- ->setTransactionFee( self::TRANSACTION_FEE_EURO_STRING )
128		- ->setAmountGross( Euro::newFromCents( self::AMOUNT_GROSS_CENTS ) )
129		- ->setSettleAmount( Euro::newFromCents( self::SETTLE_AMOUNT_CENTS ) )
130		- ->setPaymentTimestamp( self::PAYMENT_TIMESTAMP )
131		- ->setPaymentStatus( self::PAYMENT_STATUS_COMPLETED )
132		- ->setPaymentType( self::PAYMENT_TYPE );
	111	+ return (new PayPalPaymentNotificationRequest())
	112	+ ->setTransactionId(self::TRANSACTION_ID)
	113	+ ->setPayerId(self::PAYER_ID)
	114	+ ->setSubscriptionId(self::SUBSCRIBER_ID)
	115	+ ->setPayerEmail(self::PAYER_EMAIL)
	116	+ ->setPayerStatus(self::PAYER_STATUS)
	117	+ ->setPayerFirstName(self::PAYER_FIRST_NAME)
	118	+ ->setPayerLastName(self::PAYER_LAST_NAME)
	119	+ ->setPayerAddressName(self::PAYER_ADDRESS_NAME)
	120	+ ->setPayerAddressStreet(self::PAYER_ADDRESS_STREET)
	121	+ ->setPayerAddressPostalCode(self::PAYER_ADDRESS_POSTAL_CODE)
	122	+ ->setPayerAddressCity(self::PAYER_ADDRESS_CITY)
	123	+ ->setPayerAddressCountryCode(self::PAYER_ADDRESS_COUNTRY_CODE)
	124	+ ->setPayerAddressStatus(self::PAYER_ADDRESS_STATUS)
	125	+ ->setToken(self::TOKEN)
	126	+ ->setCurrencyCode(self::CURRENCY_CODE)
	127	+ ->setTransactionFee(self::TRANSACTION_FEE_EURO_STRING)
	128	+ ->setAmountGross(Euro::newFromCents(self::AMOUNT_GROSS_CENTS))
	129	+ ->setSettleAmount(Euro::newFromCents(self::SETTLE_AMOUNT_CENTS))
	130	+ ->setPaymentTimestamp(self::PAYMENT_TIMESTAMP)
	131	+ ->setPaymentStatus(self::PAYMENT_STATUS_COMPLETED)
	132	+ ->setPaymentType(self::PAYMENT_TYPE);
133	133	}
134	134
135	135	}

wmde / FundraisingFrontend

Pull Request — master (#850)

Status

Category

Spacing +44 added lines, -44 removed lines patch added patch discarded remove patch