wmde / FundraisingFrontend

contexts/MembershipContext/tests/Integration/UseCases/HandleSubscriptionPaymentNotification/HandleSubscriptionPaymentNotificationUseCaseTest.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\UseCases\HandleSubscriptionPaymentNotification;
 
-use WMDE\Fundraising\Frontend\DonationContext\Infrastructure\DonationEventLogger;
 use WMDE\Fundraising\Frontend\DonationContext\Tests\Data\ValidPayPalNotificationRequest;
 use WMDE\Fundraising\Frontend\Infrastructure\TemplateBasedMailer;
 use WMDE\Fundraising\Frontend\MembershipContext\DataAccess\DoctrineApplicationRepository;

Spacing +42 added lines, -42 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\UseCases\HandleSubscriptionPaymentNotification;
 
@@ -28,20 +28,20 @@ 
 
 	public function testWhenRepositoryThrowsException_requestIsNotHandled(): void {
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
-			new DoctrineApplicationRepository( ThrowingEntityManager::newInstance( $this ) ),
+			new DoctrineApplicationRepository(ThrowingEntityManager::newInstance($this)),
 			new SucceedingAuthorizer(),
 			$this->getMailer(),
 			new NullLogger()
 		);
-		$request = ValidPayPalNotificationRequest::newInstantPayment( 1 );
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
-		$this->assertTrue( $response->hasErrors() );
+		$request = ValidPayPalNotificationRequest::newInstantPayment(1);
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
+		$this->assertTrue($response->hasErrors());
 	}
 
 	public function testWhenApplicationDoesNotExist_requestIsNotHandled(): void {
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( ValidMembershipApplication::newDomainEntityUsingPayPal() );
+		$fakeRepository->storeApplication(ValidMembershipApplication::newDomainEntityUsingPayPal());
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -50,14 +50,14 @@ 
 			new NullLogger()
 		);
 
-		$request = ValidPayPalNotificationRequest::newInstantPayment( 667 );
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
+		$request = ValidPayPalNotificationRequest::newInstantPayment(667);
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
 	}
 
 	public function testWhenAuthorizationFails_requestIsNotHandled(): void {
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( ValidMembershipApplication::newDomainEntityUsingPayPal() );
+		$fakeRepository->storeApplication(ValidMembershipApplication::newDomainEntityUsingPayPal());
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -66,9 +66,9 @@ 
 			new NullLogger()
 		);
 
-		$request = ValidPayPalNotificationRequest::newInstantPayment( 1 );
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
+		$request = ValidPayPalNotificationRequest::newInstantPayment(1);
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
 	}
 
 	public function testWhenTransactionTypeIsForSubscriptionChanges_requestIsNotHandled(): void {
@@ -80,17 +80,17 @@ 
 			$this->getMailer(),
 			new NullLogger()
 		);
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
 	}
 
 	public function testGivenSubscriptionPaymentRequest_childDataSetIsCreated(): void {
 		$application = ValidMembershipApplication::newConfirmedSubscriptionDomainEntity();
 
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( $application );
+		$fakeRepository->storeApplication($application);
 
-		$request = ValidPayPalNotificationRequest::newRecurringPayment( $application->getId() );
+		$request = ValidPayPalNotificationRequest::newRecurringPayment($application->getId());
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -99,35 +99,35 @@ 
 			new NullLogger()
 		);
 
-		$response = $useCase->handleNotification( $request );
-		$this->assertTrue( $response->notificationWasHandled() );
-		$this->assertFalse( $response->hasErrors() );
+		$response = $useCase->handleNotification($request);
+		$this->assertTrue($response->notificationWasHandled());
+		$this->assertFalse($response->hasErrors());
 
-		$application = $fakeRepository->getApplicationById( $application->getId() );
+		$application = $fakeRepository->getApplicationById($application->getId());
 		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $payment */
 		$payment = $application->getPayment()->getPaymentMethod();
-		$childApplication = $fakeRepository->getApplicationById( $payment->getPayPalData()->getChildPaymentEntityId( ValidPayPalNotificationRequest::TRANSACTION_ID ) );
-		$this->assertNotNull( $childApplication );
+		$childApplication = $fakeRepository->getApplicationById($payment->getPayPalData()->getChildPaymentEntityId(ValidPayPalNotificationRequest::TRANSACTION_ID));
+		$this->assertNotNull($childApplication);
 		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $childPayment */
 		$childPayment = $childApplication->getPayment()->getPaymentMethod();
-		$this->assertEquals( ValidPayPalNotificationRequest::TRANSACTION_ID, $childPayment->getPayPalData()->getPaymentId() );
-		$this->assertEquals( $application->getPayment()->getAmount(), $childApplication->getPayment()->getAmount() );
-		$this->assertEquals( $application->getApplicant(), $childApplication->getApplicant() );
-		$this->assertEquals( $application->getPayment()->getIntervalInMonths(), $childApplication->getPayment()->getIntervalInMonths() );
-		$this->assertTrue( $childApplication->isConfirmed() );
-		$this->assertTrue( $childApplication->getDonationReceipt() );
+		$this->assertEquals(ValidPayPalNotificationRequest::TRANSACTION_ID, $childPayment->getPayPalData()->getPaymentId());
+		$this->assertEquals($application->getPayment()->getAmount(), $childApplication->getPayment()->getAmount());
+		$this->assertEquals($application->getApplicant(), $childApplication->getApplicant());
+		$this->assertEquals($application->getPayment()->getIntervalInMonths(), $childApplication->getPayment()->getIntervalInMonths());
+		$this->assertTrue($childApplication->isConfirmed());
+		$this->assertTrue($childApplication->getDonationReceipt());
 	}
 
 	public function testGivenExistingTransactionId_requestIsNotHandled(): void {
 		$application = ValidMembershipApplication::newConfirmedSubscriptionDomainEntity();
 		/** @var PayPalPayment $payment */
 		$payment = $application->getPayment()->getPaymentMethod();
-		$payment->getPayPalData()->addChildPayment( ValidPayPalNotificationRequest::TRANSACTION_ID, 1 );
+		$payment->getPayPalData()->addChildPayment(ValidPayPalNotificationRequest::TRANSACTION_ID, 1);
 
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( $application );
+		$fakeRepository->storeApplication($application);
 
-		$request = ValidPayPalNotificationRequest::newRecurringPayment( 1 );
+		$request = ValidPayPalNotificationRequest::newRecurringPayment(1);
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -136,24 +136,24 @@ 
 			new NullLogger()
 		);
 
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
 	}
 
 	/**
 	 * @return TemplateBasedMailer|\PHPUnit_Framework_MockObject_MockObject
 	 */
 	private function getMailer(): TemplateBasedMailer {
-		return $this->getMockBuilder( TemplateBasedMailer::class )->disableOriginalConstructor()->getMock();
+		return $this->getMockBuilder(TemplateBasedMailer::class)->disableOriginalConstructor()->getMock();
 	}
 
 	public function testGivenSubscriptionPaymentRequest_parentDataSetReferencesChildPaymentId(): void {
 		$application = ValidMembershipApplication::newConfirmedSubscriptionDomainEntity();
 
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( $application );
+		$fakeRepository->storeApplication($application);
 
-		$request = ValidPayPalNotificationRequest::newRecurringPayment( $application->getId() );
+		$request = ValidPayPalNotificationRequest::newRecurringPayment($application->getId());
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -161,22 +161,22 @@ 
 			$this->getMailer(),
 			new NullLogger()
 		);
-		$useCase->handleNotification( $request );
+		$useCase->handleNotification($request);
 
 		/** @var PayPalPayment $payment */
 		$payment = $application->getPayment()->getPaymentMethod();
 
-		$storedApplication = $fakeRepository->getApplicationById( $application->getId() );
+		$storedApplication = $fakeRepository->getApplicationById($application->getId());
 		/** @var PayPalPayment $storedpayment */
 		$storedpayment = $storedApplication->getPayment()->getPaymentMethod();
 
 		$this->assertSame(
 			2,
-			$storedpayment->getPayPalData()->getChildPaymentEntityId( ValidPayPalNotificationRequest::TRANSACTION_ID )
+			$storedpayment->getPayPalData()->getChildPaymentEntityId(ValidPayPalNotificationRequest::TRANSACTION_ID)
 		);
 
 		$this->assertEquals(
-			$payment->getPayPalData()->addChildPayment( ValidPayPalNotificationRequest::TRANSACTION_ID, 2 ),
+			$payment->getPayPalData()->addChildPayment(ValidPayPalNotificationRequest::TRANSACTION_ID, 2),
 			$storedpayment->getPayPalData()
 		);
 	}

contexts/MembershipContext/tests/Integration/UseCases/ApplyForMembership/ApplyForMembershipUseCaseTest.php

Spacing +106 added lines, -106 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\UseCases\ApplyForMembership;
 
@@ -78,29 +78,29 @@ 
 
 	public function setUp(): void {
 		$this->repository = new InMemoryApplicationRepository();
-		$this->mailer = new TemplateBasedMailerSpy( $this );
-		$this->tokenGenerator = new FixedTokenGenerator( self::ACCESS_TOKEN );
+		$this->mailer = new TemplateBasedMailerSpy($this);
+		$this->tokenGenerator = new FixedTokenGenerator(self::ACCESS_TOKEN);
 		$this->validator = $this->newSucceedingValidator();
 		$this->policyValidator = $this->newSucceedingPolicyValidator();
-		$this->tracker = $this->createMock( ApplicationTracker::class );
-		$this->piwikTracker = $this->createMock( ApplicationPiwikTracker::class );
+		$this->tracker = $this->createMock(ApplicationTracker::class);
+		$this->piwikTracker = $this->createMock(ApplicationPiwikTracker::class);
 	}
 
 	private function newSucceedingValidator(): MembershipApplicationValidator {
-		$validator = $this->getMockBuilder( MembershipApplicationValidator::class )
+		$validator = $this->getMockBuilder(MembershipApplicationValidator::class)
 			->disableOriginalConstructor()->getMock();
 
-		$validator->expects( $this->any() )
-			->method( 'validate' )
-			->willReturn( new ApplicationValidationResult() );
+		$validator->expects($this->any())
+			->method('validate')
+			->willReturn(new ApplicationValidationResult());
 
 		return $validator;
 	}
 
 	public function testGivenValidRequest_applicationSucceeds(): void {
-		$response = $this->newUseCase()->applyForMembership( $this->newValidRequest() );
+		$response = $this->newUseCase()->applyForMembership($this->newValidRequest());
 
-		$this->assertTrue( $response->isSuccessful() );
+		$this->assertTrue($response->isSuccessful());
 	}
 
 	private function newUseCase(): ApplyForMembershipUseCase {
@@ -117,45 +117,45 @@ 
 	}
 
 	private function newTokenFetcher(): ApplicationTokenFetcher {
-		return new FixedApplicationTokenFetcher( new MembershipApplicationTokens(
+		return new FixedApplicationTokenFetcher(new MembershipApplicationTokens(
 			self::ACCESS_TOKEN,
 			self::UPDATE_TOKEN
-		) );
+		));
 	}
 
 	private function newFixedPaymentDelayCalculator(): PaymentDelayCalculator {
 		return new FixedPaymentDelayCalculator(
-			new \DateTime( self::FIRST_PAYMENT_DATE )
+			new \DateTime(self::FIRST_PAYMENT_DATE)
 		);
 	}
 
 	private function newValidRequest(): ApplyForMembershipRequest {
 		$request = new ApplyForMembershipRequest();
 
-		$request->setMembershipType( ValidMembershipApplication::MEMBERSHIP_TYPE );
-		$request->setApplicantCompanyName( '' );
-		$request->setMembershipType( ValidMembershipApplication::MEMBERSHIP_TYPE );
-		$request->setApplicantSalutation( ValidMembershipApplication::APPLICANT_SALUTATION );
-		$request->setApplicantTitle( ValidMembershipApplication::APPLICANT_TITLE );
-		$request->setApplicantFirstName( ValidMembershipApplication::APPLICANT_FIRST_NAME );
-		$request->setApplicantLastName( ValidMembershipApplication::APPLICANT_LAST_NAME );
-		$request->setApplicantStreetAddress( ValidMembershipApplication::APPLICANT_STREET_ADDRESS );
-		$request->setApplicantPostalCode( ValidMembershipApplication::APPLICANT_POSTAL_CODE );
-		$request->setApplicantCity( ValidMembershipApplication::APPLICANT_CITY );
-		$request->setApplicantCountryCode( ValidMembershipApplication::APPLICANT_COUNTRY_CODE );
-		$request->setApplicantEmailAddress( ValidMembershipApplication::APPLICANT_EMAIL_ADDRESS );
-		$request->setApplicantPhoneNumber( ValidMembershipApplication::APPLICANT_PHONE_NUMBER );
-		$request->setApplicantDateOfBirth( ValidMembershipApplication::APPLICANT_DATE_OF_BIRTH );
-		$request->setPaymentType( ValidMembershipApplication::PAYMENT_TYPE_DIRECT_DEBIT );
-		$request->setPaymentIntervalInMonths( ValidMembershipApplication::PAYMENT_PERIOD_IN_MONTHS );
-		$request->setPaymentAmountInEuros( (string)ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO );
-
-		$request->setBankData( $this->newValidBankData() );
-
-		$request->setTrackingInfo( $this->newTrackingInfo() );
-		$request->setPiwikTrackingString( 'foo/bar' );
-
-		$request->setOptsIntoDonationReceipt( true );
+		$request->setMembershipType(ValidMembershipApplication::MEMBERSHIP_TYPE);
+		$request->setApplicantCompanyName('');
+		$request->setMembershipType(ValidMembershipApplication::MEMBERSHIP_TYPE);
+		$request->setApplicantSalutation(ValidMembershipApplication::APPLICANT_SALUTATION);
+		$request->setApplicantTitle(ValidMembershipApplication::APPLICANT_TITLE);
+		$request->setApplicantFirstName(ValidMembershipApplication::APPLICANT_FIRST_NAME);
+		$request->setApplicantLastName(ValidMembershipApplication::APPLICANT_LAST_NAME);
+		$request->setApplicantStreetAddress(ValidMembershipApplication::APPLICANT_STREET_ADDRESS);
+		$request->setApplicantPostalCode(ValidMembershipApplication::APPLICANT_POSTAL_CODE);
+		$request->setApplicantCity(ValidMembershipApplication::APPLICANT_CITY);
+		$request->setApplicantCountryCode(ValidMembershipApplication::APPLICANT_COUNTRY_CODE);
+		$request->setApplicantEmailAddress(ValidMembershipApplication::APPLICANT_EMAIL_ADDRESS);
+		$request->setApplicantPhoneNumber(ValidMembershipApplication::APPLICANT_PHONE_NUMBER);
+		$request->setApplicantDateOfBirth(ValidMembershipApplication::APPLICANT_DATE_OF_BIRTH);
+		$request->setPaymentType(ValidMembershipApplication::PAYMENT_TYPE_DIRECT_DEBIT);
+		$request->setPaymentIntervalInMonths(ValidMembershipApplication::PAYMENT_PERIOD_IN_MONTHS);
+		$request->setPaymentAmountInEuros((string)ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO);
+
+		$request->setBankData($this->newValidBankData());
+
+		$request->setTrackingInfo($this->newTrackingInfo());
+		$request->setPiwikTrackingString('foo/bar');
+
+		$request->setOptsIntoDonationReceipt(true);
 
 		return $request->assertNoNullFields();
 	}
@@ -163,11 +163,11 @@ 
 	private function newValidBankData(): BankData {
 		$bankData = new BankData();
 
-		$bankData->setIban( new Iban( ValidMembershipApplication::PAYMENT_IBAN ) );
-		$bankData->setBic( ValidMembershipApplication::PAYMENT_BIC );
-		$bankData->setAccount( ValidMembershipApplication::PAYMENT_BANK_ACCOUNT );
-		$bankData->setBankCode( ValidMembershipApplication::PAYMENT_BANK_CODE );
-		$bankData->setBankName( ValidMembershipApplication::PAYMENT_BANK_NAME );
+		$bankData->setIban(new Iban(ValidMembershipApplication::PAYMENT_IBAN));
+		$bankData->setBic(ValidMembershipApplication::PAYMENT_BIC);
+		$bankData->setAccount(ValidMembershipApplication::PAYMENT_BANK_ACCOUNT);
+		$bankData->setBankCode(ValidMembershipApplication::PAYMENT_BANK_CODE);
+		$bankData->setBankName(ValidMembershipApplication::PAYMENT_BANK_NAME);
 
 		return $bankData->assertNoNullFields()->freeze();
 	}
@@ -180,22 +180,22 @@ 
 	}
 
 	public function testGivenValidRequest_applicationGetsPersisted(): void {
-		$this->newUseCase()->applyForMembership( $this->newValidRequest() );
+		$this->newUseCase()->applyForMembership($this->newValidRequest());
 
 		$expectedApplication = ValidMembershipApplication::newDomainEntity();
-		$expectedApplication->assignId( self::FIRST_APPLICATION_ID );
+		$expectedApplication->assignId(self::FIRST_APPLICATION_ID);
 
-		$application = $this->repository->getApplicationById( $expectedApplication->getId() );
-		$this->assertNotNull( $application );
+		$application = $this->repository->getApplicationById($expectedApplication->getId());
+		$this->assertNotNull($application);
 
-		$this->assertEquals( $expectedApplication, $application );
+		$this->assertEquals($expectedApplication, $application);
 	}
 
 	public function testGivenValidRequest_confirmationEmailIsSend(): void {
-		$this->newUseCase()->applyForMembership( $this->newValidRequest() );
+		$this->newUseCase()->applyForMembership($this->newValidRequest());
 
 		$this->mailer->assertCalledOnceWith(
-			new EmailAddress( ValidMembershipApplication::APPLICANT_EMAIL_ADDRESS ),
+			new EmailAddress(ValidMembershipApplication::APPLICANT_EMAIL_ADDRESS),
 			[
 				'membershipType' => 'sustaining',
 				'membershipFee' => '10.00',
@@ -209,131 +209,131 @@ 
 	}
 
 	public function testGivenValidRequest_tokenIsGeneratedAndReturned(): void {
-		$response = $this->newUseCase()->applyForMembership( $this->newValidRequest() );
+		$response = $this->newUseCase()->applyForMembership($this->newValidRequest());
 
-		$this->assertSame( self::ACCESS_TOKEN, $response->getAccessToken() );
-		$this->assertSame( self::UPDATE_TOKEN, $response->getUpdateToken() );
+		$this->assertSame(self::ACCESS_TOKEN, $response->getAccessToken());
+		$this->assertSame(self::UPDATE_TOKEN, $response->getUpdateToken());
 	}
 
 	public function testWhenValidationFails_failureResultIsReturned(): void {
 		$this->validator = $this->newFailingValidator();
 
-		$response = $this->newUseCase()->applyForMembership( $this->newValidRequest() );
+		$response = $this->newUseCase()->applyForMembership($this->newValidRequest());
 
-		$this->assertFalse( $response->isSuccessful() );
+		$this->assertFalse($response->isSuccessful());
 	}
 
 	private function newFailingValidator(): MembershipApplicationValidator {
-		$validator = $this->getMockBuilder( MembershipApplicationValidator::class )
+		$validator = $this->getMockBuilder(MembershipApplicationValidator::class)
 			->disableOriginalConstructor()->getMock();
 
-		$validator->expects( $this->any() )
-			->method( 'validate' )
-			->willReturn( $this->newInvalidValidationResult() );
+		$validator->expects($this->any())
+			->method('validate')
+			->willReturn($this->newInvalidValidationResult());
 
 		return $validator;
 	}
 
 	private function newInvalidValidationResult(): ApplicationValidationResult {
-		$invalidResult = $this->createMock( ApplicationValidationResult::class );
+		$invalidResult = $this->createMock(ApplicationValidationResult::class);
 
-		$invalidResult->expects( $this->any() )
-			->method( 'isSuccessful' )
-			->willReturn( false );
+		$invalidResult->expects($this->any())
+			->method('isSuccessful')
+			->willReturn(false);
 
 		return $invalidResult;
 	}
 
 	public function testGivenValidRequest_moderationIsNotNeeded(): void {
-		$response = $this->newUseCase()->applyForMembership( $this->newValidRequest() );
+		$response = $this->newUseCase()->applyForMembership($this->newValidRequest());
 
-		$this->assertFalse( $response->getMembershipApplication()->needsModeration() );
+		$this->assertFalse($response->getMembershipApplication()->needsModeration());
 	}
 
 	public function testGivenFailingPolicyValidator_moderationIsNeeded(): void {
 		$this->policyValidator = $this->newFailingPolicyValidator();
 
-		$response = $this->newUseCase()->applyForMembership( $this->newValidRequest() );
-		$this->assertTrue( $response->getMembershipApplication()->needsModeration() );
+		$response = $this->newUseCase()->applyForMembership($this->newValidRequest());
+		$this->assertTrue($response->getMembershipApplication()->needsModeration());
 	}
 
 	private function newSucceedingPolicyValidator(): ApplyForMembershipPolicyValidator {
-		$policyValidator = $this->getMockBuilder( ApplyForMembershipPolicyValidator::class )
+		$policyValidator = $this->getMockBuilder(ApplyForMembershipPolicyValidator::class)
 			->disableOriginalConstructor()->getMock();
-		$policyValidator->method( 'needsModeration' )->willReturn( false );
+		$policyValidator->method('needsModeration')->willReturn(false);
 		return $policyValidator;
 	}
 
 	private function newFailingPolicyValidator(): ApplyForMembershipPolicyValidator {
-		$policyValidator = $this->getMockBuilder( ApplyForMembershipPolicyValidator::class )
+		$policyValidator = $this->getMockBuilder(ApplyForMembershipPolicyValidator::class)
 			->disableOriginalConstructor()->getMock();
-		$policyValidator->method( 'needsModeration' )->willReturn( true );
+		$policyValidator->method('needsModeration')->willReturn(true);
 		return $policyValidator;
 	}
 
 	public function testWhenApplicationIsUnconfirmed_confirmationEmailIsNotSent(): void {
-		$this->newUseCase()->applyForMembership( $this->newValidRequestForUnconfirmedApplication() );
+		$this->newUseCase()->applyForMembership($this->newValidRequestForUnconfirmedApplication());
 
-		$this->assertSame( 0, count( $this->mailer->getSendMailCalls() ) );
+		$this->assertSame(0, count($this->mailer->getSendMailCalls()));
 	}
 
 	private function newValidRequestForUnconfirmedApplication(): ApplyForMembershipRequest {
 		$request = new ApplyForMembershipRequest();
 
-		$request->setMembershipType( ValidMembershipApplication::MEMBERSHIP_TYPE );
-		$request->setApplicantCompanyName( '' );
-		$request->setMembershipType( ValidMembershipApplication::MEMBERSHIP_TYPE );
-		$request->setApplicantSalutation( ValidMembershipApplication::APPLICANT_SALUTATION );
-		$request->setApplicantTitle( ValidMembershipApplication::APPLICANT_TITLE );
-		$request->setApplicantFirstName( ValidMembershipApplication::APPLICANT_FIRST_NAME );
-		$request->setApplicantLastName( ValidMembershipApplication::APPLICANT_LAST_NAME );
-		$request->setApplicantStreetAddress( ValidMembershipApplication::APPLICANT_STREET_ADDRESS );
-		$request->setApplicantPostalCode( ValidMembershipApplication::APPLICANT_POSTAL_CODE );
-		$request->setApplicantCity( ValidMembershipApplication::APPLICANT_CITY );
-		$request->setApplicantCountryCode( ValidMembershipApplication::APPLICANT_COUNTRY_CODE );
-		$request->setApplicantEmailAddress( ValidMembershipApplication::APPLICANT_EMAIL_ADDRESS );
-		$request->setApplicantPhoneNumber( ValidMembershipApplication::APPLICANT_PHONE_NUMBER );
-		$request->setApplicantDateOfBirth( ValidMembershipApplication::APPLICANT_DATE_OF_BIRTH );
-		$request->setPaymentType( ValidMembershipApplication::PAYMENT_TYPE_PAYPAL );
-		$request->setPaymentIntervalInMonths( ValidMembershipApplication::PAYMENT_PERIOD_IN_MONTHS );
-		$request->setPaymentAmountInEuros( (string)ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO );
-		$request->setBankData( new BankData() );
-
-		$request->setTrackingInfo( $this->newTrackingInfo() );
-		$request->setPiwikTrackingString( 'foo/bar' );
+		$request->setMembershipType(ValidMembershipApplication::MEMBERSHIP_TYPE);
+		$request->setApplicantCompanyName('');
+		$request->setMembershipType(ValidMembershipApplication::MEMBERSHIP_TYPE);
+		$request->setApplicantSalutation(ValidMembershipApplication::APPLICANT_SALUTATION);
+		$request->setApplicantTitle(ValidMembershipApplication::APPLICANT_TITLE);
+		$request->setApplicantFirstName(ValidMembershipApplication::APPLICANT_FIRST_NAME);
+		$request->setApplicantLastName(ValidMembershipApplication::APPLICANT_LAST_NAME);
+		$request->setApplicantStreetAddress(ValidMembershipApplication::APPLICANT_STREET_ADDRESS);
+		$request->setApplicantPostalCode(ValidMembershipApplication::APPLICANT_POSTAL_CODE);
+		$request->setApplicantCity(ValidMembershipApplication::APPLICANT_CITY);
+		$request->setApplicantCountryCode(ValidMembershipApplication::APPLICANT_COUNTRY_CODE);
+		$request->setApplicantEmailAddress(ValidMembershipApplication::APPLICANT_EMAIL_ADDRESS);
+		$request->setApplicantPhoneNumber(ValidMembershipApplication::APPLICANT_PHONE_NUMBER);
+		$request->setApplicantDateOfBirth(ValidMembershipApplication::APPLICANT_DATE_OF_BIRTH);
+		$request->setPaymentType(ValidMembershipApplication::PAYMENT_TYPE_PAYPAL);
+		$request->setPaymentIntervalInMonths(ValidMembershipApplication::PAYMENT_PERIOD_IN_MONTHS);
+		$request->setPaymentAmountInEuros((string)ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO);
+		$request->setBankData(new BankData());
+
+		$request->setTrackingInfo($this->newTrackingInfo());
+		$request->setPiwikTrackingString('foo/bar');
 
 		return $request->assertNoNullFields();
 	}
 
 	private function newAutoDeletingPolicyValidator(): ApplyForMembershipPolicyValidator {
-		$policyValidator = $this->getMockBuilder( ApplyForMembershipPolicyValidator::class )
+		$policyValidator = $this->getMockBuilder(ApplyForMembershipPolicyValidator::class)
 			->disableOriginalConstructor()->getMock();
-		$policyValidator->method( 'isAutoDeleted' )->willReturn( true );
+		$policyValidator->method('isAutoDeleted')->willReturn(true);
 		return $policyValidator;
 	}
 
 	public function testWhenUsingBlacklistedEmailAddress_moderationIsAutomaticallyDeleted(): void {
 		$this->policyValidator = $this->newAutoDeletingPolicyValidator();
-		$this->newUseCase()->applyForMembership( $this->newValidRequest() );
-		$this->assertTrue( $this->repository->getApplicationById( 1 )->isDeleted() );
+		$this->newUseCase()->applyForMembership($this->newValidRequest());
+		$this->assertTrue($this->repository->getApplicationById(1)->isDeleted());
 	}
 
 	public function testWhenUsingPayPalPayment_delayInDaysIsPersisted(): void {
 		$request = $this->newValidRequest();
-		$request->setPaymentType( 'PPL' );
-		$this->newUseCase()->applyForMembership( $request );
+		$request->setPaymentType('PPL');
+		$this->newUseCase()->applyForMembership($request);
 		/** @var PayPalPayment $payPalPayment */
-		$payPalPayment = $this->repository->getApplicationById( 1 )->getPayment()->getPaymentMethod();
-		$this->assertSame( self::FIRST_PAYMENT_DATE, $payPalPayment->getPayPalData()->getFirstPaymentDate() );
+		$payPalPayment = $this->repository->getApplicationById(1)->getPayment()->getPaymentMethod();
+		$this->assertSame(self::FIRST_PAYMENT_DATE, $payPalPayment->getPayPalData()->getFirstPaymentDate());
 	}
 
 	public function testGivenDonationReceiptOptOutRequest_applicationHoldsThisValue(): void {
 		$request = $this->newValidRequest();
-		$request->setOptsIntoDonationReceipt( false );
-		$this->newUseCase()->applyForMembership( $request );
+		$request->setOptsIntoDonationReceipt(false);
+		$this->newUseCase()->applyForMembership($request);
 
-		$application = $this->repository->getApplicationById( self::FIRST_APPLICATION_ID );
-		$this->assertFalse( $application->getDonationReceipt() );
+		$application = $this->repository->getApplicationById(self::FIRST_APPLICATION_ID);
+		$this->assertFalse($application->getDonationReceipt());
 	}
 
 }

contexts/MembershipContext/tests/Unit/Domain/Model/ApplicationTest.php

Spacing +13 added lines, -13 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Unit\Domain\Model;
 
@@ -16,49 +16,49 @@ 
 class ApplicationTest extends \PHPUnit\Framework\TestCase {
 
 	public function testIdIsNullWhenNotAssigned(): void {
-		$this->assertNull( ValidMembershipApplication::newDomainEntity()->getId() );
+		$this->assertNull(ValidMembershipApplication::newDomainEntity()->getId());
 	}
 
 	public function testCanAssignIdToNewDonation(): void {
 		$donation = ValidMembershipApplication::newDomainEntity();
 
-		$donation->assignId( 42 );
-		$this->assertSame( 42, $donation->getId() );
+		$donation->assignId(42);
+		$this->assertSame(42, $donation->getId());
 	}
 
 	public function testCannotAssignIdToDonationWithIdentity(): void {
 		$donation = ValidMembershipApplication::newDomainEntity();
-		$donation->assignId( 42 );
+		$donation->assignId(42);
 
-		$this->expectException( RuntimeException::class );
-		$donation->assignId( 43 );
+		$this->expectException(RuntimeException::class);
+		$donation->assignId(43);
 	}
 
 	public function testNewApplicationHasExpectedDefaults(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 
-		$this->assertNull( $application->getId() );
-		$this->assertFalse( $application->isCancelled() );
-		$this->assertFalse( $application->needsModeration() );
+		$this->assertNull($application->getId());
+		$this->assertFalse($application->isCancelled());
+		$this->assertFalse($application->needsModeration());
 	}
 
 	public function testCancellationResultsInCancelledApplication(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->cancel();
 
-		$this->assertTrue( $application->isCancelled() );
+		$this->assertTrue($application->isCancelled());
 	}
 
 	public function testMarkForModerationResultsInApplicationThatNeedsModeration(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->markForModeration();
 
-		$this->assertTrue( $application->needsModeration() );
+		$this->assertTrue($application->needsModeration());
 	}
 
 	public function testDonationReceiptIsSetFromConstructor(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
-		$this->assertTrue( $application->getDonationReceipt() );
+		$this->assertTrue($application->getDonationReceipt());
 	}
 
 }
\ No newline at end of file

contexts/MembershipContext/tests/Unit/UseCases/ApplyForMembership/MembershipApplicationBuilderTest.php

Spacing +50 added lines, -50 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Unit\UseCases\ApplyForMembership;
 
@@ -29,48 +29,48 @@ 
 	public function testCompanyMembershipRequestGetsBuildCorrectly(): void {
 		$request = $this->newCompanyMembershipRequest();
 
-		$application = ( new MembershipApplicationBuilder() )->newApplicationFromRequest( $request );
+		$application = (new MembershipApplicationBuilder())->newApplicationFromRequest($request);
 
-		$this->assertIsExpectedCompanyPersonName( $application->getApplicant()->getName() );
-		$this->assertIsExpectedAddress( $application->getApplicant()->getPhysicalAddress() );
+		$this->assertIsExpectedCompanyPersonName($application->getApplicant()->getName());
+		$this->assertIsExpectedAddress($application->getApplicant()->getPhysicalAddress());
 
 		$this->assertEquals(
-			Euro::newFromInt( ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO ),
+			Euro::newFromInt(ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO),
 			$application->getPayment()->getAmount()
 		);
 
-		$this->assertTrue( $application->getDonationReceipt() );
+		$this->assertTrue($application->getDonationReceipt());
 	}
 
-	private function newCompanyMembershipRequest( bool $omitOptionalFields = false ): ApplyForMembershipRequest {
+	private function newCompanyMembershipRequest(bool $omitOptionalFields = false): ApplyForMembershipRequest {
 		$request = new ApplyForMembershipRequest();
 
-		$request->setMembershipType( ValidMembershipApplication::MEMBERSHIP_TYPE );
+		$request->setMembershipType(ValidMembershipApplication::MEMBERSHIP_TYPE);
 		$request->markApplicantAsCompany();
-		$request->setApplicantCompanyName( self::COMPANY_NAME );
-		$request->setMembershipType( ValidMembershipApplication::MEMBERSHIP_TYPE );
-		$request->setApplicantSalutation( '' );
-		$request->setApplicantTitle( '' );
-		$request->setApplicantFirstName( '' );
-		$request->setApplicantLastName( '' );
-		$request->setApplicantStreetAddress( ValidMembershipApplication::APPLICANT_STREET_ADDRESS );
-		$request->setApplicantPostalCode( ValidMembershipApplication::APPLICANT_POSTAL_CODE );
-		$request->setApplicantCity( ValidMembershipApplication::APPLICANT_CITY );
-		$request->setApplicantCountryCode( ValidMembershipApplication::APPLICANT_COUNTRY_CODE );
-		$request->setApplicantEmailAddress( ValidMembershipApplication::APPLICANT_EMAIL_ADDRESS );
-		$request->setPaymentType( ValidMembershipApplication::PAYMENT_TYPE_DIRECT_DEBIT );
-		$request->setPaymentIntervalInMonths( ValidMembershipApplication::PAYMENT_PERIOD_IN_MONTHS );
-		$request->setPaymentAmountInEuros( (string)ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO );
-		$request->setBankData( $this->newValidBankData() );
+		$request->setApplicantCompanyName(self::COMPANY_NAME);
+		$request->setMembershipType(ValidMembershipApplication::MEMBERSHIP_TYPE);
+		$request->setApplicantSalutation('');
+		$request->setApplicantTitle('');
+		$request->setApplicantFirstName('');
+		$request->setApplicantLastName('');
+		$request->setApplicantStreetAddress(ValidMembershipApplication::APPLICANT_STREET_ADDRESS);
+		$request->setApplicantPostalCode(ValidMembershipApplication::APPLICANT_POSTAL_CODE);
+		$request->setApplicantCity(ValidMembershipApplication::APPLICANT_CITY);
+		$request->setApplicantCountryCode(ValidMembershipApplication::APPLICANT_COUNTRY_CODE);
+		$request->setApplicantEmailAddress(ValidMembershipApplication::APPLICANT_EMAIL_ADDRESS);
+		$request->setPaymentType(ValidMembershipApplication::PAYMENT_TYPE_DIRECT_DEBIT);
+		$request->setPaymentIntervalInMonths(ValidMembershipApplication::PAYMENT_PERIOD_IN_MONTHS);
+		$request->setPaymentAmountInEuros((string)ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO);
+		$request->setBankData($this->newValidBankData());
 		$request->setApplicantPhoneNumber(
 			$omitOptionalFields ? '' : ValidMembershipApplication::APPLICANT_PHONE_NUMBER
 		);
 		$request->setApplicantDateOfBirth(
 			$omitOptionalFields ? '' : ValidMembershipApplication::APPLICANT_DATE_OF_BIRTH
 		);
-		$request->setTrackingInfo( $this->newTrackingInfo() );
-		$request->setPiwikTrackingString( 'foo/bar' );
-		$request->setOptsIntoDonationReceipt( true );
+		$request->setTrackingInfo($this->newTrackingInfo());
+		$request->setPiwikTrackingString('foo/bar');
+		$request->setOptsIntoDonationReceipt(true);
 
 		return $request->assertNoNullFields()->freeze();
 	}
@@ -78,11 +78,11 @@ 
 	private function newValidBankData(): BankData {
 		$bankData = new BankData();
 
-		$bankData->setIban( new Iban( ValidMembershipApplication::PAYMENT_IBAN ) );
-		$bankData->setBic( ValidMembershipApplication::PAYMENT_BIC );
-		$bankData->setAccount( ValidMembershipApplication::PAYMENT_BANK_ACCOUNT );
-		$bankData->setBankCode( ValidMembershipApplication::PAYMENT_BANK_CODE );
-		$bankData->setBankName( ValidMembershipApplication::PAYMENT_BANK_NAME );
+		$bankData->setIban(new Iban(ValidMembershipApplication::PAYMENT_IBAN));
+		$bankData->setBic(ValidMembershipApplication::PAYMENT_BIC);
+		$bankData->setAccount(ValidMembershipApplication::PAYMENT_BANK_ACCOUNT);
+		$bankData->setBankCode(ValidMembershipApplication::PAYMENT_BANK_CODE);
+		$bankData->setBankName(ValidMembershipApplication::PAYMENT_BANK_NAME);
 
 		return $bankData->assertNoNullFields()->freeze();
 	}
@@ -94,7 +94,7 @@ 
 		);
 	}
 
-	private function assertIsExpectedCompanyPersonName( ApplicantName $name ): void {
+	private function assertIsExpectedCompanyPersonName(ApplicantName $name): void {
 		$this->assertEquals(
 			$this->getCompanyPersonName(),
 			$name
@@ -104,16 +104,16 @@ 
 	private function getCompanyPersonName(): ApplicantName {
 		$name = ApplicantName::newCompanyName();
 
-		$name->setCompanyName( self::COMPANY_NAME );
-		$name->setSalutation( ApplicantName::COMPANY_SALUTATION );
-		$name->setTitle( '' );
-		$name->setFirstName( '' );
-		$name->setLastName( '' );
+		$name->setCompanyName(self::COMPANY_NAME);
+		$name->setSalutation(ApplicantName::COMPANY_SALUTATION);
+		$name->setTitle('');
+		$name->setFirstName('');
+		$name->setLastName('');
 
 		return $name->assertNoNullFields()->freeze();
 	}
 
-	private function assertIsExpectedAddress( ApplicantAddress $address ): void {
+	private function assertIsExpectedAddress(ApplicantAddress $address): void {
 		$this->assertEquals(
 			$this->getPhysicalAddress(),
 			$address
@@ -123,34 +123,34 @@ 
 	private function getPhysicalAddress(): ApplicantAddress {
 		$address = new ApplicantAddress();
 
-		$address->setStreetAddress( ValidMembershipApplication::APPLICANT_STREET_ADDRESS );
-		$address->setPostalCode( ValidMembershipApplication::APPLICANT_POSTAL_CODE );
-		$address->setCity( ValidMembershipApplication::APPLICANT_CITY );
-		$address->setCountryCode( ValidMembershipApplication::APPLICANT_COUNTRY_CODE );
+		$address->setStreetAddress(ValidMembershipApplication::APPLICANT_STREET_ADDRESS);
+		$address->setPostalCode(ValidMembershipApplication::APPLICANT_POSTAL_CODE);
+		$address->setCity(ValidMembershipApplication::APPLICANT_CITY);
+		$address->setCountryCode(ValidMembershipApplication::APPLICANT_COUNTRY_CODE);
 
 		return $address->assertNoNullFields()->freeze();
 	}
 
 	public function testWhenNoBirthDateAndPhoneNumberIsGiven_membershipApplicationIsStillBuiltCorrectly(): void {
-		$request = $this->newCompanyMembershipRequest( self::OMIT_OPTIONAL_FIELDS );
+		$request = $this->newCompanyMembershipRequest(self::OMIT_OPTIONAL_FIELDS);
 
-		$application = ( new MembershipApplicationBuilder() )->newApplicationFromRequest( $request );
+		$application = (new MembershipApplicationBuilder())->newApplicationFromRequest($request);
 
-		$this->assertIsExpectedCompanyPersonName( $application->getApplicant()->getName() );
-		$this->assertIsExpectedAddress( $application->getApplicant()->getPhysicalAddress() );
+		$this->assertIsExpectedCompanyPersonName($application->getApplicant()->getName());
+		$this->assertIsExpectedAddress($application->getApplicant()->getPhysicalAddress());
 
 		$this->assertEquals(
-			Euro::newFromInt( ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO ),
+			Euro::newFromInt(ValidMembershipApplication::PAYMENT_AMOUNT_IN_EURO),
 			$application->getPayment()->getAmount()
 		);
 	}
 
 	public function testWhenBuildingCompanyApplication_salutationFieldIsSet(): void {
-		$request = $this->newCompanyMembershipRequest( self::OMIT_OPTIONAL_FIELDS );
+		$request = $this->newCompanyMembershipRequest(self::OMIT_OPTIONAL_FIELDS);
 
-		$application = ( new MembershipApplicationBuilder() )->newApplicationFromRequest( $request );
+		$application = (new MembershipApplicationBuilder())->newApplicationFromRequest($request);
 
-		$this->assertSame( ApplicantName::COMPANY_SALUTATION, $application->getApplicant()->getName()->getSalutation() );
+		$this->assertSame(ApplicantName::COMPANY_SALUTATION, $application->getApplicant()->getName()->getSalutation());
 	}
 
 }

contexts/MembershipContext/src/Domain/Model/Application.php

Spacing +14 added lines, -14 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Domain\Model;
 
@@ -43,7 +43,7 @@ 
 	private $isDeleted;
 	private $donationReceipt;
 
-	public static function newApplication( string $type, Applicant $applicant, Payment $payment, ?bool $donationReceipt ): self {
+	public static function newApplication(string $type, Applicant $applicant, Payment $payment, ?bool $donationReceipt) : self {
 		return new self(
 			null,
 			$type,
@@ -57,8 +57,8 @@ 
 		);
 	}
 
-	public function __construct( ?int $id, string $type, Applicant $applicant, Payment $payment,
-		bool $needsModeration, bool $isCancelled, bool $isConfirmed, bool $isDeleted, ?bool $donationReceipt ) {
+	public function __construct(?int $id, string $type, Applicant $applicant, Payment $payment,
+		bool $needsModeration, bool $isCancelled, bool $isConfirmed, bool $isDeleted, ?bool $donationReceipt) {
 		$this->id = $id;
 		$this->type = $type;
 		$this->applicant = $applicant;
@@ -98,9 +98,9 @@ 
 	 * @param int $id
 	 * @throws \RuntimeException
 	 */
-	public function assignId( int $id ): void {
-		if ( $this->id !== null && $this->id !== $id ) {
-			throw new \RuntimeException( 'Id cannot be changed after initial assignment' );
+	public function assignId(int $id): void {
+		if ($this->id !== null && $this->id !== $id) {
+			throw new \RuntimeException('Id cannot be changed after initial assignment');
 		}
 
 		$this->id = $id;
@@ -131,12 +131,12 @@ 
 	}
 
 	public function confirmSubscriptionCreated(): void {
-		if ( !$this->hasExternalPayment() ) {
-			throw new RuntimeException( 'Only external payments can be confirmed as booked' );
+		if (!$this->hasExternalPayment()) {
+			throw new RuntimeException('Only external payments can be confirmed as booked');
 		}
 
-		if ( !$this->statusAllowsForBooking() ) {
-			throw new RuntimeException( 'Only unconfirmed membership applications can be confirmed as booked' );
+		if (!$this->statusAllowsForBooking()) {
+			throw new RuntimeException('Only unconfirmed membership applications can be confirmed as booked');
 		}
 
 		$this->confirm();
@@ -158,11 +158,11 @@ 
 		return $this->isDeleted;
 	}
 
-	public function notifyOfFirstPaymentDate( string $firstPaymentDate ): void {
+	public function notifyOfFirstPaymentDate(string $firstPaymentDate): void {
 		$paymentMethod = $this->getPayment()->getPaymentMethod();
 
-		if ( $paymentMethod instanceof PayPalPayment ) {
-			$paymentMethod->getPayPalData()->setFirstPaymentDate( $firstPaymentDate );
+		if ($paymentMethod instanceof PayPalPayment) {
+			$paymentMethod->getPayPalData()->setFirstPaymentDate($firstPaymentDate);
 		}
 	}
 

contexts/MembershipContext/src/UseCases/ApplyForMembership/MembershipApplicationBuilder.php

Spacing +35 added lines, -35 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\UseCases\ApplyForMembership;
 
@@ -26,77 +26,77 @@ 
 
 	const COMPANY_APPLICANT_TYPE = 'firma';
 
-	public function newApplicationFromRequest( ApplyForMembershipRequest $request ): Application {
+	public function newApplicationFromRequest(ApplyForMembershipRequest $request): Application {
 		return Application::newApplication(
 			$request->getMembershipType(),
-			$this->newApplicant( $request ),
-			$this->newPayment( $request ),
+			$this->newApplicant($request),
+			$this->newPayment($request),
 			$request->getOptsIntoDonationReceipt()
 		);
 	}
 
-	private function newApplicant( ApplyForMembershipRequest $request ): Applicant {
+	private function newApplicant(ApplyForMembershipRequest $request): Applicant {
 		return new Applicant(
-			$this->newPersonName( $request ),
-			$this->newAddress( $request ),
-			new EmailAddress( $request->getApplicantEmailAddress() ),
-			new PhoneNumber( $request->getApplicantPhoneNumber() ),
-			( $request->getApplicantDateOfBirth() === '' ) ? null : new \DateTime( $request->getApplicantDateOfBirth() )
+			$this->newPersonName($request),
+			$this->newAddress($request),
+			new EmailAddress($request->getApplicantEmailAddress()),
+			new PhoneNumber($request->getApplicantPhoneNumber()),
+			($request->getApplicantDateOfBirth() === '') ? null : new \DateTime($request->getApplicantDateOfBirth())
 		);
 	}
 
-	private function newPersonName( ApplyForMembershipRequest $request ): ApplicantName {
-		if ( $request->isCompanyApplication() ) {
-			return $this->newCompanyPersonName( $request );
+	private function newPersonName(ApplyForMembershipRequest $request): ApplicantName {
+		if ($request->isCompanyApplication()) {
+			return $this->newCompanyPersonName($request);
 		} else {
-			return $this->newPrivatePersonName( $request );
+			return $this->newPrivatePersonName($request);
 		}
 	}
 
-	private function newPrivatePersonName( ApplyForMembershipRequest $request ): ApplicantName {
+	private function newPrivatePersonName(ApplyForMembershipRequest $request): ApplicantName {
 		$personName = ApplicantName::newPrivatePersonName();
-		$personName->setFirstName( $request->getApplicantFirstName() );
-		$personName->setLastName( $request->getApplicantLastName() );
-		$personName->setSalutation( $request->getApplicantSalutation() );
-		$personName->setTitle( $request->getApplicantTitle() );
+		$personName->setFirstName($request->getApplicantFirstName());
+		$personName->setLastName($request->getApplicantLastName());
+		$personName->setSalutation($request->getApplicantSalutation());
+		$personName->setTitle($request->getApplicantTitle());
 		return $personName->freeze()->assertNoNullFields();
 	}
 
-	private function newCompanyPersonName( ApplyForMembershipRequest $request ): ApplicantName {
+	private function newCompanyPersonName(ApplyForMembershipRequest $request): ApplicantName {
 		$personName = ApplicantName::newCompanyName();
-		$personName->setCompanyName( $request->getApplicantCompanyName() );
+		$personName->setCompanyName($request->getApplicantCompanyName());
 		return $personName->freeze()->assertNoNullFields();
 	}
 
-	private function newAddress( ApplyForMembershipRequest $request ): ApplicantAddress {
+	private function newAddress(ApplyForMembershipRequest $request): ApplicantAddress {
 		$address = new ApplicantAddress();
 
-		$address->setCity( $request->getApplicantCity() );
-		$address->setCountryCode( $request->getApplicantCountryCode() );
-		$address->setPostalCode( $request->getApplicantPostalCode() );
-		$address->setStreetAddress( $request->getApplicantStreetAddress() );
+		$address->setCity($request->getApplicantCity());
+		$address->setCountryCode($request->getApplicantCountryCode());
+		$address->setPostalCode($request->getApplicantPostalCode());
+		$address->setStreetAddress($request->getApplicantStreetAddress());
 
 		return $address->freeze()->assertNoNullFields();
 	}
 
-	private function newPayment( ApplyForMembershipRequest $request ): Payment {
+	private function newPayment(ApplyForMembershipRequest $request): Payment {
 		return new Payment(
 			$request->getPaymentIntervalInMonths(),
-			Euro::newFromString( $request->getPaymentAmountInEuros() ),
-			$this->newPaymentMethod( $request )
+			Euro::newFromString($request->getPaymentAmountInEuros()),
+			$this->newPaymentMethod($request)
 		);
 	}
 
-	private function newPaymentMethod( ApplyForMembershipRequest $request ): PaymentMethod {
-		if ( $request->getPaymentType() === PaymentType::DIRECT_DEBIT ) {
-			return new DirectDebitPayment( $request->getBankData() );
+	private function newPaymentMethod(ApplyForMembershipRequest $request): PaymentMethod {
+		if ($request->getPaymentType() === PaymentType::DIRECT_DEBIT) {
+			return new DirectDebitPayment($request->getBankData());
 		}
 
-		if ( $request->getPaymentType() === PaymentType::PAYPAL ) {
-			return new PayPalPayment( new PayPalData() );
+		if ($request->getPaymentType() === PaymentType::PAYPAL) {
+			return new PayPalPayment(new PayPalData());
 		}
 
-		throw new \RuntimeException( 'Unsupported payment type' );
+		throw new \RuntimeException('Unsupported payment type');
 	}
 
 }

contexts/MembershipContext/src/UseCases/ApplyForMembership/ApplyForMembershipRequest.php

Spacing +21 added lines, -21 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\UseCases\ApplyForMembership;
 
@@ -47,7 +47,7 @@ 
 		return $this->membershipType;
 	}
 
-	public function setMembershipType( string $membershipType ): void {
+	public function setMembershipType(string $membershipType): void {
 		$this->assertIsWritable();
 		$this->membershipType = $membershipType;
 	}
@@ -68,7 +68,7 @@ 
 		return $this->applicantCompanyName;
 	}
 
-	public function setApplicantCompanyName( string $applicantCompanyName ): void {
+	public function setApplicantCompanyName(string $applicantCompanyName): void {
 		$this->applicantCompanyName = $applicantCompanyName;
 	}
 
@@ -76,7 +76,7 @@ 
 		return $this->applicantSalutation;
 	}
 
-	public function setApplicantSalutation( string $applicantSalutation ): void {
+	public function setApplicantSalutation(string $applicantSalutation): void {
 		$this->assertIsWritable();
 		$this->applicantSalutation = $applicantSalutation;
 	}
@@ -85,7 +85,7 @@ 
 		return $this->applicantTitle;
 	}
 
-	public function setApplicantTitle( string $applicantTitle ): void {
+	public function setApplicantTitle(string $applicantTitle): void {
 		$this->assertIsWritable();
 		$this->applicantTitle = $applicantTitle;
 	}
@@ -94,7 +94,7 @@ 
 		return $this->applicantFirstName;
 	}
 
-	public function setApplicantFirstName( string $applicantFirstName ): void {
+	public function setApplicantFirstName(string $applicantFirstName): void {
 		$this->assertIsWritable();
 		$this->applicantFirstName = $applicantFirstName;
 	}
@@ -103,7 +103,7 @@ 
 		return $this->applicantLastName;
 	}
 
-	public function setApplicantLastName( string $applicantLastName ): void {
+	public function setApplicantLastName(string $applicantLastName): void {
 		$this->assertIsWritable();
 		$this->applicantLastName = $applicantLastName;
 	}
@@ -112,7 +112,7 @@ 
 		return $this->applicantStreetAddress;
 	}
 
-	public function setApplicantStreetAddress( string $applicantStreetAddress ): void {
+	public function setApplicantStreetAddress(string $applicantStreetAddress): void {
 		$this->assertIsWritable();
 		$this->applicantStreetAddress = $applicantStreetAddress;
 	}
@@ -121,7 +121,7 @@ 
 		return $this->applicantPostalCode;
 	}
 
-	public function setApplicantPostalCode( string $applicantPostalCode ): void {
+	public function setApplicantPostalCode(string $applicantPostalCode): void {
 		$this->assertIsWritable();
 		$this->applicantPostalCode = $applicantPostalCode;
 	}
@@ -130,7 +130,7 @@ 
 		return $this->applicantCity;
 	}
 
-	public function setApplicantCity( string $applicantCity ): void {
+	public function setApplicantCity(string $applicantCity): void {
 		$this->assertIsWritable();
 		$this->applicantCity = $applicantCity;
 	}
@@ -139,7 +139,7 @@ 
 		return $this->applicantCountryCode;
 	}
 
-	public function setApplicantCountryCode( string $applicantCountryCode ): void {
+	public function setApplicantCountryCode(string $applicantCountryCode): void {
 		$this->assertIsWritable();
 		$this->applicantCountryCode = $applicantCountryCode;
 	}
@@ -148,7 +148,7 @@ 
 		return $this->applicantEmailAddress;
 	}
 
-	public function setApplicantEmailAddress( string $applicantEmailAddress ): void {
+	public function setApplicantEmailAddress(string $applicantEmailAddress): void {
 		$this->assertIsWritable();
 		$this->applicantEmailAddress = $applicantEmailAddress;
 	}
@@ -157,7 +157,7 @@ 
 		return $this->applicantPhoneNumber;
 	}
 
-	public function setApplicantPhoneNumber( string $applicantPhoneNumber ): void {
+	public function setApplicantPhoneNumber(string $applicantPhoneNumber): void {
 		$this->assertIsWritable();
 		$this->applicantPhoneNumber = $applicantPhoneNumber;
 	}
@@ -166,7 +166,7 @@ 
 		return $this->applicantDateOfBirth;
 	}
 
-	public function setApplicantDateOfBirth( string $applicantDateOfBirth ): void {
+	public function setApplicantDateOfBirth(string $applicantDateOfBirth): void {
 		$this->assertIsWritable();
 		$this->applicantDateOfBirth = $applicantDateOfBirth;
 	}
@@ -175,7 +175,7 @@ 
 		return $this->paymentIntervalInMonths;
 	}
 
-	public function setPaymentIntervalInMonths( int $paymentIntervalInMonths ): void {
+	public function setPaymentIntervalInMonths(int $paymentIntervalInMonths): void {
 		$this->assertIsWritable();
 		$this->paymentIntervalInMonths = $paymentIntervalInMonths;
 	}
@@ -184,7 +184,7 @@ 
 		return $this->paymentAmount;
 	}
 
-	public function setPaymentAmountInEuros( string $paymentAmount ): void {
+	public function setPaymentAmountInEuros(string $paymentAmount): void {
 		$this->assertIsWritable();
 		$this->paymentAmount = $paymentAmount;
 	}
@@ -193,7 +193,7 @@ 
 		return $this->bankData;
 	}
 
-	public function setBankData( BankData $bankData ): void {
+	public function setBankData(BankData $bankData): void {
 		$this->assertIsWritable();
 		$this->bankData = $bankData;
 	}
@@ -202,7 +202,7 @@ 
 		return $this->trackingInfo;
 	}
 
-	public function setTrackingInfo( MembershipApplicationTrackingInfo $trackingInfo ): void {
+	public function setTrackingInfo(MembershipApplicationTrackingInfo $trackingInfo): void {
 		$this->assertIsWritable();
 		$this->trackingInfo = $trackingInfo;
 	}
@@ -211,7 +211,7 @@ 
 		return $this->piwikTrackingString;
 	}
 
-	public function setPiwikTrackingString( string $piwikTrackingString ): void {
+	public function setPiwikTrackingString(string $piwikTrackingString): void {
 		$this->assertIsWritable();
 		$this->piwikTrackingString = $piwikTrackingString;
 	}
@@ -220,7 +220,7 @@ 
 		return $this->paymentType;
 	}
 
-	public function setPaymentType( string $paymentType ): void {
+	public function setPaymentType(string $paymentType): void {
 		$this->assertIsWritable();
 		$this->paymentType = $paymentType;
 	}
@@ -229,7 +229,7 @@ 
 		return $this->optsIntoDonationReceipt;
 	}
 
-	public function setOptsIntoDonationReceipt( bool $optIn ): void {
+	public function setOptsIntoDonationReceipt(bool $optIn): void {
 		$this->assertIsWritable();
 		$this->optsIntoDonationReceipt = $optIn;
 	}

contexts/MembershipContext/src/UseCases/HandleSubscriptionPaymentNotification/HandleSubscriptionPaymentNotificationUseCase.php

Spacing +52 added lines, -52 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\UseCases\HandleSubscriptionPaymentNotification;
 
@@ -29,8 +29,8 @@ 
 	private $mailer;
 	private $logger;
 
-	public function __construct( ApplicationRepository $repository, ApplicationAuthorizer $authorizationService,
-		TemplateMailerInterface $mailer, LoggerInterface $logger ) {
+	public function __construct(ApplicationRepository $repository, ApplicationAuthorizer $authorizationService,
+		TemplateMailerInterface $mailer, LoggerInterface $logger) {
 
 		$this->repository = $repository;
 		$this->authorizationService = $authorizationService;
@@ -38,108 +38,108 @@ 
 		$this->logger = $logger;
 	}
 
-	public function handleNotification( PayPalPaymentNotificationRequest $request ): PaypalNotificationResponse {
+	public function handleNotification(PayPalPaymentNotificationRequest $request): PaypalNotificationResponse {
 		try {
-			$membershipApplication = $this->repository->getApplicationById( $request->getInternalId() );
-		} catch ( GetMembershipApplicationException $ex ) {
-			return $this->createErrorResponse( $ex );
+			$membershipApplication = $this->repository->getApplicationById($request->getInternalId());
+		} catch (GetMembershipApplicationException $ex) {
+			return $this->createErrorResponse($ex);
 		}
 
-		if ( $membershipApplication === null ) {
-			return $this->createUnhandledResponse( 'specified data set could not be found' );
+		if ($membershipApplication === null) {
+			return $this->createUnhandledResponse('specified data set could not be found');
 		}
 
-		return $this->handleRequestForPayment( $request, $membershipApplication );
+		return $this->handleRequestForPayment($request, $membershipApplication);
 	}
 
-	private function handleRequestForPayment( PayPalPaymentNotificationRequest $request,
-											  Application $application ): PaypalNotificationResponse {
-		if ( !( $application->getPayment()->getPaymentMethod() instanceof PayPalPayment ) ) {
-			return $this->createUnhandledResponse( 'Trying to handle IPN for non-PayPal membership application' );
+	private function handleRequestForPayment(PayPalPaymentNotificationRequest $request,
+											  Application $application): PaypalNotificationResponse {
+		if (!($application->getPayment()->getPaymentMethod() instanceof PayPalPayment)) {
+			return $this->createUnhandledResponse('Trying to handle IPN for non-PayPal membership application');
 		}
 
-		if ( !$this->authorizationService->canModifyApplication( $request->getInternalId() ) ) {
-			return $this->createUnhandledResponse( 'Wrong access code for membership application' );
+		if (!$this->authorizationService->canModifyApplication($request->getInternalId())) {
+			return $this->createUnhandledResponse('Wrong access code for membership application');
 		}
 
-		if ( $this->transactionAlreadyProcessed( $application, $request ) ) {
-			return $this->createUnhandledResponse( 'Trying to handle IPN for already processed transaction' );
+		if ($this->transactionAlreadyProcessed($application, $request)) {
+			return $this->createUnhandledResponse('Trying to handle IPN for already processed transaction');
 		}
 
-		$childApplication = $this->createChildApplication( $application, $request );
+		$childApplication = $this->createChildApplication($application, $request);
 
 		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $payment */
 		$payment = $application->getPayment()->getPaymentMethod();
-		$payment->getPayPalData()->addChildPayment( $request->getTransactionId(), $childApplication->getId() );
+		$payment->getPayPalData()->addChildPayment($request->getTransactionId(), $childApplication->getId());
 
 		try {
-			$this->repository->storeApplication( $application );
+			$this->repository->storeApplication($application);
 		}
-		catch ( StoreMembershipApplicationException $ex ) {
-			$this->createErrorResponse( $ex );
+		catch (StoreMembershipApplicationException $ex) {
+			$this->createErrorResponse($ex);
 		}
 
 		return PaypalNotificationResponse::newSuccessResponse();
 	}
 
-	private function createUnhandledResponse( string $reason ): PaypalNotificationResponse {
-		return PaypalNotificationResponse::newUnhandledResponse( [
+	private function createUnhandledResponse(string $reason): PaypalNotificationResponse {
+		return PaypalNotificationResponse::newUnhandledResponse([
 			'message' => $reason
-		] );
+		]);
 	}
 
-	private function createErrorResponse( \Exception $ex ): PaypalNotificationResponse {
-		return PaypalNotificationResponse::newFailureResponse( [
+	private function createErrorResponse(\Exception $ex): PaypalNotificationResponse {
+		return PaypalNotificationResponse::newFailureResponse([
 			'message' => $ex->getMessage(),
 			'stackTrace' => $ex->getTraceAsString()
-		] );
+		]);
 	}
-	private function newPayPalDataFromRequest( PayPalPaymentNotificationRequest $request ): PayPalData {
-		return ( new PayPalData() )
-			->setPayerId( $request->getPayerId() )
-			->setSubscriberId( $request->getSubscriptionId() )
-			->setPayerStatus( $request->getPayerStatus() )
-			->setAddressStatus( $request->getPayerAddressStatus() )
-			->setAmount( $request->getAmountGross() )
-			->setCurrencyCode( $request->getCurrencyCode() )
-			->setFee( Euro::newFromString( $request->getTransactionFee() ) )
-			->setSettleAmount( $request->getSettleAmount() )
-			->setFirstName( $request->getPayerFirstName() )
-			->setLastName( $request->getPayerLastName() )
-			->setAddressName( $request->getPayerAddressName() )
-			->setPaymentId( $request->getTransactionId() )
-			->setPaymentType( $request->getPaymentType() )
-			->setPaymentStatus( implode( '/', [ $request->getPaymentStatus(), $request->getTransactionType() ] ) )
-			->setPaymentTimestamp( $request->getPaymentTimestamp() );
+	private function newPayPalDataFromRequest(PayPalPaymentNotificationRequest $request): PayPalData {
+		return (new PayPalData())
+			->setPayerId($request->getPayerId())
+			->setSubscriberId($request->getSubscriptionId())
+			->setPayerStatus($request->getPayerStatus())
+			->setAddressStatus($request->getPayerAddressStatus())
+			->setAmount($request->getAmountGross())
+			->setCurrencyCode($request->getCurrencyCode())
+			->setFee(Euro::newFromString($request->getTransactionFee()))
+			->setSettleAmount($request->getSettleAmount())
+			->setFirstName($request->getPayerFirstName())
+			->setLastName($request->getPayerLastName())
+			->setAddressName($request->getPayerAddressName())
+			->setPaymentId($request->getTransactionId())
+			->setPaymentType($request->getPaymentType())
+			->setPaymentStatus(implode('/', [$request->getPaymentStatus(), $request->getTransactionType()]))
+			->setPaymentTimestamp($request->getPaymentTimestamp());
 	}
 
-	private function createChildApplication( Application $application, PayPalPaymentNotificationRequest $request ): ?Application {
+	private function createChildApplication(Application $application, PayPalPaymentNotificationRequest $request): ?Application {
 		$childApplication = Application::newApplication(
 			$application->getType(),
 			$application->getApplicant(),
 			new Payment(
 				$application->getPayment()->getIntervalInMonths(),
 				$application->getPayment()->getAmount(),
-				new PayPalPayment( $this->newPayPalDataFromRequest( $request ) )
+				new PayPalPayment($this->newPayPalDataFromRequest($request))
 			),
 			$application->getDonationReceipt()
 		);
 		$childApplication->confirm();
 
 		try {
-			$this->repository->storeApplication( $childApplication );
+			$this->repository->storeApplication($childApplication);
 		}
-		catch ( StoreMembershipApplicationException $ex ) {
+		catch (StoreMembershipApplicationException $ex) {
 			return null;
 		}
 
 		return $childApplication;
 	}
 
-	private function transactionAlreadyProcessed( Application $application, PayPalPaymentNotificationRequest $request ): bool {
+	private function transactionAlreadyProcessed(Application $application, PayPalPaymentNotificationRequest $request): bool {
 		/** @var PayPalPayment $payment */
 		$payment = $application->getPayment()->getPaymentMethod();
-		return $payment->getPayPalData()->hasChildPayment( $request->getTransactionId() );
+		return $payment->getPayPalData()->hasChildPayment($request->getTransactionId());
 	}
 
 }

contexts/MembershipContext/src/DataAccess/DoctrineApplicationRepository.php

Spacing +128 added lines, -128 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\DataAccess;
 
@@ -35,108 +35,108 @@ 
 
 	private $entityManager;
 
-	public function __construct( EntityManager $entityManager ) {
+	public function __construct(EntityManager $entityManager) {
 		$this->entityManager = $entityManager;
 	}
 
-	public function storeApplication( Application $application ): void {
-		if ( $application->hasId() ) {
-			$this->updateApplication( $application );
+	public function storeApplication(Application $application): void {
+		if ($application->hasId()) {
+			$this->updateApplication($application);
 		}
 		else {
-			$this->insertApplication( $application );
+			$this->insertApplication($application);
 		}
 	}
 
-	private function insertApplication( Application $application ): void {
+	private function insertApplication(Application $application): void {
 		$doctrineApplication = new DoctrineApplication();
-		$this->updateDoctrineApplication( $doctrineApplication, $application );
+		$this->updateDoctrineApplication($doctrineApplication, $application);
 
 		try {
-			$this->entityManager->persist( $doctrineApplication );
+			$this->entityManager->persist($doctrineApplication);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreMembershipApplicationException($ex);
 		}
 
-		$application->assignId( $doctrineApplication->getId() );
+		$application->assignId($doctrineApplication->getId());
 	}
 
-	private function updateApplication( Application $application ): void {
-		$doctrineApplication = $this->getDoctrineApplicationById( $application->getId() );
+	private function updateApplication(Application $application): void {
+		$doctrineApplication = $this->getDoctrineApplicationById($application->getId());
 
-		if ( $doctrineApplication === null ) {
+		if ($doctrineApplication === null) {
 			throw new StoreMembershipApplicationException();
 		}
 
-		$this->updateDoctrineApplication( $doctrineApplication, $application );
+		$this->updateDoctrineApplication($doctrineApplication, $application);
 
 		try {
-			$this->entityManager->persist( $doctrineApplication );
+			$this->entityManager->persist($doctrineApplication);
 			$this->entityManager->flush();
 		}
-		catch ( ORMException $ex ) {
-			throw new StoreMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new StoreMembershipApplicationException($ex);
 		}
 	}
 
-	private function updateDoctrineApplication( DoctrineApplication $doctrineApplication, Application $application ): void {
-		$doctrineApplication->setId( $application->getId() );
-		$doctrineApplication->setMembershipType( $application->getType() );
+	private function updateDoctrineApplication(DoctrineApplication $doctrineApplication, Application $application): void {
+		$doctrineApplication->setId($application->getId());
+		$doctrineApplication->setMembershipType($application->getType());
 
-		$this->setApplicantFields( $doctrineApplication, $application->getApplicant() );
-		$this->setPaymentFields( $doctrineApplication, $application->getPayment() );
-		$doctrineApplication->setDonationReceipt( $application->getDonationReceipt() );
+		$this->setApplicantFields($doctrineApplication, $application->getApplicant());
+		$this->setPaymentFields($doctrineApplication, $application->getPayment());
+		$doctrineApplication->setDonationReceipt($application->getDonationReceipt());
 
-		$doctrineStatus = $this->getDoctrineStatus( $application );
-		$this->preserveDoctrineStatus( $doctrineApplication, $doctrineStatus );
-		$doctrineApplication->setStatus( $doctrineStatus );
+		$doctrineStatus = $this->getDoctrineStatus($application);
+		$this->preserveDoctrineStatus($doctrineApplication, $doctrineStatus);
+		$doctrineApplication->setStatus($doctrineStatus);
 	}
 
-	private function setApplicantFields( DoctrineApplication $application, Applicant $applicant ): void {
-		$application->setApplicantFirstName( $applicant->getName()->getFirstName() );
-		$application->setApplicantLastName( $applicant->getName()->getLastName() );
-		$application->setApplicantSalutation( $applicant->getName()->getSalutation() );
-		$application->setApplicantTitle( $applicant->getName()->getTitle() );
-		$application->setCompany( $applicant->getName()->getCompanyName() );
+	private function setApplicantFields(DoctrineApplication $application, Applicant $applicant): void {
+		$application->setApplicantFirstName($applicant->getName()->getFirstName());
+		$application->setApplicantLastName($applicant->getName()->getLastName());
+		$application->setApplicantSalutation($applicant->getName()->getSalutation());
+		$application->setApplicantTitle($applicant->getName()->getTitle());
+		$application->setCompany($applicant->getName()->getCompanyName());
 
-		$application->setApplicantDateOfBirth( $applicant->getDateOfBirth() );
+		$application->setApplicantDateOfBirth($applicant->getDateOfBirth());
 
-		$application->setApplicantEmailAddress( $applicant->getEmailAddress()->getFullAddress() );
-		$application->setApplicantPhoneNumber( $applicant->getPhoneNumber()->__toString() );
+		$application->setApplicantEmailAddress($applicant->getEmailAddress()->getFullAddress());
+		$application->setApplicantPhoneNumber($applicant->getPhoneNumber()->__toString());
 
 		$address = $applicant->getPhysicalAddress();
 
-		$application->setCity( $address->getCity() );
-		$application->setCountry( $address->getCountryCode() );
-		$application->setPostcode( $address->getPostalCode() );
-		$application->setAddress( $address->getStreetAddress() );
+		$application->setCity($address->getCity());
+		$application->setCountry($address->getCountryCode());
+		$application->setPostcode($address->getPostalCode());
+		$application->setAddress($address->getStreetAddress());
 	}
 
-	private function setPaymentFields( DoctrineApplication $application, Payment $payment ): void {
-		$application->setPaymentIntervalInMonths( $payment->getIntervalInMonths() );
-		$application->setPaymentAmount( (int)$payment->getAmount()->getEuroFloat() );
+	private function setPaymentFields(DoctrineApplication $application, Payment $payment): void {
+		$application->setPaymentIntervalInMonths($payment->getIntervalInMonths());
+		$application->setPaymentAmount((int)$payment->getAmount()->getEuroFloat());
 		$paymentMethod = $payment->getPaymentMethod();
 
-		$application->setPaymentType( $paymentMethod->getType() );
-		if ( $paymentMethod instanceof DirectDebitPayment ) {
-			$this->setBankDataFields( $application, $paymentMethod->getBankData() );
-		} elseif ( $paymentMethod instanceof PayPalPayment && $paymentMethod->getPayPalData() != new PayPalData() ) {
-			$this->setPayPalDataFields( $application, $paymentMethod->getPayPalData() );
+		$application->setPaymentType($paymentMethod->getType());
+		if ($paymentMethod instanceof DirectDebitPayment) {
+			$this->setBankDataFields($application, $paymentMethod->getBankData());
+		} elseif ($paymentMethod instanceof PayPalPayment && $paymentMethod->getPayPalData() != new PayPalData()) {
+			$this->setPayPalDataFields($application, $paymentMethod->getPayPalData());
 		}
 	}
 
-	private function setBankDataFields( DoctrineApplication $application, BankData $bankData ): void {
-		$application->setPaymentBankAccount( $bankData->getAccount() );
-		$application->setPaymentBankCode( $bankData->getBankCode() );
-		$application->setPaymentBankName( $bankData->getBankName() );
-		$application->setPaymentBic( $bankData->getBic() );
-		$application->setPaymentIban( $bankData->getIban()->toString() );
+	private function setBankDataFields(DoctrineApplication $application, BankData $bankData): void {
+		$application->setPaymentBankAccount($bankData->getAccount());
+		$application->setPaymentBankCode($bankData->getBankCode());
+		$application->setPaymentBankName($bankData->getBankName());
+		$application->setPaymentBic($bankData->getBic());
+		$application->setPaymentIban($bankData->getIban()->toString());
 	}
 
-	private function setPayPalDataFields( DoctrineApplication $application, PayPalData $payPalData ): void {
-		$application->encodeAndSetData( array_merge(
+	private function setPayPalDataFields(DoctrineApplication $application, PayPalData $payPalData): void {
+		$application->encodeAndSetData(array_merge(
 			$application->getDecodedData(),
 			[
 				'paypal_payer_id' => $payPalData->getPayerId(),
@@ -158,43 +158,43 @@ 
 				'ext_payment_timestamp' => $payPalData->getPaymentTimestamp(),
 				'first_payment_date' => $payPalData->getFirstPaymentDate()
 			]
-		) );
+		));
 	}
 
-	private function getDoctrineStatus( Application $application ): int {
+	private function getDoctrineStatus(Application $application): int {
 		$status = DoctrineApplication::STATUS_NEUTRAL;
 
-		if ( $application->needsModeration() ) {
+		if ($application->needsModeration()) {
 			$status += DoctrineApplication::STATUS_MODERATION;
 		}
 
-		if ( $application->isCancelled() ) {
+		if ($application->isCancelled()) {
 			$status += DoctrineApplication::STATUS_CANCELED;
 		}
 
-		if ( $application->isDeleted() ) {
+		if ($application->isDeleted()) {
 			$status += DoctrineApplication::STATUS_DELETED;
 		}
 
-		if ( $application->isConfirmed() || $this->isAutoConfirmed( $status, $application ) ) {
+		if ($application->isConfirmed() || $this->isAutoConfirmed($status, $application)) {
 			$status += DoctrineApplication::STATUS_CONFIRMED;
 		}
 
 		return $status;
 	}
 
-	private function isAutoConfirmed( int $status, Application $application ): bool {
-		return $status === DoctrineApplication::STATUS_NEUTRAL && $this->isDirectDebitPayment( $application );
+	private function isAutoConfirmed(int $status, Application $application): bool {
+		return $status === DoctrineApplication::STATUS_NEUTRAL && $this->isDirectDebitPayment($application);
 	}
 
-	private function isDirectDebitPayment( Application $application ): bool {
+	private function isDirectDebitPayment(Application $application): bool {
 		return $application->getPayment()->getPaymentMethod()->getType() === PaymentType::DIRECT_DEBIT;
 	}
 
-	private function preserveDoctrineStatus( DoctrineApplication $doctrineApplication, int $doctrineStatus ): void {
-		if ( $doctrineStatus < DoctrineApplication::STATUS_CONFIRMED ) {
-			$doctrineApplication->modifyDataObject( function ( MembershipApplicationData $data ): void {
-				$data->setPreservedStatus( DoctrineApplication::STATUS_CONFIRMED );
+	private function preserveDoctrineStatus(DoctrineApplication $doctrineApplication, int $doctrineStatus): void {
+		if ($doctrineStatus < DoctrineApplication::STATUS_CONFIRMED) {
+			$doctrineApplication->modifyDataObject(function(MembershipApplicationData $data): void {
+				$data->setPreservedStatus(DoctrineApplication::STATUS_CONFIRMED);
 			} );
 		}
 	}
@@ -205,19 +205,19 @@ 
 	 * @return Application|null
 	 * @throws GetMembershipApplicationException
 	 */
-	public function getApplicationById( int $id ): ?Application {
+	public function getApplicationById(int $id): ?Application {
 		try {
-			$application = $this->getDoctrineApplicationById( $id );
+			$application = $this->getDoctrineApplicationById($id);
 		}
-		catch ( ORMException $ex ) {
-			throw new GetMembershipApplicationException( $ex );
+		catch (ORMException $ex) {
+			throw new GetMembershipApplicationException($ex);
 		}
 
-		if ( $application === null ) {
+		if ($application === null) {
 			return null;
 		}
 
-		return $this->newApplicationDomainEntity( $application );
+		return $this->newApplicationDomainEntity($application);
 	}
 
 	/**
@@ -225,25 +225,25 @@ 
 	 * @return DoctrineApplication|null
 	 * @throws ORMException
 	 */
-	public function getDoctrineApplicationById( int $id ): ?DoctrineApplication {
-		return $this->entityManager->find( DoctrineApplication::class, $id );
+	public function getDoctrineApplicationById(int $id): ?DoctrineApplication {
+		return $this->entityManager->find(DoctrineApplication::class, $id);
 	}
 
-	private function newApplicationDomainEntity( DoctrineApplication $application ): Application {
+	private function newApplicationDomainEntity(DoctrineApplication $application): Application {
 		return new Application(
 			$application->getId(),
 			$application->getMembershipType(),
 			new Applicant(
-				$this->newPersonName( $application ),
-				$this->newAddress( $application ),
-				new EmailAddress( $application->getApplicantEmailAddress() ),
-				new PhoneNumber( $application->getApplicantPhoneNumber() ),
+				$this->newPersonName($application),
+				$this->newAddress($application),
+				new EmailAddress($application->getApplicantEmailAddress()),
+				new PhoneNumber($application->getApplicantPhoneNumber()),
 				$application->getApplicantDateOfBirth()
 			),
 			new Payment(
 				$application->getPaymentIntervalInMonths(),
-				Euro::newFromFloat( $application->getPaymentAmount() ),
-				$this->newPaymentMethod( $application )
+				Euro::newFromFloat($application->getPaymentAmount()),
+				$this->newPaymentMethod($application)
 			),
 			$application->needsModeration(),
 			$application->isCancelled(),
@@ -253,77 +253,77 @@ 
 		);
 	}
 
-	private function newPersonName( DoctrineApplication $application ): ApplicantName {
-		if ( empty( $application->getCompany() ) ) {
+	private function newPersonName(DoctrineApplication $application): ApplicantName {
+		if (empty($application->getCompany())) {
 			$personName = ApplicantName::newPrivatePersonName();
-			$personName->setFirstName( $application->getApplicantFirstName() );
-			$personName->setLastName( $application->getApplicantLastName() );
-			$personName->setSalutation( $application->getApplicantSalutation() );
-			$personName->setTitle( $application->getApplicantTitle() );
+			$personName->setFirstName($application->getApplicantFirstName());
+			$personName->setLastName($application->getApplicantLastName());
+			$personName->setSalutation($application->getApplicantSalutation());
+			$personName->setTitle($application->getApplicantTitle());
 		} else {
 			$personName = ApplicantName::newCompanyName();
-			$personName->setCompanyName( $application->getCompany() );
-			$personName->setSalutation( $application->getApplicantSalutation() );
+			$personName->setCompanyName($application->getCompany());
+			$personName->setSalutation($application->getApplicantSalutation());
 		}
 
 		return $personName->freeze()->assertNoNullFields();
 	}
 
-	private function newAddress( DoctrineApplication $application ): ApplicantAddress {
+	private function newAddress(DoctrineApplication $application): ApplicantAddress {
 		$address = new ApplicantAddress();
 
-		$address->setCity( $application->getCity() );
-		$address->setCountryCode( $application->getCountry() );
-		$address->setPostalCode( $application->getPostcode() );
-		$address->setStreetAddress( $application->getAddress() );
+		$address->setCity($application->getCity());
+		$address->setCountryCode($application->getCountry());
+		$address->setPostalCode($application->getPostcode());
+		$address->setStreetAddress($application->getAddress());
 
 		return $address->freeze()->assertNoNullFields();
 	}
 
-	private function newPaymentMethod( DoctrineApplication $application ): PaymentMethod {
-		if ( $application->getPaymentType() === PaymentType::DIRECT_DEBIT ) {
-			return new DirectDebitPayment( $this->newBankData( $application ) );
+	private function newPaymentMethod(DoctrineApplication $application): PaymentMethod {
+		if ($application->getPaymentType() === PaymentType::DIRECT_DEBIT) {
+			return new DirectDebitPayment($this->newBankData($application));
 		}
 
-		if ( $application->getPaymentType() === PaymentType::PAYPAL ) {
-			return new PayPalPayment( $this->newPayPalData( $application ) );
+		if ($application->getPaymentType() === PaymentType::PAYPAL) {
+			return new PayPalPayment($this->newPayPalData($application));
 		}
 
-		throw new \RuntimeException( 'Unsupported payment type' );
+		throw new \RuntimeException('Unsupported payment type');
 	}
 
-	private function newBankData( DoctrineApplication $application ): BankData {
+	private function newBankData(DoctrineApplication $application): BankData {
 		$bankData = new BankData();
 
-		$bankData->setAccount( $application->getPaymentBankAccount() );
-		$bankData->setBankCode( $application->getPaymentBankCode() );
-		$bankData->setBankName( $application->getPaymentBankName() );
-		$bankData->setBic( $application->getPaymentBic() );
-		$bankData->setIban( new Iban( $application->getPaymentIban() ) );
+		$bankData->setAccount($application->getPaymentBankAccount());
+		$bankData->setBankCode($application->getPaymentBankCode());
+		$bankData->setBankName($application->getPaymentBankName());
+		$bankData->setBic($application->getPaymentBic());
+		$bankData->setIban(new Iban($application->getPaymentIban()));
 
 		return $bankData->freeze()->assertNoNullFields();
 	}
 
-	private function newPayPalData( DoctrineApplication $application ): ?PayPalData {
+	private function newPayPalData(DoctrineApplication $application): ?PayPalData {
 		$data = $application->getDecodedData();
 
-		return ( new PayPalData() )
-			->setPayerId( $data['paypal_payer_id'] ?? '' )
-			->setSubscriberId( $data['paypal_subscr_id'] ?? '' )
-			->setPayerStatus( $data['paypal_payer_status'] ?? '' )
-			->setAddressStatus( $data['paypal_address_status'] ?? '' )
-			->setAmount( Euro::newFromString( $data['paypal_mc_gross'] ?? '0' ) )
-			->setCurrencyCode( $data['paypal_mc_currency'] ?? '' )
-			->setFee( Euro::newFromString( $data['paypal_mc_fee'] ?? '0' ) )
-			->setSettleAmount( Euro::newFromString( $data['paypal_settle_amount'] ?? '0' ) )
-			->setFirstName( $data['paypal_first_name'] ?? '' )
-			->setLastName( $data['paypal_last_name'] ?? '' )
-			->setAddressName( $data['paypal_address_name'] ?? '' )
-			->setPaymentId( $data['ext_payment_id'] ?? '' )
-			->setPaymentType( $data['ext_payment_type'] ?? '' )
-			->setPaymentStatus( $data['ext_payment_status'] ?? '' )
-			->setPaymentTimestamp( $data['ext_payment_timestamp'] ?? '' )
-			->setFirstPaymentDate( $data['first_payment_date'] ?? '' )
+		return (new PayPalData())
+			->setPayerId($data['paypal_payer_id'] ?? '')
+			->setSubscriberId($data['paypal_subscr_id'] ?? '')
+			->setPayerStatus($data['paypal_payer_status'] ?? '')
+			->setAddressStatus($data['paypal_address_status'] ?? '')
+			->setAmount(Euro::newFromString($data['paypal_mc_gross'] ?? '0'))
+			->setCurrencyCode($data['paypal_mc_currency'] ?? '')
+			->setFee(Euro::newFromString($data['paypal_mc_fee'] ?? '0'))
+			->setSettleAmount(Euro::newFromString($data['paypal_settle_amount'] ?? '0'))
+			->setFirstName($data['paypal_first_name'] ?? '')
+			->setLastName($data['paypal_last_name'] ?? '')
+			->setAddressName($data['paypal_address_name'] ?? '')
+			->setPaymentId($data['ext_payment_id'] ?? '')
+			->setPaymentType($data['ext_payment_type'] ?? '')
+			->setPaymentStatus($data['ext_payment_status'] ?? '')
+			->setPaymentTimestamp($data['ext_payment_timestamp'] ?? '')
+			->setFirstPaymentDate($data['first_payment_date'] ?? '')
 			->freeze()->assertNoNullFields();
 	}