wmde / FundraisingFrontend

src/Infrastructure/ConfigReader.php

Braces +1 added lines, -2 removed lines

@@ -62,8 +62,7 @@
 	private function getFileContents( string $filePath ): string {
 		try {
 			return $this->fileFetcher->fetchFile( $filePath );
-		}
-		catch ( FileFetchingException $ex ) {
+		} catch ( FileFetchingException $ex ) {
 			throw new RuntimeException( 'Cannot read config file at path "' . $filePath . '"', 0, $ex );
 		}
 	}

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WMDE\Fundraising\Frontend\Infrastructure;
 

src/Infrastructure/Cache/AuthorizedCachePurger.php

Braces +1 added lines, -2 removed lines

@@ -29,8 +29,7 @@
 
 		try {
 			$this->cachePurger->purgeCache();
-		}
-		catch ( CachePurgingException $ex ) {
+		} catch ( CachePurgingException $ex ) {
 			return self::RESULT_ERROR;
 		}
 

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WMDE\Fundraising\Frontend\Infrastructure\Cache;
 

src/Validation/TemplateNameValidator.php

Braces +1 added lines, -2 removed lines

@@ -22,8 +22,7 @@
 	public function validate( $value ): ValidationResult {	// @codingStandardsIgnoreLine
 		try {
 			$this->twig->loadTemplate( $value );
-		}
-		catch ( \Twig_Error_Loader $e ) {
+		} catch ( \Twig_Error_Loader $e ) {
 			return new ValidationResult( new ConstraintViolation( $value, 'Could not find template' ) );
 		}
 

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WMDE\Fundraising\Frontend\Validation;
 

cli/ApplicationConfigValidation/ConfigValidationException.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WMDE\Fundraising\Frontend\Cli\ApplicationConfigValidation;
 

app/RouteHandlers/PageDisplayHandler.php

Braces +2 added lines, -4 removed lines

@@ -31,15 +31,13 @@
 
 		try {
 			$pageId = $pageSelector->getPageId( $pageName );
-		}
-		catch ( PageNotFoundException $exception ) {
+		} catch ( PageNotFoundException $exception ) {
 			throw new NotFoundHttpException( "Page page name '$pageName' not found." );
 		}
 
 		try {
 			return $this->getPageTemplate( $pageId )->render( [ 'page_id' => $pageId ] );
-		}
-		catch ( \Twig_Error_Runtime $exception ) {
+		} catch ( \Twig_Error_Runtime $exception ) {
 			if ( $exception->getPrevious() instanceof ContentNotFoundException ) {
 				throw new NotFoundHttpException( "Content for page id '$pageId' not found." );
 			}

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WMDE\Fundraising\Frontend\App\RouteHandlers;
 
@@ -37,7 +37,7 @@ 
 		}
 
 		try {
-			return $this->getPageTemplate( $pageId )->render( [ 'page_id' => $pageId ] );
+			return $this->getPageTemplate( $pageId )->render( ['page_id' => $pageId] );
 		}
 		catch ( \Twig_Error_Runtime $exception ) {
 			if ( $exception->getPrevious() instanceof ContentNotFoundException ) {

src/Factories/TwigFactory.php

Braces +1 added lines, -2 removed lines

@@ -44,8 +44,7 @@
 		$appRoot = realpath( __DIR__ . '/../..' ) . '/';
 		if ( is_string( $config['template-dir'] ) ) {
 			return $this->convertToAbsolute( $appRoot, $templateDir = [ $config['template-dir'] ] );
-		}
-		elseif ( is_array( $config['template-dir'] ) ) {
+		} elseif ( is_array( $config['template-dir'] ) ) {
 			return $this->convertToAbsolute( $appRoot, $templateDir = $config['template-dir'] );
 		}
 

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WMDE\Fundraising\Frontend\Factories;
 
@@ -43,7 +43,7 @@ 
 	private function getTemplateDir( array $config ): array {
 		$appRoot = realpath( __DIR__ . '/../..' ) . '/';
 		if ( is_string( $config['template-dir'] ) ) {
-			return $this->convertToAbsolute( $appRoot, $templateDir = [ $config['template-dir'] ] );
+			return $this->convertToAbsolute( $appRoot, $templateDir = [$config['template-dir']] );
 		}
 		elseif ( is_array( $config['template-dir'] ) ) {
 			return $this->convertToAbsolute( $appRoot, $templateDir = $config['template-dir'] );
@@ -78,7 +78,7 @@ 
 	}
 
 	public function newFilePrefixFilter( FilePrefixer $filePrefixer ): Twig_SimpleFilter {
-		return new Twig_SimpleFilter( 'prefix_file', [ $filePrefixer, 'prefixFile' ] );
+		return new Twig_SimpleFilter( 'prefix_file', [$filePrefixer, 'prefixFile'] );
 	}
 
 	public function newTwigEnvironmentConfigurator(): TwigEnvironmentConfigurator {

src/Factories/UnknownChoiceDefinition.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WMDE\Fundraising\Frontend\Factories;
 

src/Presentation/ContentPage/PageNotFoundException.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WMDE\Fundraising\Frontend\Presentation\ContentPage;
 

src/BucketTesting/Validation/LoggingCampaignConfigurationLoader.php

Braces +5 added lines, -10 removed lines

@@ -22,20 +22,15 @@
 	public function loadCampaignConfiguration( string ...$configFiles ): array {
 		try {
 			return $this->actualCampaignConfigurationLoader->loadCampaignConfiguration( ...$configFiles );
-		}
-		catch ( ParseException $e ) {
+		} catch ( ParseException $e ) {
 			$this->errorLogger->addError( 'Failed to parse campaign YAML: ' . $e->getMessage() );
-		}
-		catch ( FileFetchingException $e ) {
+		} catch ( FileFetchingException $e ) {
 			$this->errorLogger->addError( 'YAML configuration file read error: ' . $e->getMessage() );
-		}
-		catch ( InvalidConfigurationException $e ) {
+		} catch ( InvalidConfigurationException $e ) {
 			$this->errorLogger->addError( 'Invalid campaign YAML configuration: ' . $e->getMessage() );
-		}
-		catch ( \RuntimeException $e ) {
+		} catch ( \RuntimeException $e ) {
 			$this->errorLogger->addError( 'Runtime error while parsing campaign YAML: ' . $e->getMessage() );
-		}
-		catch ( \Throwable $e ) {
+		} catch ( \Throwable $e ) {
 			$this->errorLogger->addError( get_class( $e ) . ': ' . $e->getMessage() );
 		}
 		return [];

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WMDE\Fundraising\Frontend\BucketTesting\Validation;