wmde / FundraisingFrontend

src/Factories/FunFunFactory.php

Spacing +179 added lines, -179 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\Factories;
 
@@ -179,7 +179,7 @@ 
 	 */
 	private $profiler = null;
 
-	public function __construct( array $config ) {
+	public function __construct(array $config) {
 		$this->config = $config;
 		$this->pimple = $this->newPimple();
 	}
@@ -200,15 +200,15 @@ 
 		};
 
 		$pimple['dbal_connection'] = function() {
-			return DriverManager::getConnection( $this->config['db'] );
+			return DriverManager::getConnection($this->config['db']);
 		};
 
 		$pimple['entity_manager'] = function() {
-			$entityManager = ( new StoreFactory( $this->getConnection(), $this->getVarPath() . '/doctrine_proxies' ) )
+			$entityManager = (new StoreFactory($this->getConnection(), $this->getVarPath() . '/doctrine_proxies'))
 				->getEntityManager();
-			if ( $this->addDoctrineSubscribers ) {
-				$entityManager->getEventManager()->addEventSubscriber( $this->newDoctrineDonationPrePersistSubscriber() );
-				$entityManager->getEventManager()->addEventSubscriber( $this->newDoctrineMembershipApplicationPrePersistSubscriber() );
+			if ($this->addDoctrineSubscribers) {
+				$entityManager->getEventManager()->addEventSubscriber($this->newDoctrineDonationPrePersistSubscriber());
+				$entityManager->getEventManager()->addEventSubscriber($this->newDoctrineMembershipApplicationPrePersistSubscriber());
 			}
 
 			return $entityManager;
@@ -216,53 +216,53 @@ 
 
 		$pimple['subscription_repository'] = function() {
 			return new LoggingSubscriptionRepository(
-				new DoctrineSubscriptionRepository( $this->getEntityManager() ),
+				new DoctrineSubscriptionRepository($this->getEntityManager()),
 				$this->getLogger()
 			);
 		};
 
 		$pimple['donation_repository'] = function() {
 			return new LoggingDonationRepository(
-				new DoctrineDonationRepository( $this->getEntityManager() ),
+				new DoctrineDonationRepository($this->getEntityManager()),
 				$this->getLogger()
 			);
 		};
 
 		$pimple['membership_application_repository'] = function() {
 			return new LoggingApplicationRepository(
-				new DoctrineApplicationRepository( $this->getEntityManager() ),
+				new DoctrineApplicationRepository($this->getEntityManager()),
 				$this->getLogger()
 			);
 		};
 
 		$pimple['comment_repository'] = function() {
 			$finder = new LoggingCommentFinder(
-				new DoctrineCommentFinder( $this->getEntityManager() ),
+				new DoctrineCommentFinder($this->getEntityManager()),
 				$this->getLogger()
 			);
 
-			return $this->addProfilingDecorator( $finder, 'CommentFinder' );
+			return $this->addProfilingDecorator($finder, 'CommentFinder');
 		};
 
 		$pimple['mail_validator'] = function() {
-			return new EmailValidator( new InternetDomainNameValidator() );
+			return new EmailValidator(new InternetDomainNameValidator());
 		};
 
 		$pimple['subscription_validator'] = function() {
 			return new SubscriptionValidator(
 				$this->getEmailValidator(),
-				$this->newTextPolicyValidator( 'fields' ),
+				$this->newTextPolicyValidator('fields'),
 				$this->newSubscriptionDuplicateValidator(),
 				$this->newHonorificValidator()
 			);
 		};
 
 		$pimple['template_name_validator'] = function() {
-			return new TemplateNameValidator( $this->getTwig() );
+			return new TemplateNameValidator($this->getTwig());
 		};
 
 		$pimple['contact_validator'] = function() {
-			return new GetInTouchValidator( $this->getEmailValidator() );
+			return new GetInTouchValidator($this->getEmailValidator());
 		};
 
 		$pimple['greeting_generator'] = function() {
@@ -276,9 +276,9 @@ 
 			];
 			$locale = $this->config['locale'];
 			$messagesPath = $this->getI18nDirectory() . $this->config['translation']['message-dir'];
-			$translator = $translationFactory->create( $loaders, $locale );
+			$translator = $translationFactory->create($loaders, $locale);
 			foreach ($this->config['translation']['files'] as $domain => $file) {
-				$translator->addResource( 'json', $messagesPath . '/' . $file, $locale, $domain );
+				$translator->addResource('json', $messagesPath . '/' . $file, $locale, $domain);
 			}
 
 			return $translator;
@@ -286,15 +286,15 @@ 
 
 		// In the future, this could be locale-specific or filled from a DB table
 		$pimple['honorifics'] = function() {
-			return new Honorifics( [
+			return new Honorifics([
 				'' => 'Kein Titel',
 				'Dr.' => 'Dr.',
 				'Prof.' => 'Prof.',
 				'Prof. Dr.' => 'Prof. Dr.'
-			] );
+			]);
 		};
 
-		$pimple['twig_factory'] = function () {
+		$pimple['twig_factory'] = function() {
 			return new TwigFactory(
 				array_merge_recursive(
 					$this->config['twig'],
@@ -309,12 +309,12 @@ 
 			$twigFactory = $this->getTwigFactory();
 			$configurator = $twigFactory->newTwigEnvironmentConfigurator();
 
-			$loaders = array_filter( [
+			$loaders = array_filter([
 				$twigFactory->newFileSystemLoader(),
 				$twigFactory->newArrayLoader(), // This is just a fallback for testing
-			] );
+			]);
 			$extensions = [
-				$twigFactory->newTranslationExtension( $this->getTranslator() ),
+				$twigFactory->newTranslationExtension($this->getTranslator()),
 				new Twig_Extensions_Extension_Intl()
 			];
 			$filters = [
@@ -325,21 +325,21 @@ 
 			$functions = [
 				new Twig_SimpleFunction(
 					'web_content',
-					function( string $name, array $context = [] ) {
-						return $this->getContentProvider()->getWeb( $name, $context );
+					function(string $name, array $context = []) {
+						return $this->getContentProvider()->getWeb($name, $context);
 					},
-					[ 'is_safe' => [ 'html' ] ]
+					['is_safe' => ['html']]
 				),
 				new Twig_SimpleFunction(
 					'mail_content',
-					function( string $name, array $context = [] ) {
-						return $this->getContentProvider()->getMail( $name, $context );
+					function(string $name, array $context = []) {
+						return $this->getContentProvider()->getMail($name, $context);
 					},
-					[ 'is_safe' => [ 'all' ] ]
+					['is_safe' => ['all']]
 				)
 			];
 
-			return $configurator->getEnvironment( $this->pimple['twig_environment'], $loaders, $extensions, $filters, $functions );
+			return $configurator->getEnvironment($this->pimple['twig_environment'], $loaders, $extensions, $filters, $functions);
 		};
 
 		$pimple['messenger_suborganization'] = function() {
@@ -359,7 +359,7 @@ 
 		};
 
 		$pimple['confirmation-page-selector'] = function() {
-			return new DonationConfirmationPageSelector( $this->config['confirmation-pages'] );
+			return new DonationConfirmationPageSelector($this->config['confirmation-pages']);
 		};
 
 		$pimple['paypal-payment-notification-verifier'] = function() {
@@ -398,7 +398,7 @@ 
 		$pimple['token_generator'] = function() {
 			return new RandomTokenGenerator(
 				$this->config['token-length'],
-				new \DateInterval( $this->config['token-validity-timestamp'] )
+				new \DateInterval($this->config['token-validity-timestamp'])
 			);
 		};
 
@@ -410,38 +410,38 @@ 
 			return new VoidCache();
 		};
 
-		$pimple['page_view_tracker'] = function () {
-			return new PageViewTracker( $this->newServerSideTracker(), $this->config['piwik']['siteUrlBase'] );
+		$pimple['page_view_tracker'] = function() {
+			return new PageViewTracker($this->newServerSideTracker(), $this->config['piwik']['siteUrlBase']);
 		};
 
-		$pimple['cachebusting_fileprefixer'] = function () {
-			return new FilePrefixer( $this->getFilePrefix() );
+		$pimple['cachebusting_fileprefixer'] = function() {
+			return new FilePrefixer($this->getFilePrefix());
 		};
 
-		$pimple['content_page_selector'] = function () {
-			$json = (new SimpleFileFetcher())->fetchFile( $this->getI18nDirectory() . '/data/pages.json' );
-			$config = json_decode( $json, true ) ?? [];
+		$pimple['content_page_selector'] = function() {
+			$json = (new SimpleFileFetcher())->fetchFile($this->getI18nDirectory() . '/data/pages.json');
+			$config = json_decode($json, true) ?? [];
 
-			return new PageSelector( $config );
+			return new PageSelector($config);
 		};
 
-		$pimple['content_provider'] = function () {
-			return new ContentProvider( [
+		$pimple['content_provider'] = function() {
+			return new ContentProvider([
 				'content_path' => $this->getI18nDirectory(),
 				'cache' => $this->config['twig']['enable-cache'] ? $this->getCachePath() . '/content' : false,
 				'globals' => [
 					'basepath' => $this->config['web-basepath']
 				]
-			] );
+			]);
 		};
 
 		$pimple['payment-delay-calculator'] = function() {
-			return new DefaultPaymentDelayCalculator( $this->getPayPalUrlConfigForMembershipApplications()->getDelayInDays() );
+			return new DefaultPaymentDelayCalculator($this->getPayPalUrlConfigForMembershipApplications()->getDelayInDays());
 		};
 
-		$pimple['sofort-client'] = function () {
+		$pimple['sofort-client'] = function() {
 			$config = $this->config['sofort'];
-			return new SofortClient( $config['config-key'] );
+			return new SofortClient($config['config-key']);
 		};
 
 		return $pimple;
@@ -457,17 +457,17 @@ 
 
 	private function newDonationEventLogger(): DonationEventLogger {
 		return new BestEffortDonationEventLogger(
-			new DoctrineDonationEventLogger( $this->getEntityManager() ),
+			new DoctrineDonationEventLogger($this->getEntityManager()),
 			$this->getLogger()
 		);
 	}
 
 	public function newInstaller(): Installer {
-		return ( new StoreFactory( $this->getConnection() ) )->newInstaller();
+		return (new StoreFactory($this->getConnection()))->newInstaller();
 	}
 
 	public function newListCommentsUseCase(): ListCommentsUseCase {
-		return new ListCommentsUseCase( $this->getCommentFinder() );
+		return new ListCommentsUseCase($this->getCommentFinder());
 	}
 
 	public function newCommentListJsonPresenter(): CommentListJsonPresenter {
@@ -475,14 +475,14 @@ 
 	}
 
 	public function newCommentListRssPresenter(): CommentListRssPresenter {
-		return new CommentListRssPresenter( new TwigTemplate(
+		return new CommentListRssPresenter(new TwigTemplate(
 			$this->getTwig(),
 			'Comment_List.rss.twig'
-		) );
+		));
 	}
 
 	public function newCommentListHtmlPresenter(): CommentListHtmlPresenter {
-		return new CommentListHtmlPresenter( $this->getLayoutTemplate( 'Comment_List.html.twig', [ 'piwikGoals' => [ 1 ] ] ) );
+		return new CommentListHtmlPresenter($this->getLayoutTemplate('Comment_List.html.twig', ['piwikGoals' => [1]]));
 	}
 
 	private function getCommentFinder(): CommentFinder {
@@ -493,7 +493,7 @@ 
 		return $this->pimple['subscription_repository'];
 	}
 
-	public function setSubscriptionRepository( SubscriptionRepository $subscriptionRepository ) {
+	public function setSubscriptionRepository(SubscriptionRepository $subscriptionRepository) {
 		$this->pimple['subscription_repository'] = $subscriptionRepository;
 	}
 
@@ -510,25 +510,25 @@ 
 	}
 
 	public function newAddSubscriptionHtmlPresenter(): AddSubscriptionHtmlPresenter {
-		return new AddSubscriptionHtmlPresenter( $this->getLayoutTemplate( 'Subscription_Form.html.twig' ), $this->getTranslator() );
+		return new AddSubscriptionHtmlPresenter($this->getLayoutTemplate('Subscription_Form.html.twig'), $this->getTranslator());
 	}
 
 	public function newConfirmSubscriptionHtmlPresenter(): ConfirmSubscriptionHtmlPresenter {
 		return new ConfirmSubscriptionHtmlPresenter(
-			$this->getLayoutTemplate( 'Confirm_Subscription.twig' ),
+			$this->getLayoutTemplate('Confirm_Subscription.twig'),
 			$this->getTranslator()
 		);
 	}
 
 	public function newAddSubscriptionJsonPresenter(): AddSubscriptionJsonPresenter {
-		return new AddSubscriptionJsonPresenter( $this->getTranslator() );
+		return new AddSubscriptionJsonPresenter($this->getTranslator());
 	}
 
 	public function newGetInTouchHtmlPresenter(): GetInTouchHtmlPresenter {
-		return new GetInTouchHtmlPresenter( $this->getLayoutTemplate( 'contact_form.html.twig' ), $this->getTranslator() );
+		return new GetInTouchHtmlPresenter($this->getLayoutTemplate('contact_form.html.twig'), $this->getTranslator());
 	}
 
-	public function setTwigEnvironment( Twig_Environment $twig ) {
+	public function setTwigEnvironment(Twig_Environment $twig) {
 		$this->pimple['twig_environment'] = $twig;
 	}
 
@@ -543,11 +543,11 @@ 
 	 * @param array $context Additional variables for the template
 	 * @return TwigTemplate
 	 */
-	public function getLayoutTemplate( string $templateName, array $context = [] ): TwigTemplate {
+	public function getLayoutTemplate(string $templateName, array $context = []): TwigTemplate {
 		 return new TwigTemplate(
 			$this->getTwig(),
 			$templateName,
-			array_merge( $this->getDefaultTwigVariables(), $context )
+			array_merge($this->getDefaultTwigVariables(), $context)
 		);
 	}
 
@@ -559,13 +559,13 @@ 
 	 * @param string $templateName Template to include
 	 * @return TwigTemplate
 	 */
-	private function getIncludeTemplate( string $templateName, array $context = [] ): TwigTemplate {
+	private function getIncludeTemplate(string $templateName, array $context = []): TwigTemplate {
 		return new TwigTemplate(
 			$this->getTwig(),
 			'Include_in_Layout.twig',
 			array_merge(
 				$this->getDefaultTwigVariables(),
-				[ 'main_template' => $templateName ],
+				['main_template' => $templateName],
 				$context
 			)
 		);
@@ -648,7 +648,7 @@ 
 			new TwigTemplate(
 					$this->getTwig(),
 					'Mail_Subscription_Confirmation.txt.twig',
-					[ 'greeting_generator' => $this->getGreetingGenerator() ]
+					['greeting_generator' => $this->getGreetingGenerator()]
 			),
 			'mail_subject_subscription_confirmed'
 		);
@@ -660,16 +660,16 @@ 
 	 * So much decoration going on that explicitly hinting what we return (Robustness principle) would be confusing
 	 * (you'd expect a TemplateBasedMailer, not a LoggingMailer), so we hint the interface instead.
 	 */
-	private function newTemplateMailer( Messenger $messenger, TwigTemplate $template, string $messageKey ): TemplateMailerInterface {
+	private function newTemplateMailer(Messenger $messenger, TwigTemplate $template, string $messageKey): TemplateMailerInterface {
 		$mailer = new TemplateBasedMailer(
 			$messenger,
 			$template,
-			$this->getTranslator()->trans( $messageKey )
+			$this->getTranslator()->trans($messageKey)
 		);
 
-		$mailer = new LoggingMailer( $mailer, $this->getLogger() );
+		$mailer = new LoggingMailer($mailer, $this->getLogger());
 
-		return $this->addProfilingDecorator( $mailer, 'Mailer' );
+		return $this->addProfilingDecorator($mailer, 'Mailer');
 	}
 
 	public function getGreetingGenerator() {
@@ -677,11 +677,11 @@ 
 	}
 
 	public function newCheckIbanUseCase(): CheckIbanUseCase {
-		return new CheckIbanUseCase( $this->newBankDataConverter(), $this->newIbanValidator() );
+		return new CheckIbanUseCase($this->newBankDataConverter(), $this->newIbanValidator());
 	}
 
 	public function newGenerateIbanUseCase(): GenerateIbanUseCase {
-		return new GenerateIbanUseCase( $this->newBankDataConverter(), $this->newIbanValidator() );
+		return new GenerateIbanUseCase($this->newBankDataConverter(), $this->newIbanValidator());
 	}
 
 	public function newIbanPresenter(): IbanPresenter {
@@ -689,10 +689,10 @@ 
 	}
 
 	public function newBankDataConverter() {
-		return new BankDataConverter( $this->config['bank-data-file'] );
+		return new BankDataConverter($this->config['bank-data-file']);
 	}
 
-	public function setSubscriptionValidator( SubscriptionValidator $subscriptionValidator ) {
+	public function setSubscriptionValidator(SubscriptionValidator $subscriptionValidator) {
 		$this->pimple['subscription_validator'] = $subscriptionValidator;
 	}
 
@@ -707,7 +707,7 @@ 
 	private function newContactUserMailer(): TemplateMailerInterface {
 		return $this->newTemplateMailer(
 			$this->getSuborganizationMessenger(),
-			new TwigTemplate( $this->getTwig(), 'Mail_Contact_Confirm_to_User.txt.twig' ),
+			new TwigTemplate($this->getTwig(), 'Mail_Contact_Confirm_to_User.txt.twig'),
 			'mail_subject_getintouch'
 		);
 	}
@@ -715,8 +715,8 @@ 
 	private function newContactOperatorMailer(): OperatorMailer {
 		return new OperatorMailer(
 			$this->getSuborganizationMessenger(),
-			new TwigTemplate( $this->getTwig(), 'Mail_Contact_Forward_to_Operator.txt.twig' ),
-			$this->getTranslator()->trans( 'mail_subject_getintouch_forward' )
+			new TwigTemplate($this->getTwig(), 'Mail_Contact_Forward_to_Operator.txt.twig'),
+			$this->getTranslator()->trans('mail_subject_getintouch_forward')
 		);
 	}
 
@@ -733,12 +733,12 @@ 
 
 	private function newSubscriptionDuplicateCutoffDate(): \DateTime {
 		$cutoffDateTime = new \DateTime();
-		$cutoffDateTime->sub( new \DateInterval( $this->config['subscription-interval'] ) );
+		$cutoffDateTime->sub(new \DateInterval($this->config['subscription-interval']));
 		return $cutoffDateTime;
 	}
 
 	private function newHonorificValidator(): AllowedValuesValidator {
-		return new AllowedValuesValidator( $this->getHonorifics()->getKeys() );
+		return new AllowedValuesValidator($this->getHonorifics()->getKeys());
 	}
 
 	private function getHonorifics(): Honorifics {
@@ -747,20 +747,20 @@ 
 
 	public function newAuthorizedCachePurger(): AuthorizedCachePurger {
 		return new AuthorizedCachePurger(
-			new AllOfTheCachePurger( $this->getTwig(), $this->getPageCache(), $this->getRenderedPageCache() ),
+			new AllOfTheCachePurger($this->getTwig(), $this->getPageCache(), $this->getRenderedPageCache()),
 			$this->config['purging-secret']
 		);
 	}
 
 	private function newBankDataValidator(): BankDataValidator {
-		return new BankDataValidator( $this->newIbanValidator() );
+		return new BankDataValidator($this->newIbanValidator());
 	}
 
 	private function getSuborganizationMessenger(): Messenger {
 		return $this->pimple['messenger_suborganization'];
 	}
 
-	public function setSuborganizationMessenger( Messenger $messenger ) {
+	public function setSuborganizationMessenger(Messenger $messenger) {
 		$this->pimple['messenger_suborganization'] = $messenger;
 	}
 
@@ -768,42 +768,42 @@ 
 		return $this->pimple['messenger_organization'];
 	}
 
-	public function setOrganizationMessenger( Messenger $messenger ) {
+	public function setOrganizationMessenger(Messenger $messenger) {
 		$this->pimple['messenger_organization'] = $messenger;
 	}
 
 	public function setNullMessenger() {
-		$this->setSuborganizationMessenger( new Messenger(
+		$this->setSuborganizationMessenger(new Messenger(
 			Swift_NullTransport::newInstance(),
 			$this->getSubOrganizationEmailAddress()
-		) );
-		$this->setOrganizationMessenger( new Messenger(
+		));
+		$this->setOrganizationMessenger(new Messenger(
 			Swift_NullTransport::newInstance(),
 			$this->getOrganizationEmailAddress()
-		) );
+		));
 	}
 
 	public function getSubOrganizationEmailAddress(): EmailAddress {
-		return new EmailAddress( $this->config['contact-info']['suborganization']['email'] );
+		return new EmailAddress($this->config['contact-info']['suborganization']['email']);
 	}
 
 	public function getOrganizationEmailAddress() {
-		return new EmailAddress( $this->config['contact-info']['organization']['email'] );
+		return new EmailAddress($this->config['contact-info']['organization']['email']);
 	}
 
 	public function newInternalErrorHtmlPresenter(): InternalErrorHtmlPresenter {
-		return new InternalErrorHtmlPresenter( $this->getIncludeTemplate( 'Error_Page.html.twig' ) );
+		return new InternalErrorHtmlPresenter($this->getIncludeTemplate('Error_Page.html.twig'));
 	}
 
 	public function newAccessDeniedHtmlPresenter(): InternalErrorHtmlPresenter {
-		return new InternalErrorHtmlPresenter( $this->getLayoutTemplate( 'Access_Denied.twig' ) );
+		return new InternalErrorHtmlPresenter($this->getLayoutTemplate('Access_Denied.twig'));
 	}
 
 	public function getTranslator(): TranslatorInterface {
 		return $this->pimple['translator'];
 	}
 
-	public function setTranslator( TranslatorInterface $translator ) {
+	public function setTranslator(TranslatorInterface $translator) {
 		$this->pimple['translator'] = $translator;
 	}
 
@@ -811,7 +811,7 @@ 
 		return $this->pimple['twig_factory'];
 	}
 
-	private function newTextPolicyValidator( string $policyName ): TextPolicyValidator {
+	private function newTextPolicyValidator(string $policyName): TextPolicyValidator {
 		$fetcher = new ErrorLoggingFileFetcher(
 			new SimpleFileFetcher(),
 			$this->getLogger()
@@ -820,24 +820,24 @@ 
 		return new TextPolicyValidator(
 			new WordListFileReader(
 				$fetcher,
-				$textPolicyConfig['badwords'] ? $this->getAbsolutePath( $textPolicyConfig['badwords'] ) : ''
+				$textPolicyConfig['badwords'] ? $this->getAbsolutePath($textPolicyConfig['badwords']) : ''
 			),
 			new WordListFileReader(
 				$fetcher,
-				$textPolicyConfig['whitewords'] ? $this->getAbsolutePath( $textPolicyConfig['whitewords'] ) : ''
+				$textPolicyConfig['whitewords'] ? $this->getAbsolutePath($textPolicyConfig['whitewords']) : ''
 			)
 		);
 	}
 
 	private function newCommentPolicyValidator(): TextPolicyValidator {
-		return $this->newTextPolicyValidator( 'comment' );
+		return $this->newTextPolicyValidator('comment');
 	}
 
-	public function newCancelDonationUseCase( string $updateToken ): CancelDonationUseCase {
+	public function newCancelDonationUseCase(string $updateToken): CancelDonationUseCase {
 		return new CancelDonationUseCase(
 			$this->getDonationRepository(),
 			$this->newCancelDonationMailer(),
-			$this->newDonationAuthorizer( $updateToken ),
+			$this->newDonationAuthorizer($updateToken),
 			$this->newDonationEventLogger()
 		);
 	}
@@ -848,7 +848,7 @@ 
 			new TwigTemplate(
 				$this->getTwig(),
 				'Mail_Donation_Cancellation_Confirmation.txt.twig',
-				[ 'greeting_generator' => $this->getGreetingGenerator() ]
+				['greeting_generator' => $this->getGreetingGenerator()]
 			),
 			'mail_subject_confirm_cancellation'
 		);
@@ -906,19 +906,19 @@ 
 	}
 
 	public function newPayPalUrlGeneratorForDonations() {
-		return new PayPalUrlGenerator( $this->getPayPalUrlConfigForDonations() );
+		return new PayPalUrlGenerator($this->getPayPalUrlConfigForDonations());
 	}
 
 	public function newPayPalUrlGeneratorForMembershipApplications() {
-		return new PayPalUrlGenerator( $this->getPayPalUrlConfigForMembershipApplications() );
+		return new PayPalUrlGenerator($this->getPayPalUrlConfigForMembershipApplications());
 	}
 
 	private function getPayPalUrlConfigForDonations() {
-		return PayPalConfig::newFromConfig( $this->config['paypal-donation'] );
+		return PayPalConfig::newFromConfig($this->config['paypal-donation']);
 	}
 
 	private function getPayPalUrlConfigForMembershipApplications() {
-		return PayPalConfig::newFromConfig( $this->config['paypal-membership'] );
+		return PayPalConfig::newFromConfig($this->config['paypal-membership']);
 	}
 
 	public function newSofortUrlGeneratorForDonations(): SofortUrlGenerator {
@@ -926,7 +926,7 @@ 
 
 		return new SofortUrlGenerator(
 			new SofortConfig(
-				$this->getTranslator()->trans( 'item_name_donation', [], 'messages' ),
+				$this->getTranslator()->trans('item_name_donation', [], 'messages'),
 				$config['return-url'],
 				$config['cancel-url']
 			),
@@ -934,7 +934,7 @@ 
 		);
 	}
 
-	public function setSofortClient( SofortClient $client ): void {
+	public function setSofortClient(SofortClient $client): void {
 		$this->pimple['sofort-client'] = $client;
 	}
 
@@ -943,11 +943,11 @@ 
 	}
 
 	private function newCreditCardUrlGenerator(): CreditCardUrlGenerator {
-		return new CreditCardUrlGenerator( $this->newCreditCardUrlConfig() );
+		return new CreditCardUrlGenerator($this->newCreditCardUrlConfig());
 	}
 
 	private function newCreditCardUrlConfig(): CreditCardConfig {
-		return CreditCardConfig::newFromConfig( $this->config['creditcard'] );
+		return CreditCardConfig::newFromConfig($this->config['creditcard']);
 	}
 
 	public function getDonationRepository(): DonationRepository {
@@ -963,23 +963,23 @@ 
 	}
 
 	private function newAmountFormatter(): AmountFormatter {
-		return new AmountFormatter( $this->config['locale'] );
+		return new AmountFormatter($this->config['locale']);
 	}
 
 	public function newDecimalNumberFormatter(): NumberFormatter {
-		return new NumberFormatter( $this->config['locale'], NumberFormatter::DECIMAL );
+		return new NumberFormatter($this->config['locale'], NumberFormatter::DECIMAL);
 	}
 
-	public function newAddCommentUseCase( string $updateToken ): AddCommentUseCase {
+	public function newAddCommentUseCase(string $updateToken): AddCommentUseCase {
 		return new AddCommentUseCase(
 			$this->getDonationRepository(),
-			$this->newDonationAuthorizer( $updateToken ),
+			$this->newDonationAuthorizer($updateToken),
 			$this->newCommentPolicyValidator(),
 			$this->newAddCommentValidator()
 		);
 	}
 
-	private function newDonationAuthorizer( string $updateToken = null, string $accessToken = null ): DonationAuthorizer {
+	private function newDonationAuthorizer(string $updateToken = null, string $accessToken = null): DonationAuthorizer {
 		return new DoctrineDonationAuthorizer(
 			$this->getEntityManager(),
 			$updateToken,
@@ -993,13 +993,13 @@ 
 
 	public function newDonationConfirmationPresenter() {
 		return new DonationConfirmationHtmlPresenter(
-			$this->getIncludeTemplate( 'Donation_Confirmation.html.twig', [ 'piwikGoals' => [ 3 ] ] )
+			$this->getIncludeTemplate('Donation_Confirmation.html.twig', ['piwikGoals' => [3]])
 		);
 	}
 
 	public function newCreditCardPaymentHtmlPresenter() {
 		return new CreditCardPaymentHtmlPresenter(
-			$this->getIncludeTemplate( 'Credit_Card_Payment_Iframe.html.twig' ),
+			$this->getIncludeTemplate('Credit_Card_Payment_Iframe.html.twig'),
 			$this->getTranslator(),
 			$this->newCreditCardUrlGenerator()
 		);
@@ -1007,7 +1007,7 @@ 
 
 	public function newCancelDonationHtmlPresenter() {
 		return new CancelDonationHtmlPresenter(
-			$this->getIncludeTemplate( 'Donation_Cancellation_Confirmation.html.twig' )
+			$this->getIncludeTemplate('Donation_Cancellation_Confirmation.html.twig')
 		);
 	}
 
@@ -1030,7 +1030,7 @@ 
 			new TwigTemplate(
 				$this->getTwig(),
 				'Mail_Membership_Application_Confirmation.txt.twig',
-				[ 'greeting_generator' => $this->getGreetingGenerator() ]
+				['greeting_generator' => $this->getGreetingGenerator()]
 			),
 			'mail_subject_confirm_membership_application'
 		);
@@ -1045,31 +1045,31 @@ 
 	}
 
 	private function newMembershipApplicationTracker(): ApplicationTracker {
-		return new DoctrineApplicationTracker( $this->getEntityManager() );
+		return new DoctrineApplicationTracker($this->getEntityManager());
 	}
 
 	private function newMembershipApplicationPiwikTracker(): ApplicationPiwikTracker {
-		return new DoctrineApplicationPiwikTracker( $this->getEntityManager() );
+		return new DoctrineApplicationPiwikTracker($this->getEntityManager());
 	}
 
 	private function getPaymentDelayCalculator() {
 		return $this->pimple['payment-delay-calculator'];
 	}
 
-	public function setPaymentDelayCalculator( PaymentDelayCalculator $paymentDelayCalculator ) {
+	public function setPaymentDelayCalculator(PaymentDelayCalculator $paymentDelayCalculator) {
 		$this->pimple['payment-delay-calculator'] = $paymentDelayCalculator;
 	}
 
 	private function newApplyForMembershipPolicyValidator(): ApplyForMembershipPolicyValidator {
 		return new ApplyForMembershipPolicyValidator(
-			$this->newTextPolicyValidator( 'fields' ),
+			$this->newTextPolicyValidator('fields'),
 			$this->config['email-address-blacklist']
 		);
 	}
 
-	public function newCancelMembershipApplicationUseCase( string $updateToken ): CancelMembershipApplicationUseCase {
+	public function newCancelMembershipApplicationUseCase(string $updateToken): CancelMembershipApplicationUseCase {
 		return new CancelMembershipApplicationUseCase(
-			$this->newMembershipApplicationAuthorizer( $updateToken ),
+			$this->newMembershipApplicationAuthorizer($updateToken),
 			$this->getMembershipApplicationRepository(),
 			$this->newCancelMembershipApplicationMailer()
 		);
@@ -1095,28 +1095,28 @@ 
 			new TwigTemplate(
 				$this->getTwig(),
 				'Mail_Membership_Application_Cancellation_Confirmation.txt.twig',
-				[ 'greeting_generator' => $this->getGreetingGenerator() ]
+				['greeting_generator' => $this->getGreetingGenerator()]
 			),
 			'mail_subject_confirm_membership_application_cancellation'
 		);
 	}
 
-	public function newMembershipApplicationConfirmationUseCase( string $accessToken ) {
+	public function newMembershipApplicationConfirmationUseCase(string $accessToken) {
 		return new ShowMembershipApplicationConfirmationUseCase(
-			$this->newMembershipApplicationAuthorizer( null, $accessToken ), $this->getMembershipApplicationRepository(),
+			$this->newMembershipApplicationAuthorizer(null, $accessToken), $this->getMembershipApplicationRepository(),
 			$this->newMembershipApplicationTokenFetcher()
 		);
 	}
 
-	public function newShowDonationConfirmationUseCase( string $accessToken ): ShowDonationConfirmationUseCase {
+	public function newShowDonationConfirmationUseCase(string $accessToken): ShowDonationConfirmationUseCase {
 		return new ShowDonationConfirmationUseCase(
-			$this->newDonationAuthorizer( null, $accessToken ),
+			$this->newDonationAuthorizer(null, $accessToken),
 			$this->newDonationTokenFetcher(),
 			$this->getDonationRepository()
 		);
 	}
 
-	public function setDonationConfirmationPageSelector( DonationConfirmationPageSelector $selector ) {
+	public function setDonationConfirmationPageSelector(DonationConfirmationPageSelector $selector) {
 		$this->pimple['confirmation-page-selector'] = $selector;
 	}
 
@@ -1125,49 +1125,49 @@ 
 	}
 
 	public function newDonationFormViolationPresenter() {
-		return new DonationFormViolationPresenter( $this->getDonationFormTemplate(), $this->newAmountFormatter() );
+		return new DonationFormViolationPresenter($this->getDonationFormTemplate(), $this->newAmountFormatter());
 	}
 
 	public function newDonationFormPresenter() {
-		return new DonationFormPresenter( $this->getDonationFormTemplate(), $this->newAmountFormatter() );
+		return new DonationFormPresenter($this->getDonationFormTemplate(), $this->newAmountFormatter());
 	}
 
 	private function getDonationFormTemplate(): TwigTemplate {
 		// TODO make the template name dependent on the 'form' value from the HTTP POST request
 		// (we need different form pages for A/B testing)
-		return $this->getLayoutTemplate( 'Donation_Form.html.twig', [
+		return $this->getLayoutTemplate('Donation_Form.html.twig', [
 			'paymentTypes' => $this->getEnabledDonationPaymentTypes()
-		] );
+		]);
 	}
 
 	private function getEnabledDonationPaymentTypes(): array {
-		return array_keys( array_filter( $this->config['payment-types'], function ( $config ) {
-			return ( $config['donation-enabled'] === true );
-		} ) );
+		return array_keys(array_filter($this->config['payment-types'], function($config) {
+			return ($config['donation-enabled'] === true);
+		} ));
 	}
 
-	public function newHandlePayPalPaymentNotificationUseCase( string $updateToken ) {
+	public function newHandlePayPalPaymentNotificationUseCase(string $updateToken) {
 		return new HandlePayPalPaymentNotificationUseCase(
 			$this->getDonationRepository(),
-			$this->newDonationAuthorizer( $updateToken ),
+			$this->newDonationAuthorizer($updateToken),
 			$this->newDonationConfirmationMailer(),
 			$this->newDonationEventLogger()
 		);
 	}
 
-	public function newMembershipApplicationSubscriptionSignupNotificationUseCase( string $updateToken ) {
+	public function newMembershipApplicationSubscriptionSignupNotificationUseCase(string $updateToken) {
 		return new HandleSubscriptionSignupNotificationUseCase(
 			$this->getMembershipApplicationRepository(),
-			$this->newMembershipApplicationAuthorizer( $updateToken ),
+			$this->newMembershipApplicationAuthorizer($updateToken),
 			$this->newApplyForMembershipMailer(),
 			$this->getLogger()
 		);
 	}
 
-	public function newMembershipApplicationSubscriptionPaymentNotificationUseCase( string $updateToken ) {
+	public function newMembershipApplicationSubscriptionPaymentNotificationUseCase(string $updateToken) {
 		return new HandleSubscriptionPaymentNotificationUseCase(
 			$this->getMembershipApplicationRepository(),
-			$this->newMembershipApplicationAuthorizer( $updateToken ),
+			$this->newMembershipApplicationAuthorizer($updateToken),
 			$this->newApplyForMembershipMailer(),
 			$this->getLogger()
 		);
@@ -1177,7 +1177,7 @@ 
 		return $this->pimple['paypal-payment-notification-verifier'];
 	}
 
-	public function setPayPalPaymentNotificationVerifier( PaymentNotificationVerifier $verifier ) {
+	public function setPayPalPaymentNotificationVerifier(PaymentNotificationVerifier $verifier) {
 		$this->pimple['paypal-payment-notification-verifier'] = $verifier;
 	}
 
@@ -1185,14 +1185,14 @@ 
 		return $this->pimple['paypal-membership-fee-notification-verifier'];
 	}
 
-	public function setPayPalMembershipFeeNotificationVerifier( PaymentNotificationVerifier $verifier ) {
+	public function setPayPalMembershipFeeNotificationVerifier(PaymentNotificationVerifier $verifier) {
 		$this->pimple['paypal-membership-fee-notification-verifier'] = $verifier;
 	}
 
-	public function newCreditCardNotificationUseCase( string $updateToken ) {
+	public function newCreditCardNotificationUseCase(string $updateToken) {
 		return new CreditCardNotificationUseCase(
 			$this->getDonationRepository(),
-			$this->newDonationAuthorizer( $updateToken ),
+			$this->newDonationAuthorizer($updateToken),
 			$this->getCreditCardService(),
 			$this->newDonationConfirmationMailer(),
 			$this->getLogger(),
@@ -1202,23 +1202,23 @@ 
 
 	public function newCancelMembershipApplicationHtmlPresenter() {
 		return new CancelMembershipApplicationHtmlPresenter(
-			$this->getIncludeTemplate( 'Membership_Application_Cancellation_Confirmation.html.twig' )
+			$this->getIncludeTemplate('Membership_Application_Cancellation_Confirmation.html.twig')
 		);
 	}
 
 	public function newMembershipApplicationConfirmationHtmlPresenter() {
 		return new MembershipApplicationConfirmationHtmlPresenter(
-			$this->getIncludeTemplate( 'Membership_Application_Confirmation.html.twig' )
+			$this->getIncludeTemplate('Membership_Application_Confirmation.html.twig')
 		);
 	}
 
 	public function newMembershipFormViolationPresenter() {
 		return new MembershipFormViolationPresenter(
-			$this->getLayoutTemplate( 'Membership_Application.html.twig' )
+			$this->getLayoutTemplate('Membership_Application.html.twig')
 		);
 	}
 
-	public function setCreditCardService( CreditCardService $ccService ) {
+	public function setCreditCardService(CreditCardService $ccService) {
 		$this->pimple['credit-card-api-service'] = $ccService;
 	}
 
@@ -1231,7 +1231,7 @@ 
 			new TwigTemplate(
 				$this->getTwig(),
 				'Credit_Card_Payment_Notification.txt.twig',
-				[ 'returnUrl' => $this->config['creditcard']['return-url'] ]
+				['returnUrl' => $this->config['creditcard']['return-url']]
 			)
 		);
 	}
@@ -1252,7 +1252,7 @@ 
 		);
 	}
 
-	public function setTokenGenerator( TokenGenerator $tokenGenerator ) {
+	public function setTokenGenerator(TokenGenerator $tokenGenerator) {
 		$this->pimple['token_generator'] = $tokenGenerator;
 	}
 
@@ -1275,23 +1275,23 @@ 
 	private function newDonationPolicyValidator(): AddDonationPolicyValidator {
 		return new AddDonationPolicyValidator(
 			$this->newDonationAmountPolicyValidator(),
-			$this->newTextPolicyValidator( 'fields' ),
+			$this->newTextPolicyValidator('fields'),
 			$this->config['email-address-blacklist']
 		);
 	}
 
 	private function newDonationAmountPolicyValidator(): AmountPolicyValidator {
 		// in the future, this might come from the configuration
-		return new AmountPolicyValidator( 1000, 1000 );
+		return new AmountPolicyValidator(1000, 1000);
 	}
 
 	public function getDonationTimeframeLimit() {
 		return $this->config['donation-timeframe-limit'];
 	}
 
-	public function newSystemMessageResponse( string $message ) {
-		$test = $this->getIncludeTemplate( 'System_Message.html.twig' );
-		return $test->render( [ 'message' => $message ] );
+	public function newSystemMessageResponse(string $message) {
+		$test = $this->getIncludeTemplate('System_Message.html.twig');
+		return $test->render(['message' => $message]);
 	}
 
 	public function getMembershipApplicationTimeframeLimit() {
@@ -1312,37 +1312,37 @@ 
 
 	public function enablePageCache() {
 		$this->pimple['page_cache'] = function() {
-			return new FilesystemCache( $this->getCachePath() . '/pages/raw' );
+			return new FilesystemCache($this->getCachePath() . '/pages/raw');
 		};
 
 		$this->pimple['rendered_page_cache'] = function() {
-			return new FilesystemCache( $this->getCachePath() . '/pages/rendered' );
+			return new FilesystemCache($this->getCachePath() . '/pages/rendered');
 		};
 	}
 
-	private function addProfilingDecorator( $objectToDecorate, string $profilingLabel ) {
-		if ( $this->profiler === null ) {
+	private function addProfilingDecorator($objectToDecorate, string $profilingLabel) {
+		if ($this->profiler === null) {
 			return $objectToDecorate;
 		}
 
-		$builder = new ProfilingDecoratorBuilder( $this->profiler, $this->getProfilerDataCollector() );
+		$builder = new ProfilingDecoratorBuilder($this->profiler, $this->getProfilerDataCollector());
 
-		return $builder->decorate( $objectToDecorate, $profilingLabel );
+		return $builder->decorate($objectToDecorate, $profilingLabel);
 	}
 
-	public function setProfiler( Stopwatch $profiler ) {
+	public function setProfiler(Stopwatch $profiler) {
 		$this->profiler = $profiler;
 	}
 
-	public function setEmailValidator( EmailValidator $validator ) {
+	public function setEmailValidator(EmailValidator $validator) {
 		$this->pimple['mail_validator'] = $validator;
 	}
 
-	public function setLogger( LoggerInterface $logger ) {
+	public function setLogger(LoggerInterface $logger) {
 		$this->pimple['logger'] = $logger;
 	}
 
-	public function setPaypalLogger( LoggerInterface $logger ) {
+	public function setPaypalLogger(LoggerInterface $logger) {
 		$this->pimple['paypal_logger'] = $logger;
 	}
 
@@ -1351,10 +1351,10 @@ 
 	}
 
 	private function newIbanValidator(): IbanValidator {
-		return new IbanValidator( $this->newBankDataConverter(), $this->config['banned-ibans'] );
+		return new IbanValidator($this->newBankDataConverter(), $this->config['banned-ibans']);
 	}
 
-	public function setFilePrefixer( FilePrefixer $prefixer ): void {
+	public function setFilePrefixer(FilePrefixer $prefixer): void {
 		$this->pimple['cachebusting_fileprefixer'] = $prefixer;
 	}
 
@@ -1364,26 +1364,26 @@ 
 
 	private function getFilePrefix(): string {
 		$prefixContentFile = $this->getVarPath() . '/file_prefix.txt';
-		if ( !file_exists( $prefixContentFile ) ) {
+		if (!file_exists($prefixContentFile)) {
 			return '';
 		}
-		return $prefix = preg_replace( '/[^0-9a-f]/', '', file_get_contents( $prefixContentFile ) );
+		return $prefix = preg_replace('/[^0-9a-f]/', '', file_get_contents($prefixContentFile));
 	}
 
-	public function newDonationAcceptedEventHandler( string $updateToken ): DonationAcceptedEventHandler {
+	public function newDonationAcceptedEventHandler(string $updateToken): DonationAcceptedEventHandler {
 		return new DonationAcceptedEventHandler(
-			$this->newDonationAuthorizer( $updateToken ),
+			$this->newDonationAuthorizer($updateToken),
 			$this->getDonationRepository(),
 			$this->newDonationConfirmationMailer()
 		);
 	}
 
 	public function newPageNotFoundHtmlPresenter(): PageNotFoundPresenter {
-		return new PageNotFoundPresenter( $this->getLayoutTemplate( 'Page_not_found.html.twig' ) );
+		return new PageNotFoundPresenter($this->getLayoutTemplate('Page_not_found.html.twig'));
 	}
 
-	public function setPageViewTracker( PageViewTracker $tracker ) {
-		$this->pimple['page_view_tracker'] = function () use ( $tracker )  {
+	public function setPageViewTracker(PageViewTracker $tracker) {
+		$this->pimple['page_view_tracker'] = function() use ($tracker)  {
 			return $tracker;
 		};
 	}
@@ -1396,25 +1396,25 @@ 
 		// the "https:" prefix does NOT get any slashes because baseURL is stored in a protocol-agnostic way
 		// (e.g. "//tracking.wikimedia.de" )
 		return new PiwikServerSideTracker(
-			new \PiwikTracker( $this->config['piwik']['siteId'], 'https:' . $this->config['piwik']['baseUrl'] )
+			new \PiwikTracker($this->config['piwik']['siteId'], 'https:' . $this->config['piwik']['baseUrl'])
 		);
 	}
 
 	public function getI18nDirectory(): string {
-		return $this->getAbsolutePath( $this->config['i18n-base-path'] ) . '/' . $this->config['locale'];
+		return $this->getAbsolutePath($this->config['i18n-base-path']) . '/' . $this->config['locale'];
 	}
 
 	/**
 	 * If the pathname does not start with a slash, make the path absolute to root dir of application
 	 */
-	private function getAbsolutePath( string $path ): string {
-		if ( $path[0] === '/' ) {
+	private function getAbsolutePath(string $path): string {
+		if ($path[0] === '/') {
 			return $path;
 		}
 		return __DIR__ . '/../../' . $path;
 	}
 
-	public function setContentPagePageSelector( PageSelector $pageSelector ): void {
+	public function setContentPagePageSelector(PageSelector $pageSelector): void {
 		$this->pimple['content_page_selector'] = $pageSelector;
 	}
 
@@ -1422,7 +1422,7 @@ 
 		return $this->pimple['content_page_selector'];
 	}
 
-	public function setContentProvider( ContentProvider $contentProvider ): void {
+	public function setContentProvider(ContentProvider $contentProvider): void {
 		$this->pimple['content_provider'] = $contentProvider;
 	}
 

src/Presentation/Presenters/CreditCardPaymentHtmlPresenter.php

Spacing +8 added lines, -8 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\Presentation\Presenters;
 
@@ -23,18 +23,18 @@ 
 	private $translator;
 	private $urlGenerator;
 
-	public function __construct( TwigTemplate $template, TranslatorInterface $translator,
-								CreditCardUrlGenerator $urlGenerator ) {
+	public function __construct(TwigTemplate $template, TranslatorInterface $translator,
+								CreditCardUrlGenerator $urlGenerator) {
 		$this->template = $template;
 		$this->translator = $translator;
 		$this->urlGenerator = $urlGenerator;
 	}
 
-	public function present( AddDonationResponse $response ): string {
-		return $this->template->render( $this->getArguments( $response ) );
+	public function present(AddDonationResponse $response): string {
+		return $this->template->render($this->getArguments($response));
 	}
 
-	private function getArguments( AddDonationResponse $response ) {
+	private function getArguments(AddDonationResponse $response) {
 		$personalInfo = $response->getDonation()->getDonor();
 		return [
 			'donation' => [
@@ -44,8 +44,8 @@ 
 			'iframeUrl' => $this->urlGenerator->generateUrl(
 				$personalInfo ? $personalInfo->getName()->getFirstName() : '',
 				$personalInfo ? $personalInfo->getName()->getLastName() : '',
-				$this->translator->trans( 'paytext_cc', [], 'paymentIntervals' ) . ' ' .
-					$this->translator->trans( $response->getDonation()->getPaymentIntervalInMonths(), [], 'paymentIntervals' ),
+				$this->translator->trans('paytext_cc', [], 'paymentIntervals') . ' ' .
+					$this->translator->trans($response->getDonation()->getPaymentIntervalInMonths(), [], 'paymentIntervals'),
 				$response->getDonation()->getId(),
 				$response->getAccessToken(),
 				$response->getUpdateToken(),

contexts/PaymentContext/src/Domain/PaymentUrlGenerator/CreditCard.php

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\Domain\PaymentUrlGenerator;
 
@@ -14,12 +14,12 @@ 
 
 	private $config;
 
-	public function __construct( CreditCardConfig $config ) {
+	public function __construct(CreditCardConfig $config) {
 		$this->config = $config;
 	}
 
-	public function generateUrl( string $firstName, string $lastName, string $payText, int $donationId,
-								 string $accessToken, string $updateToken, Euro $amount ) {
+	public function generateUrl(string $firstName, string $lastName, string $payText, int $donationId,
+								 string $accessToken, string $updateToken, Euro $amount) {
 		// TODO: implement sealed parameters (https://techdoc.micropayment.de/payment/payments/payments_en.html#id302721)
 		$baseUrl = $this->config->getBaseUrl();
 		$params = [
@@ -35,11 +35,11 @@ 
 			'amount' => $amount->getEuroCents(),
 			'theme' => $this->config->getTheme()
 		];
-		if ( $this->config->isTestMode() ) {
+		if ($this->config->isTestMode()) {
 			$params['testmode'] = '1';
 		}
 
-		return $baseUrl . http_build_query( $params );
+		return $baseUrl . http_build_query($params);
 	}
 
 }

contexts/PaymentContext/src/Domain/PaymentUrlGenerator/PayPalConfig.php

Spacing +10 added lines, -10 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\Domain\PaymentUrlGenerator;
 
@@ -26,8 +26,8 @@ 
 	private $itemName;
 	private $delayInDays;
 
-	private function __construct( string $payPalAccountAddress, string $payPalBaseUrl, string $notifyUrl,
-								 string $returnUrl, string $cancelUrl, string $itemName, int $delayInDays ) {
+	private function __construct(string $payPalAccountAddress, string $payPalBaseUrl, string $notifyUrl,
+								 string $returnUrl, string $cancelUrl, string $itemName, int $delayInDays) {
 		$this->payPalAccountAddress = $payPalAccountAddress;
 		$this->payPalBaseUrl = $payPalBaseUrl;
 		$this->notifyUrl = $notifyUrl;
@@ -42,22 +42,22 @@ 
 	 * @return PayPalConfig
 	 * @throws \RuntimeException
 	 */
-	public static function newFromConfig( array $config ): self {
-		return ( new self(
+	public static function newFromConfig(array $config): self {
+		return (new self(
 			$config[self::CONFIG_KEY_ACCOUNT_ADDRESS],
 			$config[self::CONFIG_KEY_BASE_URL],
 			$config[self::CONFIG_KEY_NOTIFY_URL],
 			$config[self::CONFIG_KEY_RETURN_URL],
 			$config[self::CONFIG_KEY_CANCEL_URL],
 			$config[self::CONFIG_KEY_ITEM_NAME],
-			isset( $config[self::CONFIG_KEY_DELAY_IN_DAYS] ) ? (int)$config[self::CONFIG_KEY_DELAY_IN_DAYS] : -1
-		) )->assertNoEmptyFields();
+			isset($config[self::CONFIG_KEY_DELAY_IN_DAYS]) ? (int)$config[self::CONFIG_KEY_DELAY_IN_DAYS] : -1
+		))->assertNoEmptyFields();
 	}
 
 	private function assertNoEmptyFields(): self {
-		foreach ( get_object_vars( $this ) as $fieldName => $fieldValue ) {
-			if ( empty( $fieldValue ) ) {
-				throw new \RuntimeException( "Configuration variable '$fieldName' can not be empty" );
+		foreach (get_object_vars($this) as $fieldName => $fieldValue) {
+			if (empty($fieldValue)) {
+				throw new \RuntimeException("Configuration variable '$fieldName' can not be empty");
 			}
 		}
 

contexts/PaymentContext/src/Domain/PaymentUrlGenerator/Sofort.php

Spacing +13 added lines, -13 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\Domain\PaymentUrlGenerator;
 
@@ -25,7 +25,7 @@ 
 	 */
 	private $client;
 
-	public function __construct( SofortConfig $config, Client $client ) {
+	public function __construct(SofortConfig $config, Client $client) {
 		$this->config = $config;
 		$this->client = $client;
 	}
@@ -39,25 +39,25 @@ 
 	 * @param string $accessToken A token to return to the payment process after completing the 3rd party process
 	 * @return string
 	 */
-	public function generateUrl( int $internalItemId, string $externalItemId, Euro $amount, string $accessToken ): string {
+	public function generateUrl(int $internalItemId, string $externalItemId, Euro $amount, string $accessToken): string {
 		$request = new Request();
-		$request->setAmount( $amount );
-		$request->setCurrencyCode( self::CURRENCY );
-		$request->setReasons( [ $this->config->getReasonText(), $externalItemId ] );
+		$request->setAmount($amount);
+		$request->setCurrencyCode(self::CURRENCY);
+		$request->setReasons([$this->config->getReasonText(), $externalItemId]);
 		$request->setSuccessUrl(
-			$this->config->getReturnUrl() . '?' . http_build_query( [
+			$this->config->getReturnUrl() . '?' . http_build_query([
 				'id' => $internalItemId,
 				'accessToken' => $accessToken
-			] )
+			])
 		);
-		$request->setAbortUrl( $this->config->getCancelUrl() );
+		$request->setAbortUrl($this->config->getCancelUrl());
 		// @todo To use in T167882
-		$request->setNotificationUrl( '' );
+		$request->setNotificationUrl('');
 
 		try {
-			$response = $this->client->get( $request );
-		} catch ( RuntimeException $exception ) {
-			throw new RuntimeException( 'Could not generate Sofort URL: ' . $exception->getMessage() );
+			$response = $this->client->get($request);
+		} catch (RuntimeException $exception) {
+			throw new RuntimeException('Could not generate Sofort URL: ' . $exception->getMessage());
 		}
 
 		return $response->getPaymentUrl();

contexts/PaymentContext/src/Domain/PaymentUrlGenerator/SofortConfig.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\Domain\PaymentUrlGenerator;
 
@@ -19,7 +19,7 @@ 
 	 */
 	private $cancelUrl;
 
-	public function __construct( string $reasonText, string $returnUrl, string $cancelUrl ) {
+	public function __construct(string $reasonText, string $returnUrl, string $cancelUrl) {
 		$this->reasonText = $reasonText;
 		$this->returnUrl = $returnUrl;
 		$this->cancelUrl = $cancelUrl;

contexts/PaymentContext/src/Domain/PaymentUrlGenerator/CreditCardConfig.php

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\Domain\PaymentUrlGenerator;
 
@@ -24,8 +24,8 @@ 
 	private $theme;
 	private $testMode;
 
-	private function __construct( string $baseUrl, string $projectId, string $backgroundColor, string $skin, string $theme,
-								  bool $testMode ) {
+	private function __construct(string $baseUrl, string $projectId, string $backgroundColor, string $skin, string $theme,
+								  bool $testMode) {
 		$this->baseUrl = $baseUrl;
 		$this->projectId = $projectId;
 		$this->backgroundColor = $backgroundColor;
@@ -39,21 +39,21 @@ 
 	 * @return self
 	 * @throws \RuntimeException
 	 */
-	public static function newFromConfig( array $config ): self {
-		return ( new self(
+	public static function newFromConfig(array $config): self {
+		return (new self(
 			$config[self::CONFIG_KEY_BASE_URL],
 			$config[self::CONFIG_KEY_PROJECT_ID],
 			$config[self::CONFIG_KEY_BACKGROUND_COLOR],
 			$config[self::CONFIG_KEY_SKIN],
 			$config[self::CONFIG_KEY_THEME],
 			$config[self::CONFIG_KEY_TESTMODE]
-		) )->assertNoEmptyFields();
+		))->assertNoEmptyFields();
 	}
 
 	private function assertNoEmptyFields(): self {
-		foreach ( get_object_vars( $this ) as $fieldName => $fieldValue ) {
-			if ( !isset( $fieldValue ) || $fieldValue === '' ) {
-				throw new \RuntimeException( "Configuration variable '$fieldName' can not be empty" );
+		foreach (get_object_vars($this) as $fieldName => $fieldValue) {
+			if (!isset($fieldValue) || $fieldValue === '') {
+				throw new \RuntimeException("Configuration variable '$fieldName' can not be empty");
 			}
 		}
 

contexts/PaymentContext/src/Domain/PaymentUrlGenerator/PayPal.php

Spacing +19 added lines, -19 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\Domain\PaymentUrlGenerator;
 
@@ -20,23 +20,23 @@ 
 
 	private $config;
 
-	public function __construct( PayPalConfig $config ) {
+	public function __construct(PayPalConfig $config) {
 		$this->config = $config;
 	}
 
-	public function generateUrl( int $itemId, Euro $amount, int $interval,
-								 string $updateToken, string $accessToken ): string {
+	public function generateUrl(int $itemId, Euro $amount, int $interval,
+								 string $updateToken, string $accessToken): string {
 
 		$params = array_merge(
-			$this->getIntervalDependentParameters( $amount, $interval ),
-			$this->getIntervalAgnosticParameters( $itemId, $updateToken, $accessToken ),
+			$this->getIntervalDependentParameters($amount, $interval),
+			$this->getIntervalAgnosticParameters($itemId, $updateToken, $accessToken),
 			$this->getPaymentDelayParameters()
 		);
 
-		return $this->config->getPayPalBaseUrl() . http_build_query( $params );
+		return $this->config->getPayPalBaseUrl() . http_build_query($params);
 	}
 
-	private function getIntervalAgnosticParameters( int $itemId, string $updateToken, string $accessToken ): array {
+	private function getIntervalAgnosticParameters(int $itemId, string $updateToken, string $accessToken): array {
 		return [
 			'business' => $this->config->getPayPalAccountAddress(),
 			'currency_code' => 'EUR',
@@ -46,33 +46,33 @@ 
 			'notify_url' => $this->config->getNotifyUrl(),
 			'cancel_return' => $this->config->getCancelUrl(),
 			'return' => $this->config->getReturnUrl() . '?id=' . $itemId . '&accessToken=' . $accessToken,
-			'custom' => json_encode( [
+			'custom' => json_encode([
 				'sid' => $itemId,
 				'utoken' => $updateToken
-			] )
+			])
 		];
 	}
 
 	private function getPaymentDelayParameters() {
-		if ( $this->config->getDelayInDays() > 0 ) {
-			return $this->getDelayedSubscriptionParams( $this->config->getDelayInDays() );
+		if ($this->config->getDelayInDays() > 0) {
+			return $this->getDelayedSubscriptionParams($this->config->getDelayInDays());
 		}
 		return [];
 	}
 
-	private function getIntervalDependentParameters( Euro $amount, int $interval ): array {
-		if ( $interval > 0 ) {
-			return $this->getSubscriptionParams( $amount, $interval );
+	private function getIntervalDependentParameters(Euro $amount, int $interval): array {
+		if ($interval > 0) {
+			return $this->getSubscriptionParams($amount, $interval);
 		}
 
-		return $this->getSinglePaymentParams( $amount );
+		return $this->getSinglePaymentParams($amount);
 	}
 
 	/**
 	 * This method returns a set of parameters needed for recurring payments.
 	 * @link https://developer.paypal.com/docs/classic/paypal-payments-standard/integration-guide/wp_standard_overview/
 	 */
-	private function getSubscriptionParams( Euro $amount, int $interval ): array {
+	private function getSubscriptionParams(Euro $amount, int $interval): array {
 		return [
 			'cmd' => '_xclick-subscriptions',
 			'no_shipping' => '1',
@@ -90,7 +90,7 @@ 
 	 * trial periods supported by PayPal.
 	 * @link https://developer.paypal.com/docs/classic/paypal-payments-standard/integration-guide/wp_standard_overview/
 	 */
-	private function getDelayedSubscriptionParams( int $delayInDays ): array {
+	private function getDelayedSubscriptionParams(int $delayInDays): array {
 		return [
 			'a1' => 0,
 			'p1' => $delayInDays,
@@ -102,7 +102,7 @@ 
 	 * This method returns a set of parameters needed for one time payments.
 	 * @link https://developer.paypal.com/docs/classic/paypal-payments-standard/integration-guide/wp_standard_overview/
 	 */
-	private function getSinglePaymentParams( Euro $amount ): array {
+	private function getSinglePaymentParams(Euro $amount): array {
 		return [
 			'cmd' => '_donations',
 			'amount' => $amount->getEuroString()

contexts/PaymentContext/src/DataAccess/Sofort/Transfer/Response.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\DataAccess\Sofort\Transfer;
 
@@ -19,7 +19,7 @@ 
 		return $this->transactionId;
 	}
 
-	public function setTransactionId( string $transactionId ): void {
+	public function setTransactionId(string $transactionId): void {
 		$this->transactionId = $transactionId;
 	}
 
@@ -27,7 +27,7 @@ 
 		return $this->paymentUrl;
 	}
 
-	public function setPaymentUrl( string $paymentUrl ): void {
+	public function setPaymentUrl(string $paymentUrl): void {
 		$this->paymentUrl = $paymentUrl;
 	}
 }