wmde / FundraisingFrontend

contexts/PaymentContext/src/Domain/ChecksumGenerator.php

Spacing +8 added lines, -8 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\Domain;
 
@@ -14,8 +14,8 @@ 
 	/**
 	 * @param array $checksumCharacters Characters that can be used for the checksum
 	 */
-	public function __construct( array $checksumCharacters ) {
-		if ( count( $checksumCharacters ) < 2 ) {
+	public function __construct(array $checksumCharacters) {
+		if (count($checksumCharacters) < 2) {
 			throw new \InvalidArgumentException(
 				'Need at least two characters to create meaningful checksum'
 			);
@@ -29,14 +29,14 @@ 
 	 *
 	 * @return string The checksum as a single character present in the constructors array argument
 	 */
-	public function createChecksum( string $string ): string {
-		$checksum = hexdec( substr( md5( $this->normalizeString( $string ) ), 0, 8 ) );
+	public function createChecksum(string $string): string {
+		$checksum = hexdec(substr(md5($this->normalizeString($string)), 0, 8));
 
-		return $this->checksumCharacters[$checksum % count( $this->checksumCharacters )];
+		return $this->checksumCharacters[$checksum % count($this->checksumCharacters)];
 	}
 
-	private function normalizeString( string $string ): string {
-		return strtoupper( str_replace( [ '-', '_', ' ' ], [ '', '', '' ], $string ) );
+	private function normalizeString(string $string): string {
+		return strtoupper(str_replace(['-', '_', ' '], ['', '', ''], $string));
 	}
 
 }
\ No newline at end of file

contexts/PaymentContext/tests/Unit/Domain/ChecksumGeneratorTest.php

Spacing +35 added lines, -35 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\PaymentContext\Tests\Unit\Domain;
 
@@ -15,62 +15,62 @@ 
 class ChecksumGeneratorTest extends TestCase {
 
 	public function testCannotConstructWithLessThanTwoCharacters(): void {
-		$this->expectException( \InvalidArgumentException::class );
-		new ChecksumGenerator( [ 'a' ] );
+		$this->expectException(\InvalidArgumentException::class);
+		new ChecksumGenerator(['a']);
 	}
 
 	public function testCanGenerateChecksumWithTwoCharacters(): void {
-		$generator = new ChecksumGenerator( [ 'a', 'b' ] );
+		$generator = new ChecksumGenerator(['a', 'b']);
 
-		$this->assertSame( 'b', $generator->createChecksum( 'aaaa' ) );
-		$this->assertSame( 'b', $generator->createChecksum( 'aaaaa' ) );
+		$this->assertSame('b', $generator->createChecksum('aaaa'));
+		$this->assertSame('b', $generator->createChecksum('aaaaa'));
 	}
 
 	public function testCanGenerateChecksumWithManyCharacters(): void {
-		$generator = new ChecksumGenerator( str_split( 'ACDEFKLMNPRSTWXYZ349' ) );
+		$generator = new ChecksumGenerator(str_split('ACDEFKLMNPRSTWXYZ349'));
 
-		$this->assertSame( 'X', $generator->createChecksum( 'AAAU' ) );
-		$this->assertSame( 'K', $generator->createChecksum( 'AAAA' ) );
-		$this->assertSame( 'C', $generator->createChecksum( 'QAQA' ) );
-		$this->assertSame( 'D', $generator->createChecksum( 'ABCD' ) );
+		$this->assertSame('X', $generator->createChecksum('AAAU'));
+		$this->assertSame('K', $generator->createChecksum('AAAA'));
+		$this->assertSame('C', $generator->createChecksum('QAQA'));
+		$this->assertSame('D', $generator->createChecksum('ABCD'));
 	}
 
 	public function testIgnoresDashesUnderscoresAndSpaces(): void {
-		$generator = new ChecksumGenerator( str_split( 'ACDEFKLMNPRSTWXYZ349' ) );
+		$generator = new ChecksumGenerator(str_split('ACDEFKLMNPRSTWXYZ349'));
 
-		$checksum = $generator->createChecksum( 'CAT' );
+		$checksum = $generator->createChecksum('CAT');
 
-		$this->assertSame( $checksum, $generator->createChecksum( 'C-AT-' ) );
-		$this->assertSame( $checksum, $generator->createChecksum( '_CAT_' ) );
-		$this->assertSame( $checksum, $generator->createChecksum( 'C A T' ) );
+		$this->assertSame($checksum, $generator->createChecksum('C-AT-'));
+		$this->assertSame($checksum, $generator->createChecksum('_CAT_'));
+		$this->assertSame($checksum, $generator->createChecksum('C A T'));
 	}
 
 	public function testLowerAndMixedCaseProduceConsistentChecksum(): void {
-		$generator = new ChecksumGenerator( str_split( 'ACDEFKLMNPRSTWXYZ349' ) );
+		$generator = new ChecksumGenerator(str_split('ACDEFKLMNPRSTWXYZ349'));
 
-		$this->assertSame( 'X', $generator->createChecksum( 'AAAU' ) );
-		$this->assertSame( 'X', $generator->createChecksum( 'aAAU' ) );
+		$this->assertSame('X', $generator->createChecksum('AAAU'));
+		$this->assertSame('X', $generator->createChecksum('aAAU'));
 
-		$this->assertSame( 'K', $generator->createChecksum( 'aAaa' ) );
-		$this->assertSame( 'K', $generator->createChecksum( 'aaaa' ) );
+		$this->assertSame('K', $generator->createChecksum('aAaa'));
+		$this->assertSame('K', $generator->createChecksum('aaaa'));
 
-		$this->assertSame( 'C', $generator->createChecksum( 'QaQa' ) );
-		$this->assertSame( 'C', $generator->createChecksum( 'qaqa' ) );
+		$this->assertSame('C', $generator->createChecksum('QaQa'));
+		$this->assertSame('C', $generator->createChecksum('qaqa'));
 
-		$this->assertSame( 'D', $generator->createChecksum( 'xxxx' ) );
-		$this->assertSame( 'D', $generator->createChecksum( 'XXXX' ) );
+		$this->assertSame('D', $generator->createChecksum('xxxx'));
+		$this->assertSame('D', $generator->createChecksum('XXXX'));
 	}
 
 	public function testChecksumIsOneOfTheExpectedCharacters(): void {
-		$characters = [ 'A', 'B', 'C' ];
-		$generator = new ChecksumGenerator( $characters );
+		$characters = ['A', 'B', 'C'];
+		$generator = new ChecksumGenerator($characters);
 
 		//$distribution = ['A' => 0, 'B' => 0, 'C' => 0];
 
-		foreach ( $this->getRandomStrings() as $string ) {
+		foreach ($this->getRandomStrings() as $string) {
 			//$distribution[$generator->createChecksum( $string )]++;
 			$this->assertContains(
-				$generator->createChecksum( $string ),
+				$generator->createChecksum($string),
 				$characters
 			);
 		}
@@ -79,17 +79,17 @@ 
 	}
 
 	public function getRandomStrings(): iterable {
-		$characters = str_split( 'ACDEFKLMNPRSTWXYZ349-' );
-		$characterCount = count( $characters );
+		$characters = str_split('ACDEFKLMNPRSTWXYZ349-');
+		$characterCount = count($characters);
 
-		for ( $i = 0; $i < 1000; $i++ ) {
+		for ($i = 0; $i < 1000; $i++) {
 			yield implode(
 				'',
 				array_map(
-					function() use ( $characters, $characterCount ) {
-						return $characters[mt_rand( 0, $characterCount - 1 )];
+					function() use ($characters, $characterCount) {
+						return $characters[mt_rand(0, $characterCount - 1)];
 					},
-					array_fill( 0, 10, null )
+					array_fill(0, 10, null)
 				)
 			);
 		}