wmde / FundraisingFrontend

contexts/DonationContext/tests/Unit/Domain/Model/DonorNameTest.php

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonationContext\Tests\Unit\Domain\Model;
 
@@ -17,15 +17,15 @@ 
 	/**
 	 * @dataProvider privatePersonProvider
 	 */
-	public function testGivenPersonName_determineFullNameReturnsFullName( string $expectedValue, array $data ): void {
+	public function testGivenPersonName_determineFullNameReturnsFullName(string $expectedValue, array $data): void {
 		$personName = DonorName::newPrivatePersonName();
 
-		$personName->setCompanyName( $data['company'] );
-		$personName->setFirstName( $data['firstName'] );
-		$personName->setLastName( $data['lastName'] );
-		$personName->setTitle( $data['title'] );
+		$personName->setCompanyName($data['company']);
+		$personName->setFirstName($data['firstName']);
+		$personName->setLastName($data['lastName']);
+		$personName->setTitle($data['title']);
 
-		$this->assertSame( $expectedValue, $personName->getFullName() );
+		$this->assertSame($expectedValue, $personName->getFullName());
 	}
 
 	public function privatePersonProvider(): array {

contexts/DonationContext/tests/Unit/UseCases/AddDonation/ReferrerGeneralizerTest.php

Spacing +13 added lines, -13 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\DonationContext\Tests\Unit\UseCases\AddDonation;
 
@@ -30,22 +30,22 @@ 
 	 * @param string $expected
 	 * @param string $url
 	 */
-	public function testGeneralization( string $url, string $expected ): void {
-		$generalizer = new ReferrerGeneralizer( 'web', $this->domainMap );
-		$this->assertSame( $expected, $generalizer->generalize( $url ) );
+	public function testGeneralization(string $url, string $expected): void {
+		$generalizer = new ReferrerGeneralizer('web', $this->domainMap);
+		$this->assertSame($expected, $generalizer->generalize($url));
 	}
 
 	public function urlProvider(): array {
 		return [
-			[ 'http://de.wikipedia.org/wiki/Hauptseite', 'de.wikipedia.org' ],
-			[ 'https://en.wikipedia.org/wiki/Main_Page', 'en.wikipedia.org' ],
-			[ 'http://www.wikimedia.de/Mitarbeiter', 'wikimedia.de' ],
-			[ 'https://wikimedia.de/wiki/Hauptseite', 'wikimedia.de' ],
-			[ 'https://www.wikipedia.de/', 'wikipedia.de' ],
-			[ 'http://www.wikipedia.de', 'wikipedia.de' ],
-			[ 'wikipedia.de', 'web' ],
-			[ 'https://www.google.com/?q=wikimedia+spenden', 'web' ],
-			[ 'https://ru.wikivoyage.org/wiki/Молдавия', 'ru.wikivoyage.org' ],
+			['http://de.wikipedia.org/wiki/Hauptseite', 'de.wikipedia.org'],
+			['https://en.wikipedia.org/wiki/Main_Page', 'en.wikipedia.org'],
+			['http://www.wikimedia.de/Mitarbeiter', 'wikimedia.de'],
+			['https://wikimedia.de/wiki/Hauptseite', 'wikimedia.de'],
+			['https://www.wikipedia.de/', 'wikipedia.de'],
+			['http://www.wikipedia.de', 'wikipedia.de'],
+			['wikipedia.de', 'web'],
+			['https://www.google.com/?q=wikimedia+spenden', 'web'],
+			['https://ru.wikivoyage.org/wiki/Молдавия', 'ru.wikivoyage.org'],
 		];
 	}
 

contexts/MembershipContext/tests/Integration/DataAccess/DoctrineMembershipApplicationAuthorizerTest.php

Spacing +46 added lines, -46 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\DataAccess;
 
@@ -29,32 +29,32 @@ 
 	const MEANINGLESS_APPLICATION_ID = 1337;
 	const ID_OF_WRONG_APPLICATION = 42;
 
-	private function newAuthorizerWithApplications( string $updateToken = null,
-		string $accessToken = null, MembershipApplication ...$applications ): ApplicationAuthorizer {
+	private function newAuthorizerWithApplications(string $updateToken = null,
+		string $accessToken = null, MembershipApplication ...$applications): ApplicationAuthorizer {
 
 		$entityManager = TestEnvironment::newInstance()->getFactory()->getEntityManager();
 
-		foreach ( $applications as $application ) {
-			$entityManager->persist( $application );
+		foreach ($applications as $application) {
+			$entityManager->persist($application);
 		}
 
 		$entityManager->flush();
 
-		return new DoctrineApplicationAuthorizer( $entityManager, $updateToken, $accessToken );
+		return new DoctrineApplicationAuthorizer($entityManager, $updateToken, $accessToken);
 	}
 
 	/**
 	 * @slowThreshold 400
 	 */
 	public function testWhenNoMembershipApplications(): void {
-		$this->specify( 'update authorization fails', function() {
-			$authorizer = $this->newAuthorizerWithApplications( self::CORRECT_UPDATE_TOKEN );
-			$this->assertFalse( $authorizer->canModifyApplication( self::MEANINGLESS_APPLICATION_ID ) );
+		$this->specify('update authorization fails', function() {
+			$authorizer = $this->newAuthorizerWithApplications(self::CORRECT_UPDATE_TOKEN);
+			$this->assertFalse($authorizer->canModifyApplication(self::MEANINGLESS_APPLICATION_ID));
 		} );
 
-		$this->specify( 'access authorization fails', function() {
-			$authorizer = $this->newAuthorizerWithApplications( self::CORRECT_ACCESS_TOKEN );
-			$this->assertFalse( $authorizer->canAccessApplication( self::MEANINGLESS_APPLICATION_ID ) );
+		$this->specify('access authorization fails', function() {
+			$authorizer = $this->newAuthorizerWithApplications(self::CORRECT_ACCESS_TOKEN);
+			$this->assertFalse($authorizer->canAccessApplication(self::MEANINGLESS_APPLICATION_ID));
 		} );
 	}
 
@@ -64,56 +64,56 @@ 
 	public function testWhenApplicationWithTokenExists(): void {
 		$application = new MembershipApplication();
 
-		$application->modifyDataObject( function( MembershipApplicationData $data ) {
-			$data->setUpdateToken( self::CORRECT_UPDATE_TOKEN );
-			$data->setAccessToken( self::CORRECT_ACCESS_TOKEN );
+		$application->modifyDataObject(function(MembershipApplicationData $data) {
+			$data->setUpdateToken(self::CORRECT_UPDATE_TOKEN);
+			$data->setAccessToken(self::CORRECT_ACCESS_TOKEN);
 		} );
 
 		$this->specify(
 			'given correct application id and correct token, update authorization succeeds',
-			function() use ( $application ) {
-				$authorizer = $this->newAuthorizerWithApplications( self::CORRECT_UPDATE_TOKEN, null, $application );
-				$this->assertTrue( $authorizer->canModifyApplication( $application->getId() ) );
+			function() use ($application) {
+				$authorizer = $this->newAuthorizerWithApplications(self::CORRECT_UPDATE_TOKEN, null, $application);
+				$this->assertTrue($authorizer->canModifyApplication($application->getId()));
 			}
 		);
 
 		$this->specify(
 			'given wrong application id and correct token, update authorization fails',
-			function() use ( $application ) {
-				$authorizer = $this->newAuthorizerWithApplications( self::CORRECT_UPDATE_TOKEN, null, $application );
-				$this->assertFalse( $authorizer->canModifyApplication( self::ID_OF_WRONG_APPLICATION ) );
+			function() use ($application) {
+				$authorizer = $this->newAuthorizerWithApplications(self::CORRECT_UPDATE_TOKEN, null, $application);
+				$this->assertFalse($authorizer->canModifyApplication(self::ID_OF_WRONG_APPLICATION));
 			}
 		);
 
 		$this->specify(
 			'given correct application id and wrong token, update authorization fails',
-			function() use ( $application ) {
-				$authorizer = $this->newAuthorizerWithApplications( self::WRONG__UPDATE_TOKEN, null, $application );
-				$this->assertFalse( $authorizer->canModifyApplication( $application->getId() ) );
+			function() use ($application) {
+				$authorizer = $this->newAuthorizerWithApplications(self::WRONG__UPDATE_TOKEN, null, $application);
+				$this->assertFalse($authorizer->canModifyApplication($application->getId()));
 			}
 		);
 
 		$this->specify(
 			'given correct application id and correct token, access authorization succeeds',
-			function() use ( $application ) {
-				$authorizer = $this->newAuthorizerWithApplications( null, self::CORRECT_ACCESS_TOKEN, $application );
-				$this->assertTrue( $authorizer->canAccessApplication( $application->getId() ) );
+			function() use ($application) {
+				$authorizer = $this->newAuthorizerWithApplications(null, self::CORRECT_ACCESS_TOKEN, $application);
+				$this->assertTrue($authorizer->canAccessApplication($application->getId()));
 			}
 		);
 
 		$this->specify(
 			'given wrong application id and correct token, access authorization fails',
-			function() use ( $application ) {
-				$authorizer = $this->newAuthorizerWithApplications( null, self::CORRECT_ACCESS_TOKEN, $application );
-				$this->assertFalse( $authorizer->canAccessApplication( self::ID_OF_WRONG_APPLICATION ) );
+			function() use ($application) {
+				$authorizer = $this->newAuthorizerWithApplications(null, self::CORRECT_ACCESS_TOKEN, $application);
+				$this->assertFalse($authorizer->canAccessApplication(self::ID_OF_WRONG_APPLICATION));
 			}
 		);
 
 		$this->specify(
 			'given correct application id and wrong token, access authorization fails',
-			function() use ( $application ) {
-				$authorizer = $this->newAuthorizerWithApplications( null, self::WRONG_ACCESS_TOKEN, $application );
-				$this->assertFalse( $authorizer->canAccessApplication( $application->getId() ) );
+			function() use ($application) {
+				$authorizer = $this->newAuthorizerWithApplications(null, self::WRONG_ACCESS_TOKEN, $application);
+				$this->assertFalse($authorizer->canAccessApplication($application->getId()));
 			}
 		);
 	}
@@ -126,17 +126,17 @@ 
 
 		$this->specify(
 			'given correct application id and a token, update authorization fails',
-			function() use ( $application ) {
-				$authorizer = $this->newAuthorizerWithApplications( 'SomeToken', null, $application );
-				$this->assertFalse( $authorizer->canModifyApplication( $application->getId() ) );
+			function() use ($application) {
+				$authorizer = $this->newAuthorizerWithApplications('SomeToken', null, $application);
+				$this->assertFalse($authorizer->canModifyApplication($application->getId()));
 			}
 		);
 
 		$this->specify(
 			'given correct application id and a token, access authorization fails',
-			function() use ( $application ) {
-				$authorizer = $this->newAuthorizerWithApplications( null, 'SomeToken', $application );
-				$this->assertFalse( $authorizer->canAccessApplication( $application->getId() ) );
+			function() use ($application) {
+				$authorizer = $this->newAuthorizerWithApplications(null, 'SomeToken', $application);
+				$this->assertFalse($authorizer->canAccessApplication($application->getId()));
 			}
 		);
 	}
@@ -151,21 +151,21 @@ 
 			self::CORRECT_ACCESS_TOKEN
 		);
 
-		$this->specify( 'update authorization fails', function() use ( $authorizer ) {
-			$this->assertFalse( $authorizer->canModifyApplication( self::MEANINGLESS_APPLICATION_ID ) );
+		$this->specify('update authorization fails', function() use ($authorizer) {
+			$this->assertFalse($authorizer->canModifyApplication(self::MEANINGLESS_APPLICATION_ID));
 		} );
 
-		$this->specify( 'access authorization fails', function() use ( $authorizer ) {
-			$this->assertFalse( $authorizer->canAccessApplication( self::MEANINGLESS_APPLICATION_ID ) );
+		$this->specify('access authorization fails', function() use ($authorizer) {
+			$this->assertFalse($authorizer->canAccessApplication(self::MEANINGLESS_APPLICATION_ID));
 		} );
 	}
 
 	private function getThrowingEntityManager(): EntityManager {
-		$entityManager = $this->getMockBuilder( EntityManager::class )
+		$entityManager = $this->getMockBuilder(EntityManager::class)
 			->disableOriginalConstructor()->getMock();
 
-		$entityManager->method( $this->anything() )
-			->willThrowException( new ORMException() );
+		$entityManager->method($this->anything())
+			->willThrowException(new ORMException());
 
 		return $entityManager;
 	}

contexts/MembershipContext/tests/Integration/DataAccess/DoctrineMembershipApplicationTrackerTest.php

Spacing +18 added lines, -18 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\DataAccess;
 
@@ -32,45 +32,45 @@ 
 	/**
 	 * @dataProvider validTrackingDataProvider
 	 */
-	public function testValidTrackingDataIsProperlyApplied( string $campaignCode, string $keyword ): void {
+	public function testValidTrackingDataIsProperlyApplied(string $campaignCode, string $keyword): void {
 		$application = ValidMembershipApplication::newDoctrineEntity();
-		$this->persistApplication( $application );
+		$this->persistApplication($application);
 
 		$this->newMembershipApplicationTracker()->trackApplication(
 			$application->getId(),
-			$this->newMembershipApplicationTrackingInfo( $campaignCode, $keyword )
+			$this->newMembershipApplicationTrackingInfo($campaignCode, $keyword)
 		);
 
-		$storedApplication = $this->getApplicationById( $application->getId() );
+		$storedApplication = $this->getApplicationById($application->getId());
 
-		$this->assertSame( $keyword, $storedApplication->getDecodedData()['confirmationPage'] );
-		$this->assertSame( $campaignCode, $storedApplication->getDecodedData()['confirmationPageCampaign'] );
+		$this->assertSame($keyword, $storedApplication->getDecodedData()['confirmationPage']);
+		$this->assertSame($campaignCode, $storedApplication->getDecodedData()['confirmationPageCampaign']);
 	}
 
 	public function validTrackingDataProvider(): array {
 		return [
-			[ 'campaignCode', 'keyword' ],
-			[ '', 'keyword', 'keyword' ],
-			[ 'campaignCode', '' ],
-			[ '', '' ],
+			['campaignCode', 'keyword'],
+			['', 'keyword', 'keyword'],
+			['campaignCode', ''],
+			['', ''],
 		];
 	}
 
-	private function persistApplication( MembershipApplication $application ): void {
-		$this->entityManager->persist( $application );
+	private function persistApplication(MembershipApplication $application): void {
+		$this->entityManager->persist($application);
 		$this->entityManager->flush();
 	}
 
-	private function getApplicationById( int $applicationId ): MembershipApplication {
-		return $this->entityManager->find( MembershipApplication::class, $applicationId );
+	private function getApplicationById(int $applicationId): MembershipApplication {
+		return $this->entityManager->find(MembershipApplication::class, $applicationId);
 	}
 
 	private function newMembershipApplicationTracker(): ApplicationTracker {
-		return new DoctrineApplicationTracker( $this->entityManager );
+		return new DoctrineApplicationTracker($this->entityManager);
 	}
 
-	private function newMembershipApplicationTrackingInfo( string $campaignCode, string $keyword ): MembershipApplicationTrackingInfo {
-		return new MembershipApplicationTrackingInfo( $campaignCode, $keyword );
+	private function newMembershipApplicationTrackingInfo(string $campaignCode, string $keyword): MembershipApplicationTrackingInfo {
+		return new MembershipApplicationTrackingInfo($campaignCode, $keyword);
 	}
 
 }

contexts/MembershipContext/tests/Integration/DataAccess/DoctrineMembershipApplicationRepositoryTest.php

Spacing +73 added lines, -73 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\DataAccess;
 
@@ -39,141 +39,141 @@ 
 	}
 
 	public function testValidMembershipApplicationGetPersisted(): void {
-		$this->newRepository()->storeApplication( ValidMembershipApplication::newDomainEntity() );
+		$this->newRepository()->storeApplication(ValidMembershipApplication::newDomainEntity());
 
 		$expectedDoctrineEntity = ValidMembershipApplication::newDoctrineEntity();
-		$expectedDoctrineEntity->setId( self::MEMBERSHIP_APPLICATION_ID );
+		$expectedDoctrineEntity->setId(self::MEMBERSHIP_APPLICATION_ID);
 
-		$this->assertDoctrineEntityIsInDatabase( $expectedDoctrineEntity );
+		$this->assertDoctrineEntityIsInDatabase($expectedDoctrineEntity);
 	}
 
 	private function newRepository(): ApplicationRepository {
-		return new DoctrineApplicationRepository( $this->entityManager );
+		return new DoctrineApplicationRepository($this->entityManager);
 	}
 
-	private function assertDoctrineEntityIsInDatabase( DoctrineApplication $expected ): void {
-		$actual = $this->getApplicationFromDatabase( $expected->getId() );
+	private function assertDoctrineEntityIsInDatabase(DoctrineApplication $expected): void {
+		$actual = $this->getApplicationFromDatabase($expected->getId());
 
-		$this->assertNotNull( $actual->getCreationTime() );
-		$actual->setCreationTime( null );
+		$this->assertNotNull($actual->getCreationTime());
+		$actual->setCreationTime(null);
 
-		$this->assertEquals( $expected->getDecodedData(), $actual->getDecodedData() );
+		$this->assertEquals($expected->getDecodedData(), $actual->getDecodedData());
 
-		$this->assertEquals( $expected, $actual );
+		$this->assertEquals($expected, $actual);
 	}
 
-	private function getApplicationFromDatabase( int $id ): DoctrineApplication {
-		$applicationRepo = $this->entityManager->getRepository( DoctrineApplication::class );
-		$donation = $applicationRepo->find( $id );
-		$this->assertInstanceOf( DoctrineApplication::class, $donation );
+	private function getApplicationFromDatabase(int $id): DoctrineApplication {
+		$applicationRepo = $this->entityManager->getRepository(DoctrineApplication::class);
+		$donation = $applicationRepo->find($id);
+		$this->assertInstanceOf(DoctrineApplication::class, $donation);
 		return $donation;
 	}
 
 	public function testIdGetsAssigned(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 
-		$this->newRepository()->storeApplication( $application );
+		$this->newRepository()->storeApplication($application);
 
-		$this->assertSame( self::MEMBERSHIP_APPLICATION_ID, $application->getId() );
+		$this->assertSame(self::MEMBERSHIP_APPLICATION_ID, $application->getId());
 	}
 
 	public function testWhenPersistenceFails_domainExceptionIsThrown(): void {
 		$donation = ValidMembershipApplication::newDomainEntity();
 
-		$repository = new DoctrineApplicationRepository( ThrowingEntityManager::newInstance( $this ) );
+		$repository = new DoctrineApplicationRepository(ThrowingEntityManager::newInstance($this));
 
-		$this->expectException( StoreMembershipApplicationException::class );
-		$repository->storeApplication( $donation );
+		$this->expectException(StoreMembershipApplicationException::class);
+		$repository->storeApplication($donation);
 	}
 
 	public function testWhenMembershipApplicationInDatabase_itIsReturnedAsMatchingDomainEntity(): void {
-		$this->storeDoctrineApplication( ValidMembershipApplication::newDoctrineEntity() );
+		$this->storeDoctrineApplication(ValidMembershipApplication::newDoctrineEntity());
 
 		$expected = ValidMembershipApplication::newAutoConfirmedDomainEntity();
-		$expected->assignId( self::MEMBERSHIP_APPLICATION_ID );
+		$expected->assignId(self::MEMBERSHIP_APPLICATION_ID);
 
 		$this->assertEquals(
 			$expected,
-			$this->newRepository()->getApplicationById( self::MEMBERSHIP_APPLICATION_ID )
+			$this->newRepository()->getApplicationById(self::MEMBERSHIP_APPLICATION_ID)
 		);
 	}
 
-	private function storeDoctrineApplication( DoctrineApplication $application ): void {
-		$this->entityManager->persist( $application );
+	private function storeDoctrineApplication(DoctrineApplication $application): void {
+		$this->entityManager->persist($application);
 		$this->entityManager->flush();
 	}
 
 	public function testWhenEntityDoesNotExist_getEntityReturnsNull(): void {
-		$this->assertNull( $this->newRepository()->getApplicationById( self::ID_OF_APPLICATION_NOT_IN_DB ) );
+		$this->assertNull($this->newRepository()->getApplicationById(self::ID_OF_APPLICATION_NOT_IN_DB));
 	}
 
 	public function testWhenReadFails_domainExceptionIsThrown(): void {
-		$repository = new DoctrineApplicationRepository( ThrowingEntityManager::newInstance( $this ) );
+		$repository = new DoctrineApplicationRepository(ThrowingEntityManager::newInstance($this));
 
-		$this->expectException( GetMembershipApplicationException::class );
-		$repository->getApplicationById( self::ID_OF_APPLICATION_NOT_IN_DB );
+		$this->expectException(GetMembershipApplicationException::class);
+		$repository->getApplicationById(self::ID_OF_APPLICATION_NOT_IN_DB);
 	}
 
 	public function testWhenApplicationAlreadyExists_persistingCausesUpdate(): void {
 		$repository = $this->newRepository();
 		$originalApplication = ValidMembershipApplication::newDomainEntity();
 
-		$repository->storeApplication( $originalApplication );
+		$repository->storeApplication($originalApplication);
 
 		// It is important a new instance is created here to test "detached entity" handling
 		$newApplication = ValidMembershipApplication::newDomainEntity();
-		$newApplication->assignId( $originalApplication->getId() );
-		$newApplication->getApplicant()->changeEmailAddress( new EmailAddress( 'chuck.norris@always.win' ) );
+		$newApplication->assignId($originalApplication->getId());
+		$newApplication->getApplicant()->changeEmailAddress(new EmailAddress('chuck.norris@always.win'));
 
-		$repository->storeApplication( $newApplication );
+		$repository->storeApplication($newApplication);
 
-		$doctrineApplication = $this->getApplicationFromDatabase( $newApplication->getId() );
+		$doctrineApplication = $this->getApplicationFromDatabase($newApplication->getId());
 
-		$this->assertSame( 'chuck.norris@always.win', $doctrineApplication->getApplicantEmailAddress() );
+		$this->assertSame('chuck.norris@always.win', $doctrineApplication->getApplicantEmailAddress());
 	}
 
 	public function testWriteAndReadRoundtrip(): void {
 		$repository = $this->newRepository();
 		$application = ValidMembershipApplication::newAutoConfirmedDomainEntity();
 
-		$repository->storeApplication( $application );
+		$repository->storeApplication($application);
 
 		$this->assertEquals(
 			$application,
-			$repository->getApplicationById( self::MEMBERSHIP_APPLICATION_ID )
+			$repository->getApplicationById(self::MEMBERSHIP_APPLICATION_ID)
 		);
 	}
 
 	public function testWhenPersistingDeletedApplication_exceptionIsThrown(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
-		$application->assignId( self::ID_OF_APPLICATION_NOT_IN_DB );
+		$application->assignId(self::ID_OF_APPLICATION_NOT_IN_DB);
 
 		$repository = $this->newRepository();
 
-		$this->expectException( StoreMembershipApplicationException::class );
-		$repository->storeApplication( $application );
+		$this->expectException(StoreMembershipApplicationException::class);
+		$repository->storeApplication($application);
 	}
 
 	public function testWhenPersistingApplicationWithModerationFlag_doctrineApplicationHasFlag(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->markForModeration();
 
-		$this->newRepository()->storeApplication( $application );
-		$doctrineApplication = $this->getApplicationFromDatabase( $application->getId() );
+		$this->newRepository()->storeApplication($application);
+		$doctrineApplication = $this->getApplicationFromDatabase($application->getId());
 
-		$this->assertTrue( $doctrineApplication->needsModeration() );
-		$this->assertFalse( $doctrineApplication->isCancelled() );
+		$this->assertTrue($doctrineApplication->needsModeration());
+		$this->assertFalse($doctrineApplication->isCancelled());
 	}
 
 	public function testWhenPersistingApplicationWithCancelledFlag_doctrineApplicationHasFlag(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->cancel();
 
-		$this->newRepository()->storeApplication( $application );
-		$doctrineApplication = $this->getApplicationFromDatabase( $application->getId() );
+		$this->newRepository()->storeApplication($application);
+		$doctrineApplication = $this->getApplicationFromDatabase($application->getId());
 
-		$this->assertFalse( $doctrineApplication->needsModeration() );
-		$this->assertTrue( $doctrineApplication->isCancelled() );
+		$this->assertFalse($doctrineApplication->needsModeration());
+		$this->assertTrue($doctrineApplication->isCancelled());
 	}
 
 	public function testWhenPersistingCancelledModerationApplication_doctrineApplicationHasFlags(): void {
@@ -181,63 +181,63 @@ 
 		$application->markForModeration();
 		$application->cancel();
 
-		$this->newRepository()->storeApplication( $application );
-		$doctrineApplication = $this->getApplicationFromDatabase( $application->getId() );
+		$this->newRepository()->storeApplication($application);
+		$doctrineApplication = $this->getApplicationFromDatabase($application->getId());
 
-		$this->assertTrue( $doctrineApplication->needsModeration() );
-		$this->assertTrue( $doctrineApplication->isCancelled() );
+		$this->assertTrue($doctrineApplication->needsModeration());
+		$this->assertTrue($doctrineApplication->isCancelled());
 	}
 
 	public function testGivenDoctrineApplicationWithModerationAndCancelled_domainEntityHasFlags(): void {
 		$doctrineApplication = ValidMembershipApplication::newDoctrineEntity();
-		$doctrineApplication->setStatus( DoctrineApplication::STATUS_CANCELED + DoctrineApplication::STATUS_MODERATION );
+		$doctrineApplication->setStatus(DoctrineApplication::STATUS_CANCELED + DoctrineApplication::STATUS_MODERATION);
 
-		$this->storeDoctrineApplication( $doctrineApplication );
-		$application = $this->newRepository()->getApplicationById( $doctrineApplication->getId() );
+		$this->storeDoctrineApplication($doctrineApplication);
+		$application = $this->newRepository()->getApplicationById($doctrineApplication->getId());
 
-		$this->assertTrue( $application->needsModeration() );
-		$this->assertTrue( $application->isCancelled() );
+		$this->assertTrue($application->needsModeration());
+		$this->assertTrue($application->isCancelled());
 	}
 
 	public function testGivenDoctrineApplicationWithModerationFlag_domainEntityHasFlag(): void {
 		$doctrineApplication = ValidMembershipApplication::newDoctrineEntity();
-		$doctrineApplication->setStatus( DoctrineApplication::STATUS_MODERATION );
+		$doctrineApplication->setStatus(DoctrineApplication::STATUS_MODERATION);
 
-		$this->storeDoctrineApplication( $doctrineApplication );
-		$application = $this->newRepository()->getApplicationById( $doctrineApplication->getId() );
+		$this->storeDoctrineApplication($doctrineApplication);
+		$application = $this->newRepository()->getApplicationById($doctrineApplication->getId());
 
-		$this->assertTrue( $application->needsModeration() );
-		$this->assertFalse( $application->isCancelled() );
+		$this->assertTrue($application->needsModeration());
+		$this->assertFalse($application->isCancelled());
 	}
 
 	public function testGivenDoctrineApplicationWithCancelledFlag_domainEntityHasFlag(): void {
 		$doctrineApplication = ValidMembershipApplication::newDoctrineEntity();
-		$doctrineApplication->setStatus( DoctrineApplication::STATUS_CANCELED );
+		$doctrineApplication->setStatus(DoctrineApplication::STATUS_CANCELED);
 
-		$this->storeDoctrineApplication( $doctrineApplication );
-		$application = $this->newRepository()->getApplicationById( $doctrineApplication->getId() );
+		$this->storeDoctrineApplication($doctrineApplication);
+		$application = $this->newRepository()->getApplicationById($doctrineApplication->getId());
 
-		$this->assertFalse( $application->needsModeration() );
-		$this->assertTrue( $application->isCancelled() );
+		$this->assertFalse($application->needsModeration());
+		$this->assertTrue($application->isCancelled());
 	}
 
 	public function testGivenDoctrineApplicationWithCancelledFlag_initialStatusIsPreserved(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->cancel();
 
-		$this->newRepository()->storeApplication( $application );
-		$doctrineApplication = $this->getApplicationFromDatabase( $application->getId() );
+		$this->newRepository()->storeApplication($application);
+		$doctrineApplication = $this->getApplicationFromDatabase($application->getId());
 
-		$this->assertSame( DoctrineApplication::STATUS_CONFIRMED, $doctrineApplication->getDataObject()->getPreservedStatus() );
+		$this->assertSame(DoctrineApplication::STATUS_CONFIRMED, $doctrineApplication->getDataObject()->getPreservedStatus());
 	}
 
 	public function testGivenCompanyApplication_companyNameIsPersisted(): void {
-		$this->newRepository()->storeApplication( ValidMembershipApplication::newCompanyApplication() );
+		$this->newRepository()->storeApplication(ValidMembershipApplication::newCompanyApplication());
 
 		$expectedDoctrineEntity = ValidMembershipApplication::newDoctrineCompanyEntity();
-		$expectedDoctrineEntity->setId( self::MEMBERSHIP_APPLICATION_ID );
+		$expectedDoctrineEntity->setId(self::MEMBERSHIP_APPLICATION_ID);
 
-		$this->assertDoctrineEntityIsInDatabase( $expectedDoctrineEntity );
+		$this->assertDoctrineEntityIsInDatabase($expectedDoctrineEntity);
 	}
 
 }

contexts/MembershipContext/tests/Integration/UseCases/HandleSubscriptionPaymentNotification/HandleSubscriptionPaymentNotificationUseCaseTest.php

Spacing +42 added lines, -42 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Integration\UseCases\HandleSubscriptionPaymentNotification;
 
@@ -27,20 +27,20 @@ 
 
 	public function testWhenRepositoryThrowsException_requestIsNotHandled(): void {
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
-			new DoctrineApplicationRepository( ThrowingEntityManager::newInstance( $this ) ),
+			new DoctrineApplicationRepository(ThrowingEntityManager::newInstance($this)),
 			new SucceedingAuthorizer(),
 			$this->getMailer(),
 			new NullLogger()
 		);
-		$request = ValidPayPalNotificationRequest::newInstantPayment( 1 );
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
-		$this->assertTrue( $response->hasErrors() );
+		$request = ValidPayPalNotificationRequest::newInstantPayment(1);
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
+		$this->assertTrue($response->hasErrors());
 	}
 
 	public function testWhenApplicationDoesNotExist_requestIsNotHandled(): void {
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( ValidMembershipApplication::newDomainEntityUsingPayPal() );
+		$fakeRepository->storeApplication(ValidMembershipApplication::newDomainEntityUsingPayPal());
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -49,14 +49,14 @@ 
 			new NullLogger()
 		);
 
-		$request = ValidPayPalNotificationRequest::newInstantPayment( 667 );
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
+		$request = ValidPayPalNotificationRequest::newInstantPayment(667);
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
 	}
 
 	public function testWhenAuthorizationFails_requestIsNotHandled(): void {
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( ValidMembershipApplication::newDomainEntityUsingPayPal() );
+		$fakeRepository->storeApplication(ValidMembershipApplication::newDomainEntityUsingPayPal());
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -65,9 +65,9 @@ 
 			new NullLogger()
 		);
 
-		$request = ValidPayPalNotificationRequest::newInstantPayment( 1 );
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
+		$request = ValidPayPalNotificationRequest::newInstantPayment(1);
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
 	}
 
 	public function testWhenTransactionTypeIsForSubscriptionChanges_requestIsNotHandled(): void {
@@ -79,17 +79,17 @@ 
 			$this->getMailer(),
 			new NullLogger()
 		);
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
 	}
 
 	public function testGivenSubscriptionPaymentRequest_childDataSetIsCreated(): void {
 		$application = ValidMembershipApplication::newConfirmedSubscriptionDomainEntity();
 
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( $application );
+		$fakeRepository->storeApplication($application);
 
-		$request = ValidPayPalNotificationRequest::newRecurringPayment( $application->getId() );
+		$request = ValidPayPalNotificationRequest::newRecurringPayment($application->getId());
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -98,34 +98,34 @@ 
 			new NullLogger()
 		);
 
-		$response = $useCase->handleNotification( $request );
-		$this->assertTrue( $response->notificationWasHandled() );
-		$this->assertFalse( $response->hasErrors() );
+		$response = $useCase->handleNotification($request);
+		$this->assertTrue($response->notificationWasHandled());
+		$this->assertFalse($response->hasErrors());
 
-		$application = $fakeRepository->getApplicationById( $application->getId() );
+		$application = $fakeRepository->getApplicationById($application->getId());
 		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $payment */
 		$payment = $application->getPayment()->getPaymentMethod();
-		$childApplication = $fakeRepository->getApplicationById( $payment->getPayPalData()->getChildPaymentEntityId( ValidPayPalNotificationRequest::TRANSACTION_ID ) );
-		$this->assertNotNull( $childApplication );
+		$childApplication = $fakeRepository->getApplicationById($payment->getPayPalData()->getChildPaymentEntityId(ValidPayPalNotificationRequest::TRANSACTION_ID));
+		$this->assertNotNull($childApplication);
 		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $childPayment */
 		$childPayment = $childApplication->getPayment()->getPaymentMethod();
-		$this->assertEquals( ValidPayPalNotificationRequest::TRANSACTION_ID, $childPayment->getPayPalData()->getPaymentId() );
-		$this->assertEquals( $application->getPayment()->getAmount(), $childApplication->getPayment()->getAmount() );
-		$this->assertEquals( $application->getApplicant(), $childApplication->getApplicant() );
-		$this->assertEquals( $application->getPayment()->getIntervalInMonths(), $childApplication->getPayment()->getIntervalInMonths() );
-		$this->assertTrue( $childApplication->isConfirmed() );
+		$this->assertEquals(ValidPayPalNotificationRequest::TRANSACTION_ID, $childPayment->getPayPalData()->getPaymentId());
+		$this->assertEquals($application->getPayment()->getAmount(), $childApplication->getPayment()->getAmount());
+		$this->assertEquals($application->getApplicant(), $childApplication->getApplicant());
+		$this->assertEquals($application->getPayment()->getIntervalInMonths(), $childApplication->getPayment()->getIntervalInMonths());
+		$this->assertTrue($childApplication->isConfirmed());
 	}
 
 	public function testGivenExistingTransactionId_requestIsNotHandled(): void {
 		$application = ValidMembershipApplication::newConfirmedSubscriptionDomainEntity();
 		/** @var PayPalPayment $payment */
 		$payment = $application->getPayment()->getPaymentMethod();
-		$payment->getPayPalData()->addChildPayment( ValidPayPalNotificationRequest::TRANSACTION_ID, 1 );
+		$payment->getPayPalData()->addChildPayment(ValidPayPalNotificationRequest::TRANSACTION_ID, 1);
 
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( $application );
+		$fakeRepository->storeApplication($application);
 
-		$request = ValidPayPalNotificationRequest::newRecurringPayment( 1 );
+		$request = ValidPayPalNotificationRequest::newRecurringPayment(1);
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -134,31 +134,31 @@ 
 			new NullLogger()
 		);
 
-		$response = $useCase->handleNotification( $request );
-		$this->assertFalse( $response->notificationWasHandled() );
+		$response = $useCase->handleNotification($request);
+		$this->assertFalse($response->notificationWasHandled());
 	}
 
 	/**
 	 * @return TemplateBasedMailer|\PHPUnit_Framework_MockObject_MockObject
 	 */
 	private function getMailer(): TemplateBasedMailer {
-		return $this->getMockBuilder( TemplateBasedMailer::class )->disableOriginalConstructor()->getMock();
+		return $this->getMockBuilder(TemplateBasedMailer::class)->disableOriginalConstructor()->getMock();
 	}
 
 	/**
 	 * @return DonationEventLogger|\PHPUnit_Framework_MockObject_MockObject
 	 */
 	private function getEventLogger(): DonationEventLogger {
-		return $this->createMock( DonationEventLogger::class );
+		return $this->createMock(DonationEventLogger::class);
 	}
 
 	public function testGivenSubscriptionPaymentRequest_parentDataSetReferencesChildPaymentId(): void {
 		$application = ValidMembershipApplication::newConfirmedSubscriptionDomainEntity();
 
 		$fakeRepository = new FakeApplicationRepository();
-		$fakeRepository->storeApplication( $application );
+		$fakeRepository->storeApplication($application);
 
-		$request = ValidPayPalNotificationRequest::newRecurringPayment( $application->getId() );
+		$request = ValidPayPalNotificationRequest::newRecurringPayment($application->getId());
 
 		$useCase = new HandleSubscriptionPaymentNotificationUseCase(
 			$fakeRepository,
@@ -166,22 +166,22 @@ 
 			$this->getMailer(),
 			new NullLogger()
 		);
-		$useCase->handleNotification( $request );
+		$useCase->handleNotification($request);
 
 		/** @var PayPalPayment $payment */
 		$payment = $application->getPayment()->getPaymentMethod();
 
-		$storedApplication = $fakeRepository->getApplicationById( $application->getId() );
+		$storedApplication = $fakeRepository->getApplicationById($application->getId());
 		/** @var PayPalPayment $storedpayment */
 		$storedpayment = $storedApplication->getPayment()->getPaymentMethod();
 
 		$this->assertSame(
 			2,
-			$storedpayment->getPayPalData()->getChildPaymentEntityId( ValidPayPalNotificationRequest::TRANSACTION_ID )
+			$storedpayment->getPayPalData()->getChildPaymentEntityId(ValidPayPalNotificationRequest::TRANSACTION_ID)
 		);
 
 		$this->assertEquals(
-			$payment->getPayPalData()->addChildPayment( ValidPayPalNotificationRequest::TRANSACTION_ID, 2 ),
+			$payment->getPayPalData()->addChildPayment(ValidPayPalNotificationRequest::TRANSACTION_ID, 2),
 			$storedpayment->getPayPalData()
 		);
 	}

contexts/MembershipContext/tests/Unit/Domain/Model/PaymentTest.php

Spacing +16 added lines, -16 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Unit\Domain\Model;
 
@@ -20,38 +20,38 @@ 
 	/**
 	 * @dataProvider invalidIntervalProvider
 	 */
-	public function testGivenInvalidInterval_constructorThrowsException( int $invalidInterval ): void {
-		$this->expectException( \InvalidArgumentException::class );
+	public function testGivenInvalidInterval_constructorThrowsException(int $invalidInterval): void {
+		$this->expectException(\InvalidArgumentException::class);
 		new Payment(
 			$invalidInterval,
-			Euro::newFromInt( 42 ),
-			new DirectDebitPayment( new BankData() )
+			Euro::newFromInt(42),
+			new DirectDebitPayment(new BankData())
 		);
 	}
 
 	public function invalidIntervalProvider(): array {
 		return [
-			'you cant have infinity moneys' => [ 0 ],
-			'time travel is also not allowed' => [ -1 ],
-			'you cant pay 2.4 times per year' => [ 5 ],
-			'you need to pay at least once per year' => [ 13 ],
-			'you need to pay at least once per year!' => [ 24 ],
+			'you cant have infinity moneys' => [0],
+			'time travel is also not allowed' => [ -1],
+			'you cant pay 2.4 times per year' => [5],
+			'you need to pay at least once per year' => [13],
+			'you need to pay at least once per year!' => [24],
 		];
 	}
 
 	public function testWhenIntervalIsTwelveMonths_yearlyPaymentIsBasePayment(): void {
-		$payment = new Payment( 12, Euro::newFromInt( 42 ), new DirectDebitPayment( new BankData() ) );
-		$this->assertEquals( 42, $payment->getYearlyAmount()->getEuroFloat() );
+		$payment = new Payment(12, Euro::newFromInt(42), new DirectDebitPayment(new BankData()));
+		$this->assertEquals(42, $payment->getYearlyAmount()->getEuroFloat());
 	}
 
 	public function testWhenIntervalIsOneMonth_yearlyPaymentIsTwelveTimesBasePayment(): void {
-		$payment = new Payment( 1, Euro::newFromInt( 10 ), new DirectDebitPayment( new BankData() ) );
-		$this->assertEquals( 120, $payment->getYearlyAmount()->getEuroFloat() );
+		$payment = new Payment(1, Euro::newFromInt(10), new DirectDebitPayment(new BankData()));
+		$this->assertEquals(120, $payment->getYearlyAmount()->getEuroFloat());
 	}
 
 	public function testWhenIntervalIsOneQuarter_yearlyPaymentIsFourTimesBasePayment(): void {
-		$payment = new Payment( 3, Euro::newFromInt( 50 ), new DirectDebitPayment( new BankData() ) );
-		$this->assertEquals( 200, $payment->getYearlyAmount()->getEuroFloat() );
+		$payment = new Payment(3, Euro::newFromInt(50), new DirectDebitPayment(new BankData()));
+		$this->assertEquals(200, $payment->getYearlyAmount()->getEuroFloat());
 	}
 
 }

contexts/MembershipContext/tests/Unit/Domain/Model/ApplicationTest.php

Spacing +12 added lines, -12 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\MembershipContext\Tests\Unit\Domain\Model;
 
@@ -16,44 +16,44 @@ 
 class ApplicationTest extends \PHPUnit\Framework\TestCase {
 
 	public function testIdIsNullWhenNotAssigned(): void {
-		$this->assertNull( ValidMembershipApplication::newDomainEntity()->getId() );
+		$this->assertNull(ValidMembershipApplication::newDomainEntity()->getId());
 	}
 
 	public function testCanAssignIdToNewDonation(): void {
 		$donation = ValidMembershipApplication::newDomainEntity();
 
-		$donation->assignId( 42 );
-		$this->assertSame( 42, $donation->getId() );
+		$donation->assignId(42);
+		$this->assertSame(42, $donation->getId());
 	}
 
 	public function testCannotAssignIdToDonationWithIdentity(): void {
 		$donation = ValidMembershipApplication::newDomainEntity();
-		$donation->assignId( 42 );
+		$donation->assignId(42);
 
-		$this->expectException( RuntimeException::class );
-		$donation->assignId( 43 );
+		$this->expectException(RuntimeException::class);
+		$donation->assignId(43);
 	}
 
 	public function testNewApplicationHasExpectedDefaults(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 
-		$this->assertNull( $application->getId() );
-		$this->assertFalse( $application->isCancelled() );
-		$this->assertFalse( $application->needsModeration() );
+		$this->assertNull($application->getId());
+		$this->assertFalse($application->isCancelled());
+		$this->assertFalse($application->needsModeration());
 	}
 
 	public function testCancellationResultsInCancelledApplication(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->cancel();
 
-		$this->assertTrue( $application->isCancelled() );
+		$this->assertTrue($application->isCancelled());
 	}
 
 	public function testMarkForModerationResultsInApplicationThatNeedsModeration(): void {
 		$application = ValidMembershipApplication::newDomainEntity();
 		$application->markForModeration();
 
-		$this->assertTrue( $application->needsModeration() );
+		$this->assertTrue($application->needsModeration());
 	}
 
 }
\ No newline at end of file

contexts/SubscriptionContext/tests/Integration/DataAccess/DoctrineSubscriptionRepositoryTest.php

Spacing +29 added lines, -29 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types = 1);
 
 namespace WMDE\Fundraising\Frontend\SubscriptionContext\Tests\Integration\DataAccess;
 
@@ -33,24 +33,24 @@ 
 	}
 
 	private function getOrmRepository(): EntityRepository {
-		return $this->entityManager->getRepository( Subscription::class );
+		return $this->entityManager->getRepository(Subscription::class);
 	}
 
 	public function testGivenASubscription_itIsStored(): void {
 		$subscription = new Subscription();
-		$subscription->setEmail( 'nyan@awesomecats.com' );
-		$subscription->setAddress( new Address() );
-		$repository = new DoctrineSubscriptionRepository( $this->entityManager );
-		$repository->storeSubscription( $subscription );
+		$subscription->setEmail('nyan@awesomecats.com');
+		$subscription->setAddress(new Address());
+		$repository = new DoctrineSubscriptionRepository($this->entityManager);
+		$repository->storeSubscription($subscription);
 		$expected = $this->getOrmRepository()->findAll();
-		$this->assertEquals( [$subscription], $expected );
+		$this->assertEquals([$subscription], $expected);
 	}
 
 	public function testGivenARecentSubscription_itIsCounted(): void {
 		$firstSubscription = $this->persistFirstSubscription();
 		$this->entityManager->flush();
-		$repository = new DoctrineSubscriptionRepository( $this->entityManager );
-		$this->assertSame( 1, $repository->countSimilar( $firstSubscription, new \DateTime( '100 years ago' ) ) );
+		$repository = new DoctrineSubscriptionRepository($this->entityManager);
+		$this->assertSame(1, $repository->countSimilar($firstSubscription, new \DateTime('100 years ago')));
 	}
 
 	public function testMultipleSubscriptions_onlySimilarAreCounted(): void {
@@ -59,48 +59,48 @@ 
 		$thirdSubscription = $this->persistThirdSubscription();
 
 		$this->entityManager->flush();
-		$repository = new DoctrineSubscriptionRepository( $this->entityManager );
-		$this->assertSame( 1, $repository->countSimilar( $thirdSubscription, new \DateTime( '1 hour ago' ) ) );
-		$this->assertSame( 2, $repository->countSimilar( $thirdSubscription, new \DateTime( '100 years ago' ) ) );
+		$repository = new DoctrineSubscriptionRepository($this->entityManager);
+		$this->assertSame(1, $repository->countSimilar($thirdSubscription, new \DateTime('1 hour ago')));
+		$this->assertSame(2, $repository->countSimilar($thirdSubscription, new \DateTime('100 years ago')));
 	}
 
 	public function testDatabaseLayerExceptionsAreConvertedToDomainExceptions(): void {
-		$entityManager = $this->getMockBuilder( EntityManager::class )
-			->setMethods( [ 'getRepository', 'getClassMetadata', 'persist', 'flush' ] )
+		$entityManager = $this->getMockBuilder(EntityManager::class)
+			->setMethods(['getRepository', 'getClassMetadata', 'persist', 'flush'])
 			->disableOriginalConstructor()
 			->getMock();
 
-		$entityManager->expects( $this->once() )->method( 'persist' )->willThrowException( new ORMException() );
-		$repository = new DoctrineSubscriptionRepository( $entityManager );
+		$entityManager->expects($this->once())->method('persist')->willThrowException(new ORMException());
+		$repository = new DoctrineSubscriptionRepository($entityManager);
 		$subscription = new Subscription();
-		$subscription->setEmail( 'nyan@awesomecats.com' );
-		$subscription->setAddress( new Address() );
+		$subscription->setEmail('nyan@awesomecats.com');
+		$subscription->setAddress(new Address());
 
-		$this->expectException( SubscriptionRepositoryException::class );
-		$repository->storeSubscription( $subscription );
+		$this->expectException(SubscriptionRepositoryException::class);
+		$repository->storeSubscription($subscription);
 	}
 
 	private function persistFirstSubscription(): Subscription {
 		$subscription = new Subscription();
-		$subscription->setEmail( 'nyan@awesomecats.com' );
-		$subscription->setCreatedAt( new \DateTime( '10 minutes ago' ) );
-		$this->entityManager->persist( $subscription );
+		$subscription->setEmail('nyan@awesomecats.com');
+		$subscription->setCreatedAt(new \DateTime('10 minutes ago'));
+		$this->entityManager->persist($subscription);
 		return $subscription;
 	}
 
 	private function persistSecondSubscription(): Subscription {
 		$subscription = new Subscription();
-		$subscription->setEmail( 'unicorn@dancingonrainbows.com' );
-		$subscription->setCreatedAt( new \DateTime( '10 days ago' ) );
-		$this->entityManager->persist( $subscription );
+		$subscription->setEmail('unicorn@dancingonrainbows.com');
+		$subscription->setCreatedAt(new \DateTime('10 days ago'));
+		$this->entityManager->persist($subscription);
 		return $subscription;
 	}
 
 	private function persistThirdSubscription(): Subscription {
 		$subscription = new Subscription();
-		$subscription->setEmail( 'unicorn@dancingonrainbows.com' );
-		$subscription->setCreatedAt( new \DateTime( '10 minutes ago' ) );
-		$this->entityManager->persist( $subscription );
+		$subscription->setEmail('unicorn@dancingonrainbows.com');
+		$subscription->setCreatedAt(new \DateTime('10 minutes ago'));
+		$this->entityManager->persist($subscription);
 		return $subscription;
 	}
 }