WMDE\Fundraising\Frontend\Tests\Integration\PaymentContext\DataAccess\McpCreditCardServiceTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	testMicroPaymentServiceGetsCalledWithAccessKeyAndCustomerId()	0	15	1
A	getMicroPaymentServiceTestDouble()	0	3	1
A	testWhenValidDataIsReturned_creditCardExpiryIsCreated()	0	14	1
A	testWhenInvalidDataIsReturned_exceptionIsThrown()	0	12	1
A	invalidReturnDataProvider()	0	16	1

<?php

declare( strict_types = 1 );

namespace WMDE\Fundraising\Frontend\PaymentContext\Tests\Integration\DataAccess;

use WMDE\Fundraising\Frontend\PaymentContext\DataAccess\McpCreditCardService;
use WMDE\Fundraising\Frontend\PaymentContext\Infrastructure\CreditCardExpiry;
use WMDE\Fundraising\Frontend\PaymentContext\Infrastructure\CreditCardExpiryFetchingException;

/**
 * @covers \WMDE\Fundraising\Frontend\PaymentContext\DataAccess\McpCreditCardService
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 */
class McpCreditCardServiceTest extends \PHPUnit\Framework\TestCase {

	const ACCESS_KEY = 'pink fluffy unicorns';
	const CUSTOMER_ID = '31333333333333333337';

	const EXPIRY_MONTH = 5;
	const EXPIRY_YEAR = 2020;

	const VALID_RETURN_DATA = [
		'expiryMonth' => self::EXPIRY_MONTH,
		'expiryYear' => self::EXPIRY_YEAR,
	];

	public function testMicroPaymentServiceGetsCalledWithAccessKeyAndCustomerId(): void {
		$microPaymentServiceMock = $this->getMicroPaymentServiceTestDouble();

		$microPaymentServiceMock->expects( $this->once() )

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in IMcpCreditcardService_v1_5.

			->method( 'creditcardDataGet' )
			->with(
				$this->equalTo( self::ACCESS_KEY ),
				$this->equalTo( true ),
				$this->equalTo( self::CUSTOMER_ID )
			)
			->willReturn( self::VALID_RETURN_DATA );

		$creditCardService = new McpCreditCardService( $microPaymentServiceMock, self::ACCESS_KEY, true );

It seems like $microPaymentServiceMock defined by $this->getMicroPaymentServiceTestDouble() on line 31 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, WMDE\Fundraising\Frontend\PaymentContext\DataAccess\McpCreditCardService::__construct() does only seem to accept object<IMcpCreditcardService_v1_5>|object<TNvpServiceDispatcher>, maybe add an additional type check?

		$creditCardService->getExpirationDate( self::CUSTOMER_ID );
	}

	/**
	 * @return \PHPUnit_Framework_MockObject_MockObject|\IMcpCreditcardService_v1_5
	 */
	private function getMicroPaymentServiceTestDouble() {
		return $this->createMock( \IMcpCreditcardService_v1_5::class );
	}

	public function testWhenValidDataIsReturned_creditCardExpiryIsCreated(): void {
		$microPaymentServiceStub = $this->getMicroPaymentServiceTestDouble();

		$microPaymentServiceStub->expects( $this->any() )

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in IMcpCreditcardService_v1_5.

			->method( 'creditcardDataGet' )
			->willReturn( self::VALID_RETURN_DATA );

		$creditCardService = new McpCreditCardService( $microPaymentServiceStub, self::ACCESS_KEY, true );

It seems like $microPaymentServiceStub defined by $this->getMicroPaymentServiceTestDouble() on line 54 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, WMDE\Fundraising\Frontend\PaymentContext\DataAccess\McpCreditCardService::__construct() does only seem to accept object<IMcpCreditcardService_v1_5>|object<TNvpServiceDispatcher>, maybe add an additional type check?

		$this->assertEquals(
			new CreditCardExpiry( self::EXPIRY_MONTH, self::EXPIRY_YEAR ),
			$creditCardService->getExpirationDate( self::CUSTOMER_ID )
		);
	}

	/**
	 * @dataProvider invalidReturnDataProvider
	 */
	public function testWhenInvalidDataIsReturned_exceptionIsThrown( array $invalidReturnData ): void {
		$microPaymentServiceStub = $this->getMicroPaymentServiceTestDouble();

		$microPaymentServiceStub->expects( $this->any() )

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in IMcpCreditcardService_v1_5.

			->method( 'creditcardDataGet' )
			->willReturn( $invalidReturnData );

		$creditCardService = new McpCreditCardService( $microPaymentServiceStub, self::ACCESS_KEY, true );

It seems like $microPaymentServiceStub defined by $this->getMicroPaymentServiceTestDouble() on line 72 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, WMDE\Fundraising\Frontend\PaymentContext\DataAccess\McpCreditCardService::__construct() does only seem to accept object<IMcpCreditcardService_v1_5>|object<TNvpServiceDispatcher>, maybe add an additional type check?

		$this->expectException( CreditCardExpiryFetchingException::class );
		$creditCardService->getExpirationDate( self::CUSTOMER_ID );
	}

	public function invalidReturnDataProvider(): array {
		return [
			[ [
				'expiryMonth' => 'potato',
				'expiryYear' => self::EXPIRY_YEAR,
			] ],
			[ [
				'expiryMonth' => 0,
				'expiryYear' => self::EXPIRY_YEAR,
			] ],
			[ [
				'expiryMonth' => 13,
				'expiryYear' => self::EXPIRY_YEAR,
			] ]
		];
	}

}