wikimedia / mediawiki

includes/deferred/DeferredUpdates.php

Doc Comments +3 added lines

@@ -483,6 +483,9 @@
 		return Html::element( 'input', $realAttrs );
 	}
 
+	/**
+	 * @param string $mode
+	 */
 	function makeSearchButton( $mode, $attrs = array() ) {
 		switch ( $mode ) {
 			case 'go':

includes/installer/Installer.php

Doc Comments +7 added lines, -7 removed lines

@@ -359,7 +359,7 @@ 
 	 *
 	 * @param Config $baseConfig
 	 *
-	 * @return Config The config to use during installation.
+	 * @return null|Config The config to use during installation.
 	 */
 	public static function getInstallerConfig( Config $baseConfig ) {
 		$configOverrides = new HashConfig();
@@ -611,7 +611,7 @@ 
 	 * fake password in which case leave it as it is.
 	 *
 	 * @param string $name
-	 * @param mixed $value
+	 * @param string $value
 	 */
 	public function setPassword( $name, $value ) {
 		if ( !preg_match( '/^\*+$/', $value ) ) {
@@ -1256,7 +1256,7 @@ 
 	 *
 	 * If $versionInfo is not false, only executables with a version
 	 * matching $versionInfo[1] will be returned.
-	 * @return bool|string
+	 * @return string|false
 	 */
 	public static function locateExecutable( $path, $names, $versionInfo = false ) {
 		if ( !is_array( $names ) ) {
@@ -1288,14 +1288,14 @@ 
 	/**
 	 * Same as locateExecutable(), but checks in getPossibleBinPaths() by default
 	 * @see locateExecutable()
-	 * @param array $names Array of possible names.
-	 * @param array|bool $versionInfo Default: false or array with two members:
+	 * @param string[] $names Array of possible names.
+	 * @param string[] $versionInfo Default: false or array with two members:
 	 *   0 => Command to run for version check, with $1 for the full executable name
 	 *   1 => String to compare the output with
 	 *
 	 * If $versionInfo is not false, only executables with a version
 	 * matching $versionInfo[1] will be returned.
-	 * @return bool|string
+	 * @return string|false
 	 */
 	public static function locateExecutableInDefaultPaths( $names, $versionInfo = false ) {
 		foreach ( self::getPossibleBinPaths() as $path ) {
@@ -1314,7 +1314,7 @@ 
 	 * Used only by environment checks.
 	 * @param string $dir
 	 * @param string $url
-	 * @return bool|int|string
+	 * @return string|false
 	 */
 	public function dirIsExecutable( $dir, $url ) {
 		$scriptTypes = [

includes/MediaWikiServices.php

Doc Comments +1 added lines, -1 removed lines

@@ -183,7 +183,7 @@
 	 * given $bootstrapConfig. In particular, all wiring files defined in the
 	 * ServiceWiringFiles setting are loaded, and the MediaWikiServices hook is called.
 	 *
-	 * @param Config|null $bootstrapConfig The Config object to be registered as the
+	 * @param Config $bootstrapConfig The Config object to be registered as the
 	 *        'BootstrapConfig' service. This has to contain at least the information
 	 *        needed to set up the 'ConfigFactory' service. If not provided, any call
 	 *        to getBootstrapConfig(), getConfigFactory, or getMainConfig will fail.

includes/search/SearchEngine.php

Doc Comments +7 added lines, -6 removed lines

@@ -97,8 +97,8 @@ 
 	 * Way to pass custom data for engines
 	 * @since 1.18
 	 * @param string $feature
-	 * @param mixed $data
-	 * @return bool
+	 * @param boolean $data
+	 * @return boolean|null
 	 */
 	public function setFeatureData( $feature, $data ) {
 		$this->features[$feature] = $data;
@@ -295,7 +295,7 @@ 
 
 	/**
 	 * Find snippet highlight settings for all users
-	 * @return array Contextlines, contextchars
+	 * @return integer[] Contextlines, contextchars
 	 */
 	public static function userHighlightPrefs() {
 		$contextlines = 2; // Hardcode this. Old defaults sucked. :)
@@ -501,6 +501,7 @@ 
 	 * Process completion search results.
 	 * Resolves the titles and rescores.
 	 * @param SearchSuggestionSet $suggestions
+	 * @param string $search
 	 * @return SearchSuggestionSet
 	 */
 	protected function processCompletionResults( $search, SearchSuggestionSet $suggestions ) {
@@ -584,7 +585,7 @@ 
 	 * settings, returning a list of index numbers.
 	 * @deprecated since 1.27; use SearchEngineConfig::userNamespaces()
 	 * @param user $user
-	 * @return array
+	 * @return integer[]
 	 */
 	public static function userNamespaces( $user ) {
 		return MediaWikiServices::getInstance()->getSearchEngineConfig()->userNamespaces( $user );
@@ -593,7 +594,7 @@ 
 	/**
 	 * An array of namespaces indexes to be searched by default
 	 * @deprecated since 1.27; use SearchEngineConfig::defaultNamespaces()
-	 * @return array
+	 * @return integer[]
 	 */
 	public static function defaultNamespaces() {
 		return MediaWikiServices::getInstance()->getSearchEngineConfig()->defaultNamespaces();
@@ -604,7 +605,7 @@ 
 	 * and preferences
 	 * @deprecated since 1.27; use SearchEngineConfig::namespacesAsText()
 	 * @param array $namespaces
-	 * @return array
+	 * @return string[]
 	 */
 	public static function namespacesAsText( $namespaces ) {
 		return MediaWikiServices::getInstance()->getSearchEngineConfig()->namespacesAsText( $namespaces );

includes/specials/SpecialBlock.php

Doc Comments +1 added lines, -1 removed lines

@@ -234,7 +234,7 @@
 	 * If the user has already been blocked with similar settings, load that block
 	 * and change the defaults for the form fields to match the existing settings.
 	 * @param array $fields HTMLForm descriptor array
-	 * @return bool Whether fields were altered (that is, whether the target is
+	 * @return boolean|null Whether fields were altered (that is, whether the target is
 	 *     already blocked)
 	 */
 	protected function maybeAlterFormDefaults( &$fields ) {