wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/Comparer/MonolingualTextValueComparer.php

Spacing +7 added lines, -7 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param StringComparer $stringComparer
 	 */
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -35,9 +35,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -45,8 +45,8 @@ 
 		 * @var MonolingualTextValue $comparativeValue
 		 */
 
-		if ( $value->getLanguageCode() === $comparativeValue->getLanguageCode() ) {
-			return $this->stringComparer->compare( $value->getText(), $comparativeValue->getText() );
+		if ($value->getLanguageCode() === $comparativeValue->getLanguageCode()) {
+			return $this->stringComparer->compare($value->getText(), $comparativeValue->getText());
 		}
 
 		return null;
@@ -59,7 +59,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof MonolingualTextValue && $comparativeValue instanceof MonolingualTextValue;
 	}
 

includes/CrossCheck/Comparer/MultilingualTextValueComparer.php

Spacing +11 added lines, -11 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param StringComparer $stringComparer
 	 */
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -35,9 +35,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -47,21 +47,21 @@ 
 
 		$texts = $value->getTexts();
 		$comparativeTexts = $comparativeValue->getTexts();
-		$commonLanguages = array_intersect( array_keys( $texts ), array_keys( $comparativeTexts ) );
+		$commonLanguages = array_intersect(array_keys($texts), array_keys($comparativeTexts));
 
-		if ( $commonLanguages ) {
+		if ($commonLanguages) {
 			$totalResult = ComparisonResult::STATUS_MISMATCH;
 
-			foreach ( $commonLanguages as $language ) {
+			foreach ($commonLanguages as $language) {
 				$monolingualText = $texts[$language];
 				$comparativeMonolingualText = $comparativeTexts[$language];
 
-				$result = $this->stringComparer->compare( $monolingualText->getText(), $comparativeMonolingualText->getText() );
-				if ( $result !== ComparisonResult::STATUS_MISMATCH ) {
+				$result = $this->stringComparer->compare($monolingualText->getText(), $comparativeMonolingualText->getText());
+				if ($result !== ComparisonResult::STATUS_MISMATCH) {
 					$totalResult = $result;
 
 					// FIXME: This reports a partial match in a single language as a full match!
-					if ( $result === ComparisonResult::STATUS_MATCH ) {
+					if ($result === ComparisonResult::STATUS_MATCH) {
 						break;
 					}
 				}
@@ -80,7 +80,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof MultilingualTextValue && $comparativeValue instanceof MultilingualTextValue;
 	}
 

includes/CrossCheck/Comparer/QuantityValueComparer.php

Spacing +6 added lines, -6 removed lines

@@ -23,9 +23,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -33,8 +33,8 @@ 
 		 * @var QuantityValue $comparativeValue
 		 */
 
-		if ( $comparativeValue->getLowerBound()->compare( $value->getUpperBound() ) <= 0 &&
-			$comparativeValue->getUpperBound()->compare( $value->getLowerBound() ) >= 0
+		if ($comparativeValue->getLowerBound()->compare($value->getUpperBound()) <= 0 &&
+			$comparativeValue->getUpperBound()->compare($value->getLowerBound()) >= 0
 		) {
 			return ComparisonResult::STATUS_MATCH;
 		}
@@ -49,7 +49,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof QuantityValue && $comparativeValue instanceof QuantityValue;
 	}
 

includes/CrossCheck/Comparer/StringComparer.php

Spacing +40 added lines, -40 removed lines

@@ -26,7 +26,7 @@ 
 	/**
 	 * @param StringNormalizer $stringNormalizer
 	 */
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -37,16 +37,16 @@ 
 	 * @param string $comparativeValue
 	 * @return string
 	 */
-	public function compare( $value, $comparativeValue ) {
-		Assert::parameterType( 'string', $value, '$value' );
-		Assert::parameterType( 'string', $comparativeValue, '$comparativeValue' );
+	public function compare($value, $comparativeValue) {
+		Assert::parameterType('string', $value, '$value');
+		Assert::parameterType('string', $comparativeValue, '$comparativeValue');
 
-		$value = $this->cleanDataString( $value );
-		$comparativeValue = $this->cleanDataString( $comparativeValue );
+		$value = $this->cleanDataString($value);
+		$comparativeValue = $this->cleanDataString($comparativeValue);
 
-		if ( $value === $comparativeValue ) {
+		if ($value === $comparativeValue) {
 			return ComparisonResult::STATUS_MATCH;
-		} elseif ( $this->checkSimilarity( $value, $comparativeValue ) ) {
+		} elseif ($this->checkSimilarity($value, $comparativeValue)) {
 			return ComparisonResult::STATUS_PARTIAL_MATCH;
 		} else {
 			return ComparisonResult::STATUS_MISMATCH;
@@ -60,19 +60,19 @@ 
 	 * @param array $comparativeValues
 	 * @return string
 	 */
-	public function compareWithArray( $value, array $comparativeValues ) {
-		Assert::parameterType( 'string', $value, '$value' );
-		Assert::parameterElementType( 'string', $comparativeValues, '$comparativeValues' );
+	public function compareWithArray($value, array $comparativeValues) {
+		Assert::parameterType('string', $value, '$value');
+		Assert::parameterElementType('string', $comparativeValues, '$comparativeValues');
 
-		$value = $this->cleanDataString( $value );
-		$comparativeValues = $this->cleanDataArray( $comparativeValues );
+		$value = $this->cleanDataString($value);
+		$comparativeValues = $this->cleanDataArray($comparativeValues);
 
-		if ( in_array( $value, $comparativeValues ) ) {
+		if (in_array($value, $comparativeValues)) {
 			return ComparisonResult::STATUS_MATCH;
 		}
 
-		foreach ( $comparativeValues as $comparativeValue ) {
-			if ( $this->checkSimilarity( $comparativeValue, $value ) ) {
+		foreach ($comparativeValues as $comparativeValue) {
+			if ($this->checkSimilarity($comparativeValue, $value)) {
 				return ComparisonResult::STATUS_PARTIAL_MATCH;
 			}
 		}
@@ -87,11 +87,11 @@ 
 	 * @param string $comparativeValue
 	 * @return bool
 	 */
-	private function checkSimilarity( $value, $comparativeValue ) {
+	private function checkSimilarity($value, $comparativeValue) {
 		return
-			$this->percentagePrefixSimilarity( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD ||
-			$this->percentageSuffixSimilarity( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD ||
-			$this->percentageLevenshteinDistance( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD;
+			$this->percentagePrefixSimilarity($value, $comparativeValue) > self::SIMILARITY_THRESHOLD ||
+			$this->percentageSuffixSimilarity($value, $comparativeValue) > self::SIMILARITY_THRESHOLD ||
+			$this->percentageLevenshteinDistance($value, $comparativeValue) > self::SIMILARITY_THRESHOLD;
 	}
 
 	/**
@@ -101,10 +101,10 @@ 
 	 *
 	 * @return string
 	 */
-	private function cleanDataString( $value ) {
-		$value = $this->stringNormalizer->trimToNFC( $value );
+	private function cleanDataString($value) {
+		$value = $this->stringNormalizer->trimToNFC($value);
 
-		return mb_strtolower( $value );
+		return mb_strtolower($value);
 	}
 
 	/**
@@ -114,10 +114,10 @@ 
 	 *
 	 * @return array
 	 */
-	private function cleanDataArray( array $array ) {
+	private function cleanDataArray(array $array) {
 
 		return array_map(
-			array( $this, 'cleanDataString' ),
+			array($this, 'cleanDataString'),
 			$array );
 	}
 
@@ -129,19 +129,19 @@ 
 	 *
 	 * @return float
 	 */
-	private function percentagePrefixSimilarity( $value, $comparativeValue ) {
+	private function percentagePrefixSimilarity($value, $comparativeValue) {
 		$prefixLength = 0; // common prefix length
-		$localLength = strlen( $value );
-		$externalLength = strlen( $comparativeValue );
-		while ( $prefixLength < min( $localLength, $externalLength ) ) {
+		$localLength = strlen($value);
+		$externalLength = strlen($comparativeValue);
+		while ($prefixLength < min($localLength, $externalLength)) {
 			$c = $value[$prefixLength];
-			if ( $externalLength > $prefixLength && $comparativeValue[$prefixLength] !== $c ) {
+			if ($externalLength > $prefixLength && $comparativeValue[$prefixLength] !== $c) {
 				break;
 			}
 			$prefixLength++;
 		}
 
-		return $prefixLength / max( $localLength, $externalLength );
+		return $prefixLength / max($localLength, $externalLength);
 	}
 
 	/**
@@ -152,19 +152,19 @@ 
 	 *
 	 * @return float
 	 */
-	private function percentageSuffixSimilarity( $value, $comparativeValue ) {
+	private function percentageSuffixSimilarity($value, $comparativeValue) {
 		$suffixLength = 0; // common suffix length
-		$localLength = strlen( $value );
-		$externalLength = strlen( $comparativeValue );
-		while ( $suffixLength < min( $localLength, $externalLength ) ) {
+		$localLength = strlen($value);
+		$externalLength = strlen($comparativeValue);
+		while ($suffixLength < min($localLength, $externalLength)) {
 			$c = $value[$localLength - 1 - $suffixLength];
-			if ( $externalLength > $suffixLength && $comparativeValue[$externalLength - 1 - $suffixLength] !== $c ) {
+			if ($externalLength > $suffixLength && $comparativeValue[$externalLength - 1 - $suffixLength] !== $c) {
 				break;
 			}
 			$suffixLength++;
 		}
 
-		return $suffixLength / max( $localLength, $externalLength );
+		return $suffixLength / max($localLength, $externalLength);
 	}
 
 	/**
@@ -175,9 +175,9 @@ 
 	 *
 	 * @return float
 	 */
-	private function percentageLevenshteinDistance( $value, $comparativeValue ) {
-		$distance = levenshtein( $value, $comparativeValue );
-		$percentage = 1.0 - $distance / max( strlen( $value ), strlen( $comparativeValue ) );
+	private function percentageLevenshteinDistance($value, $comparativeValue) {
+		$distance = levenshtein($value, $comparativeValue);
+		$percentage = 1.0 - $distance / max(strlen($value), strlen($comparativeValue));
 
 		return $percentage;
 	}

includes/CrossCheck/Comparer/StringValueComparer.php

Spacing +6 added lines, -6 removed lines

@@ -21,7 +21,7 @@ 
 	/**
 	 * @param StringComparer $stringComparer
 	 */
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -34,12 +34,12 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
-		return $this->stringComparer->compare( $value->getValue(), $comparativeValue->getValue() );
+		return $this->stringComparer->compare($value->getValue(), $comparativeValue->getValue());
 	}
 
 	/**
@@ -49,7 +49,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof StringValue && $comparativeValue instanceof StringValue;
 	}
 

includes/CrossCheck/Comparer/TimeValueComparer.php

Spacing +23 added lines, -23 removed lines

@@ -30,9 +30,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -42,38 +42,38 @@ 
 
 		$result = ComparisonResult::STATUS_MISMATCH;
 
-		if ( !preg_match( '/^([-+]?)(\d*)((\d{4}\b).*)/', $value->getTime(), $localMatches )
-			|| !preg_match( '/^([-+]?)(\d*)((\d{4}\b).*)/', $comparativeValue->getTime(), $externalMatches )
+		if (!preg_match('/^([-+]?)(\d*)((\d{4}\b).*)/', $value->getTime(), $localMatches)
+			|| !preg_match('/^([-+]?)(\d*)((\d{4}\b).*)/', $comparativeValue->getTime(), $externalMatches)
 		) {
 			return ComparisonResult::STATUS_MISMATCH;
 		}
-		list( , $localSign, $localYearHigh, $localMwTime, $localYearLow ) = $localMatches;
-		list( , $externalSign, $externalYearHigh, $externalMwTime, $externalYearLow ) = $externalMatches;
-		if ( $localSign !== $externalSign && ( $localYearHigh . $localYearLow !== '0000'
-				|| $externalYearHigh . $externalYearLow !== '0000' )
+		list(, $localSign, $localYearHigh, $localMwTime, $localYearLow) = $localMatches;
+		list(, $externalSign, $externalYearHigh, $externalMwTime, $externalYearLow) = $externalMatches;
+		if ($localSign !== $externalSign && ($localYearHigh . $localYearLow !== '0000'
+				|| $externalYearHigh . $externalYearLow !== '0000')
 		) {
 			return ComparisonResult::STATUS_MISMATCH;
 		}
 
 		try {
-			$localTimestamp = new MWTimestamp( $localMwTime );
-			$externalTimestamp = new MWTimestamp( $externalMwTime );
-			$diff = $localTimestamp->diff( $externalTimestamp );
-			$diff->y += abs( $localYearHigh - $externalYearHigh ) * 10000;
+			$localTimestamp = new MWTimestamp($localMwTime);
+			$externalTimestamp = new MWTimestamp($externalMwTime);
+			$diff = $localTimestamp->diff($externalTimestamp);
+			$diff->y += abs($localYearHigh - $externalYearHigh) * 10000;
 
-			if ( $value->getPrecision() === $comparativeValue->getPrecision()
-				&& $this->resultOfDiffWithPrecision( $diff, $value->getPrecision() )
+			if ($value->getPrecision() === $comparativeValue->getPrecision()
+				&& $this->resultOfDiffWithPrecision($diff, $value->getPrecision())
 			) {
 				$result = ComparisonResult::STATUS_MATCH;
 			} elseif (
 				$this->resultOfDiffWithPrecision(
 					$diff,
-					min( $value->getPrecision(), $comparativeValue->getPrecision() )
+					min($value->getPrecision(), $comparativeValue->getPrecision())
 				)
 			) {
 				$result = ComparisonResult::STATUS_PARTIAL_MATCH;
 			}
-		} catch ( TimestampException $ex ) {
+		} catch (TimestampException $ex) {
 		}
 
 		return $result;
@@ -87,10 +87,10 @@ 
 	 *
 	 * @return bool
 	 */
-	private function resultOfDiffWithPrecision( DateInterval $diff, $precision ) {
+	private function resultOfDiffWithPrecision(DateInterval $diff, $precision) {
 		$result = true;
 
-		switch ( $precision ) {
+		switch ($precision) {
 			case TimeValue::PRECISION_SECOND:
 				$result = $diff->s === 0;
 				// Fall through with no break/return. This is critical for this algorithm.
@@ -134,10 +134,10 @@ 
 	 *
 	 * @return ValueParser
 	 */
-	protected function getExternalValueParser( DumpMetaInformation $dumpMetaInformation ) {
+	protected function getExternalValueParser(DumpMetaInformation $dumpMetaInformation) {
 		$parserOptions = new ParserOptions();
-		$parserOptions->setOption( ValueParser::OPT_LANG, $dumpMetaInformation->getLanguageCode() );
-		$timeParserFactory = new TimeParserFactory( $parserOptions );
+		$parserOptions->setOption(ValueParser::OPT_LANG, $dumpMetaInformation->getLanguageCode());
+		$timeParserFactory = new TimeParserFactory($parserOptions);
 
 		return $timeParserFactory->getTimeParser();
 	}
@@ -150,7 +150,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof TimeValue && $comparativeValue instanceof TimeValue;
 	}
 

includes/CrossCheck/CrossChecker.php

Spacing +56 added lines, -56 removed lines

@@ -94,22 +94,22 @@ 
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatements( StatementList $entityStatements, StatementList $statements ) {
+	public function crossCheckStatements(StatementList $entityStatements, StatementList $statements) {
 		$statementsOfEntity = $entityStatements->toArray();
 
-		foreach ( $statements as $statement ) {
-			if ( !in_array( $statement, $statementsOfEntity ) ) {
-				throw new InvalidArgumentException( 'All statements in $statements must belong to the entity.' );
+		foreach ($statements as $statement) {
+			if (!in_array($statement, $statementsOfEntity)) {
+				throw new InvalidArgumentException('All statements in $statements must belong to the entity.');
 			}
 		}
 
 		$resultList = new CrossCheckResultList();
-		if ( $statements->count() > 0 ) {
-			$applicableDumps = $this->getApplicableDumps( $entityStatements );
-			foreach ( $applicableDumps as $identifierPropertyId => $dumpMetaInformationList ) {
-				$identifierPropertyId = new PropertyId( $identifierPropertyId );
+		if ($statements->count() > 0) {
+			$applicableDumps = $this->getApplicableDumps($entityStatements);
+			foreach ($applicableDumps as $identifierPropertyId => $dumpMetaInformationList) {
+				$identifierPropertyId = new PropertyId($identifierPropertyId);
 
-				if( $this->isIdentifierProperty( $identifierPropertyId ) ) {
+				if ($this->isIdentifierProperty($identifierPropertyId)) {
 					$resultList->merge(
 						$this->crossCheckStatementsWithIdentifier(
 							$entityStatements,
@@ -132,17 +132,17 @@ 
 	 *
 	 * @return array[]
 	 */
-	private function getApplicableDumps( StatementList $statements ) {
+	private function getApplicableDumps(StatementList $statements) {
 		$applicableDumps = array();
 		$identifierPropertyIds = $statements->getPropertyIds();
 		$dumpMetaInformation = $this->dumpMetaInformationLookup->getWithIdentifierProperties(
 			$identifierPropertyIds
 		);
 
-		foreach ( $dumpMetaInformation as $dump ) {
-			foreach ( $dump->getIdentifierPropertyIds() as $identifierPropertyId ) {
+		foreach ($dumpMetaInformation as $dump) {
+			foreach ($dump->getIdentifierPropertyIds() as $identifierPropertyId) {
 				$serialization = $identifierPropertyId->getSerialization();
-				$applicableDumps[ $serialization ][ $dump->getDumpId() ] = $dump;
+				$applicableDumps[$serialization][$dump->getDumpId()] = $dump;
 			}
 		}
 
@@ -167,36 +167,36 @@ 
 	) {
 		$resultList = new CrossCheckResultList();
 
-		$externalIds = $this->getExternalIds( $entityStatements, $identifierPropertyId );
-		if( !$externalIds ) {
+		$externalIds = $this->getExternalIds($entityStatements, $identifierPropertyId);
+		if (!$externalIds) {
 			return $resultList;
 		}
 
 		$dumpIds = array_map(
-			function ( DumpMetaInformation $dumpMetaInformation ) {
+			function(DumpMetaInformation $dumpMetaInformation) {
 				return $dumpMetaInformation->getDumpId();
 			},
 			$dumpMetaInformationList
 		);
-		$externalData = $this->externalDataRepo->getExternalData( $dumpIds, $externalIds, $statements->getPropertyIds() );
+		$externalData = $this->externalDataRepo->getExternalData($dumpIds, $externalIds, $statements->getPropertyIds());
 
-		foreach ( $externalData as $dumpId => $externalDataPerDump ) {
-			$dumpMetaInformation = $dumpMetaInformationList[ $dumpId ];
+		foreach ($externalData as $dumpId => $externalDataPerDump) {
+			$dumpMetaInformation = $dumpMetaInformationList[$dumpId];
 			$comparativeValueParser = $this->valueParserFactory->newComparativeValueParser(
 				$dumpMetaInformation->getLanguageCode()
 			);
 
-			foreach ( $externalDataPerDump as $externalId => $externalDataPerId ) {
+			foreach ($externalDataPerDump as $externalId => $externalDataPerId) {
 				$externalId = (string)$externalId;
-				foreach ( $externalDataPerId as $propertyId => $externalValues ) {
-					$propertyId = new PropertyId( $propertyId );
+				foreach ($externalDataPerId as $propertyId => $externalValues) {
+					$propertyId = new PropertyId($propertyId);
 					$resultList->merge(
 						$this->crossCheckExternalValues(
 							$dumpMetaInformation,
 							$identifierPropertyId,
 							$externalId,
 							$externalValues,
-							$statements->getByPropertyId( $propertyId ),
+							$statements->getByPropertyId($propertyId),
 							$comparativeValueParser
 						)
 					);
@@ -226,10 +226,10 @@ 
 		ComparativeValueParser $comparativeValueParser
 	) {
 		$resultList = new CrossCheckResultList();
-		foreach ( $statements as $statement ) {
-			$comparisonResult = $this->compareStatement( $statement, $externalValues, $comparativeValueParser );
+		foreach ($statements as $statement) {
+			$comparisonResult = $this->compareStatement($statement, $externalValues, $comparativeValueParser);
 
-			if ( $comparisonResult ) {
+			if ($comparisonResult) {
 				$referencesResult = $this->referenceHandler->checkForReferences(
 					$statement,
 					$identifierPropertyId,
@@ -263,32 +263,32 @@ 
 	 * @return ComparisonResult|bool
 	 */
 	private function compareStatement(
-		Statement $statement,array $externalValues,
+		Statement $statement, array $externalValues,
 		ComparativeValueParser $comparativeValueParser
 	) {
 		$mainSnak = $statement->getMainSnak();
-		if ( $mainSnak instanceof PropertyValueSnak ) {
+		if ($mainSnak instanceof PropertyValueSnak) {
 			$dataValue = $mainSnak->getDataValue();
 
 			$results = array();
-			$comparativeValues = $this->parseExternalValues( $dataValue, $externalValues, $comparativeValueParser );
-			foreach ( $comparativeValues as $comparativeValue ) {
-				$result = $this->dataValueComparer->compare( $dataValue, $comparativeValue );
-				if( $result ) {
+			$comparativeValues = $this->parseExternalValues($dataValue, $externalValues, $comparativeValueParser);
+			foreach ($comparativeValues as $comparativeValue) {
+				$result = $this->dataValueComparer->compare($dataValue, $comparativeValue);
+				if ($result) {
 					$results[] = $result;
 				}
 			}
 
-			if( $results ) {
+			if ($results) {
 				$result = ComparisonResult::STATUS_MISMATCH;
-				if( in_array( ComparisonResult::STATUS_MATCH, $results ) ) {
+				if (in_array(ComparisonResult::STATUS_MATCH, $results)) {
 					$result = ComparisonResult::STATUS_MATCH;
 				}
-				elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
+				elseif (in_array(ComparisonResult::STATUS_PARTIAL_MATCH, $results)) {
 					$result = ComparisonResult::STATUS_PARTIAL_MATCH;
 				}
 
-				return new ComparisonResult( $dataValue, $comparativeValues, $result );
+				return new ComparisonResult($dataValue, $comparativeValues, $result);
 			}
 		}
 
@@ -308,14 +308,14 @@ 
 		ComparativeValueParser $comparativeValueParser
 	) {
 		$parsedValues = array();
-		foreach ( $externalValues as $externalValue ) {
+		foreach ($externalValues as $externalValue) {
 			try {
-				$parsedValue = $comparativeValueParser->parse( $externalValue, $dataValue->getType() );
-				if( $parsedValue ) {
+				$parsedValue = $comparativeValueParser->parse($externalValue, $dataValue->getType());
+				if ($parsedValue) {
 					$parsedValues[] = $parsedValue;
 				}
 			}
-			catch( ParseException $e ) {}
+			catch (ParseException $e) {}
 		}
 
 		return $parsedValues;
@@ -329,12 +329,12 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function getExternalIds( StatementList $statements, PropertyId $identifierPropertyId ) {
+	private function getExternalIds(StatementList $statements, PropertyId $identifierPropertyId) {
 		$externalIds = array();
-		$identifierStatements = $statements->getByPropertyId( $identifierPropertyId );
-		$values = $this->getDataValues( $identifierStatements );
-		foreach ( $values as $value ) {
-			if ( $value instanceof StringValue ) {
+		$identifierStatements = $statements->getByPropertyId($identifierPropertyId);
+		$values = $this->getDataValues($identifierStatements);
+		foreach ($values as $value) {
+			if ($value instanceof StringValue) {
 				$externalIds[] = $value->getValue();
 			}
 		}
@@ -346,14 +346,14 @@ 
 	 * @param PropertyId $identifierPropertyId
 	 * @return bool
 	 */
-	private function isIdentifierProperty( PropertyId $identifierPropertyId ) {
-		$property = $this->entityLookup->getEntity( $identifierPropertyId );
-		$instanceOfPropertyId = new PropertyId( INSTANCE_OF_PID );
-		$statements = $property->getStatements()->getByPropertyId( $instanceOfPropertyId );
-		$values = $this->getDataValues( $statements );
-		foreach ( $values as $value ) {
-			if( $value instanceof EntityIdValue ) {
-				if( $value->getEntityId()->getSerialization() === IDENTIFIER_PROPERTY_QID ) {
+	private function isIdentifierProperty(PropertyId $identifierPropertyId) {
+		$property = $this->entityLookup->getEntity($identifierPropertyId);
+		$instanceOfPropertyId = new PropertyId(INSTANCE_OF_PID);
+		$statements = $property->getStatements()->getByPropertyId($instanceOfPropertyId);
+		$values = $this->getDataValues($statements);
+		foreach ($values as $value) {
+			if ($value instanceof EntityIdValue) {
+				if ($value->getEntityId()->getSerialization() === IDENTIFIER_PROPERTY_QID) {
 					return true;
 				}
 			}
@@ -368,11 +368,11 @@ 
 	 * @param StatementList $statementList
 	 * @return DataValue[]
 	 */
-	private function getDataValues( StatementList $statementList ){
+	private function getDataValues(StatementList $statementList) {
 		$dataValues = array();
-		foreach ( $statementList as $statement ) {
+		foreach ($statementList as $statement) {
 			$mainSnak = $statement->getMainSnak();
-			if ( $mainSnak instanceof PropertyValueSnak ) {
+			if ($mainSnak instanceof PropertyValueSnak) {
 				$dataValues[] = $mainSnak->getDataValue();
 			}
 		}

Braces +2 added lines, -4 removed lines

@@ -283,8 +283,7 @@ 
 				$result = ComparisonResult::STATUS_MISMATCH;
 				if( in_array( ComparisonResult::STATUS_MATCH, $results ) ) {
 					$result = ComparisonResult::STATUS_MATCH;
-				}
-				elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
+				} elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
 					$result = ComparisonResult::STATUS_PARTIAL_MATCH;
 				}
 
@@ -314,8 +313,7 @@ 
 				if( $parsedValue ) {
 					$parsedValues[] = $parsedValue;
 				}
-			}
-			catch( ParseException $e ) {}
+			} catch( ParseException $e ) {}
 		}
 
 		return $parsedValues;

includes/CrossCheck/ReferenceChecker.php

Spacing +9 added lines, -9 removed lines

@@ -34,17 +34,17 @@ 
 	 * @throws InvalidArgumentException
 	 * @return ReferenceResult
 	 */
-	public function checkForReferences( Statement $statement, PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation ) {
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+	public function checkForReferences(Statement $statement, PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation) {
+		Assert::parameterType('string', $externalId, '$externalId');
 
-		if ( count( $statement->getReferences() ) === 0 ) {
+		if (count($statement->getReferences()) === 0) {
 			$status = ReferenceResult::STATUS_REFERENCES_MISSING;
 		} else {
 			$status = ReferenceResult::STATUS_REFERENCES_STATED;
 		}
 
-		$externalReference = $this->buildReference( $identifierPropertyId, $externalId, $dumpMetaInformation );
-		return new ReferenceResult( $status, $externalReference );
+		$externalReference = $this->buildReference($identifierPropertyId, $externalId, $dumpMetaInformation);
+		return new ReferenceResult($status, $externalReference);
 	}
 
 	/**
@@ -55,15 +55,15 @@ 
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 * @return Reference
 	 */
-	private function buildReference( PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation ) {
+	private function buildReference(PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation) {
 		$sourceItemId = $dumpMetaInformation->getSourceItemId();
 		$statedInAuthoritySnak = new PropertyValueSnak(
-			new PropertyId( STATED_IN_PID ),
-			new EntityIdValue( $sourceItemId )
+			new PropertyId(STATED_IN_PID),
+			new EntityIdValue($sourceItemId)
 		);
 		$authorityWithExternalIdSnak = new PropertyValueSnak(
 			$identifierPropertyId,
-			new StringValue( $externalId )
+			new StringValue($externalId)
 		);
 
 		return new Reference(

includes/CrossCheck/Result/ComparisonResult.php

Spacing +8 added lines, -8 removed lines

@@ -45,12 +45,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( DataValue $localValue, array $externalValues, $status ) {
-		Assert::parameterElementType( 'DataValues\DataValue', $externalValues, '$externalValues' );
+	public function __construct(DataValue $localValue, array $externalValues, $status) {
+		Assert::parameterElementType('DataValues\DataValue', $externalValues, '$externalValues');
 
 		$this->localValue = $localValue;
 		$this->externalValues = $externalValues;
-		$this->setStatus( $status );
+		$this->setStatus($status);
 	}
 
 	/**
@@ -79,14 +79,14 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setStatus( $status ) {
-		Assert::parameterType( 'string', $status, '$status' );
-		if ( !in_array(
+	private function setStatus($status) {
+		Assert::parameterType('string', $status, '$status');
+		if (!in_array(
 			$status,
-			array( self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH )
+			array(self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH)
 		)
 		) {
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
+			throw new InvalidArgumentException('$status must be one of the status constants.');
 		}
 
 		$this->status = $status;