Inspection of "Merge "Replace all remaining usages of Entity with..." - wikimedia/mediawiki-extensions-WikibaseQualityExternalValidation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0a2cc0...5b2625 )

unknown

created 2016-03-03 15:24 UTC

Status

Spacing +62 added lines, -62 removed lines patch added patch discarded remove patch

@@ -43,7 +43,7 @@  discard block
 block discarded – undo
 	 * @param StatementGuidParser $statementGuidParser
 	 * @param CrossChecker $crossChecker
 	 */
-	public function __construct( EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker ) {
+	public function __construct(EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker) {
 		$this->entityLookup = $entityLookup;
 		$this->statementGuidParser = $statementGuidParser;
 		$this->crossChecker = $crossChecker;
@@ -56,11 +56,11 @@  discard block
 block discarded – undo
 	 *
 	 * @return CrossCheckResultList|null
 	 */
-	public function crossCheckEntityById( EntityId $entityId ) {
-		$entity = $this->entityLookup->getEntity( $entityId );
+	public function crossCheckEntityById(EntityId $entityId) {
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
-			return $this->crossCheckStatements( $entity->getStatements() );
+		if ($entity instanceof StatementListProvider) {
+			return $this->crossCheckStatements($entity->getStatements());
 		}
 
 		return null;
@@ -73,12 +73,12 @@  discard block
 block discarded – undo
 	 *
 	 * @return CrossCheckResultList[]
 	 */
-	public function crossCheckEntitiesByIds( array $entityIds ) {
-		Assert::parameterElementType( 'Wikibase\DataModel\Entity\EntityId',  $entityIds, '$entityIds' );
+	public function crossCheckEntitiesByIds(array $entityIds) {
+		Assert::parameterElementType('Wikibase\DataModel\Entity\EntityId', $entityIds, '$entityIds');
 
 		$results = array();
-		foreach ( $entityIds as $entityId ) {
-			$results[$entityId->getSerialization()] = $this->crossCheckEntityById( $entityId );
+		foreach ($entityIds as $entityId) {
+			$results[$entityId->getSerialization()] = $this->crossCheckEntityById($entityId);
 		}
 
 		return $results;
@@ -91,8 +91,8 @@  discard block
 block discarded – undo
 	 *
 	 * @return CrossCheckResultList
 	 */
-	public function crossCheckStatements( StatementList $statements ) {
-		return $this->crossChecker->crossCheckStatements( $statements, $statements );
+	public function crossCheckStatements(StatementList $statements) {
+		return $this->crossChecker->crossCheckStatements($statements, $statements);
 	}
 
 	/**
@@ -103,14 +103,14 @@  discard block
 block discarded – undo
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntities( array $entities ) {
-		Assert::parameterElementType( 'Wikibase\DataModel\Entity\EntityDocument',  $entities, '$entities' );
+	public function crossCheckEntities(array $entities) {
+		Assert::parameterElementType('Wikibase\DataModel\Entity\EntityDocument', $entities, '$entities');
 
 		$results = array();
-		foreach ( $entities as $entity ) {
+		foreach ($entities as $entity) {
 			$entityId = $entity->getId()->getSerialization();
-			if ( $entity instanceof StatementListProvider ) {
-				$results[$entityId] = $this->crossCheckStatements( $entity->getStatements() );
+			if ($entity instanceof StatementListProvider) {
+				$results[$entityId] = $this->crossCheckStatements($entity->getStatements());
 			}
 		}
 
@@ -126,13 +126,13 @@  discard block
 block discarded – undo
 	 * @return CrossCheckResultList|null
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntityByIdWithProperties( EntityId $entityId, array $propertyIds ) {
-		Assert::parameterElementType( 'Wikibase\DataModel\Entity\PropertyId',  $propertyIds, '$propertyIds' );
+	public function crossCheckEntityByIdWithProperties(EntityId $entityId, array $propertyIds) {
+		Assert::parameterElementType('Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds');
 
-		$entity = $this->entityLookup->getEntity( $entityId );
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
-			return $this->crossCheckStatementsWithProperties( $entity->getStatements(), $propertyIds );
+		if ($entity instanceof StatementListProvider) {
+			return $this->crossCheckStatementsWithProperties($entity->getStatements(), $propertyIds);
 		}
 
 		return null;
@@ -147,13 +147,13 @@  discard block
 block discarded – undo
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntitiesByIdWithProperties( array $entityIds, array $propertyIds ) {
-		Assert::parameterElementType( 'Wikibase\DataModel\Entity\EntityId',  $entityIds, '$entityIds' );
-		Assert::parameterElementType( 'Wikibase\DataModel\Entity\PropertyId',  $propertyIds, '$propertyIds' );
+	public function crossCheckEntitiesByIdWithProperties(array $entityIds, array $propertyIds) {
+		Assert::parameterElementType('Wikibase\DataModel\Entity\EntityId', $entityIds, '$entityIds');
+		Assert::parameterElementType('Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds');
 
 		$results = array();
-		foreach ( $entityIds as $entityId ) {
-			$results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties( $entityId, $propertyIds );
+		foreach ($entityIds as $entityId) {
+			$results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties($entityId, $propertyIds);
 		}
 
 		return $results;
@@ -168,17 +168,17 @@  discard block
 block discarded – undo
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementsWithProperties( StatementList $entityStatements, array $propertyIds ) {
-		Assert::parameterElementType( 'Wikibase\DataModel\Entity\PropertyId',  $propertyIds, '$propertyIds' );
+	public function crossCheckStatementsWithProperties(StatementList $entityStatements, array $propertyIds) {
+		Assert::parameterElementType('Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds');
 
 		$statements = new StatementList();
-		foreach ( $entityStatements->toArray() as $statement ) {
-			if ( in_array( $statement->getPropertyId(), $propertyIds ) ) {
-				$statements->addStatement( $statement );
+		foreach ($entityStatements->toArray() as $statement) {
+			if (in_array($statement->getPropertyId(), $propertyIds)) {
+				$statements->addStatement($statement);
 			}
 		}
 
-		return $this->crossChecker->crossCheckStatements( $entityStatements, $statements );
+		return $this->crossChecker->crossCheckStatements($entityStatements, $statements);
 	}
 
 	/**
@@ -190,14 +190,14 @@  discard block
 block discarded – undo
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntitiesWithProperties( array $entities, array $propertyIds ) {
-		Assert::parameterElementType( 'Wikibase\DataModel\Entity\EntityDocument',  $entities, '$entities' );
-		Assert::parameterElementType( 'Wikibase\DataModel\Entity\PropertyId',  $propertyIds, '$propertyIds' );
+	public function crossCheckEntitiesWithProperties(array $entities, array $propertyIds) {
+		Assert::parameterElementType('Wikibase\DataModel\Entity\EntityDocument', $entities, '$entities');
+		Assert::parameterElementType('Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds');
 
 		$results = array();
-		foreach ( $entities as $entity ) {
+		foreach ($entities as $entity) {
 			$entityId = $entity->getId()->getSerialization();
-			if ( $entity instanceof StatementListProvider ) {
+			if ($entity instanceof StatementListProvider) {
 				$results[$entityId] = $this->crossCheckStatementsWithProperties(
 					$entity->getStatements(),
 					$propertyIds
@@ -216,12 +216,12 @@  discard block
 block discarded – undo
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementByGuid( $guid ) {
-		$this->assertIsString( $guid, '$guid' );
+	public function crossCheckStatementByGuid($guid) {
+		$this->assertIsString($guid, '$guid');
 
-		$resultList = $this->crossCheckStatementsByGuids( array( $guid ) );
+		$resultList = $this->crossCheckStatementsByGuids(array($guid));
 
-		return reset( $resultList );
+		return reset($resultList);
 	}
 
 	/**
@@ -232,21 +232,21 @@  discard block
 block discarded – undo
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementsByGuids( array $guids ) {
-		$this->assertIsArrayOfStrings( $guids, '$guids' );
+	public function crossCheckStatementsByGuids(array $guids) {
+		$this->assertIsArrayOfStrings($guids, '$guids');
 
 		$entityIds = array();
 		$groupedStatementGuids = array();
-		foreach ( $guids as $guid ) {
-			$serializedEntityId = $this->statementGuidParser->parse( $guid )->getEntityId();
+		foreach ($guids as $guid) {
+			$serializedEntityId = $this->statementGuidParser->parse($guid)->getEntityId();
 			$entityIds[$serializedEntityId->getSerialization()] = $serializedEntityId;
 			$groupedStatementGuids[$serializedEntityId->getSerialization()][] = $guid;
 		}
 
 		$resultLists = array();
-		foreach ( $groupedStatementGuids as $serializedEntityId => $guidsOfEntity ) {
-			$entityId = $entityIds[ $serializedEntityId ];
-			$resultLists[ $serializedEntityId ] = $this->crossCheckClaimsOfEntity( $entityId, $guidsOfEntity );
+		foreach ($groupedStatementGuids as $serializedEntityId => $guidsOfEntity) {
+			$entityId = $entityIds[$serializedEntityId];
+			$resultLists[$serializedEntityId] = $this->crossCheckClaimsOfEntity($entityId, $guidsOfEntity);
 		}
 
 		return $resultLists;
@@ -258,18 +258,18 @@  discard block
 block discarded – undo
 	 *
 	 * @return CrossCheckResultList|null
 	 */
-	private function crossCheckClaimsOfEntity( EntityId $entityId, array $guids ) {
-		$entity = $this->entityLookup->getEntity( $entityId );
+	private function crossCheckClaimsOfEntity(EntityId $entityId, array $guids) {
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
+		if ($entity instanceof StatementListProvider) {
 			$statements = new StatementList();
-			foreach ( $entity->getStatements()->toArray() as $statement ) {
-				if ( in_array( $statement->getGuid(), $guids ) ) {
-					$statements->addStatement( $statement );
+			foreach ($entity->getStatements()->toArray() as $statement) {
+				if (in_array($statement->getGuid(), $guids)) {
+					$statements->addStatement($statement);
 				}
 			}
 
-			return $this->crossChecker->crossCheckStatements( $entity->getStatements(), $statements );
+			return $this->crossChecker->crossCheckStatements($entity->getStatements(), $statements);
 		}
 
 		return null;
@@ -281,9 +281,9 @@  discard block
 block discarded – undo
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function assertIsString( $string, $parameterName ) {
-		if ( !is_string( $string ) ) {
-			throw new InvalidArgumentException( "$parameterName must be string." );
+	private function assertIsString($string, $parameterName) {
+		if (!is_string($string)) {
+			throw new InvalidArgumentException("$parameterName must be string.");
 		}
 	}
 
@@ -293,10 +293,10 @@  discard block
 block discarded – undo
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function assertIsArrayOfStrings( array $strings, $parameterName ) {
-		foreach ( $strings as $string ) {
-			if ( !is_string( $string ) ) {
-				throw new InvalidArgumentException( "Each element of $parameterName must be string." );
+	private function assertIsArrayOfStrings(array $strings, $parameterName) {
+		foreach ($strings as $string) {
+			if (!is_string($string)) {
+				throw new InvalidArgumentException("Each element of $parameterName must be string.");
 			}
 		}
 	}

Please login to merge, or discard this patch.

		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	* @param StatementGuidParser $statementGuidParser
44	44	* @param CrossChecker $crossChecker
45	45	*/
46		- public function __construct( EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker ) {
	46	+ public function __construct(EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker) {
47	47	$this->entityLookup = $entityLookup;
48	48	$this->statementGuidParser = $statementGuidParser;
49	49	$this->crossChecker = $crossChecker;
		@@ -56,11 +56,11 @@ discard block
		block discarded – undo
56	56	*
57	57	* @return CrossCheckResultList\|null
58	58	*/
59		- public function crossCheckEntityById( EntityId $entityId ) {
60		- $entity = $this->entityLookup->getEntity( $entityId );
	59	+ public function crossCheckEntityById(EntityId $entityId) {
	60	+ $entity = $this->entityLookup->getEntity($entityId);
61	61
62		- if ( $entity instanceof StatementListProvider ) {
63		- return $this->crossCheckStatements( $entity->getStatements() );
	62	+ if ($entity instanceof StatementListProvider) {
	63	+ return $this->crossCheckStatements($entity->getStatements());
64	64	}
65	65
66	66	return null;
		@@ -73,12 +73,12 @@ discard block
		block discarded – undo
73	73	*
74	74	* @return CrossCheckResultList[]
75	75	*/
76		- public function crossCheckEntitiesByIds( array $entityIds ) {
77		- Assert::parameterElementType( 'Wikibase\DataModel\Entity\EntityId', $entityIds, '$entityIds' );
	76	+ public function crossCheckEntitiesByIds(array $entityIds) {
	77	+ Assert::parameterElementType('Wikibase\DataModel\Entity\EntityId', $entityIds, '$entityIds');
78	78
79	79	$results = array();
80		- foreach ( $entityIds as $entityId ) {
81		- $results[$entityId->getSerialization()] = $this->crossCheckEntityById( $entityId );
	80	+ foreach ($entityIds as $entityId) {
	81	+ $results[$entityId->getSerialization()] = $this->crossCheckEntityById($entityId);
82	82	}
83	83
84	84	return $results;
		@@ -91,8 +91,8 @@ discard block
		block discarded – undo
91	91	*
92	92	* @return CrossCheckResultList
93	93	*/
94		- public function crossCheckStatements( StatementList $statements ) {
95		- return $this->crossChecker->crossCheckStatements( $statements, $statements );
	94	+ public function crossCheckStatements(StatementList $statements) {
	95	+ return $this->crossChecker->crossCheckStatements($statements, $statements);
96	96	}
97	97
98	98	/**
		@@ -103,14 +103,14 @@ discard block
		block discarded – undo
103	103	* @return CrossCheckResultList[]
104	104	* @throws InvalidArgumentException
105	105	*/
106		- public function crossCheckEntities( array $entities ) {
107		- Assert::parameterElementType( 'Wikibase\DataModel\Entity\EntityDocument', $entities, '$entities' );
	106	+ public function crossCheckEntities(array $entities) {
	107	+ Assert::parameterElementType('Wikibase\DataModel\Entity\EntityDocument', $entities, '$entities');
108	108
109	109	$results = array();
110		- foreach ( $entities as $entity ) {
	110	+ foreach ($entities as $entity) {
111	111	$entityId = $entity->getId()->getSerialization();
112		- if ( $entity instanceof StatementListProvider ) {
113		- $results[$entityId] = $this->crossCheckStatements( $entity->getStatements() );
	112	+ if ($entity instanceof StatementListProvider) {
	113	+ $results[$entityId] = $this->crossCheckStatements($entity->getStatements());
114	114	}
115	115	}
116	116
		@@ -126,13 +126,13 @@ discard block
		block discarded – undo
126	126	* @return CrossCheckResultList\|null
127	127	* @throws InvalidArgumentException
128	128	*/
129		- public function crossCheckEntityByIdWithProperties( EntityId $entityId, array $propertyIds ) {
130		- Assert::parameterElementType( 'Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds' );
	129	+ public function crossCheckEntityByIdWithProperties(EntityId $entityId, array $propertyIds) {
	130	+ Assert::parameterElementType('Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds');
131	131
132		- $entity = $this->entityLookup->getEntity( $entityId );
	132	+ $entity = $this->entityLookup->getEntity($entityId);
133	133
134		- if ( $entity instanceof StatementListProvider ) {
135		- return $this->crossCheckStatementsWithProperties( $entity->getStatements(), $propertyIds );
	134	+ if ($entity instanceof StatementListProvider) {
	135	+ return $this->crossCheckStatementsWithProperties($entity->getStatements(), $propertyIds);
136	136	}
137	137
138	138	return null;
		@@ -147,13 +147,13 @@ discard block
		block discarded – undo
147	147	* @return CrossCheckResultList[]
148	148	* @throws InvalidArgumentException
149	149	*/
150		- public function crossCheckEntitiesByIdWithProperties( array $entityIds, array $propertyIds ) {
151		- Assert::parameterElementType( 'Wikibase\DataModel\Entity\EntityId', $entityIds, '$entityIds' );
152		- Assert::parameterElementType( 'Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds' );
	150	+ public function crossCheckEntitiesByIdWithProperties(array $entityIds, array $propertyIds) {
	151	+ Assert::parameterElementType('Wikibase\DataModel\Entity\EntityId', $entityIds, '$entityIds');
	152	+ Assert::parameterElementType('Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds');
153	153
154	154	$results = array();
155		- foreach ( $entityIds as $entityId ) {
156		- $results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties( $entityId, $propertyIds );
	155	+ foreach ($entityIds as $entityId) {
	156	+ $results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties($entityId, $propertyIds);
157	157	}
158	158
159	159	return $results;
		@@ -168,17 +168,17 @@ discard block
		block discarded – undo
168	168	* @return CrossCheckResultList
169	169	* @throws InvalidArgumentException
170	170	*/
171		- public function crossCheckStatementsWithProperties( StatementList $entityStatements, array $propertyIds ) {
172		- Assert::parameterElementType( 'Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds' );
	171	+ public function crossCheckStatementsWithProperties(StatementList $entityStatements, array $propertyIds) {
	172	+ Assert::parameterElementType('Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds');
173	173
174	174	$statements = new StatementList();
175		- foreach ( $entityStatements->toArray() as $statement ) {
176		- if ( in_array( $statement->getPropertyId(), $propertyIds ) ) {
177		- $statements->addStatement( $statement );
	175	+ foreach ($entityStatements->toArray() as $statement) {
	176	+ if (in_array($statement->getPropertyId(), $propertyIds)) {
	177	+ $statements->addStatement($statement);
178	178	}
179	179	}
180	180
181		- return $this->crossChecker->crossCheckStatements( $entityStatements, $statements );
	181	+ return $this->crossChecker->crossCheckStatements($entityStatements, $statements);
182	182	}
183	183
184	184	/**
		@@ -190,14 +190,14 @@ discard block
		block discarded – undo
190	190	* @return CrossCheckResultList[]
191	191	* @throws InvalidArgumentException
192	192	*/
193		- public function crossCheckEntitiesWithProperties( array $entities, array $propertyIds ) {
194		- Assert::parameterElementType( 'Wikibase\DataModel\Entity\EntityDocument', $entities, '$entities' );
195		- Assert::parameterElementType( 'Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds' );
	193	+ public function crossCheckEntitiesWithProperties(array $entities, array $propertyIds) {
	194	+ Assert::parameterElementType('Wikibase\DataModel\Entity\EntityDocument', $entities, '$entities');
	195	+ Assert::parameterElementType('Wikibase\DataModel\Entity\PropertyId', $propertyIds, '$propertyIds');
196	196
197	197	$results = array();
198		- foreach ( $entities as $entity ) {
	198	+ foreach ($entities as $entity) {
199	199	$entityId = $entity->getId()->getSerialization();
200		- if ( $entity instanceof StatementListProvider ) {
	200	+ if ($entity instanceof StatementListProvider) {
201	201	$results[$entityId] = $this->crossCheckStatementsWithProperties(
202	202	$entity->getStatements(),
203	203	$propertyIds
		@@ -216,12 +216,12 @@ discard block
		block discarded – undo
216	216	* @return CrossCheckResultList
217	217	* @throws InvalidArgumentException
218	218	*/
219		- public function crossCheckStatementByGuid( $guid ) {
220		- $this->assertIsString( $guid, '$guid' );
	219	+ public function crossCheckStatementByGuid($guid) {
	220	+ $this->assertIsString($guid, '$guid');
221	221
222		- $resultList = $this->crossCheckStatementsByGuids( array( $guid ) );
	222	+ $resultList = $this->crossCheckStatementsByGuids(array($guid));
223	223
224		- return reset( $resultList );
	224	+ return reset($resultList);
225	225	}
226	226
227	227	/**
		@@ -232,21 +232,21 @@ discard block
		block discarded – undo
232	232	* @return CrossCheckResultList[]
233	233	* @throws InvalidArgumentException
234	234	*/
235		- public function crossCheckStatementsByGuids( array $guids ) {
236		- $this->assertIsArrayOfStrings( $guids, '$guids' );
	235	+ public function crossCheckStatementsByGuids(array $guids) {
	236	+ $this->assertIsArrayOfStrings($guids, '$guids');
237	237
238	238	$entityIds = array();
239	239	$groupedStatementGuids = array();
240		- foreach ( $guids as $guid ) {
241		- $serializedEntityId = $this->statementGuidParser->parse( $guid )->getEntityId();
	240	+ foreach ($guids as $guid) {
	241	+ $serializedEntityId = $this->statementGuidParser->parse($guid)->getEntityId();
242	242	$entityIds[$serializedEntityId->getSerialization()] = $serializedEntityId;
243	243	$groupedStatementGuids[$serializedEntityId->getSerialization()][] = $guid;
244	244	}
245	245
246	246	$resultLists = array();
247		- foreach ( $groupedStatementGuids as $serializedEntityId => $guidsOfEntity ) {
248		- $entityId = $entityIds[ $serializedEntityId ];
249		- $resultLists[ $serializedEntityId ] = $this->crossCheckClaimsOfEntity( $entityId, $guidsOfEntity );
	247	+ foreach ($groupedStatementGuids as $serializedEntityId => $guidsOfEntity) {
	248	+ $entityId = $entityIds[$serializedEntityId];
	249	+ $resultLists[$serializedEntityId] = $this->crossCheckClaimsOfEntity($entityId, $guidsOfEntity);
250	250	}
251	251
252	252	return $resultLists;
		@@ -258,18 +258,18 @@ discard block
		block discarded – undo
258	258	*
259	259	* @return CrossCheckResultList\|null
260	260	*/
261		- private function crossCheckClaimsOfEntity( EntityId $entityId, array $guids ) {
262		- $entity = $this->entityLookup->getEntity( $entityId );
	261	+ private function crossCheckClaimsOfEntity(EntityId $entityId, array $guids) {
	262	+ $entity = $this->entityLookup->getEntity($entityId);
263	263
264		- if ( $entity instanceof StatementListProvider ) {
	264	+ if ($entity instanceof StatementListProvider) {
265	265	$statements = new StatementList();
266		- foreach ( $entity->getStatements()->toArray() as $statement ) {
267		- if ( in_array( $statement->getGuid(), $guids ) ) {
268		- $statements->addStatement( $statement );
	266	+ foreach ($entity->getStatements()->toArray() as $statement) {
	267	+ if (in_array($statement->getGuid(), $guids)) {
	268	+ $statements->addStatement($statement);
269	269	}
270	270	}
271	271
272		- return $this->crossChecker->crossCheckStatements( $entity->getStatements(), $statements );
	272	+ return $this->crossChecker->crossCheckStatements($entity->getStatements(), $statements);
273	273	}
274	274
275	275	return null;
		@@ -281,9 +281,9 @@ discard block
		block discarded – undo
281	281	*
282	282	* @throws InvalidArgumentException
283	283	*/
284		- private function assertIsString( $string, $parameterName ) {
285		- if ( !is_string( $string ) ) {
286		- throw new InvalidArgumentException( "$parameterName must be string." );
	284	+ private function assertIsString($string, $parameterName) {
	285	+ if (!is_string($string)) {
	286	+ throw new InvalidArgumentException("$parameterName must be string.");
287	287	}
288	288	}
289	289
		@@ -293,10 +293,10 @@ discard block
		block discarded – undo
293	293	*
294	294	* @throws InvalidArgumentException
295	295	*/
296		- private function assertIsArrayOfStrings( array $strings, $parameterName ) {
297		- foreach ( $strings as $string ) {
298		- if ( !is_string( $string ) ) {
299		- throw new InvalidArgumentException( "Each element of $parameterName must be string." );
	296	+ private function assertIsArrayOfStrings(array $strings, $parameterName) {
	297	+ foreach ($strings as $string) {
	298	+ if (!is_string($string)) {
	299	+ throw new InvalidArgumentException("Each element of $parameterName must be string.");
300	300	}
301	301	}
302	302	}

wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

Push — master ( 0a2cc0...5b2625 )

Status

Category

Spacing +62 added lines, -62 removed lines patch added patch discarded remove patch