Completed
Push — master ( 245134...8bf143 )
by
unknown
02:54
created
specials/SpecialCrossCheck.php 1 patch
Spacing   +99 added lines, -99 removed lines patch added patch discarded remove patch
@@ -103,18 +103,18 @@  discard block
 block discarded – undo
103 103
 		OutputFormatValueFormatterFactory $valueFormatterFactory,
104 104
 		CrossCheckInteractor $crossCheckInteractor
105 105
 	) {
106
-		parent::__construct( 'CrossCheck' );
106
+		parent::__construct('CrossCheck');
107 107
 
108 108
 		$this->entityLookup = $entityLookup;
109 109
 		$this->entityIdParser = $entityIdParser;
110 110
 
111 111
 		$formatterOptions = new FormatterOptions();
112
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $this->getLanguage()->getCode() );
113
-		$this->dataValueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions );
112
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $this->getLanguage()->getCode());
113
+		$this->dataValueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions);
114 114
 
115
-		$labelLookup = new LanguageLabelDescriptionLookup( $termLookup, $this->getLanguage()->getCode() );
116
-		$this->entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $labelLookup );
117
-		$this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $labelLookup );
115
+		$labelLookup = new LanguageLabelDescriptionLookup($termLookup, $this->getLanguage()->getCode());
116
+		$this->entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($labelLookup);
117
+		$this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($labelLookup);
118 118
 
119 119
 		$this->crossCheckInteractor = $crossCheckInteractor;
120 120
 	}
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	 * @return string (plain text)
135 135
 	 */
136 136
 	public function getDescription() {
137
-		return $this->msg( 'wbqev-crosscheck' )->text();
137
+		return $this->msg('wbqev-crosscheck')->text();
138 138
 	}
139 139
 
140 140
 	/**
@@ -146,55 +146,55 @@  discard block
 block discarded – undo
146 146
 	 * @throws EntityIdParsingException
147 147
 	 * @throws UnexpectedValueException
148 148
 	 */
149
-	public function execute( $subPage ) {
149
+	public function execute($subPage) {
150 150
 		$out = $this->getOutput();
151
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
152
-		if ( $postRequest ) {
153
-			$out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() );
151
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
152
+		if ($postRequest) {
153
+			$out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL());
154 154
 			return;
155 155
 		}
156 156
 
157
-		$out->addModules( 'SpecialCrossCheckPage' );
157
+		$out->addModules('SpecialCrossCheckPage');
158 158
 
159 159
 		$this->setHeaders();
160 160
 
161
-		$out->addHTML( $this->buildInfoBox() );
161
+		$out->addHTML($this->buildInfoBox());
162 162
 		$this->buildEntityIdForm();
163 163
 
164
-		if ( $subPage ) {
165
-			$this->buildResult( $subPage );
164
+		if ($subPage) {
165
+			$this->buildResult($subPage);
166 166
 		}
167 167
 	}
168 168
 
169 169
 	/**
170 170
 	 * @param string $idSerialization
171 171
 	 */
172
-	private function buildResult( $idSerialization ) {
172
+	private function buildResult($idSerialization) {
173 173
 		$out = $this->getOutput();
174 174
 
175 175
 		try {
176
-			$entityId = $this->entityIdParser->parse( $idSerialization );
177
-		} catch ( EntityIdParsingException $ex ) {
178
-			$out->addHTML( $this->buildNotice( 'wbqev-crosscheck-invalid-entity-id', true ) );
176
+			$entityId = $this->entityIdParser->parse($idSerialization);
177
+		} catch (EntityIdParsingException $ex) {
178
+			$out->addHTML($this->buildNotice('wbqev-crosscheck-invalid-entity-id', true));
179 179
 			return;
180 180
 		}
181 181
 
182
-		$out->addHTML( $this->buildResultHeader( $entityId ) );
182
+		$out->addHTML($this->buildResultHeader($entityId));
183 183
 
184
-		$entity = $this->entityLookup->getEntity( $entityId );
185
-		if ( $entity === null ) {
186
-			$out->addHTML( $this->buildNotice( 'wbqev-crosscheck-not-existent-entity', true ) );
184
+		$entity = $this->entityLookup->getEntity($entityId);
185
+		if ($entity === null) {
186
+			$out->addHTML($this->buildNotice('wbqev-crosscheck-not-existent-entity', true));
187 187
 			return;
188 188
 		}
189 189
 
190
-		$results = $this->getCrossCheckResultsFromEntity( $entity );
190
+		$results = $this->getCrossCheckResultsFromEntity($entity);
191 191
 
192
-		if ( $results === null || $results->toArray() === [] ) {
193
-			$out->addHTML( $this->buildNotice( 'wbqev-crosscheck-empty-result' ) );
192
+		if ($results === null || $results->toArray() === []) {
193
+			$out->addHTML($this->buildNotice('wbqev-crosscheck-empty-result'));
194 194
 		} else {
195 195
 			$out->addHTML(
196
-				$this->buildSummary( $results )
197
-				. $this->buildResultTable( $results )
196
+				$this->buildSummary($results)
197
+				. $this->buildResultTable($results)
198 198
 			);
199 199
 		}
200 200
 	}
@@ -204,9 +204,9 @@  discard block
 block discarded – undo
204 204
 	 *
205 205
 	 * @return CrossCheckResultList|null
206 206
 	 */
207
-	private function getCrossCheckResultsFromEntity( EntityDocument $entity ) {
208
-		if ( $entity instanceof StatementListProvider ) {
209
-			return $this->crossCheckInteractor->crossCheckStatements( $entity->getStatements() );
207
+	private function getCrossCheckResultsFromEntity(EntityDocument $entity) {
208
+		if ($entity instanceof StatementListProvider) {
209
+			return $this->crossCheckInteractor->crossCheckStatements($entity->getStatements());
210 210
 		}
211 211
 
212 212
 		return null;
@@ -223,15 +223,15 @@  discard block
 block discarded – undo
223 223
 				'name' => 'entityid',
224 224
 				'label-message' => 'wbqev-crosscheck-form-entityid-label',
225 225
 				'cssclass' => 'wbqev-crosscheck-form-entity-id',
226
-				'placeholder' => $this->msg( 'wbqev-crosscheck-form-entityid-placeholder' )->escaped()
226
+				'placeholder' => $this->msg('wbqev-crosscheck-form-entityid-placeholder')->escaped()
227 227
 			]
228 228
 		];
229
-		$htmlForm = new HTMLForm( $formDescriptor, $this->getContext(), 'wbqev-crosscheck-form' );
230
-		$htmlForm->setSubmitText( $this->msg( 'wbqev-crosscheck-form-submit-label' )->escaped() );
231
-		$htmlForm->setSubmitCallback( function() {
229
+		$htmlForm = new HTMLForm($formDescriptor, $this->getContext(), 'wbqev-crosscheck-form');
230
+		$htmlForm->setSubmitText($this->msg('wbqev-crosscheck-form-submit-label')->escaped());
231
+		$htmlForm->setSubmitCallback(function() {
232 232
 			return false;
233 233
 		} );
234
-		$htmlForm->setMethod( 'post' );
234
+		$htmlForm->setMethod('post');
235 235
 		$htmlForm->show();
236 236
 	}
237 237
 
@@ -241,18 +241,18 @@  discard block
 block discarded – undo
241 241
 	 * @return string HTML
242 242
 	 */
243 243
 	private function buildInfoBox() {
244
-		$externalDbLink = Linker::specialLink( 'ExternalDatabases', 'wbqev-externaldbs' );
244
+		$externalDbLink = Linker::specialLink('ExternalDatabases', 'wbqev-externaldbs');
245 245
 		$infoBox =
246 246
 			Html::openElement(
247 247
 				'div',
248
-				[ 'class' => 'wbqev-infobox' ]
248
+				['class' => 'wbqev-infobox']
249 249
 			)
250
-			. $this->msg( 'wbqev-crosscheck-explanation-general' )->parse()
251
-			. sprintf( ' %s.', $externalDbLink )
252
-			. Html::element( 'br' )
253
-			. Html::element( 'br' )
254
-			. $this->msg( 'wbqev-crosscheck-explanation-detail' )->parse()
255
-			. Html::closeElement( 'div' );
250
+			. $this->msg('wbqev-crosscheck-explanation-general')->parse()
251
+			. sprintf(' %s.', $externalDbLink)
252
+			. Html::element('br')
253
+			. Html::element('br')
254
+			. $this->msg('wbqev-crosscheck-explanation-detail')->parse()
255
+			. Html::closeElement('div');
256 256
 
257 257
 		return $infoBox;
258 258
 	}
@@ -267,17 +267,17 @@  discard block
 block discarded – undo
267 267
 	 *
268 268
 	 * @return string HTML
269 269
 	 */
270
-	private function buildNotice( $messageKey, $error = false ) {
270
+	private function buildNotice($messageKey, $error = false) {
271 271
 		$cssClasses = 'wbqev-crosscheck-notice';
272
-		if ( $error ) {
272
+		if ($error) {
273 273
 			$cssClasses .= ' wbqev-crosscheck-notice-error';
274 274
 		}
275 275
 
276 276
 		return
277 277
 			Html::element(
278 278
 				'p',
279
-				[ 'class' => $cssClasses ],
280
-				$this->msg( $messageKey )->text()
279
+				['class' => $cssClasses],
280
+				$this->msg($messageKey)->text()
281 281
 			);
282 282
 	}
283 283
 
@@ -288,18 +288,18 @@  discard block
 block discarded – undo
288 288
 	 *
289 289
 	 * @return string HTML
290 290
 	 */
291
-	private function buildResultHeader( EntityId $entityId ) {
291
+	private function buildResultHeader(EntityId $entityId) {
292 292
 		$entityLink = sprintf(
293 293
 			'%s (%s)',
294
-			$this->entityIdLinkFormatter->formatEntityId( $entityId ),
295
-			htmlspecialchars( $entityId->getSerialization() )
294
+			$this->entityIdLinkFormatter->formatEntityId($entityId),
295
+			htmlspecialchars($entityId->getSerialization())
296 296
 		);
297 297
 
298 298
 		return
299 299
 			Html::rawElement(
300 300
 				'h3',
301 301
 				[],
302
-				sprintf( '%s %s', $this->msg( 'wbqev-crosscheck-result-headline' )->escaped(), $entityLink )
302
+				sprintf('%s %s', $this->msg('wbqev-crosscheck-result-headline')->escaped(), $entityLink)
303 303
 			);
304 304
 	}
305 305
 
@@ -310,11 +310,11 @@  discard block
 block discarded – undo
310 310
 	 *
311 311
 	 * @return string HTML
312 312
 	 */
313
-	private function buildSummary( $results ) {
313
+	private function buildSummary($results) {
314 314
 		$statuses = [];
315
-		foreach ( $results as $result ) {
316
-			$status = strtolower( $result->getComparisonResult()->getStatus() );
317
-			if ( array_key_exists( $status, $statuses ) ) {
315
+		foreach ($results as $result) {
316
+			$status = strtolower($result->getComparisonResult()->getStatus());
317
+			if (array_key_exists($status, $statuses)) {
318 318
 				$statuses[$status]++;
319 319
 			} else {
320 320
 				$statuses[$status] = 1;
@@ -322,15 +322,15 @@  discard block
 block discarded – undo
322 322
 		}
323 323
 
324 324
 		$statusElements = [];
325
-		foreach ( $statuses as $status => $count ) {
326
-			if ( $count > 0 ) {
327
-				$statusElements[] = $this->formatStatus( $status ) . ': ' . $count;
325
+		foreach ($statuses as $status => $count) {
326
+			if ($count > 0) {
327
+				$statusElements[] = $this->formatStatus($status).': '.$count;
328 328
 			}
329 329
 		}
330 330
 		$summary =
331
-			Html::openElement( 'p' )
332
-			. implode( ', ', $statusElements )
333
-			. Html::closeElement( 'p' );
331
+			Html::openElement('p')
332
+			. implode(', ', $statusElements)
333
+			. Html::closeElement('p');
334 334
 
335 335
 		return $summary;
336 336
 	}
@@ -344,16 +344,16 @@  discard block
 block discarded – undo
344 344
 	 *
345 345
 	 * @return string HTML
346 346
 	 */
347
-	private function formatStatus( $status ) {
348
-		$messageKey = 'wbqev-crosscheck-status-' . strtolower( $status );
347
+	private function formatStatus($status) {
348
+		$messageKey = 'wbqev-crosscheck-status-'.strtolower($status);
349 349
 
350 350
 		$formattedStatus =
351 351
 			Html::element(
352 352
 				'span',
353 353
 				[
354
-					'class' => 'wbqev-status wbqev-status-' . htmlspecialchars( $status )
354
+					'class' => 'wbqev-status wbqev-status-'.htmlspecialchars($status)
355 355
 				],
356
-				$this->msg( $messageKey )->text()
356
+				$this->msg($messageKey)->text()
357 357
 			);
358 358
 
359 359
 		return $formattedStatus;
@@ -370,29 +370,29 @@  discard block
 block discarded – undo
370 370
 	 *
371 371
 	 * @return string HTML
372 372
 	 */
373
-	private function formatDataValues( $dataValues, $linking = true, $separator = null ) {
374
-		if ( $dataValues instanceof DataValue ) {
375
-			$dataValues = [ $dataValues ];
373
+	private function formatDataValues($dataValues, $linking = true, $separator = null) {
374
+		if ($dataValues instanceof DataValue) {
375
+			$dataValues = [$dataValues];
376 376
 		}
377 377
 
378 378
 		$formattedDataValues = [];
379
-		foreach ( $dataValues as $dataValue ) {
380
-			if ( $dataValue instanceof EntityIdValue ) {
381
-				if ( $linking ) {
382
-					$formattedDataValues[] = $this->entityIdLinkFormatter->formatEntityId( $dataValue->getEntityId() );
379
+		foreach ($dataValues as $dataValue) {
380
+			if ($dataValue instanceof EntityIdValue) {
381
+				if ($linking) {
382
+					$formattedDataValues[] = $this->entityIdLinkFormatter->formatEntityId($dataValue->getEntityId());
383 383
 				} else {
384
-					$formattedDataValues[] = $this->entityIdLabelFormatter->formatEntityId( $dataValue->getEntityId() );
384
+					$formattedDataValues[] = $this->entityIdLabelFormatter->formatEntityId($dataValue->getEntityId());
385 385
 				}
386 386
 			} else {
387
-				$formattedDataValues[] = $this->dataValueFormatter->format( $dataValue );
387
+				$formattedDataValues[] = $this->dataValueFormatter->format($dataValue);
388 388
 			}
389 389
 		}
390 390
 
391
-		if ( $separator ) {
392
-			return implode( $separator, $formattedDataValues );
391
+		if ($separator) {
392
+			return implode($separator, $formattedDataValues);
393 393
 		}
394 394
 
395
-		return $this->getLanguage()->commaList( $formattedDataValues );
395
+		return $this->getLanguage()->commaList($formattedDataValues);
396 396
 	}
397 397
 
398 398
 	/**
@@ -400,31 +400,31 @@  discard block
 block discarded – undo
400 400
 	 *
401 401
 	 * @return string HTML
402 402
 	 */
403
-	private function buildResultTable( $results ) {
403
+	private function buildResultTable($results) {
404 404
 		$table = new HtmlTableBuilder(
405 405
 			[
406 406
 				new HtmlTableHeaderBuilder(
407
-					$this->msg( 'wbqev-crosscheck-result-table-header-status' )->escaped(),
407
+					$this->msg('wbqev-crosscheck-result-table-header-status')->escaped(),
408 408
 					true
409 409
 				),
410 410
 				new HtmlTableHeaderBuilder(
411
-					$this->msg( 'datatypes-type-wikibase-property' )->escaped(),
411
+					$this->msg('datatypes-type-wikibase-property')->escaped(),
412 412
 					true
413 413
 				),
414 414
 				new HtmlTableHeaderBuilder(
415
-					$this->msg( 'wbqev-crosscheck-result-table-header-local-value' )->escaped()
415
+					$this->msg('wbqev-crosscheck-result-table-header-local-value')->escaped()
416 416
 				),
417 417
 				new HtmlTableHeaderBuilder(
418
-					$this->msg( 'wbqev-crosscheck-result-table-header-external-value' )->escaped()
418
+					$this->msg('wbqev-crosscheck-result-table-header-external-value')->escaped()
419 419
 				),
420 420
 				new HtmlTableHeaderBuilder(
421
-					$this->msg( 'wbqev-crosscheck-result-table-header-references' )->escaped(),
421
+					$this->msg('wbqev-crosscheck-result-table-header-references')->escaped(),
422 422
 					true
423 423
 				),
424 424
 				new HtmlTableHeaderBuilder(
425 425
 					Linker::linkKnown(
426
-						self::getTitleFor( 'ExternalDatabases' ),
427
-						$this->msg( 'wbqev-crosscheck-result-table-header-external-source' )->escaped()
426
+						self::getTitleFor('ExternalDatabases'),
427
+						$this->msg('wbqev-crosscheck-result-table-header-external-source')->escaped()
428 428
 					),
429 429
 					true,
430 430
 					true
@@ -433,28 +433,28 @@  discard block
 block discarded – undo
433 433
 			true
434 434
 		);
435 435
 
436
-		foreach ( $results as $result ) {
437
-			$status = $this->formatStatus( $result->getComparisonResult()->getStatus() );
438
-			$propertyId = $this->entityIdLinkFormatter->formatEntityId( $result->getPropertyId() );
439
-			$localValue = $this->formatDataValues( $result->getComparisonResult()->getLocalValue() );
436
+		foreach ($results as $result) {
437
+			$status = $this->formatStatus($result->getComparisonResult()->getStatus());
438
+			$propertyId = $this->entityIdLinkFormatter->formatEntityId($result->getPropertyId());
439
+			$localValue = $this->formatDataValues($result->getComparisonResult()->getLocalValue());
440 440
 			$externalValue = $this->formatDataValues(
441 441
 				$result->getComparisonResult()->getExternalValues(),
442 442
 				true,
443
-				Html::element( 'br' )
443
+				Html::element('br')
444 444
 			);
445 445
 			$referenceStatus = $this->msg(
446
-				'wbqev-crosscheck-status-' . $result->getReferenceResult()->getStatus()
446
+				'wbqev-crosscheck-status-'.$result->getReferenceResult()->getStatus()
447 447
 			)->text();
448
-			$dataSource = $this->entityIdLinkFormatter->formatEntityId( $result->getDumpMetaInformation()->getSourceItemId() );
448
+			$dataSource = $this->entityIdLinkFormatter->formatEntityId($result->getDumpMetaInformation()->getSourceItemId());
449 449
 
450 450
 			$table->appendRow(
451 451
 				[
452
-					new HtmlTableCellBuilder( $status, [], true ),
453
-					new HtmlTableCellBuilder( $propertyId, [], true ),
454
-					new HtmlTableCellBuilder( $localValue, [], true ),
455
-					new HtmlTableCellBuilder( $externalValue, [], true ),
456
-					new HtmlTableCellBuilder( $referenceStatus, [] ),
457
-					new HtmlTableCellBuilder( $dataSource, [], true )
452
+					new HtmlTableCellBuilder($status, [], true),
453
+					new HtmlTableCellBuilder($propertyId, [], true),
454
+					new HtmlTableCellBuilder($localValue, [], true),
455
+					new HtmlTableCellBuilder($externalValue, [], true),
456
+					new HtmlTableCellBuilder($referenceStatus, []),
457
+					new HtmlTableCellBuilder($dataSource, [], true)
458 458
 				]
459 459
 			);
460 460
 		}
Please login to merge, or discard this patch.
specials/SpecialExternalDatabases.php 1 patch
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -53,10 +53,10 @@  discard block
 block discarded – undo
53 53
 		TermLookup $termLookup,
54 54
 		EntityIdHtmlLinkFormatterFactory $entityIdHtmlLinkFormatterFactory,
55 55
 		DumpMetaInformationLookup $dumpMetaInformationRepo ) {
56
-		parent::__construct( 'ExternalDatabases' );
56
+		parent::__construct('ExternalDatabases');
57 57
 
58 58
 		$this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter(
59
-			new LanguageLabelDescriptionLookup( $termLookup, $this->getLanguage()->getCode() )
59
+			new LanguageLabelDescriptionLookup($termLookup, $this->getLanguage()->getCode())
60 60
 		);
61 61
 
62 62
 		$this->dumpMetaInformationRepo = $dumpMetaInformationRepo;
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	 * @return string
78 78
 	 */
79 79
 	public function getDescription() {
80
-		return $this->msg( 'wbqev-externaldbs' )->text();
80
+		return $this->msg('wbqev-externaldbs')->text();
81 81
 	}
82 82
 
83 83
 	/**
@@ -85,51 +85,51 @@  discard block
 block discarded – undo
85 85
 	 *
86 86
 	 * @param string|null $subPage
87 87
 	 */
88
-	public function execute( $subPage ) {
88
+	public function execute($subPage) {
89 89
 		$out = $this->getOutput();
90 90
 
91 91
 		$this->setHeaders();
92 92
 
93 93
 		$out->addHTML(
94
-			Html::openElement( 'p' )
95
-			. $this->msg( 'wbqev-externaldbs-instructions' )->parse()
96
-			. Html::closeElement( 'p' )
97
-			. Html::openElement( 'h3' )
98
-			. $this->msg( 'wbqev-externaldbs-overview-headline' )->parse()
99
-			. Html::closeElement( 'h3' )
94
+			Html::openElement('p')
95
+			. $this->msg('wbqev-externaldbs-instructions')->parse()
96
+			. Html::closeElement('p')
97
+			. Html::openElement('h3')
98
+			. $this->msg('wbqev-externaldbs-overview-headline')->parse()
99
+			. Html::closeElement('h3')
100 100
 		);
101 101
 
102 102
 		$dumps = $this->dumpMetaInformationRepo->getAll();
103
-		if ( count( $dumps ) > 0 ) {
103
+		if (count($dumps) > 0) {
104 104
 			$groupedDumpMetaInformation = [];
105
-			foreach ( $dumps as $dump ) {
105
+			foreach ($dumps as $dump) {
106 106
 				$sourceItemId = $dump->getSourceItemId()->getSerialization();
107 107
 				$groupedDumpMetaInformation[$sourceItemId][] = $dump;
108 108
 			}
109 109
 
110 110
 			$table = new HtmlTableBuilder(
111 111
 				[
112
-					$this->msg( 'wbqev-externaldbs-name' )->escaped(),
113
-					$this->msg( 'wbqev-externaldbs-id' )->escaped(),
114
-					$this->msg( 'wbqev-externaldbs-import-date' )->escaped(),
115
-					$this->msg( 'wbqev-externaldbs-language' )->escaped(),
116
-					$this->msg( 'wbqev-externaldbs-source-urls' )->escaped(),
117
-					$this->msg( 'wbqev-externaldbs-size' )->escaped(),
118
-					$this->msg( 'wbqev-externaldbs-license' )->escaped()
112
+					$this->msg('wbqev-externaldbs-name')->escaped(),
113
+					$this->msg('wbqev-externaldbs-id')->escaped(),
114
+					$this->msg('wbqev-externaldbs-import-date')->escaped(),
115
+					$this->msg('wbqev-externaldbs-language')->escaped(),
116
+					$this->msg('wbqev-externaldbs-source-urls')->escaped(),
117
+					$this->msg('wbqev-externaldbs-size')->escaped(),
118
+					$this->msg('wbqev-externaldbs-license')->escaped()
119 119
 				],
120 120
 				true
121 121
 			);
122 122
 
123
-			foreach ( $groupedDumpMetaInformation as $dumpMetaInformation ) {
124
-				$table->appendRows( $this->getRowGroup( $dumpMetaInformation ) );
123
+			foreach ($groupedDumpMetaInformation as $dumpMetaInformation) {
124
+				$table->appendRows($this->getRowGroup($dumpMetaInformation));
125 125
 			}
126 126
 
127
-			$out->addHTML( $table->toHtml() );
127
+			$out->addHTML($table->toHtml());
128 128
 		} else {
129 129
 			$out->addHTML(
130
-				Html::openElement( 'p' )
131
-				. $this->msg( 'wbqev-externaldbs-no-databases' )->escaped()
132
-				. Html::closeElement( 'p' )
130
+				Html::openElement('p')
131
+				. $this->msg('wbqev-externaldbs-no-databases')->escaped()
132
+				. Html::closeElement('p')
133 133
 			);
134 134
 		}
135 135
 	}
@@ -141,12 +141,12 @@  discard block
 block discarded – undo
141 141
 	 *
142 142
 	 * @return array
143 143
 	 */
144
-	private function getRowGroup( array $dumpMetaInformationGroup ) {
144
+	private function getRowGroup(array $dumpMetaInformationGroup) {
145 145
 		$rows = [];
146 146
 
147
-		foreach ( $dumpMetaInformationGroup as $dumpMetaInformation ) {
147
+		foreach ($dumpMetaInformationGroup as $dumpMetaInformation) {
148 148
 			$dumpId = $dumpMetaInformation->getDumpId();
149
-			$importDate = $this->getLanguage()->timeanddate( $dumpMetaInformation->getImportDate() );
149
+			$importDate = $this->getLanguage()->timeanddate($dumpMetaInformation->getImportDate());
150 150
 			$language = Language::fetchLanguageName(
151 151
 				$dumpMetaInformation->getLanguageCode(),
152 152
 				$this->getLanguage()->getCode()
@@ -155,23 +155,23 @@  discard block
 block discarded – undo
155 155
 				$dumpMetaInformation->getSourceUrl(),
156 156
 				$dumpMetaInformation->getSourceUrl()
157 157
 			);
158
-			$size = $this->getLanguage()->formatSize( $dumpMetaInformation->getSize() );
159
-			$license = $this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformation->getLicenseItemId() );
158
+			$size = $this->getLanguage()->formatSize($dumpMetaInformation->getSize());
159
+			$license = $this->entityIdLinkFormatter->formatEntityId($dumpMetaInformation->getLicenseItemId());
160 160
 			$rows[] = [
161
-				new HtmlTableCellBuilder( $dumpId ),
162
-				new HtmlTableCellBuilder( $importDate ),
163
-				new HtmlTableCellBuilder( $language ),
164
-				new HtmlTableCellBuilder( $sourceUrl, [], true ),
165
-				new HtmlTableCellBuilder( $size ),
166
-				new HtmlTableCellBuilder( $license, [], true )
161
+				new HtmlTableCellBuilder($dumpId),
162
+				new HtmlTableCellBuilder($importDate),
163
+				new HtmlTableCellBuilder($language),
164
+				new HtmlTableCellBuilder($sourceUrl, [], true),
165
+				new HtmlTableCellBuilder($size),
166
+				new HtmlTableCellBuilder($license, [], true)
167 167
 			];
168 168
 		}
169 169
 
170 170
 		array_unshift(
171 171
 			$rows[0],
172 172
 			new HtmlTableCellBuilder(
173
-				$this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformationGroup[0]->getSourceItemId() ),
174
-				[ 'rowspan' => (string)count( $dumpMetaInformationGroup ) ],
173
+				$this->entityIdLinkFormatter->formatEntityId($dumpMetaInformationGroup[0]->getSourceItemId()),
174
+				['rowspan' => (string)count($dumpMetaInformationGroup)],
175 175
 				true
176 176
 			)
177 177
 		);
Please login to merge, or discard this patch.
api/RunCrossCheck.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 	 *
66 66
 	 * @return self
67 67
 	 */
68
-	public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) {
68
+	public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') {
69 69
 		$repo = WikibaseRepo::getDefaultInstance();
70 70
 		$externalValidationServices = ExternalValidationServices::getDefaultInstance();
71 71
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 			$repo->getStatementGuidValidator(),
78 78
 			$externalValidationServices->getCrossCheckInteractor(),
79 79
 			$externalValidationServices->getSerializerFactory(),
80
-			$repo->getApiHelperFactory( RequestContext::getMain() )
80
+			$repo->getApiHelperFactory(RequestContext::getMain())
81 81
 		);
82 82
 	}
83 83
 
@@ -91,17 +91,17 @@  discard block
 block discarded – undo
91 91
 	 * @param SerializerFactory $serializerFactory
92 92
 	 * @param ApiHelperFactory $apiHelperFactory
93 93
 	 */
94
-	public function __construct( ApiMain $main, $name, $prefix = '', EntityIdParser $entityIdParser,
94
+	public function __construct(ApiMain $main, $name, $prefix = '', EntityIdParser $entityIdParser,
95 95
 								 StatementGuidValidator $statementGuidValidator, CrossCheckInteractor $crossCheckInteractor,
96
-								 SerializerFactory $serializerFactory, ApiHelperFactory $apiHelperFactory ) {
97
-		parent::__construct( $main, $name, $prefix );
96
+								 SerializerFactory $serializerFactory, ApiHelperFactory $apiHelperFactory) {
97
+		parent::__construct($main, $name, $prefix);
98 98
 
99 99
 		$this->entityIdParser = $entityIdParser;
100 100
 		$this->statementGuidValidator = $statementGuidValidator;
101 101
 		$this->crossCheckInteractor = $crossCheckInteractor;
102 102
 		$this->serializerFactory = $serializerFactory;
103
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
104
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
103
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
104
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
105 105
 	}
106 106
 
107 107
 	/**
@@ -110,24 +110,24 @@  discard block
 block discarded – undo
110 110
 	public function execute() {
111 111
 		$params = $this->extractRequestParams();
112 112
 
113
-		if ( $params['entities'] && $params['claims'] ) {
113
+		if ($params['entities'] && $params['claims']) {
114 114
 			$this->errorReporter->dieError(
115 115
 				'Either provide the ids of entities or ids of claims, that should be cross-checked.',
116 116
 				'param-invalid'
117 117
 			);
118 118
 			throw new LogicException();
119
-		} elseif ( $params['entities'] ) {
120
-			$entityIds = $this->parseEntityIds( $params['entities'] );
121
-			if ( $params['properties'] ) {
122
-				$propertyIds = $this->parseEntityIds( $params['properties'] );
123
-				$resultLists = $this->crossCheckInteractor->crossCheckEntitiesByIdWithProperties( $entityIds, $propertyIds );
119
+		} elseif ($params['entities']) {
120
+			$entityIds = $this->parseEntityIds($params['entities']);
121
+			if ($params['properties']) {
122
+				$propertyIds = $this->parseEntityIds($params['properties']);
123
+				$resultLists = $this->crossCheckInteractor->crossCheckEntitiesByIdWithProperties($entityIds, $propertyIds);
124 124
 			} else {
125
-				$resultLists = $this->crossCheckInteractor->crossCheckEntitiesByIds( $entityIds );
125
+				$resultLists = $this->crossCheckInteractor->crossCheckEntitiesByIds($entityIds);
126 126
 			}
127
-		} elseif ( $params['claims'] ) {
127
+		} elseif ($params['claims']) {
128 128
 			$guids = $params['claims'];
129
-			$this->assertAreValidClaimGuids( $guids );
130
-			$resultLists = $this->crossCheckInteractor->crossCheckStatementsByGuids( $guids );
129
+			$this->assertAreValidClaimGuids($guids);
130
+			$resultLists = $this->crossCheckInteractor->crossCheckStatementsByGuids($guids);
131 131
 		} else {
132 132
 			$this->errorReporter->dieError(
133 133
 				'Either provide the ids of entities or ids of claims, that should be cross-checked.',
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 		}
138 138
 
139 139
 		// Print result lists
140
-		$this->writeResultOutput( $resultLists );
140
+		$this->writeResultOutput($resultLists);
141 141
 	}
142 142
 
143 143
 	/**
@@ -145,9 +145,9 @@  discard block
 block discarded – undo
145 145
 	 *
146 146
 	 * @return EntityId[]
147 147
 	 */
148
-	private function parseEntityIds( array $entityIds ) {
148
+	private function parseEntityIds(array $entityIds) {
149 149
 		return array_map(
150
-			[ $this->entityIdParser, 'parse' ],
150
+			[$this->entityIdParser, 'parse'],
151 151
 			$entityIds
152 152
 		);
153 153
 	}
@@ -155,10 +155,10 @@  discard block
 block discarded – undo
155 155
 	/**
156 156
 	 * @param string[] $guids
157 157
 	 */
158
-	private function assertAreValidClaimGuids( array $guids ) {
159
-		foreach ( $guids as $guid ) {
160
-			if ( $this->statementGuidValidator->validateFormat( $guid ) === false ) {
161
-				$this->errorReporter->dieError( 'Invalid claim guid.', 'invalid-guid' );
158
+	private function assertAreValidClaimGuids(array $guids) {
159
+		foreach ($guids as $guid) {
160
+			if ($this->statementGuidValidator->validateFormat($guid) === false) {
161
+				$this->errorReporter->dieError('Invalid claim guid.', 'invalid-guid');
162 162
 			}
163 163
 		}
164 164
 	}
@@ -170,13 +170,13 @@  discard block
 block discarded – undo
170 170
 	 *
171 171
 	 * @return array
172 172
 	 */
173
-	private function writeResultOutput( array $resultLists ) {
173
+	private function writeResultOutput(array $resultLists) {
174 174
 		$serializer = $this->serializerFactory->newCrossCheckResultListSerializer();
175 175
 
176 176
 		$output = [];
177
-		foreach ( $resultLists as $entityId => $resultList ) {
178
-			if ( $resultList ) {
179
-				$serializedResultList = $serializer->serialize( $resultList );
177
+		foreach ($resultLists as $entityId => $resultList) {
178
+			if ($resultList) {
179
+				$serializedResultList = $serializer->serialize($resultList);
180 180
 
181 181
 				$output[$entityId] = $serializedResultList;
182 182
 			} else {
@@ -186,10 +186,10 @@  discard block
 block discarded – undo
186 186
 			}
187 187
 		}
188 188
 
189
-		$this->getResult()->setIndexedTagName( $output, 'entity' );
190
-		$this->getResult()->setArrayType( $output, 'kvp', 'id' );
191
-		$this->getResult()->addValue( null, 'results', $output );
192
-		$this->resultBuilder->markSuccess( 1 );
189
+		$this->getResult()->setIndexedTagName($output, 'entity');
190
+		$this->getResult()->setArrayType($output, 'kvp', 'id');
191
+		$this->getResult()->addValue(null, 'results', $output);
192
+		$this->resultBuilder->markSuccess(1);
193 193
 	}
194 194
 
195 195
 	/**
Please login to merge, or discard this patch.
includes/UpdateExternalData/ExternalDataImporter.php 1 patch
Spacing   +41 added lines, -41 removed lines patch added patch discarded remove patch
@@ -51,13 +51,13 @@  discard block
 block discarded – undo
51 51
 	public function import() {
52 52
 		$dumpIds = $this->insertMetaInformation();
53 53
 
54
-		$this->log( "\nDelete old database entries...\n" );
54
+		$this->log("\nDelete old database entries...\n");
55 55
 
56
-		foreach ( $dumpIds as $dumpId ) {
57
-			$this->externalDataRepo->deleteOfDump( $dumpId, $this->importSettings->getBatchSize() );
56
+		foreach ($dumpIds as $dumpId) {
57
+			$this->externalDataRepo->deleteOfDump($dumpId, $this->importSettings->getBatchSize());
58 58
 		}
59 59
 
60
-		$this->log( "\n" );
60
+		$this->log("\n");
61 61
 
62 62
 		$this->insertExternalValues();
63 63
 	}
@@ -68,52 +68,52 @@  discard block
 block discarded – undo
68 68
 	 * @return array
69 69
 	 */
70 70
 	protected function insertMetaInformation() {
71
-		$this->log( "Insert new dump meta information\n" );
71
+		$this->log("Insert new dump meta information\n");
72 72
 
73
-		$csvFile = fopen( $this->importSettings->getDumpInformationFilePath(), 'rb' );
74
-		if ( !$csvFile ) {
75
-			exit( 'Error while reading CSV file.' );
73
+		$csvFile = fopen($this->importSettings->getDumpInformationFilePath(), 'rb');
74
+		if (!$csvFile) {
75
+			exit('Error while reading CSV file.');
76 76
 		}
77 77
 
78 78
 		$i = 0;
79 79
 		$dumpIds = [];
80
-		while ( $data = fgetcsv( $csvFile ) ) {
80
+		while ($data = fgetcsv($csvFile)) {
81 81
 			$identifierPropertyIds = array_map(
82
-				function ( $propertyId ) {
83
-					return new PropertyId( $propertyId );
82
+				function($propertyId) {
83
+					return new PropertyId($propertyId);
84 84
 				},
85
-				json_decode( $data[2] )
85
+				json_decode($data[2])
86 86
 			);
87 87
 			try {
88 88
 				$dumpMetaInformation = new DumpMetaInformation(
89 89
 					$data[0],
90
-					new ItemId( $data[1] ),
90
+					new ItemId($data[1]),
91 91
 					$identifierPropertyIds,
92 92
 					$data[3],
93 93
 					$data[4],
94 94
 					$data[5],
95
-					intval( $data[6] ),
96
-					new ItemId( $data[7] )
95
+					intval($data[6]),
96
+					new ItemId($data[7])
97 97
 				);
98
-			} catch ( \InvalidArgumentException $e ) {
99
-				exit( 'Input file has bad formatted values.' );
98
+			} catch (\InvalidArgumentException $e) {
99
+				exit('Input file has bad formatted values.');
100 100
 			}
101 101
 			$dumpIds[] = $dumpMetaInformation->getDumpId();
102 102
 
103 103
 			try {
104
-				$this->dumpMetaInformationStore->save( $dumpMetaInformation );
105
-			} catch ( \DBError $e ) {
106
-				exit( 'Unknown database error occurred.' );
104
+				$this->dumpMetaInformationStore->save($dumpMetaInformation);
105
+			} catch (\DBError $e) {
106
+				exit('Unknown database error occurred.');
107 107
 			}
108 108
 
109 109
 			$i++;
110
-			$this->log( "\r\033[K" );
111
-			$this->log( "$i rows inserted or updated" );
110
+			$this->log("\r\033[K");
111
+			$this->log("$i rows inserted or updated");
112 112
 		}
113 113
 
114
-		fclose( $csvFile );
114
+		fclose($csvFile);
115 115
 
116
-		$this->log( "\n" );
116
+		$this->log("\n");
117 117
 
118 118
 		return $dumpIds;
119 119
 	}
@@ -122,31 +122,31 @@  discard block
 block discarded – undo
122 122
 	 * Inserts external values stored in csv file into database
123 123
 	 */
124 124
 	private function insertExternalValues() {
125
-		$this->log( "Insert new data values\n" );
125
+		$this->log("Insert new data values\n");
126 126
 
127
-		$csvFile = fopen( $this->importSettings->getExternalValuesFilePath(), 'rb' );
128
-		if ( !$csvFile ) {
129
-			exit( 'Error while reading CSV file.' );
127
+		$csvFile = fopen($this->importSettings->getExternalValuesFilePath(), 'rb');
128
+		if (!$csvFile) {
129
+			exit('Error while reading CSV file.');
130 130
 		}
131 131
 
132 132
 		$i = 0;
133 133
 		$accumulator = [];
134
-		while ( true ) {
135
-			$data = fgetcsv( $csvFile );
136
-			if ( $data === false || ++$i % $this->importSettings->getBatchSize() === 0 ) {
134
+		while (true) {
135
+			$data = fgetcsv($csvFile);
136
+			if ($data === false || ++$i % $this->importSettings->getBatchSize() === 0) {
137 137
 				try {
138
-					$this->externalDataRepo->insertBatch( $accumulator );
139
-				} catch ( \DBError $e ) {
140
-					exit( 'Unknown database error occurred.' );
138
+					$this->externalDataRepo->insertBatch($accumulator);
139
+				} catch (\DBError $e) {
140
+					exit('Unknown database error occurred.');
141 141
 				}
142 142
 				wfGetLBFactory()->waitForReplication();
143 143
 
144
-				$this->log( "\r\033[K" );
145
-				$this->log( "$i rows inserted" );
144
+				$this->log("\r\033[K");
145
+				$this->log("$i rows inserted");
146 146
 
147 147
 				$accumulator = [];
148 148
 
149
-				if ( $data === false ) {
149
+				if ($data === false) {
150 150
 					break;
151 151
 				}
152 152
 			}
@@ -154,16 +154,16 @@  discard block
 block discarded – undo
154 154
 			$accumulator[] = $data;
155 155
 		}
156 156
 
157
-		fclose( $csvFile );
157
+		fclose($csvFile);
158 158
 
159
-		$this->log( "\n" );
159
+		$this->log("\n");
160 160
 	}
161 161
 
162 162
 	/**
163 163
 	 * @param string $text
164 164
 	 */
165
-	private function log( $text ) {
166
-		if ( !$this->importSettings->isQuiet() ) {
165
+	private function log($text) {
166
+		if (!$this->importSettings->isQuiet()) {
167 167
 			print $text;
168 168
 		}
169 169
 	}
Please login to merge, or discard this patch.
includes/Serializer/ComparisonResultSerializer.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $dataValueSerializer
24 24
 	 */
25
-	public function __construct( Serializer $dataValueSerializer ) {
25
+	public function __construct(Serializer $dataValueSerializer) {
26 26
 		$this->dataValueSerializer = $dataValueSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof ComparisonResult;
38 38
 	}
39 39
 
@@ -45,29 +45,29 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'ComparisonResultSerializer can only serialize ComparisonResult objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( ComparisonResult $comparisonResult ) {
59
+	private function getSerialized(ComparisonResult $comparisonResult) {
60 60
 		$dataValueSerializer = $this->dataValueSerializer;
61 61
 		$externalValues = array_map(
62
-			function ( $dataValue ) use ( $dataValueSerializer ) {
63
-				return $dataValueSerializer->serialize( $dataValue );
62
+			function($dataValue) use ($dataValueSerializer) {
63
+				return $dataValueSerializer->serialize($dataValue);
64 64
 			},
65 65
 			$comparisonResult->getExternalValues()
66 66
 		);
67
-		$this->setIndexedTagName( $externalValues, 'dataValue' );
67
+		$this->setIndexedTagName($externalValues, 'dataValue');
68 68
 
69 69
 		return [
70
-			'localValue' => $this->dataValueSerializer->serialize( $comparisonResult->getLocalValue() ),
70
+			'localValue' => $this->dataValueSerializer->serialize($comparisonResult->getLocalValue()),
71 71
 			'externalValues' => $externalValues,
72 72
 			'result' => $comparisonResult->getStatus()
73 73
 		];
Please login to merge, or discard this patch.
includes/Serializer/CrossCheckResultListSerializer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $crossCheckResultSerializer
24 24
 	 */
25
-	public function __construct( Serializer $crossCheckResultSerializer ) {
25
+	public function __construct(Serializer $crossCheckResultSerializer) {
26 26
 		$this->crossCheckResultSerializer = $crossCheckResultSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof CrossCheckResultList;
38 38
 	}
39 39
 
@@ -45,29 +45,29 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( CrossCheckResultList $resultList ) {
59
+	private function getSerialized(CrossCheckResultList $resultList) {
60 60
 		$serialization = [];
61
-		$this->setKeyAttributeName( $serialization, 'property', 'id' );
61
+		$this->setKeyAttributeName($serialization, 'property', 'id');
62 62
 
63
-		foreach ( $resultList->getPropertyIds() as $propertyId ) {
63
+		foreach ($resultList->getPropertyIds() as $propertyId) {
64 64
 			$id = $propertyId->getSerialization();
65 65
 			$resultSerialization = [];
66 66
 
67
-			$this->setIndexedTagName( $resultSerialization, 'result' );
67
+			$this->setIndexedTagName($resultSerialization, 'result');
68 68
 
69
-			foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) {
70
-				$resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result );
69
+			foreach ($resultList->getByPropertyId($propertyId) as $result) {
70
+				$resultSerialization[] = $this->crossCheckResultSerializer->serialize($result);
71 71
 			}
72 72
 
73 73
 			$serialization[$id] = $resultSerialization;
Please login to merge, or discard this patch.
includes/Serializer/DumpMetaInformationSerializer.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	 *
22 22
 	 * @return bool
23 23
 	 */
24
-	public function isSerializerFor( $object ) {
24
+	public function isSerializerFor($object) {
25 25
 		return $object instanceof DumpMetaInformation;
26 26
 	}
27 27
 
@@ -33,32 +33,32 @@  discard block
 block discarded – undo
33 33
 	 * @return array
34 34
 	 * @throws UnsupportedObjectException
35 35
 	 */
36
-	public function serialize( $object ) {
37
-		if ( !$this->isSerializerFor( $object ) ) {
36
+	public function serialize($object) {
37
+		if (!$this->isSerializerFor($object)) {
38 38
 			throw new UnsupportedObjectException(
39 39
 				$object,
40 40
 				'DumpMetaInformationSerializer can only serialize DumpMetaInformation objects.'
41 41
 			);
42 42
 		}
43 43
 
44
-		return $this->getSerialized( $object );
44
+		return $this->getSerialized($object);
45 45
 	}
46 46
 
47
-	private function getSerialized( DumpMetaInformation $dumpMetaInformation ) {
47
+	private function getSerialized(DumpMetaInformation $dumpMetaInformation) {
48 48
 		$identifierPropertyIds = array_map(
49
-			function( PropertyId $id ) {
49
+			function(PropertyId $id) {
50 50
 				return $id->getSerialization();
51 51
 			},
52 52
 			$dumpMetaInformation->getIdentifierPropertyIds()
53 53
 		);
54 54
 
55
-		$this->setIndexedTagName( $identifierPropertyIds, 'propertyId' );
55
+		$this->setIndexedTagName($identifierPropertyIds, 'propertyId');
56 56
 
57 57
 		return [
58 58
 			'dumpId' => $dumpMetaInformation->getDumpId(),
59 59
 			'sourceItemId' => $dumpMetaInformation->getSourceItemId()->getSerialization(),
60 60
 			'identifierPropertyIds' => $identifierPropertyIds,
61
-			'importDate' => wfTimestamp( TS_ISO_8601, $dumpMetaInformation->getImportDate() ),
61
+			'importDate' => wfTimestamp(TS_ISO_8601, $dumpMetaInformation->getImportDate()),
62 62
 			'language' => $dumpMetaInformation->getLanguageCode(),
63 63
 			'sourceUrl' => $dumpMetaInformation->getSourceUrl(),
64 64
 			'size' => $dumpMetaInformation->getSize(),
Please login to merge, or discard this patch.
includes/Serializer/CrossCheckResultSerializer.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	 *
52 52
 	 * @return bool
53 53
 	 */
54
-	public function isSerializerFor( $object ) {
54
+	public function isSerializerFor($object) {
55 55
 		return $object instanceof CrossCheckResult;
56 56
 	}
57 57
 
@@ -63,25 +63,25 @@  discard block
 block discarded – undo
63 63
 	 * @return array
64 64
 	 * @throws UnsupportedObjectException
65 65
 	 */
66
-	public function serialize( $object ) {
67
-		if ( !$this->isSerializerFor( $object ) ) {
66
+	public function serialize($object) {
67
+		if (!$this->isSerializerFor($object)) {
68 68
 			throw new UnsupportedObjectException(
69 69
 				$object,
70 70
 				'CrossCheckResultSerializer can only serialize CrossCheckResult objects.'
71 71
 			);
72 72
 		}
73 73
 
74
-		return $this->getSerialized( $object );
74
+		return $this->getSerialized($object);
75 75
 	}
76 76
 
77
-	private function getSerialized( CrossCheckResult $crossCheckResult ) {
77
+	private function getSerialized(CrossCheckResult $crossCheckResult) {
78 78
 		return [
79 79
 			'propertyId' => $crossCheckResult->getPropertyId()->getSerialization(),
80 80
 			'claimGuid' => $crossCheckResult->getClaimGuid(),
81 81
 			'externalId' => $crossCheckResult->getExternalId(),
82
-			'dataSource' => $this->dumpMetaInformationSerializer->serialize( $crossCheckResult->getDumpMetaInformation() ),
83
-			'comparisonResult' => $this->comparisonResultSerializer->serialize( $crossCheckResult->getComparisonResult() ),
84
-			'referenceResult' => $this->referenceResultSerializer->serialize( $crossCheckResult->getReferenceResult() )
82
+			'dataSource' => $this->dumpMetaInformationSerializer->serialize($crossCheckResult->getDumpMetaInformation()),
83
+			'comparisonResult' => $this->comparisonResultSerializer->serialize($crossCheckResult->getComparisonResult()),
84
+			'referenceResult' => $this->referenceResultSerializer->serialize($crossCheckResult->getReferenceResult())
85 85
 		];
86 86
 	}
87 87
 
Please login to merge, or discard this patch.
includes/Serializer/ReferenceResultSerializer.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $referenceSerializer
24 24
 	 */
25
-	public function __construct( Serializer $referenceSerializer ) {
25
+	public function __construct(Serializer $referenceSerializer) {
26 26
 		$this->referenceSerializer = $referenceSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof ReferenceResult;
38 38
 	}
39 39
 
@@ -45,20 +45,20 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'ReferenceResultSerializer can only serialize ReferenceResult objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( ReferenceResult $referenceResult ) {
59
+	private function getSerialized(ReferenceResult $referenceResult) {
60 60
 		return [
61
-			'reference' => $this->referenceSerializer->serialize( $referenceResult->getReference() ),
61
+			'reference' => $this->referenceSerializer->serialize($referenceResult->getReference()),
62 62
 			'status' => $referenceResult->getStatus()
63 63
 		];
64 64
 	}
Please login to merge, or discard this patch.