wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/Comparer/DataValueComparer.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue );
+	public function canCompare(DataValue $value, DataValue $comparativeValue);
 
 	/**
 	 * Runs the comparison of two DataValues.
@@ -28,6 +28,6 @@ 
 	 *
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue );
+	public function compare(DataValue $value, DataValue $comparativeValue);
 
 }

includes/CrossCheck/Comparer/DataValueComparerFactory.php

Spacing +2 added lines, -2 removed lines

@@ -26,7 +26,7 @@ 
 	 * @param TermIndex $termIndex
 	 * @param StringNormalizer $stringNormalizer
 	 */
-	public function __construct( TermIndex $termIndex, StringNormalizer $stringNormalizer ) {
+	public function __construct(TermIndex $termIndex, StringNormalizer $stringNormalizer) {
 		$this->termIndex = $termIndex;
 		$this->stringNormalizer = $stringNormalizer;
 	}
@@ -68,7 +68,7 @@ 
 	 * @return StringComparer
 	 */
 	private function newStringComparer() {
-		return new StringComparer( $this->stringNormalizer );
+		return new StringComparer($this->stringNormalizer);
 	}
 
 	/**

includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php

Spacing +8 added lines, -8 removed lines

@@ -23,9 +23,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -39,14 +39,14 @@ 
 		$extLat = $comparativeValue->getLatitude();
 		$extLong = $comparativeValue->getLongitude();
 
-		$diffLat = abs( $locLat - $extLat );
-		$diffLong = abs( $locLong - $extLong );
-		if ( ( $diffLat <= $precision ) && ( $diffLong <= $precision ) ) {
+		$diffLat = abs($locLat - $extLat);
+		$diffLong = abs($locLong - $extLong);
+		if (($diffLat <= $precision) && ($diffLong <= $precision)) {
 			return ComparisonResult::STATUS_MATCH;
 		}
 
 		$daumen = $precision;
-		if ( ( $diffLat <= pi() * $daumen ) && ( $diffLong <= pi() * $daumen ) ) {
+		if (($diffLat <= pi() * $daumen) && ($diffLong <= pi() * $daumen)) {
 			return ComparisonResult::STATUS_PARTIAL_MATCH;
 		}
 
@@ -60,7 +60,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof GlobeCoordinateValue && $comparativeValue instanceof GlobeCoordinateValue;
 	}
 

includes/CrossCheck/Comparer/MonolingualTextValueComparer.php

Spacing +7 added lines, -7 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param StringComparer $stringComparer
 	 */
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -35,9 +35,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -45,8 +45,8 @@ 
 		 * @var MonolingualTextValue $comparativeValue
 		 */
 
-		if ( $value->getLanguageCode() === $comparativeValue->getLanguageCode() ) {
-			return $this->stringComparer->compare( $value->getText(), $comparativeValue->getText() );
+		if ($value->getLanguageCode() === $comparativeValue->getLanguageCode()) {
+			return $this->stringComparer->compare($value->getText(), $comparativeValue->getText());
 		}
 
 		return null;
@@ -59,7 +59,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof MonolingualTextValue && $comparativeValue instanceof MonolingualTextValue;
 	}
 

includes/CrossCheck/Comparer/MultilingualTextValueComparer.php

Spacing +11 added lines, -11 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param StringComparer $stringComparer
 	 */
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -35,9 +35,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -47,21 +47,21 @@ 
 
 		$texts = $value->getTexts();
 		$comparativeTexts = $comparativeValue->getTexts();
-		$commonLanguages = array_intersect( array_keys( $texts ), array_keys( $comparativeTexts ) );
+		$commonLanguages = array_intersect(array_keys($texts), array_keys($comparativeTexts));
 
-		if ( $commonLanguages ) {
+		if ($commonLanguages) {
 			$totalResult = ComparisonResult::STATUS_MISMATCH;
 
-			foreach ( $commonLanguages as $language ) {
+			foreach ($commonLanguages as $language) {
 				$monolingualText = $texts[$language];
 				$comparativeMonolingualText = $comparativeTexts[$language];
 
-				$result = $this->stringComparer->compare( $monolingualText->getText(), $comparativeMonolingualText->getText() );
-				if ( $result !== ComparisonResult::STATUS_MISMATCH ) {
+				$result = $this->stringComparer->compare($monolingualText->getText(), $comparativeMonolingualText->getText());
+				if ($result !== ComparisonResult::STATUS_MISMATCH) {
 					$totalResult = $result;
 
 					// FIXME: This reports a partial match in a single language as a full match!
-					if ( $result === ComparisonResult::STATUS_MATCH ) {
+					if ($result === ComparisonResult::STATUS_MATCH) {
 						break;
 					}
 				}
@@ -80,7 +80,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof MultilingualTextValue && $comparativeValue instanceof MultilingualTextValue;
 	}
 

includes/CrossCheck/Comparer/StringValueComparer.php

Spacing +6 added lines, -6 removed lines

@@ -21,7 +21,7 @@ 
 	/**
 	 * @param StringComparer $stringComparer
 	 */
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -34,12 +34,12 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
-		return $this->stringComparer->compare( $value->getValue(), $comparativeValue->getValue() );
+		return $this->stringComparer->compare($value->getValue(), $comparativeValue->getValue());
 	}
 
 	/**
@@ -49,7 +49,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof StringValue && $comparativeValue instanceof StringValue;
 	}
 

includes/CrossCheck/Result/CrossCheckResult.php

Spacing +4 added lines, -4 removed lines

@@ -65,14 +65,14 @@
 	 * @param ReferenceResult $referenceResult
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( PropertyId $propertyId,
+	public function __construct(PropertyId $propertyId,
 								 $claimGuid,
 								 $externalId,
 								 DumpMetaInformation $dumpMetaInformation,
 								 ComparisonResult $comparisonResult,
-								 ReferenceResult $referenceResult ) {
-		Assert::parameterType( 'string', $claimGuid, '$claimGuid' );
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+								 ReferenceResult $referenceResult) {
+		Assert::parameterType('string', $claimGuid, '$claimGuid');
+		Assert::parameterType('string', $externalId, '$externalId');
 
 		$this->propertyId = $propertyId;
 		$this->claimGuid = $claimGuid;

includes/CrossCheck/ValueParser/StringValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
 	/**
 	 * @param StringNormalizer $stringNormalizer
 	 */
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -28,10 +28,10 @@ 
 	 *
 	 * @return StringValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
-		return new StringValue( $this->stringNormalizer->trimToNFC( $value ) );
+		return new StringValue($this->stringNormalizer->trimToNFC($value));
 	}
 
 }

includes/DumpMetaInformation/DumpMetaInformationStore.php

Spacing +1 added lines, -1 removed lines

@@ -15,6 +15,6 @@
 	 *
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 */
-	public function save( DumpMetaInformation $dumpMetaInformation );
+	public function save(DumpMetaInformation $dumpMetaInformation);
 
 }