wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/CrossCheckInteractor.php

Spacing +62 added lines, -62 removed lines

@@ -37,7 +37,7 @@ 
 	 */
 	private $crossChecker;
 
-	public function __construct( EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker ) {
+	public function __construct(EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker) {
 		$this->entityLookup = $entityLookup;
 		$this->statementGuidParser = $statementGuidParser;
 		$this->crossChecker = $crossChecker;
@@ -50,11 +50,11 @@ 
 	 *
 	 * @return CrossCheckResultList|null
 	 */
-	public function crossCheckEntityById( EntityId $entityId ) {
-		$entity = $this->entityLookup->getEntity( $entityId );
+	public function crossCheckEntityById(EntityId $entityId) {
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
-			return $this->crossCheckStatements( $entity->getStatements() );
+		if ($entity instanceof StatementListProvider) {
+			return $this->crossCheckStatements($entity->getStatements());
 		}
 
 		return null;
@@ -67,12 +67,12 @@ 
 	 *
 	 * @return CrossCheckResultList[]
 	 */
-	public function crossCheckEntitiesByIds( array $entityIds ) {
-		Assert::parameterElementType( EntityId::class,  $entityIds, '$entityIds' );
+	public function crossCheckEntitiesByIds(array $entityIds) {
+		Assert::parameterElementType(EntityId::class, $entityIds, '$entityIds');
 
 		$results = [];
-		foreach ( $entityIds as $entityId ) {
-			$results[$entityId->getSerialization()] = $this->crossCheckEntityById( $entityId );
+		foreach ($entityIds as $entityId) {
+			$results[$entityId->getSerialization()] = $this->crossCheckEntityById($entityId);
 		}
 
 		return $results;
@@ -85,8 +85,8 @@ 
 	 *
 	 * @return CrossCheckResultList
 	 */
-	public function crossCheckStatements( StatementList $statements ) {
-		return $this->crossChecker->crossCheckStatements( $statements, $statements );
+	public function crossCheckStatements(StatementList $statements) {
+		return $this->crossChecker->crossCheckStatements($statements, $statements);
 	}
 
 	/**
@@ -97,14 +97,14 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntities( array $entities ) {
-		Assert::parameterElementType( EntityDocument::class,  $entities, '$entities' );
+	public function crossCheckEntities(array $entities) {
+		Assert::parameterElementType(EntityDocument::class, $entities, '$entities');
 
 		$results = [];
-		foreach ( $entities as $entity ) {
+		foreach ($entities as $entity) {
 			$entityId = $entity->getId()->getSerialization();
-			if ( $entity instanceof StatementListProvider ) {
-				$results[$entityId] = $this->crossCheckStatements( $entity->getStatements() );
+			if ($entity instanceof StatementListProvider) {
+				$results[$entityId] = $this->crossCheckStatements($entity->getStatements());
 			}
 		}
 
@@ -120,13 +120,13 @@ 
 	 * @return CrossCheckResultList|null
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntityByIdWithProperties( EntityId $entityId, array $propertyIds ) {
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckEntityByIdWithProperties(EntityId $entityId, array $propertyIds) {
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
-		$entity = $this->entityLookup->getEntity( $entityId );
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
-			return $this->crossCheckStatementsWithProperties( $entity->getStatements(), $propertyIds );
+		if ($entity instanceof StatementListProvider) {
+			return $this->crossCheckStatementsWithProperties($entity->getStatements(), $propertyIds);
 		}
 
 		return null;
@@ -141,13 +141,13 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntitiesByIdWithProperties( array $entityIds, array $propertyIds ) {
-		Assert::parameterElementType( EntityId::class,  $entityIds, '$entityIds' );
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckEntitiesByIdWithProperties(array $entityIds, array $propertyIds) {
+		Assert::parameterElementType(EntityId::class, $entityIds, '$entityIds');
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
 		$results = [];
-		foreach ( $entityIds as $entityId ) {
-			$results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties( $entityId, $propertyIds );
+		foreach ($entityIds as $entityId) {
+			$results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties($entityId, $propertyIds);
 		}
 
 		return $results;
@@ -162,17 +162,17 @@ 
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementsWithProperties( StatementList $entityStatements, array $propertyIds ) {
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckStatementsWithProperties(StatementList $entityStatements, array $propertyIds) {
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
 		$statements = new StatementList();
-		foreach ( $entityStatements->toArray() as $statement ) {
-			if ( in_array( $statement->getPropertyId(), $propertyIds ) ) {
-				$statements->addStatement( $statement );
+		foreach ($entityStatements->toArray() as $statement) {
+			if (in_array($statement->getPropertyId(), $propertyIds)) {
+				$statements->addStatement($statement);
 			}
 		}
 
-		return $this->crossChecker->crossCheckStatements( $entityStatements, $statements );
+		return $this->crossChecker->crossCheckStatements($entityStatements, $statements);
 	}
 
 	/**
@@ -184,14 +184,14 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntitiesWithProperties( array $entities, array $propertyIds ) {
-		Assert::parameterElementType( EntityDocument::class,  $entities, '$entities' );
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckEntitiesWithProperties(array $entities, array $propertyIds) {
+		Assert::parameterElementType(EntityDocument::class, $entities, '$entities');
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
 		$results = [];
-		foreach ( $entities as $entity ) {
+		foreach ($entities as $entity) {
 			$entityId = $entity->getId()->getSerialization();
-			if ( $entity instanceof StatementListProvider ) {
+			if ($entity instanceof StatementListProvider) {
 				$results[$entityId] = $this->crossCheckStatementsWithProperties(
 					$entity->getStatements(),
 					$propertyIds
@@ -210,12 +210,12 @@ 
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementByGuid( $guid ) {
-		$this->assertIsString( $guid, '$guid' );
+	public function crossCheckStatementByGuid($guid) {
+		$this->assertIsString($guid, '$guid');
 
-		$resultList = $this->crossCheckStatementsByGuids( [ $guid ] );
+		$resultList = $this->crossCheckStatementsByGuids([$guid]);
 
-		return reset( $resultList );
+		return reset($resultList);
 	}
 
 	/**
@@ -226,21 +226,21 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementsByGuids( array $guids ) {
-		$this->assertIsArrayOfStrings( $guids, '$guids' );
+	public function crossCheckStatementsByGuids(array $guids) {
+		$this->assertIsArrayOfStrings($guids, '$guids');
 
 		$entityIds = [];
 		$groupedStatementGuids = [];
-		foreach ( $guids as $guid ) {
-			$serializedEntityId = $this->statementGuidParser->parse( $guid )->getEntityId();
+		foreach ($guids as $guid) {
+			$serializedEntityId = $this->statementGuidParser->parse($guid)->getEntityId();
 			$entityIds[$serializedEntityId->getSerialization()] = $serializedEntityId;
 			$groupedStatementGuids[$serializedEntityId->getSerialization()][] = $guid;
 		}
 
 		$resultLists = [];
-		foreach ( $groupedStatementGuids as $serializedEntityId => $guidsOfEntity ) {
-			$entityId = $entityIds[ $serializedEntityId ];
-			$resultLists[ $serializedEntityId ] = $this->crossCheckClaimsOfEntity( $entityId, $guidsOfEntity );
+		foreach ($groupedStatementGuids as $serializedEntityId => $guidsOfEntity) {
+			$entityId = $entityIds[$serializedEntityId];
+			$resultLists[$serializedEntityId] = $this->crossCheckClaimsOfEntity($entityId, $guidsOfEntity);
 		}
 
 		return $resultLists;
@@ -252,18 +252,18 @@ 
 	 *
 	 * @return CrossCheckResultList|null
 	 */
-	private function crossCheckClaimsOfEntity( EntityId $entityId, array $guids ) {
-		$entity = $this->entityLookup->getEntity( $entityId );
+	private function crossCheckClaimsOfEntity(EntityId $entityId, array $guids) {
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
+		if ($entity instanceof StatementListProvider) {
 			$statements = new StatementList();
-			foreach ( $entity->getStatements()->toArray() as $statement ) {
-				if ( in_array( $statement->getGuid(), $guids ) ) {
-					$statements->addStatement( $statement );
+			foreach ($entity->getStatements()->toArray() as $statement) {
+				if (in_array($statement->getGuid(), $guids)) {
+					$statements->addStatement($statement);
 				}
 			}
 
-			return $this->crossChecker->crossCheckStatements( $entity->getStatements(), $statements );
+			return $this->crossChecker->crossCheckStatements($entity->getStatements(), $statements);
 		}
 
 		return null;
@@ -275,9 +275,9 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function assertIsString( $string, $parameterName ) {
-		if ( !is_string( $string ) ) {
-			throw new InvalidArgumentException( "$parameterName must be string." );
+	private function assertIsString($string, $parameterName) {
+		if (!is_string($string)) {
+			throw new InvalidArgumentException("$parameterName must be string.");
 		}
 	}
 
@@ -287,10 +287,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function assertIsArrayOfStrings( array $strings, $parameterName ) {
-		foreach ( $strings as $string ) {
-			if ( !is_string( $string ) ) {
-				throw new InvalidArgumentException( "Each element of $parameterName must be string." );
+	private function assertIsArrayOfStrings(array $strings, $parameterName) {
+		foreach ($strings as $string) {
+			if (!is_string($string)) {
+				throw new InvalidArgumentException("Each element of $parameterName must be string.");
 			}
 		}
 	}

includes/CrossCheck/Comparer/StringValueComparer.php

Spacing +6 added lines, -6 removed lines

@@ -17,7 +17,7 @@ 
 	 */
 	private $stringComparer;
 
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -30,12 +30,12 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
-		return $this->stringComparer->compare( $value->getValue(), $comparativeValue->getValue() );
+		return $this->stringComparer->compare($value->getValue(), $comparativeValue->getValue());
 	}
 
 	/**
@@ -45,7 +45,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof StringValue && $comparativeValue instanceof StringValue;
 	}
 

includes/CrossCheck/Comparer/EntityIdValueComparer.php

Spacing +11 added lines, -11 removed lines

@@ -27,7 +27,7 @@ 
 	 */
 	private $stringComparer;
 
-	public function __construct( TermIndex $termIndex, StringComparer $stringComparer ) {
+	public function __construct(TermIndex $termIndex, StringComparer $stringComparer) {
 		$this->termIndex = $termIndex;
 		$this->stringComparer = $stringComparer;
 	}
@@ -40,9 +40,9 @@ 
 	 *
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		Assert::parameterType( EntityIdValue::class, $value, '$value' );
-		Assert::parameterType( MonolingualTextValue::class, $comparativeValue, '$comparativeValue' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		Assert::parameterType(EntityIdValue::class, $value, '$value');
+		Assert::parameterType(MonolingualTextValue::class, $comparativeValue, '$comparativeValue');
 
 		/**
 		 * @var EntityIdValue $value
@@ -51,10 +51,10 @@ 
 
 		$entityId = $value->getEntityId();
 		$language = $comparativeValue->getLanguageCode();
-		$terms = $this->getTerms( $entityId, $language );
+		$terms = $this->getTerms($entityId, $language);
 
-		if ( $terms ) {
-			return $this->stringComparer->compareWithArray( $comparativeValue->getText(), $terms );
+		if ($terms) {
+			return $this->stringComparer->compareWithArray($comparativeValue->getText(), $terms);
 		}
 
 		return null;
@@ -68,18 +68,18 @@ 
 	 *
 	 * @return array
 	 */
-	private function getTerms( EntityId $entityId, $language ) {
+	private function getTerms(EntityId $entityId, $language) {
 		$terms = $this->termIndex->getTermsOfEntity(
 			$entityId,
 			[
 				TermIndexEntry::TYPE_LABEL,
 				TermIndexEntry::TYPE_ALIAS
 			],
-			[ $language ]
+			[$language]
 		);
 
 		return array_map(
-			function( TermIndexEntry $term ) {
+			function(TermIndexEntry $term) {
 				return $term->getText();
 			},
 			$terms
@@ -93,7 +93,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof EntityIdValue && $comparativeValue instanceof MonolingualTextValue;
 	}
 

includes/CrossCheck/Comparer/MonolingualTextValueComparer.php

Spacing +7 added lines, -7 removed lines

@@ -17,7 +17,7 @@ 
 	 */
 	private $stringComparer;
 
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -30,9 +30,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -40,8 +40,8 @@ 
 		 * @var MonolingualTextValue $comparativeValue
 		 */
 
-		if ( $value->getLanguageCode() === $comparativeValue->getLanguageCode() ) {
-			return $this->stringComparer->compare( $value->getText(), $comparativeValue->getText() );
+		if ($value->getLanguageCode() === $comparativeValue->getLanguageCode()) {
+			return $this->stringComparer->compare($value->getText(), $comparativeValue->getText());
 		}
 
 		return null;
@@ -54,7 +54,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof MonolingualTextValue && $comparativeValue instanceof MonolingualTextValue;
 	}
 

includes/CrossCheck/Comparer/MultilingualTextValueComparer.php

Spacing +11 added lines, -11 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $stringComparer;
 
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -31,9 +31,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -43,21 +43,21 @@ 
 
 		$texts = $value->getTexts();
 		$comparativeTexts = $comparativeValue->getTexts();
-		$commonLanguages = array_intersect( array_keys( $texts ), array_keys( $comparativeTexts ) );
+		$commonLanguages = array_intersect(array_keys($texts), array_keys($comparativeTexts));
 
-		if ( $commonLanguages ) {
+		if ($commonLanguages) {
 			$totalResult = ComparisonResult::STATUS_MISMATCH;
 
-			foreach ( $commonLanguages as $language ) {
+			foreach ($commonLanguages as $language) {
 				$monolingualText = $texts[$language];
 				$comparativeMonolingualText = $comparativeTexts[$language];
 
-				$result = $this->stringComparer->compare( $monolingualText->getText(), $comparativeMonolingualText->getText() );
-				if ( $result !== ComparisonResult::STATUS_MISMATCH ) {
+				$result = $this->stringComparer->compare($monolingualText->getText(), $comparativeMonolingualText->getText());
+				if ($result !== ComparisonResult::STATUS_MISMATCH) {
 					$totalResult = $result;
 
 					// FIXME: This reports a partial match in a single language as a full match!
-					if ( $result === ComparisonResult::STATUS_MATCH ) {
+					if ($result === ComparisonResult::STATUS_MATCH) {
 						break;
 					}
 				}
@@ -76,7 +76,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof MultilingualTextValue && $comparativeValue instanceof MultilingualTextValue;
 	}
 

includes/CrossCheck/Comparer/StringComparer.php

Spacing +40 added lines, -40 removed lines

@@ -22,7 +22,7 @@ 
 	 */
 	private $stringNormalizer;
 
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -33,16 +33,16 @@ 
 	 * @param string $comparativeValue
 	 * @return string
 	 */
-	public function compare( $value, $comparativeValue ) {
-		Assert::parameterType( 'string', $value, '$value' );
-		Assert::parameterType( 'string', $comparativeValue, '$comparativeValue' );
+	public function compare($value, $comparativeValue) {
+		Assert::parameterType('string', $value, '$value');
+		Assert::parameterType('string', $comparativeValue, '$comparativeValue');
 
-		$value = $this->cleanDataString( $value );
-		$comparativeValue = $this->cleanDataString( $comparativeValue );
+		$value = $this->cleanDataString($value);
+		$comparativeValue = $this->cleanDataString($comparativeValue);
 
-		if ( $value === $comparativeValue ) {
+		if ($value === $comparativeValue) {
 			return ComparisonResult::STATUS_MATCH;
-		} elseif ( $this->checkSimilarity( $value, $comparativeValue ) ) {
+		} elseif ($this->checkSimilarity($value, $comparativeValue)) {
 			return ComparisonResult::STATUS_PARTIAL_MATCH;
 		} else {
 			return ComparisonResult::STATUS_MISMATCH;
@@ -56,19 +56,19 @@ 
 	 * @param array $comparativeValues
 	 * @return string
 	 */
-	public function compareWithArray( $value, array $comparativeValues ) {
-		Assert::parameterType( 'string', $value, '$value' );
-		Assert::parameterElementType( 'string', $comparativeValues, '$comparativeValues' );
+	public function compareWithArray($value, array $comparativeValues) {
+		Assert::parameterType('string', $value, '$value');
+		Assert::parameterElementType('string', $comparativeValues, '$comparativeValues');
 
-		$value = $this->cleanDataString( $value );
-		$comparativeValues = $this->cleanDataArray( $comparativeValues );
+		$value = $this->cleanDataString($value);
+		$comparativeValues = $this->cleanDataArray($comparativeValues);
 
-		if ( in_array( $value, $comparativeValues ) ) {
+		if (in_array($value, $comparativeValues)) {
 			return ComparisonResult::STATUS_MATCH;
 		}
 
-		foreach ( $comparativeValues as $comparativeValue ) {
-			if ( $this->checkSimilarity( $comparativeValue, $value ) ) {
+		foreach ($comparativeValues as $comparativeValue) {
+			if ($this->checkSimilarity($comparativeValue, $value)) {
 				return ComparisonResult::STATUS_PARTIAL_MATCH;
 			}
 		}
@@ -83,11 +83,11 @@ 
 	 * @param string $comparativeValue
 	 * @return bool
 	 */
-	private function checkSimilarity( $value, $comparativeValue ) {
+	private function checkSimilarity($value, $comparativeValue) {
 		return
-			$this->percentagePrefixSimilarity( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD ||
-			$this->percentageSuffixSimilarity( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD ||
-			$this->percentageLevenshteinDistance( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD;
+			$this->percentagePrefixSimilarity($value, $comparativeValue) > self::SIMILARITY_THRESHOLD ||
+			$this->percentageSuffixSimilarity($value, $comparativeValue) > self::SIMILARITY_THRESHOLD ||
+			$this->percentageLevenshteinDistance($value, $comparativeValue) > self::SIMILARITY_THRESHOLD;
 	}
 
 	/**
@@ -97,10 +97,10 @@ 
 	 *
 	 * @return string
 	 */
-	private function cleanDataString( $value ) {
-		$value = $this->stringNormalizer->trimToNFC( $value );
+	private function cleanDataString($value) {
+		$value = $this->stringNormalizer->trimToNFC($value);
 
-		return mb_strtolower( $value );
+		return mb_strtolower($value);
 	}
 
 	/**
@@ -110,10 +110,10 @@ 
 	 *
 	 * @return array
 	 */
-	private function cleanDataArray( array $array ) {
+	private function cleanDataArray(array $array) {
 
 		return array_map(
-			[ $this, 'cleanDataString' ],
+			[$this, 'cleanDataString'],
 			$array );
 	}
 
@@ -125,19 +125,19 @@ 
 	 *
 	 * @return float
 	 */
-	private function percentagePrefixSimilarity( $value, $comparativeValue ) {
+	private function percentagePrefixSimilarity($value, $comparativeValue) {
 		$prefixLength = 0; // common prefix length
-		$localLength = strlen( $value );
-		$externalLength = strlen( $comparativeValue );
-		while ( $prefixLength < min( $localLength, $externalLength ) ) {
+		$localLength = strlen($value);
+		$externalLength = strlen($comparativeValue);
+		while ($prefixLength < min($localLength, $externalLength)) {
 			$c = $value[$prefixLength];
-			if ( $externalLength > $prefixLength && $comparativeValue[$prefixLength] !== $c ) {
+			if ($externalLength > $prefixLength && $comparativeValue[$prefixLength] !== $c) {
 				break;
 			}
 			$prefixLength++;
 		}
 
-		return $prefixLength / max( $localLength, $externalLength );
+		return $prefixLength / max($localLength, $externalLength);
 	}
 
 	/**
@@ -148,19 +148,19 @@ 
 	 *
 	 * @return float
 	 */
-	private function percentageSuffixSimilarity( $value, $comparativeValue ) {
+	private function percentageSuffixSimilarity($value, $comparativeValue) {
 		$suffixLength = 0; // common suffix length
-		$localLength = strlen( $value );
-		$externalLength = strlen( $comparativeValue );
-		while ( $suffixLength < min( $localLength, $externalLength ) ) {
+		$localLength = strlen($value);
+		$externalLength = strlen($comparativeValue);
+		while ($suffixLength < min($localLength, $externalLength)) {
 			$c = $value[$localLength - 1 - $suffixLength];
-			if ( $externalLength > $suffixLength && $comparativeValue[$externalLength - 1 - $suffixLength] !== $c ) {
+			if ($externalLength > $suffixLength && $comparativeValue[$externalLength - 1 - $suffixLength] !== $c) {
 				break;
 			}
 			$suffixLength++;
 		}
 
-		return $suffixLength / max( $localLength, $externalLength );
+		return $suffixLength / max($localLength, $externalLength);
 	}
 
 	/**
@@ -171,9 +171,9 @@ 
 	 *
 	 * @return float
 	 */
-	private function percentageLevenshteinDistance( $value, $comparativeValue ) {
-		$distance = levenshtein( $value, $comparativeValue );
-		$percentage = 1.0 - $distance / max( strlen( $value ), strlen( $comparativeValue ) );
+	private function percentageLevenshteinDistance($value, $comparativeValue) {
+		$distance = levenshtein($value, $comparativeValue);
+		$percentage = 1.0 - $distance / max(strlen($value), strlen($comparativeValue));
 
 		return $percentage;
 	}

includes/CrossCheck/Comparer/DataValueComparerFactory.php

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
 	 */
 	private $stringNormalizer;
 
-	public function __construct( TermIndex $termIndex, StringNormalizer $stringNormalizer ) {
+	public function __construct(TermIndex $termIndex, StringNormalizer $stringNormalizer) {
 		$this->termIndex = $termIndex;
 		$this->stringNormalizer = $stringNormalizer;
 	}
@@ -63,7 +63,7 @@ 
 	 * @return StringComparer
 	 */
 	private function newStringComparer() {
-		return new StringComparer( $this->stringNormalizer );
+		return new StringComparer($this->stringNormalizer);
 	}
 
 	/**

includes/CrossCheck/ValueParser/StringValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $stringNormalizer;
 
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -29,10 +29,10 @@ 
 	 *
 	 * @return StringValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
-		return new StringValue( $this->stringNormalizer->trimToNFC( $value ) );
+		return new StringValue($this->stringNormalizer->trimToNFC($value));
 	}
 
 }

includes/CrossCheck/ValueParser/MultilingualTextValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
 	 */
 	private $monolingualTextValueParser;
 
-	public function __construct( ValueParser $monolingualTextValueParser ) {
+	public function __construct(ValueParser $monolingualTextValueParser) {
 		$this->monolingualTextValueParser = $monolingualTextValueParser;
 	}
 
@@ -28,11 +28,11 @@ 
 	 *
 	 * @return MultilingualTextValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
 		return new MultilingualTextValue(
-			[ $this->monolingualTextValueParser->parse( $value ) ]
+			[$this->monolingualTextValueParser->parse($value)]
 		);
 	}