wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/Result/ComparisonResult.php

Spacing +8 added lines, -8 removed lines

@@ -45,12 +45,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( DataValue $localValue, array $externalValues, $status ) {
-		Assert::parameterElementType( DataValue::class, $externalValues, '$externalValues' );
+	public function __construct(DataValue $localValue, array $externalValues, $status) {
+		Assert::parameterElementType(DataValue::class, $externalValues, '$externalValues');
 
 		$this->localValue = $localValue;
 		$this->externalValues = $externalValues;
-		$this->setStatus( $status );
+		$this->setStatus($status);
 	}
 
 	/**
@@ -79,14 +79,14 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setStatus( $status ) {
-		Assert::parameterType( 'string', $status, '$status' );
-		if ( !in_array(
+	private function setStatus($status) {
+		Assert::parameterType('string', $status, '$status');
+		if (!in_array(
 			$status,
-			[ self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH ]
+			[self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH]
 		)
 		) {
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
+			throw new InvalidArgumentException('$status must be one of the status constants.');
 		}
 
 		$this->status = $status;

includes/CrossCheck/Result/ReferenceResult.php

Spacing +7 added lines, -7 removed lines

@@ -36,10 +36,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $status, Reference $reference ) {
+	public function __construct($status, Reference $reference) {
 
 		$this->reference = $reference;
-		$this->setStatus( $status );
+		$this->setStatus($status);
 	}
 
 	/**
@@ -61,14 +61,14 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setStatus( $status ) {
-		Assert::parameterType( 'string', $status, '$status' );
-		if ( !in_array(
+	private function setStatus($status) {
+		Assert::parameterType('string', $status, '$status');
+		if (!in_array(
 			$status,
-			[ self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED ]
+			[self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED]
 		)
 		) {
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
+			throw new InvalidArgumentException('$status must be one of the status constants.');
 		}
 
 		$this->status = $status;

includes/CrossCheck/Result/CrossCheckResultList.php

Spacing +13 added lines, -13 removed lines

@@ -26,8 +26,8 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( array $results = [] ) {
-		Assert::parameterElementType( CrossCheckResult::class, $results, '$results' );
+	public function __construct(array $results = []) {
+		Assert::parameterElementType(CrossCheckResult::class, $results, '$results');
 
 		$this->results = $results;
 	}
@@ -37,7 +37,7 @@ 
 	 *
 	 * @param CrossCheckResult $result
 	 */
-	public function add( CrossCheckResult $result ) {
+	public function add(CrossCheckResult $result) {
 		$this->results[] = $result;
 	}
 
@@ -46,8 +46,8 @@ 
 	 *
 	 * @param self $resultList
 	 */
-	public function merge( self $resultList ) {
-		$this->results = array_merge( $this->results, $resultList->results );
+	public function merge(self $resultList) {
+		$this->results = array_merge($this->results, $resultList->results);
 	}
 
 	/**
@@ -58,9 +58,9 @@ 
 	public function getPropertyIds() {
 		$propertyIds = [];
 
-		foreach ( $this->results as $result ) {
+		foreach ($this->results as $result) {
 			$propertyId = $result->getPropertyId();
-			if ( !in_array( $propertyId, $propertyIds ) ) {
+			if (!in_array($propertyId, $propertyIds)) {
 				$propertyIds[] = $propertyId;
 			}
 		}
@@ -75,16 +75,16 @@ 
 	 *
 	 * @return self
 	 */
-	public function getByPropertyId( PropertyId $propertyId ) {
+	public function getByPropertyId(PropertyId $propertyId) {
 		$results = [];
 
-		foreach ( $this->results as $result ) {
-			if ( $result->getPropertyId()->equals( $propertyId ) ) {
+		foreach ($this->results as $result) {
+			if ($result->getPropertyId()->equals($propertyId)) {
 				$results[] = $result;
 			}
 		}
 
-		return new self( $results );
+		return new self($results);
 	}
 
 	/**
@@ -103,7 +103,7 @@ 
 	 * @codeCoverageIgnore
 	 */
 	public function getIterator() {
-		return new ArrayIterator( $this->results );
+		return new ArrayIterator($this->results);
 	}
 
 	/**
@@ -112,7 +112,7 @@ 
 	 * @return int
 	 */
 	public function count() {
-		return count( $this->results );
+		return count($this->results);
 	}
 
 }

includes/CrossCheck/Comparer/DispatchingDataValueComparer.php

Spacing +12 added lines, -12 removed lines

@@ -20,8 +20,8 @@ 
 	/**
 	 * @param DataValueComparer[] $dataValueComparers
 	 */
-	public function __construct( array $dataValueComparers = [] ) {
-		$this->assertAreDataValueComparer( $dataValueComparers );
+	public function __construct(array $dataValueComparers = []) {
+		$this->assertAreDataValueComparer($dataValueComparers);
 		$this->dataValueComparers = $dataValueComparers;
 	}
 
@@ -30,9 +30,9 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	protected function assertAreDataValueComparer( array $dataValueComparers ) {
-		foreach ( $dataValueComparers as $dataValueComparer ) {
-			if ( !is_object( $dataValueComparer ) || !( $dataValueComparer instanceof DataValueComparer ) ) {
+	protected function assertAreDataValueComparer(array $dataValueComparers) {
+		foreach ($dataValueComparers as $dataValueComparer) {
+			if (!is_object($dataValueComparer) || !($dataValueComparer instanceof DataValueComparer)) {
 				throw new InvalidArgumentException(
 					'All $dataValueComparers need to implement the DataValueComparer interface'
 				);
@@ -48,9 +48,9 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
-		foreach ( $this->dataValueComparers as $dataValueComparer ) {
-			if ( $dataValueComparer->canCompare( $value, $comparativeValue ) ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
+		foreach ($this->dataValueComparers as $dataValueComparer) {
+			if ($dataValueComparer->canCompare($value, $comparativeValue)) {
 				return true;
 			}
 		}
@@ -67,10 +67,10 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		foreach ( $this->dataValueComparers as $dataValueComparer ) {
-			if ( $dataValueComparer->canCompare( $value, $comparativeValue ) ) {
-				return $dataValueComparer->compare( $value, $comparativeValue );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		foreach ($this->dataValueComparers as $dataValueComparer) {
+			if ($dataValueComparer->canCompare($value, $comparativeValue)) {
+				return $dataValueComparer->compare($value, $comparativeValue);
 			}
 		}
 

includes/DumpMetaInformation/DumpMetaInformation.php

Spacing +29 added lines, -29 removed lines

@@ -99,13 +99,13 @@ 
 			'$identifierPropertyIds'
 		);
 
-		$this->setDumpId( $dumpId );
+		$this->setDumpId($dumpId);
 		$this->sourceItemId = $sourceItemId;
 		$this->identifierPropertyIds = $identifierPropertyIds;
-		$this->setImportDate( $importDate );
-		$this->setLanguageCode( $languageCode );
-		$this->setSourceUrl( $sourceUrl );
-		$this->setSize( $size );
+		$this->setImportDate($importDate);
+		$this->setLanguageCode($languageCode);
+		$this->setSourceUrl($sourceUrl);
+		$this->setSize($size);
 		$this->licenseItemId = $licenseItemId;
 	}
 
@@ -170,11 +170,11 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setDumpId( $dumpId ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		$length = strlen( $dumpId );
-		if ( $length < 1 || $length > 25 ) {
-			throw new InvalidArgumentException( '$dumpId must be between 1 and 25 characters.' );
+	private function setDumpId($dumpId) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		$length = strlen($dumpId);
+		if ($length < 1 || $length > 25) {
+			throw new InvalidArgumentException('$dumpId must be between 1 and 25 characters.');
 		}
 
 		$this->dumpId = $dumpId;
@@ -185,10 +185,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setLanguageCode( $languageCode ) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
-		if ( !Language::isValidCode( $languageCode ) ) {
-			throw new InvalidArgumentException( '$languageCode is not valid.' );
+	private function setLanguageCode($languageCode) {
+		Assert::parameterType('string', $languageCode, '$languageCode');
+		if (!Language::isValidCode($languageCode)) {
+			throw new InvalidArgumentException('$languageCode is not valid.');
 		}
 
 		$this->languageCode = $languageCode;
@@ -199,12 +199,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setImportDate( $importDate ) {
-		Assert::parameterType( 'string', $importDate, '$importDate' );
+	private function setImportDate($importDate) {
+		Assert::parameterType('string', $importDate, '$importDate');
 
-		$timestamp = wfTimestamp( TS_MW, $importDate );
-		if ( !$timestamp ) {
-			throw new InvalidArgumentException( '$updatedAt has invalid timestamp format.' );
+		$timestamp = wfTimestamp(TS_MW, $importDate);
+		if (!$timestamp) {
+			throw new InvalidArgumentException('$updatedAt has invalid timestamp format.');
 		}
 
 		$this->importDate = $importDate;
@@ -215,13 +215,13 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setSourceUrl( $sourceUrl ) {
-		Assert::parameterType( 'string', $sourceUrl, '$sourceUrl' );
-		if ( strlen( $sourceUrl ) > 300 ) {
-			throw new InvalidArgumentException( '$sourceUrl must not be longer than 300 characters.' );
+	private function setSourceUrl($sourceUrl) {
+		Assert::parameterType('string', $sourceUrl, '$sourceUrl');
+		if (strlen($sourceUrl) > 300) {
+			throw new InvalidArgumentException('$sourceUrl must not be longer than 300 characters.');
 		}
-		if ( !filter_var( $sourceUrl, FILTER_VALIDATE_URL ) ) {
-			throw new InvalidArgumentException( '$sourceUrl is not a valid url.' );
+		if (!filter_var($sourceUrl, FILTER_VALIDATE_URL)) {
+			throw new InvalidArgumentException('$sourceUrl is not a valid url.');
 		}
 
 		$this->sourceUrl = $sourceUrl;
@@ -232,10 +232,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setSize( $size ) {
-		Assert::parameterType( 'integer', $size, '$size' );
-		if ( $size <= 0 ) {
-			throw new InvalidArgumentException( '$size must be positive integer.' );
+	private function setSize($size) {
+		Assert::parameterType('integer', $size, '$size');
+		if ($size <= 0) {
+			throw new InvalidArgumentException('$size must be positive integer.');
 		}
 
 		$this->size = $size;

includes/CrossCheck/Result/CrossCheckResult.php

Spacing +2 added lines, -2 removed lines

@@ -73,8 +73,8 @@
 		ComparisonResult $comparisonResult,
 		ReferenceResult $referenceResult
 	) {
-		Assert::parameterType( 'string', $claimGuid, '$claimGuid' );
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+		Assert::parameterType('string', $claimGuid, '$claimGuid');
+		Assert::parameterType('string', $externalId, '$externalId');
 
 		$this->propertyId = $propertyId;
 		$this->claimGuid = $claimGuid;

includes/ExternalValidationServices.php

Spacing +12 added lines, -12 removed lines

@@ -72,7 +72,7 @@ 
 	 *
 	 * @fixme inject specific things needed here instead of the WikibaseRepo factory. (T112105)
 	 */
-	public function __construct( WikibaseRepo $wikibaseRepo ) {
+	public function __construct(WikibaseRepo $wikibaseRepo) {
 		$this->wikibaseRepo = $wikibaseRepo;
 	}
 
@@ -85,10 +85,10 @@ 
 	public static function getDefaultInstance() {
 		static $instance = null;
 
-		if ( $instance === null ) {
+		if ($instance === null) {
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 
-			$instance = new self( $wikibaseRepo );
+			$instance = new self($wikibaseRepo);
 		}
 
 		return $instance;
@@ -98,7 +98,7 @@ 
 	 * @return CrossChecker
 	 */
 	public function getCrossChecker() {
-		if ( $this->crossChecker === null ) {
+		if ($this->crossChecker === null) {
 			$this->crossChecker = new CrossChecker(
 				$this->wikibaseRepo->getEntityLookup(),
 				$this->getComparativeValueParserFactory(),
@@ -116,7 +116,7 @@ 
 	 * @return CrossCheckInteractor
 	 */
 	public function getCrossCheckInteractor() {
-		if ( $this->crossCheckInteractor === null ) {
+		if ($this->crossCheckInteractor === null) {
 			$this->crossCheckInteractor = new CrossCheckInteractor(
 				$this->wikibaseRepo->getEntityLookup(),
 				$this->wikibaseRepo->getStatementGuidParser(),
@@ -131,7 +131,7 @@ 
 	 * @return ComparativeValueParserFactory
 	 */
 	public function getComparativeValueParserFactory() {
-		if ( $this->comparativeValueParserFactory === null ) {
+		if ($this->comparativeValueParserFactory === null) {
 			$this->comparativeValueParserFactory = new ComparativeValueParserFactory(
 				$this->wikibaseRepo->getDataTypeDefinitions(),
 				new StringNormalizer()
@@ -145,7 +145,7 @@ 
 	 * @return DataValueComparerFactory
 	 */
 	public function getDataValueComparerFactory() {
-		if ( $this->dataValueComparerFactory === null ) {
+		if ($this->dataValueComparerFactory === null) {
 			$this->dataValueComparerFactory = new DataValueComparerFactory(
 				$this->wikibaseRepo->getStore()->getTermIndex(),
 				$this->wikibaseRepo->getStringNormalizer()
@@ -159,7 +159,7 @@ 
 	 * @return DumpMetaInformationLookup
 	 */
 	public function getDumpMetaInformationLookup() {
-		if ( $this->dumpMetaInformationLookup === null ) {
+		if ($this->dumpMetaInformationLookup === null) {
 			$this->dumpMetaInformationLookup = new SqlDumpMetaInformationRepo();
 		}
 
@@ -170,7 +170,7 @@ 
 	 * @return DumpMetaInformationStore
 	 */
 	public function getDumpMetaInformationStore() {
-		if ( $this->dumpMetaInformationStore === null ) {
+		if ($this->dumpMetaInformationStore === null) {
 			$this->dumpMetaInformationStore = new SqlDumpMetaInformationRepo();
 		}
 
@@ -181,7 +181,7 @@ 
 	 * @return ExternalDataRepo
 	 */
 	public function getExternalDataRepo() {
-		if ( $this->externalDataRepo === null ) {
+		if ($this->externalDataRepo === null) {
 			$this->externalDataRepo = new ExternalDataRepo();
 		}
 
@@ -192,9 +192,9 @@ 
 	 * @return SerializerFactory
 	 */
 	public function getSerializerFactory() {
-		if ( $this->serializerFactory === null ) {
+		if ($this->serializerFactory === null) {
 			$dataValueSerializer = new DataValueSerializer();
-			$dataModelSerializerFactory = new \Wikibase\DataModel\SerializerFactory( $dataValueSerializer );
+			$dataModelSerializerFactory = new \Wikibase\DataModel\SerializerFactory($dataValueSerializer);
 			$this->serializerFactory = new SerializerFactory(
 				$dataValueSerializer,
 				$dataModelSerializerFactory->newReferenceSerializer()

WikibaseQualityExternalValidation.php

Spacing +7 added lines, -7 removed lines

@@ -1,10 +1,10 @@ 
 <?php
 
-if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
-	require_once __DIR__ . '/vendor/autoload.php';
+if (is_readable(__DIR__.'/vendor/autoload.php')) {
+	require_once __DIR__.'/vendor/autoload.php';
 }
 
-call_user_func( function () {
+call_user_func(function() {
 	// Set credits
 	$GLOBALS['wgExtensionCredits']['wikibase'][] = [
 		'path' => __FILE__,
@@ -17,9 +17,9 @@ 
 	];
 
 	// Initialize localization and aliases
-	$GLOBALS['wgMessagesDirs']['WikibaseQualityExternalValidation'] = __DIR__ . '/i18n';
+	$GLOBALS['wgMessagesDirs']['WikibaseQualityExternalValidation'] = __DIR__.'/i18n';
 	$GLOBALS['wgExtensionMessagesFiles']['WikibaseQualityExternalValidationAlias'] =
-		__DIR__ . '/WikibaseQualityExternalValidation.alias.php';
+		__DIR__.'/WikibaseQualityExternalValidation.alias.php';
 
 	// Initalize hooks for creating database tables
 	$GLOBALS['wgHooks']['LoadExtensionSchemaUpdates'][] =
@@ -38,8 +38,8 @@ 
 	// Define API modules
 	$GLOBALS['wgAPIModules']['wbqevcrosscheck'] = [
 		'class' => WikibaseQuality\ExternalValidation\Api\RunCrossCheck::class,
-		'factory' => function( ApiMain $main, $action ) {
-			return WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState( $main, $action );
+		'factory' => function(ApiMain $main, $action) {
+			return WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState($main, $action);
 		}
 	];
 

includes/UpdateExternalData/ExternalDataImporter.php

Spacing +41 added lines, -41 removed lines

@@ -52,13 +52,13 @@ 
 	public function import() {
 		$dumpIds = $this->insertMetaInformation();
 
-		$this->log( "\nDelete old database entries...\n" );
+		$this->log("\nDelete old database entries...\n");
 
-		foreach ( $dumpIds as $dumpId ) {
-			$this->externalDataRepo->deleteOfDump( $dumpId, $this->importSettings->getBatchSize() );
+		foreach ($dumpIds as $dumpId) {
+			$this->externalDataRepo->deleteOfDump($dumpId, $this->importSettings->getBatchSize());
 		}
 
-		$this->log( "\n" );
+		$this->log("\n");
 
 		$this->insertExternalValues();
 	}
@@ -69,52 +69,52 @@ 
 	 * @return array
 	 */
 	protected function insertMetaInformation() {
-		$this->log( "Insert new dump meta information\n" );
+		$this->log("Insert new dump meta information\n");
 
-		$csvFile = fopen( $this->importSettings->getDumpInformationFilePath(), 'rb' );
-		if ( !$csvFile ) {
-			exit( 'Error while reading CSV file.' );
+		$csvFile = fopen($this->importSettings->getDumpInformationFilePath(), 'rb');
+		if (!$csvFile) {
+			exit('Error while reading CSV file.');
 		}
 
 		$i = 0;
 		$dumpIds = [];
-		while ( $data = fgetcsv( $csvFile ) ) {
+		while ($data = fgetcsv($csvFile)) {
 			$identifierPropertyIds = array_map(
-				function ( $propertyId ) {
-					return new PropertyId( $propertyId );
+				function($propertyId) {
+					return new PropertyId($propertyId);
 				},
-				json_decode( $data[2] )
+				json_decode($data[2])
 			);
 			try {
 				$dumpMetaInformation = new DumpMetaInformation(
 					$data[0],
-					new ItemId( $data[1] ),
+					new ItemId($data[1]),
 					$identifierPropertyIds,
 					$data[3],
 					$data[4],
 					$data[5],
-					intval( $data[6] ),
-					new ItemId( $data[7] )
+					intval($data[6]),
+					new ItemId($data[7])
 				);
-			} catch ( \InvalidArgumentException $e ) {
-				exit( 'Input file has bad formatted values.' );
+			} catch (\InvalidArgumentException $e) {
+				exit('Input file has bad formatted values.');
 			}
 			$dumpIds[] = $dumpMetaInformation->getDumpId();
 
 			try {
-				$this->dumpMetaInformationStore->save( $dumpMetaInformation );
-			} catch ( DBError $e ) {
-				exit( 'Unknown database error occurred.' );
+				$this->dumpMetaInformationStore->save($dumpMetaInformation);
+			} catch (DBError $e) {
+				exit('Unknown database error occurred.');
 			}
 
 			$i++;
-			$this->log( "\r\033[K" );
-			$this->log( "$i rows inserted or updated" );
+			$this->log("\r\033[K");
+			$this->log("$i rows inserted or updated");
 		}
 
-		fclose( $csvFile );
+		fclose($csvFile);
 
-		$this->log( "\n" );
+		$this->log("\n");
 
 		return $dumpIds;
 	}
@@ -123,31 +123,31 @@ 
 	 * Inserts external values stored in csv file into database
 	 */
 	private function insertExternalValues() {
-		$this->log( "Insert new data values\n" );
+		$this->log("Insert new data values\n");
 
-		$csvFile = fopen( $this->importSettings->getExternalValuesFilePath(), 'rb' );
-		if ( !$csvFile ) {
-			exit( 'Error while reading CSV file.' );
+		$csvFile = fopen($this->importSettings->getExternalValuesFilePath(), 'rb');
+		if (!$csvFile) {
+			exit('Error while reading CSV file.');
 		}
 
 		$i = 0;
 		$accumulator = [];
-		while ( true ) {
-			$data = fgetcsv( $csvFile );
-			if ( $data === false || ++$i % $this->importSettings->getBatchSize() === 0 ) {
+		while (true) {
+			$data = fgetcsv($csvFile);
+			if ($data === false || ++$i % $this->importSettings->getBatchSize() === 0) {
 				try {
-					$this->externalDataRepo->insertBatch( $accumulator );
-				} catch ( DBError $e ) {
-					exit( 'Unknown database error occurred.' );
+					$this->externalDataRepo->insertBatch($accumulator);
+				} catch (DBError $e) {
+					exit('Unknown database error occurred.');
 				}
 				wfGetLBFactory()->waitForReplication();
 
-				$this->log( "\r\033[K" );
-				$this->log( "$i rows inserted" );
+				$this->log("\r\033[K");
+				$this->log("$i rows inserted");
 
 				$accumulator = [];
 
-				if ( $data === false ) {
+				if ($data === false) {
 					break;
 				}
 			}
@@ -155,16 +155,16 @@ 
 			$accumulator[] = $data;
 		}
 
-		fclose( $csvFile );
+		fclose($csvFile);
 
-		$this->log( "\n" );
+		$this->log("\n");
 	}
 
 	/**
 	 * @param string $text
 	 */
-	private function log( $text ) {
-		if ( !$this->importSettings->isQuiet() ) {
+	private function log($text) {
+		if (!$this->importSettings->isQuiet()) {
 			print $text;
 		}
 	}