wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Api/CachingResultsBuilder.php

Spacing +61 added lines, -62 removed lines

@@ -142,11 +142,11 @@ 
 	) {
 		$results = [];
 		$metadatas = [];
-		if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
+		if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds, $statuses)) {
 			$storedEntityIds = [];
-			foreach ( $entityIds as $entityId ) {
-				$storedResults = $this->getStoredResults( $entityId );
-				if ( $storedResults !== null ) {
+			foreach ($entityIds as $entityId) {
+				$storedResults = $this->getStoredResults($entityId);
+				if ($storedResults !== null) {
 					$this->dataFactory->increment(
 						'wikibase.quality.constraints.cache.entity.hit'
 					);
@@ -155,20 +155,20 @@ 
 					$storedEntityIds[] = $entityId;
 				}
 			}
-			$entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) );
+			$entityIds = array_values(array_diff($entityIds, $storedEntityIds));
 		}
-		if ( $entityIds !== [] || $claimIds !== [] ) {
+		if ($entityIds !== [] || $claimIds !== []) {
 			$this->dataFactory->updateCount(
 				'wikibase.quality.constraints.cache.entity.miss',
-				count( $entityIds )
+				count($entityIds)
 			);
-			$response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds, $statuses );
+			$response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds, $statuses);
 			$results += $response->getArray();
 			$metadatas[] = $response->getMetadata();
 		}
 		return new CachedCheckConstraintsResponse(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -197,13 +197,13 @@ 
 		array $constraintIds = null,
 		array $statuses
 	) {
-		if ( $claimIds !== [] ) {
+		if ($claimIds !== []) {
 			return false;
 		}
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( $statuses != $this->cachedStatuses ) {
+		if ($statuses != $this->cachedStatuses) {
 			return false;
 		}
 		return true;
@@ -222,10 +222,10 @@ 
 		array $constraintIds = null,
 		array $statuses
 	) {
-		$results = $this->resultsBuilder->getResults( $entityIds, $claimIds, $constraintIds, $statuses );
+		$results = $this->resultsBuilder->getResults($entityIds, $claimIds, $constraintIds, $statuses);
 
-		if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
-			foreach ( $entityIds as $entityId ) {
+		if ($this->canStoreResults($entityIds, $claimIds, $constraintIds, $statuses)) {
+			foreach ($entityIds as $entityId) {
 				$value = [
 					'results' => $results->getArray()[$entityId->getSerialization()],
 					'latestRevisionIds' => $this->getLatestRevisionIds(
@@ -233,10 +233,10 @@ 
 					),
 				];
 				$futureTime = $results->getMetadata()->getDependencyMetadata()->getFutureTime();
-				if ( $futureTime !== null ) {
+				if ($futureTime !== null) {
 					$value['futureTime'] = $futureTime->getArrayValue();
 				}
-				$this->cache->set( $entityId, $value, $this->ttlInSeconds );
+				$this->cache->set($entityId, $value, $this->ttlInSeconds);
 			}
 		}
 
@@ -268,10 +268,10 @@ 
 		array $constraintIds = null,
 		array $statuses
 	) {
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( $statuses != $this->cachedStatuses ) {
+		if ($statuses != $this->cachedStatuses) {
 			return false;
 		}
 		return true;
@@ -284,45 +284,44 @@ 
 	public function getStoredResults(
 		EntityId $entityId
 	) {
-		$value = $this->cache->get( $entityId, $curTTL, [], $asOf );
-		$now = call_user_func( $this->microtime, true );
+		$value = $this->cache->get($entityId, $curTTL, [], $asOf);
+		$now = call_user_func($this->microtime, true);
 
-		if ( $value === false ) {
+		if ($value === false) {
 			return null;
 		}
 
-		$ageInSeconds = (int)ceil( $now - $asOf );
+		$ageInSeconds = (int) ceil($now - $asOf);
 
 		$dependedEntityIds = array_map(
-			[ $this->entityIdParser, "parse" ],
-			array_keys( $value['latestRevisionIds'] )
+			[$this->entityIdParser, "parse"],
+			array_keys($value['latestRevisionIds'])
 		);
 
-		if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) {
+		if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) {
 			return null;
 		}
 
-		if ( array_key_exists( 'futureTime', $value ) ) {
-			$futureTime = TimeValue::newFromArray( $value['futureTime'] );
-			if ( !$this->timeValueComparer->isFutureTime( $futureTime ) ) {
+		if (array_key_exists('futureTime', $value)) {
+			$futureTime = TimeValue::newFromArray($value['futureTime']);
+			if (!$this->timeValueComparer->isFutureTime($futureTime)) {
 				return null;
 			}
-			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime );
+			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime);
 		} else {
 			$futureTimeDependencyMetadata = DependencyMetadata::blank();
 		}
 
 		$cachingMetadata = $ageInSeconds > 0 ?
-			CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) :
-			CachingMetadata::fresh();
+			CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh();
 
-		if ( is_array( $value['results'] ) ) {
-			array_walk( $value['results'], [ $this, 'updateCachingMetadata' ], $cachingMetadata );
+		if (is_array($value['results'])) {
+			array_walk($value['results'], [$this, 'updateCachingMetadata'], $cachingMetadata);
 		}
 
 		return new CachedCheckConstraintsResponse(
-			[ $entityId->getSerialization() => $value['results'] ],
-			$this->mergeStoredMetadata( $cachingMetadata, $dependedEntityIds, $futureTimeDependencyMetadata )
+			[$entityId->getSerialization() => $value['results']],
+			$this->mergeStoredMetadata($cachingMetadata, $dependedEntityIds, $futureTimeDependencyMetadata)
 		);
 	}
 
@@ -337,27 +336,27 @@ 
 		array $dependedEntityIds,
 		DependencyMetadata $futureTimeDependencyMetadata = null
 	) {
-		return Metadata::merge( [
-			Metadata::ofCachingMetadata( $cachingMetadata ),
-			Metadata::ofDependencyMetadata( array_reduce(
+		return Metadata::merge([
+			Metadata::ofCachingMetadata($cachingMetadata),
+			Metadata::ofDependencyMetadata(array_reduce(
 				$dependedEntityIds,
-				function( DependencyMetadata $metadata, EntityId $entityId ) {
-					return DependencyMetadata::merge( [
+				function(DependencyMetadata $metadata, EntityId $entityId) {
+					return DependencyMetadata::merge([
 						$metadata,
-						DependencyMetadata::ofEntityId( $entityId )
-					] );
+						DependencyMetadata::ofEntityId($entityId)
+					]);
 				},
 				$futureTimeDependencyMetadata
-			) )
-		] );
+			))
+		]);
 	}
 
 	/**
 	 * @param EntityId[] $entityIds
 	 * @return int[]
 	 */
-	private function getLatestRevisionIds( array $entityIds ) {
-		if ( $entityIds === [] ) {
+	private function getLatestRevisionIds(array $entityIds) {
+		if ($entityIds === []) {
 			return [];
 		}
 
@@ -366,33 +365,33 @@ 
 			EntityRevisionLookup::LATEST_FROM_REPLICA
 		);
 		$latestRevisionIds = [];
-		foreach ( $revisionInformations as $serialization => $revisionInformation ) {
+		foreach ($revisionInformations as $serialization => $revisionInformation) {
 			$latestRevisionIds[$serialization] = $revisionInformation->page_latest;
 		}
 		return $latestRevisionIds;
 	}
 
-	public function updateCachingMetadata( &$element, $key, CachingMetadata $cachingMetadata ) {
-		if ( $key === 'cached' ) {
-			$element = CachingMetadata::merge( [
+	public function updateCachingMetadata(&$element, $key, CachingMetadata $cachingMetadata) {
+		if ($key === 'cached') {
+			$element = CachingMetadata::merge([
 				$cachingMetadata,
-				CachingMetadata::ofArray( $element ),
-			] )->toArray();
+				CachingMetadata::ofArray($element),
+			])->toArray();
 		}
 		if (
-			is_array( $element ) &&
-			array_key_exists( 'constraint', $element ) &&
-			in_array( $element['constraint']['type'], $this->possiblyStaleConstraintTypes, true )
+			is_array($element) &&
+			array_key_exists('constraint', $element) &&
+			in_array($element['constraint']['type'], $this->possiblyStaleConstraintTypes, true)
 		) {
-			$element['cached'] = CachingMetadata::merge( [
+			$element['cached'] = CachingMetadata::merge([
 				$cachingMetadata,
 				CachingMetadata::ofArray(
-					array_key_exists( 'cached', $element ) ? $element['cached'] : null
+					array_key_exists('cached', $element) ? $element['cached'] : null
 				),
-			] )->toArray();
+			])->toArray();
 		}
-		if ( is_array( $element ) ) {
-			array_walk( $element, [ $this, __FUNCTION__ ], $cachingMetadata );
+		if (is_array($element)) {
+			array_walk($element, [$this, __FUNCTION__], $cachingMetadata);
 		}
 	}
 
@@ -401,7 +400,7 @@ 
 	 *
 	 * @param callable $microtime
 	 */
-	public function setMicrotimeFunction( callable $microtime ) {
+	public function setMicrotimeFunction(callable $microtime) {
 		$this->microtime = $microtime;
 	}