@@ -41,22 +41,21 @@ discard block |
||
41 | 41 | ]; |
42 | 42 | } |
43 | 43 | |
44 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
44 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
45 | 45 | $snak = $context->getSnak(); |
46 | 46 | |
47 | - if ( $context->getSnak()->getType() !== 'value' ) { |
|
48 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE ); |
|
47 | + if ($context->getSnak()->getType() !== 'value') { |
|
48 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE); |
|
49 | 49 | } |
50 | 50 | |
51 | - $violationMessage = $this->checkSnak( $snak ); |
|
51 | + $violationMessage = $this->checkSnak($snak); |
|
52 | 52 | |
53 | 53 | return new CheckResult( |
54 | 54 | $context, |
55 | 55 | $constraint, |
56 | 56 | [], |
57 | 57 | $violationMessage === null ? |
58 | - CheckResult::STATUS_COMPLIANCE : |
|
59 | - CheckResult::STATUS_VIOLATION, |
|
58 | + CheckResult::STATUS_COMPLIANCE : CheckResult::STATUS_VIOLATION, |
|
60 | 59 | $violationMessage |
61 | 60 | ); |
62 | 61 | } |
@@ -65,23 +64,23 @@ discard block |
||
65 | 64 | * @param PropertyValueSnak $snak |
66 | 65 | * @return ViolationMessage|null |
67 | 66 | */ |
68 | - public function checkSnak( PropertyValueSnak $snak ) { |
|
67 | + public function checkSnak(PropertyValueSnak $snak) { |
|
69 | 68 | $dataValue = $snak->getDataValue(); |
70 | 69 | |
71 | - if ( $dataValue instanceof DecimalValue ) { |
|
72 | - if ( !$this->isInteger( $dataValue ) ) { |
|
73 | - return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak ); |
|
70 | + if ($dataValue instanceof DecimalValue) { |
|
71 | + if (!$this->isInteger($dataValue)) { |
|
72 | + return $this->getViolationMessage('wbqc-violation-message-integer', $snak); |
|
74 | 73 | } |
75 | - } elseif ( $dataValue instanceof UnboundedQuantityValue ) { |
|
76 | - if ( !$this->isInteger( $dataValue->getAmount() ) ) { |
|
77 | - return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak ); |
|
74 | + } elseif ($dataValue instanceof UnboundedQuantityValue) { |
|
75 | + if (!$this->isInteger($dataValue->getAmount())) { |
|
76 | + return $this->getViolationMessage('wbqc-violation-message-integer', $snak); |
|
78 | 77 | } elseif ( |
79 | 78 | $dataValue instanceof QuantityValue && ( |
80 | - !$this->isInteger( $dataValue->getLowerBound() ) || |
|
81 | - !$this->isInteger( $dataValue->getUpperBound() ) |
|
79 | + !$this->isInteger($dataValue->getLowerBound()) || |
|
80 | + !$this->isInteger($dataValue->getUpperBound()) |
|
82 | 81 | ) |
83 | 82 | ) { |
84 | - return $this->getViolationMessage( 'wbqc-violation-message-integer-bounds', $snak ); |
|
83 | + return $this->getViolationMessage('wbqc-violation-message-integer-bounds', $snak); |
|
85 | 84 | } |
86 | 85 | } |
87 | 86 | |
@@ -92,7 +91,7 @@ discard block |
||
92 | 91 | * @param DecimalValue $decimalValue |
93 | 92 | * @return bool |
94 | 93 | */ |
95 | - private function isInteger( DecimalValue $decimalValue ) { |
|
94 | + private function isInteger(DecimalValue $decimalValue) { |
|
96 | 95 | return $decimalValue->getTrimmed()->getFractionalPart() === ''; |
97 | 96 | } |
98 | 97 | |
@@ -101,13 +100,13 @@ discard block |
||
101 | 100 | * @param PropertyValueSnak $snak |
102 | 101 | * @return ViolationMessage |
103 | 102 | */ |
104 | - private function getViolationMessage( $messageKey, PropertyValueSnak $snak ) { |
|
105 | - return ( new ViolationMessage( $messageKey ) ) |
|
106 | - ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
107 | - ->withDataValue( $snak->getDataValue() ); |
|
103 | + private function getViolationMessage($messageKey, PropertyValueSnak $snak) { |
|
104 | + return (new ViolationMessage($messageKey)) |
|
105 | + ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
106 | + ->withDataValue($snak->getDataValue()); |
|
108 | 107 | } |
109 | 108 | |
110 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
109 | + public function checkConstraintParameters(Constraint $constraint) { |
|
111 | 110 | // no parameters |
112 | 111 | return []; |
113 | 112 | } |