wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Html/HtmlTableHeaderBuilder.php

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Html;
 
@@ -33,8 +33,8 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, bool $isSortable = false ) {
-		Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' );
+	public function __construct($content, bool $isSortable = false) {
+		Assert::parameterType(['string', HtmlArmor::class], $content, '$content');
 
 		$this->content = $content;
 		$this->isSortable = $isSortable;
@@ -44,7 +44,7 @@ 
 	 * @return string HTML
 	 */
 	public function getContent(): string {
-		return HtmlArmor::getHtml( $this->content );
+		return HtmlArmor::getHtml($this->content);
 	}
 
 	public function getIsSortable(): bool {
@@ -57,13 +57,13 @@ 
 	 * @return string HTML
 	 */
 	public function toHtml(): string {
-		$attributes = [ 'role' => 'columnheader button' ];
+		$attributes = ['role' => 'columnheader button'];
 
-		if ( !$this->isSortable ) {
+		if (!$this->isSortable) {
 			$attributes['class'] = 'unsortable';
 		}
 
-		return Html::rawElement( 'th', $attributes, $this->getContent() );
+		return Html::rawElement('th', $attributes, $this->getContent());
 	}
 
 }

src/ConstraintCheck/Message/ViolationMessageSerializer.php

Spacing +30 added lines, -30 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Message;
 
@@ -21,26 +21,26 @@ 
  */
 class ViolationMessageSerializer implements Serializer {
 
-	private function abbreviateViolationMessageKey( string $fullMessageKey ): string {
-		return substr( $fullMessageKey, strlen( ViolationMessage::MESSAGE_KEY_PREFIX ) );
+	private function abbreviateViolationMessageKey(string $fullMessageKey): string {
+		return substr($fullMessageKey, strlen(ViolationMessage::MESSAGE_KEY_PREFIX));
 	}
 
 	/**
 	 * @param ViolationMessage $object
 	 * @return array
 	 */
-	public function serialize( $object ): array {
+	public function serialize($object): array {
 		/** @var ViolationMessage $object */
-		Assert::parameterType( ViolationMessage::class, $object, '$object' );
+		Assert::parameterType(ViolationMessage::class, $object, '$object');
 
 		$arguments = $object->getArguments();
 		$serializedArguments = [];
-		foreach ( $arguments as $argument ) {
-			$serializedArguments[] = $this->serializeArgument( $argument );
+		foreach ($arguments as $argument) {
+			$serializedArguments[] = $this->serializeArgument($argument);
 		}
 
 		return [
-			'k' => $this->abbreviateViolationMessageKey( $object->getMessageKey() ),
+			'k' => $this->abbreviateViolationMessageKey($object->getMessageKey()),
 			'a' => $serializedArguments,
 		];
 	}
@@ -49,7 +49,7 @@ 
 	 * @param array $argument element of ViolationMessage::getArguments()
 	 * @return array [ 't' => ViolationMessage::TYPE_*, 'v' => serialized value, 'r' => $role ]
 	 */
-	private function serializeArgument( array $argument ): array {
+	private function serializeArgument(array $argument): array {
 		$methods = [
 			ViolationMessage::TYPE_ENTITY_ID => 'serializeEntityId',
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'serializeEntityIdList',
@@ -71,12 +71,12 @@ 
 		$value = $argument['value'];
 		$role = $argument['role'];
 
-		if ( array_key_exists( $type, $methods ) ) {
+		if (array_key_exists($type, $methods)) {
 			$method = $methods[$type];
-			$serializedValue = $this->$method( $value );
+			$serializedValue = $this->$method($value);
 		} else {
 			throw new InvalidArgumentException(
-				'Unknown ViolationMessage argument type ' . $type . '!'
+				'Unknown ViolationMessage argument type '.$type.'!'
 			);
 		}
 
@@ -93,7 +93,7 @@ 
 	 * @param string $string any value that shall simply be serialized to itself
 	 * @return string that same value, unchanged
 	 */
-	private function serializeStringByIdentity( string $string ): string {
+	private function serializeStringByIdentity(string $string): string {
 		return $string;
 	}
 
@@ -101,8 +101,8 @@ 
 	 * @param string[] $strings
 	 * @return string[]
 	 */
-	private function serializeStringListByIdentity( array $strings ): array {
-		Assert::parameterElementType( 'string', $strings, '$strings' );
+	private function serializeStringListByIdentity(array $strings): array {
+		Assert::parameterElementType('string', $strings, '$strings');
 		return $strings;
 	}
 
@@ -110,7 +110,7 @@ 
 	 * @param EntityId $entityId
 	 * @return string entity ID serialization
 	 */
-	private function serializeEntityId( EntityId $entityId ): string {
+	private function serializeEntityId(EntityId $entityId): string {
 		return $entityId->getSerialization();
 	}
 
@@ -118,8 +118,8 @@ 
 	 * @param EntityId[] $entityIdList
 	 * @return string[] entity ID serializations
 	 */
-	private function serializeEntityIdList( array $entityIdList ): array {
-		return array_map( [ $this, 'serializeEntityId' ], $entityIdList );
+	private function serializeEntityIdList(array $entityIdList): array {
+		return array_map([$this, 'serializeEntityId'], $entityIdList);
 	}
 
 	/**
@@ -127,10 +127,10 @@ 
 	 * @return string entity ID serialization, '::somevalue', or '::novalue'
 	 * (according to EntityId::PATTERN, entity ID serializations can never begin with two colons)
 	 */
-	private function serializeItemIdSnakValue( ItemIdSnakValue $value ): string {
-		switch ( true ) {
+	private function serializeItemIdSnakValue(ItemIdSnakValue $value): string {
+		switch (true) {
 			case $value->isValue():
-				return $this->serializeEntityId( $value->getItemId() );
+				return $this->serializeEntityId($value->getItemId());
 			case $value->isSomeValue():
 				return '::somevalue';
 			case $value->isNoValue():
@@ -148,15 +148,15 @@ 
 	 * @param ItemIdSnakValue[] $valueList
 	 * @return string[] array of entity ID serializations, '::somevalue's or '::novalue's
 	 */
-	private function serializeItemIdSnakValueList( array $valueList ): array {
-		return array_map( [ $this, 'serializeItemIdSnakValue' ], $valueList );
+	private function serializeItemIdSnakValueList(array $valueList): array {
+		return array_map([$this, 'serializeItemIdSnakValue'], $valueList);
 	}
 
 	/**
 	 * @param DataValue $dataValue
 	 * @return array the data value in array form
 	 */
-	private function serializeDataValue( DataValue $dataValue ): array {
+	private function serializeDataValue(DataValue $dataValue): array {
 		return $dataValue->toArray();
 	}
 
@@ -164,8 +164,8 @@ 
 	 * @param string $contextType one of the Context::TYPE_* constants
 	 * @return string the abbreviated context type
 	 */
-	private function serializeContextType( string $contextType ): string {
-		switch ( $contextType ) {
+	private function serializeContextType(string $contextType): string {
+		switch ($contextType) {
 			case Context::TYPE_STATEMENT:
 				return 's';
 			case Context::TYPE_QUALIFIER:
@@ -175,7 +175,7 @@ 
 			default:
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
-					'Unknown context type ' . $contextType
+					'Unknown context type '.$contextType
 				);
 				// @codeCoverageIgnoreEnd
 		}
@@ -185,15 +185,15 @@ 
 	 * @param string[] $contextTypeList Context::TYPE_* constants
 	 * @return string[] abbreviated context types
 	 */
-	private function serializeContextTypeList( array $contextTypeList ): array {
-		return array_map( [ $this, 'serializeContextType' ], $contextTypeList );
+	private function serializeContextTypeList(array $contextTypeList): array {
+		return array_map([$this, 'serializeContextType'], $contextTypeList);
 	}
 
 	/**
 	 * @param MultilingualTextValue $text
 	 * @return mixed {@see MultilingualTextValue::getArrayValue}
 	 */
-	private function serializeMultilingualText( MultilingualTextValue $text ) {
+	private function serializeMultilingualText(MultilingualTextValue $text) {
 		return $text->getArrayValue();
 	}
 

src/ConstraintCheck/Cache/CachingMetadata.php

Spacing +11 added lines, -12 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Cache;
 
@@ -31,8 +31,8 @@ 
 	 * @param int $maxAge The maximum age of the cached value (in seconds).
 	 * @return self Indication that a value is possibly outdated by up to this many seconds.
 	 */
-	public static function ofMaximumAgeInSeconds( int $maxAge ): self {
-		Assert::parameter( $maxAge > 0, '$maxAge', '$maxage > 0' );
+	public static function ofMaximumAgeInSeconds(int $maxAge): self {
+		Assert::parameter($maxAge > 0, '$maxAge', '$maxage > 0');
 		$ret = new self;
 		$ret->maxAge = $maxAge;
 		return $ret;
@@ -43,9 +43,9 @@ 
 	 * @param array|null $array As returned by toArray.
 	 * @return self
 	 */
-	public static function ofArray( array $array = null ): self {
+	public static function ofArray(array $array = null): self {
 		$ret = new self;
-		if ( $array !== null ) {
+		if ($array !== null) {
 			$ret->maxAge = $array['maximumAgeInSeconds'];
 		}
 		return $ret;
@@ -55,11 +55,11 @@ 
 	 * @param self[] $metadatas
 	 * @return self
 	 */
-	public static function merge( array $metadatas ): self {
-		Assert::parameterElementType( self::class, $metadatas, '$metadatas' );
+	public static function merge(array $metadatas): self {
+		Assert::parameterElementType(self::class, $metadatas, '$metadatas');
 		$ret = new self;
-		foreach ( $metadatas as $metadata ) {
-			$ret->maxAge = max( $ret->maxAge, $metadata->maxAge );
+		foreach ($metadatas as $metadata) {
+			$ret->maxAge = max($ret->maxAge, $metadata->maxAge);
 		}
 		return $ret;
 	}
@@ -77,7 +77,7 @@ 
 	 * For a fresh value, returns 0.
 	 */
 	public function getMaximumAgeInSeconds(): int {
-		if ( is_int( $this->maxAge ) ) {
+		if (is_int($this->maxAge)) {
 			return $this->maxAge;
 		} else {
 			return 0;
@@ -92,8 +92,7 @@ 
 		return $this->isCached() ?
 			[
 				'maximumAgeInSeconds' => $this->maxAge,
-			] :
-			null;
+			] : null;
 	}
 
 }

src/Api/ExpiryLock.php

Spacing +18 added lines, -18 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -21,7 +21,7 @@ 
 
 	private BagOStuff $cache;
 
-	public function __construct( BagOStuff $cache ) {
+	public function __construct(BagOStuff $cache) {
 		$this->cache = $cache;
 	}
 
@@ -32,9 +32,9 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	private function makeKey( string $id ): string {
-		if ( trim( $id ) === '' ) {
-			throw new ParameterTypeException( '$id', 'non-empty string' );
+	private function makeKey(string $id): string {
+		if (trim($id) === '') {
+			throw new ParameterTypeException('$id', 'non-empty string');
 		}
 
 		return $this->cache->makeKey(
@@ -52,15 +52,15 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	public function lock( string $id, ConvertibleTimestamp $expiryTimestamp ): bool {
+	public function lock(string $id, ConvertibleTimestamp $expiryTimestamp): bool {
 
-		$cacheId = $this->makeKey( $id );
+		$cacheId = $this->makeKey($id);
 
-		if ( !$this->isLockedInternal( $cacheId ) ) {
+		if (!$this->isLockedInternal($cacheId)) {
 			return $this->cache->set(
 				$cacheId,
-				$expiryTimestamp->getTimestamp( TS_UNIX ),
-				(int)$expiryTimestamp->getTimestamp( TS_UNIX )
+				$expiryTimestamp->getTimestamp(TS_UNIX),
+				(int) $expiryTimestamp->getTimestamp(TS_UNIX)
 			);
 		} else {
 			return false;
@@ -74,20 +74,20 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	private function isLockedInternal( string $cacheId ): bool {
-		$expiryTime = $this->cache->get( $cacheId );
-		if ( !$expiryTime ) {
+	private function isLockedInternal(string $cacheId): bool {
+		$expiryTime = $this->cache->get($cacheId);
+		if (!$expiryTime) {
 			return false;
 		}
 
 		try {
-			$lockExpiryTimeStamp = new ConvertibleTimestamp( $expiryTime );
-		} catch ( TimestampException $exception ) {
+			$lockExpiryTimeStamp = new ConvertibleTimestamp($expiryTime);
+		} catch (TimestampException $exception) {
 			return false;
 		}
 
 		$now = new ConvertibleTimestamp();
-		if ( $now->timestamp < $lockExpiryTimeStamp->timestamp ) {
+		if ($now->timestamp < $lockExpiryTimeStamp->timestamp) {
 			return true;
 		} else {
 			return false;
@@ -101,8 +101,8 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	public function isLocked( string $id ): bool {
-		return $this->isLockedInternal( $this->makeKey( $id ) );
+	public function isLocked(string $id): bool {
+		return $this->isLockedInternal($this->makeKey($id));
 	}
 
 }