@@ -36,196 +36,196 @@ |
||
36 | 36 | use WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\ValueTypeChecker; |
37 | 37 | |
38 | 38 | return [ |
39 | - ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => function( MediaWikiServices $services ) { |
|
39 | + ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => function(MediaWikiServices $services) { |
|
40 | 40 | return new ConflictsWithChecker( |
41 | - WikibaseServices::getEntityLookup( $services ), |
|
42 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
43 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
41 | + WikibaseServices::getEntityLookup($services), |
|
42 | + ConstraintsServices::getConstraintParameterParser($services), |
|
43 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
44 | 44 | ); |
45 | 45 | }, |
46 | 46 | |
47 | - ConstraintCheckerServices::ITEM_CHECKER => function( MediaWikiServices $services ) { |
|
47 | + ConstraintCheckerServices::ITEM_CHECKER => function(MediaWikiServices $services) { |
|
48 | 48 | return new ItemChecker( |
49 | - WikibaseServices::getEntityLookup( $services ), |
|
50 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
51 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
49 | + WikibaseServices::getEntityLookup($services), |
|
50 | + ConstraintsServices::getConstraintParameterParser($services), |
|
51 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
52 | 52 | ); |
53 | 53 | }, |
54 | 54 | |
55 | - ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => function( MediaWikiServices $services ) { |
|
55 | + ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => function(MediaWikiServices $services) { |
|
56 | 56 | return new TargetRequiredClaimChecker( |
57 | - WikibaseServices::getEntityLookup( $services ), |
|
58 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
59 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
57 | + WikibaseServices::getEntityLookup($services), |
|
58 | + ConstraintsServices::getConstraintParameterParser($services), |
|
59 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
60 | 60 | ); |
61 | 61 | }, |
62 | 62 | |
63 | - ConstraintCheckerServices::SYMMETRIC_CHECKER => function( MediaWikiServices $services ) { |
|
63 | + ConstraintCheckerServices::SYMMETRIC_CHECKER => function(MediaWikiServices $services) { |
|
64 | 64 | return new SymmetricChecker( |
65 | - WikibaseServices::getEntityLookup( $services ), |
|
66 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
65 | + WikibaseServices::getEntityLookup($services), |
|
66 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
67 | 67 | ); |
68 | 68 | }, |
69 | 69 | |
70 | - ConstraintCheckerServices::INVERSE_CHECKER => function( MediaWikiServices $services ) { |
|
70 | + ConstraintCheckerServices::INVERSE_CHECKER => function(MediaWikiServices $services) { |
|
71 | 71 | return new InverseChecker( |
72 | - WikibaseServices::getEntityLookup( $services ), |
|
73 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
74 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
72 | + WikibaseServices::getEntityLookup($services), |
|
73 | + ConstraintsServices::getConstraintParameterParser($services), |
|
74 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
75 | 75 | ); |
76 | 76 | }, |
77 | 77 | |
78 | - ConstraintCheckerServices::QUALIFIER_CHECKER => function( MediaWikiServices $services ) { |
|
78 | + ConstraintCheckerServices::QUALIFIER_CHECKER => function(MediaWikiServices $services) { |
|
79 | 79 | return new QualifierChecker(); |
80 | 80 | }, |
81 | 81 | |
82 | - ConstraintCheckerServices::QUALIFIERS_CHECKER => function( MediaWikiServices $services ) { |
|
82 | + ConstraintCheckerServices::QUALIFIERS_CHECKER => function(MediaWikiServices $services) { |
|
83 | 83 | return new QualifiersChecker( |
84 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
84 | + ConstraintsServices::getConstraintParameterParser($services) |
|
85 | 85 | ); |
86 | 86 | }, |
87 | 87 | |
88 | - ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => function( MediaWikiServices $services ) { |
|
88 | + ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => function(MediaWikiServices $services) { |
|
89 | 89 | return new MandatoryQualifiersChecker( |
90 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
90 | + ConstraintsServices::getConstraintParameterParser($services) |
|
91 | 91 | ); |
92 | 92 | }, |
93 | 93 | |
94 | - ConstraintCheckerServices::RANGE_CHECKER => function( MediaWikiServices $services ) { |
|
94 | + ConstraintCheckerServices::RANGE_CHECKER => function(MediaWikiServices $services) { |
|
95 | 95 | return new RangeChecker( |
96 | - WikibaseServices::getPropertyDataTypeLookup( $services ), |
|
97 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
98 | - ConstraintsServices::getRangeCheckerHelper( $services ) |
|
96 | + WikibaseServices::getPropertyDataTypeLookup($services), |
|
97 | + ConstraintsServices::getConstraintParameterParser($services), |
|
98 | + ConstraintsServices::getRangeCheckerHelper($services) |
|
99 | 99 | ); |
100 | 100 | }, |
101 | 101 | |
102 | - ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => function( MediaWikiServices $services ) { |
|
102 | + ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => function(MediaWikiServices $services) { |
|
103 | 103 | return new DiffWithinRangeChecker( |
104 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
105 | - ConstraintsServices::getRangeCheckerHelper( $services ), |
|
104 | + ConstraintsServices::getConstraintParameterParser($services), |
|
105 | + ConstraintsServices::getRangeCheckerHelper($services), |
|
106 | 106 | $services->getMainConfig() |
107 | 107 | ); |
108 | 108 | }, |
109 | 109 | |
110 | - ConstraintCheckerServices::TYPE_CHECKER => function( MediaWikiServices $services ) { |
|
110 | + ConstraintCheckerServices::TYPE_CHECKER => function(MediaWikiServices $services) { |
|
111 | 111 | return new TypeChecker( |
112 | - WikibaseServices::getEntityLookup( $services ), |
|
113 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
114 | - ConstraintsServices::getTypeCheckerHelper( $services ), |
|
112 | + WikibaseServices::getEntityLookup($services), |
|
113 | + ConstraintsServices::getConstraintParameterParser($services), |
|
114 | + ConstraintsServices::getTypeCheckerHelper($services), |
|
115 | 115 | $services->getMainConfig() |
116 | 116 | ); |
117 | 117 | }, |
118 | 118 | |
119 | - ConstraintCheckerServices::VALUE_TYPE_CHECKER => function( MediaWikiServices $services ) { |
|
119 | + ConstraintCheckerServices::VALUE_TYPE_CHECKER => function(MediaWikiServices $services) { |
|
120 | 120 | return new ValueTypeChecker( |
121 | - WikibaseServices::getEntityLookup( $services ), |
|
122 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
123 | - ConstraintsServices::getTypeCheckerHelper( $services ), |
|
121 | + WikibaseServices::getEntityLookup($services), |
|
122 | + ConstraintsServices::getConstraintParameterParser($services), |
|
123 | + ConstraintsServices::getTypeCheckerHelper($services), |
|
124 | 124 | $services->getMainConfig() |
125 | 125 | ); |
126 | 126 | }, |
127 | 127 | |
128 | - ConstraintCheckerServices::SINGLE_VALUE_CHECKER => function( MediaWikiServices $services ) { |
|
128 | + ConstraintCheckerServices::SINGLE_VALUE_CHECKER => function(MediaWikiServices $services) { |
|
129 | 129 | return new SingleValueChecker( |
130 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
130 | + ConstraintsServices::getConstraintParameterParser($services) |
|
131 | 131 | ); |
132 | 132 | }, |
133 | 133 | |
134 | - ConstraintCheckerServices::MULTI_VALUE_CHECKER => function( MediaWikiServices $services ) { |
|
134 | + ConstraintCheckerServices::MULTI_VALUE_CHECKER => function(MediaWikiServices $services) { |
|
135 | 135 | return new MultiValueChecker( |
136 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
136 | + ConstraintsServices::getConstraintParameterParser($services) |
|
137 | 137 | ); |
138 | 138 | }, |
139 | 139 | |
140 | - ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => function( MediaWikiServices $services ) { |
|
140 | + ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => function(MediaWikiServices $services) { |
|
141 | 141 | // TODO return a different, dummy implementation if SPARQL is not available |
142 | 142 | return new UniqueValueChecker( |
143 | - ConstraintsServices::getSparqlHelper( $services ) |
|
143 | + ConstraintsServices::getSparqlHelper($services) |
|
144 | 144 | ); |
145 | 145 | }, |
146 | 146 | |
147 | - ConstraintCheckerServices::FORMAT_CHECKER => function( MediaWikiServices $services ) { |
|
147 | + ConstraintCheckerServices::FORMAT_CHECKER => function(MediaWikiServices $services) { |
|
148 | 148 | // TODO return a different, dummy implementation if SPARQL is not available |
149 | 149 | return new FormatChecker( |
150 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
150 | + ConstraintsServices::getConstraintParameterParser($services), |
|
151 | 151 | $services->getMainConfig(), |
152 | - ConstraintsServices::getSparqlHelper( $services ) |
|
152 | + ConstraintsServices::getSparqlHelper($services) |
|
153 | 153 | ); |
154 | 154 | }, |
155 | 155 | |
156 | - ConstraintCheckerServices::COMMONS_LINK_CHECKER => function( MediaWikiServices $services ) { |
|
156 | + ConstraintCheckerServices::COMMONS_LINK_CHECKER => function(MediaWikiServices $services) { |
|
157 | 157 | $pageNameNormalizer = new MediaWikiPageNameNormalizer(); |
158 | 158 | return new CommonsLinkChecker( |
159 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
159 | + ConstraintsServices::getConstraintParameterParser($services), |
|
160 | 160 | $pageNameNormalizer |
161 | 161 | ); |
162 | 162 | }, |
163 | 163 | |
164 | - ConstraintCheckerServices::ONE_OF_CHECKER => function( MediaWikiServices $services ) { |
|
164 | + ConstraintCheckerServices::ONE_OF_CHECKER => function(MediaWikiServices $services) { |
|
165 | 165 | return new OneOfChecker( |
166 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
166 | + ConstraintsServices::getConstraintParameterParser($services) |
|
167 | 167 | ); |
168 | 168 | }, |
169 | 169 | |
170 | - ConstraintCheckerServices::VALUE_ONLY_CHECKER => function( MediaWikiServices $services ) { |
|
170 | + ConstraintCheckerServices::VALUE_ONLY_CHECKER => function(MediaWikiServices $services) { |
|
171 | 171 | return new ValueOnlyChecker(); |
172 | 172 | }, |
173 | 173 | |
174 | - ConstraintCheckerServices::REFERENCE_CHECKER => function( MediaWikiServices $services ) { |
|
174 | + ConstraintCheckerServices::REFERENCE_CHECKER => function(MediaWikiServices $services) { |
|
175 | 175 | return new ReferenceChecker(); |
176 | 176 | }, |
177 | 177 | |
178 | - ConstraintCheckerServices::NO_BOUNDS_CHECKER => function( MediaWikiServices $services ) { |
|
178 | + ConstraintCheckerServices::NO_BOUNDS_CHECKER => function(MediaWikiServices $services) { |
|
179 | 179 | return new NoBoundsChecker(); |
180 | 180 | }, |
181 | 181 | |
182 | - ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => function( MediaWikiServices $services ) { |
|
182 | + ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => function(MediaWikiServices $services) { |
|
183 | 183 | // TODO in the future, get UnitConverter from $services? |
184 | 184 | $repo = WikibaseRepo::getDefaultInstance(); |
185 | 185 | $unitConverter = $repo->getUnitConverter(); |
186 | 186 | |
187 | 187 | return new AllowedUnitsChecker( |
188 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
188 | + ConstraintsServices::getConstraintParameterParser($services), |
|
189 | 189 | $unitConverter |
190 | 190 | ); |
191 | 191 | }, |
192 | 192 | |
193 | - ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => function( MediaWikiServices $services ) { |
|
193 | + ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => function(MediaWikiServices $services) { |
|
194 | 194 | return new SingleBestValueChecker( |
195 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
195 | + ConstraintsServices::getConstraintParameterParser($services) |
|
196 | 196 | ); |
197 | 197 | }, |
198 | 198 | |
199 | - ConstraintCheckerServices::ENTITY_TYPE_CHECKER => function( MediaWikiServices $services ) { |
|
199 | + ConstraintCheckerServices::ENTITY_TYPE_CHECKER => function(MediaWikiServices $services) { |
|
200 | 200 | return new EntityTypeChecker( |
201 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
201 | + ConstraintsServices::getConstraintParameterParser($services) |
|
202 | 202 | ); |
203 | 203 | }, |
204 | 204 | |
205 | - ConstraintCheckerServices::NONE_OF_CHECKER => function( MediaWikiServices $services ) { |
|
205 | + ConstraintCheckerServices::NONE_OF_CHECKER => function(MediaWikiServices $services) { |
|
206 | 206 | return new NoneOfChecker( |
207 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
207 | + ConstraintsServices::getConstraintParameterParser($services) |
|
208 | 208 | ); |
209 | 209 | }, |
210 | 210 | |
211 | - ConstraintCheckerServices::INTEGER_CHECKER => function( MediaWikiServices $services ) { |
|
211 | + ConstraintCheckerServices::INTEGER_CHECKER => function(MediaWikiServices $services) { |
|
212 | 212 | return new IntegerChecker(); |
213 | 213 | }, |
214 | 214 | |
215 | - ConstraintCheckerServices::CITATION_NEEDED_CHECKER => function( MediaWikiServices $services ) { |
|
215 | + ConstraintCheckerServices::CITATION_NEEDED_CHECKER => function(MediaWikiServices $services) { |
|
216 | 216 | return new CitationNeededChecker(); |
217 | 217 | }, |
218 | 218 | |
219 | - ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => function( MediaWikiServices $services ) { |
|
219 | + ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => function(MediaWikiServices $services) { |
|
220 | 220 | return new PropertyScopeChecker( |
221 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
221 | + ConstraintsServices::getConstraintParameterParser($services) |
|
222 | 222 | ); |
223 | 223 | }, |
224 | 224 | |
225 | - ConstraintCheckerServices::CONTEMPORARY_CHECKER => function( MediaWikiServices $services ) { |
|
225 | + ConstraintCheckerServices::CONTEMPORARY_CHECKER => function(MediaWikiServices $services) { |
|
226 | 226 | return new ContemporaryChecker( |
227 | - WikibaseServices::getEntityLookup( $services ), |
|
228 | - ConstraintsServices::getRangeCheckerHelper( $services ), |
|
227 | + WikibaseServices::getEntityLookup($services), |
|
228 | + ConstraintsServices::getRangeCheckerHelper($services), |
|
229 | 229 | $services->getMainConfig() |
230 | 230 | ); |
231 | 231 | }, |
@@ -70,26 +70,26 @@ discard block |
||
70 | 70 | * @return array first element is the namespace number (default namespace for TitleParser), |
71 | 71 | * second element is a string to prepend to the title before giving it to the TitleParser |
72 | 72 | */ |
73 | - private function getCommonsNamespace( $namespace ) { |
|
74 | - switch ( $namespace ) { |
|
73 | + private function getCommonsNamespace($namespace) { |
|
74 | + switch ($namespace) { |
|
75 | 75 | case '': |
76 | - return [ NS_MAIN, '' ]; |
|
76 | + return [NS_MAIN, '']; |
|
77 | 77 | // extra namespaces, see operations/mediawiki-config.git, |
78 | 78 | // wmf-config/InitialiseSettings.php, 'wgExtraNamespaces' key, 'commonswiki' subkey |
79 | 79 | case 'Creator': |
80 | - return [ 100, '' ]; |
|
80 | + return [100, '']; |
|
81 | 81 | case 'TimedText': |
82 | - return [ 102, '' ]; |
|
82 | + return [102, '']; |
|
83 | 83 | case 'Sequence': |
84 | - return [ 104, '' ]; |
|
84 | + return [104, '']; |
|
85 | 85 | case 'Institution': |
86 | - return [ 106, '' ]; |
|
86 | + return [106, '']; |
|
87 | 87 | // extension namespace, see mediawiki/extensions/JsonConfig.git, |
88 | 88 | // extension.json, 'namespaces' key, third element |
89 | 89 | case 'Data': |
90 | - return [ 486, '' ]; |
|
90 | + return [486, '']; |
|
91 | 91 | default: |
92 | - return [ NS_MAIN, $namespace . ':' ]; |
|
92 | + return [NS_MAIN, $namespace.':']; |
|
93 | 93 | } |
94 | 94 | } |
95 | 95 | |
@@ -102,17 +102,17 @@ discard block |
||
102 | 102 | * @throws ConstraintParameterException |
103 | 103 | * @return CheckResult |
104 | 104 | */ |
105 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
105 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
106 | 106 | $parameters = []; |
107 | 107 | $constraintParameters = $constraint->getConstraintParameters(); |
108 | - $namespace = $this->constraintParameterParser->parseNamespaceParameter( $constraintParameters, $constraint->getConstraintTypeItemId() ); |
|
109 | - $parameters['namespace'] = [ $namespace ]; |
|
108 | + $namespace = $this->constraintParameterParser->parseNamespaceParameter($constraintParameters, $constraint->getConstraintTypeItemId()); |
|
109 | + $parameters['namespace'] = [$namespace]; |
|
110 | 110 | |
111 | 111 | $snak = $context->getSnak(); |
112 | 112 | |
113 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
113 | + if (!$snak instanceof PropertyValueSnak) { |
|
114 | 114 | // nothing to check |
115 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE ); |
|
115 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE); |
|
116 | 116 | } |
117 | 117 | |
118 | 118 | $dataValue = $snak->getDataValue(); |
@@ -122,51 +122,51 @@ discard block |
||
122 | 122 | * type of $dataValue for properties with 'Commons link' constraint has to be 'string' |
123 | 123 | * parameter $namespace can be null, works for commons galleries |
124 | 124 | */ |
125 | - if ( $dataValue->getType() !== 'string' ) { |
|
126 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) ) |
|
127 | - ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM ) |
|
128 | - ->withDataValueType( 'string' ); |
|
129 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message ); |
|
125 | + if ($dataValue->getType() !== 'string') { |
|
126 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type')) |
|
127 | + ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM) |
|
128 | + ->withDataValueType('string'); |
|
129 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message); |
|
130 | 130 | } |
131 | 131 | |
132 | 132 | $commonsLink = $dataValue->getValue(); |
133 | 133 | |
134 | 134 | try { |
135 | - if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) { |
|
136 | - throw new MalformedTitleException( 'wbqc-violation-message-commons-link-not-well-formed', $commonsLink ); // caught below |
|
135 | + if (!$this->commonsLinkIsWellFormed($commonsLink)) { |
|
136 | + throw new MalformedTitleException('wbqc-violation-message-commons-link-not-well-formed', $commonsLink); // caught below |
|
137 | 137 | } |
138 | 138 | |
139 | - $prefix = $this->getCommonsNamespace( $namespace )[1]; |
|
139 | + $prefix = $this->getCommonsNamespace($namespace)[1]; |
|
140 | 140 | $normalizedTitle = $this->pageNameNormalizer->normalizePageName( |
141 | - $prefix . $commonsLink, |
|
141 | + $prefix.$commonsLink, |
|
142 | 142 | 'https://commons.wikimedia.org/w/api.php' |
143 | 143 | ); |
144 | 144 | |
145 | - if ( $normalizedTitle === false ) { |
|
146 | - if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) { |
|
147 | - throw new MalformedTitleException( 'wbqc-violation-message-commons-link-not-well-formed', $commonsLink ); // caught below |
|
145 | + if ($normalizedTitle === false) { |
|
146 | + if ($this->valueIncludesNamespace($commonsLink, $namespace)) { |
|
147 | + throw new MalformedTitleException('wbqc-violation-message-commons-link-not-well-formed', $commonsLink); // caught below |
|
148 | 148 | } else { |
149 | - $message = new ViolationMessage( 'wbqc-violation-message-commons-link-no-existent' ); |
|
149 | + $message = new ViolationMessage('wbqc-violation-message-commons-link-no-existent'); |
|
150 | 150 | $status = CheckResult::STATUS_VIOLATION; |
151 | 151 | } |
152 | 152 | } else { |
153 | 153 | $message = null; |
154 | 154 | $status = CheckResult::STATUS_COMPLIANCE; |
155 | 155 | } |
156 | - } catch ( MalformedTitleException $e ) { |
|
157 | - $message = new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ); |
|
156 | + } catch (MalformedTitleException $e) { |
|
157 | + $message = new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'); |
|
158 | 158 | $status = CheckResult::STATUS_VIOLATION; |
159 | 159 | } |
160 | 160 | |
161 | - return new CheckResult( $context, $constraint, $parameters, $status, $message ); |
|
161 | + return new CheckResult($context, $constraint, $parameters, $status, $message); |
|
162 | 162 | } |
163 | 163 | |
164 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
164 | + public function checkConstraintParameters(Constraint $constraint) { |
|
165 | 165 | $constraintParameters = $constraint->getConstraintParameters(); |
166 | 166 | $exceptions = []; |
167 | 167 | try { |
168 | - $this->constraintParameterParser->parseNamespaceParameter( $constraintParameters, $constraint->getConstraintTypeItemId() ); |
|
169 | - } catch ( ConstraintParameterException $e ) { |
|
168 | + $this->constraintParameterParser->parseNamespaceParameter($constraintParameters, $constraint->getConstraintTypeItemId()); |
|
169 | + } catch (ConstraintParameterException $e) { |
|
170 | 170 | $exceptions[] = $e; |
171 | 171 | } |
172 | 172 | return $exceptions; |
@@ -177,9 +177,9 @@ discard block |
||
177 | 177 | * |
178 | 178 | * @return bool |
179 | 179 | */ |
180 | - private function commonsLinkIsWellFormed( $commonsLink ) { |
|
181 | - $toReplace = [ "_", "%20" ]; |
|
182 | - $compareString = trim( str_replace( $toReplace, '', $commonsLink ) ); |
|
180 | + private function commonsLinkIsWellFormed($commonsLink) { |
|
181 | + $toReplace = ["_", "%20"]; |
|
182 | + $compareString = trim(str_replace($toReplace, '', $commonsLink)); |
|
183 | 183 | |
184 | 184 | return $commonsLink === $compareString; |
185 | 185 | } |
@@ -193,9 +193,9 @@ discard block |
||
193 | 193 | * |
194 | 194 | * @return bool |
195 | 195 | */ |
196 | - private function valueIncludesNamespace( $value, $namespace ) { |
|
196 | + private function valueIncludesNamespace($value, $namespace) { |
|
197 | 197 | return $namespace !== '' && |
198 | - strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0; |
|
198 | + strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0; |
|
199 | 199 | } |
200 | 200 | |
201 | 201 | } |