wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/WikibaseQualityConstraintsHooks.php

Spacing +46 added lines, -46 removed lines

@@ -31,25 +31,25 @@ 
 	/**
 	 * @param DatabaseUpdater $updater
 	 */
-	public static function onCreateSchema( DatabaseUpdater $updater ) {
+	public static function onCreateSchema(DatabaseUpdater $updater) {
 		$updater->addExtensionTable(
 			'wbqc_constraints',
-			__DIR__ . '/../sql/create_wbqc_constraints.sql'
+			__DIR__.'/../sql/create_wbqc_constraints.sql'
 		);
 		$updater->addExtensionField(
 			'wbqc_constraints',
 			'constraint_id',
-			__DIR__ . '/../sql/patch-wbqc_constraints-constraint_id.sql'
+			__DIR__.'/../sql/patch-wbqc_constraints-constraint_id.sql'
 		);
 		$updater->addExtensionIndex(
 			'wbqc_constraints',
 			'wbqc_constraints_guid_uniq',
-			__DIR__ . '/../sql/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
+			__DIR__.'/../sql/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
 		);
 	}
 
-	public static function onWikibaseChange( Change $change ) {
-		if ( !( $change instanceof EntityChange ) ) {
+	public static function onWikibaseChange(Change $change) {
+		if (!($change instanceof EntityChange)) {
 			return;
 		}
 
@@ -58,44 +58,44 @@ 
 
 		// If jobs are enabled and the results would be stored in some way run a job.
 		if (
-			$config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) &&
-			$config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) &&
+			$config->get('WBQualityConstraintsEnableConstraintsCheckJobs') &&
+			$config->get('WBQualityConstraintsCacheCheckConstraintsResults') &&
 			self::isSelectedForJobRunBasedOnPercentage()
 		) {
-			$params = [ 'entityId' => $change->getEntityId()->getSerialization() ];
+			$params = ['entityId' => $change->getEntityId()->getSerialization()];
 			JobQueueGroup::singleton()->push(
-				new JobSpecification( CheckConstraintsJob::COMMAND, $params )
+				new JobSpecification(CheckConstraintsJob::COMMAND, $params)
 			);
 		}
 
-		if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
-			self::isConstraintStatementsChange( $config, $change )
+		if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') &&
+			self::isConstraintStatementsChange($config, $change)
 		) {
-			$params = [ 'propertyId' => $change->getEntityId()->getSerialization() ];
+			$params = ['propertyId' => $change->getEntityId()->getSerialization()];
 			JobQueueGroup::singleton()->push(
-				new JobSpecification( 'constraintsTableUpdate', $params )
+				new JobSpecification('constraintsTableUpdate', $params)
 			);
 		}
 	}
 
 	private static function isSelectedForJobRunBasedOnPercentage() {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
-		$percentage = $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' );
+		$percentage = $config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio');
 
-		return mt_rand( 1, 100 ) <= $percentage;
+		return mt_rand(1, 100) <= $percentage;
 	}
 
-	public static function isConstraintStatementsChange( Config $config, Change $change ) {
-		if ( !( $change instanceof EntityChange ) ||
+	public static function isConstraintStatementsChange(Config $config, Change $change) {
+		if (!($change instanceof EntityChange) ||
 			 $change->getAction() !== EntityChange::UPDATE ||
-			 !( $change->getEntityId() instanceof PropertyId )
+			 !($change->getEntityId() instanceof PropertyId)
 		) {
 			return false;
 		}
 
 		$info = $change->getInfo();
 
-		if ( !array_key_exists( 'compactDiff', $info ) ) {
+		if (!array_key_exists('compactDiff', $info)) {
 			// the non-compact diff ($info['diff']) does not contain statement diffs (T110996),
 			// so we only know that the change *might* affect the constraint statements
 			return true;
@@ -104,46 +104,46 @@ 
 		/** @var EntityDiffChangedAspects $aspects */
 		$aspects = $info['compactDiff'];
 
-		$propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
-		return in_array( $propertyConstraintId, $aspects->getStatementChanges() );
+		$propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId');
+		return in_array($propertyConstraintId, $aspects->getStatementChanges());
 	}
 
-	public static function onArticlePurge( WikiPage $wikiPage ) {
+	public static function onArticlePurge(WikiPage $wikiPage) {
 		$repo = WikibaseRepo::getDefaultInstance();
 
 		$entityContentFactory = $repo->getEntityContentFactory();
-		if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) {
-			$entityId = $entityContentFactory->getEntityIdForTitle( $wikiPage->getTitle() );
-			if ( $entityId !== null ) {
+		if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) {
+			$entityId = $entityContentFactory->getEntityIdForTitle($wikiPage->getTitle());
+			if ($entityId !== null) {
 				$resultsCache = ResultsCache::getDefaultInstance();
-				$resultsCache->delete( $entityId );
+				$resultsCache->delete($entityId);
 			}
 		}
 	}
 
-	public static function onBeforePageDisplay( OutputPage $out, Skin $skin ) {
+	public static function onBeforePageDisplay(OutputPage $out, Skin $skin) {
 		$repo = WikibaseRepo::getDefaultInstance();
 
 		$lookup = $repo->getEntityNamespaceLookup();
 		$title = $out->getTitle();
-		if ( $title === null ) {
+		if ($title === null) {
 			return;
 		}
 
-		if ( !$lookup->isEntityNamespace( $title->getNamespace() ) ) {
+		if (!$lookup->isEntityNamespace($title->getNamespace())) {
 			return;
 		}
-		if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) {
+		if (empty($out->getJsConfigVars()['wbIsEditView'])) {
 			return;
 		}
 
-		$out->addModules( 'wikibase.quality.constraints.suggestions' );
+		$out->addModules('wikibase.quality.constraints.suggestions');
 
-		if ( !$out->getUser()->isLoggedIn() ) {
+		if (!$out->getUser()->isLoggedIn()) {
 			return;
 		}
 
-		$out->addModules( 'wikibase.quality.constraints.gadget' );
+		$out->addModules('wikibase.quality.constraints.gadget');
 	}
 
 	/**
@@ -152,10 +152,10 @@ 
 	 * @param User $user
 	 * @param array[] &$prefs
 	 */
-	public static function onGetBetaFeaturePreferences( User $user, array &$prefs ) {
+	public static function onGetBetaFeaturePreferences(User $user, array &$prefs) {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
-		$extensionAssetsPath = $config->get( 'ExtensionAssetsPath' );
-		if ( $config->get( 'WBQualityConstraintsSuggestionsBetaFeature' ) ) {
+		$extensionAssetsPath = $config->get('ExtensionAssetsPath');
+		if ($config->get('WBQualityConstraintsSuggestionsBetaFeature')) {
 			$prefs['constraint-suggestions'] = [
 					'label-message' => 'wbqc-beta-feature-label-message',
 					'desc-message' => 'wbqc-beta-feature-description-message',
@@ -179,20 +179,20 @@ 
 	 * @param array &$vars
 	 * @param OutputPage $out
 	 */
-	public static function addVariables( &$vars, OutputPage $out ) {
+	public static function addVariables(&$vars, OutputPage $out) {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
 
-		$vars['wbQualityConstraintsPropertyConstraintId'] = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
-		$vars['wbQualityConstraintsOneOfConstraintId'] = $config->get( 'WBQualityConstraintsOneOfConstraintId' );
-		$vars['wbQualityConstraintsAllowedQualifierConstraintId'] = $config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' );
-		$vars['wbQualityConstraintsPropertyId'] = $config->get( 'WBQualityConstraintsPropertyId' );
-		$vars['wbQualityConstraintsQualifierOfPropertyConstraintId'] = $config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' );
+		$vars['wbQualityConstraintsPropertyConstraintId'] = $config->get('WBQualityConstraintsPropertyConstraintId');
+		$vars['wbQualityConstraintsOneOfConstraintId'] = $config->get('WBQualityConstraintsOneOfConstraintId');
+		$vars['wbQualityConstraintsAllowedQualifierConstraintId'] = $config->get('WBQualityConstraintsAllowedQualifiersConstraintId');
+		$vars['wbQualityConstraintsPropertyId'] = $config->get('WBQualityConstraintsPropertyId');
+		$vars['wbQualityConstraintsQualifierOfPropertyConstraintId'] = $config->get('WBQualityConstraintsQualifierOfPropertyConstraintId');
 
 		$vars['wbQualityConstraintsSuggestionsGloballyEnabled'] = false;
 
-		if ( $config->get( 'WBQualityConstraintsSuggestionsBetaFeature' ) &&
-			ExtensionRegistry::getInstance()->isLoaded( 'BetaFeatures' ) &&
-			BetaFeatures::isFeatureEnabled( $out->getUser(), 'constraint-suggestions' )
+		if ($config->get('WBQualityConstraintsSuggestionsBetaFeature') &&
+			ExtensionRegistry::getInstance()->isLoaded('BetaFeatures') &&
+			BetaFeatures::isFeatureEnabled($out->getUser(), 'constraint-suggestions')
 			) {
 			$vars['wbQualityConstraintsSuggestionsGloballyEnabled'] = true;
 		}

src/Job/CheckConstraintsJob.php

Spacing +13 added lines, -13 removed lines

@@ -42,25 +42,25 @@ 
 	 * @param Title $title
 	 * @param string[] $params should contain 'entityId' => 'Q1234'
 	 */
-	public function __construct( Title $title, array $params ) {
-		parent::__construct( self::COMMAND, $title, $params );
+	public function __construct(Title $title, array $params) {
+		parent::__construct(self::COMMAND, $title, $params);
 		$this->removeDuplicates = true;
 
-		Assert::parameterType( 'string', $params['entityId'], '$params[\'entityId\']' );
+		Assert::parameterType('string', $params['entityId'], '$params[\'entityId\']');
 		$this->entityId = $params['entityId'];
 
-		$resultSource = ConstraintsServices::getResultsSource( MediaWikiServices::getInstance() );
+		$resultSource = ConstraintsServices::getResultsSource(MediaWikiServices::getInstance());
 		// This job should only ever be used when caching result sources are used.
-		$this->setResultsSource( $resultSource );
+		$this->setResultsSource($resultSource);
 
-		$this->setEntityIdParser( WikibaseRepo::getDefaultInstance()->getEntityIdParser() );
+		$this->setEntityIdParser(WikibaseRepo::getDefaultInstance()->getEntityIdParser());
 	}
 
-	public function setResultsSource( CachingResultsSource $resultsSource ) {
+	public function setResultsSource(CachingResultsSource $resultsSource) {
 		$this->resultsSource = $resultsSource;
 	}
 
-	public function setEntityIdParser( EntityIdParser $parser ) {
+	public function setEntityIdParser(EntityIdParser $parser) {
 		$this->entityIdParser = $parser;
 	}
 
@@ -71,19 +71,19 @@ 
 	 */
 	public function run() {
 		try {
-			$entityId = $this->entityIdParser->parse( $this->entityId );
-		} catch ( EntityIdParsingException $e ) {
+			$entityId = $this->entityIdParser->parse($this->entityId);
+		} catch (EntityIdParsingException $e) {
 			return false;
 		}
 
-		$this->checkConstraints( $entityId );
+		$this->checkConstraints($entityId);
 
 		return true;
 	}
 
-	private function checkConstraints( EntityId $entityId ) {
+	private function checkConstraints(EntityId $entityId) {
 		$this->resultsSource->getResults(
-			[ $entityId ],
+			[$entityId],
 			[],
 			null,
 			[]