@@ -18,10 +18,10 @@ discard block |
||
18 | 18 | use Wikibase\Repo\WikibaseRepo; |
19 | 19 | |
20 | 20 | // @codeCoverageIgnoreStart |
21 | -$basePath = getenv( "MW_INSTALL_PATH" ) !== false |
|
22 | - ? getenv( "MW_INSTALL_PATH" ) : __DIR__ . "/../../.."; |
|
21 | +$basePath = getenv("MW_INSTALL_PATH") !== false |
|
22 | + ? getenv("MW_INSTALL_PATH") : __DIR__."/../../.."; |
|
23 | 23 | |
24 | -require_once $basePath . "/maintenance/Maintenance.php"; |
|
24 | +require_once $basePath."/maintenance/Maintenance.php"; |
|
25 | 25 | // @codeCoverageIgnoreEnd |
26 | 26 | |
27 | 27 | /** |
@@ -60,20 +60,20 @@ discard block |
||
60 | 60 | parent::__construct(); |
61 | 61 | |
62 | 62 | $this->addDescription( |
63 | - 'Import entities needed for constraint checks ' . |
|
63 | + 'Import entities needed for constraint checks '. |
|
64 | 64 | 'from Wikidata into the local repository.' |
65 | 65 | ); |
66 | 66 | $this->addOption( |
67 | 67 | 'config-format', |
68 | - 'The format in which the resulting configuration will be omitted: ' . |
|
69 | - '"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), ' . |
|
68 | + 'The format in which the resulting configuration will be omitted: '. |
|
69 | + '"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), '. |
|
70 | 70 | 'or "wgConf" for printing parts of arrays suitable for inclusion in $wgConf->settings.' |
71 | 71 | ); |
72 | 72 | $this->addOption( |
73 | 73 | 'dry-run', |
74 | 74 | 'Don’t actually import entities, just print which ones would be imported.' |
75 | 75 | ); |
76 | - $this->requireExtension( 'WikibaseQualityConstraints' ); |
|
76 | + $this->requireExtension('WikibaseQualityConstraints'); |
|
77 | 77 | } |
78 | 78 | |
79 | 79 | /** |
@@ -81,12 +81,12 @@ discard block |
||
81 | 81 | */ |
82 | 82 | private function setupServices() { |
83 | 83 | $services = MediaWikiServices::getInstance(); |
84 | - $this->entitySerializer = WikibaseRepo::getAllTypesEntitySerializer( $services ); |
|
85 | - $this->entityDeserializer = WikibaseRepo::getInternalFormatEntityDeserializer( $services ); |
|
86 | - $this->entityStore = WikibaseRepo::getEntityStore( $services ); |
|
84 | + $this->entitySerializer = WikibaseRepo::getAllTypesEntitySerializer($services); |
|
85 | + $this->entityDeserializer = WikibaseRepo::getInternalFormatEntityDeserializer($services); |
|
86 | + $this->entityStore = WikibaseRepo::getEntityStore($services); |
|
87 | 87 | $this->httpRequestFactory = $services->getHttpRequestFactory(); |
88 | - if ( !$this->getOption( 'dry-run', false ) ) { |
|
89 | - $this->user = User::newSystemUser( 'WikibaseQualityConstraints importer' ); |
|
88 | + if (!$this->getOption('dry-run', false)) { |
|
89 | + $this->user = User::newSystemUser('WikibaseQualityConstraints importer'); |
|
90 | 90 | } |
91 | 91 | } |
92 | 92 | |
@@ -95,21 +95,21 @@ discard block |
||
95 | 95 | |
96 | 96 | $configUpdates = []; |
97 | 97 | |
98 | - $extensionJsonFile = __DIR__ . '/../extension.json'; |
|
99 | - $extensionJsonText = file_get_contents( $extensionJsonFile ); |
|
100 | - $extensionJson = json_decode( $extensionJsonText, /* assoc = */ true ); |
|
98 | + $extensionJsonFile = __DIR__.'/../extension.json'; |
|
99 | + $extensionJsonText = file_get_contents($extensionJsonFile); |
|
100 | + $extensionJson = json_decode($extensionJsonText, /* assoc = */ true); |
|
101 | 101 | // @phan-suppress-next-line PhanTypeArraySuspiciousNullable |
102 | - $wikidataEntityIds = $this->getEntitiesToImport( $extensionJson['config'], $this->getConfig() ); |
|
102 | + $wikidataEntityIds = $this->getEntitiesToImport($extensionJson['config'], $this->getConfig()); |
|
103 | 103 | |
104 | - foreach ( $wikidataEntityIds as $key => $wikidataEntityId ) { |
|
105 | - $localEntityId = $this->importEntityFromWikidata( $wikidataEntityId ); |
|
104 | + foreach ($wikidataEntityIds as $key => $wikidataEntityId) { |
|
105 | + $localEntityId = $this->importEntityFromWikidata($wikidataEntityId); |
|
106 | 106 | $configUpdates[$key] = [ |
107 | 107 | 'wikidata' => $wikidataEntityId, |
108 | 108 | 'local' => $localEntityId, |
109 | 109 | ]; |
110 | 110 | } |
111 | 111 | |
112 | - $this->outputConfigUpdates( $configUpdates ); |
|
112 | + $this->outputConfigUpdates($configUpdates); |
|
113 | 113 | } |
114 | 114 | |
115 | 115 | /** |
@@ -117,18 +117,18 @@ discard block |
||
117 | 117 | * @param Config $wikiConfig |
118 | 118 | * @return string[] |
119 | 119 | */ |
120 | - private function getEntitiesToImport( array $extensionJsonConfig, Config $wikiConfig ) { |
|
120 | + private function getEntitiesToImport(array $extensionJsonConfig, Config $wikiConfig) { |
|
121 | 121 | $wikidataEntityIds = []; |
122 | 122 | |
123 | - foreach ( $extensionJsonConfig as $key => $value ) { |
|
124 | - if ( !preg_match( '/Id$/', $key ) ) { |
|
123 | + foreach ($extensionJsonConfig as $key => $value) { |
|
124 | + if (!preg_match('/Id$/', $key)) { |
|
125 | 125 | continue; |
126 | 126 | } |
127 | 127 | |
128 | 128 | $wikidataEntityId = $value['value']; |
129 | - $localEntityId = $wikiConfig->get( $key ); |
|
129 | + $localEntityId = $wikiConfig->get($key); |
|
130 | 130 | |
131 | - if ( $localEntityId === $wikidataEntityId ) { |
|
131 | + if ($localEntityId === $wikidataEntityId) { |
|
132 | 132 | $wikidataEntityIds[$key] = $wikidataEntityId; |
133 | 133 | } |
134 | 134 | } |
@@ -140,10 +140,10 @@ discard block |
||
140 | 140 | * @param string $wikidataEntityId |
141 | 141 | * @return string local entity ID |
142 | 142 | */ |
143 | - private function importEntityFromWikidata( $wikidataEntityId ) { |
|
143 | + private function importEntityFromWikidata($wikidataEntityId) { |
|
144 | 144 | $wikidataEntityUrl = "https://www.wikidata.org/wiki/Special:EntityData/$wikidataEntityId.json"; |
145 | - $wikidataEntitiesJson = $this->httpRequestFactory->get( $wikidataEntityUrl, [], __METHOD__ ); |
|
146 | - return $this->importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson ); |
|
145 | + $wikidataEntitiesJson = $this->httpRequestFactory->get($wikidataEntityUrl, [], __METHOD__); |
|
146 | + return $this->importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson); |
|
147 | 147 | } |
148 | 148 | |
149 | 149 | /** |
@@ -151,24 +151,24 @@ discard block |
||
151 | 151 | * @param string $wikidataEntitiesJson |
152 | 152 | * @return string local entity ID |
153 | 153 | */ |
154 | - private function importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson ) { |
|
154 | + private function importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson) { |
|
155 | 155 | // @phan-suppress-next-line PhanTypeArraySuspiciousNullable |
156 | - $wikidataEntityArray = json_decode( $wikidataEntitiesJson, true )['entities'][$wikidataEntityId]; |
|
157 | - $wikidataEntity = $this->entityDeserializer->deserialize( $wikidataEntityArray ); |
|
156 | + $wikidataEntityArray = json_decode($wikidataEntitiesJson, true)['entities'][$wikidataEntityId]; |
|
157 | + $wikidataEntity = $this->entityDeserializer->deserialize($wikidataEntityArray); |
|
158 | 158 | |
159 | - $wikidataEntity->setId( null ); |
|
159 | + $wikidataEntity->setId(null); |
|
160 | 160 | |
161 | - if ( $wikidataEntity instanceof StatementListProvider ) { |
|
161 | + if ($wikidataEntity instanceof StatementListProvider) { |
|
162 | 162 | $wikidataEntity->getStatements()->clear(); |
163 | 163 | } |
164 | 164 | |
165 | - if ( $wikidataEntity instanceof Item ) { |
|
166 | - $wikidataEntity->setSiteLinkList( new SiteLinkList() ); |
|
165 | + if ($wikidataEntity instanceof Item) { |
|
166 | + $wikidataEntity->setSiteLinkList(new SiteLinkList()); |
|
167 | 167 | } |
168 | 168 | |
169 | - if ( $this->getOption( 'dry-run', false ) ) { |
|
170 | - $wikidataEntityJson = json_encode( $this->entitySerializer->serialize( $wikidataEntity ) ); |
|
171 | - $this->output( $wikidataEntityJson . "\n" ); |
|
169 | + if ($this->getOption('dry-run', false)) { |
|
170 | + $wikidataEntityJson = json_encode($this->entitySerializer->serialize($wikidataEntity)); |
|
171 | + $this->output($wikidataEntityJson."\n"); |
|
172 | 172 | return "-$wikidataEntityId"; |
173 | 173 | } |
174 | 174 | |
@@ -181,12 +181,12 @@ discard block |
||
181 | 181 | )->getEntity(); |
182 | 182 | |
183 | 183 | return $localEntity->getId()->getSerialization(); |
184 | - } catch ( StorageException $storageException ) { |
|
185 | - return $this->storageExceptionToEntityId( $storageException ); |
|
184 | + } catch (StorageException $storageException) { |
|
185 | + return $this->storageExceptionToEntityId($storageException); |
|
186 | 186 | } |
187 | 187 | } |
188 | 188 | |
189 | - private function storageExceptionToEntityId( StorageException $storageException ): string { |
|
189 | + private function storageExceptionToEntityId(StorageException $storageException): string { |
|
190 | 190 | $message = $storageException->getMessage(); |
191 | 191 | // example messages: |
192 | 192 | // * Item [[Item:Q475|Q475]] already has label "as references" |
@@ -196,25 +196,25 @@ discard block |
||
196 | 196 | // * Property [[Property:P694|P694]] already has label "instance of" |
197 | 197 | // associated with language code en. |
198 | 198 | $pattern = '/[[|]([^][|]*)]] already has label .* associated with language code/'; |
199 | - if ( preg_match( $pattern, $message, $matches ) ) { |
|
199 | + if (preg_match($pattern, $message, $matches)) { |
|
200 | 200 | return $matches[1]; |
201 | 201 | } else { |
202 | 202 | throw $storageException; |
203 | 203 | } |
204 | 204 | } |
205 | 205 | |
206 | - private function outputConfigUpdates( array $configUpdates ) { |
|
207 | - $configFormat = $this->getOption( 'config-format', 'globals' ); |
|
208 | - switch ( $configFormat ) { |
|
206 | + private function outputConfigUpdates(array $configUpdates) { |
|
207 | + $configFormat = $this->getOption('config-format', 'globals'); |
|
208 | + switch ($configFormat) { |
|
209 | 209 | case 'globals': |
210 | - $this->outputConfigUpdatesGlobals( $configUpdates ); |
|
210 | + $this->outputConfigUpdatesGlobals($configUpdates); |
|
211 | 211 | break; |
212 | 212 | case 'wgConf': |
213 | - $this->outputConfigUpdatesWgConf( $configUpdates ); |
|
213 | + $this->outputConfigUpdatesWgConf($configUpdates); |
|
214 | 214 | break; |
215 | 215 | default: |
216 | - $this->error( "Invalid config format \"$configFormat\", using \"globals\"" ); |
|
217 | - $this->outputConfigUpdatesGlobals( $configUpdates ); |
|
216 | + $this->error("Invalid config format \"$configFormat\", using \"globals\""); |
|
217 | + $this->outputConfigUpdatesGlobals($configUpdates); |
|
218 | 218 | break; |
219 | 219 | } |
220 | 220 | } |
@@ -222,22 +222,22 @@ discard block |
||
222 | 222 | /** |
223 | 223 | * @param array[] $configUpdates |
224 | 224 | */ |
225 | - private function outputConfigUpdatesGlobals( array $configUpdates ) { |
|
226 | - foreach ( $configUpdates as $key => $value ) { |
|
227 | - $localValueCode = var_export( $value['local'], true ); |
|
228 | - $this->output( "\$wg$key = $localValueCode;\n" ); |
|
225 | + private function outputConfigUpdatesGlobals(array $configUpdates) { |
|
226 | + foreach ($configUpdates as $key => $value) { |
|
227 | + $localValueCode = var_export($value['local'], true); |
|
228 | + $this->output("\$wg$key = $localValueCode;\n"); |
|
229 | 229 | } |
230 | 230 | } |
231 | 231 | |
232 | 232 | /** |
233 | 233 | * @param array[] $configUpdates |
234 | 234 | */ |
235 | - private function outputConfigUpdatesWgConf( array $configUpdates ) { |
|
236 | - $wikiIdCode = var_export( WikiMap::getCurrentWikiId(), true ); |
|
237 | - foreach ( $configUpdates as $key => $value ) { |
|
238 | - $keyCode = var_export( "wg$key", true ); |
|
239 | - $wikidataValueCode = var_export( $value['wikidata'], true ); |
|
240 | - $localValueCode = var_export( $value['local'], true ); |
|
235 | + private function outputConfigUpdatesWgConf(array $configUpdates) { |
|
236 | + $wikiIdCode = var_export(WikiMap::getCurrentWikiId(), true); |
|
237 | + foreach ($configUpdates as $key => $value) { |
|
238 | + $keyCode = var_export("wg$key", true); |
|
239 | + $wikidataValueCode = var_export($value['wikidata'], true); |
|
240 | + $localValueCode = var_export($value['local'], true); |
|
241 | 241 | $block = <<< EOF |
242 | 242 | $keyCode => [ |
243 | 243 | 'default' => $wikidataValueCode, |
@@ -246,7 +246,7 @@ discard block |
||
246 | 246 | |
247 | 247 | |
248 | 248 | EOF; |
249 | - $this->output( $block ); |
|
249 | + $this->output($block); |
|
250 | 250 | } |
251 | 251 | } |
252 | 252 |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport; |
6 | 6 | |
@@ -25,9 +25,9 @@ discard block |
||
25 | 25 | public const ENTITY_LOOKUP = 'WBQC_EntityLookup'; |
26 | 26 | public const ENTITY_LOOKUP_WITHOUT_CACHE = 'WBQC_EntityLookupWithoutCache'; |
27 | 27 | |
28 | - private static function getService( ?MediaWikiServices $services, string $name ) { |
|
28 | + private static function getService(?MediaWikiServices $services, string $name) { |
|
29 | 29 | $services ??= MediaWikiServices::getInstance(); |
30 | - return $services->getService( $name ); |
|
30 | + return $services->getService($name); |
|
31 | 31 | } |
32 | 32 | |
33 | 33 | /** |
@@ -37,8 +37,8 @@ discard block |
||
37 | 37 | * this lookup ignores exceptions (such as unresolved redirects, T93273), |
38 | 38 | * as it is more convenient to treat them all as missing entities in WBQC. |
39 | 39 | */ |
40 | - public static function getEntityLookup( ?MediaWikiServices $services = null ): EntityLookup { |
|
41 | - return self::getService( $services, self::ENTITY_LOOKUP ); |
|
40 | + public static function getEntityLookup(?MediaWikiServices $services = null): EntityLookup { |
|
41 | + return self::getService($services, self::ENTITY_LOOKUP); |
|
42 | 42 | } |
43 | 43 | |
44 | 44 | /** |
@@ -48,8 +48,8 @@ discard block |
||
48 | 48 | * were exceeding the request memory limit when they were all added to the cache (T227450). |
49 | 49 | * Also, like {@link self::getEntityLookup()}, this lookup ignores exceptions. |
50 | 50 | */ |
51 | - public static function getEntityLookupWithoutCache( ?MediaWikiServices $services = null ): EntityLookup { |
|
52 | - return self::getService( $services, self::ENTITY_LOOKUP_WITHOUT_CACHE ); |
|
51 | + public static function getEntityLookupWithoutCache(?MediaWikiServices $services = null): EntityLookup { |
|
52 | + return self::getService($services, self::ENTITY_LOOKUP_WITHOUT_CACHE); |
|
53 | 53 | } |
54 | 54 | |
55 | 55 | } |
@@ -38,8 +38,8 @@ discard block |
||
38 | 38 | */ |
39 | 39 | private const BATCH_SIZE = 50; |
40 | 40 | |
41 | - public static function newFromGlobalState( Title $title, array $params ): self { |
|
42 | - Assert::parameterType( 'string', $params['propertyId'], '$params["propertyId"]' ); |
|
41 | + public static function newFromGlobalState(Title $title, array $params): self { |
|
42 | + Assert::parameterType('string', $params['propertyId'], '$params["propertyId"]'); |
|
43 | 43 | $services = MediaWikiServices::getInstance(); |
44 | 44 | return new UpdateConstraintsTableJob( |
45 | 45 | $title, |
@@ -49,8 +49,8 @@ discard block |
||
49 | 49 | $services->getMainConfig(), |
50 | 50 | ConstraintsServices::getConstraintStore(), |
51 | 51 | $services->getDBLoadBalancerFactory(), |
52 | - WikibaseRepo::getStore()->getEntityRevisionLookup( Store::LOOKUP_CACHING_DISABLED ), |
|
53 | - WikibaseRepo::getBaseDataModelSerializerFactory( $services ) |
|
52 | + WikibaseRepo::getStore()->getEntityRevisionLookup(Store::LOOKUP_CACHING_DISABLED), |
|
53 | + WikibaseRepo::getBaseDataModelSerializerFactory($services) |
|
54 | 54 | ->newSnakSerializer(), |
55 | 55 | $services->getJobQueueGroup() |
56 | 56 | ); |
@@ -118,7 +118,7 @@ discard block |
||
118 | 118 | Serializer $snakSerializer, |
119 | 119 | JobQueueGroup $jobQueueGroup |
120 | 120 | ) { |
121 | - parent::__construct( 'constraintsTableUpdate', $title, $params ); |
|
121 | + parent::__construct('constraintsTableUpdate', $title, $params); |
|
122 | 122 | |
123 | 123 | $this->propertyId = $propertyId; |
124 | 124 | $this->revisionId = $revisionId; |
@@ -130,11 +130,11 @@ discard block |
||
130 | 130 | $this->jobQueueGroup = $jobQueueGroup; |
131 | 131 | } |
132 | 132 | |
133 | - public function extractParametersFromQualifiers( SnakList $qualifiers ): array { |
|
133 | + public function extractParametersFromQualifiers(SnakList $qualifiers): array { |
|
134 | 134 | $parameters = []; |
135 | - foreach ( $qualifiers as $qualifier ) { |
|
135 | + foreach ($qualifiers as $qualifier) { |
|
136 | 136 | $qualifierId = $qualifier->getPropertyId()->getSerialization(); |
137 | - $paramSerialization = $this->snakSerializer->serialize( $qualifier ); |
|
137 | + $paramSerialization = $this->snakSerializer->serialize($qualifier); |
|
138 | 138 | $parameters[$qualifierId][] = $paramSerialization; |
139 | 139 | } |
140 | 140 | return $parameters; |
@@ -152,7 +152,7 @@ discard block |
||
152 | 152 | '@phan-var \Wikibase\DataModel\Entity\EntityIdValue $dataValue'; |
153 | 153 | $entityId = $dataValue->getEntityId(); |
154 | 154 | $constraintTypeQid = $entityId->getSerialization(); |
155 | - $parameters = $this->extractParametersFromQualifiers( $constraintStatement->getQualifiers() ); |
|
155 | + $parameters = $this->extractParametersFromQualifiers($constraintStatement->getQualifiers()); |
|
156 | 156 | return new Constraint( |
157 | 157 | $constraintId, |
158 | 158 | $propertyId, |
@@ -167,25 +167,25 @@ discard block |
||
167 | 167 | NumericPropertyId $propertyConstraintPropertyId |
168 | 168 | ) { |
169 | 169 | $constraintsStatements = $property->getStatements() |
170 | - ->getByPropertyId( $propertyConstraintPropertyId ) |
|
171 | - ->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] ); |
|
170 | + ->getByPropertyId($propertyConstraintPropertyId) |
|
171 | + ->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]); |
|
172 | 172 | $constraints = []; |
173 | - foreach ( $constraintsStatements->getIterator() as $constraintStatement ) { |
|
173 | + foreach ($constraintsStatements->getIterator() as $constraintStatement) { |
|
174 | 174 | // @phan-suppress-next-line PhanTypeMismatchArgumentSuperType |
175 | - $constraints[] = $this->extractConstraintFromStatement( $property->getId(), $constraintStatement ); |
|
176 | - if ( count( $constraints ) >= self::BATCH_SIZE ) { |
|
177 | - $constraintStore->insertBatch( $constraints ); |
|
175 | + $constraints[] = $this->extractConstraintFromStatement($property->getId(), $constraintStatement); |
|
176 | + if (count($constraints) >= self::BATCH_SIZE) { |
|
177 | + $constraintStore->insertBatch($constraints); |
|
178 | 178 | // interrupt transaction and wait for replication |
179 | - $connection = $this->lbFactory->getMainLB()->getConnection( DB_PRIMARY ); |
|
180 | - $connection->endAtomic( __CLASS__ ); |
|
181 | - if ( !$connection->explicitTrxActive() ) { |
|
179 | + $connection = $this->lbFactory->getMainLB()->getConnection(DB_PRIMARY); |
|
180 | + $connection->endAtomic(__CLASS__); |
|
181 | + if (!$connection->explicitTrxActive()) { |
|
182 | 182 | $this->lbFactory->waitForReplication(); |
183 | 183 | } |
184 | - $connection->startAtomic( __CLASS__ ); |
|
184 | + $connection->startAtomic(__CLASS__); |
|
185 | 185 | $constraints = []; |
186 | 186 | } |
187 | 187 | } |
188 | - $constraintStore->insertBatch( $constraints ); |
|
188 | + $constraintStore->insertBatch($constraints); |
|
189 | 189 | } |
190 | 190 | |
191 | 191 | /** |
@@ -196,24 +196,24 @@ discard block |
||
196 | 196 | public function run() { |
197 | 197 | // TODO in the future: only touch constraints affected by the edit (requires T163465) |
198 | 198 | |
199 | - $propertyId = new NumericPropertyId( $this->propertyId ); |
|
199 | + $propertyId = new NumericPropertyId($this->propertyId); |
|
200 | 200 | $propertyRevision = $this->entityRevisionLookup->getEntityRevision( |
201 | 201 | $propertyId, |
202 | 202 | 0, // latest |
203 | 203 | LookupConstants::LATEST_FROM_REPLICA |
204 | 204 | ); |
205 | 205 | |
206 | - if ( $this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId ) { |
|
207 | - $this->jobQueueGroup->push( $this ); |
|
206 | + if ($this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId) { |
|
207 | + $this->jobQueueGroup->push($this); |
|
208 | 208 | return true; |
209 | 209 | } |
210 | 210 | |
211 | - $connection = $this->lbFactory->getMainLB()->getConnection( DB_PRIMARY ); |
|
211 | + $connection = $this->lbFactory->getMainLB()->getConnection(DB_PRIMARY); |
|
212 | 212 | // start transaction (if not started yet) – using __CLASS__, not __METHOD__, |
213 | 213 | // because importConstraintsForProperty() can interrupt the transaction |
214 | - $connection->startAtomic( __CLASS__ ); |
|
214 | + $connection->startAtomic(__CLASS__); |
|
215 | 215 | |
216 | - $this->constraintStore->deleteForProperty( $propertyId ); |
|
216 | + $this->constraintStore->deleteForProperty($propertyId); |
|
217 | 217 | |
218 | 218 | /** @var Property $property */ |
219 | 219 | $property = $propertyRevision->getEntity(); |
@@ -221,10 +221,10 @@ discard block |
||
221 | 221 | $this->importConstraintsForProperty( |
222 | 222 | $property, |
223 | 223 | $this->constraintStore, |
224 | - new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ) |
|
224 | + new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')) |
|
225 | 225 | ); |
226 | 226 | |
227 | - $connection->endAtomic( __CLASS__ ); |
|
227 | + $connection->endAtomic(__CLASS__); |
|
228 | 228 | |
229 | 229 | return true; |
230 | 230 | } |
@@ -26,8 +26,8 @@ discard block |
||
26 | 26 | BeforePageDisplayHook |
27 | 27 | { |
28 | 28 | |
29 | - public static function onWikibaseChange( Change $change ) { |
|
30 | - if ( !( $change instanceof EntityChange ) ) { |
|
29 | + public static function onWikibaseChange(Change $change) { |
|
30 | + if (!($change instanceof EntityChange)) { |
|
31 | 31 | return; |
32 | 32 | } |
33 | 33 | /** @var EntityChange $change */ |
@@ -38,48 +38,48 @@ discard block |
||
38 | 38 | |
39 | 39 | // If jobs are enabled and the results would be stored in some way run a job. |
40 | 40 | if ( |
41 | - $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) && |
|
42 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) && |
|
41 | + $config->get('WBQualityConstraintsEnableConstraintsCheckJobs') && |
|
42 | + $config->get('WBQualityConstraintsCacheCheckConstraintsResults') && |
|
43 | 43 | self::isSelectedForJobRunBasedOnPercentage() |
44 | 44 | ) { |
45 | - $params = [ 'entityId' => $change->getEntityId()->getSerialization() ]; |
|
45 | + $params = ['entityId' => $change->getEntityId()->getSerialization()]; |
|
46 | 46 | $jobQueueGroup->lazyPush( |
47 | - new JobSpecification( CheckConstraintsJob::COMMAND, $params ) |
|
47 | + new JobSpecification(CheckConstraintsJob::COMMAND, $params) |
|
48 | 48 | ); |
49 | 49 | } |
50 | 50 | |
51 | - if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) && |
|
52 | - self::isConstraintStatementsChange( $config, $change ) |
|
51 | + if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') && |
|
52 | + self::isConstraintStatementsChange($config, $change) |
|
53 | 53 | ) { |
54 | - $params = [ 'propertyId' => $change->getEntityId()->getSerialization() ]; |
|
54 | + $params = ['propertyId' => $change->getEntityId()->getSerialization()]; |
|
55 | 55 | $metadata = $change->getMetadata(); |
56 | - if ( array_key_exists( 'rev_id', $metadata ) ) { |
|
56 | + if (array_key_exists('rev_id', $metadata)) { |
|
57 | 57 | $params['revisionId'] = $metadata['rev_id']; |
58 | 58 | } |
59 | 59 | $jobQueueGroup->push( |
60 | - new JobSpecification( 'constraintsTableUpdate', $params ) |
|
60 | + new JobSpecification('constraintsTableUpdate', $params) |
|
61 | 61 | ); |
62 | 62 | } |
63 | 63 | } |
64 | 64 | |
65 | 65 | private static function isSelectedForJobRunBasedOnPercentage(): bool { |
66 | 66 | $config = MediaWikiServices::getInstance()->getMainConfig(); |
67 | - $percentage = $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' ); |
|
67 | + $percentage = $config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio'); |
|
68 | 68 | |
69 | - return mt_rand( 1, 100 ) <= $percentage; |
|
69 | + return mt_rand(1, 100) <= $percentage; |
|
70 | 70 | } |
71 | 71 | |
72 | - public static function isConstraintStatementsChange( Config $config, Change $change ): bool { |
|
73 | - if ( !( $change instanceof EntityChange ) || |
|
72 | + public static function isConstraintStatementsChange(Config $config, Change $change): bool { |
|
73 | + if (!($change instanceof EntityChange) || |
|
74 | 74 | $change->getAction() !== EntityChange::UPDATE || |
75 | - !( $change->getEntityId() instanceof NumericPropertyId ) |
|
75 | + !($change->getEntityId() instanceof NumericPropertyId) |
|
76 | 76 | ) { |
77 | 77 | return false; |
78 | 78 | } |
79 | 79 | |
80 | 80 | $info = $change->getInfo(); |
81 | 81 | |
82 | - if ( !array_key_exists( 'compactDiff', $info ) ) { |
|
82 | + if (!array_key_exists('compactDiff', $info)) { |
|
83 | 83 | // the non-compact diff ($info['diff']) does not contain statement diffs (T110996), |
84 | 84 | // so we only know that the change *might* affect the constraint statements |
85 | 85 | return true; |
@@ -88,50 +88,50 @@ discard block |
||
88 | 88 | /** @var EntityDiffChangedAspects $aspects */ |
89 | 89 | $aspects = $info['compactDiff']; |
90 | 90 | |
91 | - $propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' ); |
|
92 | - return in_array( $propertyConstraintId, $aspects->getStatementChanges() ); |
|
91 | + $propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId'); |
|
92 | + return in_array($propertyConstraintId, $aspects->getStatementChanges()); |
|
93 | 93 | } |
94 | 94 | |
95 | - public function onArticlePurge( $wikiPage ) { |
|
95 | + public function onArticlePurge($wikiPage) { |
|
96 | 96 | $entityContentFactory = WikibaseRepo::getEntityContentFactory(); |
97 | - if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) { |
|
97 | + if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) { |
|
98 | 98 | $entityIdLookup = WikibaseRepo::getEntityIdLookup(); |
99 | - $entityId = $entityIdLookup->getEntityIdForTitle( $wikiPage->getTitle() ); |
|
100 | - if ( $entityId !== null ) { |
|
99 | + $entityId = $entityIdLookup->getEntityIdForTitle($wikiPage->getTitle()); |
|
100 | + if ($entityId !== null) { |
|
101 | 101 | $resultsCache = ResultsCache::getDefaultInstance(); |
102 | - $resultsCache->delete( $entityId ); |
|
102 | + $resultsCache->delete($entityId); |
|
103 | 103 | } |
104 | 104 | } |
105 | 105 | } |
106 | 106 | |
107 | - public function onBeforePageDisplay( $out, $skin ): void { |
|
107 | + public function onBeforePageDisplay($out, $skin): void { |
|
108 | 108 | $lookup = WikibaseRepo::getEntityNamespaceLookup(); |
109 | 109 | $title = $out->getTitle(); |
110 | - if ( $title === null ) { |
|
110 | + if ($title === null) { |
|
111 | 111 | return; |
112 | 112 | } |
113 | 113 | |
114 | - if ( !$lookup->isNamespaceWithEntities( $title->getNamespace() ) ) { |
|
114 | + if (!$lookup->isNamespaceWithEntities($title->getNamespace())) { |
|
115 | 115 | return; |
116 | 116 | } |
117 | - if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) { |
|
117 | + if (empty($out->getJsConfigVars()['wbIsEditView'])) { |
|
118 | 118 | return; |
119 | 119 | } |
120 | 120 | |
121 | 121 | $services = MediaWikiServices::getInstance(); |
122 | 122 | $config = $services->getMainConfig(); |
123 | 123 | |
124 | - $isMobileView = ExtensionRegistry::getInstance()->isLoaded( 'MobileFrontend' ) && |
|
125 | - $services->getService( 'MobileFrontend.Context' )->shouldDisplayMobileView(); |
|
126 | - if ( $isMobileView ) { |
|
124 | + $isMobileView = ExtensionRegistry::getInstance()->isLoaded('MobileFrontend') && |
|
125 | + $services->getService('MobileFrontend.Context')->shouldDisplayMobileView(); |
|
126 | + if ($isMobileView) { |
|
127 | 127 | return; |
128 | 128 | } |
129 | 129 | |
130 | - $out->addModules( 'wikibase.quality.constraints.suggestions' ); |
|
130 | + $out->addModules('wikibase.quality.constraints.suggestions'); |
|
131 | 131 | |
132 | - if ( $config->get( 'WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers' ) |
|
133 | - || $out->getUser()->isRegistered() ) { |
|
134 | - $out->addModules( 'wikibase.quality.constraints.gadget' ); |
|
132 | + if ($config->get('WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers') |
|
133 | + || $out->getUser()->isRegistered()) { |
|
134 | + $out->addModules('wikibase.quality.constraints.gadget'); |
|
135 | 135 | } |
136 | 136 | } |
137 | 137 |
@@ -44,257 +44,257 @@ |
||
44 | 44 | public const LEXEME_LANGUAGE_CHECKER = 'WBQC_Lexeme_LanguageChecker'; |
45 | 45 | public const LABEL_IN_LANGUAGE_CHECKER = 'WBQC_LabelInLanguageChecker'; |
46 | 46 | |
47 | - private static function getService( ?MediaWikiServices $services, string $name ) { |
|
47 | + private static function getService(?MediaWikiServices $services, string $name) { |
|
48 | 48 | $services ??= MediaWikiServices::getInstance(); |
49 | - return $services->getService( $name ); |
|
49 | + return $services->getService($name); |
|
50 | 50 | } |
51 | 51 | |
52 | 52 | /** |
53 | 53 | * @param MediaWikiServices|null $services |
54 | 54 | * @return ConstraintChecker |
55 | 55 | */ |
56 | - public static function getConflictsWithChecker( ?MediaWikiServices $services = null ) { |
|
57 | - return self::getService( $services, self::CONFLICTS_WITH_CHECKER ); |
|
56 | + public static function getConflictsWithChecker(?MediaWikiServices $services = null) { |
|
57 | + return self::getService($services, self::CONFLICTS_WITH_CHECKER); |
|
58 | 58 | } |
59 | 59 | |
60 | 60 | /** |
61 | 61 | * @param MediaWikiServices|null $services |
62 | 62 | * @return ConstraintChecker |
63 | 63 | */ |
64 | - public static function getItemChecker( ?MediaWikiServices $services = null ) { |
|
65 | - return self::getService( $services, self::ITEM_CHECKER ); |
|
64 | + public static function getItemChecker(?MediaWikiServices $services = null) { |
|
65 | + return self::getService($services, self::ITEM_CHECKER); |
|
66 | 66 | } |
67 | 67 | |
68 | 68 | /** |
69 | 69 | * @param MediaWikiServices|null $services |
70 | 70 | * @return ConstraintChecker |
71 | 71 | */ |
72 | - public static function getTargetRequiredClaimChecker( ?MediaWikiServices $services = null ) { |
|
73 | - return self::getService( $services, self::TARGET_REQUIRED_CLAIM_CHECKER ); |
|
72 | + public static function getTargetRequiredClaimChecker(?MediaWikiServices $services = null) { |
|
73 | + return self::getService($services, self::TARGET_REQUIRED_CLAIM_CHECKER); |
|
74 | 74 | } |
75 | 75 | |
76 | 76 | /** |
77 | 77 | * @param MediaWikiServices|null $services |
78 | 78 | * @return ConstraintChecker |
79 | 79 | */ |
80 | - public static function getSymmetricChecker( ?MediaWikiServices $services = null ) { |
|
81 | - return self::getService( $services, self::SYMMETRIC_CHECKER ); |
|
80 | + public static function getSymmetricChecker(?MediaWikiServices $services = null) { |
|
81 | + return self::getService($services, self::SYMMETRIC_CHECKER); |
|
82 | 82 | } |
83 | 83 | |
84 | 84 | /** |
85 | 85 | * @param MediaWikiServices|null $services |
86 | 86 | * @return ConstraintChecker |
87 | 87 | */ |
88 | - public static function getInverseChecker( ?MediaWikiServices $services = null ) { |
|
89 | - return self::getService( $services, self::INVERSE_CHECKER ); |
|
88 | + public static function getInverseChecker(?MediaWikiServices $services = null) { |
|
89 | + return self::getService($services, self::INVERSE_CHECKER); |
|
90 | 90 | } |
91 | 91 | |
92 | 92 | /** |
93 | 93 | * @param MediaWikiServices|null $services |
94 | 94 | * @return ConstraintChecker |
95 | 95 | */ |
96 | - public static function getQualifierChecker( ?MediaWikiServices $services = null ) { |
|
97 | - return self::getService( $services, self::QUALIFIER_CHECKER ); |
|
96 | + public static function getQualifierChecker(?MediaWikiServices $services = null) { |
|
97 | + return self::getService($services, self::QUALIFIER_CHECKER); |
|
98 | 98 | } |
99 | 99 | |
100 | 100 | /** |
101 | 101 | * @param MediaWikiServices|null $services |
102 | 102 | * @return ConstraintChecker |
103 | 103 | */ |
104 | - public static function getQualifiersChecker( ?MediaWikiServices $services = null ) { |
|
105 | - return self::getService( $services, self::QUALIFIERS_CHECKER ); |
|
104 | + public static function getQualifiersChecker(?MediaWikiServices $services = null) { |
|
105 | + return self::getService($services, self::QUALIFIERS_CHECKER); |
|
106 | 106 | } |
107 | 107 | |
108 | 108 | /** |
109 | 109 | * @param MediaWikiServices|null $services |
110 | 110 | * @return ConstraintChecker |
111 | 111 | */ |
112 | - public static function getMandatoryQualifiersChecker( ?MediaWikiServices $services = null ) { |
|
113 | - return self::getService( $services, self::MANDATORY_QUALIFIERS_CHECKER ); |
|
112 | + public static function getMandatoryQualifiersChecker(?MediaWikiServices $services = null) { |
|
113 | + return self::getService($services, self::MANDATORY_QUALIFIERS_CHECKER); |
|
114 | 114 | } |
115 | 115 | |
116 | 116 | /** |
117 | 117 | * @param MediaWikiServices|null $services |
118 | 118 | * @return ConstraintChecker |
119 | 119 | */ |
120 | - public static function getRangeChecker( ?MediaWikiServices $services = null ) { |
|
121 | - return self::getService( $services, self::RANGE_CHECKER ); |
|
120 | + public static function getRangeChecker(?MediaWikiServices $services = null) { |
|
121 | + return self::getService($services, self::RANGE_CHECKER); |
|
122 | 122 | } |
123 | 123 | |
124 | 124 | /** |
125 | 125 | * @param MediaWikiServices|null $services |
126 | 126 | * @return ConstraintChecker |
127 | 127 | */ |
128 | - public static function getDiffWithinRangeChecker( ?MediaWikiServices $services = null ) { |
|
129 | - return self::getService( $services, self::DIFF_WITHIN_RANGE_CHECKER ); |
|
128 | + public static function getDiffWithinRangeChecker(?MediaWikiServices $services = null) { |
|
129 | + return self::getService($services, self::DIFF_WITHIN_RANGE_CHECKER); |
|
130 | 130 | } |
131 | 131 | |
132 | 132 | /** |
133 | 133 | * @param MediaWikiServices|null $services |
134 | 134 | * @return ConstraintChecker |
135 | 135 | */ |
136 | - public static function getTypeChecker( ?MediaWikiServices $services = null ) { |
|
137 | - return self::getService( $services, self::TYPE_CHECKER ); |
|
136 | + public static function getTypeChecker(?MediaWikiServices $services = null) { |
|
137 | + return self::getService($services, self::TYPE_CHECKER); |
|
138 | 138 | } |
139 | 139 | |
140 | 140 | /** |
141 | 141 | * @param MediaWikiServices|null $services |
142 | 142 | * @return ConstraintChecker |
143 | 143 | */ |
144 | - public static function getValueTypeChecker( ?MediaWikiServices $services = null ) { |
|
145 | - return self::getService( $services, self::VALUE_TYPE_CHECKER ); |
|
144 | + public static function getValueTypeChecker(?MediaWikiServices $services = null) { |
|
145 | + return self::getService($services, self::VALUE_TYPE_CHECKER); |
|
146 | 146 | } |
147 | 147 | |
148 | 148 | /** |
149 | 149 | * @param MediaWikiServices|null $services |
150 | 150 | * @return ConstraintChecker |
151 | 151 | */ |
152 | - public static function getSingleValueChecker( ?MediaWikiServices $services = null ) { |
|
153 | - return self::getService( $services, self::SINGLE_VALUE_CHECKER ); |
|
152 | + public static function getSingleValueChecker(?MediaWikiServices $services = null) { |
|
153 | + return self::getService($services, self::SINGLE_VALUE_CHECKER); |
|
154 | 154 | } |
155 | 155 | |
156 | 156 | /** |
157 | 157 | * @param MediaWikiServices|null $services |
158 | 158 | * @return ConstraintChecker |
159 | 159 | */ |
160 | - public static function getMultiValueChecker( ?MediaWikiServices $services = null ) { |
|
161 | - return self::getService( $services, self::MULTI_VALUE_CHECKER ); |
|
160 | + public static function getMultiValueChecker(?MediaWikiServices $services = null) { |
|
161 | + return self::getService($services, self::MULTI_VALUE_CHECKER); |
|
162 | 162 | } |
163 | 163 | |
164 | 164 | /** |
165 | 165 | * @param MediaWikiServices|null $services |
166 | 166 | * @return ConstraintChecker |
167 | 167 | */ |
168 | - public static function getUniqueValueChecker( ?MediaWikiServices $services = null ) { |
|
169 | - return self::getService( $services, self::UNIQUE_VALUE_CHECKER ); |
|
168 | + public static function getUniqueValueChecker(?MediaWikiServices $services = null) { |
|
169 | + return self::getService($services, self::UNIQUE_VALUE_CHECKER); |
|
170 | 170 | } |
171 | 171 | |
172 | 172 | /** |
173 | 173 | * @param MediaWikiServices|null $services |
174 | 174 | * @return ConstraintChecker |
175 | 175 | */ |
176 | - public static function getFormatChecker( ?MediaWikiServices $services = null ) { |
|
177 | - return self::getService( $services, self::FORMAT_CHECKER ); |
|
176 | + public static function getFormatChecker(?MediaWikiServices $services = null) { |
|
177 | + return self::getService($services, self::FORMAT_CHECKER); |
|
178 | 178 | } |
179 | 179 | |
180 | 180 | /** |
181 | 181 | * @param MediaWikiServices|null $services |
182 | 182 | * @return ConstraintChecker |
183 | 183 | */ |
184 | - public static function getCommonsLinkChecker( ?MediaWikiServices $services = null ) { |
|
185 | - return self::getService( $services, self::COMMONS_LINK_CHECKER ); |
|
184 | + public static function getCommonsLinkChecker(?MediaWikiServices $services = null) { |
|
185 | + return self::getService($services, self::COMMONS_LINK_CHECKER); |
|
186 | 186 | } |
187 | 187 | |
188 | 188 | /** |
189 | 189 | * @param MediaWikiServices|null $services |
190 | 190 | * @return ConstraintChecker |
191 | 191 | */ |
192 | - public static function getOneOfChecker( ?MediaWikiServices $services = null ) { |
|
193 | - return self::getService( $services, self::ONE_OF_CHECKER ); |
|
192 | + public static function getOneOfChecker(?MediaWikiServices $services = null) { |
|
193 | + return self::getService($services, self::ONE_OF_CHECKER); |
|
194 | 194 | } |
195 | 195 | |
196 | 196 | /** |
197 | 197 | * @param MediaWikiServices|null $services |
198 | 198 | * @return ConstraintChecker |
199 | 199 | */ |
200 | - public static function getValueOnlyChecker( ?MediaWikiServices $services = null ) { |
|
201 | - return self::getService( $services, self::VALUE_ONLY_CHECKER ); |
|
200 | + public static function getValueOnlyChecker(?MediaWikiServices $services = null) { |
|
201 | + return self::getService($services, self::VALUE_ONLY_CHECKER); |
|
202 | 202 | } |
203 | 203 | |
204 | 204 | /** |
205 | 205 | * @param MediaWikiServices|null $services |
206 | 206 | * @return ConstraintChecker |
207 | 207 | */ |
208 | - public static function getReferenceChecker( ?MediaWikiServices $services = null ) { |
|
209 | - return self::getService( $services, self::REFERENCE_CHECKER ); |
|
208 | + public static function getReferenceChecker(?MediaWikiServices $services = null) { |
|
209 | + return self::getService($services, self::REFERENCE_CHECKER); |
|
210 | 210 | } |
211 | 211 | |
212 | 212 | /** |
213 | 213 | * @param MediaWikiServices|null $services |
214 | 214 | * @return ConstraintChecker |
215 | 215 | */ |
216 | - public static function getNoBoundsChecker( ?MediaWikiServices $services = null ) { |
|
217 | - return self::getService( $services, self::NO_BOUNDS_CHECKER ); |
|
216 | + public static function getNoBoundsChecker(?MediaWikiServices $services = null) { |
|
217 | + return self::getService($services, self::NO_BOUNDS_CHECKER); |
|
218 | 218 | } |
219 | 219 | |
220 | 220 | /** |
221 | 221 | * @param MediaWikiServices|null $services |
222 | 222 | * @return ConstraintChecker |
223 | 223 | */ |
224 | - public static function getAllowedUnitsChecker( ?MediaWikiServices $services = null ) { |
|
225 | - return self::getService( $services, self::ALLOWED_UNITS_CHECKER ); |
|
224 | + public static function getAllowedUnitsChecker(?MediaWikiServices $services = null) { |
|
225 | + return self::getService($services, self::ALLOWED_UNITS_CHECKER); |
|
226 | 226 | } |
227 | 227 | |
228 | 228 | /** |
229 | 229 | * @param MediaWikiServices|null $services |
230 | 230 | * @return ConstraintChecker |
231 | 231 | */ |
232 | - public static function getSingleBestValueChecker( ?MediaWikiServices $services = null ) { |
|
233 | - return self::getService( $services, self::SINGLE_BEST_VALUE_CHECKER ); |
|
232 | + public static function getSingleBestValueChecker(?MediaWikiServices $services = null) { |
|
233 | + return self::getService($services, self::SINGLE_BEST_VALUE_CHECKER); |
|
234 | 234 | } |
235 | 235 | |
236 | 236 | /** |
237 | 237 | * @param MediaWikiServices|null $services |
238 | 238 | * @return ConstraintChecker |
239 | 239 | */ |
240 | - public static function getEntityTypeChecker( ?MediaWikiServices $services = null ) { |
|
241 | - return self::getService( $services, self::ENTITY_TYPE_CHECKER ); |
|
240 | + public static function getEntityTypeChecker(?MediaWikiServices $services = null) { |
|
241 | + return self::getService($services, self::ENTITY_TYPE_CHECKER); |
|
242 | 242 | } |
243 | 243 | |
244 | 244 | /** |
245 | 245 | * @param MediaWikiServices|null $services |
246 | 246 | * @return ConstraintChecker |
247 | 247 | */ |
248 | - public static function getNoneOfChecker( ?MediaWikiServices $services = null ) { |
|
249 | - return self::getService( $services, self::NONE_OF_CHECKER ); |
|
248 | + public static function getNoneOfChecker(?MediaWikiServices $services = null) { |
|
249 | + return self::getService($services, self::NONE_OF_CHECKER); |
|
250 | 250 | } |
251 | 251 | |
252 | 252 | /** |
253 | 253 | * @param MediaWikiServices|null $services |
254 | 254 | * @return ConstraintChecker |
255 | 255 | */ |
256 | - public static function getIntegerChecker( ?MediaWikiServices $services = null ) { |
|
257 | - return self::getService( $services, self::INTEGER_CHECKER ); |
|
256 | + public static function getIntegerChecker(?MediaWikiServices $services = null) { |
|
257 | + return self::getService($services, self::INTEGER_CHECKER); |
|
258 | 258 | } |
259 | 259 | |
260 | 260 | /** |
261 | 261 | * @param MediaWikiServices|null $services |
262 | 262 | * @return ConstraintChecker |
263 | 263 | */ |
264 | - public static function getCitationNeededChecker( ?MediaWikiServices $services = null ) { |
|
265 | - return self::getService( $services, self::CITATION_NEEDED_CHECKER ); |
|
264 | + public static function getCitationNeededChecker(?MediaWikiServices $services = null) { |
|
265 | + return self::getService($services, self::CITATION_NEEDED_CHECKER); |
|
266 | 266 | } |
267 | 267 | |
268 | 268 | /** |
269 | 269 | * @param MediaWikiServices|null $services |
270 | 270 | * @return ConstraintChecker |
271 | 271 | */ |
272 | - public static function getPropertyScopeChecker( ?MediaWikiServices $services = null ) { |
|
273 | - return self::getService( $services, self::PROPERTY_SCOPE_CHECKER ); |
|
272 | + public static function getPropertyScopeChecker(?MediaWikiServices $services = null) { |
|
273 | + return self::getService($services, self::PROPERTY_SCOPE_CHECKER); |
|
274 | 274 | } |
275 | 275 | |
276 | 276 | /** |
277 | 277 | * @param MediaWikiServices|null $services |
278 | 278 | * @return ConstraintChecker |
279 | 279 | */ |
280 | - public static function getContemporaryChecker( ?MediaWikiServices $services = null ) { |
|
281 | - return self::getService( $services, self::CONTEMPORARY_CHECKER ); |
|
280 | + public static function getContemporaryChecker(?MediaWikiServices $services = null) { |
|
281 | + return self::getService($services, self::CONTEMPORARY_CHECKER); |
|
282 | 282 | } |
283 | 283 | |
284 | 284 | /** |
285 | 285 | * @param MediaWikiServices|null $services |
286 | 286 | * @return LanguageChecker |
287 | 287 | */ |
288 | - public static function getLexemeLanguageChecker( ?MediaWikiServices $services = null ) { |
|
289 | - return self::getService( $services, self::LEXEME_LANGUAGE_CHECKER ); |
|
288 | + public static function getLexemeLanguageChecker(?MediaWikiServices $services = null) { |
|
289 | + return self::getService($services, self::LEXEME_LANGUAGE_CHECKER); |
|
290 | 290 | } |
291 | 291 | |
292 | 292 | /** |
293 | 293 | * @param MediaWikiServices|null $services |
294 | 294 | * @return LabelInLanguageChecker |
295 | 295 | */ |
296 | - public static function getLabelInLanguageChecker( ?MediaWikiServices $services = null ) { |
|
297 | - return self::getService( $services, self::LABEL_IN_LANGUAGE_CHECKER ); |
|
296 | + public static function getLabelInLanguageChecker(?MediaWikiServices $services = null) { |
|
297 | + return self::getService($services, self::LABEL_IN_LANGUAGE_CHECKER); |
|
298 | 298 | } |
299 | 299 | |
300 | 300 | } |
@@ -11,8 +11,8 @@ discard block |
||
11 | 11 | */ |
12 | 12 | class ContextCursorDeserializer { |
13 | 13 | |
14 | - public function deserialize( array $serialization ): ContextCursor { |
|
15 | - switch ( $serialization['t'] ) { |
|
14 | + public function deserialize(array $serialization): ContextCursor { |
|
15 | + switch ($serialization['t']) { |
|
16 | 16 | case Context::TYPE_STATEMENT: |
17 | 17 | return new MainSnakContextCursor( |
18 | 18 | $serialization['i'], |
@@ -43,7 +43,7 @@ discard block |
||
43 | 43 | ); |
44 | 44 | default: |
45 | 45 | throw new InvalidArgumentException( |
46 | - 'Unknown serialization type ' . $serialization['t'] |
|
46 | + 'Unknown serialization type '.$serialization['t'] |
|
47 | 47 | ); |
48 | 48 | } |
49 | 49 | } |
@@ -39,23 +39,23 @@ discard block |
||
39 | 39 | $this->dataValueFactory = $dataValueFactory; |
40 | 40 | } |
41 | 41 | |
42 | - public function unabbreviateViolationMessageKey( string $messageKeySuffix ): string { |
|
43 | - return ViolationMessage::MESSAGE_KEY_PREFIX . $messageKeySuffix; |
|
42 | + public function unabbreviateViolationMessageKey(string $messageKeySuffix): string { |
|
43 | + return ViolationMessage::MESSAGE_KEY_PREFIX.$messageKeySuffix; |
|
44 | 44 | } |
45 | 45 | |
46 | 46 | /** |
47 | 47 | * @param array $serialization |
48 | 48 | * @return ViolationMessage |
49 | 49 | */ |
50 | - public function deserialize( $serialization ) { |
|
51 | - Assert::parameterType( 'array', $serialization, '$serialization' ); |
|
50 | + public function deserialize($serialization) { |
|
51 | + Assert::parameterType('array', $serialization, '$serialization'); |
|
52 | 52 | |
53 | 53 | $message = new ViolationMessage( |
54 | - $this->unabbreviateViolationMessageKey( $serialization['k'] ) |
|
54 | + $this->unabbreviateViolationMessageKey($serialization['k']) |
|
55 | 55 | ); |
56 | 56 | |
57 | - foreach ( $serialization['a'] as $serializedArgument ) { |
|
58 | - $message = $this->deserializeArgument( $message, $serializedArgument ); |
|
57 | + foreach ($serialization['a'] as $serializedArgument) { |
|
58 | + $message = $this->deserializeArgument($message, $serializedArgument); |
|
59 | 59 | } |
60 | 60 | |
61 | 61 | return $message; |
@@ -66,7 +66,7 @@ discard block |
||
66 | 66 | * @param array $serializedArgument [ 't' => ViolationMessage::TYPE_*, 'v' => serialized value, 'r' => $role ] |
67 | 67 | * @return ViolationMessage $message with the deserialized argument appended |
68 | 68 | */ |
69 | - private function deserializeArgument( ViolationMessage $message, array $serializedArgument ) { |
|
69 | + private function deserializeArgument(ViolationMessage $message, array $serializedArgument) { |
|
70 | 70 | $methods = [ |
71 | 71 | ViolationMessage::TYPE_ENTITY_ID => 'deserializeEntityId', |
72 | 72 | ViolationMessage::TYPE_ENTITY_ID_LIST => 'deserializeEntityIdList', |
@@ -88,23 +88,23 @@ discard block |
||
88 | 88 | $serializedValue = $serializedArgument['v']; |
89 | 89 | $role = $serializedArgument['r']; |
90 | 90 | |
91 | - if ( array_key_exists( $type, $methods ) ) { |
|
91 | + if (array_key_exists($type, $methods)) { |
|
92 | 92 | $method = $methods[$type]; |
93 | - $value = $this->$method( $serializedValue ); |
|
93 | + $value = $this->$method($serializedValue); |
|
94 | 94 | } else { |
95 | 95 | throw new InvalidArgumentException( |
96 | - 'Unknown ViolationMessage argument type ' . $type . '!' |
|
96 | + 'Unknown ViolationMessage argument type '.$type.'!' |
|
97 | 97 | ); |
98 | 98 | } |
99 | 99 | |
100 | - return $message->withArgument( $type, $role, $value ); |
|
100 | + return $message->withArgument($type, $role, $value); |
|
101 | 101 | } |
102 | 102 | |
103 | 103 | /** |
104 | 104 | * @param string $string any value that shall simply be deserialized into itself |
105 | 105 | * @return string that same value, unchanged |
106 | 106 | */ |
107 | - private function deserializeStringByIdentity( $string ) { |
|
107 | + private function deserializeStringByIdentity($string) { |
|
108 | 108 | return $string; |
109 | 109 | } |
110 | 110 | |
@@ -112,32 +112,32 @@ discard block |
||
112 | 112 | * @param string $entityIdSerialization entity ID serialization |
113 | 113 | * @return EntityId |
114 | 114 | */ |
115 | - private function deserializeEntityId( $entityIdSerialization ) { |
|
116 | - return $this->entityIdParser->parse( $entityIdSerialization ); |
|
115 | + private function deserializeEntityId($entityIdSerialization) { |
|
116 | + return $this->entityIdParser->parse($entityIdSerialization); |
|
117 | 117 | } |
118 | 118 | |
119 | 119 | /** |
120 | 120 | * @param string[] $entityIdSerializations entity ID serializations |
121 | 121 | * @return EntityId[] |
122 | 122 | */ |
123 | - private function deserializeEntityIdList( array $entityIdSerializations ) { |
|
124 | - return array_map( [ $this, 'deserializeEntityId' ], $entityIdSerializations ); |
|
123 | + private function deserializeEntityIdList(array $entityIdSerializations) { |
|
124 | + return array_map([$this, 'deserializeEntityId'], $entityIdSerializations); |
|
125 | 125 | } |
126 | 126 | |
127 | 127 | /** |
128 | 128 | * @param string $valueSerialization entity ID serialization, '::somevalue' or '::novalue' |
129 | 129 | * @return ItemIdSnakValue |
130 | 130 | */ |
131 | - private function deserializeItemIdSnakValue( $valueSerialization ) { |
|
132 | - switch ( $valueSerialization ) { |
|
131 | + private function deserializeItemIdSnakValue($valueSerialization) { |
|
132 | + switch ($valueSerialization) { |
|
133 | 133 | case '::somevalue': |
134 | 134 | return ItemIdSnakValue::someValue(); |
135 | 135 | case '::novalue': |
136 | 136 | return ItemIdSnakValue::noValue(); |
137 | 137 | default: |
138 | - $itemId = $this->deserializeEntityId( $valueSerialization ); |
|
138 | + $itemId = $this->deserializeEntityId($valueSerialization); |
|
139 | 139 | '@phan-var \Wikibase\DataModel\Entity\ItemId $itemId'; |
140 | - return ItemIdSnakValue::fromItemId( $itemId ); |
|
140 | + return ItemIdSnakValue::fromItemId($itemId); |
|
141 | 141 | } |
142 | 142 | } |
143 | 143 | |
@@ -145,24 +145,24 @@ discard block |
||
145 | 145 | * @param string[] $valueSerializations entity ID serializations, '::somevalue's or '::novalue's |
146 | 146 | * @return ItemIdSnakValue[] |
147 | 147 | */ |
148 | - private function deserializeItemIdSnakValueList( $valueSerializations ) { |
|
149 | - return array_map( [ $this, 'deserializeItemIdSnakValue' ], $valueSerializations ); |
|
148 | + private function deserializeItemIdSnakValueList($valueSerializations) { |
|
149 | + return array_map([$this, 'deserializeItemIdSnakValue'], $valueSerializations); |
|
150 | 150 | } |
151 | 151 | |
152 | 152 | /** |
153 | 153 | * @param array $dataValueSerialization the data value in array form |
154 | 154 | * @return DataValue |
155 | 155 | */ |
156 | - private function deserializeDataValue( array $dataValueSerialization ) { |
|
157 | - return $this->dataValueFactory->newFromArray( $dataValueSerialization ); |
|
156 | + private function deserializeDataValue(array $dataValueSerialization) { |
|
157 | + return $this->dataValueFactory->newFromArray($dataValueSerialization); |
|
158 | 158 | } |
159 | 159 | |
160 | 160 | /** |
161 | 161 | * @param string $contextTypeAbbreviation |
162 | 162 | * @return string one of the Context::TYPE_* constants |
163 | 163 | */ |
164 | - private function deserializeContextType( $contextTypeAbbreviation ) { |
|
165 | - switch ( $contextTypeAbbreviation ) { |
|
164 | + private function deserializeContextType($contextTypeAbbreviation) { |
|
165 | + switch ($contextTypeAbbreviation) { |
|
166 | 166 | case 's': |
167 | 167 | return Context::TYPE_STATEMENT; |
168 | 168 | case 'q': |
@@ -172,7 +172,7 @@ discard block |
||
172 | 172 | default: |
173 | 173 | // @codeCoverageIgnoreStart |
174 | 174 | throw new LogicException( |
175 | - 'Unknown context type abbreviation ' . $contextTypeAbbreviation |
|
175 | + 'Unknown context type abbreviation '.$contextTypeAbbreviation |
|
176 | 176 | ); |
177 | 177 | // @codeCoverageIgnoreEnd |
178 | 178 | } |
@@ -182,16 +182,16 @@ discard block |
||
182 | 182 | * @param string[] $contextTypeAbbreviations |
183 | 183 | * @return string[] Context::TYPE_* constants |
184 | 184 | */ |
185 | - private function deserializeContextTypeList( array $contextTypeAbbreviations ) { |
|
186 | - return array_map( [ $this, 'deserializeContextType' ], $contextTypeAbbreviations ); |
|
185 | + private function deserializeContextTypeList(array $contextTypeAbbreviations) { |
|
186 | + return array_map([$this, 'deserializeContextType'], $contextTypeAbbreviations); |
|
187 | 187 | } |
188 | 188 | |
189 | 189 | /** |
190 | 190 | * @param mixed $textSerialization {@see MultilingualTextValue::getArrayValue} |
191 | 191 | * @return MultilingualTextValue |
192 | 192 | */ |
193 | - private function deserializeMultilingualText( $textSerialization ) { |
|
194 | - return MultilingualTextValue::newFromArray( $textSerialization ); |
|
193 | + private function deserializeMultilingualText($textSerialization) { |
|
194 | + return MultilingualTextValue::newFromArray($textSerialization); |
|
195 | 195 | } |
196 | 196 | |
197 | 197 | } |
@@ -53,7 +53,7 @@ discard block |
||
53 | 53 | $this->config = $config; |
54 | 54 | $this->timeParser = new IsoTimestampParser(); |
55 | 55 | $this->timeCalculator = new TimeValueCalculator(); |
56 | - $this->timeValueComparer = new TimeValueComparer( $this->timeCalculator ); |
|
56 | + $this->timeValueComparer = new TimeValueComparer($this->timeCalculator); |
|
57 | 57 | $this->unitConverter = $unitConverter; |
58 | 58 | } |
59 | 59 | |
@@ -61,10 +61,10 @@ discard block |
||
61 | 61 | * @param UnboundedQuantityValue $value |
62 | 62 | * @return UnboundedQuantityValue $value converted to standard units if possible, otherwise unchanged $value. |
63 | 63 | */ |
64 | - private function standardize( UnboundedQuantityValue $value ) { |
|
65 | - if ( $this->unitConverter !== null ) { |
|
66 | - $standard = $this->unitConverter->toStandardUnits( $value ); |
|
67 | - if ( $standard !== null ) { |
|
64 | + private function standardize(UnboundedQuantityValue $value) { |
|
65 | + if ($this->unitConverter !== null) { |
|
66 | + $standard = $this->unitConverter->toStandardUnits($value); |
|
67 | + if ($standard !== null) { |
|
68 | 68 | return $standard; |
69 | 69 | } else { |
70 | 70 | return $value; |
@@ -86,33 +86,33 @@ discard block |
||
86 | 86 | * when $lhs is respectively less than, equal to, or greater than $rhs. |
87 | 87 | * (In other words, just like the “spaceship” operator <=>.) |
88 | 88 | */ |
89 | - public function getComparison( ?DataValue $lhs, ?DataValue $rhs ) { |
|
90 | - if ( $lhs === null || $rhs === null ) { |
|
89 | + public function getComparison(?DataValue $lhs, ?DataValue $rhs) { |
|
90 | + if ($lhs === null || $rhs === null) { |
|
91 | 91 | return 0; |
92 | 92 | } |
93 | 93 | |
94 | - if ( $lhs->getType() !== $rhs->getType() ) { |
|
95 | - throw new InvalidArgumentException( 'Different data value types' ); |
|
94 | + if ($lhs->getType() !== $rhs->getType()) { |
|
95 | + throw new InvalidArgumentException('Different data value types'); |
|
96 | 96 | } |
97 | 97 | |
98 | - switch ( $lhs->getType() ) { |
|
98 | + switch ($lhs->getType()) { |
|
99 | 99 | case 'time': |
100 | 100 | /** @var TimeValue $lhs */ |
101 | 101 | /** @var TimeValue $rhs */ |
102 | 102 | '@phan-var TimeValue $lhs'; |
103 | 103 | '@phan-var TimeValue $rhs'; |
104 | - return $this->timeValueComparer->getComparison( $lhs, $rhs ); |
|
104 | + return $this->timeValueComparer->getComparison($lhs, $rhs); |
|
105 | 105 | case 'quantity': |
106 | 106 | /** @var QuantityValue|UnboundedQuantityValue $lhs */ |
107 | 107 | /** @var QuantityValue|UnboundedQuantityValue $rhs */ |
108 | 108 | '@phan-var QuantityValue|UnboundedQuantityValue $lhs'; |
109 | 109 | '@phan-var QuantityValue|UnboundedQuantityValue $rhs'; |
110 | - $lhsStandard = $this->standardize( $lhs ); |
|
111 | - $rhsStandard = $this->standardize( $rhs ); |
|
112 | - return $lhsStandard->getAmount()->compare( $rhsStandard->getAmount() ); |
|
110 | + $lhsStandard = $this->standardize($lhs); |
|
111 | + $rhsStandard = $this->standardize($rhs); |
|
112 | + return $lhsStandard->getAmount()->compare($rhsStandard->getAmount()); |
|
113 | 113 | } |
114 | 114 | |
115 | - throw new InvalidArgumentException( 'Unsupported data value type' ); |
|
115 | + throw new InvalidArgumentException('Unsupported data value type'); |
|
116 | 116 | } |
117 | 117 | |
118 | 118 | /** |
@@ -127,71 +127,71 @@ discard block |
||
127 | 127 | * @throws InvalidArgumentException if the values do not both have the same, supported data value type |
128 | 128 | * @return UnboundedQuantityValue |
129 | 129 | */ |
130 | - public function getDifference( DataValue $minuend, DataValue $subtrahend ) { |
|
131 | - if ( $minuend->getType() === 'time' && $subtrahend->getType() === 'time' ) { |
|
132 | - $minuendSeconds = $this->timeCalculator->getTimestamp( $minuend ); |
|
133 | - $subtrahendSeconds = $this->timeCalculator->getTimestamp( $subtrahend ); |
|
130 | + public function getDifference(DataValue $minuend, DataValue $subtrahend) { |
|
131 | + if ($minuend->getType() === 'time' && $subtrahend->getType() === 'time') { |
|
132 | + $minuendSeconds = $this->timeCalculator->getTimestamp($minuend); |
|
133 | + $subtrahendSeconds = $this->timeCalculator->getTimestamp($subtrahend); |
|
134 | 134 | return UnboundedQuantityValue::newFromNumber( |
135 | 135 | $minuendSeconds - $subtrahendSeconds, |
136 | - $this->config->get( 'WBQualityConstraintsSecondUnit' ) |
|
136 | + $this->config->get('WBQualityConstraintsSecondUnit') |
|
137 | 137 | ); |
138 | 138 | } |
139 | - if ( $minuend->getType() === 'quantity' && $subtrahend->getType() === 'quantity' ) { |
|
140 | - $minuendStandard = $this->standardize( $minuend ); |
|
141 | - $subtrahendStandard = $this->standardize( $subtrahend ); |
|
139 | + if ($minuend->getType() === 'quantity' && $subtrahend->getType() === 'quantity') { |
|
140 | + $minuendStandard = $this->standardize($minuend); |
|
141 | + $subtrahendStandard = $this->standardize($subtrahend); |
|
142 | 142 | $minuendValue = $minuendStandard->getAmount()->getValueFloat(); |
143 | 143 | $subtrahendValue = $subtrahendStandard->getAmount()->getValueFloat(); |
144 | 144 | $diff = $minuendValue - $subtrahendValue; |
145 | 145 | // we don’t check whether both quantities have the same standard unit – |
146 | 146 | // that’s the job of a different constraint type, Units (T164372) |
147 | - return UnboundedQuantityValue::newFromNumber( $diff, $minuendStandard->getUnit() ); |
|
147 | + return UnboundedQuantityValue::newFromNumber($diff, $minuendStandard->getUnit()); |
|
148 | 148 | } |
149 | 149 | |
150 | - throw new InvalidArgumentException( 'Unsupported or different data value types' ); |
|
150 | + throw new InvalidArgumentException('Unsupported or different data value types'); |
|
151 | 151 | } |
152 | 152 | |
153 | - public function getDifferenceInYears( TimeValue $minuend, TimeValue $subtrahend ): DataValue { |
|
154 | - if ( !preg_match( '/^([-+]\d{1,16})-(.*)$/', $minuend->getTime(), $minuendMatches ) || |
|
155 | - !preg_match( '/^([-+]\d{1,16})-(.*)$/', $subtrahend->getTime(), $subtrahendMatches ) |
|
153 | + public function getDifferenceInYears(TimeValue $minuend, TimeValue $subtrahend): DataValue { |
|
154 | + if (!preg_match('/^([-+]\d{1,16})-(.*)$/', $minuend->getTime(), $minuendMatches) || |
|
155 | + !preg_match('/^([-+]\d{1,16})-(.*)$/', $subtrahend->getTime(), $subtrahendMatches) |
|
156 | 156 | ) { |
157 | - throw new InvalidArgumentException( 'TimeValue::getTime() did not match expected format' ); |
|
157 | + throw new InvalidArgumentException('TimeValue::getTime() did not match expected format'); |
|
158 | 158 | } |
159 | - $minuendYear = (float)$minuendMatches[1]; |
|
160 | - $subtrahendYear = (float)$subtrahendMatches[1]; |
|
159 | + $minuendYear = (float) $minuendMatches[1]; |
|
160 | + $subtrahendYear = (float) $subtrahendMatches[1]; |
|
161 | 161 | $minuendRest = $minuendMatches[2]; |
162 | 162 | $subtrahendRest = $subtrahendMatches[2]; |
163 | 163 | |
164 | 164 | // calculate difference of years |
165 | 165 | $diff = $minuendYear - $subtrahendYear; |
166 | - if ( $minuendYear > 0.0 && $subtrahendYear < 0.0 ) { |
|
166 | + if ($minuendYear > 0.0 && $subtrahendYear < 0.0) { |
|
167 | 167 | $diff -= 1.0; // there is no year 0, remove it from difference |
168 | - } elseif ( $minuendYear < 0.0 && $subtrahendYear > 0.0 ) { |
|
168 | + } elseif ($minuendYear < 0.0 && $subtrahendYear > 0.0) { |
|
169 | 169 | $diff -= -1.0; // there is no year 0, remove it from negative difference |
170 | 170 | } |
171 | 171 | |
172 | 172 | // adjust for date within year by parsing the month-day part within the same year |
173 | - $minuendDateValue = $this->timeParser->parse( '+0000000000001970-' . $minuendRest ); |
|
174 | - $subtrahendDateValue = $this->timeParser->parse( '+0000000000001970-' . $subtrahendRest ); |
|
175 | - $minuendDateSeconds = $this->timeCalculator->getTimestamp( $minuendDateValue ); |
|
176 | - $subtrahendDateSeconds = $this->timeCalculator->getTimestamp( $subtrahendDateValue ); |
|
177 | - if ( $minuendDateSeconds < $subtrahendDateSeconds ) { |
|
173 | + $minuendDateValue = $this->timeParser->parse('+0000000000001970-'.$minuendRest); |
|
174 | + $subtrahendDateValue = $this->timeParser->parse('+0000000000001970-'.$subtrahendRest); |
|
175 | + $minuendDateSeconds = $this->timeCalculator->getTimestamp($minuendDateValue); |
|
176 | + $subtrahendDateSeconds = $this->timeCalculator->getTimestamp($subtrahendDateValue); |
|
177 | + if ($minuendDateSeconds < $subtrahendDateSeconds) { |
|
178 | 178 | // difference in the last year is actually less than one full year |
179 | 179 | // e. g. 1975-03-01 - 1974-09-01 is just six months |
180 | 180 | // (we don’t need sub-year precision in the difference, adjusting by 0.5 is enough) |
181 | 181 | $diff -= 0.5; |
182 | - } elseif ( $minuendDateSeconds > $subtrahendDateSeconds ) { |
|
182 | + } elseif ($minuendDateSeconds > $subtrahendDateSeconds) { |
|
183 | 183 | // difference in the last year is actually more than one full year |
184 | 184 | // e. g. 1975-09-01 - 1974-03-01 is 18 months |
185 | 185 | // (we don’t need sub-year precision in the difference, adjusting by 0.5 is enough) |
186 | 186 | $diff += 0.5; |
187 | 187 | } |
188 | 188 | |
189 | - $unit = $this->config->get( 'WBQualityConstraintsYearUnit' ); |
|
190 | - return UnboundedQuantityValue::newFromNumber( $diff, $unit ); |
|
189 | + $unit = $this->config->get('WBQualityConstraintsYearUnit'); |
|
190 | + return UnboundedQuantityValue::newFromNumber($diff, $unit); |
|
191 | 191 | } |
192 | 192 | |
193 | - public function isFutureTime( TimeValue $timeValue ): bool { |
|
194 | - return $this->timeValueComparer->isFutureTime( $timeValue ); |
|
193 | + public function isFutureTime(TimeValue $timeValue): bool { |
|
194 | + return $this->timeValueComparer->isFutureTime($timeValue); |
|
195 | 195 | } |
196 | 196 | |
197 | 197 | } |
@@ -9,8 +9,8 @@ |
||
9 | 9 | */ |
10 | 10 | class SparqlHelperException extends RuntimeException { |
11 | 11 | |
12 | - public function __construct( string $msg = 'The SPARQL query endpoint returned an error.' ) { |
|
13 | - parent::__construct( $msg ); |
|
12 | + public function __construct(string $msg = 'The SPARQL query endpoint returned an error.') { |
|
13 | + parent::__construct($msg); |
|
14 | 14 | } |
15 | 15 | |
16 | 16 | } |