Inspection of "Merge "Clean up Wikibase-related services"" - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dc26af...270588 )

unknown

created 2024-09-23 09:21 UTC

Status

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport;
 
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
 	public const ENTITY_LOOKUP = 'WBQC_EntityLookup';
 	public const ENTITY_LOOKUP_WITHOUT_CACHE = 'WBQC_EntityLookupWithoutCache';
 
-	private static function getService( ?MediaWikiServices $services, $name ) {
+	private static function getService(?MediaWikiServices $services, $name) {
 		$services ??= MediaWikiServices::getInstance();
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
 	/**
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
 	 * this lookup ignores exceptions (such as unresolved redirects, T93273),
 	 * as it is more convenient to treat them all as missing entities in WBQC.
 	 */
-	public static function getEntityLookup( MediaWikiServices $services = null ): EntityLookup {
-		return self::getService( $services, self::ENTITY_LOOKUP );
+	public static function getEntityLookup(MediaWikiServices $services = null): EntityLookup {
+		return self::getService($services, self::ENTITY_LOOKUP);
 	}
 
 	/**
@@ -48,8 +48,8 @@  discard block
 block discarded – undo
 	 * were exceeding the request memory limit when they were all added to the cache (T227450).
 	 * Also, like {@link self::getEntityLookup()}, this lookup ignores exceptions.
 	 */
-	public static function getEntityLookupWithoutCache( MediaWikiServices $services = null ): EntityLookup {
-		return self::getService( $services, self::ENTITY_LOOKUP_WITHOUT_CACHE );
+	public static function getEntityLookupWithoutCache(MediaWikiServices $services = null): EntityLookup {
+		return self::getService($services, self::ENTITY_LOOKUP_WITHOUT_CACHE);
 	}
 
 }

Please login to merge, or discard this patch.

src/ServiceWiring-Wikibase.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport;
 
@@ -11,16 +11,16 @@  discard block
 block discarded – undo
 use Wikibase\Repo\WikibaseRepo;
 
 return [
-	WikibaseServices::ENTITY_LOOKUP => static function ( MediaWikiServices $services ): EntityLookup {
+	WikibaseServices::ENTITY_LOOKUP => static function(MediaWikiServices $services): EntityLookup {
 		return new ExceptionIgnoringEntityLookup(
-			WikibaseRepo::getEntityLookup( $services )
+			WikibaseRepo::getEntityLookup($services)
 		);
 	},
 
-	WikibaseServices::ENTITY_LOOKUP_WITHOUT_CACHE => static function ( MediaWikiServices $services ): EntityLookup {
+	WikibaseServices::ENTITY_LOOKUP_WITHOUT_CACHE => static function(MediaWikiServices $services): EntityLookup {
 		return new ExceptionIgnoringEntityLookup(
-			WikibaseRepo::getStore( $services )
-				->getEntityLookup( Store::LOOKUP_CACHING_RETRIEVE_ONLY )
+			WikibaseRepo::getStore($services)
+				->getEntityLookup(Store::LOOKUP_CACHING_RETRIEVE_ONLY)
 		);
 	},
 ];

Please login to merge, or discard this patch.

src/ServiceWiring-ConstraintCheckers.php 1 patch

Spacing +75 added lines, -75 removed lines patch added patch discarded remove patch

@@ -38,216 +38,216 @@
 block discarded – undo
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\ValueTypeChecker;
 
 return [
-	ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => static function ( MediaWikiServices $services ): ConflictsWithChecker {
+	ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => static function(MediaWikiServices $services): ConflictsWithChecker {
 		return new ConflictsWithChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::ITEM_CHECKER => static function ( MediaWikiServices $services ): ItemChecker {
+	ConstraintCheckerServices::ITEM_CHECKER => static function(MediaWikiServices $services): ItemChecker {
 		return new ItemChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => static function (
+	ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => static function(
 		MediaWikiServices $services
 	): TargetRequiredClaimChecker {
 		return new TargetRequiredClaimChecker(
-			WikibaseServices::getEntityLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			WikibaseServices::getEntityLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::SYMMETRIC_CHECKER => static function ( MediaWikiServices $services ): SymmetricChecker {
+	ConstraintCheckerServices::SYMMETRIC_CHECKER => static function(MediaWikiServices $services): SymmetricChecker {
 		return new SymmetricChecker(
-			WikibaseServices::getEntityLookupWithoutCache( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			WikibaseServices::getEntityLookupWithoutCache($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::INVERSE_CHECKER => static function ( MediaWikiServices $services ): InverseChecker {
+	ConstraintCheckerServices::INVERSE_CHECKER => static function(MediaWikiServices $services): InverseChecker {
 		return new InverseChecker(
-			WikibaseServices::getEntityLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			WikibaseServices::getEntityLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::QUALIFIER_CHECKER => static function ( MediaWikiServices $services ): QualifierChecker {
+	ConstraintCheckerServices::QUALIFIER_CHECKER => static function(MediaWikiServices $services): QualifierChecker {
 		return new QualifierChecker();
 	},
 
-	ConstraintCheckerServices::QUALIFIERS_CHECKER => static function ( MediaWikiServices $services ): QualifiersChecker {
+	ConstraintCheckerServices::QUALIFIERS_CHECKER => static function(MediaWikiServices $services): QualifiersChecker {
 		return new QualifiersChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => static function (
+	ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => static function(
 		MediaWikiServices $services
 	): MandatoryQualifiersChecker {
 		return new MandatoryQualifiersChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::RANGE_CHECKER => static function ( MediaWikiServices $services ): RangeChecker {
+	ConstraintCheckerServices::RANGE_CHECKER => static function(MediaWikiServices $services): RangeChecker {
 		return new RangeChecker(
-			WikibaseRepo::getPropertyDataTypeLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getRangeCheckerHelper( $services )
+			WikibaseRepo::getPropertyDataTypeLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getRangeCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => static function (
+	ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => static function(
 		MediaWikiServices $services
 	): DiffWithinRangeChecker {
 		return new DiffWithinRangeChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getRangeCheckerHelper( $services ),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getRangeCheckerHelper($services),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintCheckerServices::TYPE_CHECKER => static function ( MediaWikiServices $services ): TypeChecker {
+	ConstraintCheckerServices::TYPE_CHECKER => static function(MediaWikiServices $services): TypeChecker {
 		return new TypeChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getTypeCheckerHelper( $services ),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getTypeCheckerHelper($services),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintCheckerServices::VALUE_TYPE_CHECKER => static function ( MediaWikiServices $services ): ValueTypeChecker {
+	ConstraintCheckerServices::VALUE_TYPE_CHECKER => static function(MediaWikiServices $services): ValueTypeChecker {
 		return new ValueTypeChecker(
-			WikibaseServices::getEntityLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getTypeCheckerHelper( $services ),
+			WikibaseServices::getEntityLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getTypeCheckerHelper($services),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintCheckerServices::SINGLE_VALUE_CHECKER => static function ( MediaWikiServices $services ): SingleValueChecker {
+	ConstraintCheckerServices::SINGLE_VALUE_CHECKER => static function(MediaWikiServices $services): SingleValueChecker {
 		return new SingleValueChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::MULTI_VALUE_CHECKER => static function ( MediaWikiServices $services ): MultiValueChecker {
+	ConstraintCheckerServices::MULTI_VALUE_CHECKER => static function(MediaWikiServices $services): MultiValueChecker {
 		return new MultiValueChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => static function ( MediaWikiServices $services ): UniqueValueChecker {
+	ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => static function(MediaWikiServices $services): UniqueValueChecker {
 		// TODO return a different, dummy implementation if SPARQL is not available
 		return new UniqueValueChecker(
-			ConstraintsServices::getSparqlHelper( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getSparqlHelper($services),
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::FORMAT_CHECKER => static function ( MediaWikiServices $services ): FormatChecker {
+	ConstraintCheckerServices::FORMAT_CHECKER => static function(MediaWikiServices $services): FormatChecker {
 		// TODO return a different, dummy implementation if SPARQL is not available
 		return new FormatChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
+			ConstraintsServices::getConstraintParameterParser($services),
 			$services->getMainConfig(),
-			ConstraintsServices::getSparqlHelper( $services ),
+			ConstraintsServices::getSparqlHelper($services),
 			$services->getShellboxClientFactory()
 		);
 	},
 
-	ConstraintCheckerServices::COMMONS_LINK_CHECKER => static function ( MediaWikiServices $services ): CommonsLinkChecker {
+	ConstraintCheckerServices::COMMONS_LINK_CHECKER => static function(MediaWikiServices $services): CommonsLinkChecker {
 		$pageNameNormalizer = new MediaWikiPageNameNormalizer();
 		return new CommonsLinkChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
+			ConstraintsServices::getConstraintParameterParser($services),
 			$pageNameNormalizer,
-			WikibaseRepo::getPropertyDataTypeLookup( $services )
+			WikibaseRepo::getPropertyDataTypeLookup($services)
 		);
 	},
 
-	ConstraintCheckerServices::ONE_OF_CHECKER => static function ( MediaWikiServices $services ): OneOfChecker {
+	ConstraintCheckerServices::ONE_OF_CHECKER => static function(MediaWikiServices $services): OneOfChecker {
 		return new OneOfChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::VALUE_ONLY_CHECKER => static function ( MediaWikiServices $services ): ValueOnlyChecker {
+	ConstraintCheckerServices::VALUE_ONLY_CHECKER => static function(MediaWikiServices $services): ValueOnlyChecker {
 		return new ValueOnlyChecker();
 	},
 
-	ConstraintCheckerServices::REFERENCE_CHECKER => static function ( MediaWikiServices $services ): ReferenceChecker {
+	ConstraintCheckerServices::REFERENCE_CHECKER => static function(MediaWikiServices $services): ReferenceChecker {
 		return new ReferenceChecker();
 	},
 
-	ConstraintCheckerServices::NO_BOUNDS_CHECKER => static function ( MediaWikiServices $services ): NoBoundsChecker {
+	ConstraintCheckerServices::NO_BOUNDS_CHECKER => static function(MediaWikiServices $services): NoBoundsChecker {
 		return new NoBoundsChecker();
 	},
 
-	ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => static function ( MediaWikiServices $services ): AllowedUnitsChecker {
+	ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => static function(MediaWikiServices $services): AllowedUnitsChecker {
 		return new AllowedUnitsChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			WikibaseRepo::getUnitConverter( $services )
+			ConstraintsServices::getConstraintParameterParser($services),
+			WikibaseRepo::getUnitConverter($services)
 		);
 	},
 
-	ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => static function (
+	ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => static function(
 		MediaWikiServices $services
 	): SingleBestValueChecker {
 		return new SingleBestValueChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::ENTITY_TYPE_CHECKER => static function ( MediaWikiServices $services ): EntityTypeChecker {
+	ConstraintCheckerServices::ENTITY_TYPE_CHECKER => static function(MediaWikiServices $services): EntityTypeChecker {
 		return new EntityTypeChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::NONE_OF_CHECKER => static function ( MediaWikiServices $services ): NoneOfChecker {
+	ConstraintCheckerServices::NONE_OF_CHECKER => static function(MediaWikiServices $services): NoneOfChecker {
 		return new NoneOfChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::INTEGER_CHECKER => static function ( MediaWikiServices $services ): IntegerChecker {
+	ConstraintCheckerServices::INTEGER_CHECKER => static function(MediaWikiServices $services): IntegerChecker {
 		return new IntegerChecker();
 	},
 
-	ConstraintCheckerServices::CITATION_NEEDED_CHECKER => static function ( MediaWikiServices $services ): CitationNeededChecker {
+	ConstraintCheckerServices::CITATION_NEEDED_CHECKER => static function(MediaWikiServices $services): CitationNeededChecker {
 		return new CitationNeededChecker();
 	},
 
-	ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => static function ( MediaWikiServices $services ): PropertyScopeChecker {
+	ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => static function(MediaWikiServices $services): PropertyScopeChecker {
 		return new PropertyScopeChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::CONTEMPORARY_CHECKER => static function ( MediaWikiServices $services ): ContemporaryChecker {
+	ConstraintCheckerServices::CONTEMPORARY_CHECKER => static function(MediaWikiServices $services): ContemporaryChecker {
 		return new ContemporaryChecker(
-			WikibaseServices::getEntityLookup( $services ),
-			ConstraintsServices::getRangeCheckerHelper( $services ),
+			WikibaseServices::getEntityLookup($services),
+			ConstraintsServices::getRangeCheckerHelper($services),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintCheckerServices::LEXEME_LANGUAGE_CHECKER => static function ( MediaWikiServices $services ): LanguageChecker {
+	ConstraintCheckerServices::LEXEME_LANGUAGE_CHECKER => static function(MediaWikiServices $services): LanguageChecker {
 		return new LanguageChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			WikibaseServices::getEntityLookup( $services )
+			ConstraintsServices::getConstraintParameterParser($services),
+			WikibaseServices::getEntityLookup($services)
 		);
 	},
 
-	ConstraintCheckerServices::LABEL_IN_LANGUAGE_CHECKER => static function (
+	ConstraintCheckerServices::LABEL_IN_LANGUAGE_CHECKER => static function(
 		MediaWikiServices $services
 	): LabelInLanguageChecker {
 		return new LabelInLanguageChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 ];

Please login to merge, or discard this patch.

		@@ -1,6 +1,6 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-declare( strict_types = 1 );
	3	+declare(strict_types=1);
4	4
5	5	namespace WikibaseQuality\ConstraintReport;
6	6
		@@ -25,9 +25,9 @@ discard block
		block discarded – undo
25	25	public const ENTITY_LOOKUP = 'WBQC_EntityLookup';
26	26	public const ENTITY_LOOKUP_WITHOUT_CACHE = 'WBQC_EntityLookupWithoutCache';
27	27
28		- private static function getService( ?MediaWikiServices $services, $name ) {
	28	+ private static function getService(?MediaWikiServices $services, $name) {
29	29	$services ??= MediaWikiServices::getInstance();
30		- return $services->getService( $name );
	30	+ return $services->getService($name);
31	31	}
32	32
33	33	/**
		@@ -37,8 +37,8 @@ discard block
		block discarded – undo
37	37	* this lookup ignores exceptions (such as unresolved redirects, T93273),
38	38	* as it is more convenient to treat them all as missing entities in WBQC.
39	39	*/
40		- public static function getEntityLookup( MediaWikiServices $services = null ): EntityLookup {
41		- return self::getService( $services, self::ENTITY_LOOKUP );
	40	+ public static function getEntityLookup(MediaWikiServices $services = null): EntityLookup {
	41	+ return self::getService($services, self::ENTITY_LOOKUP);
42	42	}
43	43
44	44	/**
		@@ -48,8 +48,8 @@ discard block
		block discarded – undo
48	48	* were exceeding the request memory limit when they were all added to the cache (T227450).
49	49	* Also, like {@link self::getEntityLookup()}, this lookup ignores exceptions.
50	50	*/
51		- public static function getEntityLookupWithoutCache( MediaWikiServices $services = null ): EntityLookup {
52		- return self::getService( $services, self::ENTITY_LOOKUP_WITHOUT_CACHE );
	51	+ public static function getEntityLookupWithoutCache(MediaWikiServices $services = null): EntityLookup {
	52	+ return self::getService($services, self::ENTITY_LOOKUP_WITHOUT_CACHE);
53	53	}
54	54
55	55	}

		@@ -38,216 +38,216 @@
		block discarded – undo
38	38	use WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\ValueTypeChecker;
39	39
40	40	return [
41		- ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => static function ( MediaWikiServices $services ): ConflictsWithChecker {
	41	+ ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => static function(MediaWikiServices $services): ConflictsWithChecker {
42	42	return new ConflictsWithChecker(
43		- ConstraintsServices::getConstraintParameterParser( $services ),
44		- ConstraintsServices::getConnectionCheckerHelper( $services )
	43	+ ConstraintsServices::getConstraintParameterParser($services),
	44	+ ConstraintsServices::getConnectionCheckerHelper($services)
45	45	);
46	46	},
47	47
48		- ConstraintCheckerServices::ITEM_CHECKER => static function ( MediaWikiServices $services ): ItemChecker {
	48	+ ConstraintCheckerServices::ITEM_CHECKER => static function(MediaWikiServices $services): ItemChecker {
49	49	return new ItemChecker(
50		- ConstraintsServices::getConstraintParameterParser( $services ),
51		- ConstraintsServices::getConnectionCheckerHelper( $services )
	50	+ ConstraintsServices::getConstraintParameterParser($services),
	51	+ ConstraintsServices::getConnectionCheckerHelper($services)
52	52	);
53	53	},
54	54
55		- ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => static function (
	55	+ ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => static function(
56	56	MediaWikiServices $services
57	57	): TargetRequiredClaimChecker {
58	58	return new TargetRequiredClaimChecker(
59		- WikibaseServices::getEntityLookup( $services ),
60		- ConstraintsServices::getConstraintParameterParser( $services ),
61		- ConstraintsServices::getConnectionCheckerHelper( $services )
	59	+ WikibaseServices::getEntityLookup($services),
	60	+ ConstraintsServices::getConstraintParameterParser($services),
	61	+ ConstraintsServices::getConnectionCheckerHelper($services)
62	62	);
63	63	},
64	64
65		- ConstraintCheckerServices::SYMMETRIC_CHECKER => static function ( MediaWikiServices $services ): SymmetricChecker {
	65	+ ConstraintCheckerServices::SYMMETRIC_CHECKER => static function(MediaWikiServices $services): SymmetricChecker {
66	66	return new SymmetricChecker(
67		- WikibaseServices::getEntityLookupWithoutCache( $services ),
68		- ConstraintsServices::getConnectionCheckerHelper( $services )
	67	+ WikibaseServices::getEntityLookupWithoutCache($services),
	68	+ ConstraintsServices::getConnectionCheckerHelper($services)
69	69	);
70	70	},
71	71
72		- ConstraintCheckerServices::INVERSE_CHECKER => static function ( MediaWikiServices $services ): InverseChecker {
	72	+ ConstraintCheckerServices::INVERSE_CHECKER => static function(MediaWikiServices $services): InverseChecker {
73	73	return new InverseChecker(
74		- WikibaseServices::getEntityLookup( $services ),
75		- ConstraintsServices::getConstraintParameterParser( $services ),
76		- ConstraintsServices::getConnectionCheckerHelper( $services )
	74	+ WikibaseServices::getEntityLookup($services),
	75	+ ConstraintsServices::getConstraintParameterParser($services),
	76	+ ConstraintsServices::getConnectionCheckerHelper($services)
77	77	);
78	78	},
79	79
80		- ConstraintCheckerServices::QUALIFIER_CHECKER => static function ( MediaWikiServices $services ): QualifierChecker {
	80	+ ConstraintCheckerServices::QUALIFIER_CHECKER => static function(MediaWikiServices $services): QualifierChecker {
81	81	return new QualifierChecker();
82	82	},
83	83
84		- ConstraintCheckerServices::QUALIFIERS_CHECKER => static function ( MediaWikiServices $services ): QualifiersChecker {
	84	+ ConstraintCheckerServices::QUALIFIERS_CHECKER => static function(MediaWikiServices $services): QualifiersChecker {
85	85	return new QualifiersChecker(
86		- ConstraintsServices::getConstraintParameterParser( $services )
	86	+ ConstraintsServices::getConstraintParameterParser($services)
87	87	);
88	88	},
89	89
90		- ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => static function (
	90	+ ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => static function(
91	91	MediaWikiServices $services
92	92	): MandatoryQualifiersChecker {
93	93	return new MandatoryQualifiersChecker(
94		- ConstraintsServices::getConstraintParameterParser( $services )
	94	+ ConstraintsServices::getConstraintParameterParser($services)
95	95	);
96	96	},
97	97
98		- ConstraintCheckerServices::RANGE_CHECKER => static function ( MediaWikiServices $services ): RangeChecker {
	98	+ ConstraintCheckerServices::RANGE_CHECKER => static function(MediaWikiServices $services): RangeChecker {
99	99	return new RangeChecker(
100		- WikibaseRepo::getPropertyDataTypeLookup( $services ),
101		- ConstraintsServices::getConstraintParameterParser( $services ),
102		- ConstraintsServices::getRangeCheckerHelper( $services )
	100	+ WikibaseRepo::getPropertyDataTypeLookup($services),
	101	+ ConstraintsServices::getConstraintParameterParser($services),
	102	+ ConstraintsServices::getRangeCheckerHelper($services)
103	103	);
104	104	},
105	105
106		- ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => static function (
	106	+ ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => static function(
107	107	MediaWikiServices $services
108	108	): DiffWithinRangeChecker {
109	109	return new DiffWithinRangeChecker(
110		- ConstraintsServices::getConstraintParameterParser( $services ),
111		- ConstraintsServices::getRangeCheckerHelper( $services ),
	110	+ ConstraintsServices::getConstraintParameterParser($services),
	111	+ ConstraintsServices::getRangeCheckerHelper($services),
112	112	$services->getMainConfig()
113	113	);
114	114	},
115	115
116		- ConstraintCheckerServices::TYPE_CHECKER => static function ( MediaWikiServices $services ): TypeChecker {
	116	+ ConstraintCheckerServices::TYPE_CHECKER => static function(MediaWikiServices $services): TypeChecker {
117	117	return new TypeChecker(
118		- ConstraintsServices::getConstraintParameterParser( $services ),
119		- ConstraintsServices::getTypeCheckerHelper( $services ),
	118	+ ConstraintsServices::getConstraintParameterParser($services),
	119	+ ConstraintsServices::getTypeCheckerHelper($services),
120	120	$services->getMainConfig()
121	121	);
122	122	},
123	123
124		- ConstraintCheckerServices::VALUE_TYPE_CHECKER => static function ( MediaWikiServices $services ): ValueTypeChecker {
	124	+ ConstraintCheckerServices::VALUE_TYPE_CHECKER => static function(MediaWikiServices $services): ValueTypeChecker {
125	125	return new ValueTypeChecker(
126		- WikibaseServices::getEntityLookup( $services ),
127		- ConstraintsServices::getConstraintParameterParser( $services ),
128		- ConstraintsServices::getTypeCheckerHelper( $services ),
	126	+ WikibaseServices::getEntityLookup($services),
	127	+ ConstraintsServices::getConstraintParameterParser($services),
	128	+ ConstraintsServices::getTypeCheckerHelper($services),
129	129	$services->getMainConfig()
130	130	);
131	131	},
132	132
133		- ConstraintCheckerServices::SINGLE_VALUE_CHECKER => static function ( MediaWikiServices $services ): SingleValueChecker {
	133	+ ConstraintCheckerServices::SINGLE_VALUE_CHECKER => static function(MediaWikiServices $services): SingleValueChecker {
134	134	return new SingleValueChecker(
135		- ConstraintsServices::getConstraintParameterParser( $services )
	135	+ ConstraintsServices::getConstraintParameterParser($services)
136	136	);
137	137	},
138	138
139		- ConstraintCheckerServices::MULTI_VALUE_CHECKER => static function ( MediaWikiServices $services ): MultiValueChecker {
	139	+ ConstraintCheckerServices::MULTI_VALUE_CHECKER => static function(MediaWikiServices $services): MultiValueChecker {
140	140	return new MultiValueChecker(
141		- ConstraintsServices::getConstraintParameterParser( $services )
	141	+ ConstraintsServices::getConstraintParameterParser($services)
142	142	);
143	143	},
144	144
145		- ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => static function ( MediaWikiServices $services ): UniqueValueChecker {
	145	+ ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => static function(MediaWikiServices $services): UniqueValueChecker {
146	146	// TODO return a different, dummy implementation if SPARQL is not available
147	147	return new UniqueValueChecker(
148		- ConstraintsServices::getSparqlHelper( $services ),
149		- ConstraintsServices::getConstraintParameterParser( $services )
	148	+ ConstraintsServices::getSparqlHelper($services),
	149	+ ConstraintsServices::getConstraintParameterParser($services)
150	150	);
151	151	},
152	152
153		- ConstraintCheckerServices::FORMAT_CHECKER => static function ( MediaWikiServices $services ): FormatChecker {
	153	+ ConstraintCheckerServices::FORMAT_CHECKER => static function(MediaWikiServices $services): FormatChecker {
154	154	// TODO return a different, dummy implementation if SPARQL is not available
155	155	return new FormatChecker(
156		- ConstraintsServices::getConstraintParameterParser( $services ),
	156	+ ConstraintsServices::getConstraintParameterParser($services),
157	157	$services->getMainConfig(),
158		- ConstraintsServices::getSparqlHelper( $services ),
	158	+ ConstraintsServices::getSparqlHelper($services),
159	159	$services->getShellboxClientFactory()
160	160	);
161	161	},
162	162
163		- ConstraintCheckerServices::COMMONS_LINK_CHECKER => static function ( MediaWikiServices $services ): CommonsLinkChecker {
	163	+ ConstraintCheckerServices::COMMONS_LINK_CHECKER => static function(MediaWikiServices $services): CommonsLinkChecker {
164	164	$pageNameNormalizer = new MediaWikiPageNameNormalizer();
165	165	return new CommonsLinkChecker(
166		- ConstraintsServices::getConstraintParameterParser( $services ),
	166	+ ConstraintsServices::getConstraintParameterParser($services),
167	167	$pageNameNormalizer,
168		- WikibaseRepo::getPropertyDataTypeLookup( $services )
	168	+ WikibaseRepo::getPropertyDataTypeLookup($services)
169	169	);
170	170	},
171	171
172		- ConstraintCheckerServices::ONE_OF_CHECKER => static function ( MediaWikiServices $services ): OneOfChecker {
	172	+ ConstraintCheckerServices::ONE_OF_CHECKER => static function(MediaWikiServices $services): OneOfChecker {
173	173	return new OneOfChecker(
174		- ConstraintsServices::getConstraintParameterParser( $services )
	174	+ ConstraintsServices::getConstraintParameterParser($services)
175	175	);
176	176	},
177	177
178		- ConstraintCheckerServices::VALUE_ONLY_CHECKER => static function ( MediaWikiServices $services ): ValueOnlyChecker {
	178	+ ConstraintCheckerServices::VALUE_ONLY_CHECKER => static function(MediaWikiServices $services): ValueOnlyChecker {
179	179	return new ValueOnlyChecker();
180	180	},
181	181
182		- ConstraintCheckerServices::REFERENCE_CHECKER => static function ( MediaWikiServices $services ): ReferenceChecker {
	182	+ ConstraintCheckerServices::REFERENCE_CHECKER => static function(MediaWikiServices $services): ReferenceChecker {
183	183	return new ReferenceChecker();
184	184	},
185	185
186		- ConstraintCheckerServices::NO_BOUNDS_CHECKER => static function ( MediaWikiServices $services ): NoBoundsChecker {
	186	+ ConstraintCheckerServices::NO_BOUNDS_CHECKER => static function(MediaWikiServices $services): NoBoundsChecker {
187	187	return new NoBoundsChecker();
188	188	},
189	189
190		- ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => static function ( MediaWikiServices $services ): AllowedUnitsChecker {
	190	+ ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => static function(MediaWikiServices $services): AllowedUnitsChecker {
191	191	return new AllowedUnitsChecker(
192		- ConstraintsServices::getConstraintParameterParser( $services ),
193		- WikibaseRepo::getUnitConverter( $services )
	192	+ ConstraintsServices::getConstraintParameterParser($services),
	193	+ WikibaseRepo::getUnitConverter($services)
194	194	);
195	195	},
196	196
197		- ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => static function (
	197	+ ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => static function(
198	198	MediaWikiServices $services
199	199	): SingleBestValueChecker {
200	200	return new SingleBestValueChecker(
201		- ConstraintsServices::getConstraintParameterParser( $services )
	201	+ ConstraintsServices::getConstraintParameterParser($services)
202	202	);
203	203	},
204	204
205		- ConstraintCheckerServices::ENTITY_TYPE_CHECKER => static function ( MediaWikiServices $services ): EntityTypeChecker {
	205	+ ConstraintCheckerServices::ENTITY_TYPE_CHECKER => static function(MediaWikiServices $services): EntityTypeChecker {
206	206	return new EntityTypeChecker(
207		- ConstraintsServices::getConstraintParameterParser( $services )
	207	+ ConstraintsServices::getConstraintParameterParser($services)
208	208	);
209	209	},
210	210
211		- ConstraintCheckerServices::NONE_OF_CHECKER => static function ( MediaWikiServices $services ): NoneOfChecker {
	211	+ ConstraintCheckerServices::NONE_OF_CHECKER => static function(MediaWikiServices $services): NoneOfChecker {
212	212	return new NoneOfChecker(
213		- ConstraintsServices::getConstraintParameterParser( $services )
	213	+ ConstraintsServices::getConstraintParameterParser($services)
214	214	);
215	215	},
216	216
217		- ConstraintCheckerServices::INTEGER_CHECKER => static function ( MediaWikiServices $services ): IntegerChecker {
	217	+ ConstraintCheckerServices::INTEGER_CHECKER => static function(MediaWikiServices $services): IntegerChecker {
218	218	return new IntegerChecker();
219	219	},
220	220
221		- ConstraintCheckerServices::CITATION_NEEDED_CHECKER => static function ( MediaWikiServices $services ): CitationNeededChecker {
	221	+ ConstraintCheckerServices::CITATION_NEEDED_CHECKER => static function(MediaWikiServices $services): CitationNeededChecker {
222	222	return new CitationNeededChecker();
223	223	},
224	224
225		- ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => static function ( MediaWikiServices $services ): PropertyScopeChecker {
	225	+ ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => static function(MediaWikiServices $services): PropertyScopeChecker {
226	226	return new PropertyScopeChecker(
227		- ConstraintsServices::getConstraintParameterParser( $services )
	227	+ ConstraintsServices::getConstraintParameterParser($services)
228	228	);
229	229	},
230	230
231		- ConstraintCheckerServices::CONTEMPORARY_CHECKER => static function ( MediaWikiServices $services ): ContemporaryChecker {
	231	+ ConstraintCheckerServices::CONTEMPORARY_CHECKER => static function(MediaWikiServices $services): ContemporaryChecker {
232	232	return new ContemporaryChecker(
233		- WikibaseServices::getEntityLookup( $services ),
234		- ConstraintsServices::getRangeCheckerHelper( $services ),
	233	+ WikibaseServices::getEntityLookup($services),
	234	+ ConstraintsServices::getRangeCheckerHelper($services),
235	235	$services->getMainConfig()
236	236	);
237	237	},
238	238
239		- ConstraintCheckerServices::LEXEME_LANGUAGE_CHECKER => static function ( MediaWikiServices $services ): LanguageChecker {
	239	+ ConstraintCheckerServices::LEXEME_LANGUAGE_CHECKER => static function(MediaWikiServices $services): LanguageChecker {
240	240	return new LanguageChecker(
241		- ConstraintsServices::getConstraintParameterParser( $services ),
242		- WikibaseServices::getEntityLookup( $services )
	241	+ ConstraintsServices::getConstraintParameterParser($services),
	242	+ WikibaseServices::getEntityLookup($services)
243	243	);
244	244	},
245	245
246		- ConstraintCheckerServices::LABEL_IN_LANGUAGE_CHECKER => static function (
	246	+ ConstraintCheckerServices::LABEL_IN_LANGUAGE_CHECKER => static function(
247	247	MediaWikiServices $services
248	248	): LabelInLanguageChecker {
249	249	return new LabelInLanguageChecker(
250		- ConstraintsServices::getConstraintParameterParser( $services )
	250	+ ConstraintsServices::getConstraintParameterParser($services)
251	251	);
252	252	},
253	253	];

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( dc26af...270588 )

Status

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +75 added lines, -75 removed lines patch added patch discarded remove patch