Inspection of "Add entity lookup without cache service and use it..." - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f41943...71e1d7 )

unknown

created 2019-07-23 16:11 UTC

Status

Spacing +67 added lines, -67 removed lines patch added patch discarded remove patch

@@ -36,193 +36,193 @@
 block discarded – undo
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\ValueTypeChecker;
 
 return [
-	ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => function(MediaWikiServices $services) {
 		return new ConflictsWithChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::ITEM_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::ITEM_CHECKER => function(MediaWikiServices $services) {
 		return new ItemChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => function(MediaWikiServices $services) {
 		return new TargetRequiredClaimChecker(
-			WikibaseServices::getEntityLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			WikibaseServices::getEntityLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::SYMMETRIC_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::SYMMETRIC_CHECKER => function(MediaWikiServices $services) {
 		return new SymmetricChecker(
-			WikibaseServices::getEntityLookupWithoutCache( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			WikibaseServices::getEntityLookupWithoutCache($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::INVERSE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::INVERSE_CHECKER => function(MediaWikiServices $services) {
 		return new InverseChecker(
-			WikibaseServices::getEntityLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getConnectionCheckerHelper( $services )
+			WikibaseServices::getEntityLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getConnectionCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::QUALIFIER_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::QUALIFIER_CHECKER => function(MediaWikiServices $services) {
 		return new QualifierChecker();
 	},
 
-	ConstraintCheckerServices::QUALIFIERS_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::QUALIFIERS_CHECKER => function(MediaWikiServices $services) {
 		return new QualifiersChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => function(MediaWikiServices $services) {
 		return new MandatoryQualifiersChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::RANGE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::RANGE_CHECKER => function(MediaWikiServices $services) {
 		return new RangeChecker(
-			WikibaseServices::getPropertyDataTypeLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getRangeCheckerHelper( $services )
+			WikibaseServices::getPropertyDataTypeLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getRangeCheckerHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => function(MediaWikiServices $services) {
 		return new DiffWithinRangeChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getRangeCheckerHelper( $services ),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getRangeCheckerHelper($services),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintCheckerServices::TYPE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::TYPE_CHECKER => function(MediaWikiServices $services) {
 		return new TypeChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getTypeCheckerHelper( $services ),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getTypeCheckerHelper($services),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintCheckerServices::VALUE_TYPE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::VALUE_TYPE_CHECKER => function(MediaWikiServices $services) {
 		return new ValueTypeChecker(
-			WikibaseServices::getEntityLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
-			ConstraintsServices::getTypeCheckerHelper( $services ),
+			WikibaseServices::getEntityLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
+			ConstraintsServices::getTypeCheckerHelper($services),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintCheckerServices::SINGLE_VALUE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::SINGLE_VALUE_CHECKER => function(MediaWikiServices $services) {
 		return new SingleValueChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::MULTI_VALUE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::MULTI_VALUE_CHECKER => function(MediaWikiServices $services) {
 		return new MultiValueChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => function(MediaWikiServices $services) {
 		// TODO return a different, dummy implementation if SPARQL is not available
 		return new UniqueValueChecker(
-			ConstraintsServices::getSparqlHelper( $services )
+			ConstraintsServices::getSparqlHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::FORMAT_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::FORMAT_CHECKER => function(MediaWikiServices $services) {
 		// TODO return a different, dummy implementation if SPARQL is not available
 		return new FormatChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
+			ConstraintsServices::getConstraintParameterParser($services),
 			$services->getMainConfig(),
-			ConstraintsServices::getSparqlHelper( $services )
+			ConstraintsServices::getSparqlHelper($services)
 		);
 	},
 
-	ConstraintCheckerServices::COMMONS_LINK_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::COMMONS_LINK_CHECKER => function(MediaWikiServices $services) {
 		$pageNameNormalizer = new MediaWikiPageNameNormalizer();
 		return new CommonsLinkChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
+			ConstraintsServices::getConstraintParameterParser($services),
 			$pageNameNormalizer
 		);
 	},
 
-	ConstraintCheckerServices::ONE_OF_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::ONE_OF_CHECKER => function(MediaWikiServices $services) {
 		return new OneOfChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::VALUE_ONLY_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::VALUE_ONLY_CHECKER => function(MediaWikiServices $services) {
 		return new ValueOnlyChecker();
 	},
 
-	ConstraintCheckerServices::REFERENCE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::REFERENCE_CHECKER => function(MediaWikiServices $services) {
 		return new ReferenceChecker();
 	},
 
-	ConstraintCheckerServices::NO_BOUNDS_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::NO_BOUNDS_CHECKER => function(MediaWikiServices $services) {
 		return new NoBoundsChecker();
 	},
 
-	ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => function(MediaWikiServices $services) {
 		// TODO in the future, get UnitConverter from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$unitConverter = $repo->getUnitConverter();
 
 		return new AllowedUnitsChecker(
-			ConstraintsServices::getConstraintParameterParser( $services ),
+			ConstraintsServices::getConstraintParameterParser($services),
 			$unitConverter
 		);
 	},
 
-	ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => function(MediaWikiServices $services) {
 		return new SingleBestValueChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::ENTITY_TYPE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::ENTITY_TYPE_CHECKER => function(MediaWikiServices $services) {
 		return new EntityTypeChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::NONE_OF_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::NONE_OF_CHECKER => function(MediaWikiServices $services) {
 		return new NoneOfChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::INTEGER_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::INTEGER_CHECKER => function(MediaWikiServices $services) {
 		return new IntegerChecker();
 	},
 
-	ConstraintCheckerServices::CITATION_NEEDED_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::CITATION_NEEDED_CHECKER => function(MediaWikiServices $services) {
 		return new CitationNeededChecker();
 	},
 
-	ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => function(MediaWikiServices $services) {
 		return new PropertyScopeChecker(
-			ConstraintsServices::getConstraintParameterParser( $services )
+			ConstraintsServices::getConstraintParameterParser($services)
 		);
 	},
 
-	ConstraintCheckerServices::CONTEMPORARY_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintCheckerServices::CONTEMPORARY_CHECKER => function(MediaWikiServices $services) {
 		return new ContemporaryChecker(
-			WikibaseServices::getEntityLookup( $services ),
-			ConstraintsServices::getRangeCheckerHelper( $services ),
+			WikibaseServices::getEntityLookup($services),
+			ConstraintsServices::getRangeCheckerHelper($services),
 			$services->getMainConfig()
 		);
 	},

Please login to merge, or discard this patch.

src/ServiceWiring-Wikibase.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -8,19 +8,19 @@
 block discarded – undo
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ExceptionIgnoringEntityLookup;
 
 return [
-	WikibaseServices::ENTITY_LOOKUP => function( MediaWikiServices $services ) {
+	WikibaseServices::ENTITY_LOOKUP => function(MediaWikiServices $services) {
 		return new ExceptionIgnoringEntityLookup(
 			WikibaseRepo::getDefaultInstance()->getEntityLookup()
 		);
 	},
 
-	WikibaseServices::ENTITY_LOOKUP_WIHTOUT_CACHE => function( MediaWikiServices $services ) {
+	WikibaseServices::ENTITY_LOOKUP_WIHTOUT_CACHE => function(MediaWikiServices $services) {
 		return new ExceptionIgnoringEntityLookup(
-			WikibaseRepo::getDefaultInstance()->getEntityLookup( Store::LOOKUP_CACHING_RETRIEVE_ONLY )
+			WikibaseRepo::getDefaultInstance()->getEntityLookup(Store::LOOKUP_CACHING_RETRIEVE_ONLY)
 		);
 	},
 
-	WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => function( MediaWikiServices $services ) {
+	WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => function(MediaWikiServices $services) {
 		return WikibaseRepo::getDefaultInstance()->getPropertyDataTypeLookup();
 	},
 ];

Please login to merge, or discard this patch.

src/WikibaseServices.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -20,35 +20,35 @@
 block discarded – undo
 	const PROPERTY_DATA_TYPE_LOOKUP = 'WBQC_PropertyDataTypeLookup';
 	const ENTITY_LOOKUP_WIHTOUT_CACHE = 'WBQC_EntityLookupWithoutCache';
 
-	private static function getService( MediaWikiServices $services = null, $name ) {
-		if ( $services === null ) {
+	private static function getService(MediaWikiServices $services = null, $name) {
+		if ($services === null) {
 			$services = MediaWikiServices::getInstance();
 		}
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return EntityLookup
 	 */
-	public static function getEntityLookup( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ENTITY_LOOKUP );
+	public static function getEntityLookup(MediaWikiServices $services = null) {
+		return self::getService($services, self::ENTITY_LOOKUP);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return PropertyDataTypeLookup
 	 */
-	public static function getPropertyDataTypeLookup( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::PROPERTY_DATA_TYPE_LOOKUP );
+	public static function getPropertyDataTypeLookup(MediaWikiServices $services = null) {
+		return self::getService($services, self::PROPERTY_DATA_TYPE_LOOKUP);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return EntityLookup
 	 */
-	public static function getEntityLookupWithoutCache( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ENTITY_LOOKUP_WIHTOUT_CACHE );
+	public static function getEntityLookupWithoutCache(MediaWikiServices $services = null) {
+		return self::getService($services, self::ENTITY_LOOKUP_WIHTOUT_CACHE);
 	}
 
 }

Please login to merge, or discard this patch.

		@@ -20,35 +20,35 @@
		block discarded – undo
20	20	const PROPERTY_DATA_TYPE_LOOKUP = 'WBQC_PropertyDataTypeLookup';
21	21	const ENTITY_LOOKUP_WIHTOUT_CACHE = 'WBQC_EntityLookupWithoutCache';
22	22
23		- private static function getService( MediaWikiServices $services = null, $name ) {
24		- if ( $services === null ) {
	23	+ private static function getService(MediaWikiServices $services = null, $name) {
	24	+ if ($services === null) {
25	25	$services = MediaWikiServices::getInstance();
26	26	}
27		- return $services->getService( $name );
	27	+ return $services->getService($name);
28	28	}
29	29
30	30	/**
31	31	* @param MediaWikiServices\|null $services
32	32	* @return EntityLookup
33	33	*/
34		- public static function getEntityLookup( MediaWikiServices $services = null ) {
35		- return self::getService( $services, self::ENTITY_LOOKUP );
	34	+ public static function getEntityLookup(MediaWikiServices $services = null) {
	35	+ return self::getService($services, self::ENTITY_LOOKUP);
36	36	}
37	37
38	38	/**
39	39	* @param MediaWikiServices\|null $services
40	40	* @return PropertyDataTypeLookup
41	41	*/
42		- public static function getPropertyDataTypeLookup( MediaWikiServices $services = null ) {
43		- return self::getService( $services, self::PROPERTY_DATA_TYPE_LOOKUP );
	42	+ public static function getPropertyDataTypeLookup(MediaWikiServices $services = null) {
	43	+ return self::getService($services, self::PROPERTY_DATA_TYPE_LOOKUP);
44	44	}
45	45
46	46	/**
47	47	* @param MediaWikiServices\|null $services
48	48	* @return EntityLookup
49	49	*/
50		- public static function getEntityLookupWithoutCache( MediaWikiServices $services = null ) {
51		- return self::getService( $services, self::ENTITY_LOOKUP_WIHTOUT_CACHE );
	50	+ public static function getEntityLookupWithoutCache(MediaWikiServices $services = null) {
	51	+ return self::getService($services, self::ENTITY_LOOKUP_WIHTOUT_CACHE);
52	52	}
53	53
54	54	}

		@@ -36,193 +36,193 @@
		block discarded – undo
36	36	use WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\ValueTypeChecker;
37	37
38	38	return [
39		- ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => function( MediaWikiServices $services ) {
	39	+ ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => function(MediaWikiServices $services) {
40	40	return new ConflictsWithChecker(
41		- ConstraintsServices::getConstraintParameterParser( $services ),
42		- ConstraintsServices::getConnectionCheckerHelper( $services )
	41	+ ConstraintsServices::getConstraintParameterParser($services),
	42	+ ConstraintsServices::getConnectionCheckerHelper($services)
43	43	);
44	44	},
45	45
46		- ConstraintCheckerServices::ITEM_CHECKER => function( MediaWikiServices $services ) {
	46	+ ConstraintCheckerServices::ITEM_CHECKER => function(MediaWikiServices $services) {
47	47	return new ItemChecker(
48		- ConstraintsServices::getConstraintParameterParser( $services ),
49		- ConstraintsServices::getConnectionCheckerHelper( $services )
	48	+ ConstraintsServices::getConstraintParameterParser($services),
	49	+ ConstraintsServices::getConnectionCheckerHelper($services)
50	50	);
51	51	},
52	52
53		- ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => function( MediaWikiServices $services ) {
	53	+ ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => function(MediaWikiServices $services) {
54	54	return new TargetRequiredClaimChecker(
55		- WikibaseServices::getEntityLookup( $services ),
56		- ConstraintsServices::getConstraintParameterParser( $services ),
57		- ConstraintsServices::getConnectionCheckerHelper( $services )
	55	+ WikibaseServices::getEntityLookup($services),
	56	+ ConstraintsServices::getConstraintParameterParser($services),
	57	+ ConstraintsServices::getConnectionCheckerHelper($services)
58	58	);
59	59	},
60	60
61		- ConstraintCheckerServices::SYMMETRIC_CHECKER => function( MediaWikiServices $services ) {
	61	+ ConstraintCheckerServices::SYMMETRIC_CHECKER => function(MediaWikiServices $services) {
62	62	return new SymmetricChecker(
63		- WikibaseServices::getEntityLookupWithoutCache( $services ),
64		- ConstraintsServices::getConnectionCheckerHelper( $services )
	63	+ WikibaseServices::getEntityLookupWithoutCache($services),
	64	+ ConstraintsServices::getConnectionCheckerHelper($services)
65	65	);
66	66	},
67	67
68		- ConstraintCheckerServices::INVERSE_CHECKER => function( MediaWikiServices $services ) {
	68	+ ConstraintCheckerServices::INVERSE_CHECKER => function(MediaWikiServices $services) {
69	69	return new InverseChecker(
70		- WikibaseServices::getEntityLookup( $services ),
71		- ConstraintsServices::getConstraintParameterParser( $services ),
72		- ConstraintsServices::getConnectionCheckerHelper( $services )
	70	+ WikibaseServices::getEntityLookup($services),
	71	+ ConstraintsServices::getConstraintParameterParser($services),
	72	+ ConstraintsServices::getConnectionCheckerHelper($services)
73	73	);
74	74	},
75	75
76		- ConstraintCheckerServices::QUALIFIER_CHECKER => function( MediaWikiServices $services ) {
	76	+ ConstraintCheckerServices::QUALIFIER_CHECKER => function(MediaWikiServices $services) {
77	77	return new QualifierChecker();
78	78	},
79	79
80		- ConstraintCheckerServices::QUALIFIERS_CHECKER => function( MediaWikiServices $services ) {
	80	+ ConstraintCheckerServices::QUALIFIERS_CHECKER => function(MediaWikiServices $services) {
81	81	return new QualifiersChecker(
82		- ConstraintsServices::getConstraintParameterParser( $services )
	82	+ ConstraintsServices::getConstraintParameterParser($services)
83	83	);
84	84	},
85	85
86		- ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => function( MediaWikiServices $services ) {
	86	+ ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => function(MediaWikiServices $services) {
87	87	return new MandatoryQualifiersChecker(
88		- ConstraintsServices::getConstraintParameterParser( $services )
	88	+ ConstraintsServices::getConstraintParameterParser($services)
89	89	);
90	90	},
91	91
92		- ConstraintCheckerServices::RANGE_CHECKER => function( MediaWikiServices $services ) {
	92	+ ConstraintCheckerServices::RANGE_CHECKER => function(MediaWikiServices $services) {
93	93	return new RangeChecker(
94		- WikibaseServices::getPropertyDataTypeLookup( $services ),
95		- ConstraintsServices::getConstraintParameterParser( $services ),
96		- ConstraintsServices::getRangeCheckerHelper( $services )
	94	+ WikibaseServices::getPropertyDataTypeLookup($services),
	95	+ ConstraintsServices::getConstraintParameterParser($services),
	96	+ ConstraintsServices::getRangeCheckerHelper($services)
97	97	);
98	98	},
99	99
100		- ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => function( MediaWikiServices $services ) {
	100	+ ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => function(MediaWikiServices $services) {
101	101	return new DiffWithinRangeChecker(
102		- ConstraintsServices::getConstraintParameterParser( $services ),
103		- ConstraintsServices::getRangeCheckerHelper( $services ),
	102	+ ConstraintsServices::getConstraintParameterParser($services),
	103	+ ConstraintsServices::getRangeCheckerHelper($services),
104	104	$services->getMainConfig()
105	105	);
106	106	},
107	107
108		- ConstraintCheckerServices::TYPE_CHECKER => function( MediaWikiServices $services ) {
	108	+ ConstraintCheckerServices::TYPE_CHECKER => function(MediaWikiServices $services) {
109	109	return new TypeChecker(
110		- ConstraintsServices::getConstraintParameterParser( $services ),
111		- ConstraintsServices::getTypeCheckerHelper( $services ),
	110	+ ConstraintsServices::getConstraintParameterParser($services),
	111	+ ConstraintsServices::getTypeCheckerHelper($services),
112	112	$services->getMainConfig()
113	113	);
114	114	},
115	115
116		- ConstraintCheckerServices::VALUE_TYPE_CHECKER => function( MediaWikiServices $services ) {
	116	+ ConstraintCheckerServices::VALUE_TYPE_CHECKER => function(MediaWikiServices $services) {
117	117	return new ValueTypeChecker(
118		- WikibaseServices::getEntityLookup( $services ),
119		- ConstraintsServices::getConstraintParameterParser( $services ),
120		- ConstraintsServices::getTypeCheckerHelper( $services ),
	118	+ WikibaseServices::getEntityLookup($services),
	119	+ ConstraintsServices::getConstraintParameterParser($services),
	120	+ ConstraintsServices::getTypeCheckerHelper($services),
121	121	$services->getMainConfig()
122	122	);
123	123	},
124	124
125		- ConstraintCheckerServices::SINGLE_VALUE_CHECKER => function( MediaWikiServices $services ) {
	125	+ ConstraintCheckerServices::SINGLE_VALUE_CHECKER => function(MediaWikiServices $services) {
126	126	return new SingleValueChecker(
127		- ConstraintsServices::getConstraintParameterParser( $services )
	127	+ ConstraintsServices::getConstraintParameterParser($services)
128	128	);
129	129	},
130	130
131		- ConstraintCheckerServices::MULTI_VALUE_CHECKER => function( MediaWikiServices $services ) {
	131	+ ConstraintCheckerServices::MULTI_VALUE_CHECKER => function(MediaWikiServices $services) {
132	132	return new MultiValueChecker(
133		- ConstraintsServices::getConstraintParameterParser( $services )
	133	+ ConstraintsServices::getConstraintParameterParser($services)
134	134	);
135	135	},
136	136
137		- ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => function( MediaWikiServices $services ) {
	137	+ ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => function(MediaWikiServices $services) {
138	138	// TODO return a different, dummy implementation if SPARQL is not available
139	139	return new UniqueValueChecker(
140		- ConstraintsServices::getSparqlHelper( $services )
	140	+ ConstraintsServices::getSparqlHelper($services)
141	141	);
142	142	},
143	143
144		- ConstraintCheckerServices::FORMAT_CHECKER => function( MediaWikiServices $services ) {
	144	+ ConstraintCheckerServices::FORMAT_CHECKER => function(MediaWikiServices $services) {
145	145	// TODO return a different, dummy implementation if SPARQL is not available
146	146	return new FormatChecker(
147		- ConstraintsServices::getConstraintParameterParser( $services ),
	147	+ ConstraintsServices::getConstraintParameterParser($services),
148	148	$services->getMainConfig(),
149		- ConstraintsServices::getSparqlHelper( $services )
	149	+ ConstraintsServices::getSparqlHelper($services)
150	150	);
151	151	},
152	152
153		- ConstraintCheckerServices::COMMONS_LINK_CHECKER => function( MediaWikiServices $services ) {
	153	+ ConstraintCheckerServices::COMMONS_LINK_CHECKER => function(MediaWikiServices $services) {
154	154	$pageNameNormalizer = new MediaWikiPageNameNormalizer();
155	155	return new CommonsLinkChecker(
156		- ConstraintsServices::getConstraintParameterParser( $services ),
	156	+ ConstraintsServices::getConstraintParameterParser($services),
157	157	$pageNameNormalizer
158	158	);
159	159	},
160	160
161		- ConstraintCheckerServices::ONE_OF_CHECKER => function( MediaWikiServices $services ) {
	161	+ ConstraintCheckerServices::ONE_OF_CHECKER => function(MediaWikiServices $services) {
162	162	return new OneOfChecker(
163		- ConstraintsServices::getConstraintParameterParser( $services )
	163	+ ConstraintsServices::getConstraintParameterParser($services)
164	164	);
165	165	},
166	166
167		- ConstraintCheckerServices::VALUE_ONLY_CHECKER => function( MediaWikiServices $services ) {
	167	+ ConstraintCheckerServices::VALUE_ONLY_CHECKER => function(MediaWikiServices $services) {
168	168	return new ValueOnlyChecker();
169	169	},
170	170
171		- ConstraintCheckerServices::REFERENCE_CHECKER => function( MediaWikiServices $services ) {
	171	+ ConstraintCheckerServices::REFERENCE_CHECKER => function(MediaWikiServices $services) {
172	172	return new ReferenceChecker();
173	173	},
174	174
175		- ConstraintCheckerServices::NO_BOUNDS_CHECKER => function( MediaWikiServices $services ) {
	175	+ ConstraintCheckerServices::NO_BOUNDS_CHECKER => function(MediaWikiServices $services) {
176	176	return new NoBoundsChecker();
177	177	},
178	178
179		- ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => function( MediaWikiServices $services ) {
	179	+ ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => function(MediaWikiServices $services) {
180	180	// TODO in the future, get UnitConverter from $services?
181	181	$repo = WikibaseRepo::getDefaultInstance();
182	182	$unitConverter = $repo->getUnitConverter();
183	183
184	184	return new AllowedUnitsChecker(
185		- ConstraintsServices::getConstraintParameterParser( $services ),
	185	+ ConstraintsServices::getConstraintParameterParser($services),
186	186	$unitConverter
187	187	);
188	188	},
189	189
190		- ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => function( MediaWikiServices $services ) {
	190	+ ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => function(MediaWikiServices $services) {
191	191	return new SingleBestValueChecker(
192		- ConstraintsServices::getConstraintParameterParser( $services )
	192	+ ConstraintsServices::getConstraintParameterParser($services)
193	193	);
194	194	},
195	195
196		- ConstraintCheckerServices::ENTITY_TYPE_CHECKER => function( MediaWikiServices $services ) {
	196	+ ConstraintCheckerServices::ENTITY_TYPE_CHECKER => function(MediaWikiServices $services) {
197	197	return new EntityTypeChecker(
198		- ConstraintsServices::getConstraintParameterParser( $services )
	198	+ ConstraintsServices::getConstraintParameterParser($services)
199	199	);
200	200	},
201	201
202		- ConstraintCheckerServices::NONE_OF_CHECKER => function( MediaWikiServices $services ) {
	202	+ ConstraintCheckerServices::NONE_OF_CHECKER => function(MediaWikiServices $services) {
203	203	return new NoneOfChecker(
204		- ConstraintsServices::getConstraintParameterParser( $services )
	204	+ ConstraintsServices::getConstraintParameterParser($services)
205	205	);
206	206	},
207	207
208		- ConstraintCheckerServices::INTEGER_CHECKER => function( MediaWikiServices $services ) {
	208	+ ConstraintCheckerServices::INTEGER_CHECKER => function(MediaWikiServices $services) {
209	209	return new IntegerChecker();
210	210	},
211	211
212		- ConstraintCheckerServices::CITATION_NEEDED_CHECKER => function( MediaWikiServices $services ) {
	212	+ ConstraintCheckerServices::CITATION_NEEDED_CHECKER => function(MediaWikiServices $services) {
213	213	return new CitationNeededChecker();
214	214	},
215	215
216		- ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => function( MediaWikiServices $services ) {
	216	+ ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => function(MediaWikiServices $services) {
217	217	return new PropertyScopeChecker(
218		- ConstraintsServices::getConstraintParameterParser( $services )
	218	+ ConstraintsServices::getConstraintParameterParser($services)
219	219	);
220	220	},
221	221
222		- ConstraintCheckerServices::CONTEMPORARY_CHECKER => function( MediaWikiServices $services ) {
	222	+ ConstraintCheckerServices::CONTEMPORARY_CHECKER => function(MediaWikiServices $services) {
223	223	return new ContemporaryChecker(
224		- WikibaseServices::getEntityLookup( $services ),
225		- ConstraintsServices::getRangeCheckerHelper( $services ),
	224	+ WikibaseServices::getEntityLookup($services),
	225	+ ConstraintsServices::getRangeCheckerHelper($services),
226	226	$services->getMainConfig()
227	227	);
228	228	},

		@@ -8,19 +8,19 @@
		block discarded – undo
8	8	use WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ExceptionIgnoringEntityLookup;
9	9
10	10	return [
11		- WikibaseServices::ENTITY_LOOKUP => function( MediaWikiServices $services ) {
	11	+ WikibaseServices::ENTITY_LOOKUP => function(MediaWikiServices $services) {
12	12	return new ExceptionIgnoringEntityLookup(
13	13	WikibaseRepo::getDefaultInstance()->getEntityLookup()
14	14	);
15	15	},
16	16
17		- WikibaseServices::ENTITY_LOOKUP_WIHTOUT_CACHE => function( MediaWikiServices $services ) {
	17	+ WikibaseServices::ENTITY_LOOKUP_WIHTOUT_CACHE => function(MediaWikiServices $services) {
18	18	return new ExceptionIgnoringEntityLookup(
19		- WikibaseRepo::getDefaultInstance()->getEntityLookup( Store::LOOKUP_CACHING_RETRIEVE_ONLY )
	19	+ WikibaseRepo::getDefaultInstance()->getEntityLookup(Store::LOOKUP_CACHING_RETRIEVE_ONLY)
20	20	);
21	21	},
22	22
23		- WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => function( MediaWikiServices $services ) {
	23	+ WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => function(MediaWikiServices $services) {
24	24	return WikibaseRepo::getDefaultInstance()->getPropertyDataTypeLookup();
25	25	},
26	26	];

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( f41943...71e1d7 )

Status

Category

Spacing +67 added lines, -67 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch