@@ -79,19 +79,19 @@ discard block |
||
79 | 79 | * |
80 | 80 | * @return self |
81 | 81 | */ |
82 | - public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) { |
|
82 | + public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') { |
|
83 | 83 | $repo = WikibaseRepo::getDefaultInstance(); |
84 | 84 | |
85 | 85 | $language = $repo->getUserLanguage(); |
86 | 86 | $formatterOptions = new FormatterOptions(); |
87 | - $formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() ); |
|
87 | + $formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode()); |
|
88 | 88 | $valueFormatterFactory = $repo->getValueFormatterFactory(); |
89 | - $valueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions ); |
|
89 | + $valueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions); |
|
90 | 90 | |
91 | 91 | $entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory(); |
92 | - $entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $language ); |
|
92 | + $entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($language); |
|
93 | 93 | $entityIdLabelFormatterFactory = new EntityIdLabelFormatterFactory(); |
94 | - $entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $language ); |
|
94 | + $entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($language); |
|
95 | 95 | $config = MediaWikiServices::getInstance()->getMainConfig(); |
96 | 96 | $dataFactory = MediaWikiServices::getInstance()->getStatsdDataFactory(); |
97 | 97 | |
@@ -113,7 +113,7 @@ discard block |
||
113 | 113 | $prefix, |
114 | 114 | $repo->getEntityIdParser(), |
115 | 115 | $repo->getStatementGuidValidator(), |
116 | - $repo->getApiHelperFactory( RequestContext::getMain() ), |
|
116 | + $repo->getApiHelperFactory(RequestContext::getMain()), |
|
117 | 117 | $resultsSource, |
118 | 118 | $checkResultsRenderer, |
119 | 119 | $dataFactory |
@@ -142,11 +142,11 @@ discard block |
||
142 | 142 | CheckResultsRenderer $checkResultsRenderer, |
143 | 143 | IBufferingStatsdDataFactory $dataFactory |
144 | 144 | ) { |
145 | - parent::__construct( $main, $name, $prefix ); |
|
145 | + parent::__construct($main, $name, $prefix); |
|
146 | 146 | $this->entityIdParser = $entityIdParser; |
147 | 147 | $this->statementGuidValidator = $statementGuidValidator; |
148 | - $this->resultBuilder = $apiHelperFactory->getResultBuilder( $this ); |
|
149 | - $this->errorReporter = $apiHelperFactory->getErrorReporter( $this ); |
|
148 | + $this->resultBuilder = $apiHelperFactory->getResultBuilder($this); |
|
149 | + $this->errorReporter = $apiHelperFactory->getErrorReporter($this); |
|
150 | 150 | $this->resultsSource = $resultsSource; |
151 | 151 | $this->checkResultsRenderer = $checkResultsRenderer; |
152 | 152 | $this->dataFactory = $dataFactory; |
@@ -162,9 +162,9 @@ discard block |
||
162 | 162 | |
163 | 163 | $params = $this->extractRequestParams(); |
164 | 164 | |
165 | - $this->validateParameters( $params ); |
|
166 | - $entityIds = $this->parseEntityIds( $params ); |
|
167 | - $claimIds = $this->parseClaimIds( $params ); |
|
165 | + $this->validateParameters($params); |
|
166 | + $entityIds = $this->parseEntityIds($params); |
|
167 | + $claimIds = $this->parseClaimIds($params); |
|
168 | 168 | $constraintIDs = $params[self::PARAM_CONSTRAINT_ID]; |
169 | 169 | $statuses = $params[self::PARAM_STATUS]; |
170 | 170 | |
@@ -180,7 +180,7 @@ discard block |
||
180 | 180 | ) |
181 | 181 | )->getArray() |
182 | 182 | ); |
183 | - $this->resultBuilder->markSuccess( 1 ); |
|
183 | + $this->resultBuilder->markSuccess(1); |
|
184 | 184 | } |
185 | 185 | |
186 | 186 | /** |
@@ -188,24 +188,24 @@ discard block |
||
188 | 188 | * |
189 | 189 | * @return EntityId[] |
190 | 190 | */ |
191 | - private function parseEntityIds( array $params ) { |
|
191 | + private function parseEntityIds(array $params) { |
|
192 | 192 | $ids = $params[self::PARAM_ID]; |
193 | 193 | |
194 | - if ( $ids === null ) { |
|
194 | + if ($ids === null) { |
|
195 | 195 | return []; |
196 | - } elseif ( $ids === [] ) { |
|
196 | + } elseif ($ids === []) { |
|
197 | 197 | $this->errorReporter->dieError( |
198 | - 'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
198 | + 'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
199 | 199 | } |
200 | 200 | |
201 | - return array_map( function ( $id ) { |
|
201 | + return array_map(function($id) { |
|
202 | 202 | try { |
203 | - return $this->entityIdParser->parse( $id ); |
|
204 | - } catch ( EntityIdParsingException $e ) { |
|
203 | + return $this->entityIdParser->parse($id); |
|
204 | + } catch (EntityIdParsingException $e) { |
|
205 | 205 | $this->errorReporter->dieError( |
206 | - "Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] ); |
|
206 | + "Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] ); |
|
207 | 207 | } |
208 | - }, $ids ); |
|
208 | + }, $ids); |
|
209 | 209 | } |
210 | 210 | |
211 | 211 | /** |
@@ -213,36 +213,36 @@ discard block |
||
213 | 213 | * |
214 | 214 | * @return string[] |
215 | 215 | */ |
216 | - private function parseClaimIds( array $params ) { |
|
216 | + private function parseClaimIds(array $params) { |
|
217 | 217 | $ids = $params[self::PARAM_CLAIM_ID]; |
218 | 218 | |
219 | - if ( $ids === null ) { |
|
219 | + if ($ids === null) { |
|
220 | 220 | return []; |
221 | - } elseif ( $ids === [] ) { |
|
221 | + } elseif ($ids === []) { |
|
222 | 222 | $this->errorReporter->dieError( |
223 | - 'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
223 | + 'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
224 | 224 | } |
225 | 225 | |
226 | - foreach ( $ids as $id ) { |
|
227 | - if ( !$this->statementGuidValidator->validate( $id ) ) { |
|
226 | + foreach ($ids as $id) { |
|
227 | + if (!$this->statementGuidValidator->validate($id)) { |
|
228 | 228 | $this->errorReporter->dieError( |
229 | - "Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] ); |
|
229 | + "Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] ); |
|
230 | 230 | } |
231 | 231 | } |
232 | 232 | |
233 | 233 | return $ids; |
234 | 234 | } |
235 | 235 | |
236 | - private function validateParameters( array $params ) { |
|
237 | - if ( $params[self::PARAM_CONSTRAINT_ID] !== null |
|
238 | - && empty( $params[self::PARAM_CONSTRAINT_ID] ) |
|
236 | + private function validateParameters(array $params) { |
|
237 | + if ($params[self::PARAM_CONSTRAINT_ID] !== null |
|
238 | + && empty($params[self::PARAM_CONSTRAINT_ID]) |
|
239 | 239 | ) { |
240 | 240 | $paramConstraintId = self::PARAM_CONSTRAINT_ID; |
241 | 241 | $this->errorReporter->dieError( |
242 | 242 | "If $paramConstraintId is specified, it must be nonempty.", 'no-data' ); |
243 | 243 | } |
244 | 244 | // @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset |
245 | - if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) { |
|
245 | + if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) { |
|
246 | 246 | $paramId = self::PARAM_ID; |
247 | 247 | $paramClaimId = self::PARAM_CLAIM_ID; |
248 | 248 | $this->errorReporter->dieError( |
@@ -283,7 +283,7 @@ discard block |
||
283 | 283 | ], |
284 | 284 | ApiBase::PARAM_ISMULTI => true, |
285 | 285 | ApiBase::PARAM_ALL => true, |
286 | - ApiBase::PARAM_DFLT => implode( '|', CachingResultsSource::CACHED_STATUSES ), |
|
286 | + ApiBase::PARAM_DFLT => implode('|', CachingResultsSource::CACHED_STATUSES), |
|
287 | 287 | ApiBase::PARAM_HELP_MSG_PER_VALUE => [], |
288 | 288 | ], |
289 | 289 | ]; |
@@ -162,58 +162,58 @@ discard block |
||
162 | 162 | $this->defaultUserAgent = $defaultUserAgent; |
163 | 163 | $this->requestFactory = $requestFactory; |
164 | 164 | $this->entityPrefixes = []; |
165 | - foreach ( $rdfVocabulary->entityNamespaceNames as $namespaceName ) { |
|
166 | - $this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI( $namespaceName ); |
|
165 | + foreach ($rdfVocabulary->entityNamespaceNames as $namespaceName) { |
|
166 | + $this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI($namespaceName); |
|
167 | 167 | } |
168 | 168 | |
169 | - $this->prefixes = $this->getQueryPrefixes( $rdfVocabulary ); |
|
169 | + $this->prefixes = $this->getQueryPrefixes($rdfVocabulary); |
|
170 | 170 | } |
171 | 171 | |
172 | - private function getQueryPrefixes( RdfVocabulary $rdfVocabulary ) { |
|
172 | + private function getQueryPrefixes(RdfVocabulary $rdfVocabulary) { |
|
173 | 173 | // TODO: it would probably be smarter that RdfVocubulary exposed these prefixes somehow |
174 | 174 | $prefixes = ''; |
175 | - foreach ( $rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName ) { |
|
175 | + foreach ($rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName) { |
|
176 | 176 | $prefixes .= <<<END |
177 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
177 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
178 | 178 | END; |
179 | 179 | } |
180 | 180 | $prefixes .= <<<END |
181 | -PREFIX wds: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_STATEMENT )}> |
|
182 | -PREFIX wdv: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_VALUE )}>\n |
|
181 | +PREFIX wds: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_STATEMENT)}> |
|
182 | +PREFIX wdv: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_VALUE)}>\n |
|
183 | 183 | END; |
184 | 184 | |
185 | - foreach ( $rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces ) { |
|
185 | + foreach ($rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces) { |
|
186 | 186 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_DIRECT_CLAIM]; |
187 | 187 | $prefixes .= <<<END |
188 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
188 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
189 | 189 | END; |
190 | 190 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM]; |
191 | 191 | $prefixes .= <<<END |
192 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
192 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
193 | 193 | END; |
194 | 194 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM_STATEMENT]; |
195 | 195 | $prefixes .= <<<END |
196 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
196 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
197 | 197 | END; |
198 | 198 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER]; |
199 | 199 | $prefixes .= <<<END |
200 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
200 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
201 | 201 | END; |
202 | 202 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER_VALUE]; |
203 | 203 | $prefixes .= <<<END |
204 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
204 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
205 | 205 | END; |
206 | 206 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE]; |
207 | 207 | $prefixes .= <<<END |
208 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
208 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
209 | 209 | END; |
210 | 210 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE_VALUE]; |
211 | 211 | $prefixes .= <<<END |
212 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
212 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
213 | 213 | END; |
214 | 214 | } |
215 | 215 | $prefixes .= <<<END |
216 | -PREFIX wikibase: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_ONTOLOGY )}>\n |
|
216 | +PREFIX wikibase: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_ONTOLOGY)}>\n |
|
217 | 217 | END; |
218 | 218 | return $prefixes; |
219 | 219 | } |
@@ -225,22 +225,21 @@ discard block |
||
225 | 225 | * @return CachedBool |
226 | 226 | * @throws SparqlHelperException if the query times out or some other error occurs |
227 | 227 | */ |
228 | - public function hasType( $id, array $classes ) { |
|
229 | - $subclassOfId = $this->config->get( 'WBQualityConstraintsSubclassOfId' ); |
|
228 | + public function hasType($id, array $classes) { |
|
229 | + $subclassOfId = $this->config->get('WBQualityConstraintsSubclassOfId'); |
|
230 | 230 | // TODO hint:gearing is a workaround for T168973 and can hopefully be removed eventually |
231 | - $gearingHint = $this->config->get( 'WBQualityConstraintsSparqlHasWikibaseSupport' ) ? |
|
232 | - ' hint:Prior hint:gearing "forward".' : |
|
233 | - ''; |
|
231 | + $gearingHint = $this->config->get('WBQualityConstraintsSparqlHasWikibaseSupport') ? |
|
232 | + ' hint:Prior hint:gearing "forward".' : ''; |
|
234 | 233 | |
235 | 234 | $metadatas = []; |
236 | 235 | |
237 | - foreach ( array_chunk( $classes, 20 ) as $classesChunk ) { |
|
238 | - $classesValues = implode( ' ', array_map( |
|
239 | - function( $class ) { |
|
240 | - return 'wd:' . $class; |
|
236 | + foreach (array_chunk($classes, 20) as $classesChunk) { |
|
237 | + $classesValues = implode(' ', array_map( |
|
238 | + function($class) { |
|
239 | + return 'wd:'.$class; |
|
241 | 240 | }, |
242 | 241 | $classesChunk |
243 | - ) ); |
|
242 | + )); |
|
244 | 243 | |
245 | 244 | $query = <<<EOF |
246 | 245 | ASK { |
@@ -250,19 +249,19 @@ discard block |
||
250 | 249 | } |
251 | 250 | EOF; |
252 | 251 | |
253 | - $result = $this->runQuery( $query ); |
|
252 | + $result = $this->runQuery($query); |
|
254 | 253 | $metadatas[] = $result->getMetadata(); |
255 | - if ( $result->getArray()['boolean'] ) { |
|
254 | + if ($result->getArray()['boolean']) { |
|
256 | 255 | return new CachedBool( |
257 | 256 | true, |
258 | - Metadata::merge( $metadatas ) |
|
257 | + Metadata::merge($metadatas) |
|
259 | 258 | ); |
260 | 259 | } |
261 | 260 | } |
262 | 261 | |
263 | 262 | return new CachedBool( |
264 | 263 | false, |
265 | - Metadata::merge( $metadatas ) |
|
264 | + Metadata::merge($metadatas) |
|
266 | 265 | ); |
267 | 266 | } |
268 | 267 | |
@@ -278,10 +277,10 @@ discard block |
||
278 | 277 | $ignoreDeprecatedStatements |
279 | 278 | ) { |
280 | 279 | $pid = $statement->getPropertyId()->serialize(); |
281 | - $guid = str_replace( '$', '-', $statement->getGuid() ); |
|
280 | + $guid = str_replace('$', '-', $statement->getGuid()); |
|
282 | 281 | |
283 | 282 | $deprecatedFilter = ''; |
284 | - if ( $ignoreDeprecatedStatements ) { |
|
283 | + if ($ignoreDeprecatedStatements) { |
|
285 | 284 | $deprecatedFilter = 'MINUS { ?otherStatement wikibase:rank wikibase:DeprecatedRank. }'; |
286 | 285 | } |
287 | 286 | |
@@ -300,9 +299,9 @@ discard block |
||
300 | 299 | LIMIT 10 |
301 | 300 | EOF; |
302 | 301 | |
303 | - $result = $this->runQuery( $query ); |
|
302 | + $result = $this->runQuery($query); |
|
304 | 303 | |
305 | - return $this->getOtherEntities( $result ); |
|
304 | + return $this->getOtherEntities($result); |
|
306 | 305 | } |
307 | 306 | |
308 | 307 | /** |
@@ -327,16 +326,15 @@ discard block |
||
327 | 326 | $dataType = $this->propertyDataTypeLookup->getDataTypeIdForProperty( |
328 | 327 | $snak->getPropertyId() |
329 | 328 | ); |
330 | - list( $value, $isFullValue ) = $this->getRdfLiteral( $dataType, $dataValue ); |
|
331 | - if ( $isFullValue ) { |
|
329 | + list($value, $isFullValue) = $this->getRdfLiteral($dataType, $dataValue); |
|
330 | + if ($isFullValue) { |
|
332 | 331 | $prefix .= 'v'; |
333 | 332 | } |
334 | 333 | $path = $type === Context::TYPE_QUALIFIER ? |
335 | - "$prefix:$pid" : |
|
336 | - "prov:wasDerivedFrom/$prefix:$pid"; |
|
334 | + "$prefix:$pid" : "prov:wasDerivedFrom/$prefix:$pid"; |
|
337 | 335 | |
338 | 336 | $deprecatedFilter = ''; |
339 | - if ( $ignoreDeprecatedStatements ) { |
|
337 | + if ($ignoreDeprecatedStatements) { |
|
340 | 338 | $deprecatedFilter = <<< EOF |
341 | 339 | MINUS { ?otherStatement wikibase:rank wikibase:DeprecatedRank. } |
342 | 340 | EOF; |
@@ -356,9 +354,9 @@ discard block |
||
356 | 354 | LIMIT 10 |
357 | 355 | EOF; |
358 | 356 | |
359 | - $result = $this->runQuery( $query ); |
|
357 | + $result = $this->runQuery($query); |
|
360 | 358 | |
361 | - return $this->getOtherEntities( $result ); |
|
359 | + return $this->getOtherEntities($result); |
|
362 | 360 | } |
363 | 361 | |
364 | 362 | /** |
@@ -368,8 +366,8 @@ discard block |
||
368 | 366 | * |
369 | 367 | * @return string |
370 | 368 | */ |
371 | - private function stringLiteral( $text ) { |
|
372 | - return '"' . strtr( $text, [ '"' => '\\"', '\\' => '\\\\' ] ) . '"'; |
|
369 | + private function stringLiteral($text) { |
|
370 | + return '"'.strtr($text, ['"' => '\\"', '\\' => '\\\\']).'"'; |
|
373 | 371 | } |
374 | 372 | |
375 | 373 | /** |
@@ -379,18 +377,18 @@ discard block |
||
379 | 377 | * |
380 | 378 | * @return CachedEntityIds |
381 | 379 | */ |
382 | - private function getOtherEntities( CachedQueryResults $results ) { |
|
383 | - return new CachedEntityIds( array_map( |
|
384 | - function ( $resultBindings ) { |
|
380 | + private function getOtherEntities(CachedQueryResults $results) { |
|
381 | + return new CachedEntityIds(array_map( |
|
382 | + function($resultBindings) { |
|
385 | 383 | $entityIRI = $resultBindings['otherEntity']['value']; |
386 | - foreach ( $this->entityPrefixes as $entityPrefix ) { |
|
387 | - $entityPrefixLength = strlen( $entityPrefix ); |
|
388 | - if ( substr( $entityIRI, 0, $entityPrefixLength ) === $entityPrefix ) { |
|
384 | + foreach ($this->entityPrefixes as $entityPrefix) { |
|
385 | + $entityPrefixLength = strlen($entityPrefix); |
|
386 | + if (substr($entityIRI, 0, $entityPrefixLength) === $entityPrefix) { |
|
389 | 387 | try { |
390 | 388 | return $this->entityIdParser->parse( |
391 | - substr( $entityIRI, $entityPrefixLength ) |
|
389 | + substr($entityIRI, $entityPrefixLength) |
|
392 | 390 | ); |
393 | - } catch ( EntityIdParsingException $e ) { |
|
391 | + } catch (EntityIdParsingException $e) { |
|
394 | 392 | // fall through |
395 | 393 | } |
396 | 394 | } |
@@ -401,7 +399,7 @@ discard block |
||
401 | 399 | return null; |
402 | 400 | }, |
403 | 401 | $results->getArray()['results']['bindings'] |
404 | - ), $results->getMetadata() ); |
|
402 | + ), $results->getMetadata()); |
|
405 | 403 | } |
406 | 404 | |
407 | 405 | // @codingStandardsIgnoreStart cyclomatic complexity of this function is too high |
@@ -414,49 +412,49 @@ discard block |
||
414 | 412 | * @return array the literal or IRI as a string in SPARQL syntax, |
415 | 413 | * and a boolean indicating whether it refers to a full value node or not |
416 | 414 | */ |
417 | - private function getRdfLiteral( $dataType, DataValue $dataValue ) { |
|
418 | - switch ( $dataType ) { |
|
415 | + private function getRdfLiteral($dataType, DataValue $dataValue) { |
|
416 | + switch ($dataType) { |
|
419 | 417 | case 'string': |
420 | 418 | case 'external-id': |
421 | - return [ $this->stringLiteral( $dataValue->getValue() ), false ]; |
|
419 | + return [$this->stringLiteral($dataValue->getValue()), false]; |
|
422 | 420 | case 'commonsMedia': |
423 | - $url = $this->rdfVocabulary->getMediaFileURI( $dataValue->getValue() ); |
|
424 | - return [ '<' . $url . '>', false ]; |
|
421 | + $url = $this->rdfVocabulary->getMediaFileURI($dataValue->getValue()); |
|
422 | + return ['<'.$url.'>', false]; |
|
425 | 423 | case 'geo-shape': |
426 | - $url = $this->rdfVocabulary->getGeoShapeURI( $dataValue->getValue() ); |
|
427 | - return [ '<' . $url . '>', false ]; |
|
424 | + $url = $this->rdfVocabulary->getGeoShapeURI($dataValue->getValue()); |
|
425 | + return ['<'.$url.'>', false]; |
|
428 | 426 | case 'tabular-data': |
429 | - $url = $this->rdfVocabulary->getTabularDataURI( $dataValue->getValue() ); |
|
430 | - return [ '<' . $url . '>', false ]; |
|
427 | + $url = $this->rdfVocabulary->getTabularDataURI($dataValue->getValue()); |
|
428 | + return ['<'.$url.'>', false]; |
|
431 | 429 | case 'url': |
432 | 430 | $url = $dataValue->getValue(); |
433 | - if ( !preg_match( '/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url ) ) { |
|
431 | + if (!preg_match('/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url)) { |
|
434 | 432 | // not a valid URL for SPARQL (see SPARQL spec, production 139 IRIREF) |
435 | 433 | // such an URL should never reach us, so just throw |
436 | - throw new InvalidArgumentException( 'invalid URL: ' . $url ); |
|
434 | + throw new InvalidArgumentException('invalid URL: '.$url); |
|
437 | 435 | } |
438 | - return [ '<' . $url . '>', false ]; |
|
436 | + return ['<'.$url.'>', false]; |
|
439 | 437 | case 'wikibase-item': |
440 | 438 | case 'wikibase-property': |
441 | 439 | /** @var EntityIdValue $dataValue */ |
442 | 440 | '@phan-var EntityIdValue $dataValue'; |
443 | - return [ 'wd:' . $dataValue->getEntityId()->getSerialization(), false ]; |
|
441 | + return ['wd:'.$dataValue->getEntityId()->getSerialization(), false]; |
|
444 | 442 | case 'monolingualtext': |
445 | 443 | /** @var MonolingualTextValue $dataValue */ |
446 | 444 | '@phan-var MonolingualTextValue $dataValue'; |
447 | 445 | $lang = $dataValue->getLanguageCode(); |
448 | - if ( !preg_match( '/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang ) ) { |
|
446 | + if (!preg_match('/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang)) { |
|
449 | 447 | // not a valid language tag for SPARQL (see SPARQL spec, production 145 LANGTAG) |
450 | 448 | // such a language tag should never reach us, so just throw |
451 | - throw new InvalidArgumentException( 'invalid language tag: ' . $lang ); |
|
449 | + throw new InvalidArgumentException('invalid language tag: '.$lang); |
|
452 | 450 | } |
453 | - return [ $this->stringLiteral( $dataValue->getText() ) . '@' . $lang, false ]; |
|
451 | + return [$this->stringLiteral($dataValue->getText()).'@'.$lang, false]; |
|
454 | 452 | case 'globe-coordinate': |
455 | 453 | case 'quantity': |
456 | 454 | case 'time': |
457 | - return [ 'wdv:' . $dataValue->getHash(), true ]; |
|
455 | + return ['wdv:'.$dataValue->getHash(), true]; |
|
458 | 456 | default: |
459 | - throw new InvalidArgumentException( 'unknown data type: ' . $dataType ); |
|
457 | + throw new InvalidArgumentException('unknown data type: '.$dataType); |
|
460 | 458 | } |
461 | 459 | } |
462 | 460 | // @codingStandardsIgnoreEnd |
@@ -469,44 +467,44 @@ discard block |
||
469 | 467 | * @throws SparqlHelperException if the query times out or some other error occurs |
470 | 468 | * @throws ConstraintParameterException if the $regex is invalid |
471 | 469 | */ |
472 | - public function matchesRegularExpression( $text, $regex ) { |
|
470 | + public function matchesRegularExpression($text, $regex) { |
|
473 | 471 | // caching wrapper around matchesRegularExpressionWithSparql |
474 | 472 | |
475 | - $textHash = hash( 'sha256', $text ); |
|
473 | + $textHash = hash('sha256', $text); |
|
476 | 474 | $cacheKey = $this->cache->makeKey( |
477 | 475 | 'WikibaseQualityConstraints', // extension |
478 | 476 | 'regex', // action |
479 | 477 | 'WDQS-Java', // regex flavor |
480 | - hash( 'sha256', $regex ) |
|
478 | + hash('sha256', $regex) |
|
481 | 479 | ); |
482 | - $cacheMapSize = $this->config->get( 'WBQualityConstraintsFormatCacheMapSize' ); |
|
480 | + $cacheMapSize = $this->config->get('WBQualityConstraintsFormatCacheMapSize'); |
|
483 | 481 | |
484 | 482 | $cacheMapArray = $this->cache->getWithSetCallback( |
485 | 483 | $cacheKey, |
486 | 484 | WANObjectCache::TTL_DAY, |
487 | - function( $cacheMapArray ) use ( $text, $regex, $textHash, $cacheMapSize ) { |
|
485 | + function($cacheMapArray) use ($text, $regex, $textHash, $cacheMapSize) { |
|
488 | 486 | // Initialize the cache map if not set |
489 | - if ( $cacheMapArray === false ) { |
|
487 | + if ($cacheMapArray === false) { |
|
490 | 488 | $key = 'wikibase.quality.constraints.regex.cache.refresh.init'; |
491 | - $this->dataFactory->increment( $key ); |
|
489 | + $this->dataFactory->increment($key); |
|
492 | 490 | return []; |
493 | 491 | } |
494 | 492 | |
495 | 493 | $key = 'wikibase.quality.constraints.regex.cache.refresh'; |
496 | - $this->dataFactory->increment( $key ); |
|
497 | - $cacheMap = MapCacheLRU::newFromArray( $cacheMapArray, $cacheMapSize ); |
|
498 | - if ( $cacheMap->has( $textHash ) ) { |
|
494 | + $this->dataFactory->increment($key); |
|
495 | + $cacheMap = MapCacheLRU::newFromArray($cacheMapArray, $cacheMapSize); |
|
496 | + if ($cacheMap->has($textHash)) { |
|
499 | 497 | $key = 'wikibase.quality.constraints.regex.cache.refresh.hit'; |
500 | - $this->dataFactory->increment( $key ); |
|
501 | - $cacheMap->get( $textHash ); // ping cache |
|
498 | + $this->dataFactory->increment($key); |
|
499 | + $cacheMap->get($textHash); // ping cache |
|
502 | 500 | } else { |
503 | 501 | $key = 'wikibase.quality.constraints.regex.cache.refresh.miss'; |
504 | - $this->dataFactory->increment( $key ); |
|
502 | + $this->dataFactory->increment($key); |
|
505 | 503 | try { |
506 | - $matches = $this->matchesRegularExpressionWithSparql( $text, $regex ); |
|
507 | - } catch ( ConstraintParameterException $e ) { |
|
508 | - $matches = $this->serializeConstraintParameterException( $e ); |
|
509 | - } catch ( SparqlHelperException $e ) { |
|
504 | + $matches = $this->matchesRegularExpressionWithSparql($text, $regex); |
|
505 | + } catch (ConstraintParameterException $e) { |
|
506 | + $matches = $this->serializeConstraintParameterException($e); |
|
507 | + } catch (SparqlHelperException $e) { |
|
510 | 508 | // don’t cache this |
511 | 509 | return $cacheMap->toArray(); |
512 | 510 | } |
@@ -530,42 +528,42 @@ discard block |
||
530 | 528 | ] |
531 | 529 | ); |
532 | 530 | |
533 | - if ( isset( $cacheMapArray[$textHash] ) ) { |
|
531 | + if (isset($cacheMapArray[$textHash])) { |
|
534 | 532 | $key = 'wikibase.quality.constraints.regex.cache.hit'; |
535 | - $this->dataFactory->increment( $key ); |
|
533 | + $this->dataFactory->increment($key); |
|
536 | 534 | $matches = $cacheMapArray[$textHash]; |
537 | - if ( is_bool( $matches ) ) { |
|
535 | + if (is_bool($matches)) { |
|
538 | 536 | return $matches; |
539 | - } elseif ( is_array( $matches ) && |
|
540 | - $matches['type'] == ConstraintParameterException::class ) { |
|
541 | - throw $this->deserializeConstraintParameterException( $matches ); |
|
537 | + } elseif (is_array($matches) && |
|
538 | + $matches['type'] == ConstraintParameterException::class) { |
|
539 | + throw $this->deserializeConstraintParameterException($matches); |
|
542 | 540 | } else { |
543 | 541 | throw new MWException( |
544 | - 'Value of unknown type in object cache (' . |
|
545 | - 'cache key: ' . $cacheKey . ', ' . |
|
546 | - 'cache map key: ' . $textHash . ', ' . |
|
547 | - 'value type: ' . gettype( $matches ) . ')' |
|
542 | + 'Value of unknown type in object cache ('. |
|
543 | + 'cache key: '.$cacheKey.', '. |
|
544 | + 'cache map key: '.$textHash.', '. |
|
545 | + 'value type: '.gettype($matches).')' |
|
548 | 546 | ); |
549 | 547 | } |
550 | 548 | } else { |
551 | 549 | $key = 'wikibase.quality.constraints.regex.cache.miss'; |
552 | - $this->dataFactory->increment( $key ); |
|
553 | - return $this->matchesRegularExpressionWithSparql( $text, $regex ); |
|
550 | + $this->dataFactory->increment($key); |
|
551 | + return $this->matchesRegularExpressionWithSparql($text, $regex); |
|
554 | 552 | } |
555 | 553 | } |
556 | 554 | |
557 | - private function serializeConstraintParameterException( ConstraintParameterException $cpe ) { |
|
555 | + private function serializeConstraintParameterException(ConstraintParameterException $cpe) { |
|
558 | 556 | return [ |
559 | 557 | 'type' => ConstraintParameterException::class, |
560 | - 'violationMessage' => $this->violationMessageSerializer->serialize( $cpe->getViolationMessage() ), |
|
558 | + 'violationMessage' => $this->violationMessageSerializer->serialize($cpe->getViolationMessage()), |
|
561 | 559 | ]; |
562 | 560 | } |
563 | 561 | |
564 | - private function deserializeConstraintParameterException( array $serialization ) { |
|
562 | + private function deserializeConstraintParameterException(array $serialization) { |
|
565 | 563 | $message = $this->violationMessageDeserializer->deserialize( |
566 | 564 | $serialization['violationMessage'] |
567 | 565 | ); |
568 | - return new ConstraintParameterException( $message ); |
|
566 | + return new ConstraintParameterException($message); |
|
569 | 567 | } |
570 | 568 | |
571 | 569 | /** |
@@ -579,25 +577,25 @@ discard block |
||
579 | 577 | * @throws SparqlHelperException if the query times out or some other error occurs |
580 | 578 | * @throws ConstraintParameterException if the $regex is invalid |
581 | 579 | */ |
582 | - public function matchesRegularExpressionWithSparql( $text, $regex ) { |
|
583 | - $textStringLiteral = $this->stringLiteral( $text ); |
|
584 | - $regexStringLiteral = $this->stringLiteral( '^(?:' . $regex . ')$' ); |
|
580 | + public function matchesRegularExpressionWithSparql($text, $regex) { |
|
581 | + $textStringLiteral = $this->stringLiteral($text); |
|
582 | + $regexStringLiteral = $this->stringLiteral('^(?:'.$regex.')$'); |
|
585 | 583 | |
586 | 584 | $query = <<<EOF |
587 | 585 | SELECT (REGEX($textStringLiteral, $regexStringLiteral) AS ?matches) {} |
588 | 586 | EOF; |
589 | 587 | |
590 | - $result = $this->runQuery( $query, false ); |
|
588 | + $result = $this->runQuery($query, false); |
|
591 | 589 | |
592 | 590 | $vars = $result->getArray()['results']['bindings'][0]; |
593 | - if ( array_key_exists( 'matches', $vars ) ) { |
|
591 | + if (array_key_exists('matches', $vars)) { |
|
594 | 592 | // true or false ⇒ regex okay, text matches or not |
595 | 593 | return $vars['matches']['value'] === 'true'; |
596 | 594 | } else { |
597 | 595 | // empty result: regex broken |
598 | 596 | throw new ConstraintParameterException( |
599 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) ) |
|
600 | - ->withInlineCode( $regex, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
597 | + (new ViolationMessage('wbqc-violation-message-parameter-regex')) |
|
598 | + ->withInlineCode($regex, Role::CONSTRAINT_PARAMETER_VALUE) |
|
601 | 599 | ); |
602 | 600 | } |
603 | 601 | } |
@@ -609,14 +607,14 @@ discard block |
||
609 | 607 | * |
610 | 608 | * @return boolean |
611 | 609 | */ |
612 | - public function isTimeout( $responseContent ) { |
|
613 | - $timeoutRegex = implode( '|', array_map( |
|
614 | - function ( $fqn ) { |
|
615 | - return preg_quote( $fqn, '/' ); |
|
610 | + public function isTimeout($responseContent) { |
|
611 | + $timeoutRegex = implode('|', array_map( |
|
612 | + function($fqn) { |
|
613 | + return preg_quote($fqn, '/'); |
|
616 | 614 | }, |
617 | - $this->config->get( 'WBQualityConstraintsSparqlTimeoutExceptionClasses' ) |
|
618 | - ) ); |
|
619 | - return (bool)preg_match( '/' . $timeoutRegex . '/', $responseContent ); |
|
615 | + $this->config->get('WBQualityConstraintsSparqlTimeoutExceptionClasses') |
|
616 | + )); |
|
617 | + return (bool) preg_match('/'.$timeoutRegex.'/', $responseContent); |
|
620 | 618 | } |
621 | 619 | |
622 | 620 | /** |
@@ -628,18 +626,18 @@ discard block |
||
628 | 626 | * @return int|boolean the max-age (in seconds) |
629 | 627 | * or a plain boolean if no max-age can be determined |
630 | 628 | */ |
631 | - public function getCacheMaxAge( $responseHeaders ) { |
|
629 | + public function getCacheMaxAge($responseHeaders) { |
|
632 | 630 | if ( |
633 | - array_key_exists( 'x-cache-status', $responseHeaders ) && |
|
634 | - preg_match( '/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0] ) |
|
631 | + array_key_exists('x-cache-status', $responseHeaders) && |
|
632 | + preg_match('/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0]) |
|
635 | 633 | ) { |
636 | 634 | $maxage = []; |
637 | 635 | if ( |
638 | - array_key_exists( 'cache-control', $responseHeaders ) && |
|
639 | - preg_match( '/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage ) |
|
636 | + array_key_exists('cache-control', $responseHeaders) && |
|
637 | + preg_match('/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage) |
|
640 | 638 | ) { |
641 | 639 | // @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset |
642 | - return intval( $maxage[1] ); |
|
640 | + return intval($maxage[1]); |
|
643 | 641 | } else { |
644 | 642 | return true; |
645 | 643 | } |
@@ -660,34 +658,34 @@ discard block |
||
660 | 658 | * or SparlHelper::EMPTY_RETRY_AFTER if there is an empty Retry-After |
661 | 659 | * or SparlHelper::INVALID_RETRY_AFTER if there is something wrong with the format |
662 | 660 | */ |
663 | - public function getThrottling( MWHttpRequest $request ) { |
|
664 | - $retryAfterValue = $request->getResponseHeader( 'Retry-After' ); |
|
665 | - if ( $retryAfterValue === null ) { |
|
661 | + public function getThrottling(MWHttpRequest $request) { |
|
662 | + $retryAfterValue = $request->getResponseHeader('Retry-After'); |
|
663 | + if ($retryAfterValue === null) { |
|
666 | 664 | return self::NO_RETRY_AFTER; |
667 | 665 | } |
668 | 666 | |
669 | - $trimmedRetryAfterValue = trim( $retryAfterValue ); |
|
670 | - if ( empty( $trimmedRetryAfterValue ) ) { |
|
667 | + $trimmedRetryAfterValue = trim($retryAfterValue); |
|
668 | + if (empty($trimmedRetryAfterValue)) { |
|
671 | 669 | return self::EMPTY_RETRY_AFTER; |
672 | 670 | } |
673 | 671 | |
674 | - if ( is_numeric( $trimmedRetryAfterValue ) ) { |
|
675 | - $delaySeconds = (int)$trimmedRetryAfterValue; |
|
676 | - if ( $delaySeconds >= 0 ) { |
|
677 | - return $this->getTimestampInFuture( new DateInterval( 'PT' . $delaySeconds . 'S' ) ); |
|
672 | + if (is_numeric($trimmedRetryAfterValue)) { |
|
673 | + $delaySeconds = (int) $trimmedRetryAfterValue; |
|
674 | + if ($delaySeconds >= 0) { |
|
675 | + return $this->getTimestampInFuture(new DateInterval('PT'.$delaySeconds.'S')); |
|
678 | 676 | } |
679 | 677 | } else { |
680 | - $return = strtotime( $trimmedRetryAfterValue ); |
|
681 | - if ( !empty( $return ) ) { |
|
682 | - return new ConvertibleTimestamp( $return ); |
|
678 | + $return = strtotime($trimmedRetryAfterValue); |
|
679 | + if (!empty($return)) { |
|
680 | + return new ConvertibleTimestamp($return); |
|
683 | 681 | } |
684 | 682 | } |
685 | 683 | return self::INVALID_RETRY_AFTER; |
686 | 684 | } |
687 | 685 | |
688 | - private function getTimestampInFuture( DateInterval $delta ) { |
|
686 | + private function getTimestampInFuture(DateInterval $delta) { |
|
689 | 687 | $now = new ConvertibleTimestamp(); |
690 | - return new ConvertibleTimestamp( $now->timestamp->add( $delta ) ); |
|
688 | + return new ConvertibleTimestamp($now->timestamp->add($delta)); |
|
691 | 689 | } |
692 | 690 | |
693 | 691 | /** |
@@ -701,97 +699,96 @@ discard block |
||
701 | 699 | * |
702 | 700 | * @throws SparqlHelperException if the query times out or some other error occurs |
703 | 701 | */ |
704 | - public function runQuery( $query, $needsPrefixes = true ) { |
|
702 | + public function runQuery($query, $needsPrefixes = true) { |
|
705 | 703 | |
706 | - if ( $this->throttlingLock->isLocked( self::EXPIRY_LOCK_ID ) ) { |
|
707 | - $this->dataFactory->increment( 'wikibase.quality.constraints.sparql.throttling' ); |
|
704 | + if ($this->throttlingLock->isLocked(self::EXPIRY_LOCK_ID)) { |
|
705 | + $this->dataFactory->increment('wikibase.quality.constraints.sparql.throttling'); |
|
708 | 706 | throw new TooManySparqlRequestsException(); |
709 | 707 | } |
710 | 708 | |
711 | - $endpoint = $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ); |
|
712 | - $maxQueryTimeMillis = $this->config->get( 'WBQualityConstraintsSparqlMaxMillis' ); |
|
713 | - $fallbackBlockDuration = (int)$this->config->get( 'WBQualityConstraintsSparqlThrottlingFallbackDuration' ); |
|
709 | + $endpoint = $this->config->get('WBQualityConstraintsSparqlEndpoint'); |
|
710 | + $maxQueryTimeMillis = $this->config->get('WBQualityConstraintsSparqlMaxMillis'); |
|
711 | + $fallbackBlockDuration = (int) $this->config->get('WBQualityConstraintsSparqlThrottlingFallbackDuration'); |
|
714 | 712 | |
715 | - if ( $fallbackBlockDuration < 0 ) { |
|
716 | - throw new InvalidArgumentException( 'Fallback duration must be positive int but is: ' . |
|
717 | - $fallbackBlockDuration ); |
|
713 | + if ($fallbackBlockDuration < 0) { |
|
714 | + throw new InvalidArgumentException('Fallback duration must be positive int but is: '. |
|
715 | + $fallbackBlockDuration); |
|
718 | 716 | } |
719 | 717 | |
720 | - if ( $this->config->get( 'WBQualityConstraintsSparqlHasWikibaseSupport' ) ) { |
|
718 | + if ($this->config->get('WBQualityConstraintsSparqlHasWikibaseSupport')) { |
|
721 | 719 | $needsPrefixes = false; |
722 | 720 | } |
723 | 721 | |
724 | - if ( $needsPrefixes ) { |
|
725 | - $query = $this->prefixes . $query; |
|
722 | + if ($needsPrefixes) { |
|
723 | + $query = $this->prefixes.$query; |
|
726 | 724 | } |
727 | - $query = "#wbqc\n" . $query; |
|
725 | + $query = "#wbqc\n".$query; |
|
728 | 726 | |
729 | - $url = $endpoint . '?' . http_build_query( |
|
727 | + $url = $endpoint.'?'.http_build_query( |
|
730 | 728 | [ |
731 | 729 | 'query' => $query, |
732 | 730 | 'format' => 'json', |
733 | 731 | 'maxQueryTimeMillis' => $maxQueryTimeMillis, |
734 | 732 | ], |
735 | - null, ini_get( 'arg_separator.output' ), |
|
733 | + null, ini_get('arg_separator.output'), |
|
736 | 734 | // encode spaces with %20, not + |
737 | 735 | PHP_QUERY_RFC3986 |
738 | 736 | ); |
739 | 737 | |
740 | 738 | $options = [ |
741 | 739 | 'method' => 'GET', |
742 | - 'timeout' => (int)round( ( $maxQueryTimeMillis + 1000 ) / 1000 ), |
|
740 | + 'timeout' => (int) round(($maxQueryTimeMillis + 1000) / 1000), |
|
743 | 741 | 'connectTimeout' => 'default', |
744 | 742 | 'userAgent' => $this->defaultUserAgent, |
745 | 743 | ]; |
746 | - $request = $this->requestFactory->create( $url, $options ); |
|
747 | - $startTime = microtime( true ); |
|
744 | + $request = $this->requestFactory->create($url, $options); |
|
745 | + $startTime = microtime(true); |
|
748 | 746 | $status = $request->execute(); |
749 | - $endTime = microtime( true ); |
|
747 | + $endTime = microtime(true); |
|
750 | 748 | $this->dataFactory->timing( |
751 | 749 | 'wikibase.quality.constraints.sparql.timing', |
752 | - ( $endTime - $startTime ) * 1000 |
|
750 | + ($endTime - $startTime) * 1000 |
|
753 | 751 | ); |
754 | 752 | |
755 | - if ( $request->getStatus() === self::HTTP_TOO_MANY_REQUESTS ) { |
|
756 | - $this->dataFactory->increment( 'wikibase.quality.constraints.sparql.throttling' ); |
|
757 | - $throttlingUntil = $this->getThrottling( $request ); |
|
758 | - if ( !( $throttlingUntil instanceof ConvertibleTimestamp ) ) { |
|
759 | - $this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid( $request ); |
|
753 | + if ($request->getStatus() === self::HTTP_TOO_MANY_REQUESTS) { |
|
754 | + $this->dataFactory->increment('wikibase.quality.constraints.sparql.throttling'); |
|
755 | + $throttlingUntil = $this->getThrottling($request); |
|
756 | + if (!($throttlingUntil instanceof ConvertibleTimestamp)) { |
|
757 | + $this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid($request); |
|
760 | 758 | $this->throttlingLock->lock( |
761 | 759 | self::EXPIRY_LOCK_ID, |
762 | - $this->getTimestampInFuture( new DateInterval( 'PT' . $fallbackBlockDuration . 'S' ) ) |
|
760 | + $this->getTimestampInFuture(new DateInterval('PT'.$fallbackBlockDuration.'S')) |
|
763 | 761 | ); |
764 | 762 | } else { |
765 | - $this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent( $throttlingUntil, $request ); |
|
766 | - $this->throttlingLock->lock( self::EXPIRY_LOCK_ID, $throttlingUntil ); |
|
763 | + $this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent($throttlingUntil, $request); |
|
764 | + $this->throttlingLock->lock(self::EXPIRY_LOCK_ID, $throttlingUntil); |
|
767 | 765 | } |
768 | 766 | throw new TooManySparqlRequestsException(); |
769 | 767 | } |
770 | 768 | |
771 | - $maxAge = $this->getCacheMaxAge( $request->getResponseHeaders() ); |
|
772 | - if ( $maxAge ) { |
|
773 | - $this->dataFactory->increment( 'wikibase.quality.constraints.sparql.cached' ); |
|
769 | + $maxAge = $this->getCacheMaxAge($request->getResponseHeaders()); |
|
770 | + if ($maxAge) { |
|
771 | + $this->dataFactory->increment('wikibase.quality.constraints.sparql.cached'); |
|
774 | 772 | } |
775 | 773 | |
776 | - if ( $status->isOK() ) { |
|
774 | + if ($status->isOK()) { |
|
777 | 775 | $json = $request->getContent(); |
778 | - $arr = json_decode( $json, true ); |
|
776 | + $arr = json_decode($json, true); |
|
779 | 777 | return new CachedQueryResults( |
780 | 778 | $arr, |
781 | 779 | Metadata::ofCachingMetadata( |
782 | 780 | $maxAge ? |
783 | - CachingMetadata::ofMaximumAgeInSeconds( $maxAge ) : |
|
784 | - CachingMetadata::fresh() |
|
781 | + CachingMetadata::ofMaximumAgeInSeconds($maxAge) : CachingMetadata::fresh() |
|
785 | 782 | ) |
786 | 783 | ); |
787 | 784 | } else { |
788 | - $this->dataFactory->increment( 'wikibase.quality.constraints.sparql.error' ); |
|
785 | + $this->dataFactory->increment('wikibase.quality.constraints.sparql.error'); |
|
789 | 786 | |
790 | 787 | $this->dataFactory->increment( |
791 | 788 | "wikibase.quality.constraints.sparql.error.http.{$request->getStatus()}" |
792 | 789 | ); |
793 | 790 | |
794 | - if ( $this->isTimeout( $request->getContent() ) ) { |
|
791 | + if ($this->isTimeout($request->getContent())) { |
|
795 | 792 | $this->dataFactory->increment( |
796 | 793 | 'wikibase.quality.constraints.sparql.error.timeout' |
797 | 794 | ); |