@@ -85,13 +85,13 @@ discard block |
||
85 | 85 | |
86 | 86 | $language = WikibaseRepo::getUserLanguage(); |
87 | 87 | $formatterOptions = new FormatterOptions(); |
88 | - $formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() ); |
|
89 | - $valueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions ); |
|
88 | + $formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode()); |
|
89 | + $valueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions); |
|
90 | 90 | |
91 | 91 | $entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory(); |
92 | - $entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $language ); |
|
92 | + $entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($language); |
|
93 | 93 | $entityIdLabelFormatterFactory = new EntityIdLabelFormatterFactory(); |
94 | - $entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $language ); |
|
94 | + $entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($language); |
|
95 | 95 | |
96 | 96 | $checkResultsRenderer = new CheckResultsRenderer( |
97 | 97 | $entityTitleLookup, |
@@ -109,7 +109,7 @@ discard block |
||
109 | 109 | $name, |
110 | 110 | $entityIdParser, |
111 | 111 | $statementGuidValidator, |
112 | - $repo->getApiHelperFactory( $main->getContext() ), |
|
112 | + $repo->getApiHelperFactory($main->getContext()), |
|
113 | 113 | $resultsSource, |
114 | 114 | $checkResultsRenderer, |
115 | 115 | $dataFactory |
@@ -136,11 +136,11 @@ discard block |
||
136 | 136 | CheckResultsRenderer $checkResultsRenderer, |
137 | 137 | IBufferingStatsdDataFactory $dataFactory |
138 | 138 | ) { |
139 | - parent::__construct( $main, $name ); |
|
139 | + parent::__construct($main, $name); |
|
140 | 140 | $this->entityIdParser = $entityIdParser; |
141 | 141 | $this->statementGuidValidator = $statementGuidValidator; |
142 | - $this->resultBuilder = $apiHelperFactory->getResultBuilder( $this ); |
|
143 | - $this->errorReporter = $apiHelperFactory->getErrorReporter( $this ); |
|
142 | + $this->resultBuilder = $apiHelperFactory->getResultBuilder($this); |
|
143 | + $this->errorReporter = $apiHelperFactory->getErrorReporter($this); |
|
144 | 144 | $this->resultsSource = $resultsSource; |
145 | 145 | $this->checkResultsRenderer = $checkResultsRenderer; |
146 | 146 | $this->dataFactory = $dataFactory; |
@@ -156,9 +156,9 @@ discard block |
||
156 | 156 | |
157 | 157 | $params = $this->extractRequestParams(); |
158 | 158 | |
159 | - $this->validateParameters( $params ); |
|
160 | - $entityIds = $this->parseEntityIds( $params ); |
|
161 | - $claimIds = $this->parseClaimIds( $params ); |
|
159 | + $this->validateParameters($params); |
|
160 | + $entityIds = $this->parseEntityIds($params); |
|
161 | + $claimIds = $this->parseClaimIds($params); |
|
162 | 162 | $constraintIDs = $params[self::PARAM_CONSTRAINT_ID]; |
163 | 163 | $statuses = $params[self::PARAM_STATUS]; |
164 | 164 | |
@@ -174,7 +174,7 @@ discard block |
||
174 | 174 | ) |
175 | 175 | )->getArray() |
176 | 176 | ); |
177 | - $this->resultBuilder->markSuccess( 1 ); |
|
177 | + $this->resultBuilder->markSuccess(1); |
|
178 | 178 | } |
179 | 179 | |
180 | 180 | /** |
@@ -182,24 +182,24 @@ discard block |
||
182 | 182 | * |
183 | 183 | * @return EntityId[] |
184 | 184 | */ |
185 | - private function parseEntityIds( array $params ) { |
|
185 | + private function parseEntityIds(array $params) { |
|
186 | 186 | $ids = $params[self::PARAM_ID]; |
187 | 187 | |
188 | - if ( $ids === null ) { |
|
188 | + if ($ids === null) { |
|
189 | 189 | return []; |
190 | - } elseif ( $ids === [] ) { |
|
190 | + } elseif ($ids === []) { |
|
191 | 191 | $this->errorReporter->dieError( |
192 | - 'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
192 | + 'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
193 | 193 | } |
194 | 194 | |
195 | - return array_map( function ( $id ) { |
|
195 | + return array_map(function($id) { |
|
196 | 196 | try { |
197 | - return $this->entityIdParser->parse( $id ); |
|
198 | - } catch ( EntityIdParsingException $e ) { |
|
197 | + return $this->entityIdParser->parse($id); |
|
198 | + } catch (EntityIdParsingException $e) { |
|
199 | 199 | $this->errorReporter->dieError( |
200 | - "Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] ); |
|
200 | + "Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] ); |
|
201 | 201 | } |
202 | - }, $ids ); |
|
202 | + }, $ids); |
|
203 | 203 | } |
204 | 204 | |
205 | 205 | /** |
@@ -207,35 +207,35 @@ discard block |
||
207 | 207 | * |
208 | 208 | * @return string[] |
209 | 209 | */ |
210 | - private function parseClaimIds( array $params ) { |
|
210 | + private function parseClaimIds(array $params) { |
|
211 | 211 | $ids = $params[self::PARAM_CLAIM_ID]; |
212 | 212 | |
213 | - if ( $ids === null ) { |
|
213 | + if ($ids === null) { |
|
214 | 214 | return []; |
215 | - } elseif ( $ids === [] ) { |
|
215 | + } elseif ($ids === []) { |
|
216 | 216 | $this->errorReporter->dieError( |
217 | - 'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
217 | + 'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
218 | 218 | } |
219 | 219 | |
220 | - foreach ( $ids as $id ) { |
|
221 | - if ( !$this->statementGuidValidator->validate( $id ) ) { |
|
220 | + foreach ($ids as $id) { |
|
221 | + if (!$this->statementGuidValidator->validate($id)) { |
|
222 | 222 | $this->errorReporter->dieError( |
223 | - "Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] ); |
|
223 | + "Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] ); |
|
224 | 224 | } |
225 | 225 | } |
226 | 226 | |
227 | 227 | return $ids; |
228 | 228 | } |
229 | 229 | |
230 | - private function validateParameters( array $params ) { |
|
231 | - if ( $params[self::PARAM_CONSTRAINT_ID] !== null |
|
232 | - && empty( $params[self::PARAM_CONSTRAINT_ID] ) |
|
230 | + private function validateParameters(array $params) { |
|
231 | + if ($params[self::PARAM_CONSTRAINT_ID] !== null |
|
232 | + && empty($params[self::PARAM_CONSTRAINT_ID]) |
|
233 | 233 | ) { |
234 | 234 | $paramConstraintId = self::PARAM_CONSTRAINT_ID; |
235 | 235 | $this->errorReporter->dieError( |
236 | 236 | "If $paramConstraintId is specified, it must be nonempty.", 'no-data' ); |
237 | 237 | } |
238 | - if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) { |
|
238 | + if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) { |
|
239 | 239 | $paramId = self::PARAM_ID; |
240 | 240 | $paramClaimId = self::PARAM_CLAIM_ID; |
241 | 241 | $this->errorReporter->dieError( |
@@ -276,7 +276,7 @@ discard block |
||
276 | 276 | ], |
277 | 277 | ApiBase::PARAM_ISMULTI => true, |
278 | 278 | ApiBase::PARAM_ALL => true, |
279 | - ApiBase::PARAM_DFLT => implode( '|', CachingResultsSource::CACHED_STATUSES ), |
|
279 | + ApiBase::PARAM_DFLT => implode('|', CachingResultsSource::CACHED_STATUSES), |
|
280 | 280 | ApiBase::PARAM_HELP_MSG_PER_VALUE => [], |
281 | 281 | ], |
282 | 282 | ]; |
@@ -77,16 +77,16 @@ discard block |
||
77 | 77 | DelegatingConstraintChecker $delegatingConstraintChecker |
78 | 78 | ): self { |
79 | 79 | $repo = WikibaseRepo::getDefaultInstance(); |
80 | - $helperFactory = $repo->getApiHelperFactory( $main->getContext() ); |
|
80 | + $helperFactory = $repo->getApiHelperFactory($main->getContext()); |
|
81 | 81 | $language = WikibaseRepo::getUserLanguage(); |
82 | 82 | |
83 | 83 | $entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory(); |
84 | 84 | $entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory |
85 | - ->getEntityIdFormatter( $language ); |
|
85 | + ->getEntityIdFormatter($language); |
|
86 | 86 | $formatterOptions = new FormatterOptions(); |
87 | - $formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() ); |
|
87 | + $formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode()); |
|
88 | 88 | $dataValueFormatter = $valueFormatterFactory |
89 | - ->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions ); |
|
89 | + ->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions); |
|
90 | 90 | $violationMessageRenderer = new MultilingualTextViolationMessageRenderer( |
91 | 91 | $entityIdHtmlLinkFormatter, |
92 | 92 | $dataValueFormatter, |
@@ -122,9 +122,9 @@ discard block |
||
122 | 122 | StatementGuidParser $statementGuidParser, |
123 | 123 | IBufferingStatsdDataFactory $dataFactory |
124 | 124 | ) { |
125 | - parent::__construct( $main, $name ); |
|
125 | + parent::__construct($main, $name); |
|
126 | 126 | |
127 | - $this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this ); |
|
127 | + $this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this); |
|
128 | 128 | $this->delegatingConstraintChecker = $delegatingConstraintChecker; |
129 | 129 | $this->violationMessageRenderer = $violationMessageRenderer; |
130 | 130 | $this->statementGuidParser = $statementGuidParser; |
@@ -139,39 +139,39 @@ discard block |
||
139 | 139 | $params = $this->extractRequestParams(); |
140 | 140 | $result = $this->getResult(); |
141 | 141 | |
142 | - $propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] ); |
|
143 | - $constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] ); |
|
142 | + $propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]); |
|
143 | + $constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]); |
|
144 | 144 | |
145 | - $this->checkPropertyIds( $propertyIds, $result ); |
|
146 | - $this->checkConstraintIds( $constraintIds, $result ); |
|
145 | + $this->checkPropertyIds($propertyIds, $result); |
|
146 | + $this->checkConstraintIds($constraintIds, $result); |
|
147 | 147 | |
148 | - $result->addValue( null, 'success', 1 ); |
|
148 | + $result->addValue(null, 'success', 1); |
|
149 | 149 | } |
150 | 150 | |
151 | 151 | /** |
152 | 152 | * @param array|null $propertyIdSerializations |
153 | 153 | * @return PropertyId[] |
154 | 154 | */ |
155 | - private function parsePropertyIds( $propertyIdSerializations ) { |
|
156 | - if ( $propertyIdSerializations === null ) { |
|
155 | + private function parsePropertyIds($propertyIdSerializations) { |
|
156 | + if ($propertyIdSerializations === null) { |
|
157 | 157 | return []; |
158 | - } elseif ( empty( $propertyIdSerializations ) ) { |
|
158 | + } elseif (empty($propertyIdSerializations)) { |
|
159 | 159 | $this->apiErrorReporter->dieError( |
160 | - 'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.', |
|
160 | + 'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.', |
|
161 | 161 | 'no-data' |
162 | 162 | ); |
163 | 163 | } |
164 | 164 | |
165 | 165 | return array_map( |
166 | - function ( $propertyIdSerialization ) { |
|
166 | + function($propertyIdSerialization) { |
|
167 | 167 | try { |
168 | - return new PropertyId( $propertyIdSerialization ); |
|
169 | - } catch ( InvalidArgumentException $e ) { |
|
168 | + return new PropertyId($propertyIdSerialization); |
|
169 | + } catch (InvalidArgumentException $e) { |
|
170 | 170 | $this->apiErrorReporter->dieError( |
171 | 171 | "Invalid id: $propertyIdSerialization", |
172 | 172 | 'invalid-property-id', |
173 | 173 | 0, // default argument |
174 | - [ self::PARAM_PROPERTY_ID => $propertyIdSerialization ] |
|
174 | + [self::PARAM_PROPERTY_ID => $propertyIdSerialization] |
|
175 | 175 | ); |
176 | 176 | } |
177 | 177 | }, |
@@ -183,35 +183,35 @@ discard block |
||
183 | 183 | * @param array|null $constraintIds |
184 | 184 | * @return string[] |
185 | 185 | */ |
186 | - private function parseConstraintIds( $constraintIds ) { |
|
187 | - if ( $constraintIds === null ) { |
|
186 | + private function parseConstraintIds($constraintIds) { |
|
187 | + if ($constraintIds === null) { |
|
188 | 188 | return []; |
189 | - } elseif ( empty( $constraintIds ) ) { |
|
189 | + } elseif (empty($constraintIds)) { |
|
190 | 190 | $this->apiErrorReporter->dieError( |
191 | - 'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.', |
|
191 | + 'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.', |
|
192 | 192 | 'no-data' |
193 | 193 | ); |
194 | 194 | } |
195 | 195 | |
196 | 196 | return array_map( |
197 | - function ( $constraintId ) { |
|
197 | + function($constraintId) { |
|
198 | 198 | try { |
199 | - $propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId(); |
|
200 | - if ( !$propertyId instanceof PropertyId ) { |
|
199 | + $propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId(); |
|
200 | + if (!$propertyId instanceof PropertyId) { |
|
201 | 201 | $this->apiErrorReporter->dieError( |
202 | 202 | "Invalid property ID: {$propertyId->getSerialization()}", |
203 | 203 | 'invalid-property-id', |
204 | 204 | 0, // default argument |
205 | - [ self::PARAM_CONSTRAINT_ID => $constraintId ] |
|
205 | + [self::PARAM_CONSTRAINT_ID => $constraintId] |
|
206 | 206 | ); |
207 | 207 | } |
208 | 208 | return $constraintId; |
209 | - } catch ( StatementGuidParsingException $e ) { |
|
209 | + } catch (StatementGuidParsingException $e) { |
|
210 | 210 | $this->apiErrorReporter->dieError( |
211 | 211 | "Invalid statement GUID: $constraintId", |
212 | 212 | 'invalid-guid', |
213 | 213 | 0, // default argument |
214 | - [ self::PARAM_CONSTRAINT_ID => $constraintId ] |
|
214 | + [self::PARAM_CONSTRAINT_ID => $constraintId] |
|
215 | 215 | ); |
216 | 216 | } |
217 | 217 | }, |
@@ -223,12 +223,12 @@ discard block |
||
223 | 223 | * @param PropertyId[] $propertyIds |
224 | 224 | * @param ApiResult $result |
225 | 225 | */ |
226 | - private function checkPropertyIds( array $propertyIds, ApiResult $result ) { |
|
227 | - foreach ( $propertyIds as $propertyId ) { |
|
228 | - $result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' ); |
|
226 | + private function checkPropertyIds(array $propertyIds, ApiResult $result) { |
|
227 | + foreach ($propertyIds as $propertyId) { |
|
228 | + $result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc'); |
|
229 | 229 | $allConstraintExceptions = $this->delegatingConstraintChecker |
230 | - ->checkConstraintParametersOnPropertyId( $propertyId ); |
|
231 | - foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) { |
|
230 | + ->checkConstraintParametersOnPropertyId($propertyId); |
|
231 | + foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) { |
|
232 | 232 | $this->addConstraintParameterExceptionsToResult( |
233 | 233 | $constraintId, |
234 | 234 | $constraintParameterExceptions, |
@@ -242,15 +242,15 @@ discard block |
||
242 | 242 | * @param string[] $constraintIds |
243 | 243 | * @param ApiResult $result |
244 | 244 | */ |
245 | - private function checkConstraintIds( array $constraintIds, ApiResult $result ) { |
|
246 | - foreach ( $constraintIds as $constraintId ) { |
|
247 | - if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) { |
|
245 | + private function checkConstraintIds(array $constraintIds, ApiResult $result) { |
|
246 | + foreach ($constraintIds as $constraintId) { |
|
247 | + if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) { |
|
248 | 248 | // already checked as part of checkPropertyIds() |
249 | 249 | continue; |
250 | 250 | } |
251 | 251 | $constraintParameterExceptions = $this->delegatingConstraintChecker |
252 | - ->checkConstraintParametersOnConstraintId( $constraintId ); |
|
253 | - $this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result ); |
|
252 | + ->checkConstraintParametersOnConstraintId($constraintId); |
|
253 | + $this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result); |
|
254 | 254 | } |
255 | 255 | } |
256 | 256 | |
@@ -258,18 +258,18 @@ discard block |
||
258 | 258 | * @param PropertyId $propertyId |
259 | 259 | * @return string[] |
260 | 260 | */ |
261 | - private function getResultPathForPropertyId( PropertyId $propertyId ) { |
|
262 | - return [ $this->getModuleName(), $propertyId->getSerialization() ]; |
|
261 | + private function getResultPathForPropertyId(PropertyId $propertyId) { |
|
262 | + return [$this->getModuleName(), $propertyId->getSerialization()]; |
|
263 | 263 | } |
264 | 264 | |
265 | 265 | /** |
266 | 266 | * @param string $constraintId |
267 | 267 | * @return string[] |
268 | 268 | */ |
269 | - private function getResultPathForConstraintId( $constraintId ) { |
|
270 | - $propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId(); |
|
269 | + private function getResultPathForConstraintId($constraintId) { |
|
270 | + $propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId(); |
|
271 | 271 | '@phan-var PropertyId $propertyId'; |
272 | - return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] ); |
|
272 | + return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]); |
|
273 | 273 | } |
274 | 274 | |
275 | 275 | /** |
@@ -284,8 +284,8 @@ discard block |
||
284 | 284 | $constraintParameterExceptions, |
285 | 285 | ApiResult $result |
286 | 286 | ) { |
287 | - $path = $this->getResultPathForConstraintId( $constraintId ); |
|
288 | - if ( $constraintParameterExceptions === null ) { |
|
287 | + $path = $this->getResultPathForConstraintId($constraintId); |
|
288 | + if ($constraintParameterExceptions === null) { |
|
289 | 289 | $result->addValue( |
290 | 290 | $path, |
291 | 291 | self::KEY_STATUS, |
@@ -295,12 +295,12 @@ discard block |
||
295 | 295 | $result->addValue( |
296 | 296 | $path, |
297 | 297 | self::KEY_STATUS, |
298 | - empty( $constraintParameterExceptions ) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY |
|
298 | + empty($constraintParameterExceptions) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY |
|
299 | 299 | ); |
300 | 300 | $result->addValue( |
301 | 301 | $path, |
302 | 302 | self::KEY_PROBLEMS, |
303 | - array_map( [ $this, 'formatConstraintParameterException' ], $constraintParameterExceptions ) |
|
303 | + array_map([$this, 'formatConstraintParameterException'], $constraintParameterExceptions) |
|
304 | 304 | ); |
305 | 305 | } |
306 | 306 | } |
@@ -311,7 +311,7 @@ discard block |
||
311 | 311 | * @param ConstraintParameterException $e |
312 | 312 | * @return string[] |
313 | 313 | */ |
314 | - private function formatConstraintParameterException( ConstraintParameterException $e ) { |
|
314 | + private function formatConstraintParameterException(ConstraintParameterException $e) { |
|
315 | 315 | return [ |
316 | 316 | self::KEY_MESSAGE_HTML => $this->violationMessageRenderer->render( |
317 | 317 | $e->getViolationMessage() |
@@ -344,8 +344,8 @@ discard block |
||
344 | 344 | return [ |
345 | 345 | 'action=wbcheckconstraintparameters&propertyid=P247' |
346 | 346 | => 'apihelp-wbcheckconstraintparameters-example-propertyid-1', |
347 | - 'action=wbcheckconstraintparameters&' . |
|
348 | - 'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|' . |
|
347 | + 'action=wbcheckconstraintparameters&'. |
|
348 | + 'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|'. |
|
349 | 349 | 'P225$cdc71e4a-47a0-12c5-dfb3-3f6fc0b6613f' |
350 | 350 | => 'apihelp-wbcheckconstraintparameters-example-constraintid-2', |
351 | 351 | ]; |