@@ -28,46 +28,46 @@ discard block |
||
28 | 28 | use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer; |
29 | 29 | |
30 | 30 | return [ |
31 | - ConstraintsServices::EXPIRY_LOCK => function ( MediaWikiServices $services ) { |
|
32 | - return new ExpiryLock( ObjectCache::getInstance( CACHE_ANYTHING ) ); |
|
31 | + ConstraintsServices::EXPIRY_LOCK => function(MediaWikiServices $services) { |
|
32 | + return new ExpiryLock(ObjectCache::getInstance(CACHE_ANYTHING)); |
|
33 | 33 | }, |
34 | 34 | |
35 | - ConstraintsServices::LOGGING_HELPER => function ( MediaWikiServices $services ) { |
|
35 | + ConstraintsServices::LOGGING_HELPER => function(MediaWikiServices $services) { |
|
36 | 36 | return new LoggingHelper( |
37 | 37 | $services->getStatsdDataFactory(), |
38 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' ), |
|
38 | + LoggerFactory::getInstance('WikibaseQualityConstraints'), |
|
39 | 39 | $services->getMainConfig() |
40 | 40 | ); |
41 | 41 | }, |
42 | 42 | |
43 | - ConstraintsServices::CONSTRAINT_STORE => function ( MediaWikiServices $services ) { |
|
43 | + ConstraintsServices::CONSTRAINT_STORE => function(MediaWikiServices $services) { |
|
44 | 44 | $wbRepo = WikibaseRepo::getDefaultInstance(); |
45 | - $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
46 | - $propertySource = $sourceDefinitions->getSourceForEntityType( Property::ENTITY_TYPE ); |
|
45 | + $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
46 | + $propertySource = $sourceDefinitions->getSourceForEntityType(Property::ENTITY_TYPE); |
|
47 | 47 | $dbName = $propertySource->getDatabaseName(); |
48 | 48 | |
49 | - if ( $propertySource->getSourceName() !== $wbRepo->getLocalEntitySource()->getSourceName() ) { |
|
50 | - throw new \RuntimeException( 'Can\'t get a ConstraintStore for a non local entity source.' ); |
|
49 | + if ($propertySource->getSourceName() !== $wbRepo->getLocalEntitySource()->getSourceName()) { |
|
50 | + throw new \RuntimeException('Can\'t get a ConstraintStore for a non local entity source.'); |
|
51 | 51 | } |
52 | 52 | |
53 | 53 | return new ConstraintRepositoryStore( |
54 | - $services->getDBLoadBalancerFactory()->getMainLB( $dbName ), |
|
54 | + $services->getDBLoadBalancerFactory()->getMainLB($dbName), |
|
55 | 55 | $dbName |
56 | 56 | ); |
57 | 57 | }, |
58 | 58 | |
59 | - ConstraintsServices::CONSTRAINT_LOOKUP => function ( MediaWikiServices $services ) { |
|
60 | - $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
61 | - $propertySource = $sourceDefinitions->getSourceForEntityType( Property::ENTITY_TYPE ); |
|
59 | + ConstraintsServices::CONSTRAINT_LOOKUP => function(MediaWikiServices $services) { |
|
60 | + $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
61 | + $propertySource = $sourceDefinitions->getSourceForEntityType(Property::ENTITY_TYPE); |
|
62 | 62 | $dbName = $propertySource->getDatabaseName(); |
63 | 63 | $rawLookup = new ConstraintRepositoryLookup( |
64 | - $services->getDBLoadBalancerFactory()->getMainLB( $dbName ), |
|
64 | + $services->getDBLoadBalancerFactory()->getMainLB($dbName), |
|
65 | 65 | $dbName |
66 | 66 | ); |
67 | - return new CachingConstraintLookup( $rawLookup ); |
|
67 | + return new CachingConstraintLookup($rawLookup); |
|
68 | 68 | }, |
69 | 69 | |
70 | - ConstraintsServices::CHECK_RESULT_SERIALIZER => function ( MediaWikiServices $services ) { |
|
70 | + ConstraintsServices::CHECK_RESULT_SERIALIZER => function(MediaWikiServices $services) { |
|
71 | 71 | return new CheckResultSerializer( |
72 | 72 | new ConstraintSerializer( |
73 | 73 | false // constraint parameters are not exposed |
@@ -78,10 +78,10 @@ discard block |
||
78 | 78 | ); |
79 | 79 | }, |
80 | 80 | |
81 | - ConstraintsServices::CHECK_RESULT_DESERIALIZER => function ( MediaWikiServices $services ) { |
|
81 | + ConstraintsServices::CHECK_RESULT_DESERIALIZER => function(MediaWikiServices $services) { |
|
82 | 82 | // TODO in the future, get DataValueFactory from $services? |
83 | 83 | $repo = WikibaseRepo::getDefaultInstance(); |
84 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
84 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
85 | 85 | $dataValueFactory = $repo->getDataValueFactory(); |
86 | 86 | |
87 | 87 | return new CheckResultDeserializer( |
@@ -95,14 +95,14 @@ discard block |
||
95 | 95 | ); |
96 | 96 | }, |
97 | 97 | |
98 | - ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function ( MediaWikiServices $services ) { |
|
98 | + ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function(MediaWikiServices $services) { |
|
99 | 99 | return new ViolationMessageSerializer(); |
100 | 100 | }, |
101 | 101 | |
102 | - ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function ( MediaWikiServices $services ) { |
|
102 | + ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function(MediaWikiServices $services) { |
|
103 | 103 | // TODO in the future, get DataValueFactory from $services? |
104 | 104 | $repo = WikibaseRepo::getDefaultInstance(); |
105 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
105 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
106 | 106 | $dataValueFactory = $repo->getDataValueFactory(); |
107 | 107 | |
108 | 108 | return new ViolationMessageDeserializer( |
@@ -111,24 +111,24 @@ discard block |
||
111 | 111 | ); |
112 | 112 | }, |
113 | 113 | |
114 | - ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function ( MediaWikiServices $services ) { |
|
114 | + ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function(MediaWikiServices $services) { |
|
115 | 115 | // TODO in the future, get DeserializerFactory from $services? |
116 | 116 | $repo = WikibaseRepo::getDefaultInstance(); |
117 | 117 | $deserializerFactory = $repo->getBaseDataModelDeserializerFactory(); |
118 | - $entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
118 | + $entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
119 | 119 | |
120 | 120 | return new ConstraintParameterParser( |
121 | 121 | $services->getMainConfig(), |
122 | 122 | $deserializerFactory, |
123 | - $entitySourceDefinitions->getSourceForEntityType( 'item' )->getConceptBaseUri() |
|
123 | + $entitySourceDefinitions->getSourceForEntityType('item')->getConceptBaseUri() |
|
124 | 124 | ); |
125 | 125 | }, |
126 | 126 | |
127 | - ConstraintsServices::CONNECTION_CHECKER_HELPER => function ( MediaWikiServices $services ) { |
|
127 | + ConstraintsServices::CONNECTION_CHECKER_HELPER => function(MediaWikiServices $services) { |
|
128 | 128 | return new ConnectionCheckerHelper(); |
129 | 129 | }, |
130 | 130 | |
131 | - ConstraintsServices::RANGE_CHECKER_HELPER => function ( MediaWikiServices $services ) { |
|
131 | + ConstraintsServices::RANGE_CHECKER_HELPER => function(MediaWikiServices $services) { |
|
132 | 132 | // TODO in the future, get UnitConverter from $services? |
133 | 133 | $repo = WikibaseRepo::getDefaultInstance(); |
134 | 134 | $unitConverter = $repo->getUnitConverter(); |
@@ -139,16 +139,16 @@ discard block |
||
139 | 139 | ); |
140 | 140 | }, |
141 | 141 | |
142 | - ConstraintsServices::SPARQL_HELPER => function ( MediaWikiServices $services ) { |
|
143 | - $endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' ); |
|
144 | - if ( $endpoint === '' ) { |
|
142 | + ConstraintsServices::SPARQL_HELPER => function(MediaWikiServices $services) { |
|
143 | + $endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint'); |
|
144 | + if ($endpoint === '') { |
|
145 | 145 | return new DummySparqlHelper(); |
146 | 146 | } |
147 | 147 | |
148 | 148 | // TODO in the future, get RDFVocabulary and PropertyDataTypeLookup from $services? |
149 | 149 | $repo = WikibaseRepo::getDefaultInstance(); |
150 | 150 | $rdfVocabulary = $repo->getRdfVocabulary(); |
151 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
151 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
152 | 152 | $propertyDataTypeLookup = $repo->getPropertyDataTypeLookup(); |
153 | 153 | |
154 | 154 | return new SparqlHelper( |
@@ -157,121 +157,121 @@ discard block |
||
157 | 157 | $entityIdParser, |
158 | 158 | $propertyDataTypeLookup, |
159 | 159 | $services->getMainWANObjectCache(), |
160 | - ConstraintsServices::getViolationMessageSerializer( $services ), |
|
161 | - ConstraintsServices::getViolationMessageDeserializer( $services ), |
|
160 | + ConstraintsServices::getViolationMessageSerializer($services), |
|
161 | + ConstraintsServices::getViolationMessageDeserializer($services), |
|
162 | 162 | $services->getStatsdDataFactory(), |
163 | - ConstraintsServices::getExpiryLock( $services ), |
|
163 | + ConstraintsServices::getExpiryLock($services), |
|
164 | 164 | ConstraintsServices::getLoggingHelper(), |
165 | - wfWikiID() . ' WikibaseQualityConstraints ' . Http::userAgent(), |
|
165 | + wfWikiID().' WikibaseQualityConstraints '.Http::userAgent(), |
|
166 | 166 | $services->getHttpRequestFactory() |
167 | 167 | ); |
168 | 168 | }, |
169 | 169 | |
170 | - ConstraintsServices::TYPE_CHECKER_HELPER => function ( MediaWikiServices $services ) { |
|
170 | + ConstraintsServices::TYPE_CHECKER_HELPER => function(MediaWikiServices $services) { |
|
171 | 171 | return new TypeCheckerHelper( |
172 | - WikibaseServices::getEntityLookup( $services ), |
|
172 | + WikibaseServices::getEntityLookup($services), |
|
173 | 173 | $services->getMainConfig(), |
174 | - ConstraintsServices::getSparqlHelper( $services ), |
|
174 | + ConstraintsServices::getSparqlHelper($services), |
|
175 | 175 | $services->getStatsdDataFactory() |
176 | 176 | ); |
177 | 177 | }, |
178 | 178 | |
179 | - ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function ( MediaWikiServices $services ) { |
|
180 | - $statementGuidParser = WikibaseRepo::getStatementGuidParser( $services ); |
|
179 | + ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function(MediaWikiServices $services) { |
|
180 | + $statementGuidParser = WikibaseRepo::getStatementGuidParser($services); |
|
181 | 181 | |
182 | 182 | $config = $services->getMainConfig(); |
183 | 183 | $checkerMap = [ |
184 | - $config->get( 'WBQualityConstraintsConflictsWithConstraintId' ) |
|
185 | - => ConstraintCheckerServices::getConflictsWithChecker( $services ), |
|
186 | - $config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' ) |
|
187 | - => ConstraintCheckerServices::getItemChecker( $services ), |
|
188 | - $config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' ) |
|
189 | - => ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ), |
|
190 | - $config->get( 'WBQualityConstraintsSymmetricConstraintId' ) |
|
191 | - => ConstraintCheckerServices::getSymmetricChecker( $services ), |
|
192 | - $config->get( 'WBQualityConstraintsInverseConstraintId' ) |
|
193 | - => ConstraintCheckerServices::getInverseChecker( $services ), |
|
194 | - $config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' ) |
|
195 | - => ConstraintCheckerServices::getQualifierChecker( $services ), |
|
196 | - $config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' ) |
|
197 | - => ConstraintCheckerServices::getQualifiersChecker( $services ), |
|
198 | - $config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' ) |
|
199 | - => ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ), |
|
200 | - $config->get( 'WBQualityConstraintsRangeConstraintId' ) |
|
201 | - => ConstraintCheckerServices::getRangeChecker( $services ), |
|
202 | - $config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' ) |
|
203 | - => ConstraintCheckerServices::getDiffWithinRangeChecker( $services ), |
|
204 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ) |
|
205 | - => ConstraintCheckerServices::getTypeChecker( $services ), |
|
206 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ) |
|
207 | - => ConstraintCheckerServices::getValueTypeChecker( $services ), |
|
208 | - $config->get( 'WBQualityConstraintsSingleValueConstraintId' ) |
|
209 | - => ConstraintCheckerServices::getSingleValueChecker( $services ), |
|
210 | - $config->get( 'WBQualityConstraintsMultiValueConstraintId' ) |
|
211 | - => ConstraintCheckerServices::getMultiValueChecker( $services ), |
|
212 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ) |
|
213 | - => ConstraintCheckerServices::getUniqueValueChecker( $services ), |
|
214 | - $config->get( 'WBQualityConstraintsFormatConstraintId' ) |
|
215 | - => ConstraintCheckerServices::getFormatChecker( $services ), |
|
216 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ) |
|
217 | - => ConstraintCheckerServices::getCommonsLinkChecker( $services ), |
|
218 | - $config->get( 'WBQualityConstraintsOneOfConstraintId' ) |
|
219 | - => ConstraintCheckerServices::getOneOfChecker( $services ), |
|
220 | - $config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' ) |
|
221 | - => ConstraintCheckerServices::getValueOnlyChecker( $services ), |
|
222 | - $config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' ) |
|
223 | - => ConstraintCheckerServices::getReferenceChecker( $services ), |
|
224 | - $config->get( 'WBQualityConstraintsNoBoundsConstraintId' ) |
|
225 | - => ConstraintCheckerServices::getNoBoundsChecker( $services ), |
|
226 | - $config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' ) |
|
227 | - => ConstraintCheckerServices::getAllowedUnitsChecker( $services ), |
|
228 | - $config->get( 'WBQualityConstraintsSingleBestValueConstraintId' ) |
|
229 | - => ConstraintCheckerServices::getSingleBestValueChecker( $services ), |
|
230 | - $config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' ) |
|
231 | - => ConstraintCheckerServices::getEntityTypeChecker( $services ), |
|
232 | - $config->get( 'WBQualityConstraintsNoneOfConstraintId' ) |
|
233 | - => ConstraintCheckerServices::getNoneOfChecker( $services ), |
|
234 | - $config->get( 'WBQualityConstraintsIntegerConstraintId' ) |
|
235 | - => ConstraintCheckerServices::getIntegerChecker( $services ), |
|
236 | - $config->get( 'WBQualityConstraintsCitationNeededConstraintId' ) |
|
237 | - => ConstraintCheckerServices::getCitationNeededChecker( $services ), |
|
238 | - $config->get( 'WBQualityConstraintsPropertyScopeConstraintId' ) |
|
239 | - => ConstraintCheckerServices::getPropertyScopeChecker( $services ), |
|
240 | - $config->get( 'WBQualityConstraintsContemporaryConstraintId' ) |
|
241 | - => ConstraintCheckerServices::getContemporaryChecker( $services ), |
|
184 | + $config->get('WBQualityConstraintsConflictsWithConstraintId') |
|
185 | + => ConstraintCheckerServices::getConflictsWithChecker($services), |
|
186 | + $config->get('WBQualityConstraintsItemRequiresClaimConstraintId') |
|
187 | + => ConstraintCheckerServices::getItemChecker($services), |
|
188 | + $config->get('WBQualityConstraintsValueRequiresClaimConstraintId') |
|
189 | + => ConstraintCheckerServices::getTargetRequiredClaimChecker($services), |
|
190 | + $config->get('WBQualityConstraintsSymmetricConstraintId') |
|
191 | + => ConstraintCheckerServices::getSymmetricChecker($services), |
|
192 | + $config->get('WBQualityConstraintsInverseConstraintId') |
|
193 | + => ConstraintCheckerServices::getInverseChecker($services), |
|
194 | + $config->get('WBQualityConstraintsUsedAsQualifierConstraintId') |
|
195 | + => ConstraintCheckerServices::getQualifierChecker($services), |
|
196 | + $config->get('WBQualityConstraintsAllowedQualifiersConstraintId') |
|
197 | + => ConstraintCheckerServices::getQualifiersChecker($services), |
|
198 | + $config->get('WBQualityConstraintsMandatoryQualifierConstraintId') |
|
199 | + => ConstraintCheckerServices::getMandatoryQualifiersChecker($services), |
|
200 | + $config->get('WBQualityConstraintsRangeConstraintId') |
|
201 | + => ConstraintCheckerServices::getRangeChecker($services), |
|
202 | + $config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId') |
|
203 | + => ConstraintCheckerServices::getDiffWithinRangeChecker($services), |
|
204 | + $config->get('WBQualityConstraintsTypeConstraintId') |
|
205 | + => ConstraintCheckerServices::getTypeChecker($services), |
|
206 | + $config->get('WBQualityConstraintsValueTypeConstraintId') |
|
207 | + => ConstraintCheckerServices::getValueTypeChecker($services), |
|
208 | + $config->get('WBQualityConstraintsSingleValueConstraintId') |
|
209 | + => ConstraintCheckerServices::getSingleValueChecker($services), |
|
210 | + $config->get('WBQualityConstraintsMultiValueConstraintId') |
|
211 | + => ConstraintCheckerServices::getMultiValueChecker($services), |
|
212 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId') |
|
213 | + => ConstraintCheckerServices::getUniqueValueChecker($services), |
|
214 | + $config->get('WBQualityConstraintsFormatConstraintId') |
|
215 | + => ConstraintCheckerServices::getFormatChecker($services), |
|
216 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId') |
|
217 | + => ConstraintCheckerServices::getCommonsLinkChecker($services), |
|
218 | + $config->get('WBQualityConstraintsOneOfConstraintId') |
|
219 | + => ConstraintCheckerServices::getOneOfChecker($services), |
|
220 | + $config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId') |
|
221 | + => ConstraintCheckerServices::getValueOnlyChecker($services), |
|
222 | + $config->get('WBQualityConstraintsUsedAsReferenceConstraintId') |
|
223 | + => ConstraintCheckerServices::getReferenceChecker($services), |
|
224 | + $config->get('WBQualityConstraintsNoBoundsConstraintId') |
|
225 | + => ConstraintCheckerServices::getNoBoundsChecker($services), |
|
226 | + $config->get('WBQualityConstraintsAllowedUnitsConstraintId') |
|
227 | + => ConstraintCheckerServices::getAllowedUnitsChecker($services), |
|
228 | + $config->get('WBQualityConstraintsSingleBestValueConstraintId') |
|
229 | + => ConstraintCheckerServices::getSingleBestValueChecker($services), |
|
230 | + $config->get('WBQualityConstraintsAllowedEntityTypesConstraintId') |
|
231 | + => ConstraintCheckerServices::getEntityTypeChecker($services), |
|
232 | + $config->get('WBQualityConstraintsNoneOfConstraintId') |
|
233 | + => ConstraintCheckerServices::getNoneOfChecker($services), |
|
234 | + $config->get('WBQualityConstraintsIntegerConstraintId') |
|
235 | + => ConstraintCheckerServices::getIntegerChecker($services), |
|
236 | + $config->get('WBQualityConstraintsCitationNeededConstraintId') |
|
237 | + => ConstraintCheckerServices::getCitationNeededChecker($services), |
|
238 | + $config->get('WBQualityConstraintsPropertyScopeConstraintId') |
|
239 | + => ConstraintCheckerServices::getPropertyScopeChecker($services), |
|
240 | + $config->get('WBQualityConstraintsContemporaryConstraintId') |
|
241 | + => ConstraintCheckerServices::getContemporaryChecker($services), |
|
242 | 242 | ]; |
243 | 243 | |
244 | 244 | return new DelegatingConstraintChecker( |
245 | - WikibaseServices::getEntityLookup( $services ), |
|
245 | + WikibaseServices::getEntityLookup($services), |
|
246 | 246 | $checkerMap, |
247 | - ConstraintsServices::getConstraintLookup( $services ), |
|
248 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
247 | + ConstraintsServices::getConstraintLookup($services), |
|
248 | + ConstraintsServices::getConstraintParameterParser($services), |
|
249 | 249 | $statementGuidParser, |
250 | - ConstraintsServices::getLoggingHelper( $services ), |
|
251 | - $config->get( 'WBQualityConstraintsCheckQualifiers' ), |
|
252 | - $config->get( 'WBQualityConstraintsCheckReferences' ), |
|
253 | - $config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' ) |
|
250 | + ConstraintsServices::getLoggingHelper($services), |
|
251 | + $config->get('WBQualityConstraintsCheckQualifiers'), |
|
252 | + $config->get('WBQualityConstraintsCheckReferences'), |
|
253 | + $config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers') |
|
254 | 254 | ); |
255 | 255 | }, |
256 | 256 | |
257 | - ConstraintsServices::RESULTS_SOURCE => function ( MediaWikiServices $services ) { |
|
257 | + ConstraintsServices::RESULTS_SOURCE => function(MediaWikiServices $services) { |
|
258 | 258 | $config = $services->getMainConfig(); |
259 | 259 | $resultsSource = new CheckingResultsSource( |
260 | - ConstraintsServices::getDelegatingConstraintChecker( $services ) |
|
260 | + ConstraintsServices::getDelegatingConstraintChecker($services) |
|
261 | 261 | ); |
262 | 262 | |
263 | 263 | $cacheCheckConstraintsResults = false; |
264 | 264 | |
265 | - if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) { |
|
265 | + if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) { |
|
266 | 266 | $cacheCheckConstraintsResults = true; |
267 | 267 | // check that we can use getLocalRepoWikiPageMetaDataAccessor() |
268 | 268 | // TODO we should always be able to cache constraint check results (T244726) |
269 | 269 | $repo = WikibaseRepo::getDefaultInstance(); |
270 | - $entitySources = WikibaseRepo::getEntitySourceDefinitions( $services )->getSources(); |
|
271 | - foreach ( $entitySources as $entitySource ) { |
|
272 | - if ( $entitySource->getSourceName() !== $repo->getLocalEntitySource()->getSourceName() ) { |
|
273 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' )->warning( |
|
274 | - 'Cannot cache constraint check results for non-local source: ' . |
|
270 | + $entitySources = WikibaseRepo::getEntitySourceDefinitions($services)->getSources(); |
|
271 | + foreach ($entitySources as $entitySource) { |
|
272 | + if ($entitySource->getSourceName() !== $repo->getLocalEntitySource()->getSourceName()) { |
|
273 | + LoggerFactory::getInstance('WikibaseQualityConstraints')->warning( |
|
274 | + 'Cannot cache constraint check results for non-local source: '. |
|
275 | 275 | $entitySource->getSourceName() |
276 | 276 | ); |
277 | 277 | $cacheCheckConstraintsResults = false; |
@@ -280,29 +280,29 @@ discard block |
||
280 | 280 | } |
281 | 281 | } |
282 | 282 | |
283 | - if ( $cacheCheckConstraintsResults ) { |
|
283 | + if ($cacheCheckConstraintsResults) { |
|
284 | 284 | $possiblyStaleConstraintTypes = [ |
285 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ), |
|
286 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ), |
|
287 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ), |
|
288 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ), |
|
285 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId'), |
|
286 | + $config->get('WBQualityConstraintsTypeConstraintId'), |
|
287 | + $config->get('WBQualityConstraintsValueTypeConstraintId'), |
|
288 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId'), |
|
289 | 289 | ]; |
290 | 290 | // TODO in the future, get WikiPageEntityMetaDataAccessor from $services? |
291 | 291 | $repo = WikibaseRepo::getDefaultInstance(); |
292 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
292 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
293 | 293 | $wikiPageEntityMetaDataAccessor = $repo->getLocalRepoWikiPageMetaDataAccessor(); |
294 | 294 | |
295 | 295 | $resultsSource = new CachingResultsSource( |
296 | 296 | $resultsSource, |
297 | 297 | ResultsCache::getDefaultInstance(), |
298 | - ConstraintsServices::getCheckResultSerializer( $services ), |
|
299 | - ConstraintsServices::getCheckResultDeserializer( $services ), |
|
298 | + ConstraintsServices::getCheckResultSerializer($services), |
|
299 | + ConstraintsServices::getCheckResultDeserializer($services), |
|
300 | 300 | $wikiPageEntityMetaDataAccessor, |
301 | 301 | $entityIdParser, |
302 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ), |
|
302 | + $config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'), |
|
303 | 303 | $possiblyStaleConstraintTypes, |
304 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ), |
|
305 | - ConstraintsServices::getLoggingHelper( $services ) |
|
304 | + $config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'), |
|
305 | + ConstraintsServices::getLoggingHelper($services) |
|
306 | 306 | ); |
307 | 307 | } |
308 | 308 |
@@ -36,7 +36,7 @@ discard block |
||
36 | 36 | * @param WANObjectCache $cache |
37 | 37 | * @param string $formatVersion The version of the API response format. |
38 | 38 | */ |
39 | - public function __construct( WANObjectCache $cache, $formatVersion ) { |
|
39 | + public function __construct(WANObjectCache $cache, $formatVersion) { |
|
40 | 40 | $this->cache = $cache; |
41 | 41 | $this->formatVersion = $formatVersion; |
42 | 42 | } |
@@ -45,7 +45,7 @@ discard block |
||
45 | 45 | * @param EntityId $entityId |
46 | 46 | * @return string cache key |
47 | 47 | */ |
48 | - public function makeKey( EntityId $entityId ) { |
|
48 | + public function makeKey(EntityId $entityId) { |
|
49 | 49 | return $this->cache->makeKey( |
50 | 50 | 'WikibaseQualityConstraints', // extension |
51 | 51 | 'checkConstraints', // action |
@@ -61,8 +61,8 @@ discard block |
||
61 | 61 | * @param mixed|null &$info |
62 | 62 | * @return mixed |
63 | 63 | */ |
64 | - public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], &$info = null ) { |
|
65 | - return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $info ); |
|
64 | + public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], &$info = null) { |
|
65 | + return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $info); |
|
66 | 66 | } |
67 | 67 | |
68 | 68 | /** |
@@ -72,16 +72,16 @@ discard block |
||
72 | 72 | * @param array $opts |
73 | 73 | * @return bool |
74 | 74 | */ |
75 | - public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) { |
|
76 | - return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts ); |
|
75 | + public function set(EntityId $key, $value, $ttl = 0, array $opts = []) { |
|
76 | + return $this->cache->set($this->makeKey($key), $value, $ttl, $opts); |
|
77 | 77 | } |
78 | 78 | |
79 | 79 | /** |
80 | 80 | * @param EntityId $key |
81 | 81 | * @return bool |
82 | 82 | */ |
83 | - public function delete( EntityId $key ) { |
|
84 | - return $this->cache->delete( $this->makeKey( $key ) ); |
|
83 | + public function delete(EntityId $key) { |
|
84 | + return $this->cache->delete($this->makeKey($key)); |
|
85 | 85 | } |
86 | 86 | |
87 | 87 | } |