View GitHub Repository mediawiki-extensions-WikibaseQualityConstraints

Schedule Inspection
Subscribe
Completed
Push — master ( 08de92...05461e )
by
unknown
39s queued 14s
created
Status
Category
Toggle Patches
src/ConstraintCheck/ConstraintChecker.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -108,7 +108,7 @@  discard block
 
 block discarded – undo
108 108 
 	 * @throws ConstraintParameterException if the constraint parameters are invalid
109 109 
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
110 110 
 	 */
111 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult;
111 
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult;
112 112
113 113 
 	/**
114 114 
 	 * Check if the constraint parameters of $constraint are valid.
 
@@ -119,6 +119,6 @@  discard block
 
 block discarded – undo
119 119 
 	 *
120 120 
 	 * @return ConstraintParameterException[]
121 121 
 	 */
122 
-	public function checkConstraintParameters( Constraint $constraint ): array;
122 
+	public function checkConstraintParameters(Constraint $constraint): array;
123 123
124 124 
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/MandatoryQualifiersChecker.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch 
@@ -67,9 +67,9 @@  discard block
 
 block discarded – undo
67 67 
 	 * @throws ConstraintParameterException
68 68 
 	 * @return CheckResult
69 69 
 	 */
70 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
71 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
72 
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
70 
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
71 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
72 
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
73 73 
 		}
74 74
75 75 
 		$constraintParameters = $constraint->getConstraintParameters();
 
@@ -80,24 +80,24 @@  discard block
 
 block discarded – undo
80 80 
 			$constraintTypeItemId
81 81 
 		);
82 82
83 
-		$message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) )
84 
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
85 
-			->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE );
83 
+		$message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier'))
84 
+			->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
85 
+			->withEntityId($propertyId, Role::QUALIFIER_PREDICATE);
86 86 
 		$status = CheckResult::STATUS_VIOLATION;
87 87
88 88 
 		/** @var Snak $qualifier */
89 
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
90 
-			if ( $propertyId->equals( $qualifier->getPropertyId() ) ) {
89 
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
90 
+			if ($propertyId->equals($qualifier->getPropertyId())) {
91 91 
 				$message = null;
92 92 
 				$status = CheckResult::STATUS_COMPLIANCE;
93 93 
 				break;
94 94 
 			}
95 95 
 		}
96 96
97 
-		return new CheckResult( $context, $constraint, $status, $message );
97 
+		return new CheckResult($context, $constraint, $status, $message);
98 98 
 	}
99 99
100 
-	public function checkConstraintParameters( Constraint $constraint ): array {
100 
+	public function checkConstraintParameters(Constraint $constraint): array {
101 101 
 		$constraintParameters = $constraint->getConstraintParameters();
102 102 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
103 103 
 		$exceptions = [];
 
@@ -106,7 +106,7 @@  discard block
 
 block discarded – undo
106 106 
 				$constraintParameters,
107 107 
 				$constraintTypeItemId
108 108 
 			);
109 
-		} catch ( ConstraintParameterException $e ) {
109 
+		} catch (ConstraintParameterException $e) {
110 110 
 			$exceptions[] = $e;
111 111 
 		}
112 112 
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ConflictsWithChecker.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch 
@@ -76,9 +76,9 @@  discard block
 
 block discarded – undo
76 76 
 	 * @throws ConstraintParameterException
77 77 
 	 * @return CheckResult
78 78 
 	 */
79 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
80 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
81 
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
79 
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
80 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
81 
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
82 82 
 		}
83 83
84 84 
 		$constraintParameters = $constraint->getConstraintParameters();
 
@@ -97,22 +97,22 @@  discard block
 
 block discarded – undo
97 97
98 98 
 		$statementList = $context->getEntity()
99 99 
 			->getStatements()
100 
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
100 
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
101 101
102 102 
 		/*
103 103 
 		 * 'Conflicts with' can be defined with
104 104 
 		 *   a) a property only
105 105 
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
106 106 
 		 */
107 
-		if ( $items === [] ) {
107 
+		if ($items === []) {
108 108 
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
109 109 
 				$statementList,
110 110 
 				$propertyId
111 111 
 			);
112 
-			if ( $offendingStatement !== null ) {
113 
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
114 
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
115 
-					->withEntityId( $propertyId, Role::PREDICATE );
112 
+			if ($offendingStatement !== null) {
113 
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
114 
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
115 
+					->withEntityId($propertyId, Role::PREDICATE);
116 116 
 				$status = CheckResult::STATUS_VIOLATION;
117 117 
 			} else {
118 118 
 				$message = null;
 
@@ -124,12 +124,12 @@  discard block
 
 block discarded – undo
124 124 
 				$propertyId,
125 125 
 				$items
126 126 
 			);
127 
-			if ( $offendingStatement !== null ) {
128 
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
129 
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
130 
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
131 
-					->withEntityId( $propertyId, Role::PREDICATE )
132 
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
127 
+			if ($offendingStatement !== null) {
128 
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
129 
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
130 
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
131 
+					->withEntityId($propertyId, Role::PREDICATE)
132 
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
133 133 
 				$status = CheckResult::STATUS_VIOLATION;
134 134 
 			} else {
135 135 
 				$message = null;
 
@@ -137,10 +137,10 @@  discard block
 
 block discarded – undo
137 137 
 			}
138 138 
 		}
139 139
140 
-		return new CheckResult( $context, $constraint, $status, $message );
140 
+		return new CheckResult($context, $constraint, $status, $message);
141 141 
 	}
142 142
143 
-	public function checkConstraintParameters( Constraint $constraint ): array {
143 
+	public function checkConstraintParameters(Constraint $constraint): array {
144 144 
 		$constraintParameters = $constraint->getConstraintParameters();
145 145 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
146 146 
 		$exceptions = [];
 
@@ -149,7 +149,7 @@  discard block
 
 block discarded – undo
149 149 
 				$constraintParameters,
150 150 
 				$constraintTypeItemId
151 151 
 			);
152 
-		} catch ( ConstraintParameterException $e ) {
152 
+		} catch (ConstraintParameterException $e) {
153 153 
 			$exceptions[] = $e;
154 154 
 		}
155 155 
 		try {
 
@@ -158,7 +158,7 @@  discard block
 
 block discarded – undo
158 158 
 				$constraintTypeItemId,
159 159 
 				false
160 160 
 			);
161 
-		} catch ( ConstraintParameterException $e ) {
161 
+		} catch (ConstraintParameterException $e) {
162 162 
 			$exceptions[] = $e;
163 163 
 		}
164 164 
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ReferenceChecker.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -33,16 +33,16 @@
 
 block discarded – undo
33 33 
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
34 34 
 	}
35 35
36 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
37 
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
38 
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
36 
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
37 
+		if ($context->getType() === Context::TYPE_REFERENCE) {
38 
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
39 39 
 		} else {
40 
-			$message = new ViolationMessage( 'wbqc-violation-message-reference' );
41 
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
40 
+			$message = new ViolationMessage('wbqc-violation-message-reference');
41 
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
42 42 
 		}
43 43 
 	}
44 44
45 
-	public function checkConstraintParameters( Constraint $constraint ): array {
45 
+	public function checkConstraintParameters(Constraint $constraint): array {
46 46 
 		// no parameters
47 47 
 		return [];
48 48 
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/PropertyScopeChecker.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -46,7 +46,7 @@  discard block
 
 block discarded – undo
46 46 
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
47 47 
 	}
48 48
49 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
49 
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
50 50 
 		$constraintParameters = $constraint->getConstraintParameters();
51 51 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
52 52 
 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
 			$constraintTypeItemId
56 56 
 		);
57 57
58 
-		if ( in_array( $context->getType(), $allowedContextTypes ) ) {
58 
+		if (in_array($context->getType(), $allowedContextTypes)) {
59 59 
 			return new CheckResult(
60 60 
 				$context->getCursor(),
61 61 
 				$constraint,
 
@@ -66,15 +66,15 @@  discard block
 
 block discarded – undo
66 66 
 				$context->getCursor(),
67 67 
 				$constraint,
68 68 
 				CheckResult::STATUS_VIOLATION,
69 
-				( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
70 
-					->withEntityId( $context->getSnak()->getPropertyId() )
71 
-					->withPropertyScope( $context->getType() )
72 
-					->withPropertyScopeList( $allowedContextTypes )
69 
+				(new ViolationMessage('wbqc-violation-message-property-scope'))
70 
+					->withEntityId($context->getSnak()->getPropertyId())
71 
+					->withPropertyScope($context->getType())
72 
+					->withPropertyScopeList($allowedContextTypes)
73 73 
 			);
74 74 
 		}
75 75 
 	}
76 76
77 
-	public function checkConstraintParameters( Constraint $constraint ): array {
77 
+	public function checkConstraintParameters(Constraint $constraint): array {
78 78 
 		$constraintParameters = $constraint->getConstraintParameters();
79 79 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
80 80 
 		$exceptions = [];
 
@@ -83,7 +83,7 @@  discard block
 
 block discarded – undo
83 83 
 				$constraintParameters,
84 84 
 				$constraintTypeItemId
85 85 
 			);
86 
-		} catch ( ConstraintParameterException $e ) {
86 
+		} catch (ConstraintParameterException $e) {
87 87 
 			$exceptions[] = $e;
88 88 
 		}
89 89 
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/SingleBestValueChecker.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch 
@@ -63,9 +63,9 @@  discard block
 
 block discarded – undo
63 63 
 	 *
64 64 
 	 * @return CheckResult
65 65 
 	 */
66 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
67 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
68 
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
66 
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
67 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
68 
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
69 69 
 		}
70 70
71 71 
 		$separators = $this->constraintParameterParser->parseSeparatorsParameter(
 
@@ -74,13 +74,13 @@  discard block
 
 block discarded – undo
74 74
75 75 
 		$propertyId = $context->getSnak()->getPropertyId();
76 76 
 		$bestRankCount = $this->valueCountCheckerHelper->getPropertyCount(
77 
-			$context->getSnakGroup( Context::GROUP_BEST_RANK, $separators ),
77 
+			$context->getSnakGroup(Context::GROUP_BEST_RANK, $separators),
78 78 
 			$propertyId
79 79 
 		);
80 80
81 
-		if ( $bestRankCount > 1 ) {
81 
+		if ($bestRankCount > 1) {
82 82 
 			$nonDeprecatedCount = $this->valueCountCheckerHelper->getPropertyCount(
83 
-				$context->getSnakGroup( Context::GROUP_NON_DEPRECATED ),
83 
+				$context->getSnakGroup(Context::GROUP_NON_DEPRECATED),
84 84 
 				$propertyId
85 85 
 			);
86 86 
 			$message = $this->getViolationMessage(
 
@@ -95,15 +95,15 @@  discard block
 
 block discarded – undo
95 95 
 			$status = CheckResult::STATUS_COMPLIANCE;
96 96 
 		}
97 97
98 
-		return new CheckResult( $context, $constraint, $status, $message );
98 
+		return new CheckResult($context, $constraint, $status, $message);
99 99 
 	}
100 100
101 
-	public function checkConstraintParameters( Constraint $constraint ): array {
101 
+	public function checkConstraintParameters(Constraint $constraint): array {
102 102 
 		$constraintParameters = $constraint->getConstraintParameters();
103 103 
 		$exceptions = [];
104 104 
 		try {
105 
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
106 
-		} catch ( ConstraintParameterException $e ) {
105 
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
106 
+		} catch (ConstraintParameterException $e) {
107 107 
 			$exceptions[] = $e;
108 108 
 		}
109 109 
 		return $exceptions;
 
@@ -122,23 +122,23 @@  discard block
 
 block discarded – undo
122 122 
 		$separators,
123 123 
 		$propertyId
124 124 
 	) {
125 
-		if ( $bestRankCount === $nonDeprecatedCount ) {
126 
-			if ( $separators === [] ) {
125 
+		if ($bestRankCount === $nonDeprecatedCount) {
126 
+			if ($separators === []) {
127 127 
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred';
128 128 
 			} else {
129 129 
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred-separators';
130 130 
 			}
131 131 
 		} else {
132 
-			if ( $separators === [] ) {
132 
+			if ($separators === []) {
133 133 
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred';
134 134 
 			} else {
135 135 
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred-separators';
136 136 
 			}
137 137 
 		}
138 138
139 
-		return ( new ViolationMessage( $messageKey ) )
140 
-			->withEntityId( $propertyId )
141 
-			->withEntityIdList( $separators );
139 
+		return (new ViolationMessage($messageKey))
140 
+			->withEntityId($propertyId)
141 
+			->withEntityIdList($separators);
142 142 
 	}
143 143
144 144 
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ItemChecker.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch 
@@ -75,9 +75,9 @@  discard block
 
 block discarded – undo
75 75 
 	 * @throws ConstraintParameterException
76 76 
 	 * @return CheckResult
77 77 
 	 */
78 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
79 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
80 
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
78 
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
79 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
80 
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
81 81 
 		}
82 82
83 83 
 		$constraintParameters = $constraint->getConstraintParameters();
 
@@ -99,7 +99,7 @@  discard block
 
 block discarded – undo
99 99 
 		 *   a) a property only
100 100 
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
101 101 
 		 */
102 
-		if ( $items === [] ) {
102 
+		if ($items === []) {
103 103 
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
104 104 
 				$context->getEntity()->getStatements(),
105 105 
 				$propertyId
 
@@ -112,21 +112,21 @@  discard block
 
 block discarded – undo
112 112 
 			);
113 113 
 		}
114 114
115 
-		if ( $requiredStatement !== null ) {
115 
+		if ($requiredStatement !== null) {
116 116 
 			$status = CheckResult::STATUS_COMPLIANCE;
117 117 
 			$message = null;
118 118 
 		} else {
119 119 
 			$status = CheckResult::STATUS_VIOLATION;
120 
-			$message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
121 
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
122 
-				->withEntityId( $propertyId, Role::PREDICATE )
123 
-				->withItemIdSnakValueList( $items, Role::OBJECT );
120 
+			$message = (new ViolationMessage('wbqc-violation-message-item'))
121 
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
122 
+				->withEntityId($propertyId, Role::PREDICATE)
123 
+				->withItemIdSnakValueList($items, Role::OBJECT);
124 124 
 		}
125 125
126 
-		return new CheckResult( $context, $constraint, $status, $message );
126 
+		return new CheckResult($context, $constraint, $status, $message);
127 127 
 	}
128 128
129 
-	public function checkConstraintParameters( Constraint $constraint ): array {
129 
+	public function checkConstraintParameters(Constraint $constraint): array {
130 130 
 		$constraintParameters = $constraint->getConstraintParameters();
131 131 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
132 132 
 		$exceptions = [];
 
@@ -135,7 +135,7 @@  discard block
 
 block discarded – undo
135 135 
 				$constraintParameters,
136 136 
 				$constraintTypeItemId
137 137 
 			);
138 
-		} catch ( ConstraintParameterException $e ) {
138 
+		} catch (ConstraintParameterException $e) {
139 139 
 			$exceptions[] = $e;
140 140 
 		}
141 141 
 		try {
 
@@ -144,7 +144,7 @@  discard block
 
 block discarded – undo
144 144 
 				$constraintTypeItemId,
145 145 
 				false
146 146 
 			);
147 
-		} catch ( ConstraintParameterException $e ) {
147 
+		} catch (ConstraintParameterException $e) {
148 148 
 			$exceptions[] = $e;
149 149 
 		}
150 150 
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/QualifiersChecker.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch 
@@ -67,9 +67,9 @@  discard block
 
 block discarded – undo
67 67 
 	 * @throws ConstraintParameterException
68 68 
 	 * @return CheckResult
69 69 
 	 */
70 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
71 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
72 
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
70 
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
71 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
72 
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
73 73 
 		}
74 74
75 75 
 		$constraintParameters = $constraint->getConstraintParameters();
 
@@ -84,33 +84,33 @@  discard block
 
 block discarded – undo
84 84 
 		$status = CheckResult::STATUS_COMPLIANCE;
85 85
86 86 
 		/** @var Snak $qualifier */
87 
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
87 
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
88 88 
 			$allowedQualifier = false;
89 
-			foreach ( $properties as $property ) {
90 
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
89 
+			foreach ($properties as $property) {
90 
+				if ($qualifier->getPropertyId()->equals($property)) {
91 91 
 					$allowedQualifier = true;
92 92 
 					break;
93 93 
 				}
94 94 
 			}
95 
-			if ( !$allowedQualifier ) {
96 
-				if ( $properties === [] || $properties === [ '' ] ) {
97 
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
98 
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
95 
+			if (!$allowedQualifier) {
96 
+				if ($properties === [] || $properties === ['']) {
97 
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
98 
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
99 99 
 				} else {
100 
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
101 
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
102 
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
103 
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
100 
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
101 
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
102 
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
103 
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
104 104 
 				}
105 105 
 				$status = CheckResult::STATUS_VIOLATION;
106 106 
 				break;
107 107 
 			}
108 108 
 		}
109 109
110 
-		return new CheckResult( $context, $constraint, $status, $message );
110 
+		return new CheckResult($context, $constraint, $status, $message);
111 111 
 	}
112 112
113 
-	public function checkConstraintParameters( Constraint $constraint ): array {
113 
+	public function checkConstraintParameters(Constraint $constraint): array {
114 114 
 		$constraintParameters = $constraint->getConstraintParameters();
115 115 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
116 116 
 		$exceptions = [];
 
@@ -119,7 +119,7 @@  discard block
 
 block discarded – undo
119 119 
 				$constraintParameters,
120 120 
 				$constraintTypeItemId
121 121 
 			);
122 
-		} catch ( ConstraintParameterException $e ) {
122 
+		} catch (ConstraintParameterException $e) {
123 123 
 			$exceptions[] = $e;
124 124 
 		}
125 125 
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/SingleValueChecker.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch 
@@ -64,9 +64,9 @@  discard block
 
 block discarded – undo
64 64 
 	 * @throws ConstraintParameterException
65 65 
 	 * @return CheckResult
66 66 
 	 */
67 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
68 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
69 
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
67 
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
68 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
69 
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
70 70 
 		}
71 71
72 72 
 		$separators = $this->constraintParameterParser->parseSeparatorsParameter(
 
@@ -75,19 +75,19 @@  discard block
 
 block discarded – undo
75 75
76 76 
 		$propertyId = $context->getSnak()->getPropertyId();
77 77 
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
78 
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
78 
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
79 79 
 			$propertyId
80 80 
 		);
81 81
82 
-		if ( $propertyCount > 1 ) {
83 
-			$message = $this->getViolationMessage( $separators, $propertyId );
82 
+		if ($propertyCount > 1) {
83 
+			$message = $this->getViolationMessage($separators, $propertyId);
84 84 
 			$status = CheckResult::STATUS_VIOLATION;
85 85 
 		} else {
86 86 
 			$message = null;
87 87 
 			$status = CheckResult::STATUS_COMPLIANCE;
88 88 
 		}
89 89
90 
-		return new CheckResult( $context, $constraint, $status, $message );
90 
+		return new CheckResult($context, $constraint, $status, $message);
91 91 
 	}
92 92
93 93 
 	/**
 
@@ -95,22 +95,21 @@  discard block
 
 block discarded – undo
95 95 
 	 * @param PropertyId $propertyId
96 96 
 	 * @return ViolationMessage
97 97 
 	 */
98 
-	private function getViolationMessage( array $separators, PropertyId $propertyId ) {
98 
+	private function getViolationMessage(array $separators, PropertyId $propertyId) {
99 99 
 		$messageKey = $separators === [] ?
100 
-			'wbqc-violation-message-single-value' :
101 
-			'wbqc-violation-message-single-value-separators';
100 
+			'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
102 101
103 
-		return ( new ViolationMessage( $messageKey ) )
104 
-			->withEntityId( $propertyId )
105 
-			->withEntityIdList( $separators );
102 
+		return (new ViolationMessage($messageKey))
103 
+			->withEntityId($propertyId)
104 
+			->withEntityIdList($separators);
106 105 
 	}
107 106
108 
-	public function checkConstraintParameters( Constraint $constraint ): array {
107 
+	public function checkConstraintParameters(Constraint $constraint): array {
109 108 
 		$constraintParameters = $constraint->getConstraintParameters();
110 109 
 		$exceptions = [];
111 110 
 		try {
112 
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
113 
-		} catch ( ConstraintParameterException $e ) {
111 
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
112 
+		} catch (ConstraintParameterException $e) {
114 113 
 			$exceptions[] = $e;
115 114 
 		}
116 115 
 		return $exceptions;
Please login to merge, or discard this patch.