wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ServiceWiring.php

Spacing +145 added lines, -145 removed lines

@@ -30,53 +30,53 @@ 
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer;
 
 return [
-	ConstraintsServices::EXPIRY_LOCK => static function ( MediaWikiServices $services ): ExpiryLock {
-		return new ExpiryLock( $services->getObjectCacheFactory()->getInstance( CACHE_ANYTHING ) );
+	ConstraintsServices::EXPIRY_LOCK => static function(MediaWikiServices $services): ExpiryLock {
+		return new ExpiryLock($services->getObjectCacheFactory()->getInstance(CACHE_ANYTHING));
 	},
 
-	ConstraintsServices::LOGGING_HELPER => static function ( MediaWikiServices $services ): LoggingHelper {
+	ConstraintsServices::LOGGING_HELPER => static function(MediaWikiServices $services): LoggingHelper {
 		return new LoggingHelper(
 			$services->getStatsdDataFactory(),
-			LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
+			LoggerFactory::getInstance('WikibaseQualityConstraints'),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_STORE => static function ( MediaWikiServices $services ): ConstraintRepositoryStore {
-		$sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services );
-		$propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE );
-		if ( $propertySource === null ) {
-			throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' );
+	ConstraintsServices::CONSTRAINT_STORE => static function(MediaWikiServices $services): ConstraintRepositoryStore {
+		$sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services);
+		$propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE);
+		if ($propertySource === null) {
+			throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.');
 		}
 
-		$localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName();
-		if ( $propertySource->getSourceName() !== $localEntitySourceName ) {
-			throw new RuntimeException( 'Can\'t get a ConstraintStore for a non local entity source.' );
+		$localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName();
+		if ($propertySource->getSourceName() !== $localEntitySourceName) {
+			throw new RuntimeException('Can\'t get a ConstraintStore for a non local entity source.');
 		}
 
 		$dbName = $propertySource->getDatabaseName();
 		return new ConstraintRepositoryStore(
-			$services->getDBLoadBalancerFactory()->getMainLB( $dbName ),
+			$services->getDBLoadBalancerFactory()->getMainLB($dbName),
 			$dbName
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_LOOKUP => static function ( MediaWikiServices $services ): ConstraintLookup {
-		$sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services );
-		$propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE );
-		if ( $propertySource === null ) {
-			throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' );
+	ConstraintsServices::CONSTRAINT_LOOKUP => static function(MediaWikiServices $services): ConstraintLookup {
+		$sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services);
+		$propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE);
+		if ($propertySource === null) {
+			throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.');
 		}
 
 		$dbName = $propertySource->getDatabaseName();
 		$rawLookup = new ConstraintRepositoryLookup(
-			$services->getDBLoadBalancerFactory()->getMainLB( $dbName ),
+			$services->getDBLoadBalancerFactory()->getMainLB($dbName),
 			$dbName
 		);
-		return new CachingConstraintLookup( $rawLookup );
+		return new CachingConstraintLookup($rawLookup);
 	},
 
-	ConstraintsServices::CHECK_RESULT_SERIALIZER => static function ( MediaWikiServices $services ): CheckResultSerializer {
+	ConstraintsServices::CHECK_RESULT_SERIALIZER => static function(MediaWikiServices $services): CheckResultSerializer {
 		return new CheckResultSerializer(
 			new ConstraintSerializer(
 				false // constraint parameters are not exposed
@@ -87,9 +87,9 @@ 
 		);
 	},
 
-	ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function ( MediaWikiServices $services ): CheckResultDeserializer {
-		$entityIdParser = WikibaseRepo::getEntityIdParser( $services );
-		$dataValueFactory = WikibaseRepo::getDataValueFactory( $services );
+	ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function(MediaWikiServices $services): CheckResultDeserializer {
+		$entityIdParser = WikibaseRepo::getEntityIdParser($services);
+		$dataValueFactory = WikibaseRepo::getDataValueFactory($services);
 
 		return new CheckResultDeserializer(
 			new ConstraintDeserializer(),
@@ -102,17 +102,17 @@ 
 		);
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function (
+	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function(
 		MediaWikiServices $services
 	): ViolationMessageSerializer {
 		return new ViolationMessageSerializer();
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function (
+	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function(
 		MediaWikiServices $services
 	): ViolationMessageDeserializer {
-		$entityIdParser = WikibaseRepo::getEntityIdParser( $services );
-		$dataValueFactory = WikibaseRepo::getDataValueFactory( $services );
+		$entityIdParser = WikibaseRepo::getEntityIdParser($services);
+		$dataValueFactory = WikibaseRepo::getDataValueFactory($services);
 
 		return new ViolationMessageDeserializer(
 			$entityIdParser,
@@ -120,40 +120,40 @@ 
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function (
+	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function(
 		MediaWikiServices $services
 	): ConstraintParameterParser {
-		$deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory( $services );
-		$entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services );
+		$deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory($services);
+		$entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services);
 
 		return new ConstraintParameterParser(
 			$services->getMainConfig(),
 			$deserializerFactory,
-			$entitySourceDefinitions->getDatabaseSourceForEntityType( 'item' )->getConceptBaseUri()
+			$entitySourceDefinitions->getDatabaseSourceForEntityType('item')->getConceptBaseUri()
 		);
 	},
 
-	ConstraintsServices::CONNECTION_CHECKER_HELPER => static function ( MediaWikiServices $services ): ConnectionCheckerHelper {
+	ConstraintsServices::CONNECTION_CHECKER_HELPER => static function(MediaWikiServices $services): ConnectionCheckerHelper {
 		return new ConnectionCheckerHelper();
 	},
 
-	ConstraintsServices::RANGE_CHECKER_HELPER => static function ( MediaWikiServices $services ): RangeCheckerHelper {
+	ConstraintsServices::RANGE_CHECKER_HELPER => static function(MediaWikiServices $services): RangeCheckerHelper {
 		return new RangeCheckerHelper(
 			$services->getMainConfig(),
-			WikibaseRepo::getUnitConverter( $services )
+			WikibaseRepo::getUnitConverter($services)
 		);
 	},
 
-	ConstraintsServices::SPARQL_HELPER => static function ( MediaWikiServices $services ): SparqlHelper {
-		$endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' );
-		if ( $endpoint === '' ) {
+	ConstraintsServices::SPARQL_HELPER => static function(MediaWikiServices $services): SparqlHelper {
+		$endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint');
+		if ($endpoint === '') {
 			return new DummySparqlHelper();
 		}
 
-		$rdfVocabulary = WikibaseRepo::getRdfVocabulary( $services );
-		$valueSnakRdfBuilderFactory = WikibaseRepo::getValueSnakRdfBuilderFactory( $services );
-		$entityIdParser = WikibaseRepo::getEntityIdParser( $services );
-		$propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup( $services );
+		$rdfVocabulary = WikibaseRepo::getRdfVocabulary($services);
+		$valueSnakRdfBuilderFactory = WikibaseRepo::getValueSnakRdfBuilderFactory($services);
+		$entityIdParser = WikibaseRepo::getEntityIdParser($services);
+		$propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup($services);
 
 		return new SparqlHelper(
 			$services->getMainConfig(),
@@ -162,128 +162,128 @@ 
 			$entityIdParser,
 			$propertyDataTypeLookup,
 			$services->getMainWANObjectCache(),
-			ConstraintsServices::getViolationMessageSerializer( $services ),
-			ConstraintsServices::getViolationMessageDeserializer( $services ),
+			ConstraintsServices::getViolationMessageSerializer($services),
+			ConstraintsServices::getViolationMessageDeserializer($services),
 			$services->getStatsdDataFactory(),
-			ConstraintsServices::getExpiryLock( $services ),
-			ConstraintsServices::getLoggingHelper( $services ),
-			WikiMap::getCurrentWikiId() . ' WikibaseQualityConstraints ' . $services->getHttpRequestFactory()->getUserAgent(),
+			ConstraintsServices::getExpiryLock($services),
+			ConstraintsServices::getLoggingHelper($services),
+			WikiMap::getCurrentWikiId().' WikibaseQualityConstraints '.$services->getHttpRequestFactory()->getUserAgent(),
 			$services->getHttpRequestFactory()
 		);
 	},
 
-	ConstraintsServices::TYPE_CHECKER_HELPER => static function ( MediaWikiServices $services ): TypeCheckerHelper {
+	ConstraintsServices::TYPE_CHECKER_HELPER => static function(MediaWikiServices $services): TypeCheckerHelper {
 		return new TypeCheckerHelper(
-			WikibaseServices::getEntityLookup( $services ),
+			WikibaseServices::getEntityLookup($services),
 			$services->getMainConfig(),
-			ConstraintsServices::getSparqlHelper( $services ),
-			$services->getStatsFactory()->withComponent( 'WikibaseQualityConstraints' )
+			ConstraintsServices::getSparqlHelper($services),
+			$services->getStatsFactory()->withComponent('WikibaseQualityConstraints')
 		);
 	},
 
-	ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function (
+	ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function(
 		MediaWikiServices $services
 	): DelegatingConstraintChecker {
-		$statementGuidParser = WikibaseRepo::getStatementGuidParser( $services );
+		$statementGuidParser = WikibaseRepo::getStatementGuidParser($services);
 
 		$config = $services->getMainConfig();
 		$checkerMap = [
-			$config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
-				=> ConstraintCheckerServices::getConflictsWithChecker( $services ),
-			$config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
-				=> ConstraintCheckerServices::getItemChecker( $services ),
-			$config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
-				=> ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ),
-			$config->get( 'WBQualityConstraintsSymmetricConstraintId' )
-				=> ConstraintCheckerServices::getSymmetricChecker( $services ),
-			$config->get( 'WBQualityConstraintsInverseConstraintId' )
-				=> ConstraintCheckerServices::getInverseChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
-				=> ConstraintCheckerServices::getQualifierChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
-				=> ConstraintCheckerServices::getQualifiersChecker( $services ),
-			$config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
-				=> ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ),
-			$config->get( 'WBQualityConstraintsRangeConstraintId' )
-				=> ConstraintCheckerServices::getRangeChecker( $services ),
-			$config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
-				=> ConstraintCheckerServices::getDiffWithinRangeChecker( $services ),
-			$config->get( 'WBQualityConstraintsTypeConstraintId' )
-				=> ConstraintCheckerServices::getTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsValueTypeConstraintId' )
-				=> ConstraintCheckerServices::getValueTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsSingleValueConstraintId' )
-				=> ConstraintCheckerServices::getSingleValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsMultiValueConstraintId' )
-				=> ConstraintCheckerServices::getMultiValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
-				=> ConstraintCheckerServices::getUniqueValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsFormatConstraintId' )
-				=> ConstraintCheckerServices::getFormatChecker( $services ),
-			$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
-				=> ConstraintCheckerServices::getCommonsLinkChecker( $services ),
-			$config->get( 'WBQualityConstraintsOneOfConstraintId' )
-				=> ConstraintCheckerServices::getOneOfChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
-				=> ConstraintCheckerServices::getValueOnlyChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
-				=> ConstraintCheckerServices::getReferenceChecker( $services ),
-			$config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
-				=> ConstraintCheckerServices::getNoBoundsChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
-				=> ConstraintCheckerServices::getAllowedUnitsChecker( $services ),
-			$config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
-				=> ConstraintCheckerServices::getSingleBestValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
-				=> ConstraintCheckerServices::getEntityTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsNoneOfConstraintId' )
-				=> ConstraintCheckerServices::getNoneOfChecker( $services ),
-			$config->get( 'WBQualityConstraintsIntegerConstraintId' )
-				=> ConstraintCheckerServices::getIntegerChecker( $services ),
-			$config->get( 'WBQualityConstraintsCitationNeededConstraintId' )
-				=> ConstraintCheckerServices::getCitationNeededChecker( $services ),
-			$config->get( 'WBQualityConstraintsPropertyScopeConstraintId' )
-				=> ConstraintCheckerServices::getPropertyScopeChecker( $services ),
-			$config->get( 'WBQualityConstraintsContemporaryConstraintId' )
-				=> ConstraintCheckerServices::getContemporaryChecker( $services ),
-			$config->get( 'WBQualityConstraintsLexemeLanguageConstraintId' )
-				=> ConstraintCheckerServices::getLexemeLanguageChecker( $services ),
-			$config->get( 'WBQualityConstraintsLabelInLanguageConstraintId' )
-				=> ConstraintCheckerServices::getLabelInLanguageChecker( $services ),
+			$config->get('WBQualityConstraintsConflictsWithConstraintId')
+				=> ConstraintCheckerServices::getConflictsWithChecker($services),
+			$config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
+				=> ConstraintCheckerServices::getItemChecker($services),
+			$config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
+				=> ConstraintCheckerServices::getTargetRequiredClaimChecker($services),
+			$config->get('WBQualityConstraintsSymmetricConstraintId')
+				=> ConstraintCheckerServices::getSymmetricChecker($services),
+			$config->get('WBQualityConstraintsInverseConstraintId')
+				=> ConstraintCheckerServices::getInverseChecker($services),
+			$config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
+				=> ConstraintCheckerServices::getQualifierChecker($services),
+			$config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
+				=> ConstraintCheckerServices::getQualifiersChecker($services),
+			$config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
+				=> ConstraintCheckerServices::getMandatoryQualifiersChecker($services),
+			$config->get('WBQualityConstraintsRangeConstraintId')
+				=> ConstraintCheckerServices::getRangeChecker($services),
+			$config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
+				=> ConstraintCheckerServices::getDiffWithinRangeChecker($services),
+			$config->get('WBQualityConstraintsTypeConstraintId')
+				=> ConstraintCheckerServices::getTypeChecker($services),
+			$config->get('WBQualityConstraintsValueTypeConstraintId')
+				=> ConstraintCheckerServices::getValueTypeChecker($services),
+			$config->get('WBQualityConstraintsSingleValueConstraintId')
+				=> ConstraintCheckerServices::getSingleValueChecker($services),
+			$config->get('WBQualityConstraintsMultiValueConstraintId')
+				=> ConstraintCheckerServices::getMultiValueChecker($services),
+			$config->get('WBQualityConstraintsDistinctValuesConstraintId')
+				=> ConstraintCheckerServices::getUniqueValueChecker($services),
+			$config->get('WBQualityConstraintsFormatConstraintId')
+				=> ConstraintCheckerServices::getFormatChecker($services),
+			$config->get('WBQualityConstraintsCommonsLinkConstraintId')
+				=> ConstraintCheckerServices::getCommonsLinkChecker($services),
+			$config->get('WBQualityConstraintsOneOfConstraintId')
+				=> ConstraintCheckerServices::getOneOfChecker($services),
+			$config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
+				=> ConstraintCheckerServices::getValueOnlyChecker($services),
+			$config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
+				=> ConstraintCheckerServices::getReferenceChecker($services),
+			$config->get('WBQualityConstraintsNoBoundsConstraintId')
+				=> ConstraintCheckerServices::getNoBoundsChecker($services),
+			$config->get('WBQualityConstraintsAllowedUnitsConstraintId')
+				=> ConstraintCheckerServices::getAllowedUnitsChecker($services),
+			$config->get('WBQualityConstraintsSingleBestValueConstraintId')
+				=> ConstraintCheckerServices::getSingleBestValueChecker($services),
+			$config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
+				=> ConstraintCheckerServices::getEntityTypeChecker($services),
+			$config->get('WBQualityConstraintsNoneOfConstraintId')
+				=> ConstraintCheckerServices::getNoneOfChecker($services),
+			$config->get('WBQualityConstraintsIntegerConstraintId')
+				=> ConstraintCheckerServices::getIntegerChecker($services),
+			$config->get('WBQualityConstraintsCitationNeededConstraintId')
+				=> ConstraintCheckerServices::getCitationNeededChecker($services),
+			$config->get('WBQualityConstraintsPropertyScopeConstraintId')
+				=> ConstraintCheckerServices::getPropertyScopeChecker($services),
+			$config->get('WBQualityConstraintsContemporaryConstraintId')
+				=> ConstraintCheckerServices::getContemporaryChecker($services),
+			$config->get('WBQualityConstraintsLexemeLanguageConstraintId')
+				=> ConstraintCheckerServices::getLexemeLanguageChecker($services),
+			$config->get('WBQualityConstraintsLabelInLanguageConstraintId')
+				=> ConstraintCheckerServices::getLabelInLanguageChecker($services),
 		];
 
 		return new DelegatingConstraintChecker(
-			WikibaseServices::getEntityLookup( $services ),
+			WikibaseServices::getEntityLookup($services),
 			$checkerMap,
-			ConstraintsServices::getConstraintLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
+			ConstraintsServices::getConstraintLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
 			$statementGuidParser,
-			ConstraintsServices::getLoggingHelper( $services ),
-			$config->get( 'WBQualityConstraintsCheckQualifiers' ),
-			$config->get( 'WBQualityConstraintsCheckReferences' ),
-			$config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
+			ConstraintsServices::getLoggingHelper($services),
+			$config->get('WBQualityConstraintsCheckQualifiers'),
+			$config->get('WBQualityConstraintsCheckReferences'),
+			$config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
 		);
 	},
 
-	ConstraintsServices::RESULTS_SOURCE => static function ( MediaWikiServices $services ): ResultsSource {
+	ConstraintsServices::RESULTS_SOURCE => static function(MediaWikiServices $services): ResultsSource {
 		$config = $services->getMainConfig();
 		$resultsSource = new CheckingResultsSource(
-			ConstraintsServices::getDelegatingConstraintChecker( $services )
+			ConstraintsServices::getDelegatingConstraintChecker($services)
 		);
 
 		$cacheCheckConstraintsResults = false;
 
-		if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
+		if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
 			$cacheCheckConstraintsResults = true;
 			// check that we can use getLocalRepoWikiPageMetaDataAccessor()
 			// TODO we should always be able to cache constraint check results (T244726)
-			$entitySources = WikibaseRepo::getEntitySourceDefinitions( $services )->getSources();
-			$localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName();
+			$entitySources = WikibaseRepo::getEntitySourceDefinitions($services)->getSources();
+			$localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName();
 
-			foreach ( $entitySources as $entitySource ) {
-				if ( $entitySource->getSourceName() !== $localEntitySourceName ) {
-					LoggerFactory::getInstance( 'WikibaseQualityConstraints' )->warning(
-						'Cannot cache constraint check results for non-local source: ' .
+			foreach ($entitySources as $entitySource) {
+				if ($entitySource->getSourceName() !== $localEntitySourceName) {
+					LoggerFactory::getInstance('WikibaseQualityConstraints')->warning(
+						'Cannot cache constraint check results for non-local source: '.
 						$entitySource->getSourceName()
 					);
 					$cacheCheckConstraintsResults = false;
@@ -292,42 +292,42 @@ 
 			}
 		}
 
-		if ( $cacheCheckConstraintsResults ) {
+		if ($cacheCheckConstraintsResults) {
 			$possiblyStaleConstraintTypes = [
-				$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
-				$config->get( 'WBQualityConstraintsTypeConstraintId' ),
-				$config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
-				$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
+				$config->get('WBQualityConstraintsCommonsLinkConstraintId'),
+				$config->get('WBQualityConstraintsTypeConstraintId'),
+				$config->get('WBQualityConstraintsValueTypeConstraintId'),
+				$config->get('WBQualityConstraintsDistinctValuesConstraintId'),
 			];
-			$entityIdParser = WikibaseRepo::getEntityIdParser( $services );
+			$entityIdParser = WikibaseRepo::getEntityIdParser($services);
 			$wikiPageEntityMetaDataAccessor = WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor(
 				$services );
 
 			$resultsSource = new CachingResultsSource(
 				$resultsSource,
 				ResultsCache::getDefaultInstance(),
-				ConstraintsServices::getCheckResultSerializer( $services ),
-				ConstraintsServices::getCheckResultDeserializer( $services ),
+				ConstraintsServices::getCheckResultSerializer($services),
+				ConstraintsServices::getCheckResultDeserializer($services),
 				$wikiPageEntityMetaDataAccessor,
 				$entityIdParser,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
+				$config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
 				$possiblyStaleConstraintTypes,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ),
-				ConstraintsServices::getLoggingHelper( $services )
+				$config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'),
+				ConstraintsServices::getLoggingHelper($services)
 			);
 		}
 
 		return $resultsSource;
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_RENDERER_FACTORY => static function (
+	ConstraintsServices::VIOLATION_MESSAGE_RENDERER_FACTORY => static function(
 		MediaWikiServices $services
 	): ViolationMessageRendererFactory {
 		return new ViolationMessageRendererFactory(
 			$services->getMainConfig(),
 			$services->getLanguageNameUtils(),
-			WikibaseRepo::getEntityIdHtmlLinkFormatterFactory( $services ),
-			WikibaseRepo::getValueFormatterFactory( $services )
+			WikibaseRepo::getEntityIdHtmlLinkFormatterFactory($services),
+			WikibaseRepo::getValueFormatterFactory($services)
 		);
 	},
 ];

src/ConstraintCheck/Helper/SparqlHelper.php

Spacing +203 added lines, -207 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Helper;
 
@@ -166,143 +166,143 @@ 
 		$this->defaultUserAgent = $defaultUserAgent;
 		$this->requestFactory = $requestFactory;
 		$this->entityPrefixes = [];
-		foreach ( $rdfVocabulary->entityNamespaceNames as $namespaceName ) {
-			$this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI( $namespaceName );
+		foreach ($rdfVocabulary->entityNamespaceNames as $namespaceName) {
+			$this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI($namespaceName);
 		}
 
-		$this->primaryEndpoint = $config->get( 'WBQualityConstraintsSparqlEndpoint' );
-		$this->additionalEndpoints = $config->get( 'WBQualityConstraintsAdditionalSparqlEndpoints' ) ?: [];
-		$this->maxQueryTimeMillis = $config->get( 'WBQualityConstraintsSparqlMaxMillis' );
-		$this->subclassOfId = new NumericPropertyId( $config->get( 'WBQualityConstraintsSubclassOfId' ) );
-		$this->cacheMapSize = $config->get( 'WBQualityConstraintsFormatCacheMapSize' );
+		$this->primaryEndpoint = $config->get('WBQualityConstraintsSparqlEndpoint');
+		$this->additionalEndpoints = $config->get('WBQualityConstraintsAdditionalSparqlEndpoints') ?: [];
+		$this->maxQueryTimeMillis = $config->get('WBQualityConstraintsSparqlMaxMillis');
+		$this->subclassOfId = new NumericPropertyId($config->get('WBQualityConstraintsSubclassOfId'));
+		$this->cacheMapSize = $config->get('WBQualityConstraintsFormatCacheMapSize');
 		$this->timeoutExceptionClasses = $config->get(
 			'WBQualityConstraintsSparqlTimeoutExceptionClasses'
 		);
 		$this->sparqlHasWikibaseSupport = $config->get(
 			'WBQualityConstraintsSparqlHasWikibaseSupport'
 		);
-		$this->sparqlThrottlingFallbackDuration = (int)$config->get(
+		$this->sparqlThrottlingFallbackDuration = (int) $config->get(
 			'WBQualityConstraintsSparqlThrottlingFallbackDuration'
 		);
 
-		$this->prefixes = $this->getQueryPrefixes( $rdfVocabulary );
+		$this->prefixes = $this->getQueryPrefixes($rdfVocabulary);
 
 		$this->rdfVocabularyWithoutNormalization = clone $rdfVocabulary;
 		// @phan-suppress-next-line PhanTypeMismatchProperty
 		$this->rdfVocabularyWithoutNormalization->normalizedPropertyValueNamespace = array_fill_keys(
-			array_keys( $rdfVocabulary->normalizedPropertyValueNamespace ),
+			array_keys($rdfVocabulary->normalizedPropertyValueNamespace),
 			null
 		);
 	}
 
-	private function getQueryPrefixes( RdfVocabulary $rdfVocabulary ): string {
+	private function getQueryPrefixes(RdfVocabulary $rdfVocabulary): string {
 		// TODO: it would probably be smarter that RdfVocabulary exposed these prefixes somehow
 		$prefixes = '';
-		foreach ( $rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName ) {
+		foreach ($rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName) {
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 
-		foreach ( $rdfVocabulary->statementNamespaceNames as $sourceName => $sourceNamespaces ) {
+		foreach ($rdfVocabulary->statementNamespaceNames as $sourceName => $sourceNamespaces) {
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NS_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 
-		foreach ( $rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces ) {
+		foreach ($rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces) {
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_DIRECT_CLAIM];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM_STATEMENT];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 		$namespaceName = RdfVocabulary::NS_ONTOLOGY;
 		$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		return $prefixes;
 	}
 
 	/** Return a SPARQL term like `wd:Q123` for the given ID. */
-	private function wd( EntityId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function wd(EntityId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->entityNamespaceNames[$repository];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `wdt:P123` for the given ID. */
-	private function wdt( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function wdt(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_DIRECT_CLAIM];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `p:P123` for the given ID. */
-	private function p( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function p(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_CLAIM];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `pq:P123` for the given ID. */
-	private function pq( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function pq(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_QUALIFIER];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `wdno:P123` for the given ID. */
-	private function wdno( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function wdno(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_NOVALUE];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `prov:NAME` for the given name. */
-	private function prov( string $name ): string {
+	private function prov(string $name): string {
 		$prefix = RdfVocabulary::NS_PROV;
 		return "$prefix:$name";
 	}
 
 	/** Return a SPARQL term like `wikibase:NAME` for the given name. */
-	private function wikibase( string $name ): string {
+	private function wikibase(string $name): string {
 		$prefix = RdfVocabulary::NS_ONTOLOGY;
 		return "$prefix:$name";
 	}
 
 	/** Return a SPARQL snippet like `MINUS { ?var wikibase:rank wikibase:DeprecatedRank. }`. */
-	private function minusDeprecatedRank( string $varName ): string {
+	private function minusDeprecatedRank(string $varName): string {
 		$deprecatedRank = RdfVocabulary::RANK_MAP[Statement::RANK_DEPRECATED];
-		return "MINUS { $varName {$this->wikibase( 'rank' )} {$this->wikibase( $deprecatedRank )}. }";
+		return "MINUS { $varName {$this->wikibase('rank')} {$this->wikibase($deprecatedRank)}. }";
 	}
 
 	/**
@@ -312,43 +312,42 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	public function hasType( EntityId $id, array $classes ): CachedBool {
+	public function hasType(EntityId $id, array $classes): CachedBool {
 		// TODO hint:gearing is a workaround for T168973 and can hopefully be removed eventually
 		$gearingHint = $this->sparqlHasWikibaseSupport ?
-			' hint:Prior hint:gearing "forward".' :
-			'';
+			' hint:Prior hint:gearing "forward".' : '';
 
 		$metadatas = [];
 
-		foreach ( array_chunk( $classes, 20 ) as $classesChunk ) {
-			$classesValues = implode( ' ', array_map(
-				function ( string $class ) {
-					return $this->wd( new ItemId( $class ) );
+		foreach (array_chunk($classes, 20) as $classesChunk) {
+			$classesValues = implode(' ', array_map(
+				function(string $class) {
+					return $this->wd(new ItemId($class));
 				},
 				$classesChunk
-			) );
+			));
 
 			$query = <<<EOF
 ASK {
-  BIND({$this->wd( $id )} AS ?item)
+  BIND({$this->wd($id)} AS ?item)
   VALUES ?class { $classesValues }
-  ?item {$this->wdt( $this->subclassOfId )}* ?class.$gearingHint
+  ?item {$this->wdt($this->subclassOfId)}* ?class.$gearingHint
 }
 EOF;
 
-			$result = $this->runQuery( $query, $this->primaryEndpoint );
+			$result = $this->runQuery($query, $this->primaryEndpoint);
 			$metadatas[] = $result->getMetadata();
-			if ( $result->getArray()['boolean'] ) {
+			if ($result->getArray()['boolean']) {
 				return new CachedBool(
 					true,
-					Metadata::merge( $metadatas )
+					Metadata::merge($metadatas)
 				);
 			}
 		}
 
 		return new CachedBool(
 			false,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -365,12 +364,12 @@ 
 		array $separators
 	): CachedEntityIds {
 		$mainSnak = $statement->getMainSnak();
-		if ( !( $mainSnak instanceof PropertyValueSnak ) ) {
-			return new CachedEntityIds( [], Metadata::blank() );
+		if (!($mainSnak instanceof PropertyValueSnak)) {
+			return new CachedEntityIds([], Metadata::blank());
 		}
 
 		$propertyId = $statement->getPropertyId();
-		$pPredicateAndObject = "{$this->p( $propertyId )} ?otherStatement."; // p:P123 ?otherStatement.
+		$pPredicateAndObject = "{$this->p($propertyId)} ?otherStatement."; // p:P123 ?otherStatement.
 		$otherStatementPredicateAndObject = $this->getSnakPredicateAndObject(
 			$entityId,
 			$mainSnak,
@@ -379,57 +378,57 @@ 
 
 		$isSeparator = [];
 		$unusedSeparators = [];
-		foreach ( $separators as $separator ) {
+		foreach ($separators as $separator) {
 			$isSeparator[$separator->getSerialization()] = true;
 			$unusedSeparators[$separator->getSerialization()] = $separator;
 		}
 		$separatorFilters = '';
-		foreach ( $statement->getQualifiers() as $qualifier ) {
+		foreach ($statement->getQualifiers() as $qualifier) {
 			$qualPropertyId = $qualifier->getPropertyId();
-			if ( !( $isSeparator[$qualPropertyId->getSerialization()] ?? false ) ) {
+			if (!($isSeparator[$qualPropertyId->getSerialization()] ?? false)) {
 				continue;
 			}
-			unset( $unusedSeparators[$qualPropertyId->getSerialization()] );
+			unset($unusedSeparators[$qualPropertyId->getSerialization()]);
 			// only look for other statements with the same qualifier
-			if ( $qualifier instanceof PropertyValueSnak ) {
+			if ($qualifier instanceof PropertyValueSnak) {
 				$sepPredicateAndObject = $this->getSnakPredicateAndObject(
 					$entityId,
 					$qualifier,
 					RdfVocabulary::NSP_QUALIFIER
 				);
 				$separatorFilters .= "  ?otherStatement $sepPredicateAndObject\n";
-			} elseif ( $qualifier instanceof PropertyNoValueSnak ) {
-				$sepPredicateAndObject = "a {$this->wdno( $qualPropertyId )}."; // a wdno:P123.
+			} elseif ($qualifier instanceof PropertyNoValueSnak) {
+				$sepPredicateAndObject = "a {$this->wdno($qualPropertyId)}."; // a wdno:P123.
 				$separatorFilters .= "  ?otherStatement $sepPredicateAndObject\n";
 			} else {
 				// "some value" / "unknown value" is always different from everything else,
 				// therefore the whole statement has no duplicates and we can return immediately
-				return new CachedEntityIds( [], Metadata::blank() );
+				return new CachedEntityIds([], Metadata::blank());
 			}
 		}
-		foreach ( $unusedSeparators as $unusedSeparator ) {
+		foreach ($unusedSeparators as $unusedSeparator) {
 			// exclude other statements which have a separator that this one lacks
-			$separatorFilters .= "  MINUS { ?otherStatement {$this->pq( $unusedSeparator )} []. }\n";
-			$separatorFilters .= "  MINUS { ?otherStatement a {$this->wdno( $unusedSeparator )}. }\n";
+			$separatorFilters .= "  MINUS { ?otherStatement {$this->pq($unusedSeparator)} []. }\n";
+			$separatorFilters .= "  MINUS { ?otherStatement a {$this->wdno($unusedSeparator)}. }\n";
 		}
 
 		$query = <<<SPARQL
 SELECT DISTINCT ?otherEntity WHERE {
   ?otherEntity $pPredicateAndObject
   ?otherStatement $otherStatementPredicateAndObject
-  {$this->minusDeprecatedRank( '?otherStatement' )}
-  FILTER(?otherEntity != {$this->wd( $entityId )})
+  {$this->minusDeprecatedRank('?otherStatement')}
+  FILTER(?otherEntity != {$this->wd($entityId)})
 $separatorFilters
 }
 LIMIT 10
 SPARQL;
 
-		$results = [ $this->runQuery( $query, $this->primaryEndpoint ) ];
-		foreach ( $this->additionalEndpoints as $endpoint ) {
-			$results[] = $this->runQuery( $query, $endpoint );
+		$results = [$this->runQuery($query, $this->primaryEndpoint)];
+		foreach ($this->additionalEndpoints as $endpoint) {
+			$results[] = $this->runQuery($query, $endpoint);
 		}
 
-		return $this->getOtherEntities( $results );
+		return $this->getOtherEntities($results);
 	}
 
 	/**
@@ -448,40 +447,38 @@ 
 		bool $ignoreDeprecatedStatements
 	): CachedEntityIds {
 		$propertyId = $snak->getPropertyId();
-		$pPredicateAndObject = "{$this->p( $propertyId )} ?otherStatement."; // p:P123 ?otherStatement.
+		$pPredicateAndObject = "{$this->p($propertyId)} ?otherStatement."; // p:P123 ?otherStatement.
 
 		$otherSubject = $type === Context::TYPE_QUALIFIER ?
-			'?otherStatement' :
-			"?otherStatement {$this->prov( 'wasDerivedFrom' )} ?reference.\n  ?reference";
+			'?otherStatement' : "?otherStatement {$this->prov('wasDerivedFrom')} ?reference.\n  ?reference";
 		$otherPredicateAndObject = $this->getSnakPredicateAndObject(
 			$entityId,
 			$snak,
 			$type === Context::TYPE_QUALIFIER ?
-				RdfVocabulary::NSP_QUALIFIER :
-				RdfVocabulary::NSP_REFERENCE
+				RdfVocabulary::NSP_QUALIFIER : RdfVocabulary::NSP_REFERENCE
 		);
 
 		$deprecatedFilter = '';
-		if ( $ignoreDeprecatedStatements ) {
-			$deprecatedFilter = '  ' . $this->minusDeprecatedRank( '?otherStatement' );
+		if ($ignoreDeprecatedStatements) {
+			$deprecatedFilter = '  '.$this->minusDeprecatedRank('?otherStatement');
 		}
 
 		$query = <<<SPARQL
 SELECT DISTINCT ?otherEntity WHERE {
   ?otherEntity $pPredicateAndObject
   $otherSubject $otherPredicateAndObject
-  FILTER(?otherEntity != {$this->wd( $entityId )})
+  FILTER(?otherEntity != {$this->wd($entityId)})
 $deprecatedFilter
 }
 LIMIT 10
 SPARQL;
 
-		$results = [ $this->runQuery( $query, $this->primaryEndpoint ) ];
-		foreach ( $this->additionalEndpoints as $endpoint ) {
-			$results[] = $this->runQuery( $query, $endpoint );
+		$results = [$this->runQuery($query, $this->primaryEndpoint)];
+		foreach ($this->additionalEndpoints as $endpoint) {
+			$results[] = $this->runQuery($query, $endpoint);
 		}
 
-		return $this->getOtherEntities( $results );
+		return $this->getOtherEntities($results);
 	}
 
 	/**
@@ -512,13 +509,13 @@ 
 		$writer->start();
 		$writer->drain();
 		$placeholder1 = 'wbqc';
-		$placeholder2 = 'x' . wfRandomString( 32 );
-		$writer->about( $placeholder1, $placeholder2 );
+		$placeholder2 = 'x'.wfRandomString(32);
+		$writer->about($placeholder1, $placeholder2);
 
 		$propertyId = $snak->getPropertyId();
 		$pid = $propertyId->getSerialization();
-		$propertyRepository = $this->rdfVocabulary->getEntityRepositoryName( $propertyId );
-		$entityRepository = $this->rdfVocabulary->getEntityRepositoryName( $entityId );
+		$propertyRepository = $this->rdfVocabulary->getEntityRepositoryName($propertyId);
+		$entityRepository = $this->rdfVocabulary->getEntityRepositoryName($entityId);
 		$propertyNamespace = $this->rdfVocabulary->propertyNamespaceNames[$propertyRepository][$namespace];
 		$value = $snak->getDataValue();
 		if (
@@ -549,21 +546,21 @@ 
 				$writer,
 				$propertyNamespace,
 				$pid,
-				$this->propertyDataTypeLookup->getDataTypeIdForProperty( $propertyId ),
+				$this->propertyDataTypeLookup->getDataTypeIdForProperty($propertyId),
 				$this->rdfVocabulary->statementNamespaceNames[$entityRepository][RdfVocabulary::NS_VALUE], // should be unused
 				$snak
 			);
 		}
 
 		$triple = $writer->drain(); // wbqc:xRANDOM ps:PID "value". or similar
-		return trim( str_replace( "$placeholder1:$placeholder2", '', $triple ) );
+		return trim(str_replace("$placeholder1:$placeholder2", '', $triple));
 	}
 
 	/**
 	 * Return SPARQL code for a string literal with $text as content.
 	 */
-	private function stringLiteral( string $text ): string {
-		return '"' . strtr( $text, [ '"' => '\\"', '\\' => '\\\\' ] ) . '"';
+	private function stringLiteral(string $text): string {
+		return '"'.strtr($text, ['"' => '\\"', '\\' => '\\\\']).'"';
 	}
 
 	/**
@@ -573,26 +570,26 @@ 
 	 *
 	 * @return CachedEntityIds
 	 */
-	private function getOtherEntities( array $results ): CachedEntityIds {
+	private function getOtherEntities(array $results): CachedEntityIds {
 		$allResultBindings = [];
 		$metadatas = [];
 
-		foreach ( $results as $result ) {
+		foreach ($results as $result) {
 			$metadatas[] = $result->getMetadata();
-			$allResultBindings = array_merge( $allResultBindings, $result->getArray()['results']['bindings'] );
+			$allResultBindings = array_merge($allResultBindings, $result->getArray()['results']['bindings']);
 		}
 
 		$entityIds = array_map(
-			function ( $resultBindings ) {
+			function($resultBindings) {
 				$entityIRI = $resultBindings['otherEntity']['value'];
-				foreach ( $this->entityPrefixes as $entityPrefix ) {
-					$entityPrefixLength = strlen( $entityPrefix );
-					if ( substr( $entityIRI, 0, $entityPrefixLength ) === $entityPrefix ) {
+				foreach ($this->entityPrefixes as $entityPrefix) {
+					$entityPrefixLength = strlen($entityPrefix);
+					if (substr($entityIRI, 0, $entityPrefixLength) === $entityPrefix) {
 						try {
 							return $this->entityIdParser->parse(
-								substr( $entityIRI, $entityPrefixLength )
+								substr($entityIRI, $entityPrefixLength)
 							);
-						} catch ( EntityIdParsingException $e ) {
+						} catch (EntityIdParsingException $e) {
 							// fall through
 						}
 					}
@@ -606,8 +603,8 @@ 
 		);
 
 		return new CachedEntityIds(
-			array_values( array_filter( array_unique( $entityIds ) ) ),
-			Metadata::merge( $metadatas )
+			array_values(array_filter(array_unique($entityIds))),
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -615,43 +612,43 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpression( string $text, string $regex ): bool {
+	public function matchesRegularExpression(string $text, string $regex): bool {
 		// caching wrapper around matchesRegularExpressionWithSparql
 
-		$textHash = hash( 'sha256', $text );
+		$textHash = hash('sha256', $text);
 		$cacheKey = $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'regex', // action
 			'WDQS-Java', // regex flavor
-			hash( 'sha256', $regex )
+			hash('sha256', $regex)
 		);
 
 		$cacheMapArray = $this->cache->getWithSetCallback(
 			$cacheKey,
 			WANObjectCache::TTL_DAY,
-			function ( $cacheMapArray ) use ( $text, $regex, $textHash ) {
+			function($cacheMapArray) use ($text, $regex, $textHash) {
 				// Initialize the cache map if not set
-				if ( $cacheMapArray === false ) {
+				if ($cacheMapArray === false) {
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.init';
-					$this->dataFactory->increment( $key );
+					$this->dataFactory->increment($key);
 					return [];
 				}
 
 				$key = 'wikibase.quality.constraints.regex.cache.refresh';
-				$this->dataFactory->increment( $key );
-				$cacheMap = MapCacheLRU::newFromArray( $cacheMapArray, $this->cacheMapSize );
-				if ( $cacheMap->has( $textHash ) ) {
+				$this->dataFactory->increment($key);
+				$cacheMap = MapCacheLRU::newFromArray($cacheMapArray, $this->cacheMapSize);
+				if ($cacheMap->has($textHash)) {
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.hit';
-					$this->dataFactory->increment( $key );
-					$cacheMap->get( $textHash ); // ping cache
+					$this->dataFactory->increment($key);
+					$cacheMap->get($textHash); // ping cache
 				} else {
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.miss';
-					$this->dataFactory->increment( $key );
+					$this->dataFactory->increment($key);
 					try {
-						$matches = $this->matchesRegularExpressionWithSparql( $text, $regex );
-					} catch ( ConstraintParameterException $e ) {
-						$matches = $this->serializeConstraintParameterException( $e );
-					} catch ( SparqlHelperException $e ) {
+						$matches = $this->matchesRegularExpressionWithSparql($text, $regex);
+					} catch (ConstraintParameterException $e) {
+						$matches = $this->serializeConstraintParameterException($e);
+					} catch (SparqlHelperException $e) {
 						// don’t cache this
 						return $cacheMap->toArray();
 					}
@@ -675,42 +672,42 @@ 
 			]
 		);
 
-		if ( isset( $cacheMapArray[$textHash] ) ) {
+		if (isset($cacheMapArray[$textHash])) {
 			$key = 'wikibase.quality.constraints.regex.cache.hit';
-			$this->dataFactory->increment( $key );
+			$this->dataFactory->increment($key);
 			$matches = $cacheMapArray[$textHash];
-			if ( is_bool( $matches ) ) {
+			if (is_bool($matches)) {
 				return $matches;
-			} elseif ( is_array( $matches ) &&
-				$matches['type'] == ConstraintParameterException::class ) {
-				throw $this->deserializeConstraintParameterException( $matches );
+			} elseif (is_array($matches) &&
+				$matches['type'] == ConstraintParameterException::class) {
+				throw $this->deserializeConstraintParameterException($matches);
 			} else {
 				throw new UnexpectedValueException(
-					'Value of unknown type in object cache (' .
-					'cache key: ' . $cacheKey . ', ' .
-					'cache map key: ' . $textHash . ', ' .
-					'value type: ' . get_debug_type( $matches ) . ')'
+					'Value of unknown type in object cache ('.
+					'cache key: '.$cacheKey.', '.
+					'cache map key: '.$textHash.', '.
+					'value type: '.get_debug_type($matches).')'
 				);
 			}
 		} else {
 			$key = 'wikibase.quality.constraints.regex.cache.miss';
-			$this->dataFactory->increment( $key );
-			return $this->matchesRegularExpressionWithSparql( $text, $regex );
+			$this->dataFactory->increment($key);
+			return $this->matchesRegularExpressionWithSparql($text, $regex);
 		}
 	}
 
-	private function serializeConstraintParameterException( ConstraintParameterException $cpe ): array {
+	private function serializeConstraintParameterException(ConstraintParameterException $cpe): array {
 		return [
 			'type' => ConstraintParameterException::class,
-			'violationMessage' => $this->violationMessageSerializer->serialize( $cpe->getViolationMessage() ),
+			'violationMessage' => $this->violationMessageSerializer->serialize($cpe->getViolationMessage()),
 		];
 	}
 
-	private function deserializeConstraintParameterException( array $serialization ): ConstraintParameterException {
+	private function deserializeConstraintParameterException(array $serialization): ConstraintParameterException {
 		$message = $this->violationMessageDeserializer->deserialize(
 			$serialization['violationMessage']
 		);
-		return new ConstraintParameterException( $message );
+		return new ConstraintParameterException($message);
 	}
 
 	/**
@@ -720,25 +717,25 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpressionWithSparql( string $text, string $regex ): bool {
-		$textStringLiteral = $this->stringLiteral( $text );
-		$regexStringLiteral = $this->stringLiteral( '^(?:' . $regex . ')$' );
+	public function matchesRegularExpressionWithSparql(string $text, string $regex): bool {
+		$textStringLiteral = $this->stringLiteral($text);
+		$regexStringLiteral = $this->stringLiteral('^(?:'.$regex.')$');
 
 		$query = <<<EOF
 SELECT (REGEX($textStringLiteral, $regexStringLiteral) AS ?matches) {}
 EOF;
 
-		$result = $this->runQuery( $query, $this->primaryEndpoint, false );
+		$result = $this->runQuery($query, $this->primaryEndpoint, false);
 
 		$vars = $result->getArray()['results']['bindings'][0];
-		if ( array_key_exists( 'matches', $vars ) ) {
+		if (array_key_exists('matches', $vars)) {
 			// true or false ⇒ regex okay, text matches or not
 			return $vars['matches']['value'] === 'true';
 		} else {
 			// empty result: regex broken
 			throw new ConstraintParameterException(
-				( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) )
-					->withInlineCode( $regex, Role::CONSTRAINT_PARAMETER_VALUE )
+				(new ViolationMessage('wbqc-violation-message-parameter-regex'))
+					->withInlineCode($regex, Role::CONSTRAINT_PARAMETER_VALUE)
 			);
 		}
 	}
@@ -746,14 +743,14 @@ 
 	/**
 	 * Check whether the text content of an error response indicates a query timeout.
 	 */
-	public function isTimeout( string $responseContent ): bool {
-		$timeoutRegex = implode( '|', array_map(
-			static function ( $fqn ) {
-				return preg_quote( $fqn, '/' );
+	public function isTimeout(string $responseContent): bool {
+		$timeoutRegex = implode('|', array_map(
+			static function($fqn) {
+				return preg_quote($fqn, '/');
 			},
 			$this->timeoutExceptionClasses
-		) );
-		return (bool)preg_match( '/' . $timeoutRegex . '/', $responseContent );
+		));
+		return (bool) preg_match('/'.$timeoutRegex.'/', $responseContent);
 	}
 
 	/**
@@ -765,17 +762,17 @@ 
 	 * @return int|boolean the max-age (in seconds)
 	 * or a plain boolean if no max-age can be determined
 	 */
-	public function getCacheMaxAge( array $responseHeaders ) {
+	public function getCacheMaxAge(array $responseHeaders) {
 		if (
-			array_key_exists( 'x-cache-status', $responseHeaders ) &&
-			preg_match( '/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0] )
+			array_key_exists('x-cache-status', $responseHeaders) &&
+			preg_match('/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0])
 		) {
 			$maxage = [];
 			if (
-				array_key_exists( 'cache-control', $responseHeaders ) &&
-				preg_match( '/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage )
+				array_key_exists('cache-control', $responseHeaders) &&
+				preg_match('/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage)
 			) {
-				return intval( $maxage[1] );
+				return intval($maxage[1]);
 			} else {
 				return true;
 			}
@@ -796,34 +793,34 @@ 
 	 * or SparlHelper::EMPTY_RETRY_AFTER if there is an empty Retry-After
 	 * or SparlHelper::INVALID_RETRY_AFTER if there is something wrong with the format
 	 */
-	public function getThrottling( MWHttpRequest $request ) {
-		$retryAfterValue = $request->getResponseHeader( 'Retry-After' );
-		if ( $retryAfterValue === null ) {
+	public function getThrottling(MWHttpRequest $request) {
+		$retryAfterValue = $request->getResponseHeader('Retry-After');
+		if ($retryAfterValue === null) {
 			return self::NO_RETRY_AFTER;
 		}
 
-		$trimmedRetryAfterValue = trim( $retryAfterValue );
-		if ( $trimmedRetryAfterValue === '' ) {
+		$trimmedRetryAfterValue = trim($retryAfterValue);
+		if ($trimmedRetryAfterValue === '') {
 			return self::EMPTY_RETRY_AFTER;
 		}
 
-		if ( is_numeric( $trimmedRetryAfterValue ) ) {
-			$delaySeconds = (int)$trimmedRetryAfterValue;
-			if ( $delaySeconds >= 0 ) {
-				return $this->getTimestampInFuture( new DateInterval( 'PT' . $delaySeconds . 'S' ) );
+		if (is_numeric($trimmedRetryAfterValue)) {
+			$delaySeconds = (int) $trimmedRetryAfterValue;
+			if ($delaySeconds >= 0) {
+				return $this->getTimestampInFuture(new DateInterval('PT'.$delaySeconds.'S'));
 			}
 		} else {
-			$return = strtotime( $trimmedRetryAfterValue );
-			if ( $return !== false ) {
-				return new ConvertibleTimestamp( $return );
+			$return = strtotime($trimmedRetryAfterValue);
+			if ($return !== false) {
+				return new ConvertibleTimestamp($return);
 			}
 		}
 		return self::INVALID_RETRY_AFTER;
 	}
 
-	private function getTimestampInFuture( DateInterval $delta ): ConvertibleTimestamp {
+	private function getTimestampInFuture(DateInterval $delta): ConvertibleTimestamp {
 		$now = new ConvertibleTimestamp();
-		return new ConvertibleTimestamp( $now->timestamp->add( $delta ) );
+		return new ConvertibleTimestamp($now->timestamp->add($delta));
 	}
 
 	/**
@@ -838,64 +835,63 @@ 
 	 *
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	protected function runQuery( string $query, string $endpoint, bool $needsPrefixes = true ): CachedQueryResults {
-		if ( $this->throttlingLock->isLocked( self::EXPIRY_LOCK_ID ) ) {
-			$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.throttling' );
+	protected function runQuery(string $query, string $endpoint, bool $needsPrefixes = true): CachedQueryResults {
+		if ($this->throttlingLock->isLocked(self::EXPIRY_LOCK_ID)) {
+			$this->dataFactory->increment('wikibase.quality.constraints.sparql.throttling');
 			throw new TooManySparqlRequestsException();
 		}
 
-		if ( $this->sparqlHasWikibaseSupport ) {
+		if ($this->sparqlHasWikibaseSupport) {
 			$needsPrefixes = false;
 		}
 
-		if ( $needsPrefixes ) {
-			$query = $this->prefixes . $query;
+		if ($needsPrefixes) {
+			$query = $this->prefixes.$query;
 		}
-		$query = "#wbqc\n" . $query;
+		$query = "#wbqc\n".$query;
 
-		$url = $endpoint . '?' . http_build_query(
+		$url = $endpoint.'?'.http_build_query(
 			[
 				'query' => $query,
 				'format' => 'json',
 				'maxQueryTimeMillis' => $this->maxQueryTimeMillis,
 			],
-			'', ini_get( 'arg_separator.output' ),
+			'', ini_get('arg_separator.output'),
 			// encode spaces with %20, not +
 			PHP_QUERY_RFC3986
 		);
 
 		$options = [
 			'method' => 'GET',
-			'timeout' => (int)round( ( $this->maxQueryTimeMillis + 1000 ) / 1000 ),
+			'timeout' => (int) round(($this->maxQueryTimeMillis + 1000) / 1000),
 			'connectTimeout' => 'default',
 			'userAgent' => $this->defaultUserAgent,
 		];
-		$request = $this->requestFactory->create( $url, $options, __METHOD__ );
-		$startTime = microtime( true );
+		$request = $this->requestFactory->create($url, $options, __METHOD__);
+		$startTime = microtime(true);
 		$requestStatus = $request->execute();
-		$endTime = microtime( true );
+		$endTime = microtime(true);
 		$this->dataFactory->timing(
 			'wikibase.quality.constraints.sparql.timing',
-			( $endTime - $startTime ) * 1000
+			($endTime - $startTime) * 1000
 		);
 
-		$this->guardAgainstTooManyRequestsError( $request );
+		$this->guardAgainstTooManyRequestsError($request);
 
-		$maxAge = $this->getCacheMaxAge( $request->getResponseHeaders() );
-		if ( $maxAge ) {
-			$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.cached' );
+		$maxAge = $this->getCacheMaxAge($request->getResponseHeaders());
+		if ($maxAge) {
+			$this->dataFactory->increment('wikibase.quality.constraints.sparql.cached');
 		}
 
-		if ( $requestStatus->isOK() ) {
+		if ($requestStatus->isOK()) {
 			$json = $request->getContent();
-			$jsonStatus = FormatJson::parse( $json, FormatJson::FORCE_ASSOC );
-			if ( $jsonStatus->isOK() ) {
+			$jsonStatus = FormatJson::parse($json, FormatJson::FORCE_ASSOC);
+			if ($jsonStatus->isOK()) {
 				return new CachedQueryResults(
 					$jsonStatus->getValue(),
 					Metadata::ofCachingMetadata(
 						$maxAge ?
-							CachingMetadata::ofMaximumAgeInSeconds( $maxAge ) :
-							CachingMetadata::fresh()
+							CachingMetadata::ofMaximumAgeInSeconds($maxAge) : CachingMetadata::fresh()
 					)
 				);
 			} else {
@@ -912,9 +908,9 @@ 
 			// fall through to general error handling
 		}
 
-		$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.error' );
+		$this->dataFactory->increment('wikibase.quality.constraints.sparql.error');
 
-		if ( $this->isTimeout( $request->getContent() ) ) {
+		if ($this->isTimeout($request->getContent())) {
 			$this->dataFactory->increment(
 				'wikibase.quality.constraints.sparql.error.timeout'
 			);
@@ -929,29 +925,29 @@ 
 	 * @param MWHttpRequest $request
 	 * @throws TooManySparqlRequestsException
 	 */
-	private function guardAgainstTooManyRequestsError( MWHttpRequest $request ): void {
-		if ( $request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS ) {
+	private function guardAgainstTooManyRequestsError(MWHttpRequest $request): void {
+		if ($request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS) {
 			return;
 		}
 
 		$fallbackBlockDuration = $this->sparqlThrottlingFallbackDuration;
 
-		if ( $fallbackBlockDuration < 0 ) {
-			throw new InvalidArgumentException( 'Fallback duration must be positive int but is: ' .
-				$fallbackBlockDuration );
+		if ($fallbackBlockDuration < 0) {
+			throw new InvalidArgumentException('Fallback duration must be positive int but is: '.
+				$fallbackBlockDuration);
 		}
 
-		$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.throttling' );
-		$throttlingUntil = $this->getThrottling( $request );
-		if ( !( $throttlingUntil instanceof ConvertibleTimestamp ) ) {
-			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid( $request );
+		$this->dataFactory->increment('wikibase.quality.constraints.sparql.throttling');
+		$throttlingUntil = $this->getThrottling($request);
+		if (!($throttlingUntil instanceof ConvertibleTimestamp)) {
+			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid($request);
 			$this->throttlingLock->lock(
 				self::EXPIRY_LOCK_ID,
-				$this->getTimestampInFuture( new DateInterval( 'PT' . $fallbackBlockDuration . 'S' ) )
+				$this->getTimestampInFuture(new DateInterval('PT'.$fallbackBlockDuration.'S'))
 			);
 		} else {
-			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent( $throttlingUntil, $request );
-			$this->throttlingLock->lock( self::EXPIRY_LOCK_ID, $throttlingUntil );
+			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent($throttlingUntil, $request);
+			$this->throttlingLock->lock(self::EXPIRY_LOCK_ID, $throttlingUntil);
 		}
 		throw new TooManySparqlRequestsException();
 	}