wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Checker/TargetRequiredClaimChecker.php

Spacing +26 added lines, -26 removed lines

@@ -79,9 +79,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -100,9 +100,9 @@ 
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -111,18 +111,18 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		/*
@@ -130,7 +130,7 @@ 
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$targetEntity->getStatements(),
 				$propertyId
@@ -143,23 +143,23 @@ 
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-target-required-claim'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return ( new CheckResult( $context, $constraint, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -168,7 +168,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -177,7 +177,7 @@ 
 				$constraintTypeItemId,
 				false
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/SymmetricChecker.php

Spacing +23 added lines, -23 removed lines

@@ -79,17 +79,17 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$snak = $context->getSnak();
 		$propertyId = $context->getSnak()->getPropertyId();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -98,18 +98,18 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -117,23 +117,23 @@ 
 			$propertyId,
 			$context->getEntity()->getId()
 		);
-		if ( $symmetricStatement !== null ) {
+		if ($symmetricStatement !== null) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-symmetric'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/NoneOfChecker.php

Spacing +11 added lines, -11 removed lines

@@ -57,9 +57,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -76,20 +76,20 @@ 
 		$message = null;
 		$status = CheckResult::STATUS_COMPLIANCE;
 
-		foreach ( $items as $item ) {
-			if ( $item->matchesSnak( $snak ) ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-					->withItemIdSnakValueList( $items, Role::OBJECT );
+		foreach ($items as $item) {
+			if ($item->matchesSnak($snak)) {
+				$message = (new ViolationMessage('wbqc-violation-message-none-of'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+					->withItemIdSnakValueList($items, Role::OBJECT);
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -99,7 +99,7 @@ 
 				$constraintTypeItemId,
 				true
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/DiffWithinRangeChecker.php

Spacing +36 added lines, -37 removed lines

@@ -73,8 +73,8 @@ 
 	 * @throws ConstraintParameterException
 	 * @return array [ DataValue|null $min, DataValue|null $max, NumericPropertyId $property ]
 	 */
-	private function parseConstraintParameters( Constraint $constraint ) {
-		[ $min, $max ] = $this->constraintParameterParser->parseQuantityRangeParameter(
+	private function parseConstraintParameters(Constraint $constraint) {
+		[$min, $max] = $this->constraintParameterParser->parseQuantityRangeParameter(
 			$constraint->getConstraintParameters(),
 			$constraint->getConstraintTypeItemId()
 		);
@@ -83,7 +83,7 @@ 
 			$constraint->getConstraintTypeItemId()
 		);
 
-		return [ $min, $max, $property ];
+		return [$min, $max, $property];
 	}
 
 	/**
@@ -93,13 +93,13 @@ 
 	 *
 	 * @return bool
 	 */
-	private function rangeInYears( $min, $max ) {
-		$yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' );
+	private function rangeInYears($min, $max) {
+		$yearUnit = $this->config->get('WBQualityConstraintsYearUnit');
 
-		if ( $min !== null && $min->getUnit() === $yearUnit ) {
+		if ($min !== null && $min->getUnit() === $yearUnit) {
 			return true;
 		}
-		if ( $max !== null && $max->getUnit() === $yearUnit ) {
+		if ($max !== null && $max->getUnit() === $yearUnit) {
 			return true;
 		}
 
@@ -115,28 +115,28 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$minuend = $snak->getDataValue();
 		'@phan-var \DataValues\TimeValue|\DataValues\QuantityValue|\DataValues\UnboundedQuantityValue $minuend';
 
 		/** @var NumericPropertyId $property */
-		[ $min, $max, $property ] = $this->parseConstraintParameters( $constraint );
+		[$min, $max, $property] = $this->parseConstraintParameters($constraint);
 
 		// checks only the first occurrence of the referenced property
-		foreach ( $context->getSnakGroup( Context::GROUP_NON_DEPRECATED ) as $otherSnak ) {
+		foreach ($context->getSnakGroup(Context::GROUP_NON_DEPRECATED) as $otherSnak) {
 			if (
-				!$property->equals( $otherSnak->getPropertyId() ) ||
+				!$property->equals($otherSnak->getPropertyId()) ||
 				!$otherSnak instanceof PropertyValueSnak
 			) {
 				continue;
@@ -144,30 +144,29 @@ 
 
 			$subtrahend = $otherSnak->getDataValue();
 			'@phan-var \DataValues\TimeValue|\DataValues\QuantityValue|\DataValues\UnboundedQuantityValue $subtrahend';
-			if ( $subtrahend->getType() === $minuend->getType() ) {
-				$diff = $this->rangeInYears( $min, $max ) && $minuend->getType() === 'time' ?
-					$this->rangeCheckerHelper->getDifferenceInYears( $minuend, $subtrahend ) :
-					$this->rangeCheckerHelper->getDifference( $minuend, $subtrahend );
+			if ($subtrahend->getType() === $minuend->getType()) {
+				$diff = $this->rangeInYears($min, $max) && $minuend->getType() === 'time' ?
+					$this->rangeCheckerHelper->getDifferenceInYears($minuend, $subtrahend) : $this->rangeCheckerHelper->getDifference($minuend, $subtrahend);
 
-				if ( $this->rangeCheckerHelper->getComparison( $min, $diff ) > 0 ||
-					$this->rangeCheckerHelper->getComparison( $diff, $max ) > 0
+				if ($this->rangeCheckerHelper->getComparison($min, $diff) > 0 ||
+					$this->rangeCheckerHelper->getComparison($diff, $max) > 0
 				) {
 					// at least one of $min, $max is set at this point, otherwise there could be no violation
-					$openness = $min !== null ? ( $max !== null ? '' : '-rightopen' ) : '-leftopen';
+					$openness = $min !== null ? ($max !== null ? '' : '-rightopen') : '-leftopen';
 					// possible message keys:
 					// wbqc-violation-message-diff-within-range
 					// wbqc-violation-message-diff-within-range-leftopen
 					// wbqc-violation-message-diff-within-range-rightopen
-					$message = ( new ViolationMessage( "wbqc-violation-message-diff-within-range$openness" ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-						->withDataValue( $minuend, Role::OBJECT )
-						->withEntityId( $otherSnak->getPropertyId(), Role::PREDICATE )
-						->withDataValue( $subtrahend, Role::OBJECT );
-					if ( $min !== null ) {
-						$message = $message->withDataValue( $min, Role::OBJECT );
+					$message = (new ViolationMessage("wbqc-violation-message-diff-within-range$openness"))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+						->withDataValue($minuend, Role::OBJECT)
+						->withEntityId($otherSnak->getPropertyId(), Role::PREDICATE)
+						->withDataValue($subtrahend, Role::OBJECT);
+					if ($min !== null) {
+						$message = $message->withDataValue($min, Role::OBJECT);
 					}
-					if ( $max !== null ) {
-						$message = $message->withDataValue( $max, Role::OBJECT );
+					if ($max !== null) {
+						$message = $message->withDataValue($max, Role::OBJECT);
 					}
 					$status = CheckResult::STATUS_VIOLATION;
 				} else {
@@ -175,17 +174,17 @@ 
 					$status = CheckResult::STATUS_COMPLIANCE;
 				}
 			} else {
-				$message = new ViolationMessage( 'wbqc-violation-message-diff-within-range-must-have-equal-types' );
+				$message = new ViolationMessage('wbqc-violation-message-diff-within-range-must-have-equal-types');
 				$status = CheckResult::STATUS_VIOLATION;
 			}
 
-			return new CheckResult( $context, $constraint, $status, $message );
+			return new CheckResult($context, $constraint, $status, $message);
 		}
 
-		return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -194,7 +193,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -202,7 +201,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/MultiValueChecker.php

Spacing +14 added lines, -15 removed lines

@@ -62,9 +62,9 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$separators = $this->constraintParameterParser->parseSeparatorsParameter(
@@ -73,33 +73,32 @@ 
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
 			$propertyId
 		);
 
-		if ( $propertyCount <= 1 ) {
-			$message = ( new ViolationMessage(
+		if ($propertyCount <= 1) {
+			$message = (new ViolationMessage(
 					$separators === [] ?
-						'wbqc-violation-message-multi-value' :
-						'wbqc-violation-message-multi-value-separators'
-				) )
-				->withEntityId( $propertyId )
-				->withEntityIdList( $separators );
+						'wbqc-violation-message-multi-value' : 'wbqc-violation-message-multi-value-separators'
+				))
+				->withEntityId($propertyId)
+				->withEntityIdList($separators);
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/ValueOnlyChecker.php

Spacing +6 added lines, -6 removed lines

@@ -33,16 +33,16 @@
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getType() === Context::TYPE_STATEMENT ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getType() === Context::TYPE_STATEMENT) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-valueOnly' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-valueOnly');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/AllowedUnitsChecker.php

Spacing +34 added lines, -35 removed lines

@@ -72,7 +72,7 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$unitsParameter = $this->constraintParameterParser
 			->parseUnitsParameter(
@@ -81,50 +81,49 @@ 
 			);
 
 		$snak = $context->getSnak();
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
-		if ( !$dataValue instanceof UnboundedQuantityValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'quantity' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof UnboundedQuantityValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('quantity');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
-		if ( $dataValue->getUnit() === '1' ) {
-			return $this->checkUnitless( $context, $constraint, $unitsParameter, $snak );
+		if ($dataValue->getUnit() === '1') {
+			return $this->checkUnitless($context, $constraint, $unitsParameter, $snak);
 		}
 
 		$status = CheckResult::STATUS_VIOLATION;
-		$actualUnit = $this->standardize( $dataValue )->getUnit();
-		foreach ( $unitsParameter->getUnitQuantities() as $unitQuantity ) {
-			$allowedUnit = $this->standardize( $unitQuantity )->getUnit();
-			if ( $actualUnit === $allowedUnit ) {
+		$actualUnit = $this->standardize($dataValue)->getUnit();
+		foreach ($unitsParameter->getUnitQuantities() as $unitQuantity) {
+			$allowedUnit = $this->standardize($unitQuantity)->getUnit();
+			if ($actualUnit === $allowedUnit) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		if ( $status === CheckResult::STATUS_VIOLATION ) {
-			if ( $unitsParameter->getUnitItemIds() === [] ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-units-none' ) )
-					->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+		if ($status === CheckResult::STATUS_VIOLATION) {
+			if ($unitsParameter->getUnitItemIds() === []) {
+				$message = (new ViolationMessage('wbqc-violation-message-units-none'))
+					->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 			} else {
 				$messageKey = $unitsParameter->getUnitlessAllowed() ?
-					'wbqc-violation-message-units-or-none' :
-					'wbqc-violation-message-units';
-				$message = ( new ViolationMessage( $messageKey ) )
-					->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
+					'wbqc-violation-message-units-or-none' : 'wbqc-violation-message-units';
+				$message = (new ViolationMessage($messageKey))
+					->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
 			}
 		} else {
 			$message = null;
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
 	/**
@@ -140,17 +139,17 @@ 
 		UnitsParameter $unitsParameter,
 		PropertyValueSnak $snak
 	) {
-		if ( $unitsParameter->getUnitlessAllowed() ) {
+		if ($unitsParameter->getUnitlessAllowed()) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-units' ) )
-				->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-				->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
+			$message = (new ViolationMessage('wbqc-violation-message-units'))
+				->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+				->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
 	/**
@@ -159,20 +158,20 @@ 
 	 * @param UnboundedQuantityValue $value
 	 * @return UnboundedQuantityValue
 	 */
-	private function standardize( UnboundedQuantityValue $value ) {
-		if ( $this->unitConverter === null ) {
+	private function standardize(UnboundedQuantityValue $value) {
+		if ($this->unitConverter === null) {
 			return $value;
 		}
 
-		$standard = $this->unitConverter->toStandardUnits( $value );
-		if ( $standard !== null ) {
+		$standard = $this->unitConverter->toStandardUnits($value);
+		if ($standard !== null) {
 			return $standard;
 		} else {
 			return $value;
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
@@ -181,7 +180,7 @@ 
 				$constraint->getConstraintTypeItemId(),
 				true
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/FormatChecker.php

Spacing +47 added lines, -47 removed lines

@@ -67,7 +67,7 @@ 
 		$this->sparqlHelper = $sparqlHelper;
 		$this->shellboxClientFactory = $shellboxClientFactory;
 		$this->knownGoodPatternsAsKeys = array_fill_keys(
-			$this->config->get( 'WBQualityConstraintsFormatCheckerKnownGoodRegexPatterns' ),
+			$this->config->get('WBQualityConstraintsFormatCheckerKnownGoodRegexPatterns'),
 			null
 		);
 	}
@@ -100,7 +100,7 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
@@ -115,9 +115,9 @@ 
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -126,7 +126,7 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Format' constraint has to be 'string' or 'monolingualtext'
 		 */
-		switch ( $dataValue->getType() ) {
+		switch ($dataValue->getType()) {
 			case 'string':
 				$text = $dataValue->getValue();
 				break;
@@ -136,13 +136,13 @@ 
 				$text = $dataValue->getText();
 				break;
 			default:
-				$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
-					->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-					->withDataValueType( 'string' )
-					->withDataValueType( 'monolingualtext' );
-				return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+				$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
+					->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+					->withDataValueType('string')
+					->withDataValueType('monolingualtext');
+				return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
-		$status = $this->runRegexCheck( $text, $format );
+		$status = $this->runRegexCheck($text, $format);
 		$message = $this->formatMessage(
 			$status,
 			$text,
@@ -151,7 +151,7 @@ 
 			$syntaxClarifications,
 			$constraintTypeItemId
 		);
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
 	private function formatMessage(
@@ -163,42 +163,42 @@ 
 		string $constraintTypeItemId
 	): ?ViolationMessage {
 		$message = null;
-		if ( $status === CheckResult::STATUS_VIOLATION ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-format-clarification' ) )
-				->withEntityId( $propertyId, Role::CONSTRAINT_PROPERTY )
-				->withDataValue( new StringValue( $text ), Role::OBJECT )
-				->withInlineCode( $format, Role::CONSTRAINT_PARAMETER_VALUE )
-				->withMultilingualText( $syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE );
-		} elseif ( $status === CheckResult::STATUS_TODO ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-security-reason' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM );
+		if ($status === CheckResult::STATUS_VIOLATION) {
+			$message = (new ViolationMessage('wbqc-violation-message-format-clarification'))
+				->withEntityId($propertyId, Role::CONSTRAINT_PROPERTY)
+				->withDataValue(new StringValue($text), Role::OBJECT)
+				->withInlineCode($format, Role::CONSTRAINT_PARAMETER_VALUE)
+				->withMultilingualText($syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE);
+		} elseif ($status === CheckResult::STATUS_TODO) {
+			$message = (new ViolationMessage('wbqc-violation-message-security-reason'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM);
 		}
 
 		return $message;
 	}
 
-	private function runRegexCheck( string $text, string $format ): string {
-		if ( !$this->config->get( 'WBQualityConstraintsCheckFormatConstraint' ) ) {
+	private function runRegexCheck(string $text, string $format): string {
+		if (!$this->config->get('WBQualityConstraintsCheckFormatConstraint')) {
 			return CheckResult::STATUS_TODO;
 		}
-		if ( \array_key_exists( $format, $this->knownGoodPatternsAsKeys ) ) {
-			$checkResult = FormatCheckerHelper::runRegexCheck( $format, $text );
+		if (\array_key_exists($format, $this->knownGoodPatternsAsKeys)) {
+			$checkResult = FormatCheckerHelper::runRegexCheck($format, $text);
 		} elseif (
-			$this->config->get( 'WBQualityConstraintsFormatCheckerShellboxRatio' ) > (float)wfRandom()
+			$this->config->get('WBQualityConstraintsFormatCheckerShellboxRatio') > (float) wfRandom()
 		) {
-			$checkResult = $this->runRegexCheckUsingShellbox( $text, $format );
+			$checkResult = $this->runRegexCheckUsingShellbox($text, $format);
 		} else {
-			return $this->runRegexCheckUsingSparql( $text, $format );
+			return $this->runRegexCheckUsingSparql($text, $format);
 		}
 
-		if ( $checkResult === 1 ) {
+		if ($checkResult === 1) {
 			return CheckResult::STATUS_COMPLIANCE;
-		} elseif ( $checkResult === 0 ) {
+		} elseif ($checkResult === 0) {
 			return CheckResult::STATUS_VIOLATION;
-		} elseif ( $checkResult === false ) {
+		} elseif ($checkResult === false) {
 			throw new ConstraintParameterException(
-				( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) )
-					->withInlineCode( $format, Role::CONSTRAINT_PARAMETER_VALUE )
+				(new ViolationMessage('wbqc-violation-message-parameter-regex'))
+					->withInlineCode($format, Role::CONSTRAINT_PARAMETER_VALUE)
 			);
 		} else {
 			return $checkResult;
@@ -212,35 +212,35 @@ 
 	 *   - FALSE if $format is invalid regex
 	 *   - CheckResult::STATUS_TODO if Shellbox is not enabled
 	 */
-	private function runRegexCheckUsingShellbox( string $text, string $format ) {
-		if ( !$this->shellboxClientFactory->isEnabled( 'constraint-regex-checker' ) ) {
+	private function runRegexCheckUsingShellbox(string $text, string $format) {
+		if (!$this->shellboxClientFactory->isEnabled('constraint-regex-checker')) {
 			return CheckResult::STATUS_TODO;
 		}
 
-		return $this->shellboxClientFactory->getClient( [
-			'timeout' => $this->config->get( 'WBQualityConstraintsSparqlMaxMillis' ) / 1000,
+		return $this->shellboxClientFactory->getClient([
+			'timeout' => $this->config->get('WBQualityConstraintsSparqlMaxMillis') / 1000,
 			'service' => 'constraint-regex-checker',
-		] )->call(
+		])->call(
 			'constraint-regex-checker',
-			[ FormatCheckerHelper::class, 'runRegexCheck' ],
-			[ $format, $text ],
-			[ 'classes' => [ FormatCheckerHelper::class ] ],
+			[FormatCheckerHelper::class, 'runRegexCheck'],
+			[$format, $text],
+			['classes' => [FormatCheckerHelper::class]],
 		);
 	}
 
-	private function runRegexCheckUsingSparql( string $text, string $format ): string {
-		if ( $this->sparqlHelper instanceof DummySparqlHelper ) {
+	private function runRegexCheckUsingSparql(string $text, string $format): string {
+		if ($this->sparqlHelper instanceof DummySparqlHelper) {
 			return CheckResult::STATUS_TODO;
 		}
 
-		if ( $this->sparqlHelper->matchesRegularExpression( $text, $format ) ) {
+		if ($this->sparqlHelper->matchesRegularExpression($text, $format)) {
 			return CheckResult::STATUS_COMPLIANCE;
 		} else {
 			return CheckResult::STATUS_VIOLATION;
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -249,14 +249,14 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
 			$this->constraintParameterParser->parseSyntaxClarificationParameter(
 				$constraintParameters
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/IntegerChecker.php

Spacing +21 added lines, -22 removed lines

@@ -38,22 +38,21 @@ 
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
-		$violationMessage = $this->checkSnak( $snak );
+		$violationMessage = $this->checkSnak($snak);
 
 		return new CheckResult(
 			$context,
 			$constraint,
 			$violationMessage === null ?
-				CheckResult::STATUS_COMPLIANCE :
-				CheckResult::STATUS_VIOLATION,
+				CheckResult::STATUS_COMPLIANCE : CheckResult::STATUS_VIOLATION,
 			$violationMessage
 		);
 	}
@@ -62,23 +61,23 @@ 
 	 * @param PropertyValueSnak $snak
 	 * @return ViolationMessage|null
 	 */
-	public function checkSnak( PropertyValueSnak $snak ) {
+	public function checkSnak(PropertyValueSnak $snak) {
 		$dataValue = $snak->getDataValue();
 
-		if ( $dataValue instanceof DecimalValue ) {
-			if ( !$this->isInteger( $dataValue ) ) {
-				return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
+		if ($dataValue instanceof DecimalValue) {
+			if (!$this->isInteger($dataValue)) {
+				return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
 			}
-		} elseif ( $dataValue instanceof UnboundedQuantityValue ) {
-			if ( !$this->isInteger( $dataValue->getAmount() ) ) {
-				return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
+		} elseif ($dataValue instanceof UnboundedQuantityValue) {
+			if (!$this->isInteger($dataValue->getAmount())) {
+				return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
 			} elseif (
 				$dataValue instanceof QuantityValue && (
-					!$this->isInteger( $dataValue->getLowerBound() ) ||
-					!$this->isInteger( $dataValue->getUpperBound() )
+					!$this->isInteger($dataValue->getLowerBound()) ||
+					!$this->isInteger($dataValue->getUpperBound())
 				)
 			) {
-				return $this->getViolationMessage( 'wbqc-violation-message-integer-bounds', $snak );
+				return $this->getViolationMessage('wbqc-violation-message-integer-bounds', $snak);
 			}
 		}
 
@@ -89,7 +88,7 @@ 
 	 * @param DecimalValue $decimalValue
 	 * @return bool
 	 */
-	private function isInteger( DecimalValue $decimalValue ) {
+	private function isInteger(DecimalValue $decimalValue) {
 		return $decimalValue->getTrimmed()->getFractionalPart() === '';
 	}
 
@@ -98,13 +97,13 @@ 
 	 * @param PropertyValueSnak $snak
 	 * @return ViolationMessage
 	 */
-	private function getViolationMessage( $messageKey, PropertyValueSnak $snak ) {
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-			->withDataValue( $snak->getDataValue() );
+	private function getViolationMessage($messageKey, PropertyValueSnak $snak) {
+		return (new ViolationMessage($messageKey))
+			->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+			->withDataValue($snak->getDataValue());
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		// no parameters
 		return [];
 	}