Inspection of "Fix WikiPageEntityMetaDataLookup construction" - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 648f65...d7bb4b )

unknown

created 2018-10-03 21:11 UTC

Status

Spacing +100 added lines, -100 removed lines patch added patch discarded remove patch

@@ -25,24 +25,24 @@  discard block
 block discarded – undo
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer;
 
 return [
-	ConstraintsServices::LOGGING_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::LOGGING_HELPER => function(MediaWikiServices $services) {
 		return new LoggingHelper(
 			$services->getStatsdDataFactory(),
-			LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
+			LoggerFactory::getInstance('WikibaseQualityConstraints'),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_REPOSITORY => function( MediaWikiServices $services ) {
+	ConstraintsServices::CONSTRAINT_REPOSITORY => function(MediaWikiServices $services) {
 		return new ConstraintRepository();
 	},
 
-	ConstraintsServices::CONSTRAINT_LOOKUP => function( MediaWikiServices $services ) {
-		$constraintRepository = ConstraintsServices::getConstraintRepository( $services );
-		return new CachingConstraintLookup( $constraintRepository );
+	ConstraintsServices::CONSTRAINT_LOOKUP => function(MediaWikiServices $services) {
+		$constraintRepository = ConstraintsServices::getConstraintRepository($services);
+		return new CachingConstraintLookup($constraintRepository);
 	},
 
-	ConstraintsServices::CHECK_RESULT_SERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CHECK_RESULT_SERIALIZER => function(MediaWikiServices $services) {
 		return new CheckResultSerializer(
 			new ConstraintSerializer(
 				false // constraint parameters are not exposed
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
 		);
 	},
 
-	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function(MediaWikiServices $services) {
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$entityIdParser = $repo->getEntityIdParser();
@@ -70,11 +70,11 @@  discard block
 block discarded – undo
 		);
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function(MediaWikiServices $services) {
 		return new ViolationMessageSerializer();
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function(MediaWikiServices $services) {
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$entityIdParser = $repo->getEntityIdParser();
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function(MediaWikiServices $services) {
 		// TODO in the future, get DeserializerFactory and concept base URIs from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$deserializerFactory = $repo->getBaseDataModelDeserializerFactory();
@@ -99,11 +99,11 @@  discard block
 block discarded – undo
 		);
 	},
 
-	ConstraintsServices::CONNECTION_CHECKER_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CONNECTION_CHECKER_HELPER => function(MediaWikiServices $services) {
 		return new ConnectionCheckerHelper();
 	},
 
-	ConstraintsServices::RANGE_CHECKER_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::RANGE_CHECKER_HELPER => function(MediaWikiServices $services) {
 		// TODO in the future, get UnitConverter from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$unitConverter = $repo->getUnitConverter();
@@ -114,9 +114,9 @@  discard block
 block discarded – undo
 		);
 	},
 
-	ConstraintsServices::SPARQL_HELPER => function( MediaWikiServices $services ) {
-		$endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' );
-		if ( $endpoint === '' ) {
+	ConstraintsServices::SPARQL_HELPER => function(MediaWikiServices $services) {
+		$endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint');
+		if ($endpoint === '') {
 			return new DummySparqlHelper();
 		}
 
@@ -132,113 +132,113 @@  discard block
 block discarded – undo
 			$entityIdParser,
 			$propertyDataTypeLookup,
 			$services->getMainWANObjectCache(),
-			ConstraintsServices::getViolationMessageSerializer( $services ),
-			ConstraintsServices::getViolationMessageDeserializer( $services ),
+			ConstraintsServices::getViolationMessageSerializer($services),
+			ConstraintsServices::getViolationMessageDeserializer($services),
 			$services->getStatsdDataFactory()
 		);
 	},
 
-	ConstraintsServices::TYPE_CHECKER_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::TYPE_CHECKER_HELPER => function(MediaWikiServices $services) {
 		return new TypeCheckerHelper(
-			WikibaseServices::getEntityLookup( $services ),
+			WikibaseServices::getEntityLookup($services),
 			$services->getMainConfig(),
-			ConstraintsServices::getSparqlHelper( $services ),
+			ConstraintsServices::getSparqlHelper($services),
 			$services->getStatsdDataFactory()
 		);
 	},
 
-	ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function(MediaWikiServices $services) {
 		// TODO in the future, get StatementGuidParser from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$statementGuidParser = $repo->getStatementGuidParser();
 
 		$config = $services->getMainConfig();
 		$checkerMap = [
-			$config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
-				=> ConstraintCheckerServices::getConflictsWithChecker( $services ),
-			$config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
-				=> ConstraintCheckerServices::getItemChecker( $services ),
-			$config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
-				=> ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ),
-			$config->get( 'WBQualityConstraintsSymmetricConstraintId' )
-				=> ConstraintCheckerServices::getSymmetricChecker( $services ),
-			$config->get( 'WBQualityConstraintsInverseConstraintId' )
-				=> ConstraintCheckerServices::getInverseChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
-				=> ConstraintCheckerServices::getQualifierChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
-				=> ConstraintCheckerServices::getQualifiersChecker( $services ),
-			$config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
-				=> ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ),
-			$config->get( 'WBQualityConstraintsRangeConstraintId' )
-				=> ConstraintCheckerServices::getRangeChecker( $services ),
-			$config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
-				=> ConstraintCheckerServices::getDiffWithinRangeChecker( $services ),
-			$config->get( 'WBQualityConstraintsTypeConstraintId' )
-				=> ConstraintCheckerServices::getTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsValueTypeConstraintId' )
-				=> ConstraintCheckerServices::getValueTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsSingleValueConstraintId' )
-				=> ConstraintCheckerServices::getSingleValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsMultiValueConstraintId' )
-				=> ConstraintCheckerServices::getMultiValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
-				=> ConstraintCheckerServices::getUniqueValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsFormatConstraintId' )
-				=> ConstraintCheckerServices::getFormatChecker( $services ),
-			$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
-				=> ConstraintCheckerServices::getCommonsLinkChecker( $services ),
-			$config->get( 'WBQualityConstraintsOneOfConstraintId' )
-				=> ConstraintCheckerServices::getOneOfChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
-				=> ConstraintCheckerServices::getValueOnlyChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
-				=> ConstraintCheckerServices::getReferenceChecker( $services ),
-			$config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
-				=> ConstraintCheckerServices::getNoBoundsChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
-				=> ConstraintCheckerServices::getAllowedUnitsChecker( $services ),
-			$config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
-				=> ConstraintCheckerServices::getSingleBestValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
-				=> ConstraintCheckerServices::getEntityTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsNoneOfConstraintId' )
-				=> ConstraintCheckerServices::getNoneOfChecker( $services ),
-			$config->get( 'WBQualityConstraintsIntegerConstraintId' )
-				=> ConstraintCheckerServices::getIntegerChecker( $services ),
-			$config->get( 'WBQualityConstraintsCitationNeededConstraintId' )
-				=> ConstraintCheckerServices::getCitationNeededChecker( $services ),
-			$config->get( 'WBQualityConstraintsPropertyScopeConstraintId' )
-				=> ConstraintCheckerServices::getPropertyScopeChecker( $services ),
-			$config->get( 'WBQualityConstraintsContemporaryConstraintId' )
-				=> ConstraintCheckerServices::getContemporaryChecker( $services ),
+			$config->get('WBQualityConstraintsConflictsWithConstraintId')
+				=> ConstraintCheckerServices::getConflictsWithChecker($services),
+			$config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
+				=> ConstraintCheckerServices::getItemChecker($services),
+			$config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
+				=> ConstraintCheckerServices::getTargetRequiredClaimChecker($services),
+			$config->get('WBQualityConstraintsSymmetricConstraintId')
+				=> ConstraintCheckerServices::getSymmetricChecker($services),
+			$config->get('WBQualityConstraintsInverseConstraintId')
+				=> ConstraintCheckerServices::getInverseChecker($services),
+			$config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
+				=> ConstraintCheckerServices::getQualifierChecker($services),
+			$config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
+				=> ConstraintCheckerServices::getQualifiersChecker($services),
+			$config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
+				=> ConstraintCheckerServices::getMandatoryQualifiersChecker($services),
+			$config->get('WBQualityConstraintsRangeConstraintId')
+				=> ConstraintCheckerServices::getRangeChecker($services),
+			$config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
+				=> ConstraintCheckerServices::getDiffWithinRangeChecker($services),
+			$config->get('WBQualityConstraintsTypeConstraintId')
+				=> ConstraintCheckerServices::getTypeChecker($services),
+			$config->get('WBQualityConstraintsValueTypeConstraintId')
+				=> ConstraintCheckerServices::getValueTypeChecker($services),
+			$config->get('WBQualityConstraintsSingleValueConstraintId')
+				=> ConstraintCheckerServices::getSingleValueChecker($services),
+			$config->get('WBQualityConstraintsMultiValueConstraintId')
+				=> ConstraintCheckerServices::getMultiValueChecker($services),
+			$config->get('WBQualityConstraintsDistinctValuesConstraintId')
+				=> ConstraintCheckerServices::getUniqueValueChecker($services),
+			$config->get('WBQualityConstraintsFormatConstraintId')
+				=> ConstraintCheckerServices::getFormatChecker($services),
+			$config->get('WBQualityConstraintsCommonsLinkConstraintId')
+				=> ConstraintCheckerServices::getCommonsLinkChecker($services),
+			$config->get('WBQualityConstraintsOneOfConstraintId')
+				=> ConstraintCheckerServices::getOneOfChecker($services),
+			$config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
+				=> ConstraintCheckerServices::getValueOnlyChecker($services),
+			$config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
+				=> ConstraintCheckerServices::getReferenceChecker($services),
+			$config->get('WBQualityConstraintsNoBoundsConstraintId')
+				=> ConstraintCheckerServices::getNoBoundsChecker($services),
+			$config->get('WBQualityConstraintsAllowedUnitsConstraintId')
+				=> ConstraintCheckerServices::getAllowedUnitsChecker($services),
+			$config->get('WBQualityConstraintsSingleBestValueConstraintId')
+				=> ConstraintCheckerServices::getSingleBestValueChecker($services),
+			$config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
+				=> ConstraintCheckerServices::getEntityTypeChecker($services),
+			$config->get('WBQualityConstraintsNoneOfConstraintId')
+				=> ConstraintCheckerServices::getNoneOfChecker($services),
+			$config->get('WBQualityConstraintsIntegerConstraintId')
+				=> ConstraintCheckerServices::getIntegerChecker($services),
+			$config->get('WBQualityConstraintsCitationNeededConstraintId')
+				=> ConstraintCheckerServices::getCitationNeededChecker($services),
+			$config->get('WBQualityConstraintsPropertyScopeConstraintId')
+				=> ConstraintCheckerServices::getPropertyScopeChecker($services),
+			$config->get('WBQualityConstraintsContemporaryConstraintId')
+				=> ConstraintCheckerServices::getContemporaryChecker($services),
 		];
 
 		return new DelegatingConstraintChecker(
-			WikibaseServices::getEntityLookup( $services ),
+			WikibaseServices::getEntityLookup($services),
 			$checkerMap,
-			ConstraintsServices::getConstraintLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
+			ConstraintsServices::getConstraintLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
 			$statementGuidParser,
-			ConstraintsServices::getLoggingHelper( $services ),
-			$config->get( 'WBQualityConstraintsCheckQualifiers' ),
-			$config->get( 'WBQualityConstraintsCheckReferences' ),
-			$config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
+			ConstraintsServices::getLoggingHelper($services),
+			$config->get('WBQualityConstraintsCheckQualifiers'),
+			$config->get('WBQualityConstraintsCheckReferences'),
+			$config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
 		);
 	},
 
-	ConstraintsServices::RESULTS_SOURCE => function( MediaWikiServices $services ) {
+	ConstraintsServices::RESULTS_SOURCE => function(MediaWikiServices $services) {
 		$config = $services->getMainConfig();
 		$resultsSource = new CheckingResultsSource(
-			ConstraintsServices::getDelegatingConstraintChecker( $services )
+			ConstraintsServices::getDelegatingConstraintChecker($services)
 		);
 
-		if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
+		if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
 			$possiblyStaleConstraintTypes = [
-				$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
-				$config->get( 'WBQualityConstraintsTypeConstraintId' ),
-				$config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
-				$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
+				$config->get('WBQualityConstraintsCommonsLinkConstraintId'),
+				$config->get('WBQualityConstraintsTypeConstraintId'),
+				$config->get('WBQualityConstraintsValueTypeConstraintId'),
+				$config->get('WBQualityConstraintsDistinctValuesConstraintId'),
 			];
 			// TODO in the future, get EntityIdParser and WikiPageEntityMetaDataAccessor from $services?
 			$repo = WikibaseRepo::getDefaultInstance();
@@ -247,21 +247,21 @@  discard block
 block discarded – undo
 			$wikiPageEntityMetaDataAccessor = new WikiPageEntityMetaDataLookup(
 				$entityNamespaceLookup,
 				$services->getSlotRoleStore(),
-				$repo->getSettings()->getSetting( 'changesDatabase' ),
+				$repo->getSettings()->getSetting('changesDatabase'),
 				'' // Empty string here means this only works for the local repo
 			);
 
 			$resultsSource = new CachingResultsSource(
 				$resultsSource,
 				ResultsCache::getDefaultInstance(),
-				ConstraintsServices::getCheckResultSerializer( $services ),
-				ConstraintsServices::getCheckResultDeserializer( $services ),
+				ConstraintsServices::getCheckResultSerializer($services),
+				ConstraintsServices::getCheckResultDeserializer($services),
 				$wikiPageEntityMetaDataAccessor,
 				$entityIdParser,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
+				$config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
 				$possiblyStaleConstraintTypes,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ),
-				ConstraintsServices::getLoggingHelper( $services )
+				$config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'),
+				ConstraintsServices::getLoggingHelper($services)
 			);
 		}
 

Please login to merge, or discard this patch.

		@@ -25,24 +25,24 @@ discard block
		block discarded – undo
25	25	use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer;
26	26
27	27	return [
28		- ConstraintsServices::LOGGING_HELPER => function( MediaWikiServices $services ) {
	28	+ ConstraintsServices::LOGGING_HELPER => function(MediaWikiServices $services) {
29	29	return new LoggingHelper(
30	30	$services->getStatsdDataFactory(),
31		- LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
	31	+ LoggerFactory::getInstance('WikibaseQualityConstraints'),
32	32	$services->getMainConfig()
33	33	);
34	34	},
35	35
36		- ConstraintsServices::CONSTRAINT_REPOSITORY => function( MediaWikiServices $services ) {
	36	+ ConstraintsServices::CONSTRAINT_REPOSITORY => function(MediaWikiServices $services) {
37	37	return new ConstraintRepository();
38	38	},
39	39
40		- ConstraintsServices::CONSTRAINT_LOOKUP => function( MediaWikiServices $services ) {
41		- $constraintRepository = ConstraintsServices::getConstraintRepository( $services );
42		- return new CachingConstraintLookup( $constraintRepository );
	40	+ ConstraintsServices::CONSTRAINT_LOOKUP => function(MediaWikiServices $services) {
	41	+ $constraintRepository = ConstraintsServices::getConstraintRepository($services);
	42	+ return new CachingConstraintLookup($constraintRepository);
43	43	},
44	44
45		- ConstraintsServices::CHECK_RESULT_SERIALIZER => function( MediaWikiServices $services ) {
	45	+ ConstraintsServices::CHECK_RESULT_SERIALIZER => function(MediaWikiServices $services) {
46	46	return new CheckResultSerializer(
47	47	new ConstraintSerializer(
48	48	false // constraint parameters are not exposed
		@@ -53,7 +53,7 @@ discard block
		block discarded – undo
53	53	);
54	54	},
55	55
56		- ConstraintsServices::CHECK_RESULT_DESERIALIZER => function( MediaWikiServices $services ) {
	56	+ ConstraintsServices::CHECK_RESULT_DESERIALIZER => function(MediaWikiServices $services) {
57	57	// TODO in the future, get EntityIdParser and DataValueFactory from $services?
58	58	$repo = WikibaseRepo::getDefaultInstance();
59	59	$entityIdParser = $repo->getEntityIdParser();
		@@ -70,11 +70,11 @@ discard block
		block discarded – undo
70	70	);
71	71	},
72	72
73		- ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function( MediaWikiServices $services ) {
	73	+ ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function(MediaWikiServices $services) {
74	74	return new ViolationMessageSerializer();
75	75	},
76	76
77		- ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function( MediaWikiServices $services ) {
	77	+ ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function(MediaWikiServices $services) {
78	78	// TODO in the future, get EntityIdParser and DataValueFactory from $services?
79	79	$repo = WikibaseRepo::getDefaultInstance();
80	80	$entityIdParser = $repo->getEntityIdParser();
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	);
87	87	},
88	88
89		- ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function( MediaWikiServices $services ) {
	89	+ ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function(MediaWikiServices $services) {
90	90	// TODO in the future, get DeserializerFactory and concept base URIs from $services?
91	91	$repo = WikibaseRepo::getDefaultInstance();
92	92	$deserializerFactory = $repo->getBaseDataModelDeserializerFactory();
		@@ -99,11 +99,11 @@ discard block
		block discarded – undo
99	99	);
100	100	},
101	101
102		- ConstraintsServices::CONNECTION_CHECKER_HELPER => function( MediaWikiServices $services ) {
	102	+ ConstraintsServices::CONNECTION_CHECKER_HELPER => function(MediaWikiServices $services) {
103	103	return new ConnectionCheckerHelper();
104	104	},
105	105
106		- ConstraintsServices::RANGE_CHECKER_HELPER => function( MediaWikiServices $services ) {
	106	+ ConstraintsServices::RANGE_CHECKER_HELPER => function(MediaWikiServices $services) {
107	107	// TODO in the future, get UnitConverter from $services?
108	108	$repo = WikibaseRepo::getDefaultInstance();
109	109	$unitConverter = $repo->getUnitConverter();
		@@ -114,9 +114,9 @@ discard block
		block discarded – undo
114	114	);
115	115	},
116	116
117		- ConstraintsServices::SPARQL_HELPER => function( MediaWikiServices $services ) {
118		- $endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' );
119		- if ( $endpoint === '' ) {
	117	+ ConstraintsServices::SPARQL_HELPER => function(MediaWikiServices $services) {
	118	+ $endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint');
	119	+ if ($endpoint === '') {
120	120	return new DummySparqlHelper();
121	121	}
122	122
		@@ -132,113 +132,113 @@ discard block
		block discarded – undo
132	132	$entityIdParser,
133	133	$propertyDataTypeLookup,
134	134	$services->getMainWANObjectCache(),
135		- ConstraintsServices::getViolationMessageSerializer( $services ),
136		- ConstraintsServices::getViolationMessageDeserializer( $services ),
	135	+ ConstraintsServices::getViolationMessageSerializer($services),
	136	+ ConstraintsServices::getViolationMessageDeserializer($services),
137	137	$services->getStatsdDataFactory()
138	138	);
139	139	},
140	140
141		- ConstraintsServices::TYPE_CHECKER_HELPER => function( MediaWikiServices $services ) {
	141	+ ConstraintsServices::TYPE_CHECKER_HELPER => function(MediaWikiServices $services) {
142	142	return new TypeCheckerHelper(
143		- WikibaseServices::getEntityLookup( $services ),
	143	+ WikibaseServices::getEntityLookup($services),
144	144	$services->getMainConfig(),
145		- ConstraintsServices::getSparqlHelper( $services ),
	145	+ ConstraintsServices::getSparqlHelper($services),
146	146	$services->getStatsdDataFactory()
147	147	);
148	148	},
149	149
150		- ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function( MediaWikiServices $services ) {
	150	+ ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function(MediaWikiServices $services) {
151	151	// TODO in the future, get StatementGuidParser from $services?
152	152	$repo = WikibaseRepo::getDefaultInstance();
153	153	$statementGuidParser = $repo->getStatementGuidParser();
154	154
155	155	$config = $services->getMainConfig();
156	156	$checkerMap = [
157		- $config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
158		- => ConstraintCheckerServices::getConflictsWithChecker( $services ),
159		- $config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
160		- => ConstraintCheckerServices::getItemChecker( $services ),
161		- $config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
162		- => ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ),
163		- $config->get( 'WBQualityConstraintsSymmetricConstraintId' )
164		- => ConstraintCheckerServices::getSymmetricChecker( $services ),
165		- $config->get( 'WBQualityConstraintsInverseConstraintId' )
166		- => ConstraintCheckerServices::getInverseChecker( $services ),
167		- $config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
168		- => ConstraintCheckerServices::getQualifierChecker( $services ),
169		- $config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
170		- => ConstraintCheckerServices::getQualifiersChecker( $services ),
171		- $config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
172		- => ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ),
173		- $config->get( 'WBQualityConstraintsRangeConstraintId' )
174		- => ConstraintCheckerServices::getRangeChecker( $services ),
175		- $config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
176		- => ConstraintCheckerServices::getDiffWithinRangeChecker( $services ),
177		- $config->get( 'WBQualityConstraintsTypeConstraintId' )
178		- => ConstraintCheckerServices::getTypeChecker( $services ),
179		- $config->get( 'WBQualityConstraintsValueTypeConstraintId' )
180		- => ConstraintCheckerServices::getValueTypeChecker( $services ),
181		- $config->get( 'WBQualityConstraintsSingleValueConstraintId' )
182		- => ConstraintCheckerServices::getSingleValueChecker( $services ),
183		- $config->get( 'WBQualityConstraintsMultiValueConstraintId' )
184		- => ConstraintCheckerServices::getMultiValueChecker( $services ),
185		- $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
186		- => ConstraintCheckerServices::getUniqueValueChecker( $services ),
187		- $config->get( 'WBQualityConstraintsFormatConstraintId' )
188		- => ConstraintCheckerServices::getFormatChecker( $services ),
189		- $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
190		- => ConstraintCheckerServices::getCommonsLinkChecker( $services ),
191		- $config->get( 'WBQualityConstraintsOneOfConstraintId' )
192		- => ConstraintCheckerServices::getOneOfChecker( $services ),
193		- $config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
194		- => ConstraintCheckerServices::getValueOnlyChecker( $services ),
195		- $config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
196		- => ConstraintCheckerServices::getReferenceChecker( $services ),
197		- $config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
198		- => ConstraintCheckerServices::getNoBoundsChecker( $services ),
199		- $config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
200		- => ConstraintCheckerServices::getAllowedUnitsChecker( $services ),
201		- $config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
202		- => ConstraintCheckerServices::getSingleBestValueChecker( $services ),
203		- $config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
204		- => ConstraintCheckerServices::getEntityTypeChecker( $services ),
205		- $config->get( 'WBQualityConstraintsNoneOfConstraintId' )
206		- => ConstraintCheckerServices::getNoneOfChecker( $services ),
207		- $config->get( 'WBQualityConstraintsIntegerConstraintId' )
208		- => ConstraintCheckerServices::getIntegerChecker( $services ),
209		- $config->get( 'WBQualityConstraintsCitationNeededConstraintId' )
210		- => ConstraintCheckerServices::getCitationNeededChecker( $services ),
211		- $config->get( 'WBQualityConstraintsPropertyScopeConstraintId' )
212		- => ConstraintCheckerServices::getPropertyScopeChecker( $services ),
213		- $config->get( 'WBQualityConstraintsContemporaryConstraintId' )
214		- => ConstraintCheckerServices::getContemporaryChecker( $services ),
	157	+ $config->get('WBQualityConstraintsConflictsWithConstraintId')
	158	+ => ConstraintCheckerServices::getConflictsWithChecker($services),
	159	+ $config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
	160	+ => ConstraintCheckerServices::getItemChecker($services),
	161	+ $config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
	162	+ => ConstraintCheckerServices::getTargetRequiredClaimChecker($services),
	163	+ $config->get('WBQualityConstraintsSymmetricConstraintId')
	164	+ => ConstraintCheckerServices::getSymmetricChecker($services),
	165	+ $config->get('WBQualityConstraintsInverseConstraintId')
	166	+ => ConstraintCheckerServices::getInverseChecker($services),
	167	+ $config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
	168	+ => ConstraintCheckerServices::getQualifierChecker($services),
	169	+ $config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
	170	+ => ConstraintCheckerServices::getQualifiersChecker($services),
	171	+ $config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
	172	+ => ConstraintCheckerServices::getMandatoryQualifiersChecker($services),
	173	+ $config->get('WBQualityConstraintsRangeConstraintId')
	174	+ => ConstraintCheckerServices::getRangeChecker($services),
	175	+ $config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
	176	+ => ConstraintCheckerServices::getDiffWithinRangeChecker($services),
	177	+ $config->get('WBQualityConstraintsTypeConstraintId')
	178	+ => ConstraintCheckerServices::getTypeChecker($services),
	179	+ $config->get('WBQualityConstraintsValueTypeConstraintId')
	180	+ => ConstraintCheckerServices::getValueTypeChecker($services),
	181	+ $config->get('WBQualityConstraintsSingleValueConstraintId')
	182	+ => ConstraintCheckerServices::getSingleValueChecker($services),
	183	+ $config->get('WBQualityConstraintsMultiValueConstraintId')
	184	+ => ConstraintCheckerServices::getMultiValueChecker($services),
	185	+ $config->get('WBQualityConstraintsDistinctValuesConstraintId')
	186	+ => ConstraintCheckerServices::getUniqueValueChecker($services),
	187	+ $config->get('WBQualityConstraintsFormatConstraintId')
	188	+ => ConstraintCheckerServices::getFormatChecker($services),
	189	+ $config->get('WBQualityConstraintsCommonsLinkConstraintId')
	190	+ => ConstraintCheckerServices::getCommonsLinkChecker($services),
	191	+ $config->get('WBQualityConstraintsOneOfConstraintId')
	192	+ => ConstraintCheckerServices::getOneOfChecker($services),
	193	+ $config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
	194	+ => ConstraintCheckerServices::getValueOnlyChecker($services),
	195	+ $config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
	196	+ => ConstraintCheckerServices::getReferenceChecker($services),
	197	+ $config->get('WBQualityConstraintsNoBoundsConstraintId')
	198	+ => ConstraintCheckerServices::getNoBoundsChecker($services),
	199	+ $config->get('WBQualityConstraintsAllowedUnitsConstraintId')
	200	+ => ConstraintCheckerServices::getAllowedUnitsChecker($services),
	201	+ $config->get('WBQualityConstraintsSingleBestValueConstraintId')
	202	+ => ConstraintCheckerServices::getSingleBestValueChecker($services),
	203	+ $config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
	204	+ => ConstraintCheckerServices::getEntityTypeChecker($services),
	205	+ $config->get('WBQualityConstraintsNoneOfConstraintId')
	206	+ => ConstraintCheckerServices::getNoneOfChecker($services),
	207	+ $config->get('WBQualityConstraintsIntegerConstraintId')
	208	+ => ConstraintCheckerServices::getIntegerChecker($services),
	209	+ $config->get('WBQualityConstraintsCitationNeededConstraintId')
	210	+ => ConstraintCheckerServices::getCitationNeededChecker($services),
	211	+ $config->get('WBQualityConstraintsPropertyScopeConstraintId')
	212	+ => ConstraintCheckerServices::getPropertyScopeChecker($services),
	213	+ $config->get('WBQualityConstraintsContemporaryConstraintId')
	214	+ => ConstraintCheckerServices::getContemporaryChecker($services),
215	215	];
216	216
217	217	return new DelegatingConstraintChecker(
218		- WikibaseServices::getEntityLookup( $services ),
	218	+ WikibaseServices::getEntityLookup($services),
219	219	$checkerMap,
220		- ConstraintsServices::getConstraintLookup( $services ),
221		- ConstraintsServices::getConstraintParameterParser( $services ),
	220	+ ConstraintsServices::getConstraintLookup($services),
	221	+ ConstraintsServices::getConstraintParameterParser($services),
222	222	$statementGuidParser,
223		- ConstraintsServices::getLoggingHelper( $services ),
224		- $config->get( 'WBQualityConstraintsCheckQualifiers' ),
225		- $config->get( 'WBQualityConstraintsCheckReferences' ),
226		- $config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
	223	+ ConstraintsServices::getLoggingHelper($services),
	224	+ $config->get('WBQualityConstraintsCheckQualifiers'),
	225	+ $config->get('WBQualityConstraintsCheckReferences'),
	226	+ $config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
227	227	);
228	228	},
229	229
230		- ConstraintsServices::RESULTS_SOURCE => function( MediaWikiServices $services ) {
	230	+ ConstraintsServices::RESULTS_SOURCE => function(MediaWikiServices $services) {
231	231	$config = $services->getMainConfig();
232	232	$resultsSource = new CheckingResultsSource(
233		- ConstraintsServices::getDelegatingConstraintChecker( $services )
	233	+ ConstraintsServices::getDelegatingConstraintChecker($services)
234	234	);
235	235
236		- if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
	236	+ if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
237	237	$possiblyStaleConstraintTypes = [
238		- $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
239		- $config->get( 'WBQualityConstraintsTypeConstraintId' ),
240		- $config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
241		- $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
	238	+ $config->get('WBQualityConstraintsCommonsLinkConstraintId'),
	239	+ $config->get('WBQualityConstraintsTypeConstraintId'),
	240	+ $config->get('WBQualityConstraintsValueTypeConstraintId'),
	241	+ $config->get('WBQualityConstraintsDistinctValuesConstraintId'),
242	242	];
243	243	// TODO in the future, get EntityIdParser and WikiPageEntityMetaDataAccessor from $services?
244	244	$repo = WikibaseRepo::getDefaultInstance();
		@@ -247,21 +247,21 @@ discard block
		block discarded – undo
247	247	$wikiPageEntityMetaDataAccessor = new WikiPageEntityMetaDataLookup(
248	248	$entityNamespaceLookup,
249	249	$services->getSlotRoleStore(),
250		- $repo->getSettings()->getSetting( 'changesDatabase' ),
	250	+ $repo->getSettings()->getSetting('changesDatabase'),
251	251	'' // Empty string here means this only works for the local repo
252	252	);
253	253
254	254	$resultsSource = new CachingResultsSource(
255	255	$resultsSource,
256	256	ResultsCache::getDefaultInstance(),
257		- ConstraintsServices::getCheckResultSerializer( $services ),
258		- ConstraintsServices::getCheckResultDeserializer( $services ),
	257	+ ConstraintsServices::getCheckResultSerializer($services),
	258	+ ConstraintsServices::getCheckResultDeserializer($services),
259	259	$wikiPageEntityMetaDataAccessor,
260	260	$entityIdParser,
261		- $config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
	261	+ $config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
262	262	$possiblyStaleConstraintTypes,
263		- $config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ),
264		- ConstraintsServices::getLoggingHelper( $services )
	263	+ $config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'),
	264	+ ConstraintsServices::getLoggingHelper($services)
265	265	);
266	266	}
267	267

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( 648f65...d7bb4b )

Status

Category

Spacing +100 added lines, -100 removed lines patch added patch discarded remove patch