wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Helper/ShellboxHelper.php

Spacing +3 added lines, -3 removed lines

@@ -21,12 +21,12 @@
 	 * @return false|int (from the preg_match documentation) returns 1 if the pattern
 	 * matches given subject, 0 if it does not, or FALSE if an error occurred.
 	 */
-	public static function runRegexCheck( string $regex, string $text ) {
-		$pattern = '(^(?:' . $regex . ')$)u';
+	public static function runRegexCheck(string $regex, string $text) {
+		$pattern = '(^(?:'.$regex.')$)u';
 
 		// `preg_match` emits an E_WARNING when the pattern is not valid regex.
 		// Silence this warning to avoid throwing a ShellboxError.
 		// phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
-		return @preg_match( $pattern, $text );
+		return @preg_match($pattern, $text);
 	}
 }

src/ConstraintCheck/Checker/FormatChecker.php

Spacing +43 added lines, -43 removed lines

@@ -94,7 +94,7 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
@@ -109,9 +109,9 @@ 
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -120,7 +120,7 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Format' constraint has to be 'string' or 'monolingualtext'
 		 */
-		switch ( $dataValue->getType() ) {
+		switch ($dataValue->getType()) {
 			case 'string':
 				$text = $dataValue->getValue();
 				break;
@@ -130,13 +130,13 @@ 
 				$text = $dataValue->getText();
 				break;
 			default:
-				$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
-					->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-					->withDataValueType( 'string' )
-					->withDataValueType( 'monolingualtext' );
-				return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+				$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
+					->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+					->withDataValueType('string')
+					->withDataValueType('monolingualtext');
+				return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
-		$status = $this->runRegexCheck( $text, $format );
+		$status = $this->runRegexCheck($text, $format);
 		$message = $this->formatMessage(
 			$status,
 			$text,
@@ -145,7 +145,7 @@ 
 			$syntaxClarifications,
 			$constraintTypeItemId
 		);
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
 	private function formatMessage(
@@ -157,76 +157,76 @@ 
 		string $constraintTypeItemId
 	): ?ViolationMessage {
 		$message = null;
-		if ( $status === CheckResult::STATUS_VIOLATION ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-format-clarification' ) )
-				->withEntityId( $propertyId, Role::CONSTRAINT_PROPERTY )
-				->withDataValue( new StringValue( $text ), Role::OBJECT )
-				->withInlineCode( $format, Role::CONSTRAINT_PARAMETER_VALUE )
-				->withMultilingualText( $syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE );
-		} elseif ( $status === CheckResult::STATUS_TODO ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-security-reason' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM );
+		if ($status === CheckResult::STATUS_VIOLATION) {
+			$message = (new ViolationMessage('wbqc-violation-message-format-clarification'))
+				->withEntityId($propertyId, Role::CONSTRAINT_PROPERTY)
+				->withDataValue(new StringValue($text), Role::OBJECT)
+				->withInlineCode($format, Role::CONSTRAINT_PARAMETER_VALUE)
+				->withMultilingualText($syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE);
+		} elseif ($status === CheckResult::STATUS_TODO) {
+			$message = (new ViolationMessage('wbqc-violation-message-security-reason'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM);
 		}
 
 		return $message;
 	}
 
-	private function runRegexCheck( string $text, string $format ): string {
-		if ( !$this->config->get( 'WBQualityConstraintsCheckFormatConstraint' ) ) {
+	private function runRegexCheck(string $text, string $format): string {
+		if (!$this->config->get('WBQualityConstraintsCheckFormatConstraint')) {
 			return CheckResult::STATUS_TODO;
 		}
 		if (
-			$this->config->get( 'WBQualityConstraintsFormatCheckerShellboxRatio' ) > (float)wfRandom()
+			$this->config->get('WBQualityConstraintsFormatCheckerShellboxRatio') > (float) wfRandom()
 		) {
-			return $this->runRegexCheckUsingShellbox( $text, $format );
+			return $this->runRegexCheckUsingShellbox($text, $format);
 		}
 
-		return $this->runRegexCheckUsingSparql( $text, $format );
+		return $this->runRegexCheckUsingSparql($text, $format);
 	}
 
 	/**
 	 * @throws ConstraintParameterException
 	 */
-	private function runRegexCheckUsingShellbox( string $text, string $format ): string {
-		if ( !$this->shellboxClientFactory->isEnabled( 'constraint-regex-checker' ) ) {
+	private function runRegexCheckUsingShellbox(string $text, string $format): string {
+		if (!$this->shellboxClientFactory->isEnabled('constraint-regex-checker')) {
 			return CheckResult::STATUS_TODO;
 		}
 
-		$shellboxResponse = $this->shellboxClientFactory->getClient( [
-			'timeout' => $this->config->get( 'WBQualityConstraintsSparqlMaxMillis' ) / 1000,
+		$shellboxResponse = $this->shellboxClientFactory->getClient([
+			'timeout' => $this->config->get('WBQualityConstraintsSparqlMaxMillis') / 1000,
 			'service' => 'constraint-regex-checker',
-		] )->call(
+		])->call(
 			'constraint-regex-checker',
-			[ ShellboxHelper::class, 'runRegexCheck' ],
-			[ $format, $text ],
-			[ 'classes' => [ ShellboxHelper::class ] ],
+			[ShellboxHelper::class, 'runRegexCheck'],
+			[$format, $text],
+			['classes' => [ShellboxHelper::class]],
 		);
 
-		if ( $shellboxResponse === 1 ) {
+		if ($shellboxResponse === 1) {
 			return CheckResult::STATUS_COMPLIANCE;
-		} elseif ( $shellboxResponse === 0 ) {
+		} elseif ($shellboxResponse === 0) {
 			return CheckResult::STATUS_VIOLATION;
 		} else {
 			throw new ConstraintParameterException(
-				( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) )
-					->withInlineCode( $format, Role::CONSTRAINT_PARAMETER_VALUE )
+				(new ViolationMessage('wbqc-violation-message-parameter-regex'))
+					->withInlineCode($format, Role::CONSTRAINT_PARAMETER_VALUE)
 			);
 		}
 	}
 
-	private function runRegexCheckUsingSparql( string $text, string $format ): string {
-		if ( $this->sparqlHelper instanceof DummySparqlHelper ) {
+	private function runRegexCheckUsingSparql(string $text, string $format): string {
+		if ($this->sparqlHelper instanceof DummySparqlHelper) {
 			return CheckResult::STATUS_TODO;
 		}
 
-		if ( $this->sparqlHelper->matchesRegularExpression( $text, $format ) ) {
+		if ($this->sparqlHelper->matchesRegularExpression($text, $format)) {
 			return CheckResult::STATUS_COMPLIANCE;
 		} else {
 			return CheckResult::STATUS_VIOLATION;
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -235,14 +235,14 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
 			$this->constraintParameterParser->parseSyntaxClarificationParameter(
 				$constraintParameters
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;