wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintRepository.php

Spacing +42 added lines, -42 removed lines

@@ -21,23 +21,23 @@ 
 	 *
 	 * @return Constraint[]
 	 */
-	public function queryConstraintsForProperty( PropertyId $propertyId ) {
-		$db = wfGetDB( DB_REPLICA );
+	public function queryConstraintsForProperty(PropertyId $propertyId) {
+		$db = wfGetDB(DB_REPLICA);
 
 		$results = $db->select(
 			'wbqc_constraints',
 			'*',
-			[ 'pid' => $propertyId->getNumericId() ]
+			['pid' => $propertyId->getNumericId()]
 		);
 
-		return $this->convertToConstraints( $results );
+		return $this->convertToConstraints($results);
 	}
 
-	private function encodeConstraintParameters( array $constraintParameters ) {
-		$json = json_encode( $constraintParameters, JSON_FORCE_OBJECT );
+	private function encodeConstraintParameters(array $constraintParameters) {
+		$json = json_encode($constraintParameters, JSON_FORCE_OBJECT);
 
-		if ( strlen( $json ) > 50000 ) {
-			$json = json_encode( [ '@error' => [ 'toolong' => true ] ] );
+		if (strlen($json) > 50000) {
+			$json = json_encode(['@error' => ['toolong' => true]]);
 		}
 
 		return $json;
@@ -49,21 +49,21 @@ 
 	 * @throws DBUnexpectedError
 	 * @return bool
 	 */
-	public function insertBatch( array $constraints ) {
+	public function insertBatch(array $constraints) {
 		$accumulator = array_map(
-			function ( Constraint $constraint ) {
+			function(Constraint $constraint) {
 				return [
 					'constraint_guid' => $constraint->getConstraintId(),
 					'pid' => $constraint->getPropertyId()->getNumericId(),
 					'constraint_type_qid' => $constraint->getConstraintTypeItemId(),
-					'constraint_parameters' => $this->encodeConstraintParameters( $constraint->getConstraintParameters() )
+					'constraint_parameters' => $this->encodeConstraintParameters($constraint->getConstraintParameters())
 				];
 			},
 			$constraints
 		);
 
-		$db = wfGetDB( DB_MASTER );
-		return $db->insert( 'wbqc_constraints', $accumulator );
+		$db = wfGetDB(DB_MASTER);
+		return $db->insert('wbqc_constraints', $accumulator);
 	}
 
 	/**
@@ -71,13 +71,13 @@ 
 	 *
 	 * @return array
 	 */
-	private function uuidPattern( LikeMatch $any ) {
+	private function uuidPattern(LikeMatch $any) {
 		return array_merge(
-			array_fill( 0, 8, $any ), [ '-' ],
-			array_fill( 0, 4, $any ), [ '-' ],
-			array_fill( 0, 4, $any ), [ '-' ],
-			array_fill( 0, 4, $any ), [ '-' ],
-			array_fill( 0, 12, $any )
+			array_fill(0, 8, $any), ['-'],
+			array_fill(0, 4, $any), ['-'],
+			array_fill(0, 4, $any), ['-'],
+			array_fill(0, 4, $any), ['-'],
+			array_fill(0, 12, $any)
 		);
 	}
 
@@ -88,11 +88,11 @@ 
 	 * @throws DBUnexpectedError
 	 */
 	public function deleteWhereConstraintIdIsUuid() {
-		$db = wfGetDB( DB_MASTER );
+		$db = wfGetDB(DB_MASTER);
 		$db->delete(
 			'wbqc_constraints',
 			// WHERE constraint_guid LIKE ________-____-____-____-____________
-			'constraint_guid ' . $db->buildLike( $this->uuidPattern( $db->anyChar() ) )
+			'constraint_guid '.$db->buildLike($this->uuidPattern($db->anyChar()))
 		);
 	}
 
@@ -104,14 +104,14 @@ 
 	 *
 	 * @throws DBUnexpectedError
 	 */
-	public function deleteForPropertyWhereConstraintIdIsStatementId( PropertyId $propertyId ) {
-		$db = wfGetDB( DB_MASTER );
+	public function deleteForPropertyWhereConstraintIdIsStatementId(PropertyId $propertyId) {
+		$db = wfGetDB(DB_MASTER);
 		$db->delete(
 			'wbqc_constraints',
 			[
 				'pid' => $propertyId->getNumericId(),
 				// AND constraint_guid LIKE %$________-____-____-____-____________
-				'constraint_guid ' . $db->buildLike( array_merge( [ $db->anyString(), '$' ], $this->uuidPattern( $db->anyChar() ) ) )
+				'constraint_guid '.$db->buildLike(array_merge([$db->anyString(), '$'], $this->uuidPattern($db->anyChar())))
 			]
 		);
 	}
@@ -122,21 +122,21 @@ 
 	 * @throws InvalidArgumentException
 	 * @throws DBUnexpectedError
 	 */
-	public function deleteAll( $batchSize = 1000 ) {
-		if ( !is_int( $batchSize ) ) {
+	public function deleteAll($batchSize = 1000) {
+		if (!is_int($batchSize)) {
 			throw new InvalidArgumentException();
 		}
 		$lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
-		$db = $lbFactory->getMainLB()->getConnection( DB_MASTER );
-		if ( $db->getType() === 'sqlite' ) {
-			$db->delete( 'wbqc_constraints', '*' );
+		$db = $lbFactory->getMainLB()->getConnection(DB_MASTER);
+		if ($db->getType() === 'sqlite') {
+			$db->delete('wbqc_constraints', '*');
 		} else {
 			do {
-				$db->commit( __METHOD__, 'flush' );
+				$db->commit(__METHOD__, 'flush');
 				$lbFactory->waitForReplication();
-				$table = $db->tableName( 'wbqc_constraints' );
-				$db->query( sprintf( 'DELETE FROM %s LIMIT %d', $table, $batchSize ) );
-			} while ( $db->affectedRows() > 0 );
+				$table = $db->tableName('wbqc_constraints');
+				$db->query(sprintf('DELETE FROM %s LIMIT %d', $table, $batchSize));
+			} while ($db->affectedRows() > 0);
 		}
 	}
 
@@ -145,26 +145,26 @@ 
 	 *
 	 * @return Constraint[]
 	 */
-	private function convertToConstraints( IResultWrapper $results ) {
+	private function convertToConstraints(IResultWrapper $results) {
 		$constraints = [];
-		foreach ( $results as $result ) {
+		foreach ($results as $result) {
 			$constraintTypeItemId = $result->constraint_type_qid;
-			$constraintParameters = json_decode( $result->constraint_parameters, true );
+			$constraintParameters = json_decode($result->constraint_parameters, true);
 
-			if ( $constraintParameters === null ) {
+			if ($constraintParameters === null) {
 				// T171295
-				LoggerFactory::getInstance( 'WikibaseQualityConstraints' )
-					->warning( 'Constraint {constraintId} has invalid constraint parameters.', [
+				LoggerFactory::getInstance('WikibaseQualityConstraints')
+					->warning('Constraint {constraintId} has invalid constraint parameters.', [
 						'method' => __METHOD__,
 						'constraintId' => $result->constraint_guid,
 						'constraintParameters' => $result->constraint_parameters,
-					] );
-				$constraintParameters = [ '@error' => [ /* unknown */ ] ];
+					]);
+				$constraintParameters = ['@error' => [/* unknown */]];
 			}
 
 			$constraints[] = new Constraint(
 				$result->constraint_guid,
-				PropertyId::newFromNumber( $result->pid ),
+				PropertyId::newFromNumber($result->pid),
 				$constraintTypeItemId,
 				$constraintParameters
 			);

src/ConstraintCheck/Checker/CommonsLinkChecker.php

Spacing +42 added lines, -42 removed lines

@@ -80,22 +80,22 @@ 
 	 * @return array first element is the namespace number (default namespace for TitleParser),
 	 * second element is a string to prepend to the title before giving it to the TitleParser
 	 */
-	private function getCommonsNamespace( $namespace ) {
+	private function getCommonsNamespace($namespace) {
 		// for namespace numbers see mediawiki-config repo, wmf-config/InitialiseSettings.php,
 		// 'wgExtraNamespaces' key, 'commonswiki' subkey
-		switch ( $namespace ) {
+		switch ($namespace) {
 			case '':
-				return [ NS_MAIN, '' ];
+				return [NS_MAIN, ''];
 			case 'Creator':
-				return [ 100, '' ];
+				return [100, ''];
 			case 'TimedText':
-				return [ 102, '' ];
+				return [102, ''];
 			case 'Sequence':
-				return [ 104, '' ];
+				return [104, ''];
 			case 'Institution':
-				return [ 106, '' ];
+				return [106, ''];
 			default:
-				return [ NS_MAIN, $namespace . ':' ];
+				return [NS_MAIN, $namespace.':'];
 		}
 	}
 
@@ -108,17 +108,17 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
-		$namespace = $this->constraintParameterParser->parseNamespaceParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['namespace'] = [ $namespace ];
+		$namespace = $this->constraintParameterParser->parseNamespaceParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['namespace'] = [$namespace];
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -128,46 +128,46 @@ 
 		 *   type of $dataValue for properties with 'Commons link' constraint has to be 'string'
 		 *   parameter $namespace can be null, works for commons galleries
 		 */
-		if ( $dataValue->getType() !== 'string' ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'string' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if ($dataValue->getType() !== 'string') {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('string');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$commonsLink = $dataValue->getValue();
 
 		try {
-			if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) {
-				throw new MalformedTitleException( 'wbqc-violation-message-commons-link-not-well-formed', $commonsLink ); // caught below
+			if (!$this->commonsLinkIsWellFormed($commonsLink)) {
+				throw new MalformedTitleException('wbqc-violation-message-commons-link-not-well-formed', $commonsLink); // caught below
 			}
-			list( $defaultNamespace, $prefix ) = $this->getCommonsNamespace( $namespace );
-			$title = $this->titleParser->parseTitle( $prefix . $commonsLink, $defaultNamespace );
-			if ( $this->pageExists( $title ) ) {
+			list($defaultNamespace, $prefix) = $this->getCommonsNamespace($namespace);
+			$title = $this->titleParser->parseTitle($prefix.$commonsLink, $defaultNamespace);
+			if ($this->pageExists($title)) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 			} else {
-				if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) {
-					throw new MalformedTitleException( 'wbqc-violation-message-commons-link-not-well-formed', $commonsLink ); // caught below
+				if ($this->valueIncludesNamespace($commonsLink, $namespace)) {
+					throw new MalformedTitleException('wbqc-violation-message-commons-link-not-well-formed', $commonsLink); // caught below
 				} else {
-					$message = new ViolationMessage( 'wbqc-violation-message-commons-link-no-existent' );
+					$message = new ViolationMessage('wbqc-violation-message-commons-link-no-existent');
 					$status = CheckResult::STATUS_VIOLATION;
 				}
 			}
-		} catch ( MalformedTitleException $e ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' );
+		} catch (MalformedTitleException $e) {
+			$message = new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed');
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseNamespaceParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseNamespaceParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;
@@ -178,20 +178,20 @@ 
 	 *
 	 * @return bool
 	 */
-	private function pageExists( TitleValue $title ) {
+	private function pageExists(TitleValue $title) {
 		$commonsWikiId = 'commonswiki';
-		if ( defined( 'MW_PHPUNIT_TEST' ) ) {
+		if (defined('MW_PHPUNIT_TEST')) {
 			$commonsWikiId = false;
 		}
 
 		$lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
-		$dbConnection = $lbFactory->getMainLB( $commonsWikiId )->getConnection(
+		$dbConnection = $lbFactory->getMainLB($commonsWikiId)->getConnection(
 			DB_REPLICA, false, $commonsWikiId
 		);
-		$row = $dbConnection->selectRow( 'page', '*', [
+		$row = $dbConnection->selectRow('page', '*', [
 			'page_title' => $title->getDBkey(),
 			'page_namespace' => $title->getNamespace()
-		] );
+		]);
 
 		return $row !== false;
 	}
@@ -201,9 +201,9 @@ 
 	 *
 	 * @return bool
 	 */
-	private function commonsLinkIsWellFormed( $commonsLink ) {
-		$toReplace = [ "_", "%20" ];
-		$compareString = trim( str_replace( $toReplace, '', $commonsLink ) );
+	private function commonsLinkIsWellFormed($commonsLink) {
+		$toReplace = ["_", "%20"];
+		$compareString = trim(str_replace($toReplace, '', $commonsLink));
 		return $commonsLink === $compareString;
 	}
 
@@ -216,9 +216,9 @@ 
 	 *
 	 * @return bool
 	 */
-	private function valueIncludesNamespace( $value, $namespace ) {
+	private function valueIncludesNamespace($value, $namespace) {
 		return $namespace !== '' &&
-			strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0;
+			strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0;
 	}
 
 }