wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Specials/SpecialConstraintReport.php

Spacing +86 added lines, -86 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Specials;
 
@@ -91,7 +91,7 @@ 
 		Config $config,
 		StatsFactory $statsFactory
 	) {
-		parent::__construct( 'ConstraintReport' );
+		parent::__construct('ConstraintReport');
 
 		$this->entityLookup = $entityLookup;
 		$this->entityTitleLookup = $entityTitleLookup;
@@ -111,7 +111,7 @@ 
 
 		$this->violationMessageRenderer = $violationMessageRendererFactory->getViolationMessageRenderer(
 			$language,
-			$languageFallbackChainFactory->newFromLanguage( $language ),
+			$languageFallbackChainFactory->newFromLanguage($language),
 			$this->getContext()
 		);
 
@@ -145,7 +145,7 @@ 
 	 * @inheritDoc
 	 */
 	public function getDescription() {
-		return $this->msg( 'wbqc-constraintreport' );
+		return $this->msg('wbqc-constraintreport');
 	}
 
 	/**
@@ -157,71 +157,71 @@ 
 	 * @throws EntityIdParsingException
 	 * @throws UnexpectedValueException
 	 */
-	public function execute( $subPage ) {
+	public function execute($subPage) {
 		$out = $this->getOutput();
 
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
-		if ( $postRequest ) {
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
+		if ($postRequest) {
 			try {
-				$entityId = $this->entityIdParser->parse( $postRequest );
-				$out->redirect( $this->getPageTitle( $entityId->getSerialization() )->getLocalURL() );
+				$entityId = $this->entityIdParser->parse($postRequest);
+				$out->redirect($this->getPageTitle($entityId->getSerialization())->getLocalURL());
 				return;
-			} catch ( EntityIdParsingException ) {
+			} catch (EntityIdParsingException) {
 				// fall through, error is shown later
 			}
 		}
 
 		$out->enableOOUI();
-		$out->addModules( $this->getModules() );
+		$out->addModules($this->getModules());
 
 		$this->setHeaders();
 
-		$out->addHTML( $this->getExplanationText() );
+		$out->addHTML($this->getExplanationText());
 		$this->buildEntityIdForm();
 
-		if ( $postRequest ) {
+		if ($postRequest) {
 			// must be an invalid entity ID (otherwise we would have redirected and returned above)
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
 			);
 			return;
 		}
 
-		if ( !$subPage ) {
+		if (!$subPage) {
 			return;
 		}
 
 		try {
-			$entityId = $this->entityIdParser->parse( $subPage );
-		} catch ( EntityIdParsingException ) {
+			$entityId = $this->entityIdParser->parse($subPage);
+		} catch (EntityIdParsingException) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
 			);
 			return;
 		}
 
-		if ( !$this->entityLookup->hasEntity( $entityId ) ) {
+		if (!$this->entityLookup->hasEntity($entityId)) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true )
+				$this->buildNotice('wbqc-constraintreport-not-existent-entity', true)
 			);
 			return;
 		}
 
-		$this->statsFactory->getCounter( 'special_constraint_report_execute_check_total' )
+		$this->statsFactory->getCounter('special_constraint_report_execute_check_total')
 			->increment();
-		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId );
+		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId);
 
-		if ( !$results ) {
-			$out->addHTML( $this->buildResultHeader( $entityId ) .
-				$this->buildNotice( 'wbqc-constraintreport-empty-result' )
+		if (!$results) {
+			$out->addHTML($this->buildResultHeader($entityId).
+				$this->buildNotice('wbqc-constraintreport-empty-result')
 			);
 			return;
 		}
 
 		$out->addHTML(
-			$this->buildResultHeader( $entityId )
-			. $this->buildSummary( $results )
-			. $this->buildResultTable( $entityId, $results )
+			$this->buildResultHeader($entityId)
+			. $this->buildSummary($results)
+			. $this->buildResultTable($entityId, $results)
 		);
 	}
 
@@ -236,15 +236,15 @@ 
 				'name' => 'entityid',
 				'label-message' => 'wbqc-constraintreport-form-entityid-label',
 				'cssclass' => 'wbqc-constraintreport-form-entity-id',
-				'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->text(),
+				'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->text(),
 				'required' => true,
 			],
 		];
-		$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(),
+		$htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(),
 			'wbqc-constraintreport-form'
 		);
-		$htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->text() );
-		$htmlForm->setSubmitCallback( static fn () => false );
+		$htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->text());
+		$htmlForm->setSubmitCallback(static fn () => false);
 		$htmlForm->show();
 	}
 
@@ -258,16 +258,16 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildNotice( string $messageKey, bool $error = false ): string {
-		$cssClasses = [ 'wbqc-constraintreport-notice' ];
-		if ( $error ) {
+	private function buildNotice(string $messageKey, bool $error = false): string {
+		$cssClasses = ['wbqc-constraintreport-notice'];
+		if ($error) {
 			$cssClasses[] = ' wbqc-constraintreport-notice-error';
 		}
 
 		return Html::element(
 			'p',
-			[ 'class' => $cssClasses ],
-			$this->msg( $messageKey )->text()
+			['class' => $cssClasses],
+			$this->msg($messageKey)->text()
 		);
 	}
 
@@ -277,16 +277,16 @@ 
 	private function getExplanationText(): string {
 		return Html::rawElement(
 			'div',
-			[ 'class' => 'wbqc-explanation' ],
+			['class' => 'wbqc-explanation'],
 			Html::element(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-one' )->text()
+				$this->msg('wbqc-constraintreport-explanation-part-one')->text()
 			)
 			. Html::element(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-two' )->text()
+				$this->msg('wbqc-constraintreport-explanation-part-two')->text()
 			)
 		);
 	}
@@ -297,31 +297,31 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildResultTable( EntityId $entityId, array $results ): string {
+	private function buildResultTable(EntityId $entityId, array $results): string {
 		// Set table headers
 		$table = new HtmlTableBuilder(
 			[
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-status' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-status')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-property' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-property')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-message' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-message')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-constraint')->text(),
 					true
 				),
 			]
 		);
 
-		foreach ( $results as $result ) {
-			$this->appendToResultTable( $table, $entityId, $result );
+		foreach ($results as $result) {
+			$this->appendToResultTable($table, $entityId, $result);
 		}
 
 		return $table->toHtml();
@@ -333,35 +333,35 @@ 
 		CheckResult $result
 	): void {
 		$message = $result->getMessage();
-		if ( !$message ) {
+		if (!$message) {
 			// no row for this result
 			return;
 		}
 
 		// Status column
-		$statusColumn = $this->formatStatus( $result->getStatus() );
+		$statusColumn = $this->formatStatus($result->getStatus());
 
 		// Property column
-		$propertyId = new NumericPropertyId( $result->getContextCursor()->getSnakPropertyId() );
+		$propertyId = new NumericPropertyId($result->getContextCursor()->getSnakPropertyId());
 		$propertyColumn = $this->getClaimLink(
 			$entityId,
 			$propertyId,
-			$this->entityIdLabelFormatter->formatEntityId( $propertyId )
+			$this->entityIdLabelFormatter->formatEntityId($propertyId)
 		);
 
 		// Message column
-		$messageColumn = $this->violationMessageRenderer->render( $message );
+		$messageColumn = $this->violationMessageRenderer->render($message);
 
 		// Constraint column
 		$constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId();
 		try {
-			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) );
-		} catch ( InvalidArgumentException ) {
-			$constraintTypeLabel = htmlspecialchars( $constraintTypeItemId );
+			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId));
+		} catch (InvalidArgumentException) {
+			$constraintTypeLabel = htmlspecialchars($constraintTypeItemId);
 		}
 		$constraintColumn = $this->getClaimLink(
 			$propertyId,
-			new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ),
+			new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')),
 			$constraintTypeLabel
 		);
 
@@ -369,16 +369,16 @@ 
 		$table->appendRow(
 			[
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $statusColumn )
+					new HtmlArmor($statusColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $propertyColumn )
+					new HtmlArmor($propertyColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $messageColumn )
+					new HtmlArmor($messageColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $constraintColumn )
+					new HtmlArmor($constraintColumn)
 				),
 			]
 		);
@@ -391,15 +391,15 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildResultHeader( EntityId $entityId ): string {
+	protected function buildResultHeader(EntityId $entityId): string {
 		return Html::rawElement(
 			'h3',
 			[],
-			$this->msg( 'wbqc-constraintreport-result-headline' )->escaped() .
-				$this->msg( 'word-separator' )->escaped() .
-				$this->entityIdLinkFormatter->formatEntityId( $entityId ) .
-				$this->msg( 'word-separator' )->escaped() .
-				$this->msg( 'parentheses', $entityId->getSerialization() )->escaped()
+			$this->msg('wbqc-constraintreport-result-headline')->escaped().
+				$this->msg('word-separator')->escaped().
+				$this->entityIdLinkFormatter->formatEntityId($entityId).
+				$this->msg('word-separator')->escaped().
+				$this->msg('parentheses', $entityId->getSerialization())->escaped()
 		);
 	}
 
@@ -410,23 +410,23 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildSummary( array $results ): string {
+	protected function buildSummary(array $results): string {
 		$statuses = [];
-		foreach ( $results as $result ) {
-			$status = strtolower( $result->getStatus() );
+		foreach ($results as $result) {
+			$status = strtolower($result->getStatus());
 			$statuses[$status] ??= 0;
 			$statuses[$status]++;
 		}
 
 		$statusElements = [];
-		foreach ( $statuses as $status => $count ) {
-			$statusElements[] = $this->formatStatus( $status ) .
-				$this->msg( 'colon-separator' )->escaped() .
-				htmlspecialchars( $this->getLanguage()->formatNum( $count ) );
+		foreach ($statuses as $status => $count) {
+			$statusElements[] = $this->formatStatus($status).
+				$this->msg('colon-separator')->escaped().
+				htmlspecialchars($this->getLanguage()->formatNum($count));
 		}
 
-		return Html::rawElement( 'p', [],
-			implode( $this->msg( 'comma-separator' )->escaped(), $statusElements )
+		return Html::rawElement('p', [],
+			implode($this->msg('comma-separator')->escaped(), $statusElements)
 		);
 	}
 
@@ -439,8 +439,8 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function formatStatus( string $status ): string {
-		$messageName = "wbqc-constraintreport-status-" . strtolower( $status );
+	private function formatStatus(string $status): string {
+		$messageName = "wbqc-constraintreport-status-".strtolower($status);
 		$statusIcons = [
 			CheckResult::STATUS_SUGGESTION => [
 				'icon' => 'suggestion-constraint-violation',
@@ -457,21 +457,21 @@ 
 			],
 		];
 
-		if ( array_key_exists( $status, $statusIcons ) ) {
-			$iconHtml = new IconWidget( $statusIcons[$status] ) .
-				$this->msg( 'word-separator' )->escaped();
+		if (array_key_exists($status, $statusIcons)) {
+			$iconHtml = new IconWidget($statusIcons[$status]).
+				$this->msg('word-separator')->escaped();
 		} else {
 			$iconHtml = '';
 		}
 
-		$labelWidget = new LabelWidget( [ 'label' => $this->msg( $messageName )->text() ] );
+		$labelWidget = new LabelWidget(['label' => $this->msg($messageName)->text()]);
 
 		return Html::rawElement(
 			'span',
 			[
-				'class' => 'wbqc-status wbqc-status-' . $status,
+				'class' => 'wbqc-status wbqc-status-'.$status,
 			],
-			$iconHtml . $labelWidget
+			$iconHtml.$labelWidget
 		);
 	}
 
@@ -489,10 +489,10 @@ 
 		NumericPropertyId $propertyId,
 		string $text
 	): string {
-		$title = clone $this->entityTitleLookup->getTitleForId( $entityId );
-		$title->setFragment( $propertyId->getSerialization() );
+		$title = clone $this->entityTitleLookup->getTitleForId($entityId);
+		$title->setFragment($propertyId->getSerialization());
 
-		return Html::rawElement( 'a',
+		return Html::rawElement('a',
 			[
 				'href' => $title->getLinkURL(),
 				'target' => '_blank',

src/ConstraintCheck/Helper/TypeCheckerHelper.php

Spacing +49 added lines, -49 removed lines

@@ -81,26 +81,26 @@ 
 	 * @return bool
 	 * @throws OverflowException if $entitiesChecked exceeds the configured limit
 	 */
-	private function isSubclassOf( EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0 ) {
-		$maxEntities = $this->config->get( 'WBQualityConstraintsTypeCheckMaxEntities' );
+	private function isSubclassOf(EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0) {
+		$maxEntities = $this->config->get('WBQualityConstraintsTypeCheckMaxEntities');
 		if ( ++$entitiesChecked > $maxEntities ) {
-			throw new OverflowException( 'Too many entities to check' );
+			throw new OverflowException('Too many entities to check');
 		}
 
-		$item = $this->entityLookup->getEntity( $comparativeClass );
-		if ( !( $item instanceof StatementListProvider ) ) {
+		$item = $this->entityLookup->getEntity($comparativeClass);
+		if (!($item instanceof StatementListProvider)) {
 			return false; // lookup failed, probably because item doesn't exist
 		}
 
-		$subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
+		$subclassId = $this->config->get('WBQualityConstraintsSubclassOfId');
 		$statements = $item->getStatements()
-			->getByPropertyId( new NumericPropertyId( $subclassId ) )
+			->getByPropertyId(new NumericPropertyId($subclassId))
 			->getBestStatements();
 		/** @var Statement $statement */
-		foreach ( $statements as $statement ) {
+		foreach ($statements as $statement) {
 			$mainSnak = $statement->getMainSnak();
 
-			if ( !$this->hasCorrectType( $mainSnak ) ) {
+			if (!$this->hasCorrectType($mainSnak)) {
 				continue;
 			}
 			/** @var PropertyValueSnak $mainSnak */
@@ -110,11 +110,11 @@ 
 			'@phan-var EntityIdValue $dataValue';
 			$comparativeClass = $dataValue->getEntityId();
 
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
 				return true;
 			}
 
-			if ( $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked ) ) {
+			if ($this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked)) {
 				return true;
 			}
 		}
@@ -135,35 +135,35 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
 	 */
-	public function isSubclassOfWithSparqlFallback( EntityId $comparativeClass, array $classesToCheck ) {
-		$timing = $this->statsFactory->getTiming( 'isSubclassOf_duration_seconds' )
-			->setLabel( 'result', 'success' )
-			->setLabel( 'TypeCheckerImplementation', 'php' );
+	public function isSubclassOfWithSparqlFallback(EntityId $comparativeClass, array $classesToCheck) {
+		$timing = $this->statsFactory->getTiming('isSubclassOf_duration_seconds')
+			->setLabel('result', 'success')
+			->setLabel('TypeCheckerImplementation', 'php');
 		$timing->start();
 
 		try {
 			$entitiesChecked = 0;
-			$isSubclass = $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked );
+			$isSubclass = $this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked);
 			$timing->stop();
 
 			// not really a timing, but works like one (we want percentiles etc.)
 			// TODO: probably a good candidate for T348796
-			$this->statsFactory->getTiming( 'isSubclassOf_entities_total' )
-				->setLabel( 'TypeCheckerImplementation', 'php' )
-				->setLabel( 'result', 'success' )
-				->observe( $entitiesChecked );
-
-			return new CachedBool( $isSubclass, Metadata::blank() );
-		} catch ( OverflowException ) {
-			$timing->setLabel( 'result', 'overflow' )
+			$this->statsFactory->getTiming('isSubclassOf_entities_total')
+				->setLabel('TypeCheckerImplementation', 'php')
+				->setLabel('result', 'success')
+				->observe($entitiesChecked);
+
+			return new CachedBool($isSubclass, Metadata::blank());
+		} catch (OverflowException) {
+			$timing->setLabel('result', 'overflow')
 				->stop();
 
-			if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
-				$this->statsFactory->getCounter( 'sparql_typeFallback_total' )
+			if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
+				$this->statsFactory->getCounter('sparql_typeFallback_total')
 					->increment();
 
-				$timing->setLabel( 'TypeCheckerImplementation', 'sparql' )
-					->setLabel( 'result', 'success' )
+				$timing->setLabel('TypeCheckerImplementation', 'sparql')
+					->setLabel('result', 'success')
 					->start();
 
 				$hasType = $this->sparqlHelper->hasType(
@@ -175,7 +175,7 @@ 
 
 				return $hasType;
 			} else {
-				return new CachedBool( false, Metadata::blank() );
+				return new CachedBool(false, Metadata::blank());
 			}
 		}
 	}
@@ -193,13 +193,13 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
 	 */
-	public function hasClassInRelation( StatementList $statements, array $relationIds, array $classesToCheck ) {
+	public function hasClassInRelation(StatementList $statements, array $relationIds, array $classesToCheck) {
 		$metadatas = [];
 
-		foreach ( $this->getBestStatementsByPropertyIds( $statements, $relationIds ) as $statement ) {
+		foreach ($this->getBestStatementsByPropertyIds($statements, $relationIds) as $statement) {
 			$mainSnak = $statement->getMainSnak();
 
-			if ( !$this->hasCorrectType( $mainSnak ) ) {
+			if (!$this->hasCorrectType($mainSnak)) {
 				continue;
 			}
 			/** @var PropertyValueSnak $mainSnak */
@@ -209,24 +209,24 @@ 
 			'@phan-var EntityIdValue $dataValue';
 			$comparativeClass = $dataValue->getEntityId();
 
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
 				// discard $metadatas, we know this is fresh
-				return new CachedBool( true, Metadata::blank() );
+				return new CachedBool(true, Metadata::blank());
 			}
 
-			$result = $this->isSubclassOfWithSparqlFallback( $comparativeClass, $classesToCheck );
+			$result = $this->isSubclassOfWithSparqlFallback($comparativeClass, $classesToCheck);
 			$metadatas[] = $result->getMetadata();
-			if ( $result->getBool() ) {
+			if ($result->getBool()) {
 				return new CachedBool(
 					true,
-					Metadata::merge( $metadatas )
+					Metadata::merge($metadatas)
 				);
 			}
 		}
 
 		return new CachedBool(
 			false,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -235,7 +235,7 @@ 
 	 * @return bool
 	 * @phan-assert PropertyValueSnak $mainSnak
 	 */
-	private function hasCorrectType( Snak $mainSnak ) {
+	private function hasCorrectType(Snak $mainSnak) {
 		return $mainSnak instanceof PropertyValueSnak
 			&& $mainSnak->getDataValue()->getType() === 'wikibase-entityid';
 	}
@@ -252,15 +252,15 @@ 
 	) {
 		$statementArrays = [];
 
-		foreach ( $propertyIdSerializations as $propertyIdSerialization ) {
-			$propertyId = new NumericPropertyId( $propertyIdSerialization );
+		foreach ($propertyIdSerializations as $propertyIdSerialization) {
+			$propertyId = new NumericPropertyId($propertyIdSerialization);
 			$statementArrays[] = $statements
-				->getByPropertyId( $propertyId )
+				->getByPropertyId($propertyId)
 				->getBestStatements()
 				->toArray();
 		}
 
-		return array_merge( ...$statementArrays );
+		return array_merge(...$statementArrays);
 	}
 
 	/**
@@ -280,8 +280,8 @@ 
 		$relation
 	) {
 		$classes = array_map(
-			static function ( $itemIdSerialization ) {
-				return new ItemId( $itemIdSerialization );
+			static function($itemIdSerialization) {
+				return new ItemId($itemIdSerialization);
 			},
 			$classes
 		);
@@ -293,10 +293,10 @@ 
 		// wbqc-violation-message-valueType-instance
 		// wbqc-violation-message-valueType-subclass
 		// wbqc-violation-message-valueType-instanceOrSubclass
-		return ( new ViolationMessage( 'wbqc-violation-message-' . $checker . '-' . $relation ) )
-			->withEntityId( $propertyId, Role::CONSTRAINT_PROPERTY )
-			->withEntityId( $entityId, Role::SUBJECT )
-			->withEntityIdList( $classes, Role::OBJECT );
+		return (new ViolationMessage('wbqc-violation-message-'.$checker.'-'.$relation))
+			->withEntityId($propertyId, Role::CONSTRAINT_PROPERTY)
+			->withEntityId($entityId, Role::SUBJECT)
+			->withEntityIdList($classes, Role::OBJECT);
 	}
 
 }

src/ConstraintCheck/Helper/LoggingHelper.php

Spacing +36 added lines, -36 removed lines

@@ -53,12 +53,12 @@ 
 		$this->statsFactory = $statsFactory;
 		$this->logger = $logger;
 		$this->constraintCheckDurationLimits = [
-			'info' => $config->get( 'WBQualityConstraintsCheckDurationInfoSeconds' ),
-			'warning' => $config->get( 'WBQualityConstraintsCheckDurationWarningSeconds' ),
+			'info' => $config->get('WBQualityConstraintsCheckDurationInfoSeconds'),
+			'warning' => $config->get('WBQualityConstraintsCheckDurationWarningSeconds'),
 		];
 		$this->constraintCheckOnEntityDurationLimits = [
-			'info' => $config->get( 'WBQualityConstraintsCheckOnEntityDurationInfoSeconds' ),
-			'warning' => $config->get( 'WBQualityConstraintsCheckOnEntityDurationWarningSeconds' ),
+			'info' => $config->get('WBQualityConstraintsCheckOnEntityDurationInfoSeconds'),
+			'warning' => $config->get('WBQualityConstraintsCheckOnEntityDurationWarningSeconds'),
 		];
 	}
 
@@ -70,23 +70,23 @@ 
 	 * @param float $durationSeconds
 	 * @return array [ $limitSeconds, $logLevel ]
 	 */
-	private function findLimit( $limits, $durationSeconds ) {
+	private function findLimit($limits, $durationSeconds) {
 		$limitSeconds = null;
 		$logLevel = null;
 
-		foreach ( $limits as $level => $limit ) {
+		foreach ($limits as $level => $limit) {
 			if (
 				// duration exceeds this limit
 				$limit !== null && $durationSeconds > $limit &&
 				// this limit is longer than previous longest limit
-				( $limitSeconds === null || $limit > $limitSeconds )
+				($limitSeconds === null || $limit > $limitSeconds)
 			) {
 				$limitSeconds = $limit;
 				$logLevel = $level;
 			}
 		}
 
-		return [ $limitSeconds, $logLevel ];
+		return [$limitSeconds, $logLevel];
 	}
 
 	/**
@@ -111,27 +111,27 @@ 
 		$durationSeconds,
 		$method
 	) {
-		$constraintCheckerClassShortName = substr( strrchr( $constraintCheckerClass, '\\' ), 1 );
+		$constraintCheckerClassShortName = substr(strrchr($constraintCheckerClass, '\\'), 1);
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
-		$this->statsFactory->getTiming( 'check_constraint_duration_seconds' )
-			->observe( $durationSeconds * 1000 );
+		$this->statsFactory->getTiming('check_constraint_duration_seconds')
+			->observe($durationSeconds * 1000);
 
 		// find the longest limit (and associated log level) that the duration exceeds
-		[ $limitSeconds, $logLevel ] = $this->findLimit(
+		[$limitSeconds, $logLevel] = $this->findLimit(
 			$this->constraintCheckDurationLimits,
 			$durationSeconds
 		);
-		if ( $limitSeconds === null ) {
+		if ($limitSeconds === null) {
 			return;
 		}
-		if ( $context->getType() !== Context::TYPE_STATEMENT ) {
+		if ($context->getType() !== Context::TYPE_STATEMENT) {
 			// TODO log less details but still log something
 			return;
 		}
 
 		$resultMessage = $result->getMessage();
-		if ( $resultMessage !== null ) {
+		if ($resultMessage !== null) {
 			$resultMessageKey = $resultMessage->getMessageKey();
 		} else {
 			$resultMessageKey = null;
@@ -139,8 +139,8 @@ 
 
 		$this->logger->log(
 			$logLevel,
-			'Constraint check with {constraintCheckerClassShortName} ' .
-			'took longer than {limitSeconds} second(s) ' .
+			'Constraint check with {constraintCheckerClassShortName} '.
+			'took longer than {limitSeconds} second(s) '.
 			'(duration: {durationSeconds} seconds).',
 			[
 				'method' => $method,
@@ -150,7 +150,7 @@ 
 				'constraintId' => $constraint->getConstraintId(),
 				'constraintPropertyId' => $constraint->getPropertyId()->getSerialization(),
 				'constraintTypeItemId' => $constraintTypeItemId,
-				'constraintParameters' => json_encode( $constraint->getConstraintParameters() ),
+				'constraintParameters' => json_encode($constraint->getConstraintParameters()),
 				'constraintCheckerClass' => $constraintCheckerClass,
 				'constraintCheckerClassShortName' => $constraintCheckerClassShortName,
 				'entityId' => $context->getEntity()->getId()->getSerialization(),
@@ -180,22 +180,22 @@ 
 		$durationSeconds,
 		$method
 	) {
-		$this->statsFactory->getTiming( 'check_entity_constraint_duration_seconds' )
-			->observe( $durationSeconds * 1000 );
+		$this->statsFactory->getTiming('check_entity_constraint_duration_seconds')
+			->observe($durationSeconds * 1000);
 
 		// find the longest limit (and associated log level) that the duration exceeds
-		[ $limitSeconds, $logLevel ] = $this->findLimit(
+		[$limitSeconds, $logLevel] = $this->findLimit(
 			$this->constraintCheckOnEntityDurationLimits,
 			$durationSeconds
 		);
-		if ( $limitSeconds === null ) {
+		if ($limitSeconds === null) {
 			return;
 		}
 
 		$this->logger->log(
 			$logLevel,
-			'Full constraint check on {entityId} ' .
-			'took longer than {limitSeconds} second(s) ' .
+			'Full constraint check on {entityId} '.
+			'took longer than {limitSeconds} second(s) '.
 			'(duration: {durationSeconds} seconds).',
 			[
 				'method' => $method,
@@ -211,8 +211,8 @@ 
 	/**
 	 * Log a cache hit for a complete constraint check result for the given entity ID.
 	 */
-	public function logCheckConstraintsCacheHit( EntityId $entityId ) {
-		$this->statsFactory->getCounter( 'cache_entity_hit_total' )
+	public function logCheckConstraintsCacheHit(EntityId $entityId) {
+		$this->statsFactory->getCounter('cache_entity_hit_total')
 			->increment();
 	}
 
@@ -221,9 +221,9 @@ 
 	 *
 	 * @param EntityId[] $entityIds
 	 */
-	public function logCheckConstraintsCacheMisses( array $entityIds ) {
-		$this->statsFactory->getCounter( 'cache_entity_miss_total' )
-			->incrementBy( count( $entityIds ) );
+	public function logCheckConstraintsCacheMisses(array $entityIds) {
+		$this->statsFactory->getCounter('cache_entity_miss_total')
+			->incrementBy(count($entityIds));
 	}
 
 	/**
@@ -249,17 +249,17 @@ 
 	 * @param EntityId[] $entityIds
 	 * @param int $maxRevisionIds
 	 */
-	public function logHugeDependencyMetadata( array $entityIds, $maxRevisionIds ) {
+	public function logHugeDependencyMetadata(array $entityIds, $maxRevisionIds) {
 		$this->logger->log(
 			'warning',
-			'Dependency metadata for constraint check result has huge set of entity IDs ' .
-			'(count ' . count( $entityIds ) . ', limit ' . $maxRevisionIds . '); ' .
+			'Dependency metadata for constraint check result has huge set of entity IDs '.
+			'(count '.count($entityIds).', limit '.$maxRevisionIds.'); '.
 			'caching disabled for this check result.',
 			[
 				'loggingMethod' => __METHOD__,
 				'entityIds' => json_encode(
 					array_map(
-						static function ( EntityId $entityId ) {
+						static function(EntityId $entityId) {
 							return $entityId->getSerialization();
 						},
 						$entityIds
@@ -278,17 +278,17 @@ 
 			'Sparql API replied with status 429 and a retry-after header. Requesting to retry after {retryAfterTime}',
 			[
 				'retryAfterTime' => $retryAfterTime,
-				'responseHeaders' => json_encode( $request->getResponseHeaders() ),
+				'responseHeaders' => json_encode($request->getResponseHeaders()),
 				'responseContent' => $request->getContent(),
 			]
 		);
 	}
 
-	public function logSparqlHelperTooManyRequestsRetryAfterInvalid( MWHttpRequest $request ) {
+	public function logSparqlHelperTooManyRequestsRetryAfterInvalid(MWHttpRequest $request) {
 		$this->logger->warning(
 			'Sparql API replied with status 429 and no valid retry-after header.',
 			[
-				'responseHeaders' => json_encode( $request->getResponseHeaders() ),
+				'responseHeaders' => json_encode($request->getResponseHeaders()),
 				'responseContent' => $request->getContent(),
 			]
 		);

src/ConstraintCheck/Helper/SparqlHelper.php

Spacing +212 added lines, -216 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Helper;
 
@@ -166,143 +166,143 @@ 
 		$this->defaultUserAgent = $defaultUserAgent;
 		$this->requestFactory = $requestFactory;
 		$this->entityPrefixes = [];
-		foreach ( $rdfVocabulary->entityNamespaceNames as $namespaceName ) {
-			$this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI( $namespaceName );
+		foreach ($rdfVocabulary->entityNamespaceNames as $namespaceName) {
+			$this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI($namespaceName);
 		}
 
-		$this->primaryEndpoint = $config->get( 'WBQualityConstraintsSparqlEndpoint' );
-		$this->additionalEndpoints = $config->get( 'WBQualityConstraintsAdditionalSparqlEndpoints' ) ?: [];
-		$this->maxQueryTimeMillis = $config->get( 'WBQualityConstraintsSparqlMaxMillis' );
-		$this->subclassOfId = new NumericPropertyId( $config->get( 'WBQualityConstraintsSubclassOfId' ) );
-		$this->cacheMapSize = $config->get( 'WBQualityConstraintsFormatCacheMapSize' );
+		$this->primaryEndpoint = $config->get('WBQualityConstraintsSparqlEndpoint');
+		$this->additionalEndpoints = $config->get('WBQualityConstraintsAdditionalSparqlEndpoints') ?: [];
+		$this->maxQueryTimeMillis = $config->get('WBQualityConstraintsSparqlMaxMillis');
+		$this->subclassOfId = new NumericPropertyId($config->get('WBQualityConstraintsSubclassOfId'));
+		$this->cacheMapSize = $config->get('WBQualityConstraintsFormatCacheMapSize');
 		$this->timeoutExceptionClasses = $config->get(
 			'WBQualityConstraintsSparqlTimeoutExceptionClasses'
 		);
 		$this->sparqlHasWikibaseSupport = $config->get(
 			'WBQualityConstraintsSparqlHasWikibaseSupport'
 		);
-		$this->sparqlThrottlingFallbackDuration = (int)$config->get(
+		$this->sparqlThrottlingFallbackDuration = (int) $config->get(
 			'WBQualityConstraintsSparqlThrottlingFallbackDuration'
 		);
 
-		$this->prefixes = $this->getQueryPrefixes( $rdfVocabulary );
+		$this->prefixes = $this->getQueryPrefixes($rdfVocabulary);
 
 		$this->rdfVocabularyWithoutNormalization = clone $rdfVocabulary;
 		// @phan-suppress-next-line PhanTypeMismatchProperty
 		$this->rdfVocabularyWithoutNormalization->normalizedPropertyValueNamespace = array_fill_keys(
-			array_keys( $rdfVocabulary->normalizedPropertyValueNamespace ),
+			array_keys($rdfVocabulary->normalizedPropertyValueNamespace),
 			null
 		);
 	}
 
-	private function getQueryPrefixes( RdfVocabulary $rdfVocabulary ): string {
+	private function getQueryPrefixes(RdfVocabulary $rdfVocabulary): string {
 		// TODO: it would probably be smarter that RdfVocabulary exposed these prefixes somehow
 		$prefixes = '';
-		foreach ( $rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName ) {
+		foreach ($rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName) {
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 
-		foreach ( $rdfVocabulary->statementNamespaceNames as $sourceName => $sourceNamespaces ) {
+		foreach ($rdfVocabulary->statementNamespaceNames as $sourceName => $sourceNamespaces) {
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NS_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 
-		foreach ( $rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces ) {
+		foreach ($rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces) {
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_DIRECT_CLAIM];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM_STATEMENT];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 		$namespaceName = RdfVocabulary::NS_ONTOLOGY;
 		$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		return $prefixes;
 	}
 
 	/** Return a SPARQL term like `wd:Q123` for the given ID. */
-	private function wd( EntityId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function wd(EntityId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->entityNamespaceNames[$repository];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `wdt:P123` for the given ID. */
-	private function wdt( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function wdt(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_DIRECT_CLAIM];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `p:P123` for the given ID. */
-	private function p( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function p(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_CLAIM];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `pq:P123` for the given ID. */
-	private function pq( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function pq(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_QUALIFIER];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `wdno:P123` for the given ID. */
-	private function wdno( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function wdno(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_NOVALUE];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `prov:NAME` for the given name. */
-	private function prov( string $name ): string {
+	private function prov(string $name): string {
 		$prefix = RdfVocabulary::NS_PROV;
 		return "$prefix:$name";
 	}
 
 	/** Return a SPARQL term like `wikibase:NAME` for the given name. */
-	private function wikibase( string $name ): string {
+	private function wikibase(string $name): string {
 		$prefix = RdfVocabulary::NS_ONTOLOGY;
 		return "$prefix:$name";
 	}
 
 	/** Return a SPARQL snippet like `MINUS { ?var wikibase:rank wikibase:DeprecatedRank. }`. */
-	private function minusDeprecatedRank( string $varName ): string {
+	private function minusDeprecatedRank(string $varName): string {
 		$deprecatedRank = RdfVocabulary::RANK_MAP[Statement::RANK_DEPRECATED];
-		return "MINUS { $varName {$this->wikibase( 'rank' )} {$this->wikibase( $deprecatedRank )}. }";
+		return "MINUS { $varName {$this->wikibase('rank')} {$this->wikibase($deprecatedRank)}. }";
 	}
 
 	/**
@@ -312,43 +312,42 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	public function hasType( EntityId $id, array $classes ): CachedBool {
+	public function hasType(EntityId $id, array $classes): CachedBool {
 		// TODO hint:gearing is a workaround for T168973 and can hopefully be removed eventually
 		$gearingHint = $this->sparqlHasWikibaseSupport ?
-			' hint:Prior hint:gearing "forward".' :
-			'';
+			' hint:Prior hint:gearing "forward".' : '';
 
 		$metadatas = [];
 
-		foreach ( array_chunk( $classes, 20 ) as $classesChunk ) {
-			$classesValues = implode( ' ', array_map(
-				function ( string $class ) {
-					return $this->wd( new ItemId( $class ) );
+		foreach (array_chunk($classes, 20) as $classesChunk) {
+			$classesValues = implode(' ', array_map(
+				function(string $class) {
+					return $this->wd(new ItemId($class));
 				},
 				$classesChunk
-			) );
+			));
 
 			$query = <<<EOF
 ASK {
-  BIND({$this->wd( $id )} AS ?item)
+  BIND({$this->wd($id)} AS ?item)
   VALUES ?class { $classesValues }
-  ?item {$this->wdt( $this->subclassOfId )}* ?class.$gearingHint
+  ?item {$this->wdt($this->subclassOfId)}* ?class.$gearingHint
 }
 EOF;
 
-			$result = $this->runQuery( $query, $this->primaryEndpoint );
+			$result = $this->runQuery($query, $this->primaryEndpoint);
 			$metadatas[] = $result->getMetadata();
-			if ( $result->getArray()['boolean'] ) {
+			if ($result->getArray()['boolean']) {
 				return new CachedBool(
 					true,
-					Metadata::merge( $metadatas )
+					Metadata::merge($metadatas)
 				);
 			}
 		}
 
 		return new CachedBool(
 			false,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -366,12 +365,12 @@ 
 		array $separators
 	): CachedEntityIds {
 		$mainSnak = $statement->getMainSnak();
-		if ( !( $mainSnak instanceof PropertyValueSnak ) ) {
-			return new CachedEntityIds( [], Metadata::blank() );
+		if (!($mainSnak instanceof PropertyValueSnak)) {
+			return new CachedEntityIds([], Metadata::blank());
 		}
 
 		$propertyId = $statement->getPropertyId();
-		$pPredicateAndObject = "{$this->p( $propertyId )} ?otherStatement."; // p:P123 ?otherStatement.
+		$pPredicateAndObject = "{$this->p($propertyId)} ?otherStatement."; // p:P123 ?otherStatement.
 		$otherStatementPredicateAndObject = $this->getSnakPredicateAndObject(
 			$entityId,
 			$mainSnak,
@@ -380,57 +379,57 @@ 
 
 		$isSeparator = [];
 		$unusedSeparators = [];
-		foreach ( $separators as $separator ) {
+		foreach ($separators as $separator) {
 			$isSeparator[$separator->getSerialization()] = true;
 			$unusedSeparators[$separator->getSerialization()] = $separator;
 		}
 		$separatorFilters = '';
-		foreach ( $statement->getQualifiers() as $qualifier ) {
+		foreach ($statement->getQualifiers() as $qualifier) {
 			$qualPropertyId = $qualifier->getPropertyId();
-			if ( !( $isSeparator[$qualPropertyId->getSerialization()] ?? false ) ) {
+			if (!($isSeparator[$qualPropertyId->getSerialization()] ?? false)) {
 				continue;
 			}
-			unset( $unusedSeparators[$qualPropertyId->getSerialization()] );
+			unset($unusedSeparators[$qualPropertyId->getSerialization()]);
 			// only look for other statements with the same qualifier
-			if ( $qualifier instanceof PropertyValueSnak ) {
+			if ($qualifier instanceof PropertyValueSnak) {
 				$sepPredicateAndObject = $this->getSnakPredicateAndObject(
 					$entityId,
 					$qualifier,
 					RdfVocabulary::NSP_QUALIFIER
 				);
 				$separatorFilters .= "  ?otherStatement $sepPredicateAndObject\n";
-			} elseif ( $qualifier instanceof PropertyNoValueSnak ) {
-				$sepPredicateAndObject = "a {$this->wdno( $qualPropertyId )}."; // a wdno:P123.
+			} elseif ($qualifier instanceof PropertyNoValueSnak) {
+				$sepPredicateAndObject = "a {$this->wdno($qualPropertyId)}."; // a wdno:P123.
 				$separatorFilters .= "  ?otherStatement $sepPredicateAndObject\n";
 			} else {
 				// "some value" / "unknown value" is always different from everything else,
 				// therefore the whole statement has no duplicates and we can return immediately
-				return new CachedEntityIds( [], Metadata::blank() );
+				return new CachedEntityIds([], Metadata::blank());
 			}
 		}
-		foreach ( $unusedSeparators as $unusedSeparator ) {
+		foreach ($unusedSeparators as $unusedSeparator) {
 			// exclude other statements which have a separator that this one lacks
-			$separatorFilters .= "  MINUS { ?otherStatement {$this->pq( $unusedSeparator )} []. }\n";
-			$separatorFilters .= "  MINUS { ?otherStatement a {$this->wdno( $unusedSeparator )}. }\n";
+			$separatorFilters .= "  MINUS { ?otherStatement {$this->pq($unusedSeparator)} []. }\n";
+			$separatorFilters .= "  MINUS { ?otherStatement a {$this->wdno($unusedSeparator)}. }\n";
 		}
 
 		$query = <<<SPARQL
 SELECT DISTINCT ?otherEntity WHERE {
   ?otherEntity $pPredicateAndObject
   ?otherStatement $otherStatementPredicateAndObject
-  {$this->minusDeprecatedRank( '?otherStatement' )}
-  FILTER(?otherEntity != {$this->wd( $entityId )})
+  {$this->minusDeprecatedRank('?otherStatement')}
+  FILTER(?otherEntity != {$this->wd($entityId)})
 $separatorFilters
 }
 LIMIT 10
 SPARQL;
 
-		$results = [ $this->runQuery( $query, $this->primaryEndpoint ) ];
-		foreach ( $this->additionalEndpoints as $endpoint ) {
-			$results[] = $this->runQuery( $query, $endpoint );
+		$results = [$this->runQuery($query, $this->primaryEndpoint)];
+		foreach ($this->additionalEndpoints as $endpoint) {
+			$results[] = $this->runQuery($query, $endpoint);
 		}
 
-		return $this->getOtherEntities( $results );
+		return $this->getOtherEntities($results);
 	}
 
 	/**
@@ -449,40 +448,38 @@ 
 		bool $ignoreDeprecatedStatements
 	): CachedEntityIds {
 		$propertyId = $snak->getPropertyId();
-		$pPredicateAndObject = "{$this->p( $propertyId )} ?otherStatement."; // p:P123 ?otherStatement.
+		$pPredicateAndObject = "{$this->p($propertyId)} ?otherStatement."; // p:P123 ?otherStatement.
 
 		$otherSubject = $type === Context::TYPE_QUALIFIER ?
-			'?otherStatement' :
-			"?otherStatement {$this->prov( 'wasDerivedFrom' )} ?reference.\n  ?reference";
+			'?otherStatement' : "?otherStatement {$this->prov('wasDerivedFrom')} ?reference.\n  ?reference";
 		$otherPredicateAndObject = $this->getSnakPredicateAndObject(
 			$entityId,
 			$snak,
 			$type === Context::TYPE_QUALIFIER ?
-				RdfVocabulary::NSP_QUALIFIER :
-				RdfVocabulary::NSP_REFERENCE
+				RdfVocabulary::NSP_QUALIFIER : RdfVocabulary::NSP_REFERENCE
 		);
 
 		$deprecatedFilter = '';
-		if ( $ignoreDeprecatedStatements ) {
-			$deprecatedFilter = '  ' . $this->minusDeprecatedRank( '?otherStatement' );
+		if ($ignoreDeprecatedStatements) {
+			$deprecatedFilter = '  '.$this->minusDeprecatedRank('?otherStatement');
 		}
 
 		$query = <<<SPARQL
 SELECT DISTINCT ?otherEntity WHERE {
   ?otherEntity $pPredicateAndObject
   $otherSubject $otherPredicateAndObject
-  FILTER(?otherEntity != {$this->wd( $entityId )})
+  FILTER(?otherEntity != {$this->wd($entityId)})
 $deprecatedFilter
 }
 LIMIT 10
 SPARQL;
 
-		$results = [ $this->runQuery( $query, $this->primaryEndpoint ) ];
-		foreach ( $this->additionalEndpoints as $endpoint ) {
-			$results[] = $this->runQuery( $query, $endpoint );
+		$results = [$this->runQuery($query, $this->primaryEndpoint)];
+		foreach ($this->additionalEndpoints as $endpoint) {
+			$results[] = $this->runQuery($query, $endpoint);
 		}
 
-		return $this->getOtherEntities( $results );
+		return $this->getOtherEntities($results);
 	}
 
 	/**
@@ -513,13 +510,13 @@ 
 		$writer->start();
 		$writer->drain();
 		$placeholder1 = 'wbqc';
-		$placeholder2 = 'x' . wfRandomString( 32 );
-		$writer->about( $placeholder1, $placeholder2 );
+		$placeholder2 = 'x'.wfRandomString(32);
+		$writer->about($placeholder1, $placeholder2);
 
 		$propertyId = $snak->getPropertyId();
 		$pid = $propertyId->getSerialization();
-		$propertyRepository = $this->rdfVocabulary->getEntityRepositoryName( $propertyId );
-		$entityRepository = $this->rdfVocabulary->getEntityRepositoryName( $entityId );
+		$propertyRepository = $this->rdfVocabulary->getEntityRepositoryName($propertyId);
+		$entityRepository = $this->rdfVocabulary->getEntityRepositoryName($entityId);
 		$propertyNamespace = $this->rdfVocabulary->propertyNamespaceNames[$propertyRepository][$namespace];
 		$value = $snak->getDataValue();
 		if (
@@ -550,21 +547,21 @@ 
 				$writer,
 				$propertyNamespace,
 				$pid,
-				$this->propertyDataTypeLookup->getDataTypeIdForProperty( $propertyId ),
+				$this->propertyDataTypeLookup->getDataTypeIdForProperty($propertyId),
 				$this->rdfVocabulary->statementNamespaceNames[$entityRepository][RdfVocabulary::NS_VALUE], // should be unused
 				$snak
 			);
 		}
 
 		$triple = $writer->drain(); // wbqc:xRANDOM ps:PID "value". or similar
-		return trim( str_replace( "$placeholder1:$placeholder2", '', $triple ) );
+		return trim(str_replace("$placeholder1:$placeholder2", '', $triple));
 	}
 
 	/**
 	 * Return SPARQL code for a string literal with $text as content.
 	 */
-	private function stringLiteral( string $text ): string {
-		return '"' . strtr( $text, [ '"' => '\\"', '\\' => '\\\\' ] ) . '"';
+	private function stringLiteral(string $text): string {
+		return '"'.strtr($text, ['"' => '\\"', '\\' => '\\\\']).'"';
 	}
 
 	/**
@@ -574,26 +571,26 @@ 
 	 *
 	 * @return CachedEntityIds
 	 */
-	private function getOtherEntities( array $results ): CachedEntityIds {
+	private function getOtherEntities(array $results): CachedEntityIds {
 		$allResultBindings = [];
 		$metadatas = [];
 
-		foreach ( $results as $result ) {
+		foreach ($results as $result) {
 			$metadatas[] = $result->getMetadata();
-			$allResultBindings = array_merge( $allResultBindings, $result->getArray()['results']['bindings'] );
+			$allResultBindings = array_merge($allResultBindings, $result->getArray()['results']['bindings']);
 		}
 
 		$entityIds = array_map(
-			function ( $resultBindings ) {
+			function($resultBindings) {
 				$entityIRI = $resultBindings['otherEntity']['value'];
-				foreach ( $this->entityPrefixes as $entityPrefix ) {
-					$entityPrefixLength = strlen( $entityPrefix );
-					if ( substr( $entityIRI, 0, $entityPrefixLength ) === $entityPrefix ) {
+				foreach ($this->entityPrefixes as $entityPrefix) {
+					$entityPrefixLength = strlen($entityPrefix);
+					if (substr($entityIRI, 0, $entityPrefixLength) === $entityPrefix) {
 						try {
 							return $this->entityIdParser->parse(
-								substr( $entityIRI, $entityPrefixLength )
+								substr($entityIRI, $entityPrefixLength)
 							);
-						} catch ( EntityIdParsingException ) {
+						} catch (EntityIdParsingException) {
 							// fall through
 						}
 					}
@@ -607,8 +604,8 @@ 
 		);
 
 		return new CachedEntityIds(
-			array_values( array_filter( array_unique( $entityIds ) ) ),
-			Metadata::merge( $metadatas )
+			array_values(array_filter(array_unique($entityIds))),
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -616,52 +613,52 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpression( string $text, string $regex ): bool {
+	public function matchesRegularExpression(string $text, string $regex): bool {
 		// caching wrapper around matchesRegularExpressionWithSparql
 
-		$textHash = hash( 'sha256', $text );
+		$textHash = hash('sha256', $text);
 		$cacheKey = $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'regex', // action
 			'WDQS-Java', // regex flavor
-			hash( 'sha256', $regex )
+			hash('sha256', $regex)
 		);
 
-		$metric = $this->statsFactory->getCounter( 'regex_cache_total' );
+		$metric = $this->statsFactory->getCounter('regex_cache_total');
 
 		$cacheMapArray = $this->cache->getWithSetCallback(
 			$cacheKey,
 			WANObjectCache::TTL_DAY,
-			function ( $cacheMapArray ) use ( $text, $regex, $textHash, $metric ) {
+			function($cacheMapArray) use ($text, $regex, $textHash, $metric) {
 				// Initialize the cache map if not set
-				if ( $cacheMapArray === false ) {
+				if ($cacheMapArray === false) {
 					$metric
-						->setLabel( 'operation', 'refresh' )
-						->setLabel( 'status', 'init' )
+						->setLabel('operation', 'refresh')
+						->setLabel('status', 'init')
 						->increment();
 
 					return [];
 				}
 
-				$cacheMap = MapCacheLRU::newFromArray( $cacheMapArray, $this->cacheMapSize );
-				if ( $cacheMap->has( $textHash ) ) {
+				$cacheMap = MapCacheLRU::newFromArray($cacheMapArray, $this->cacheMapSize);
+				if ($cacheMap->has($textHash)) {
 					$metric
-						->setLabel( 'operation', 'refresh' )
-						->setLabel( 'status', 'hit' )
+						->setLabel('operation', 'refresh')
+						->setLabel('status', 'hit')
 						->increment();
 
-					$cacheMap->get( $textHash ); // ping cache
+					$cacheMap->get($textHash); // ping cache
 				} else {
 					$metric
-						->setLabel( 'operation', 'refresh' )
-						->setLabel( 'status', 'miss' )
+						->setLabel('operation', 'refresh')
+						->setLabel('status', 'miss')
 						->increment();
 
 					try {
-						$matches = $this->matchesRegularExpressionWithSparql( $text, $regex );
-					} catch ( ConstraintParameterException $e ) {
-						$matches = $this->serializeConstraintParameterException( $e );
-					} catch ( SparqlHelperException ) {
+						$matches = $this->matchesRegularExpressionWithSparql($text, $regex);
+					} catch (ConstraintParameterException $e) {
+						$matches = $this->serializeConstraintParameterException($e);
+					} catch (SparqlHelperException) {
 						// don’t cache this
 						return $cacheMap->toArray();
 					}
@@ -685,48 +682,48 @@ 
 			]
 		);
 
-		if ( isset( $cacheMapArray[$textHash] ) ) {
+		if (isset($cacheMapArray[$textHash])) {
 			$metric
-				->setLabel( 'operation', 'none' )
-				->setLabel( 'status', 'hit' )
+				->setLabel('operation', 'none')
+				->setLabel('status', 'hit')
 				->increment();
 
 			$matches = $cacheMapArray[$textHash];
-			if ( is_bool( $matches ) ) {
+			if (is_bool($matches)) {
 				return $matches;
-			} elseif ( is_array( $matches ) &&
-				$matches['type'] == ConstraintParameterException::class ) {
-				throw $this->deserializeConstraintParameterException( $matches );
+			} elseif (is_array($matches) &&
+				$matches['type'] == ConstraintParameterException::class) {
+				throw $this->deserializeConstraintParameterException($matches);
 			} else {
 				throw new UnexpectedValueException(
-					'Value of unknown type in object cache (' .
-					'cache key: ' . $cacheKey . ', ' .
-					'cache map key: ' . $textHash . ', ' .
-					'value type: ' . get_debug_type( $matches ) . ')'
+					'Value of unknown type in object cache ('.
+					'cache key: '.$cacheKey.', '.
+					'cache map key: '.$textHash.', '.
+					'value type: '.get_debug_type($matches).')'
 				);
 			}
 		} else {
 			$metric
-				->setLabel( 'operation', 'none' )
-				->setLabel( 'status', 'miss' )
+				->setLabel('operation', 'none')
+				->setLabel('status', 'miss')
 				->increment();
 
-			return $this->matchesRegularExpressionWithSparql( $text, $regex );
+			return $this->matchesRegularExpressionWithSparql($text, $regex);
 		}
 	}
 
-	private function serializeConstraintParameterException( ConstraintParameterException $cpe ): array {
+	private function serializeConstraintParameterException(ConstraintParameterException $cpe): array {
 		return [
 			'type' => ConstraintParameterException::class,
-			'violationMessage' => $this->violationMessageSerializer->serialize( $cpe->getViolationMessage() ),
+			'violationMessage' => $this->violationMessageSerializer->serialize($cpe->getViolationMessage()),
 		];
 	}
 
-	private function deserializeConstraintParameterException( array $serialization ): ConstraintParameterException {
+	private function deserializeConstraintParameterException(array $serialization): ConstraintParameterException {
 		$message = $this->violationMessageDeserializer->deserialize(
 			$serialization['violationMessage']
 		);
-		return new ConstraintParameterException( $message );
+		return new ConstraintParameterException($message);
 	}
 
 	/**
@@ -736,25 +733,25 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpressionWithSparql( string $text, string $regex ): bool {
-		$textStringLiteral = $this->stringLiteral( $text );
-		$regexStringLiteral = $this->stringLiteral( '^(?:' . $regex . ')$' );
+	public function matchesRegularExpressionWithSparql(string $text, string $regex): bool {
+		$textStringLiteral = $this->stringLiteral($text);
+		$regexStringLiteral = $this->stringLiteral('^(?:'.$regex.')$');
 
 		$query = <<<EOF
 SELECT (REGEX($textStringLiteral, $regexStringLiteral) AS ?matches) {}
 EOF;
 
-		$result = $this->runQuery( $query, $this->primaryEndpoint, false );
+		$result = $this->runQuery($query, $this->primaryEndpoint, false);
 
 		$vars = $result->getArray()['results']['bindings'][0];
-		if ( array_key_exists( 'matches', $vars ) ) {
+		if (array_key_exists('matches', $vars)) {
 			// true or false ⇒ regex okay, text matches or not
 			return $vars['matches']['value'] === 'true';
 		} else {
 			// empty result: regex broken
 			throw new ConstraintParameterException(
-				( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) )
-					->withInlineCode( $regex, Role::CONSTRAINT_PARAMETER_VALUE )
+				(new ViolationMessage('wbqc-violation-message-parameter-regex'))
+					->withInlineCode($regex, Role::CONSTRAINT_PARAMETER_VALUE)
 			);
 		}
 	}
@@ -762,14 +759,14 @@ 
 	/**
 	 * Check whether the text content of an error response indicates a query timeout.
 	 */
-	public function isTimeout( string $responseContent ): bool {
-		$timeoutRegex = implode( '|', array_map(
-			static function ( $fqn ) {
-				return preg_quote( $fqn, '/' );
+	public function isTimeout(string $responseContent): bool {
+		$timeoutRegex = implode('|', array_map(
+			static function($fqn) {
+				return preg_quote($fqn, '/');
 			},
 			$this->timeoutExceptionClasses
-		) );
-		return (bool)preg_match( '/' . $timeoutRegex . '/', $responseContent );
+		));
+		return (bool) preg_match('/'.$timeoutRegex.'/', $responseContent);
 	}
 
 	/**
@@ -781,17 +778,17 @@ 
 	 * @return int|bool the max-age (in seconds)
 	 * or a plain boolean if no max-age can be determined
 	 */
-	public function getCacheMaxAge( array $responseHeaders ) {
+	public function getCacheMaxAge(array $responseHeaders) {
 		if (
-			array_key_exists( 'x-cache-status', $responseHeaders ) &&
-			preg_match( '/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0] )
+			array_key_exists('x-cache-status', $responseHeaders) &&
+			preg_match('/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0])
 		) {
 			$maxage = [];
 			if (
-				array_key_exists( 'cache-control', $responseHeaders ) &&
-				preg_match( '/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage )
+				array_key_exists('cache-control', $responseHeaders) &&
+				preg_match('/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage)
 			) {
-				return intval( $maxage[1] );
+				return intval($maxage[1]);
 			} else {
 				return true;
 			}
@@ -812,34 +809,34 @@ 
 	 * or SparlHelper::EMPTY_RETRY_AFTER if there is an empty Retry-After
 	 * or SparlHelper::INVALID_RETRY_AFTER if there is something wrong with the format
 	 */
-	public function getThrottling( MWHttpRequest $request ) {
-		$retryAfterValue = $request->getResponseHeader( 'Retry-After' );
-		if ( $retryAfterValue === null ) {
+	public function getThrottling(MWHttpRequest $request) {
+		$retryAfterValue = $request->getResponseHeader('Retry-After');
+		if ($retryAfterValue === null) {
 			return self::NO_RETRY_AFTER;
 		}
 
-		$trimmedRetryAfterValue = trim( $retryAfterValue );
-		if ( $trimmedRetryAfterValue === '' ) {
+		$trimmedRetryAfterValue = trim($retryAfterValue);
+		if ($trimmedRetryAfterValue === '') {
 			return self::EMPTY_RETRY_AFTER;
 		}
 
-		if ( is_numeric( $trimmedRetryAfterValue ) ) {
-			$delaySeconds = (int)$trimmedRetryAfterValue;
-			if ( $delaySeconds >= 0 ) {
-				return $this->getTimestampInFuture( new DateInterval( 'PT' . $delaySeconds . 'S' ) );
+		if (is_numeric($trimmedRetryAfterValue)) {
+			$delaySeconds = (int) $trimmedRetryAfterValue;
+			if ($delaySeconds >= 0) {
+				return $this->getTimestampInFuture(new DateInterval('PT'.$delaySeconds.'S'));
 			}
 		} else {
-			$return = strtotime( $trimmedRetryAfterValue );
-			if ( $return !== false ) {
-				return new ConvertibleTimestamp( $return );
+			$return = strtotime($trimmedRetryAfterValue);
+			if ($return !== false) {
+				return new ConvertibleTimestamp($return);
 			}
 		}
 		return self::INVALID_RETRY_AFTER;
 	}
 
-	private function getTimestampInFuture( DateInterval $delta ): ConvertibleTimestamp {
+	private function getTimestampInFuture(DateInterval $delta): ConvertibleTimestamp {
 		$now = new ConvertibleTimestamp();
-		return new ConvertibleTimestamp( $now->timestamp->add( $delta ) );
+		return new ConvertibleTimestamp($now->timestamp->add($delta));
 	}
 
 	/**
@@ -854,92 +851,91 @@ 
 	 *
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	protected function runQuery( string $query, string $endpoint, bool $needsPrefixes = true ): CachedQueryResults {
-		if ( $this->throttlingLock->isLocked( self::EXPIRY_LOCK_ID ) ) {
+	protected function runQuery(string $query, string $endpoint, bool $needsPrefixes = true): CachedQueryResults {
+		if ($this->throttlingLock->isLocked(self::EXPIRY_LOCK_ID)) {
 			$this->statsFactory
-				->getCounter( 'sparql_throttling_total' )
+				->getCounter('sparql_throttling_total')
 				->increment();
 
 			throw new TooManySparqlRequestsException();
 		}
 
-		if ( $this->sparqlHasWikibaseSupport ) {
+		if ($this->sparqlHasWikibaseSupport) {
 			$needsPrefixes = false;
 		}
 
-		if ( $needsPrefixes ) {
-			$query = $this->prefixes . $query;
+		if ($needsPrefixes) {
+			$query = $this->prefixes.$query;
 		}
-		$query = "#wbqc\n" . $query;
+		$query = "#wbqc\n".$query;
 
-		$url = $endpoint . '?' . http_build_query(
+		$url = $endpoint.'?'.http_build_query(
 			[
 				'query' => $query,
 				'format' => 'json',
 				'maxQueryTimeMillis' => $this->maxQueryTimeMillis,
 			],
-			'', ini_get( 'arg_separator.output' ),
+			'', ini_get('arg_separator.output'),
 			// encode spaces with %20, not +
 			PHP_QUERY_RFC3986
 		);
 
 		$options = [
 			'method' => 'GET',
-			'timeout' => (int)round( ( $this->maxQueryTimeMillis + 1000 ) / 1000 ),
+			'timeout' => (int) round(($this->maxQueryTimeMillis + 1000) / 1000),
 			'connectTimeout' => 'default',
 			'userAgent' => $this->defaultUserAgent,
 		];
-		$request = $this->requestFactory->create( $url, $options, __METHOD__ );
+		$request = $this->requestFactory->create($url, $options, __METHOD__);
 
 		$timing = $this->statsFactory
-			->getTiming( 'sparql_runQuery_duration_seconds' );
+			->getTiming('sparql_runQuery_duration_seconds');
 
 		$timing->start();
 		$requestStatus = $request->execute();
 		$timing->stop();
 
-		$this->guardAgainstTooManyRequestsError( $request );
+		$this->guardAgainstTooManyRequestsError($request);
 
-		$maxAge = $this->getCacheMaxAge( $request->getResponseHeaders() );
-		if ( $maxAge ) {
-			$this->statsFactory->getCounter( 'sparql_cached_total' )
+		$maxAge = $this->getCacheMaxAge($request->getResponseHeaders());
+		if ($maxAge) {
+			$this->statsFactory->getCounter('sparql_cached_total')
 				->increment();
 		}
 
-		$metric = $this->statsFactory->getCounter( 'sparql_error_total' );
-		if ( $requestStatus->isOK() ) {
+		$metric = $this->statsFactory->getCounter('sparql_error_total');
+		if ($requestStatus->isOK()) {
 			$json = $request->getContent();
-			$jsonStatus = FormatJson::parse( $json, FormatJson::FORCE_ASSOC );
+			$jsonStatus = FormatJson::parse($json, FormatJson::FORCE_ASSOC);
 			'@phan-var \MediaWiki\Status\Status<array> $jsonStatus';
-			if ( $jsonStatus->isOK() ) {
+			if ($jsonStatus->isOK()) {
 				return new CachedQueryResults(
 					$jsonStatus->getValue(),
 					Metadata::ofCachingMetadata(
 						$maxAge ?
-							CachingMetadata::ofMaximumAgeInSeconds( $maxAge ) :
-							CachingMetadata::fresh()
+							CachingMetadata::ofMaximumAgeInSeconds($maxAge) : CachingMetadata::fresh()
 					)
 				);
 			} else {
 				$jsonErrorCode = $jsonStatus->getErrors()[0]['message'];
 				$metric
-					->setLabel( 'type', 'json' )
-					->setLabel( 'code', "$jsonErrorCode" )
+					->setLabel('type', 'json')
+					->setLabel('code', "$jsonErrorCode")
 					->increment();
 				// fall through to general error handling
 			}
 		} else {
 			$metric
-				->setLabel( 'type', 'http' )
-				->setLabel( 'code', "{$request->getStatus()}" )
+				->setLabel('type', 'http')
+				->setLabel('code', "{$request->getStatus()}")
 				->increment();
 			// fall through to general error handling
 		}
 
-		if ( $this->isTimeout( $request->getContent() ) ) {
+		if ($this->isTimeout($request->getContent())) {
 			$metric
-				->setLabel( 'type', 'timeout' )
-				->setLabel( 'code', 'none' )
+				->setLabel('type', 'timeout')
+				->setLabel('code', 'none')
 				->increment();
 		}
 
@@ -952,31 +948,31 @@ 
 	 * @param MWHttpRequest $request
 	 * @throws TooManySparqlRequestsException
 	 */
-	private function guardAgainstTooManyRequestsError( MWHttpRequest $request ): void {
-		if ( $request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS ) {
+	private function guardAgainstTooManyRequestsError(MWHttpRequest $request): void {
+		if ($request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS) {
 			return;
 		}
 
 		$fallbackBlockDuration = $this->sparqlThrottlingFallbackDuration;
 
-		if ( $fallbackBlockDuration < 0 ) {
-			throw new InvalidArgumentException( 'Fallback duration must be positive int but is: ' .
-				$fallbackBlockDuration );
+		if ($fallbackBlockDuration < 0) {
+			throw new InvalidArgumentException('Fallback duration must be positive int but is: '.
+				$fallbackBlockDuration);
 		}
 
-		$this->statsFactory->getCounter( 'sparql_throttling_total' )
+		$this->statsFactory->getCounter('sparql_throttling_total')
 			->increment();
 
-		$throttlingUntil = $this->getThrottling( $request );
-		if ( !( $throttlingUntil instanceof ConvertibleTimestamp ) ) {
-			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid( $request );
+		$throttlingUntil = $this->getThrottling($request);
+		if (!($throttlingUntil instanceof ConvertibleTimestamp)) {
+			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid($request);
 			$this->throttlingLock->lock(
 				self::EXPIRY_LOCK_ID,
-				$this->getTimestampInFuture( new DateInterval( 'PT' . $fallbackBlockDuration . 'S' ) )
+				$this->getTimestampInFuture(new DateInterval('PT'.$fallbackBlockDuration.'S'))
 			);
 		} else {
-			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent( $throttlingUntil, $request );
-			$this->throttlingLock->lock( self::EXPIRY_LOCK_ID, $throttlingUntil );
+			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent($throttlingUntil, $request);
+			$this->throttlingLock->lock(self::EXPIRY_LOCK_ID, $throttlingUntil);
 		}
 		throw new TooManySparqlRequestsException();
 	}

src/Api/CheckConstraints.php

Spacing +31 added lines, -31 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -84,11 +84,11 @@ 
 		CheckResultsRendererFactory $checkResultsRendererFactory,
 		StatsFactory $statsFactory
 	) {
-		parent::__construct( $main, $name );
+		parent::__construct($main, $name);
 		$this->entityIdParser = $entityIdParser;
 		$this->statementGuidValidator = $statementGuidValidator;
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->resultsSource = $resultsSource;
 		$this->checkResultsRendererFactory = $checkResultsRendererFactory;
 		$this->statsFactory = $statsFactory;
@@ -98,19 +98,19 @@ 
 	 * Evaluates the parameters, runs the requested constraint check, and sets up the result
 	 */
 	public function execute() {
-		$this->statsFactory->getCounter( 'check_constraints_execute_total' )
+		$this->statsFactory->getCounter('check_constraints_execute_total')
 			->increment();
 
 		$params = $this->extractRequestParams();
 
-		$this->validateParameters( $params );
-		$entityIds = $this->parseEntityIds( $params );
-		$claimIds = $this->parseClaimIds( $params );
+		$this->validateParameters($params);
+		$entityIds = $this->parseEntityIds($params);
+		$claimIds = $this->parseClaimIds($params);
 		$constraintIDs = $params[self::PARAM_CONSTRAINT_ID];
 		$statuses = $params[self::PARAM_STATUS];
 
 		$checkResultsRenderer = $this->checkResultsRendererFactory
-			->getCheckResultsRenderer( $this->getLanguage(), $this );
+			->getCheckResultsRenderer($this->getLanguage(), $this);
 
 		$this->getResult()->addValue(
 			null,
@@ -124,7 +124,7 @@ 
 				)
 			)->getArray()
 		);
-		$this->resultBuilder->markSuccess( 1 );
+		$this->resultBuilder->markSuccess(1);
 	}
 
 	/**
@@ -132,24 +132,24 @@ 
 	 *
 	 * @return EntityId[]
 	 */
-	private function parseEntityIds( array $params ): array {
+	private function parseEntityIds(array $params): array {
 		$ids = $params[self::PARAM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		return array_map( function ( $id ) {
+		return array_map(function($id) {
 			try {
-				return $this->entityIdParser->parse( $id );
-			} catch ( EntityIdParsingException ) {
+				return $this->entityIdParser->parse($id);
+			} catch (EntityIdParsingException) {
 				$this->errorReporter->dieError(
-					"Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] );
+					"Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] );
 			}
-		}, $ids );
+		}, $ids);
 	}
 
 	/**
@@ -157,35 +157,35 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function parseClaimIds( array $params ): array {
+	private function parseClaimIds(array $params): array {
 		$ids = $params[self::PARAM_CLAIM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		foreach ( $ids as $id ) {
-			if ( !$this->statementGuidValidator->validate( $id ) ) {
+		foreach ($ids as $id) {
+			if (!$this->statementGuidValidator->validate($id)) {
 				$this->errorReporter->dieError(
-					"Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] );
+					"Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] );
 			}
 		}
 
 		return $ids;
 	}
 
-	private function validateParameters( array $params ): void {
-		if ( $params[self::PARAM_CONSTRAINT_ID] !== null
-			 && empty( $params[self::PARAM_CONSTRAINT_ID] )
+	private function validateParameters(array $params): void {
+		if ($params[self::PARAM_CONSTRAINT_ID] !== null
+			 && empty($params[self::PARAM_CONSTRAINT_ID])
 		) {
 			$paramConstraintId = self::PARAM_CONSTRAINT_ID;
 			$this->errorReporter->dieError(
 				"If $paramConstraintId is specified, it must be nonempty.", 'no-data' );
 		}
-		if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) {
+		if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) {
 			$paramId = self::PARAM_ID;
 			$paramClaimId = self::PARAM_CLAIM_ID;
 			$this->errorReporter->dieError(
@@ -226,7 +226,7 @@ 
 				],
 				ParamValidator::PARAM_ISMULTI => true,
 				ParamValidator::PARAM_ALL => true,
-				ParamValidator::PARAM_DEFAULT => implode( '|', CachingResultsSource::CACHED_STATUSES ),
+				ParamValidator::PARAM_DEFAULT => implode('|', CachingResultsSource::CACHED_STATUSES),
 				ApiBase::PARAM_HELP_MSG_PER_VALUE => [],
 			],
 		];