wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Api/CachingResultsSource.php

Spacing +77 added lines, -78 removed lines

@@ -144,14 +144,14 @@ 
 	) {
 		$results = [];
 		$metadatas = [];
-		if ( $this->canUseStoredResults( $claimIds, $constraintIds, $statuses ) ) {
+		if ($this->canUseStoredResults($claimIds, $constraintIds, $statuses)) {
 			$storedEntityIds = [];
-			foreach ( $entityIds as $entityId ) {
-				$storedResults = $this->getStoredResults( $entityId );
-				if ( $storedResults !== null ) {
-					$this->loggingHelper->logCheckConstraintsCacheHit( $entityId );
-					foreach ( $storedResults->getArray() as $checkResult ) {
-						if ( $this->statusSelected( $statuses, $checkResult ) ) {
+			foreach ($entityIds as $entityId) {
+				$storedResults = $this->getStoredResults($entityId);
+				if ($storedResults !== null) {
+					$this->loggingHelper->logCheckConstraintsCacheHit($entityId);
+					foreach ($storedResults->getArray() as $checkResult) {
+						if ($this->statusSelected($statuses, $checkResult)) {
 							$results[] = $checkResult;
 						}
 					}
@@ -159,19 +159,19 @@ 
 					$storedEntityIds[] = $entityId;
 				}
 			}
-			$entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) );
+			$entityIds = array_values(array_diff($entityIds, $storedEntityIds));
 		}
-		if ( $entityIds !== [] || $claimIds !== [] ) {
-			if ( $entityIds !== [] ) {
-				$this->loggingHelper->logCheckConstraintsCacheMisses( $entityIds );
+		if ($entityIds !== [] || $claimIds !== []) {
+			if ($entityIds !== []) {
+				$this->loggingHelper->logCheckConstraintsCacheMisses($entityIds);
 			}
-			$response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds, $statuses );
-			$results = array_merge( $results, $response->getArray() );
+			$response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds, $statuses);
+			$results = array_merge($results, $response->getArray());
 			$metadatas[] = $response->getMetadata();
 		}
 		return new CachedCheckResults(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -192,13 +192,13 @@ 
 		?array $constraintIds,
 		array $statuses
 	) {
-		if ( $claimIds !== [] ) {
+		if ($claimIds !== []) {
 			return false;
 		}
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( array_diff( $statuses, self::CACHED_STATUSES ) !== [] ) {
+		if (array_diff($statuses, self::CACHED_STATUSES) !== []) {
 			return false;
 		}
 		return true;
@@ -213,8 +213,8 @@ 
 	 * @param CheckResult $result
 	 * @return bool
 	 */
-	private function statusSelected( array $statuses, CheckResult $result ) {
-		return in_array( $result->getStatus(), $statuses, true ) ||
+	private function statusSelected(array $statuses, CheckResult $result) {
+		return in_array($result->getStatus(), $statuses, true) ||
 			$result instanceof NullResult;
 	}
 
@@ -231,11 +231,11 @@ 
 		?array $constraintIds,
 		array $statuses
 	) {
-		$results = $this->resultsSource->getResults( $entityIds, $claimIds, $constraintIds, $statuses );
+		$results = $this->resultsSource->getResults($entityIds, $claimIds, $constraintIds, $statuses);
 
-		if ( $this->canStoreResults( $constraintIds, $statuses ) ) {
-			foreach ( $entityIds as $entityId ) {
-				$this->storeResults( $entityId, $results );
+		if ($this->canStoreResults($constraintIds, $statuses)) {
+			foreach ($entityIds as $entityId) {
+				$this->storeResults($entityId, $results);
 			}
 		}
 
@@ -262,10 +262,10 @@ 
 		?array $constraintIds,
 		array $statuses
 	) {
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( array_diff( self::CACHED_STATUSES, $statuses ) !== [] ) {
+		if (array_diff(self::CACHED_STATUSES, $statuses) !== []) {
 			return false;
 		}
 		return true;
@@ -279,21 +279,21 @@ 
 	 * May include check results for other entity IDs as well,
 	 * or check results with statuses that we’re not interested in caching.
 	 */
-	private function storeResults( EntityId $entityId, CachedCheckResults $results ) {
+	private function storeResults(EntityId $entityId, CachedCheckResults $results) {
 		$latestRevisionIds = $this->getLatestRevisionIds(
 			$results->getMetadata()->getDependencyMetadata()->getEntityIds()
 		);
-		if ( $latestRevisionIds === null ) {
+		if ($latestRevisionIds === null) {
 			return;
 		}
 
 		$resultSerializations = [];
-		foreach ( $results->getArray() as $checkResult ) {
-			if ( $checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization() ) {
+		foreach ($results->getArray() as $checkResult) {
+			if ($checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization()) {
 				continue;
 			}
-			if ( $this->statusSelected( self::CACHED_STATUSES, $checkResult ) ) {
-				$resultSerializations[] = $this->checkResultSerializer->serialize( $checkResult );
+			if ($this->statusSelected(self::CACHED_STATUSES, $checkResult)) {
+				$resultSerializations[] = $this->checkResultSerializer->serialize($checkResult);
 			}
 		}
 
@@ -302,11 +302,11 @@ 
 			'latestRevisionIds' => $latestRevisionIds,
 		];
 		$futureTime = $results->getMetadata()->getDependencyMetadata()->getFutureTime();
-		if ( $futureTime !== null ) {
+		if ($futureTime !== null) {
 			$value['futureTime'] = $futureTime->getArrayValue();
 		}
 
-		$this->cache->set( $entityId, $value, $this->ttlInSeconds );
+		$this->cache->set($entityId, $value, $this->ttlInSeconds);
 	}
 
 	/**
@@ -321,33 +321,32 @@ 
 		$forRevision = 0
 	) {
 		$cacheInfo = WANObjectCache::PASS_BY_REF;
-		$value = $this->cache->get( $entityId, $curTTL, [], $cacheInfo );
-		$now = ( $this->microtime )( true );
+		$value = $this->cache->get($entityId, $curTTL, [], $cacheInfo);
+		$now = ($this->microtime)(true);
 
-		$dependencyMetadata = $this->checkDependencyMetadata( $value,
-			[ $entityId->getSerialization() => $forRevision ] );
-		if ( $dependencyMetadata === null ) {
+		$dependencyMetadata = $this->checkDependencyMetadata($value,
+			[$entityId->getSerialization() => $forRevision]);
+		if ($dependencyMetadata === null) {
 			return null;
 		}
 
 		// @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset False positive
 		$asOf = $cacheInfo[WANObjectCache::KEY_AS_OF];
-		$ageInSeconds = (int)ceil( $now - $asOf );
+		$ageInSeconds = (int) ceil($now - $asOf);
 		$cachingMetadata = $ageInSeconds > 0 ?
-			CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) :
-			CachingMetadata::fresh();
+			CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh();
 
 		$results = [];
-		foreach ( $value['results'] as $resultSerialization ) {
-			$results[] = $this->deserializeCheckResult( $resultSerialization, $cachingMetadata );
+		foreach ($value['results'] as $resultSerialization) {
+			$results[] = $this->deserializeCheckResult($resultSerialization, $cachingMetadata);
 		}
 
 		return new CachedCheckResults(
 			$results,
-			Metadata::merge( [
-				Metadata::ofCachingMetadata( $cachingMetadata ),
-				Metadata::ofDependencyMetadata( $dependencyMetadata ),
-			] )
+			Metadata::merge([
+				Metadata::ofCachingMetadata($cachingMetadata),
+				Metadata::ofDependencyMetadata($dependencyMetadata),
+			])
 		);
 	}
 
@@ -363,43 +362,43 @@ 
 	 * @return DependencyMetadata|null the dependency metadata,
 	 * or null if $value should no longer be used
 	 */
-	private function checkDependencyMetadata( $value, $paramRevs ) {
-		if ( $value === false ) {
+	private function checkDependencyMetadata($value, $paramRevs) {
+		if ($value === false) {
 			return null;
 		}
 
-		if ( array_key_exists( 'futureTime', $value ) ) {
-			$futureTime = TimeValue::newFromArray( $value['futureTime'] );
-			if ( !$this->timeValueComparer->isFutureTime( $futureTime ) ) {
+		if (array_key_exists('futureTime', $value)) {
+			$futureTime = TimeValue::newFromArray($value['futureTime']);
+			if (!$this->timeValueComparer->isFutureTime($futureTime)) {
 				return null;
 			}
-			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime );
+			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime);
 		} else {
 			$futureTimeDependencyMetadata = DependencyMetadata::blank();
 		}
 
-		foreach ( $paramRevs as $id => $revision ) {
-			if ( $revision > 0 ) {
-				$value['latestRevisionIds'][$id] = min( $revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX );
+		foreach ($paramRevs as $id => $revision) {
+			if ($revision > 0) {
+				$value['latestRevisionIds'][$id] = min($revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX);
 			}
 		}
 
 		$dependedEntityIds = array_map(
-			[ $this->entityIdParser, "parse" ],
-			array_keys( $value['latestRevisionIds'] )
+			[$this->entityIdParser, "parse"],
+			array_keys($value['latestRevisionIds'])
 		);
 
-		if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) {
+		if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) {
 			return null;
 		}
 
 		return array_reduce(
 			$dependedEntityIds,
-			static function ( DependencyMetadata $metadata, EntityId $entityId ) {
-				return DependencyMetadata::merge( [
+			static function(DependencyMetadata $metadata, EntityId $entityId) {
+				return DependencyMetadata::merge([
 					$metadata,
-					DependencyMetadata::ofEntityId( $entityId ),
-				] );
+					DependencyMetadata::ofEntityId($entityId),
+				]);
 			},
 			$futureTimeDependencyMetadata
 		);
@@ -419,13 +418,13 @@ 
 		array $resultSerialization,
 		CachingMetadata $cachingMetadata
 	) {
-		$result = $this->checkResultDeserializer->deserialize( $resultSerialization );
-		if ( $this->isPossiblyStaleResult( $result ) ) {
+		$result = $this->checkResultDeserializer->deserialize($resultSerialization);
+		if ($this->isPossiblyStaleResult($result)) {
 			$result->withMetadata(
-				Metadata::merge( [
+				Metadata::merge([
 					$result->getMetadata(),
-					Metadata::ofCachingMetadata( $cachingMetadata ),
-				] )
+					Metadata::ofCachingMetadata($cachingMetadata),
+				])
 			);
 		}
 		return $result;
@@ -435,8 +434,8 @@ 
 	 * @param CheckResult $result
 	 * @return bool
 	 */
-	private function isPossiblyStaleResult( CheckResult $result ) {
-		if ( $result instanceof NullResult ) {
+	private function isPossiblyStaleResult(CheckResult $result) {
+		if ($result instanceof NullResult) {
 			return false;
 		}
 
@@ -451,14 +450,14 @@ 
 	 * @return int[]|null array from entity ID serializations to revision ID,
 	 * or null to indicate that not all revision IDs could be loaded
 	 */
-	private function getLatestRevisionIds( array $entityIds ) {
-		if ( $entityIds === [] ) {
+	private function getLatestRevisionIds(array $entityIds) {
+		if ($entityIds === []) {
 			$this->loggingHelper->logEmptyDependencyMetadata();
 			return [];
 		}
-		if ( count( $entityIds ) > $this->maxRevisionIds ) {
+		if (count($entityIds) > $this->maxRevisionIds) {
 			// one of those entities will probably be edited soon, so might as well skip caching
-			$this->loggingHelper->logHugeDependencyMetadata( $entityIds, $this->maxRevisionIds );
+			$this->loggingHelper->logHugeDependencyMetadata($entityIds, $this->maxRevisionIds);
 			return null;
 		}
 
@@ -466,7 +465,7 @@ 
 			$entityIds,
 			LookupConstants::LATEST_FROM_REPLICA
 		);
-		if ( $this->hasFalseElements( $latestRevisionIds ) ) {
+		if ($this->hasFalseElements($latestRevisionIds)) {
 			return null;
 		}
 		return $latestRevisionIds;
@@ -476,14 +475,14 @@ 
 	 * @param array $array
 	 * @return bool
 	 */
-	private function hasFalseElements( array $array ) {
-		return in_array( false, $array, true );
+	private function hasFalseElements(array $array) {
+		return in_array(false, $array, true);
 	}
 
 	/**
 	 * Set a custom function to get the current time, instead of microtime().
 	 */
-	public function setMicrotimeFunction( callable $microtime ) {
+	public function setMicrotimeFunction(callable $microtime) {
 		$this->microtime = $microtime;
 	}
 

src/Api/ExpiryLock.php

Spacing +18 added lines, -18 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -21,7 +21,7 @@ 
 
 	private BagOStuff $cache;
 
-	public function __construct( BagOStuff $cache ) {
+	public function __construct(BagOStuff $cache) {
 		$this->cache = $cache;
 	}
 
@@ -32,9 +32,9 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	private function makeKey( string $id ): string {
-		if ( trim( $id ) === '' ) {
-			throw new ParameterTypeException( '$id', 'non-empty string' );
+	private function makeKey(string $id): string {
+		if (trim($id) === '') {
+			throw new ParameterTypeException('$id', 'non-empty string');
 		}
 
 		return $this->cache->makeKey(
@@ -52,15 +52,15 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	public function lock( string $id, ConvertibleTimestamp $expiryTimestamp ): bool {
+	public function lock(string $id, ConvertibleTimestamp $expiryTimestamp): bool {
 
-		$cacheId = $this->makeKey( $id );
+		$cacheId = $this->makeKey($id);
 
-		if ( !$this->isLockedInternal( $cacheId ) ) {
+		if (!$this->isLockedInternal($cacheId)) {
 			return $this->cache->set(
 				$cacheId,
-				$expiryTimestamp->getTimestamp( TS_UNIX ),
-				(int)$expiryTimestamp->getTimestamp( TS_UNIX )
+				$expiryTimestamp->getTimestamp(TS_UNIX),
+				(int) $expiryTimestamp->getTimestamp(TS_UNIX)
 			);
 		} else {
 			return false;
@@ -74,20 +74,20 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	private function isLockedInternal( string $cacheId ): bool {
-		$expiryTime = $this->cache->get( $cacheId );
-		if ( !$expiryTime ) {
+	private function isLockedInternal(string $cacheId): bool {
+		$expiryTime = $this->cache->get($cacheId);
+		if (!$expiryTime) {
 			return false;
 		}
 
 		try {
-			$lockExpiryTimeStamp = new ConvertibleTimestamp( $expiryTime );
-		} catch ( TimestampException ) {
+			$lockExpiryTimeStamp = new ConvertibleTimestamp($expiryTime);
+		} catch (TimestampException) {
 			return false;
 		}
 
 		$now = new ConvertibleTimestamp();
-		if ( $now->timestamp < $lockExpiryTimeStamp->timestamp ) {
+		if ($now->timestamp < $lockExpiryTimeStamp->timestamp) {
 			return true;
 		} else {
 			return false;
@@ -101,8 +101,8 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	public function isLocked( string $id ): bool {
-		return $this->isLockedInternal( $this->makeKey( $id ) );
+	public function isLocked(string $id): bool {
+		return $this->isLockedInternal($this->makeKey($id));
 	}
 
 }

src/ConstraintCheck/Result/NullResult.php

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 // @phan-file-suppress PhanPluginNeverReturnMethod
 
@@ -28,22 +28,22 @@ 
 	 */
 	private const NULL_PROPERTY_ID = 'P2147483647';
 
-	public function __construct( ContextCursor $contextCursor ) {
+	public function __construct(ContextCursor $contextCursor) {
 		$constraint = new Constraint(
 			'null',
-			new NumericPropertyId( self::NULL_PROPERTY_ID ),
+			new NumericPropertyId(self::NULL_PROPERTY_ID),
 			'none',
 			[]
 		);
-		parent::__construct( $contextCursor, $constraint );
+		parent::__construct($contextCursor, $constraint);
 	}
 
 	public function getConstraint(): Constraint {
-		throw new DomainException( 'NullResult holds no constraint' );
+		throw new DomainException('NullResult holds no constraint');
 	}
 
 	public function getConstraintId(): string {
-		throw new DomainException( 'NullResult holds no constraint' );
+		throw new DomainException('NullResult holds no constraint');
 	}
 
 }

src/ConstraintCheck/Helper/DummySparqlHelper.php

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 // @phan-file-suppress PhanPluginNeverReturnMethod
 
@@ -29,8 +29,8 @@ 
 		// no parent::__construct() call
 	}
 
-	public function hasType( EntityId $id, array $classes ): CachedBool {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function hasType(EntityId $id, array $classes): CachedBool {
+		throw new LogicException('methods of this class should never be called');
 	}
 
 	public function findEntitiesWithSameStatement(
@@ -38,7 +38,7 @@ 
 		Statement $statement,
 		array $separators
 	): CachedEntityIds {
-		throw new LogicException( 'methods of this class should never be called' );
+		throw new LogicException('methods of this class should never be called');
 	}
 
 	public function findEntitiesWithSameQualifierOrReference(
@@ -47,15 +47,15 @@ 
 		string $type,
 		bool $ignoreDeprecatedStatements
 	): CachedEntityIds {
-		throw new LogicException( 'methods of this class should never be called' );
+		throw new LogicException('methods of this class should never be called');
 	}
 
-	public function matchesRegularExpression( string $text, string $regex ): bool {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function matchesRegularExpression(string $text, string $regex): bool {
+		throw new LogicException('methods of this class should never be called');
 	}
 
-	public function runQuery( string $query, string $endpoint, bool $needsPrefixes = true ): CachedQueryResults {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function runQuery(string $query, string $endpoint, bool $needsPrefixes = true): CachedQueryResults {
+		throw new LogicException('methods of this class should never be called');
 	}
 
 }

src/ConstraintCheck/Context/EntityContextCursor.php

Spacing +12 added lines, -12 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 // @phan-file-suppress PhanPluginNeverReturnMethod
 
@@ -33,7 +33,7 @@ 
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getType(): string {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	public function getEntityId(): string {
@@ -44,35 +44,35 @@ 
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getStatementPropertyId(): string {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getStatementGuid(): string {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getSnakPropertyId(): string {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getSnakHash(): string {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
-	public function &getMainArray( array &$container ): array {
-		throw new LogicException( 'EntityContextCursor cannot store check results' );
+	public function &getMainArray(array &$container): array {
+		throw new LogicException('EntityContextCursor cannot store check results');
 	}
 
 	/**
@@ -81,14 +81,14 @@ 
 	 * @param ?array $result must be null
 	 * @param array[] &$container
 	 */
-	public function storeCheckResultInArray( ?array $result, array &$container ): void {
-		if ( $result !== null ) {
-			throw new LogicException( 'EntityContextCursor cannot store check results' );
+	public function storeCheckResultInArray(?array $result, array &$container): void {
+		if ($result !== null) {
+			throw new LogicException('EntityContextCursor cannot store check results');
 		}
 
 		// this ensures that the claims array is present in the $container,
 		// populating it if necessary, even though we ignore the return value
-		$this->getClaimsArray( $container );
+		$this->getClaimsArray($container);
 	}
 
 }

src/ConstraintCheck/Message/ViolationMessageRenderer.php

Spacing +86 added lines, -86 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Message;
 
@@ -70,15 +70,15 @@ 
 		$this->maxListLength = $maxListLength;
 	}
 
-	public function render( ViolationMessage $violationMessage ): string {
+	public function render(ViolationMessage $violationMessage): string {
 		$messageKey = $violationMessage->getMessageKey();
-		$paramsLists = [ [] ];
-		foreach ( $violationMessage->getArguments() as $argument ) {
-			$params = $this->renderArgument( $argument );
+		$paramsLists = [[]];
+		foreach ($violationMessage->getArguments() as $argument) {
+			$params = $this->renderArgument($argument);
 			$paramsLists[] = $params;
 		}
-		$allParams = array_merge( ...$paramsLists );
-		return $this->messageLocalizer->msg( $messageKey, ...$allParams )->escaped();
+		$allParams = array_merge(...$paramsLists);
+		return $this->messageLocalizer->msg($messageKey, ...$allParams)->escaped();
 	}
 
 	/**
@@ -86,13 +86,13 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return string HTML
 	 */
-	protected function addRole( string $value, ?string $role ): string {
-		if ( $role === null ) {
+	protected function addRole(string $value, ?string $role): string {
+		if ($role === null) {
 			return $value;
 		}
 
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">' .
-			$value .
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'.
+			$value.
 			'</span>';
 	}
 
@@ -100,15 +100,15 @@ 
 	 * @param string $key message key
 	 * @return string HTML
 	 */
-	protected function msgEscaped( string $key ): string {
-		return $this->messageLocalizer->msg( $key )->escaped();
+	protected function msgEscaped(string $key): string {
+		return $this->messageLocalizer->msg($key)->escaped();
 	}
 
 	/**
 	 * @param array $argument
 	 * @return MessageParam[] params (for Message::params)
 	 */
-	protected function renderArgument( array $argument ): array {
+	protected function renderArgument(array $argument): array {
 		$methods = [
 			ViolationMessage::TYPE_ENTITY_ID => 'renderEntityId',
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'renderEntityIdList',
@@ -129,12 +129,12 @@ 
 		$value = $argument['value'];
 		$role = $argument['role'];
 
-		if ( array_key_exists( $type, $methods ) ) {
+		if (array_key_exists($type, $methods)) {
 			$method = $methods[$type];
-			$params = $this->$method( $value, $role );
+			$params = $this->$method($value, $role);
 		} else {
 			throw new InvalidArgumentException(
-				'Unknown ViolationMessage argument type ' . $type . '!'
+				'Unknown ViolationMessage argument type '.$type.'!'
 			);
 		}
 
@@ -148,34 +148,34 @@ 
 	 * and return a single-element array with a raw message param (i. e. [ Message::rawParam( … ) ])
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 */
-	private function renderList( array $list, ?string $role, callable $render ): array {
-		if ( $list === [] ) {
+	private function renderList(array $list, ?string $role, callable $render): array {
+		if ($list === []) {
 			return [
-				Message::numParam( 0 ),
-				Message::rawParam( '<ul></ul>' ),
+				Message::numParam(0),
+				Message::rawParam('<ul></ul>'),
 			];
 		}
 
-		$truncated = count( $list ) > $this->maxListLength;
-		if ( $truncated ) {
-			$list = array_slice( $list, 0, $this->maxListLength );
+		$truncated = count($list) > $this->maxListLength;
+		if ($truncated) {
+			$list = array_slice($list, 0, $this->maxListLength);
 		}
 
 		$renderedParamsLists = array_map(
 			$render,
 			$list,
-			array_fill( 0, count( $list ), $role )
+			array_fill(0, count($list), $role)
 		);
-		$renderedParams = array_column( $renderedParamsLists, 0 );
-		$renderedElements = array_map( static fn ( MessageParam $p ) => $p->getValue(), $renderedParams );
-		if ( $truncated ) {
-			$renderedElements[] = $this->msgEscaped( 'ellipsis' );
+		$renderedParams = array_column($renderedParamsLists, 0);
+		$renderedElements = array_map(static fn (MessageParam $p) => $p->getValue(), $renderedParams);
+		if ($truncated) {
+			$renderedElements[] = $this->msgEscaped('ellipsis');
 		}
 
 		return [
-			Message::numParam( count( $list ) ),
+			Message::numParam(count($list)),
 			Message::rawParam(
-				'<ul><li>' . implode( '</li><li>', $renderedElements ) . '</li></ul>'
+				'<ul><li>'.implode('</li><li>', $renderedElements).'</li></ul>'
 			),
 			...$renderedParams,
 		];
@@ -186,11 +186,11 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderEntityId( EntityId $entityId, ?string $role ): array {
-		return [ Message::rawParam( $this->addRole(
-			$this->entityIdFormatter->formatEntityId( $entityId ),
+	private function renderEntityId(EntityId $entityId, ?string $role): array {
+		return [Message::rawParam($this->addRole(
+			$this->entityIdFormatter->formatEntityId($entityId),
 			$role
-		) ) ];
+		))];
 	}
 
 	/**
@@ -198,8 +198,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 */
-	private function renderEntityIdList( array $entityIdList, ?string $role ): array {
-		return $this->renderList( $entityIdList, $role, [ $this, 'renderEntityId' ] );
+	private function renderEntityIdList(array $entityIdList, ?string $role): array {
+		return $this->renderList($entityIdList, $role, [$this, 'renderEntityId']);
 	}
 
 	/**
@@ -207,24 +207,24 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderItemIdSnakValue( ItemIdSnakValue $value, ?string $role ): array {
-		switch ( true ) {
+	private function renderItemIdSnakValue(ItemIdSnakValue $value, ?string $role): array {
+		switch (true) {
 			case $value->isValue():
-				return $this->renderEntityId( $value->getItemId(), $role );
+				return $this->renderEntityId($value->getItemId(), $role);
 			case $value->isSomeValue():
-				return [ Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-somevaluesnak">' .
-						$this->msgEscaped( 'wikibase-snakview-snaktypeselector-somevalue' ) .
+				return [Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-somevaluesnak">'.
+						$this->msgEscaped('wikibase-snakview-snaktypeselector-somevalue').
 						'</span>',
 					$role
-				) ) ];
+				))];
 			case $value->isNoValue():
-				return [ Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-novaluesnak">' .
-					$this->msgEscaped( 'wikibase-snakview-snaktypeselector-novalue' ) .
+				return [Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-novaluesnak">'.
+					$this->msgEscaped('wikibase-snakview-snaktypeselector-novalue').
 						'</span>',
 					$role
-				) ) ];
+				))];
 			default:
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
@@ -239,8 +239,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 */
-	private function renderItemIdSnakValueList( array $valueList, ?string $role ): array {
-		return $this->renderList( $valueList, $role, [ $this, 'renderItemIdSnakValue' ] );
+	private function renderItemIdSnakValueList(array $valueList, ?string $role): array {
+		return $this->renderList($valueList, $role, [$this, 'renderItemIdSnakValue']);
 	}
 
 	/**
@@ -248,11 +248,11 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 */
-	private function renderDataValue( DataValue $dataValue, ?string $role ): array {
-		return [ Message::rawParam( $this->addRole(
-			$this->dataValueFormatter->format( $dataValue ),
+	private function renderDataValue(DataValue $dataValue, ?string $role): array {
+		return [Message::rawParam($this->addRole(
+			$this->dataValueFormatter->format($dataValue),
 			$role
-		) ) ];
+		))];
 	}
 
 	/**
@@ -260,7 +260,7 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 */
-	private function renderDataValueType( string $dataValueType, ?string $role ): array {
+	private function renderDataValueType(string $dataValueType, ?string $role): array {
 		$messageKeys = [
 			'string' => 'datatypes-type-string',
 			'monolingualtext' => 'datatypes-type-monolingualtext',
@@ -269,15 +269,15 @@ 
 			'wikibase-entityid' => 'wbqc-dataValueType-wikibase-entityid',
 		];
 
-		if ( array_key_exists( $dataValueType, $messageKeys ) ) {
-			return [ Message::rawParam( $this->addRole(
-				$this->msgEscaped( $messageKeys[$dataValueType] ),
+		if (array_key_exists($dataValueType, $messageKeys)) {
+			return [Message::rawParam($this->addRole(
+				$this->msgEscaped($messageKeys[$dataValueType]),
 				$role
-			) ) ];
+			))];
 		} else {
 			// @codeCoverageIgnoreStart
 			throw new LogicException(
-				'Unknown data value type ' . $dataValueType
+				'Unknown data value type '.$dataValueType
 			);
 			// @codeCoverageIgnoreEnd
 		}
@@ -288,11 +288,11 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 */
-	private function renderInlineCode( string $code, ?string $role ): array {
-		return [ Message::rawParam( $this->addRole(
-			'<code>' . htmlspecialchars( $code ) . '</code>',
+	private function renderInlineCode(string $code, ?string $role): array {
+		return [Message::rawParam($this->addRole(
+			'<code>'.htmlspecialchars($code).'</code>',
 			$role
-		) ) ];
+		))];
 	}
 
 	/**
@@ -300,8 +300,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderConstraintScope( string $scope, ?string $role ): array {
-		switch ( $scope ) {
+	private function renderConstraintScope(string $scope, ?string $role): array {
+		switch ($scope) {
 			case Context::TYPE_STATEMENT:
 				$itemId = $this->config->get(
 					'WBQualityConstraintsConstraintCheckedOnMainValueId'
@@ -321,10 +321,10 @@ 
 				// callers should never let this happen, but if it does happen,
 				// showing “unknown value” seems reasonable
 				// @codeCoverageIgnoreStart
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
 				// @codeCoverageIgnoreEnd
 		}
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
+		return $this->renderEntityId(new ItemId($itemId), $role);
 	}
 
 	/**
@@ -332,8 +332,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 */
-	private function renderConstraintScopeList( array $scopeList, ?string $role ): array {
-		return $this->renderList( $scopeList, $role, [ $this, 'renderConstraintScope' ] );
+	private function renderConstraintScopeList(array $scopeList, ?string $role): array {
+		return $this->renderList($scopeList, $role, [$this, 'renderConstraintScope']);
 	}
 
 	/**
@@ -341,25 +341,25 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderPropertyScope( string $scope, ?string $role ): array {
-		switch ( $scope ) {
+	private function renderPropertyScope(string $scope, ?string $role): array {
+		switch ($scope) {
 			case Context::TYPE_STATEMENT:
-				$itemId = $this->config->get( 'WBQualityConstraintsAsMainValueId' );
+				$itemId = $this->config->get('WBQualityConstraintsAsMainValueId');
 				break;
 			case Context::TYPE_QUALIFIER:
-				$itemId = $this->config->get( 'WBQualityConstraintsAsQualifiersId' );
+				$itemId = $this->config->get('WBQualityConstraintsAsQualifiersId');
 				break;
 			case Context::TYPE_REFERENCE:
-				$itemId = $this->config->get( 'WBQualityConstraintsAsReferencesId' );
+				$itemId = $this->config->get('WBQualityConstraintsAsReferencesId');
 				break;
 			default:
 				// callers should never let this happen, but if it does happen,
 				// showing “unknown value” seems reasonable
 				// @codeCoverageIgnoreStart
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
 				// @codeCoverageIgnoreEnd
 		}
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
+		return $this->renderEntityId(new ItemId($itemId), $role);
 	}
 
 	/**
@@ -367,8 +367,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 */
-	private function renderPropertyScopeList( array $scopeList, ?string $role ): array {
-		return $this->renderList( $scopeList, $role, [ $this, 'renderPropertyScope' ] );
+	private function renderPropertyScopeList(array $scopeList, ?string $role): array {
+		return $this->renderList($scopeList, $role, [$this, 'renderPropertyScope']);
 	}
 
 	/**
@@ -377,14 +377,14 @@ 
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 * @suppress PhanUnusedPrivateMethodParameter
 	 */
-	private function renderLanguage( string $languageCode, ?string $role ): array {
+	private function renderLanguage(string $languageCode, ?string $role): array {
 		return [
 			// ::renderList (through ::renderLanguageList) requires 'raw' parameter
 			// so we effectively build Message::plaintextParam here
-			Message::rawParam( htmlspecialchars(
-				$this->languageNameUtils->getLanguageName( $languageCode, $this->userLanguageCode )
-			) ),
-			Message::plaintextParam( $languageCode ),
+			Message::rawParam(htmlspecialchars(
+				$this->languageNameUtils->getLanguageName($languageCode, $this->userLanguageCode)
+			)),
+			Message::plaintextParam($languageCode),
 		];
 	}
 
@@ -393,8 +393,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return MessageParam[] list of parameters as accepted by Message::params()
 	 */
-	private function renderLanguageList( array $languageCodes, ?string $role ): array {
-		return $this->renderList( $languageCodes, $role, [ $this, 'renderLanguage' ] );
+	private function renderLanguageList(array $languageCodes, ?string $role): array {
+		return $this->renderList($languageCodes, $role, [$this, 'renderLanguage']);
 	}
 
 }

src/Api/CheckConstraintParameters.php

Spacing +49 added lines, -49 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -65,7 +65,7 @@ 
 			$delegatingConstraintChecker,
 			$violationMessageRendererFactory,
 			$statementGuidParser,
-			$statsFactory->withComponent( 'WikibaseQualityConstraints' )
+			$statsFactory->withComponent('WikibaseQualityConstraints')
 		);
 	}
 
@@ -79,9 +79,9 @@ 
 		StatementGuidParser $statementGuidParser,
 		StatsFactory $statsFactory
 	) {
-		parent::__construct( $main, $name );
+		parent::__construct($main, $name);
 
-		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->languageFallbackChainFactory = $languageFallbackChainFactory;
 		$this->delegatingConstraintChecker = $delegatingConstraintChecker;
 		$this->violationMessageRendererFactory = $violationMessageRendererFactory;
@@ -90,45 +90,45 @@ 
 	}
 
 	public function execute() {
-		$this->statsFactory->getCounter( 'check_constraint_parameters_execute_total' )
+		$this->statsFactory->getCounter('check_constraint_parameters_execute_total')
 			->increment();
 
 		$params = $this->extractRequestParams();
 		$result = $this->getResult();
 
-		$propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] );
-		$constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] );
+		$propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]);
+		$constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]);
 
-		$this->checkPropertyIds( $propertyIds, $result );
-		$this->checkConstraintIds( $constraintIds, $result );
+		$this->checkPropertyIds($propertyIds, $result);
+		$this->checkConstraintIds($constraintIds, $result);
 
-		$result->addValue( null, 'success', 1 );
+		$result->addValue(null, 'success', 1);
 	}
 
 	/**
 	 * @param array|null $propertyIdSerializations
 	 * @return NumericPropertyId[]
 	 */
-	private function parsePropertyIds( ?array $propertyIdSerializations ): array {
-		if ( $propertyIdSerializations === null ) {
+	private function parsePropertyIds(?array $propertyIdSerializations): array {
+		if ($propertyIdSerializations === null) {
 			return [];
-		} elseif ( $propertyIdSerializations === [] ) {
+		} elseif ($propertyIdSerializations === []) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function ( $propertyIdSerialization ) {
+			function($propertyIdSerialization) {
 				try {
-					return new NumericPropertyId( $propertyIdSerialization );
-				} catch ( InvalidArgumentException ) {
+					return new NumericPropertyId($propertyIdSerialization);
+				} catch (InvalidArgumentException) {
 					$this->apiErrorReporter->dieError(
 						"Invalid id: $propertyIdSerialization",
 						'invalid-property-id',
 						0, // default argument
-						[ self::PARAM_PROPERTY_ID => $propertyIdSerialization ]
+						[self::PARAM_PROPERTY_ID => $propertyIdSerialization]
 					);
 				}
 			},
@@ -140,35 +140,35 @@ 
 	 * @param array|null $constraintIds
 	 * @return string[]
 	 */
-	private function parseConstraintIds( ?array $constraintIds ): array {
-		if ( $constraintIds === null ) {
+	private function parseConstraintIds(?array $constraintIds): array {
+		if ($constraintIds === null) {
 			return [];
-		} elseif ( $constraintIds === [] ) {
+		} elseif ($constraintIds === []) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function ( $constraintId ) {
+			function($constraintId) {
 				try {
-					$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
-					if ( !$propertyId instanceof NumericPropertyId ) {
+					$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
+					if (!$propertyId instanceof NumericPropertyId) {
 						$this->apiErrorReporter->dieError(
 							"Invalid property ID: {$propertyId->getSerialization()}",
 							'invalid-property-id',
 							0, // default argument
-							[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+							[self::PARAM_CONSTRAINT_ID => $constraintId]
 						);
 					}
 					return $constraintId;
-				} catch ( StatementGuidParsingException ) {
+				} catch (StatementGuidParsingException) {
 					$this->apiErrorReporter->dieError(
 						"Invalid statement GUID: $constraintId",
 						'invalid-guid',
 						0, // default argument
-						[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+						[self::PARAM_CONSTRAINT_ID => $constraintId]
 					);
 				}
 			},
@@ -180,12 +180,12 @@ 
 	 * @param NumericPropertyId[] $propertyIds
 	 * @param ApiResult $result
 	 */
-	private function checkPropertyIds( array $propertyIds, ApiResult $result ): void {
-		foreach ( $propertyIds as $propertyId ) {
-			$result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' );
+	private function checkPropertyIds(array $propertyIds, ApiResult $result): void {
+		foreach ($propertyIds as $propertyId) {
+			$result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc');
 			$allConstraintExceptions = $this->delegatingConstraintChecker
-				->checkConstraintParametersOnPropertyId( $propertyId );
-			foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) {
+				->checkConstraintParametersOnPropertyId($propertyId);
+			foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) {
 				$this->addConstraintParameterExceptionsToResult(
 					$constraintId,
 					$constraintParameterExceptions,
@@ -199,15 +199,15 @@ 
 	 * @param string[] $constraintIds
 	 * @param ApiResult $result
 	 */
-	private function checkConstraintIds( array $constraintIds, ApiResult $result ): void {
-		foreach ( $constraintIds as $constraintId ) {
-			if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) {
+	private function checkConstraintIds(array $constraintIds, ApiResult $result): void {
+		foreach ($constraintIds as $constraintId) {
+			if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) {
 				// already checked as part of checkPropertyIds()
 				continue;
 			}
 			$constraintParameterExceptions = $this->delegatingConstraintChecker
-				->checkConstraintParametersOnConstraintId( $constraintId );
-			$this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result );
+				->checkConstraintParametersOnConstraintId($constraintId);
+			$this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result);
 		}
 	}
 
@@ -215,18 +215,18 @@ 
 	 * @param NumericPropertyId $propertyId
 	 * @return string[]
 	 */
-	private function getResultPathForPropertyId( NumericPropertyId $propertyId ): array {
-		return [ $this->getModuleName(), $propertyId->getSerialization() ];
+	private function getResultPathForPropertyId(NumericPropertyId $propertyId): array {
+		return [$this->getModuleName(), $propertyId->getSerialization()];
 	}
 
 	/**
 	 * @param string $constraintId
 	 * @return string[]
 	 */
-	private function getResultPathForConstraintId( string $constraintId ): array {
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
+	private function getResultPathForConstraintId(string $constraintId): array {
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
 		'@phan-var NumericPropertyId $propertyId';
-		return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] );
+		return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]);
 	}
 
 	/**
@@ -241,8 +241,8 @@ 
 		?array $constraintParameterExceptions,
 		ApiResult $result
 	): void {
-		$path = $this->getResultPathForConstraintId( $constraintId );
-		if ( $constraintParameterExceptions === null ) {
+		$path = $this->getResultPathForConstraintId($constraintId);
+		if ($constraintParameterExceptions === null) {
 			$result->addValue(
 				$path,
 				self::KEY_STATUS,
@@ -259,11 +259,11 @@ 
 			$violationMessageRenderer = $this->violationMessageRendererFactory
 				->getViolationMessageRenderer(
 					$language,
-					$this->languageFallbackChainFactory->newFromLanguage( $language ),
+					$this->languageFallbackChainFactory->newFromLanguage($language),
 					$this
 				);
 			$problems = [];
-			foreach ( $constraintParameterExceptions as $constraintParameterException ) {
+			foreach ($constraintParameterExceptions as $constraintParameterException) {
 				$problems[] = [
 					self::KEY_MESSAGE_HTML => $violationMessageRenderer->render(
 						$constraintParameterException->getViolationMessage() ),
@@ -302,8 +302,8 @@ 
 		return [
 			'action=wbcheckconstraintparameters&propertyid=P247'
 				=> 'apihelp-wbcheckconstraintparameters-example-propertyid-1',
-			'action=wbcheckconstraintparameters&' .
-			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|' .
+			'action=wbcheckconstraintparameters&'.
+			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|'.
 			'P225$cdc71e4a-47a0-12c5-dfb3-3f6fc0b6613f'
 				=> 'apihelp-wbcheckconstraintparameters-example-constraintid-2',
 		];

src/Specials/SpecialConstraintReport.php

Spacing +86 added lines, -86 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Specials;
 
@@ -91,7 +91,7 @@ 
 		Config $config,
 		StatsFactory $statsFactory
 	) {
-		parent::__construct( 'ConstraintReport' );
+		parent::__construct('ConstraintReport');
 
 		$this->entityLookup = $entityLookup;
 		$this->entityTitleLookup = $entityTitleLookup;
@@ -111,7 +111,7 @@ 
 
 		$this->violationMessageRenderer = $violationMessageRendererFactory->getViolationMessageRenderer(
 			$language,
-			$languageFallbackChainFactory->newFromLanguage( $language ),
+			$languageFallbackChainFactory->newFromLanguage($language),
 			$this->getContext()
 		);
 
@@ -145,7 +145,7 @@ 
 	 * @inheritDoc
 	 */
 	public function getDescription() {
-		return $this->msg( 'wbqc-constraintreport' );
+		return $this->msg('wbqc-constraintreport');
 	}
 
 	/**
@@ -157,71 +157,71 @@ 
 	 * @throws EntityIdParsingException
 	 * @throws UnexpectedValueException
 	 */
-	public function execute( $subPage ) {
+	public function execute($subPage) {
 		$out = $this->getOutput();
 
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
-		if ( $postRequest ) {
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
+		if ($postRequest) {
 			try {
-				$entityId = $this->entityIdParser->parse( $postRequest );
-				$out->redirect( $this->getPageTitle( $entityId->getSerialization() )->getLocalURL() );
+				$entityId = $this->entityIdParser->parse($postRequest);
+				$out->redirect($this->getPageTitle($entityId->getSerialization())->getLocalURL());
 				return;
-			} catch ( EntityIdParsingException ) {
+			} catch (EntityIdParsingException) {
 				// fall through, error is shown later
 			}
 		}
 
 		$out->enableOOUI();
-		$out->addModules( $this->getModules() );
+		$out->addModules($this->getModules());
 
 		$this->setHeaders();
 
-		$out->addHTML( $this->getExplanationText() );
+		$out->addHTML($this->getExplanationText());
 		$this->buildEntityIdForm();
 
-		if ( $postRequest ) {
+		if ($postRequest) {
 			// must be an invalid entity ID (otherwise we would have redirected and returned above)
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
 			);
 			return;
 		}
 
-		if ( !$subPage ) {
+		if (!$subPage) {
 			return;
 		}
 
 		try {
-			$entityId = $this->entityIdParser->parse( $subPage );
-		} catch ( EntityIdParsingException ) {
+			$entityId = $this->entityIdParser->parse($subPage);
+		} catch (EntityIdParsingException) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
 			);
 			return;
 		}
 
-		if ( !$this->entityLookup->hasEntity( $entityId ) ) {
+		if (!$this->entityLookup->hasEntity($entityId)) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true )
+				$this->buildNotice('wbqc-constraintreport-not-existent-entity', true)
 			);
 			return;
 		}
 
-		$this->statsFactory->getCounter( 'special_constraint_report_execute_check_total' )
+		$this->statsFactory->getCounter('special_constraint_report_execute_check_total')
 			->increment();
-		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId );
+		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId);
 
-		if ( !$results ) {
-			$out->addHTML( $this->buildResultHeader( $entityId ) .
-				$this->buildNotice( 'wbqc-constraintreport-empty-result' )
+		if (!$results) {
+			$out->addHTML($this->buildResultHeader($entityId).
+				$this->buildNotice('wbqc-constraintreport-empty-result')
 			);
 			return;
 		}
 
 		$out->addHTML(
-			$this->buildResultHeader( $entityId )
-			. $this->buildSummary( $results )
-			. $this->buildResultTable( $entityId, $results )
+			$this->buildResultHeader($entityId)
+			. $this->buildSummary($results)
+			. $this->buildResultTable($entityId, $results)
 		);
 	}
 
@@ -236,15 +236,15 @@ 
 				'name' => 'entityid',
 				'label-message' => 'wbqc-constraintreport-form-entityid-label',
 				'cssclass' => 'wbqc-constraintreport-form-entity-id',
-				'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->text(),
+				'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->text(),
 				'required' => true,
 			],
 		];
-		$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(),
+		$htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(),
 			'wbqc-constraintreport-form'
 		);
-		$htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->text() );
-		$htmlForm->setSubmitCallback( static fn () => false );
+		$htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->text());
+		$htmlForm->setSubmitCallback(static fn () => false);
 		$htmlForm->show();
 	}
 
@@ -258,16 +258,16 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildNotice( string $messageKey, bool $error = false ): string {
-		$cssClasses = [ 'wbqc-constraintreport-notice' ];
-		if ( $error ) {
+	private function buildNotice(string $messageKey, bool $error = false): string {
+		$cssClasses = ['wbqc-constraintreport-notice'];
+		if ($error) {
 			$cssClasses[] = ' wbqc-constraintreport-notice-error';
 		}
 
 		return Html::element(
 			'p',
-			[ 'class' => $cssClasses ],
-			$this->msg( $messageKey )->text()
+			['class' => $cssClasses],
+			$this->msg($messageKey)->text()
 		);
 	}
 
@@ -277,16 +277,16 @@ 
 	private function getExplanationText(): string {
 		return Html::rawElement(
 			'div',
-			[ 'class' => 'wbqc-explanation' ],
+			['class' => 'wbqc-explanation'],
 			Html::element(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-one' )->text()
+				$this->msg('wbqc-constraintreport-explanation-part-one')->text()
 			)
 			. Html::element(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-two' )->text()
+				$this->msg('wbqc-constraintreport-explanation-part-two')->text()
 			)
 		);
 	}
@@ -297,31 +297,31 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildResultTable( EntityId $entityId, array $results ): string {
+	private function buildResultTable(EntityId $entityId, array $results): string {
 		// Set table headers
 		$table = new HtmlTableBuilder(
 			[
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-status' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-status')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-property' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-property')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-message' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-message')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-constraint')->text(),
 					true
 				),
 			]
 		);
 
-		foreach ( $results as $result ) {
-			$this->appendToResultTable( $table, $entityId, $result );
+		foreach ($results as $result) {
+			$this->appendToResultTable($table, $entityId, $result);
 		}
 
 		return $table->toHtml();
@@ -333,35 +333,35 @@ 
 		CheckResult $result
 	): void {
 		$message = $result->getMessage();
-		if ( !$message ) {
+		if (!$message) {
 			// no row for this result
 			return;
 		}
 
 		// Status column
-		$statusColumn = $this->formatStatus( $result->getStatus() );
+		$statusColumn = $this->formatStatus($result->getStatus());
 
 		// Property column
-		$propertyId = new NumericPropertyId( $result->getContextCursor()->getSnakPropertyId() );
+		$propertyId = new NumericPropertyId($result->getContextCursor()->getSnakPropertyId());
 		$propertyColumn = $this->getClaimLink(
 			$entityId,
 			$propertyId,
-			$this->entityIdLabelFormatter->formatEntityId( $propertyId )
+			$this->entityIdLabelFormatter->formatEntityId($propertyId)
 		);
 
 		// Message column
-		$messageColumn = $this->violationMessageRenderer->render( $message );
+		$messageColumn = $this->violationMessageRenderer->render($message);
 
 		// Constraint column
 		$constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId();
 		try {
-			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) );
-		} catch ( InvalidArgumentException ) {
-			$constraintTypeLabel = htmlspecialchars( $constraintTypeItemId );
+			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId));
+		} catch (InvalidArgumentException) {
+			$constraintTypeLabel = htmlspecialchars($constraintTypeItemId);
 		}
 		$constraintColumn = $this->getClaimLink(
 			$propertyId,
-			new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ),
+			new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')),
 			$constraintTypeLabel
 		);
 
@@ -369,16 +369,16 @@ 
 		$table->appendRow(
 			[
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $statusColumn )
+					new HtmlArmor($statusColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $propertyColumn )
+					new HtmlArmor($propertyColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $messageColumn )
+					new HtmlArmor($messageColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $constraintColumn )
+					new HtmlArmor($constraintColumn)
 				),
 			]
 		);
@@ -391,15 +391,15 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildResultHeader( EntityId $entityId ): string {
+	protected function buildResultHeader(EntityId $entityId): string {
 		return Html::rawElement(
 			'h3',
 			[],
-			$this->msg( 'wbqc-constraintreport-result-headline' )->escaped() .
-				$this->msg( 'word-separator' )->escaped() .
-				$this->entityIdLinkFormatter->formatEntityId( $entityId ) .
-				$this->msg( 'word-separator' )->escaped() .
-				$this->msg( 'parentheses', $entityId->getSerialization() )->escaped()
+			$this->msg('wbqc-constraintreport-result-headline')->escaped().
+				$this->msg('word-separator')->escaped().
+				$this->entityIdLinkFormatter->formatEntityId($entityId).
+				$this->msg('word-separator')->escaped().
+				$this->msg('parentheses', $entityId->getSerialization())->escaped()
 		);
 	}
 
@@ -410,23 +410,23 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildSummary( array $results ): string {
+	protected function buildSummary(array $results): string {
 		$statuses = [];
-		foreach ( $results as $result ) {
-			$status = strtolower( $result->getStatus() );
+		foreach ($results as $result) {
+			$status = strtolower($result->getStatus());
 			$statuses[$status] ??= 0;
 			$statuses[$status]++;
 		}
 
 		$statusElements = [];
-		foreach ( $statuses as $status => $count ) {
-			$statusElements[] = $this->formatStatus( $status ) .
-				$this->msg( 'colon-separator' )->escaped() .
-				htmlspecialchars( $this->getLanguage()->formatNum( $count ) );
+		foreach ($statuses as $status => $count) {
+			$statusElements[] = $this->formatStatus($status).
+				$this->msg('colon-separator')->escaped().
+				htmlspecialchars($this->getLanguage()->formatNum($count));
 		}
 
-		return Html::rawElement( 'p', [],
-			implode( $this->msg( 'comma-separator' )->escaped(), $statusElements )
+		return Html::rawElement('p', [],
+			implode($this->msg('comma-separator')->escaped(), $statusElements)
 		);
 	}
 
@@ -439,8 +439,8 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function formatStatus( string $status ): string {
-		$messageName = "wbqc-constraintreport-status-" . strtolower( $status );
+	private function formatStatus(string $status): string {
+		$messageName = "wbqc-constraintreport-status-".strtolower($status);
 		$statusIcons = [
 			CheckResult::STATUS_SUGGESTION => [
 				'icon' => 'suggestion-constraint-violation',
@@ -457,21 +457,21 @@ 
 			],
 		];
 
-		if ( array_key_exists( $status, $statusIcons ) ) {
-			$iconHtml = new IconWidget( $statusIcons[$status] ) .
-				$this->msg( 'word-separator' )->escaped();
+		if (array_key_exists($status, $statusIcons)) {
+			$iconHtml = new IconWidget($statusIcons[$status]).
+				$this->msg('word-separator')->escaped();
 		} else {
 			$iconHtml = '';
 		}
 
-		$labelWidget = new LabelWidget( [ 'label' => $this->msg( $messageName )->text() ] );
+		$labelWidget = new LabelWidget(['label' => $this->msg($messageName)->text()]);
 
 		return Html::rawElement(
 			'span',
 			[
-				'class' => 'wbqc-status wbqc-status-' . $status,
+				'class' => 'wbqc-status wbqc-status-'.$status,
 			],
-			$iconHtml . $labelWidget
+			$iconHtml.$labelWidget
 		);
 	}
 
@@ -489,10 +489,10 @@ 
 		NumericPropertyId $propertyId,
 		string $text
 	): string {
-		$title = clone $this->entityTitleLookup->getTitleForId( $entityId );
-		$title->setFragment( $propertyId->getSerialization() );
+		$title = clone $this->entityTitleLookup->getTitleForId($entityId);
+		$title->setFragment($propertyId->getSerialization());
 
-		return Html::rawElement( 'a',
+		return Html::rawElement('a',
 			[
 				'href' => $title->getLinkURL(),
 				'target' => '_blank',

src/ConstraintCheck/Helper/TypeCheckerHelper.php

Spacing +49 added lines, -49 removed lines

@@ -81,26 +81,26 @@ 
 	 * @return bool
 	 * @throws OverflowException if $entitiesChecked exceeds the configured limit
 	 */
-	private function isSubclassOf( EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0 ) {
-		$maxEntities = $this->config->get( 'WBQualityConstraintsTypeCheckMaxEntities' );
+	private function isSubclassOf(EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0) {
+		$maxEntities = $this->config->get('WBQualityConstraintsTypeCheckMaxEntities');
 		if ( ++$entitiesChecked > $maxEntities ) {
-			throw new OverflowException( 'Too many entities to check' );
+			throw new OverflowException('Too many entities to check');
 		}
 
-		$item = $this->entityLookup->getEntity( $comparativeClass );
-		if ( !( $item instanceof StatementListProvider ) ) {
+		$item = $this->entityLookup->getEntity($comparativeClass);
+		if (!($item instanceof StatementListProvider)) {
 			return false; // lookup failed, probably because item doesn't exist
 		}
 
-		$subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
+		$subclassId = $this->config->get('WBQualityConstraintsSubclassOfId');
 		$statements = $item->getStatements()
-			->getByPropertyId( new NumericPropertyId( $subclassId ) )
+			->getByPropertyId(new NumericPropertyId($subclassId))
 			->getBestStatements();
 		/** @var Statement $statement */
-		foreach ( $statements as $statement ) {
+		foreach ($statements as $statement) {
 			$mainSnak = $statement->getMainSnak();
 
-			if ( !$this->hasCorrectType( $mainSnak ) ) {
+			if (!$this->hasCorrectType($mainSnak)) {
 				continue;
 			}
 			/** @var PropertyValueSnak $mainSnak */
@@ -110,11 +110,11 @@ 
 			'@phan-var EntityIdValue $dataValue';
 			$comparativeClass = $dataValue->getEntityId();
 
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
 				return true;
 			}
 
-			if ( $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked ) ) {
+			if ($this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked)) {
 				return true;
 			}
 		}
@@ -135,35 +135,35 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
 	 */
-	public function isSubclassOfWithSparqlFallback( EntityId $comparativeClass, array $classesToCheck ) {
-		$timing = $this->statsFactory->getTiming( 'isSubclassOf_duration_seconds' )
-			->setLabel( 'result', 'success' )
-			->setLabel( 'TypeCheckerImplementation', 'php' );
+	public function isSubclassOfWithSparqlFallback(EntityId $comparativeClass, array $classesToCheck) {
+		$timing = $this->statsFactory->getTiming('isSubclassOf_duration_seconds')
+			->setLabel('result', 'success')
+			->setLabel('TypeCheckerImplementation', 'php');
 		$timing->start();
 
 		try {
 			$entitiesChecked = 0;
-			$isSubclass = $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked );
+			$isSubclass = $this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked);
 			$timing->stop();
 
 			// not really a timing, but works like one (we want percentiles etc.)
 			// TODO: probably a good candidate for T348796
-			$this->statsFactory->getTiming( 'isSubclassOf_entities_total' )
-				->setLabel( 'TypeCheckerImplementation', 'php' )
-				->setLabel( 'result', 'success' )
-				->observe( $entitiesChecked );
-
-			return new CachedBool( $isSubclass, Metadata::blank() );
-		} catch ( OverflowException ) {
-			$timing->setLabel( 'result', 'overflow' )
+			$this->statsFactory->getTiming('isSubclassOf_entities_total')
+				->setLabel('TypeCheckerImplementation', 'php')
+				->setLabel('result', 'success')
+				->observe($entitiesChecked);
+
+			return new CachedBool($isSubclass, Metadata::blank());
+		} catch (OverflowException) {
+			$timing->setLabel('result', 'overflow')
 				->stop();
 
-			if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
-				$this->statsFactory->getCounter( 'sparql_typeFallback_total' )
+			if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
+				$this->statsFactory->getCounter('sparql_typeFallback_total')
 					->increment();
 
-				$timing->setLabel( 'TypeCheckerImplementation', 'sparql' )
-					->setLabel( 'result', 'success' )
+				$timing->setLabel('TypeCheckerImplementation', 'sparql')
+					->setLabel('result', 'success')
 					->start();
 
 				$hasType = $this->sparqlHelper->hasType(
@@ -175,7 +175,7 @@ 
 
 				return $hasType;
 			} else {
-				return new CachedBool( false, Metadata::blank() );
+				return new CachedBool(false, Metadata::blank());
 			}
 		}
 	}
@@ -193,13 +193,13 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
 	 */
-	public function hasClassInRelation( StatementList $statements, array $relationIds, array $classesToCheck ) {
+	public function hasClassInRelation(StatementList $statements, array $relationIds, array $classesToCheck) {
 		$metadatas = [];
 
-		foreach ( $this->getBestStatementsByPropertyIds( $statements, $relationIds ) as $statement ) {
+		foreach ($this->getBestStatementsByPropertyIds($statements, $relationIds) as $statement) {
 			$mainSnak = $statement->getMainSnak();
 
-			if ( !$this->hasCorrectType( $mainSnak ) ) {
+			if (!$this->hasCorrectType($mainSnak)) {
 				continue;
 			}
 			/** @var PropertyValueSnak $mainSnak */
@@ -209,24 +209,24 @@ 
 			'@phan-var EntityIdValue $dataValue';
 			$comparativeClass = $dataValue->getEntityId();
 
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
 				// discard $metadatas, we know this is fresh
-				return new CachedBool( true, Metadata::blank() );
+				return new CachedBool(true, Metadata::blank());
 			}
 
-			$result = $this->isSubclassOfWithSparqlFallback( $comparativeClass, $classesToCheck );
+			$result = $this->isSubclassOfWithSparqlFallback($comparativeClass, $classesToCheck);
 			$metadatas[] = $result->getMetadata();
-			if ( $result->getBool() ) {
+			if ($result->getBool()) {
 				return new CachedBool(
 					true,
-					Metadata::merge( $metadatas )
+					Metadata::merge($metadatas)
 				);
 			}
 		}
 
 		return new CachedBool(
 			false,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -235,7 +235,7 @@ 
 	 * @return bool
 	 * @phan-assert PropertyValueSnak $mainSnak
 	 */
-	private function hasCorrectType( Snak $mainSnak ) {
+	private function hasCorrectType(Snak $mainSnak) {
 		return $mainSnak instanceof PropertyValueSnak
 			&& $mainSnak->getDataValue()->getType() === 'wikibase-entityid';
 	}
@@ -252,15 +252,15 @@ 
 	) {
 		$statementArrays = [];
 
-		foreach ( $propertyIdSerializations as $propertyIdSerialization ) {
-			$propertyId = new NumericPropertyId( $propertyIdSerialization );
+		foreach ($propertyIdSerializations as $propertyIdSerialization) {
+			$propertyId = new NumericPropertyId($propertyIdSerialization);
 			$statementArrays[] = $statements
-				->getByPropertyId( $propertyId )
+				->getByPropertyId($propertyId)
 				->getBestStatements()
 				->toArray();
 		}
 
-		return array_merge( ...$statementArrays );
+		return array_merge(...$statementArrays);
 	}
 
 	/**
@@ -280,8 +280,8 @@ 
 		$relation
 	) {
 		$classes = array_map(
-			static function ( $itemIdSerialization ) {
-				return new ItemId( $itemIdSerialization );
+			static function($itemIdSerialization) {
+				return new ItemId($itemIdSerialization);
 			},
 			$classes
 		);
@@ -293,10 +293,10 @@ 
 		// wbqc-violation-message-valueType-instance
 		// wbqc-violation-message-valueType-subclass
 		// wbqc-violation-message-valueType-instanceOrSubclass
-		return ( new ViolationMessage( 'wbqc-violation-message-' . $checker . '-' . $relation ) )
-			->withEntityId( $propertyId, Role::CONSTRAINT_PROPERTY )
-			->withEntityId( $entityId, Role::SUBJECT )
-			->withEntityIdList( $classes, Role::OBJECT );
+		return (new ViolationMessage('wbqc-violation-message-'.$checker.'-'.$relation))
+			->withEntityId($propertyId, Role::CONSTRAINT_PROPERTY)
+			->withEntityId($entityId, Role::SUBJECT)
+			->withEntityIdList($classes, Role::OBJECT);
 	}
 
 }