@@ -28,31 +28,31 @@ discard block |
||
28 | 28 | use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer; |
29 | 29 | |
30 | 30 | return [ |
31 | - ConstraintsServices::EXPIRY_LOCK => function( MediaWikiServices $services ) { |
|
32 | - return new ExpiryLock( ObjectCache::getInstance( CACHE_ANYTHING ) ); |
|
31 | + ConstraintsServices::EXPIRY_LOCK => function(MediaWikiServices $services) { |
|
32 | + return new ExpiryLock(ObjectCache::getInstance(CACHE_ANYTHING)); |
|
33 | 33 | }, |
34 | 34 | |
35 | - ConstraintsServices::LOGGING_HELPER => function( MediaWikiServices $services ) { |
|
35 | + ConstraintsServices::LOGGING_HELPER => function(MediaWikiServices $services) { |
|
36 | 36 | return new LoggingHelper( |
37 | 37 | $services->getStatsdDataFactory(), |
38 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' ), |
|
38 | + LoggerFactory::getInstance('WikibaseQualityConstraints'), |
|
39 | 39 | $services->getMainConfig() |
40 | 40 | ); |
41 | 41 | }, |
42 | 42 | |
43 | - ConstraintsServices::CONSTRAINT_REPOSITORY => function( MediaWikiServices $services ) { |
|
43 | + ConstraintsServices::CONSTRAINT_REPOSITORY => function(MediaWikiServices $services) { |
|
44 | 44 | $sourceDefinitions = WikibaseRepo::getDefaultInstance()->getEntitySourceDefinitions(); |
45 | - $propertySource = $sourceDefinitions->getSourceForEntityType( Property::ENTITY_TYPE ); |
|
45 | + $propertySource = $sourceDefinitions->getSourceForEntityType(Property::ENTITY_TYPE); |
|
46 | 46 | |
47 | - return new ConstraintRepository( $services->getDBLoadBalancer(), $propertySource->getDatabaseName() ); |
|
47 | + return new ConstraintRepository($services->getDBLoadBalancer(), $propertySource->getDatabaseName()); |
|
48 | 48 | }, |
49 | 49 | |
50 | - ConstraintsServices::CONSTRAINT_LOOKUP => function( MediaWikiServices $services ) { |
|
51 | - $constraintRepository = ConstraintsServices::getConstraintRepository( $services ); |
|
52 | - return new CachingConstraintLookup( $constraintRepository ); |
|
50 | + ConstraintsServices::CONSTRAINT_LOOKUP => function(MediaWikiServices $services) { |
|
51 | + $constraintRepository = ConstraintsServices::getConstraintRepository($services); |
|
52 | + return new CachingConstraintLookup($constraintRepository); |
|
53 | 53 | }, |
54 | 54 | |
55 | - ConstraintsServices::CHECK_RESULT_SERIALIZER => function( MediaWikiServices $services ) { |
|
55 | + ConstraintsServices::CHECK_RESULT_SERIALIZER => function(MediaWikiServices $services) { |
|
56 | 56 | return new CheckResultSerializer( |
57 | 57 | new ConstraintSerializer( |
58 | 58 | false // constraint parameters are not exposed |
@@ -63,7 +63,7 @@ discard block |
||
63 | 63 | ); |
64 | 64 | }, |
65 | 65 | |
66 | - ConstraintsServices::CHECK_RESULT_DESERIALIZER => function( MediaWikiServices $services ) { |
|
66 | + ConstraintsServices::CHECK_RESULT_DESERIALIZER => function(MediaWikiServices $services) { |
|
67 | 67 | // TODO in the future, get EntityIdParser and DataValueFactory from $services? |
68 | 68 | $repo = WikibaseRepo::getDefaultInstance(); |
69 | 69 | $entityIdParser = $repo->getEntityIdParser(); |
@@ -80,11 +80,11 @@ discard block |
||
80 | 80 | ); |
81 | 81 | }, |
82 | 82 | |
83 | - ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function( MediaWikiServices $services ) { |
|
83 | + ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function(MediaWikiServices $services) { |
|
84 | 84 | return new ViolationMessageSerializer(); |
85 | 85 | }, |
86 | 86 | |
87 | - ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function( MediaWikiServices $services ) { |
|
87 | + ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function(MediaWikiServices $services) { |
|
88 | 88 | // TODO in the future, get EntityIdParser and DataValueFactory from $services? |
89 | 89 | $repo = WikibaseRepo::getDefaultInstance(); |
90 | 90 | $entityIdParser = $repo->getEntityIdParser(); |
@@ -96,7 +96,7 @@ discard block |
||
96 | 96 | ); |
97 | 97 | }, |
98 | 98 | |
99 | - ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function( MediaWikiServices $services ) { |
|
99 | + ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function(MediaWikiServices $services) { |
|
100 | 100 | // TODO in the future, get DeserializerFactory and entity source definitions from $services? |
101 | 101 | $repo = WikibaseRepo::getDefaultInstance(); |
102 | 102 | $deserializerFactory = $repo->getBaseDataModelDeserializerFactory(); |
@@ -105,15 +105,15 @@ discard block |
||
105 | 105 | return new ConstraintParameterParser( |
106 | 106 | $services->getMainConfig(), |
107 | 107 | $deserializerFactory, |
108 | - $entitySourceDefinitions->getSourceForEntityType( 'item' )->getConceptBaseUri() |
|
108 | + $entitySourceDefinitions->getSourceForEntityType('item')->getConceptBaseUri() |
|
109 | 109 | ); |
110 | 110 | }, |
111 | 111 | |
112 | - ConstraintsServices::CONNECTION_CHECKER_HELPER => function( MediaWikiServices $services ) { |
|
112 | + ConstraintsServices::CONNECTION_CHECKER_HELPER => function(MediaWikiServices $services) { |
|
113 | 113 | return new ConnectionCheckerHelper(); |
114 | 114 | }, |
115 | 115 | |
116 | - ConstraintsServices::RANGE_CHECKER_HELPER => function( MediaWikiServices $services ) { |
|
116 | + ConstraintsServices::RANGE_CHECKER_HELPER => function(MediaWikiServices $services) { |
|
117 | 117 | // TODO in the future, get UnitConverter from $services? |
118 | 118 | $repo = WikibaseRepo::getDefaultInstance(); |
119 | 119 | $unitConverter = $repo->getUnitConverter(); |
@@ -124,9 +124,9 @@ discard block |
||
124 | 124 | ); |
125 | 125 | }, |
126 | 126 | |
127 | - ConstraintsServices::SPARQL_HELPER => function( MediaWikiServices $services ) { |
|
128 | - $endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' ); |
|
129 | - if ( $endpoint === '' ) { |
|
127 | + ConstraintsServices::SPARQL_HELPER => function(MediaWikiServices $services) { |
|
128 | + $endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint'); |
|
129 | + if ($endpoint === '') { |
|
130 | 130 | return new DummySparqlHelper(); |
131 | 131 | } |
132 | 132 | |
@@ -142,117 +142,117 @@ discard block |
||
142 | 142 | $entityIdParser, |
143 | 143 | $propertyDataTypeLookup, |
144 | 144 | $services->getMainWANObjectCache(), |
145 | - ConstraintsServices::getViolationMessageSerializer( $services ), |
|
146 | - ConstraintsServices::getViolationMessageDeserializer( $services ), |
|
145 | + ConstraintsServices::getViolationMessageSerializer($services), |
|
146 | + ConstraintsServices::getViolationMessageDeserializer($services), |
|
147 | 147 | $services->getStatsdDataFactory(), |
148 | - ConstraintsServices::getExpiryLock( $services ), |
|
148 | + ConstraintsServices::getExpiryLock($services), |
|
149 | 149 | ConstraintsServices::getLoggingHelper(), |
150 | - wfWikiID() . ' WikibaseQualityConstraints ' . Http::userAgent(), |
|
150 | + wfWikiID().' WikibaseQualityConstraints '.Http::userAgent(), |
|
151 | 151 | $services->getHttpRequestFactory() |
152 | 152 | ); |
153 | 153 | }, |
154 | 154 | |
155 | - ConstraintsServices::TYPE_CHECKER_HELPER => function( MediaWikiServices $services ) { |
|
155 | + ConstraintsServices::TYPE_CHECKER_HELPER => function(MediaWikiServices $services) { |
|
156 | 156 | return new TypeCheckerHelper( |
157 | - WikibaseServices::getEntityLookup( $services ), |
|
157 | + WikibaseServices::getEntityLookup($services), |
|
158 | 158 | $services->getMainConfig(), |
159 | - ConstraintsServices::getSparqlHelper( $services ), |
|
159 | + ConstraintsServices::getSparqlHelper($services), |
|
160 | 160 | $services->getStatsdDataFactory() |
161 | 161 | ); |
162 | 162 | }, |
163 | 163 | |
164 | - ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function( MediaWikiServices $services ) { |
|
164 | + ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function(MediaWikiServices $services) { |
|
165 | 165 | // TODO in the future, get StatementGuidParser from $services? |
166 | 166 | $repo = WikibaseRepo::getDefaultInstance(); |
167 | 167 | $statementGuidParser = $repo->getStatementGuidParser(); |
168 | 168 | |
169 | 169 | $config = $services->getMainConfig(); |
170 | 170 | $checkerMap = [ |
171 | - $config->get( 'WBQualityConstraintsConflictsWithConstraintId' ) |
|
172 | - => ConstraintCheckerServices::getConflictsWithChecker( $services ), |
|
173 | - $config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' ) |
|
174 | - => ConstraintCheckerServices::getItemChecker( $services ), |
|
175 | - $config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' ) |
|
176 | - => ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ), |
|
177 | - $config->get( 'WBQualityConstraintsSymmetricConstraintId' ) |
|
178 | - => ConstraintCheckerServices::getSymmetricChecker( $services ), |
|
179 | - $config->get( 'WBQualityConstraintsInverseConstraintId' ) |
|
180 | - => ConstraintCheckerServices::getInverseChecker( $services ), |
|
181 | - $config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' ) |
|
182 | - => ConstraintCheckerServices::getQualifierChecker( $services ), |
|
183 | - $config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' ) |
|
184 | - => ConstraintCheckerServices::getQualifiersChecker( $services ), |
|
185 | - $config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' ) |
|
186 | - => ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ), |
|
187 | - $config->get( 'WBQualityConstraintsRangeConstraintId' ) |
|
188 | - => ConstraintCheckerServices::getRangeChecker( $services ), |
|
189 | - $config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' ) |
|
190 | - => ConstraintCheckerServices::getDiffWithinRangeChecker( $services ), |
|
191 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ) |
|
192 | - => ConstraintCheckerServices::getTypeChecker( $services ), |
|
193 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ) |
|
194 | - => ConstraintCheckerServices::getValueTypeChecker( $services ), |
|
195 | - $config->get( 'WBQualityConstraintsSingleValueConstraintId' ) |
|
196 | - => ConstraintCheckerServices::getSingleValueChecker( $services ), |
|
197 | - $config->get( 'WBQualityConstraintsMultiValueConstraintId' ) |
|
198 | - => ConstraintCheckerServices::getMultiValueChecker( $services ), |
|
199 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ) |
|
200 | - => ConstraintCheckerServices::getUniqueValueChecker( $services ), |
|
201 | - $config->get( 'WBQualityConstraintsFormatConstraintId' ) |
|
202 | - => ConstraintCheckerServices::getFormatChecker( $services ), |
|
203 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ) |
|
204 | - => ConstraintCheckerServices::getCommonsLinkChecker( $services ), |
|
205 | - $config->get( 'WBQualityConstraintsOneOfConstraintId' ) |
|
206 | - => ConstraintCheckerServices::getOneOfChecker( $services ), |
|
207 | - $config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' ) |
|
208 | - => ConstraintCheckerServices::getValueOnlyChecker( $services ), |
|
209 | - $config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' ) |
|
210 | - => ConstraintCheckerServices::getReferenceChecker( $services ), |
|
211 | - $config->get( 'WBQualityConstraintsNoBoundsConstraintId' ) |
|
212 | - => ConstraintCheckerServices::getNoBoundsChecker( $services ), |
|
213 | - $config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' ) |
|
214 | - => ConstraintCheckerServices::getAllowedUnitsChecker( $services ), |
|
215 | - $config->get( 'WBQualityConstraintsSingleBestValueConstraintId' ) |
|
216 | - => ConstraintCheckerServices::getSingleBestValueChecker( $services ), |
|
217 | - $config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' ) |
|
218 | - => ConstraintCheckerServices::getEntityTypeChecker( $services ), |
|
219 | - $config->get( 'WBQualityConstraintsNoneOfConstraintId' ) |
|
220 | - => ConstraintCheckerServices::getNoneOfChecker( $services ), |
|
221 | - $config->get( 'WBQualityConstraintsIntegerConstraintId' ) |
|
222 | - => ConstraintCheckerServices::getIntegerChecker( $services ), |
|
223 | - $config->get( 'WBQualityConstraintsCitationNeededConstraintId' ) |
|
224 | - => ConstraintCheckerServices::getCitationNeededChecker( $services ), |
|
225 | - $config->get( 'WBQualityConstraintsPropertyScopeConstraintId' ) |
|
226 | - => ConstraintCheckerServices::getPropertyScopeChecker( $services ), |
|
227 | - $config->get( 'WBQualityConstraintsContemporaryConstraintId' ) |
|
228 | - => ConstraintCheckerServices::getContemporaryChecker( $services ), |
|
171 | + $config->get('WBQualityConstraintsConflictsWithConstraintId') |
|
172 | + => ConstraintCheckerServices::getConflictsWithChecker($services), |
|
173 | + $config->get('WBQualityConstraintsItemRequiresClaimConstraintId') |
|
174 | + => ConstraintCheckerServices::getItemChecker($services), |
|
175 | + $config->get('WBQualityConstraintsValueRequiresClaimConstraintId') |
|
176 | + => ConstraintCheckerServices::getTargetRequiredClaimChecker($services), |
|
177 | + $config->get('WBQualityConstraintsSymmetricConstraintId') |
|
178 | + => ConstraintCheckerServices::getSymmetricChecker($services), |
|
179 | + $config->get('WBQualityConstraintsInverseConstraintId') |
|
180 | + => ConstraintCheckerServices::getInverseChecker($services), |
|
181 | + $config->get('WBQualityConstraintsUsedAsQualifierConstraintId') |
|
182 | + => ConstraintCheckerServices::getQualifierChecker($services), |
|
183 | + $config->get('WBQualityConstraintsAllowedQualifiersConstraintId') |
|
184 | + => ConstraintCheckerServices::getQualifiersChecker($services), |
|
185 | + $config->get('WBQualityConstraintsMandatoryQualifierConstraintId') |
|
186 | + => ConstraintCheckerServices::getMandatoryQualifiersChecker($services), |
|
187 | + $config->get('WBQualityConstraintsRangeConstraintId') |
|
188 | + => ConstraintCheckerServices::getRangeChecker($services), |
|
189 | + $config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId') |
|
190 | + => ConstraintCheckerServices::getDiffWithinRangeChecker($services), |
|
191 | + $config->get('WBQualityConstraintsTypeConstraintId') |
|
192 | + => ConstraintCheckerServices::getTypeChecker($services), |
|
193 | + $config->get('WBQualityConstraintsValueTypeConstraintId') |
|
194 | + => ConstraintCheckerServices::getValueTypeChecker($services), |
|
195 | + $config->get('WBQualityConstraintsSingleValueConstraintId') |
|
196 | + => ConstraintCheckerServices::getSingleValueChecker($services), |
|
197 | + $config->get('WBQualityConstraintsMultiValueConstraintId') |
|
198 | + => ConstraintCheckerServices::getMultiValueChecker($services), |
|
199 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId') |
|
200 | + => ConstraintCheckerServices::getUniqueValueChecker($services), |
|
201 | + $config->get('WBQualityConstraintsFormatConstraintId') |
|
202 | + => ConstraintCheckerServices::getFormatChecker($services), |
|
203 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId') |
|
204 | + => ConstraintCheckerServices::getCommonsLinkChecker($services), |
|
205 | + $config->get('WBQualityConstraintsOneOfConstraintId') |
|
206 | + => ConstraintCheckerServices::getOneOfChecker($services), |
|
207 | + $config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId') |
|
208 | + => ConstraintCheckerServices::getValueOnlyChecker($services), |
|
209 | + $config->get('WBQualityConstraintsUsedAsReferenceConstraintId') |
|
210 | + => ConstraintCheckerServices::getReferenceChecker($services), |
|
211 | + $config->get('WBQualityConstraintsNoBoundsConstraintId') |
|
212 | + => ConstraintCheckerServices::getNoBoundsChecker($services), |
|
213 | + $config->get('WBQualityConstraintsAllowedUnitsConstraintId') |
|
214 | + => ConstraintCheckerServices::getAllowedUnitsChecker($services), |
|
215 | + $config->get('WBQualityConstraintsSingleBestValueConstraintId') |
|
216 | + => ConstraintCheckerServices::getSingleBestValueChecker($services), |
|
217 | + $config->get('WBQualityConstraintsAllowedEntityTypesConstraintId') |
|
218 | + => ConstraintCheckerServices::getEntityTypeChecker($services), |
|
219 | + $config->get('WBQualityConstraintsNoneOfConstraintId') |
|
220 | + => ConstraintCheckerServices::getNoneOfChecker($services), |
|
221 | + $config->get('WBQualityConstraintsIntegerConstraintId') |
|
222 | + => ConstraintCheckerServices::getIntegerChecker($services), |
|
223 | + $config->get('WBQualityConstraintsCitationNeededConstraintId') |
|
224 | + => ConstraintCheckerServices::getCitationNeededChecker($services), |
|
225 | + $config->get('WBQualityConstraintsPropertyScopeConstraintId') |
|
226 | + => ConstraintCheckerServices::getPropertyScopeChecker($services), |
|
227 | + $config->get('WBQualityConstraintsContemporaryConstraintId') |
|
228 | + => ConstraintCheckerServices::getContemporaryChecker($services), |
|
229 | 229 | ]; |
230 | 230 | |
231 | 231 | return new DelegatingConstraintChecker( |
232 | - WikibaseServices::getEntityLookup( $services ), |
|
232 | + WikibaseServices::getEntityLookup($services), |
|
233 | 233 | $checkerMap, |
234 | - ConstraintsServices::getConstraintLookup( $services ), |
|
235 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
234 | + ConstraintsServices::getConstraintLookup($services), |
|
235 | + ConstraintsServices::getConstraintParameterParser($services), |
|
236 | 236 | $statementGuidParser, |
237 | - ConstraintsServices::getLoggingHelper( $services ), |
|
238 | - $config->get( 'WBQualityConstraintsCheckQualifiers' ), |
|
239 | - $config->get( 'WBQualityConstraintsCheckReferences' ), |
|
240 | - $config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' ) |
|
237 | + ConstraintsServices::getLoggingHelper($services), |
|
238 | + $config->get('WBQualityConstraintsCheckQualifiers'), |
|
239 | + $config->get('WBQualityConstraintsCheckReferences'), |
|
240 | + $config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers') |
|
241 | 241 | ); |
242 | 242 | }, |
243 | 243 | |
244 | - ConstraintsServices::RESULTS_SOURCE => function( MediaWikiServices $services ) { |
|
244 | + ConstraintsServices::RESULTS_SOURCE => function(MediaWikiServices $services) { |
|
245 | 245 | $config = $services->getMainConfig(); |
246 | 246 | $resultsSource = new CheckingResultsSource( |
247 | - ConstraintsServices::getDelegatingConstraintChecker( $services ) |
|
247 | + ConstraintsServices::getDelegatingConstraintChecker($services) |
|
248 | 248 | ); |
249 | 249 | |
250 | - if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) { |
|
250 | + if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) { |
|
251 | 251 | $possiblyStaleConstraintTypes = [ |
252 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ), |
|
253 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ), |
|
254 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ), |
|
255 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ), |
|
252 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId'), |
|
253 | + $config->get('WBQualityConstraintsTypeConstraintId'), |
|
254 | + $config->get('WBQualityConstraintsValueTypeConstraintId'), |
|
255 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId'), |
|
256 | 256 | ]; |
257 | 257 | // TODO in the future, get EntityIdParser and WikiPageEntityMetaDataAccessor from $services? |
258 | 258 | $repo = WikibaseRepo::getDefaultInstance(); |
@@ -262,14 +262,14 @@ discard block |
||
262 | 262 | $resultsSource = new CachingResultsSource( |
263 | 263 | $resultsSource, |
264 | 264 | ResultsCache::getDefaultInstance(), |
265 | - ConstraintsServices::getCheckResultSerializer( $services ), |
|
266 | - ConstraintsServices::getCheckResultDeserializer( $services ), |
|
265 | + ConstraintsServices::getCheckResultSerializer($services), |
|
266 | + ConstraintsServices::getCheckResultDeserializer($services), |
|
267 | 267 | $wikiPageEntityMetaDataAccessor, |
268 | 268 | $entityIdParser, |
269 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ), |
|
269 | + $config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'), |
|
270 | 270 | $possiblyStaleConstraintTypes, |
271 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ), |
|
272 | - ConstraintsServices::getLoggingHelper( $services ) |
|
271 | + $config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'), |
|
272 | + ConstraintsServices::getLoggingHelper($services) |
|
273 | 273 | ); |
274 | 274 | } |
275 | 275 |
@@ -77,15 +77,15 @@ discard block |
||
77 | 77 | * @param array $parameters |
78 | 78 | * @throws ConstraintParameterException |
79 | 79 | */ |
80 | - public function checkError( array $parameters ) { |
|
81 | - if ( array_key_exists( '@error', $parameters ) ) { |
|
80 | + public function checkError(array $parameters) { |
|
81 | + if (array_key_exists('@error', $parameters)) { |
|
82 | 82 | $error = $parameters['@error']; |
83 | - if ( array_key_exists( 'toolong', $error ) && $error['toolong'] ) { |
|
83 | + if (array_key_exists('toolong', $error) && $error['toolong']) { |
|
84 | 84 | $msg = 'wbqc-violation-message-parameters-error-toolong'; |
85 | 85 | } else { |
86 | 86 | $msg = 'wbqc-violation-message-parameters-error-unknown'; |
87 | 87 | } |
88 | - throw new ConstraintParameterException( new ViolationMessage( $msg ) ); |
|
88 | + throw new ConstraintParameterException(new ViolationMessage($msg)); |
|
89 | 89 | } |
90 | 90 | } |
91 | 91 | |
@@ -95,11 +95,11 @@ discard block |
||
95 | 95 | * @param string $parameterId |
96 | 96 | * @throws ConstraintParameterException |
97 | 97 | */ |
98 | - private function requireSingleParameter( array $parameters, $parameterId ) { |
|
99 | - if ( count( $parameters[$parameterId] ) !== 1 ) { |
|
98 | + private function requireSingleParameter(array $parameters, $parameterId) { |
|
99 | + if (count($parameters[$parameterId]) !== 1) { |
|
100 | 100 | throw new ConstraintParameterException( |
101 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-single' ) ) |
|
102 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
101 | + (new ViolationMessage('wbqc-violation-message-parameter-single')) |
|
102 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
103 | 103 | ); |
104 | 104 | } |
105 | 105 | } |
@@ -111,11 +111,11 @@ discard block |
||
111 | 111 | * @return void |
112 | 112 | * @throws ConstraintParameterException |
113 | 113 | */ |
114 | - private function requireValueParameter( Snak $snak, $parameterId ) { |
|
115 | - if ( !( $snak instanceof PropertyValueSnak ) ) { |
|
114 | + private function requireValueParameter(Snak $snak, $parameterId) { |
|
115 | + if (!($snak instanceof PropertyValueSnak)) { |
|
116 | 116 | throw new ConstraintParameterException( |
117 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) ) |
|
118 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
117 | + (new ViolationMessage('wbqc-violation-message-parameter-value')) |
|
118 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
119 | 119 | ); |
120 | 120 | } |
121 | 121 | } |
@@ -127,17 +127,17 @@ discard block |
||
127 | 127 | * @throws ConstraintParameterException |
128 | 128 | * @return EntityId |
129 | 129 | */ |
130 | - private function parseEntityIdParameter( array $snakSerialization, $parameterId ) { |
|
131 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
132 | - $this->requireValueParameter( $snak, $parameterId ); |
|
130 | + private function parseEntityIdParameter(array $snakSerialization, $parameterId) { |
|
131 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
132 | + $this->requireValueParameter($snak, $parameterId); |
|
133 | 133 | $value = $snak->getDataValue(); |
134 | - if ( $value instanceof EntityIdValue ) { |
|
134 | + if ($value instanceof EntityIdValue) { |
|
135 | 135 | return $value->getEntityId(); |
136 | 136 | } else { |
137 | 137 | throw new ConstraintParameterException( |
138 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-entity' ) ) |
|
139 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
140 | - ->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
138 | + (new ViolationMessage('wbqc-violation-message-parameter-entity')) |
|
139 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
140 | + ->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
141 | 141 | ); |
142 | 142 | } |
143 | 143 | } |
@@ -148,20 +148,20 @@ discard block |
||
148 | 148 | * @throws ConstraintParameterException if the parameter is invalid or missing |
149 | 149 | * @return string[] class entity ID serializations |
150 | 150 | */ |
151 | - public function parseClassParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
152 | - $this->checkError( $constraintParameters ); |
|
153 | - $classId = $this->config->get( 'WBQualityConstraintsClassId' ); |
|
154 | - if ( !array_key_exists( $classId, $constraintParameters ) ) { |
|
151 | + public function parseClassParameter(array $constraintParameters, $constraintTypeItemId) { |
|
152 | + $this->checkError($constraintParameters); |
|
153 | + $classId = $this->config->get('WBQualityConstraintsClassId'); |
|
154 | + if (!array_key_exists($classId, $constraintParameters)) { |
|
155 | 155 | throw new ConstraintParameterException( |
156 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
157 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
158 | - ->withEntityId( new PropertyId( $classId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
156 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
157 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
158 | + ->withEntityId(new PropertyId($classId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
159 | 159 | ); |
160 | 160 | } |
161 | 161 | |
162 | 162 | $classes = []; |
163 | - foreach ( $constraintParameters[$classId] as $class ) { |
|
164 | - $classes[] = $this->parseEntityIdParameter( $class, $classId )->getSerialization(); |
|
163 | + foreach ($constraintParameters[$classId] as $class) { |
|
164 | + $classes[] = $this->parseEntityIdParameter($class, $classId)->getSerialization(); |
|
165 | 165 | } |
166 | 166 | return $classes; |
167 | 167 | } |
@@ -172,23 +172,23 @@ discard block |
||
172 | 172 | * @throws ConstraintParameterException if the parameter is invalid or missing |
173 | 173 | * @return string 'instance', 'subclass', or 'instanceOrSubclass' |
174 | 174 | */ |
175 | - public function parseRelationParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
176 | - $this->checkError( $constraintParameters ); |
|
177 | - $relationId = $this->config->get( 'WBQualityConstraintsRelationId' ); |
|
178 | - if ( !array_key_exists( $relationId, $constraintParameters ) ) { |
|
175 | + public function parseRelationParameter(array $constraintParameters, $constraintTypeItemId) { |
|
176 | + $this->checkError($constraintParameters); |
|
177 | + $relationId = $this->config->get('WBQualityConstraintsRelationId'); |
|
178 | + if (!array_key_exists($relationId, $constraintParameters)) { |
|
179 | 179 | throw new ConstraintParameterException( |
180 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
181 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
182 | - ->withEntityId( new PropertyId( $relationId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
180 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
181 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
182 | + ->withEntityId(new PropertyId($relationId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
183 | 183 | ); |
184 | 184 | } |
185 | 185 | |
186 | - $this->requireSingleParameter( $constraintParameters, $relationId ); |
|
187 | - $relationEntityId = $this->parseEntityIdParameter( $constraintParameters[$relationId][0], $relationId ); |
|
188 | - $instanceId = $this->config->get( 'WBQualityConstraintsInstanceOfRelationId' ); |
|
189 | - $subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfRelationId' ); |
|
190 | - $instanceOrSubclassId = $this->config->get( 'WBQualityConstraintsInstanceOrSubclassOfRelationId' ); |
|
191 | - switch ( $relationEntityId ) { |
|
186 | + $this->requireSingleParameter($constraintParameters, $relationId); |
|
187 | + $relationEntityId = $this->parseEntityIdParameter($constraintParameters[$relationId][0], $relationId); |
|
188 | + $instanceId = $this->config->get('WBQualityConstraintsInstanceOfRelationId'); |
|
189 | + $subclassId = $this->config->get('WBQualityConstraintsSubclassOfRelationId'); |
|
190 | + $instanceOrSubclassId = $this->config->get('WBQualityConstraintsInstanceOrSubclassOfRelationId'); |
|
191 | + switch ($relationEntityId) { |
|
192 | 192 | case $instanceId: |
193 | 193 | return 'instance'; |
194 | 194 | case $subclassId: |
@@ -197,13 +197,13 @@ discard block |
||
197 | 197 | return 'instanceOrSubclass'; |
198 | 198 | default: |
199 | 199 | throw new ConstraintParameterException( |
200 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
201 | - ->withEntityId( new PropertyId( $relationId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
200 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
201 | + ->withEntityId(new PropertyId($relationId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
202 | 202 | ->withEntityIdList( |
203 | 203 | [ |
204 | - new ItemId( $instanceId ), |
|
205 | - new ItemId( $subclassId ), |
|
206 | - new ItemId( $instanceOrSubclassId ), |
|
204 | + new ItemId($instanceId), |
|
205 | + new ItemId($subclassId), |
|
206 | + new ItemId($instanceOrSubclassId), |
|
207 | 207 | ], |
208 | 208 | Role::CONSTRAINT_PARAMETER_VALUE |
209 | 209 | ) |
@@ -218,20 +218,20 @@ discard block |
||
218 | 218 | * @throws ConstraintParameterException |
219 | 219 | * @return PropertyId |
220 | 220 | */ |
221 | - private function parsePropertyIdParameter( array $snakSerialization, $parameterId ) { |
|
222 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
223 | - $this->requireValueParameter( $snak, $parameterId ); |
|
221 | + private function parsePropertyIdParameter(array $snakSerialization, $parameterId) { |
|
222 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
223 | + $this->requireValueParameter($snak, $parameterId); |
|
224 | 224 | $value = $snak->getDataValue(); |
225 | - if ( $value instanceof EntityIdValue ) { |
|
225 | + if ($value instanceof EntityIdValue) { |
|
226 | 226 | $id = $value->getEntityId(); |
227 | - if ( $id instanceof PropertyId ) { |
|
227 | + if ($id instanceof PropertyId) { |
|
228 | 228 | return $id; |
229 | 229 | } |
230 | 230 | } |
231 | 231 | throw new ConstraintParameterException( |
232 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-property' ) ) |
|
233 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
234 | - ->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
232 | + (new ViolationMessage('wbqc-violation-message-parameter-property')) |
|
233 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
234 | + ->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
235 | 235 | ); |
236 | 236 | } |
237 | 237 | |
@@ -242,33 +242,33 @@ discard block |
||
242 | 242 | * @throws ConstraintParameterException if the parameter is invalid or missing |
243 | 243 | * @return PropertyId |
244 | 244 | */ |
245 | - public function parsePropertyParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
246 | - $this->checkError( $constraintParameters ); |
|
247 | - $propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' ); |
|
248 | - if ( !array_key_exists( $propertyId, $constraintParameters ) ) { |
|
245 | + public function parsePropertyParameter(array $constraintParameters, $constraintTypeItemId) { |
|
246 | + $this->checkError($constraintParameters); |
|
247 | + $propertyId = $this->config->get('WBQualityConstraintsPropertyId'); |
|
248 | + if (!array_key_exists($propertyId, $constraintParameters)) { |
|
249 | 249 | throw new ConstraintParameterException( |
250 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
251 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
252 | - ->withEntityId( new PropertyId( $propertyId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
250 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
251 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
252 | + ->withEntityId(new PropertyId($propertyId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
253 | 253 | ); |
254 | 254 | } |
255 | 255 | |
256 | - $this->requireSingleParameter( $constraintParameters, $propertyId ); |
|
257 | - return $this->parsePropertyIdParameter( $constraintParameters[$propertyId][0], $propertyId ); |
|
256 | + $this->requireSingleParameter($constraintParameters, $propertyId); |
|
257 | + return $this->parsePropertyIdParameter($constraintParameters[$propertyId][0], $propertyId); |
|
258 | 258 | } |
259 | 259 | |
260 | - private function parseItemIdParameter( PropertyValueSnak $snak, $parameterId ) { |
|
260 | + private function parseItemIdParameter(PropertyValueSnak $snak, $parameterId) { |
|
261 | 261 | $dataValue = $snak->getDataValue(); |
262 | - if ( $dataValue instanceof EntityIdValue ) { |
|
262 | + if ($dataValue instanceof EntityIdValue) { |
|
263 | 263 | $entityId = $dataValue->getEntityId(); |
264 | - if ( $entityId instanceof ItemId ) { |
|
265 | - return ItemIdSnakValue::fromItemId( $entityId ); |
|
264 | + if ($entityId instanceof ItemId) { |
|
265 | + return ItemIdSnakValue::fromItemId($entityId); |
|
266 | 266 | } |
267 | 267 | } |
268 | 268 | throw new ConstraintParameterException( |
269 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-item' ) ) |
|
270 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
271 | - ->withDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
269 | + (new ViolationMessage('wbqc-violation-message-parameter-item')) |
|
270 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
271 | + ->withDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE) |
|
272 | 272 | ); |
273 | 273 | } |
274 | 274 | |
@@ -286,16 +286,16 @@ discard block |
||
286 | 286 | $required, |
287 | 287 | $parameterId = null |
288 | 288 | ) { |
289 | - $this->checkError( $constraintParameters ); |
|
290 | - if ( $parameterId === null ) { |
|
291 | - $parameterId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
289 | + $this->checkError($constraintParameters); |
|
290 | + if ($parameterId === null) { |
|
291 | + $parameterId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
292 | 292 | } |
293 | - if ( !array_key_exists( $parameterId, $constraintParameters ) ) { |
|
294 | - if ( $required ) { |
|
293 | + if (!array_key_exists($parameterId, $constraintParameters)) { |
|
294 | + if ($required) { |
|
295 | 295 | throw new ConstraintParameterException( |
296 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
297 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
298 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
296 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
297 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
298 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
299 | 299 | ); |
300 | 300 | } else { |
301 | 301 | return []; |
@@ -303,11 +303,11 @@ discard block |
||
303 | 303 | } |
304 | 304 | |
305 | 305 | $values = []; |
306 | - foreach ( $constraintParameters[$parameterId] as $parameter ) { |
|
307 | - $snak = $this->snakDeserializer->deserialize( $parameter ); |
|
308 | - switch ( true ) { |
|
306 | + foreach ($constraintParameters[$parameterId] as $parameter) { |
|
307 | + $snak = $this->snakDeserializer->deserialize($parameter); |
|
308 | + switch (true) { |
|
309 | 309 | case $snak instanceof PropertyValueSnak: |
310 | - $values[] = $this->parseItemIdParameter( $snak, $parameterId ); |
|
310 | + $values[] = $this->parseItemIdParameter($snak, $parameterId); |
|
311 | 311 | break; |
312 | 312 | case $snak instanceof PropertySomeValueSnak: |
313 | 313 | $values[] = ItemIdSnakValue::someValue(); |
@@ -326,27 +326,27 @@ discard block |
||
326 | 326 | * @throws ConstraintParameterException if the parameter is invalid or missing |
327 | 327 | * @return PropertyId[] |
328 | 328 | */ |
329 | - public function parsePropertiesParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
330 | - $this->checkError( $constraintParameters ); |
|
331 | - $propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' ); |
|
332 | - if ( !array_key_exists( $propertyId, $constraintParameters ) ) { |
|
329 | + public function parsePropertiesParameter(array $constraintParameters, $constraintTypeItemId) { |
|
330 | + $this->checkError($constraintParameters); |
|
331 | + $propertyId = $this->config->get('WBQualityConstraintsPropertyId'); |
|
332 | + if (!array_key_exists($propertyId, $constraintParameters)) { |
|
333 | 333 | throw new ConstraintParameterException( |
334 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
335 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
336 | - ->withEntityId( new PropertyId( $propertyId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
334 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
335 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
336 | + ->withEntityId(new PropertyId($propertyId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
337 | 337 | ); |
338 | 338 | } |
339 | 339 | |
340 | 340 | $parameters = $constraintParameters[$propertyId]; |
341 | - if ( count( $parameters ) === 1 && |
|
342 | - $this->snakDeserializer->deserialize( $parameters[0] ) instanceof PropertyNoValueSnak |
|
341 | + if (count($parameters) === 1 && |
|
342 | + $this->snakDeserializer->deserialize($parameters[0]) instanceof PropertyNoValueSnak |
|
343 | 343 | ) { |
344 | 344 | return []; |
345 | 345 | } |
346 | 346 | |
347 | 347 | $properties = []; |
348 | - foreach ( $parameters as $parameter ) { |
|
349 | - $properties[] = $this->parsePropertyIdParameter( $parameter, $propertyId ); |
|
348 | + foreach ($parameters as $parameter) { |
|
349 | + $properties[] = $this->parsePropertyIdParameter($parameter, $propertyId); |
|
350 | 350 | } |
351 | 351 | return $properties; |
352 | 352 | } |
@@ -357,16 +357,16 @@ discard block |
||
357 | 357 | * @throws ConstraintParameterException |
358 | 358 | * @return DataValue|null |
359 | 359 | */ |
360 | - private function parseValueOrNoValueParameter( array $snakSerialization, $parameterId ) { |
|
361 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
362 | - if ( $snak instanceof PropertyValueSnak ) { |
|
360 | + private function parseValueOrNoValueParameter(array $snakSerialization, $parameterId) { |
|
361 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
362 | + if ($snak instanceof PropertyValueSnak) { |
|
363 | 363 | return $snak->getDataValue(); |
364 | - } elseif ( $snak instanceof PropertyNoValueSnak ) { |
|
364 | + } elseif ($snak instanceof PropertyNoValueSnak) { |
|
365 | 365 | return null; |
366 | 366 | } else { |
367 | 367 | throw new ConstraintParameterException( |
368 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value-or-novalue' ) ) |
|
369 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
368 | + (new ViolationMessage('wbqc-violation-message-parameter-value-or-novalue')) |
|
369 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
370 | 370 | ); |
371 | 371 | } |
372 | 372 | } |
@@ -376,10 +376,10 @@ discard block |
||
376 | 376 | * @param string $parameterId |
377 | 377 | * @return DataValue|null |
378 | 378 | */ |
379 | - private function parseValueOrNoValueOrNowParameter( array $snakSerialization, $parameterId ) { |
|
379 | + private function parseValueOrNoValueOrNowParameter(array $snakSerialization, $parameterId) { |
|
380 | 380 | try { |
381 | - return $this->parseValueOrNoValueParameter( $snakSerialization, $parameterId ); |
|
382 | - } catch ( ConstraintParameterException $e ) { |
|
381 | + return $this->parseValueOrNoValueParameter($snakSerialization, $parameterId); |
|
382 | + } catch (ConstraintParameterException $e) { |
|
383 | 383 | // unknown value means “now” |
384 | 384 | return new NowValue(); |
385 | 385 | } |
@@ -392,14 +392,14 @@ discard block |
||
392 | 392 | * @param string $unit |
393 | 393 | * @return bool |
394 | 394 | */ |
395 | - private function exactlyOneQuantityWithUnit( ?DataValue $min, ?DataValue $max, $unit ) { |
|
396 | - if ( !( $min instanceof UnboundedQuantityValue ) || |
|
397 | - !( $max instanceof UnboundedQuantityValue ) |
|
395 | + private function exactlyOneQuantityWithUnit(?DataValue $min, ?DataValue $max, $unit) { |
|
396 | + if (!($min instanceof UnboundedQuantityValue) || |
|
397 | + !($max instanceof UnboundedQuantityValue) |
|
398 | 398 | ) { |
399 | 399 | return false; |
400 | 400 | } |
401 | 401 | |
402 | - return ( $min->getUnit() === $unit ) !== ( $max->getUnit() === $unit ); |
|
402 | + return ($min->getUnit() === $unit) !== ($max->getUnit() === $unit); |
|
403 | 403 | } |
404 | 404 | |
405 | 405 | /** |
@@ -412,42 +412,42 @@ discard block |
||
412 | 412 | * @throws ConstraintParameterException if the parameter is invalid or missing |
413 | 413 | * @return DataValue[] if the parameter is invalid or missing |
414 | 414 | */ |
415 | - private function parseRangeParameter( array $constraintParameters, $minimumId, $maximumId, $constraintTypeItemId, $type ) { |
|
416 | - $this->checkError( $constraintParameters ); |
|
417 | - if ( !array_key_exists( $minimumId, $constraintParameters ) || |
|
418 | - !array_key_exists( $maximumId, $constraintParameters ) |
|
415 | + private function parseRangeParameter(array $constraintParameters, $minimumId, $maximumId, $constraintTypeItemId, $type) { |
|
416 | + $this->checkError($constraintParameters); |
|
417 | + if (!array_key_exists($minimumId, $constraintParameters) || |
|
418 | + !array_key_exists($maximumId, $constraintParameters) |
|
419 | 419 | ) { |
420 | 420 | throw new ConstraintParameterException( |
421 | - ( new ViolationMessage( 'wbqc-violation-message-range-parameters-needed' ) ) |
|
422 | - ->withDataValueType( $type ) |
|
423 | - ->withEntityId( new PropertyId( $minimumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
424 | - ->withEntityId( new PropertyId( $maximumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
425 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
421 | + (new ViolationMessage('wbqc-violation-message-range-parameters-needed')) |
|
422 | + ->withDataValueType($type) |
|
423 | + ->withEntityId(new PropertyId($minimumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
424 | + ->withEntityId(new PropertyId($maximumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
425 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
426 | 426 | ); |
427 | 427 | } |
428 | 428 | |
429 | - $this->requireSingleParameter( $constraintParameters, $minimumId ); |
|
430 | - $this->requireSingleParameter( $constraintParameters, $maximumId ); |
|
429 | + $this->requireSingleParameter($constraintParameters, $minimumId); |
|
430 | + $this->requireSingleParameter($constraintParameters, $maximumId); |
|
431 | 431 | $parseFunction = $type === 'time' ? 'parseValueOrNoValueOrNowParameter' : 'parseValueOrNoValueParameter'; |
432 | - $min = $this->$parseFunction( $constraintParameters[$minimumId][0], $minimumId ); |
|
433 | - $max = $this->$parseFunction( $constraintParameters[$maximumId][0], $maximumId ); |
|
432 | + $min = $this->$parseFunction($constraintParameters[$minimumId][0], $minimumId); |
|
433 | + $max = $this->$parseFunction($constraintParameters[$maximumId][0], $maximumId); |
|
434 | 434 | |
435 | - $yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' ); |
|
436 | - if ( $this->exactlyOneQuantityWithUnit( $min, $max, $yearUnit ) ) { |
|
435 | + $yearUnit = $this->config->get('WBQualityConstraintsYearUnit'); |
|
436 | + if ($this->exactlyOneQuantityWithUnit($min, $max, $yearUnit)) { |
|
437 | 437 | throw new ConstraintParameterException( |
438 | - new ViolationMessage( 'wbqc-violation-message-range-parameters-one-year' ) |
|
438 | + new ViolationMessage('wbqc-violation-message-range-parameters-one-year') |
|
439 | 439 | ); |
440 | 440 | } |
441 | - if ( $min === null && $max === null || |
|
442 | - $min !== null && $max !== null && $min->equals( $max ) ) { |
|
441 | + if ($min === null && $max === null || |
|
442 | + $min !== null && $max !== null && $min->equals($max)) { |
|
443 | 443 | throw new ConstraintParameterException( |
444 | - ( new ViolationMessage( 'wbqc-violation-message-range-parameters-same' ) ) |
|
445 | - ->withEntityId( new PropertyId( $minimumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
446 | - ->withEntityId( new PropertyId( $maximumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
444 | + (new ViolationMessage('wbqc-violation-message-range-parameters-same')) |
|
445 | + ->withEntityId(new PropertyId($minimumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
446 | + ->withEntityId(new PropertyId($maximumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
447 | 447 | ); |
448 | 448 | } |
449 | 449 | |
450 | - return [ $min, $max ]; |
|
450 | + return [$min, $max]; |
|
451 | 451 | } |
452 | 452 | |
453 | 453 | /** |
@@ -457,11 +457,11 @@ discard block |
||
457 | 457 | * @throws ConstraintParameterException if the parameter is invalid or missing |
458 | 458 | * @return DataValue[] a pair of two data values, either of which may be null to signify an open range |
459 | 459 | */ |
460 | - public function parseQuantityRangeParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
460 | + public function parseQuantityRangeParameter(array $constraintParameters, $constraintTypeItemId) { |
|
461 | 461 | return $this->parseRangeParameter( |
462 | 462 | $constraintParameters, |
463 | - $this->config->get( 'WBQualityConstraintsMinimumQuantityId' ), |
|
464 | - $this->config->get( 'WBQualityConstraintsMaximumQuantityId' ), |
|
463 | + $this->config->get('WBQualityConstraintsMinimumQuantityId'), |
|
464 | + $this->config->get('WBQualityConstraintsMaximumQuantityId'), |
|
465 | 465 | $constraintTypeItemId, |
466 | 466 | 'quantity' |
467 | 467 | ); |
@@ -474,11 +474,11 @@ discard block |
||
474 | 474 | * @throws ConstraintParameterException if the parameter is invalid or missing |
475 | 475 | * @return DataValue[] a pair of two data values, either of which may be null to signify an open range |
476 | 476 | */ |
477 | - public function parseTimeRangeParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
477 | + public function parseTimeRangeParameter(array $constraintParameters, $constraintTypeItemId) { |
|
478 | 478 | return $this->parseRangeParameter( |
479 | 479 | $constraintParameters, |
480 | - $this->config->get( 'WBQualityConstraintsMinimumDateId' ), |
|
481 | - $this->config->get( 'WBQualityConstraintsMaximumDateId' ), |
|
480 | + $this->config->get('WBQualityConstraintsMinimumDateId'), |
|
481 | + $this->config->get('WBQualityConstraintsMaximumDateId'), |
|
482 | 482 | $constraintTypeItemId, |
483 | 483 | 'time' |
484 | 484 | ); |
@@ -491,17 +491,17 @@ discard block |
||
491 | 491 | * @throws ConstraintParameterException |
492 | 492 | * @return string |
493 | 493 | */ |
494 | - private function parseStringParameter( array $snakSerialization, $parameterId ) { |
|
495 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
496 | - $this->requireValueParameter( $snak, $parameterId ); |
|
494 | + private function parseStringParameter(array $snakSerialization, $parameterId) { |
|
495 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
496 | + $this->requireValueParameter($snak, $parameterId); |
|
497 | 497 | $value = $snak->getDataValue(); |
498 | - if ( $value instanceof StringValue ) { |
|
498 | + if ($value instanceof StringValue) { |
|
499 | 499 | return $value->getValue(); |
500 | 500 | } else { |
501 | 501 | throw new ConstraintParameterException( |
502 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-string' ) ) |
|
503 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
504 | - ->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
502 | + (new ViolationMessage('wbqc-violation-message-parameter-string')) |
|
503 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
504 | + ->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
505 | 505 | ); |
506 | 506 | } |
507 | 507 | } |
@@ -512,15 +512,15 @@ discard block |
||
512 | 512 | * @throws ConstraintParameterException if the parameter is invalid or missing |
513 | 513 | * @return string |
514 | 514 | */ |
515 | - public function parseNamespaceParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
516 | - $this->checkError( $constraintParameters ); |
|
517 | - $namespaceId = $this->config->get( 'WBQualityConstraintsNamespaceId' ); |
|
518 | - if ( !array_key_exists( $namespaceId, $constraintParameters ) ) { |
|
515 | + public function parseNamespaceParameter(array $constraintParameters, $constraintTypeItemId) { |
|
516 | + $this->checkError($constraintParameters); |
|
517 | + $namespaceId = $this->config->get('WBQualityConstraintsNamespaceId'); |
|
518 | + if (!array_key_exists($namespaceId, $constraintParameters)) { |
|
519 | 519 | return ''; |
520 | 520 | } |
521 | 521 | |
522 | - $this->requireSingleParameter( $constraintParameters, $namespaceId ); |
|
523 | - return $this->parseStringParameter( $constraintParameters[$namespaceId][0], $namespaceId ); |
|
522 | + $this->requireSingleParameter($constraintParameters, $namespaceId); |
|
523 | + return $this->parseStringParameter($constraintParameters[$namespaceId][0], $namespaceId); |
|
524 | 524 | } |
525 | 525 | |
526 | 526 | /** |
@@ -529,19 +529,19 @@ discard block |
||
529 | 529 | * @throws ConstraintParameterException if the parameter is invalid or missing |
530 | 530 | * @return string |
531 | 531 | */ |
532 | - public function parseFormatParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
533 | - $this->checkError( $constraintParameters ); |
|
534 | - $formatId = $this->config->get( 'WBQualityConstraintsFormatAsARegularExpressionId' ); |
|
535 | - if ( !array_key_exists( $formatId, $constraintParameters ) ) { |
|
532 | + public function parseFormatParameter(array $constraintParameters, $constraintTypeItemId) { |
|
533 | + $this->checkError($constraintParameters); |
|
534 | + $formatId = $this->config->get('WBQualityConstraintsFormatAsARegularExpressionId'); |
|
535 | + if (!array_key_exists($formatId, $constraintParameters)) { |
|
536 | 536 | throw new ConstraintParameterException( |
537 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
538 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
539 | - ->withEntityId( new PropertyId( $formatId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
537 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
538 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
539 | + ->withEntityId(new PropertyId($formatId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
540 | 540 | ); |
541 | 541 | } |
542 | 542 | |
543 | - $this->requireSingleParameter( $constraintParameters, $formatId ); |
|
544 | - return $this->parseStringParameter( $constraintParameters[$formatId][0], $formatId ); |
|
543 | + $this->requireSingleParameter($constraintParameters, $formatId); |
|
544 | + return $this->parseStringParameter($constraintParameters[$formatId][0], $formatId); |
|
545 | 545 | } |
546 | 546 | |
547 | 547 | /** |
@@ -549,16 +549,16 @@ discard block |
||
549 | 549 | * @throws ConstraintParameterException if the parameter is invalid |
550 | 550 | * @return EntityId[] |
551 | 551 | */ |
552 | - public function parseExceptionParameter( array $constraintParameters ) { |
|
553 | - $this->checkError( $constraintParameters ); |
|
554 | - $exceptionId = $this->config->get( 'WBQualityConstraintsExceptionToConstraintId' ); |
|
555 | - if ( !array_key_exists( $exceptionId, $constraintParameters ) ) { |
|
552 | + public function parseExceptionParameter(array $constraintParameters) { |
|
553 | + $this->checkError($constraintParameters); |
|
554 | + $exceptionId = $this->config->get('WBQualityConstraintsExceptionToConstraintId'); |
|
555 | + if (!array_key_exists($exceptionId, $constraintParameters)) { |
|
556 | 556 | return []; |
557 | 557 | } |
558 | 558 | |
559 | 559 | return array_map( |
560 | - function( $snakSerialization ) use ( $exceptionId ) { |
|
561 | - return $this->parseEntityIdParameter( $snakSerialization, $exceptionId ); |
|
560 | + function($snakSerialization) use ($exceptionId) { |
|
561 | + return $this->parseEntityIdParameter($snakSerialization, $exceptionId); |
|
562 | 562 | }, |
563 | 563 | $constraintParameters[$exceptionId] |
564 | 564 | ); |
@@ -569,39 +569,39 @@ discard block |
||
569 | 569 | * @throws ConstraintParameterException if the parameter is invalid |
570 | 570 | * @return string|null 'mandatory', 'suggestion' or null |
571 | 571 | */ |
572 | - public function parseConstraintStatusParameter( array $constraintParameters ) { |
|
573 | - $this->checkError( $constraintParameters ); |
|
574 | - $constraintStatusId = $this->config->get( 'WBQualityConstraintsConstraintStatusId' ); |
|
575 | - if ( !array_key_exists( $constraintStatusId, $constraintParameters ) ) { |
|
572 | + public function parseConstraintStatusParameter(array $constraintParameters) { |
|
573 | + $this->checkError($constraintParameters); |
|
574 | + $constraintStatusId = $this->config->get('WBQualityConstraintsConstraintStatusId'); |
|
575 | + if (!array_key_exists($constraintStatusId, $constraintParameters)) { |
|
576 | 576 | return null; |
577 | 577 | } |
578 | 578 | |
579 | - $mandatoryId = $this->config->get( 'WBQualityConstraintsMandatoryConstraintId' ); |
|
580 | - $supportedStatuses = [ new ItemId( $mandatoryId ) ]; |
|
581 | - if ( $this->config->get( 'WBQualityConstraintsEnableSuggestionConstraintStatus' ) ) { |
|
582 | - $suggestionId = $this->config->get( 'WBQualityConstraintsSuggestionConstraintId' ); |
|
583 | - $supportedStatuses[] = new ItemId( $suggestionId ); |
|
579 | + $mandatoryId = $this->config->get('WBQualityConstraintsMandatoryConstraintId'); |
|
580 | + $supportedStatuses = [new ItemId($mandatoryId)]; |
|
581 | + if ($this->config->get('WBQualityConstraintsEnableSuggestionConstraintStatus')) { |
|
582 | + $suggestionId = $this->config->get('WBQualityConstraintsSuggestionConstraintId'); |
|
583 | + $supportedStatuses[] = new ItemId($suggestionId); |
|
584 | 584 | } else { |
585 | 585 | $suggestionId = null; |
586 | 586 | } |
587 | 587 | |
588 | - $this->requireSingleParameter( $constraintParameters, $constraintStatusId ); |
|
589 | - $snak = $this->snakDeserializer->deserialize( $constraintParameters[$constraintStatusId][0] ); |
|
590 | - $this->requireValueParameter( $snak, $constraintStatusId ); |
|
588 | + $this->requireSingleParameter($constraintParameters, $constraintStatusId); |
|
589 | + $snak = $this->snakDeserializer->deserialize($constraintParameters[$constraintStatusId][0]); |
|
590 | + $this->requireValueParameter($snak, $constraintStatusId); |
|
591 | 591 | '@phan-var \Wikibase\DataModel\Snak\PropertyValueSnak $snak'; |
592 | 592 | $dataValue = $snak->getDataValue(); |
593 | 593 | '@phan-var EntityIdValue $dataValue'; |
594 | 594 | $entityId = $dataValue->getEntityId(); |
595 | 595 | $statusId = $entityId->getSerialization(); |
596 | 596 | |
597 | - if ( $statusId === $mandatoryId ) { |
|
597 | + if ($statusId === $mandatoryId) { |
|
598 | 598 | return 'mandatory'; |
599 | - } elseif ( $statusId === $suggestionId ) { |
|
599 | + } elseif ($statusId === $suggestionId) { |
|
600 | 600 | return 'suggestion'; |
601 | 601 | } else { |
602 | 602 | throw new ConstraintParameterException( |
603 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
604 | - ->withEntityId( new PropertyId( $constraintStatusId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
603 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
604 | + ->withEntityId(new PropertyId($constraintStatusId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
605 | 605 | ->withEntityIdList( |
606 | 606 | $supportedStatuses, |
607 | 607 | Role::CONSTRAINT_PARAMETER_VALUE |
@@ -617,12 +617,12 @@ discard block |
||
617 | 617 | * @return void |
618 | 618 | * @throws ConstraintParameterException |
619 | 619 | */ |
620 | - private function requireMonolingualTextParameter( DataValue $dataValue, $parameterId ) { |
|
621 | - if ( !( $dataValue instanceof MonolingualTextValue ) ) { |
|
620 | + private function requireMonolingualTextParameter(DataValue $dataValue, $parameterId) { |
|
621 | + if (!($dataValue instanceof MonolingualTextValue)) { |
|
622 | 622 | throw new ConstraintParameterException( |
623 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-monolingualtext' ) ) |
|
624 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
625 | - ->withDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
623 | + (new ViolationMessage('wbqc-violation-message-parameter-monolingualtext')) |
|
624 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
625 | + ->withDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE) |
|
626 | 626 | ); |
627 | 627 | } |
628 | 628 | } |
@@ -635,31 +635,31 @@ discard block |
||
635 | 635 | * @throws ConstraintParameterException if invalid snaks are found or a language has multiple texts |
636 | 636 | * @return MultilingualTextValue |
637 | 637 | */ |
638 | - private function parseMultilingualTextParameter( array $snakSerializations, $parameterId ) { |
|
638 | + private function parseMultilingualTextParameter(array $snakSerializations, $parameterId) { |
|
639 | 639 | $result = []; |
640 | 640 | |
641 | - foreach ( $snakSerializations as $snakSerialization ) { |
|
642 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
643 | - $this->requireValueParameter( $snak, $parameterId ); |
|
641 | + foreach ($snakSerializations as $snakSerialization) { |
|
642 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
643 | + $this->requireValueParameter($snak, $parameterId); |
|
644 | 644 | |
645 | 645 | $value = $snak->getDataValue(); |
646 | - $this->requireMonolingualTextParameter( $value, $parameterId ); |
|
646 | + $this->requireMonolingualTextParameter($value, $parameterId); |
|
647 | 647 | /** @var MonolingualTextValue $value */ |
648 | 648 | '@phan-var MonolingualTextValue $value'; |
649 | 649 | |
650 | 650 | $code = $value->getLanguageCode(); |
651 | - if ( array_key_exists( $code, $result ) ) { |
|
651 | + if (array_key_exists($code, $result)) { |
|
652 | 652 | throw new ConstraintParameterException( |
653 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-single-per-language' ) ) |
|
654 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
655 | - ->withLanguage( $code ) |
|
653 | + (new ViolationMessage('wbqc-violation-message-parameter-single-per-language')) |
|
654 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
655 | + ->withLanguage($code) |
|
656 | 656 | ); |
657 | 657 | } |
658 | 658 | |
659 | 659 | $result[$code] = $value; |
660 | 660 | } |
661 | 661 | |
662 | - return new MultilingualTextValue( $result ); |
|
662 | + return new MultilingualTextValue($result); |
|
663 | 663 | } |
664 | 664 | |
665 | 665 | /** |
@@ -667,11 +667,11 @@ discard block |
||
667 | 667 | * @throws ConstraintParameterException if the parameter is invalid |
668 | 668 | * @return MultilingualTextValue |
669 | 669 | */ |
670 | - public function parseSyntaxClarificationParameter( array $constraintParameters ) { |
|
671 | - $syntaxClarificationId = $this->config->get( 'WBQualityConstraintsSyntaxClarificationId' ); |
|
670 | + public function parseSyntaxClarificationParameter(array $constraintParameters) { |
|
671 | + $syntaxClarificationId = $this->config->get('WBQualityConstraintsSyntaxClarificationId'); |
|
672 | 672 | |
673 | - if ( !array_key_exists( $syntaxClarificationId, $constraintParameters ) ) { |
|
674 | - return new MultilingualTextValue( [] ); |
|
673 | + if (!array_key_exists($syntaxClarificationId, $constraintParameters)) { |
|
674 | + return new MultilingualTextValue([]); |
|
675 | 675 | } |
676 | 676 | |
677 | 677 | $syntaxClarifications = $this->parseMultilingualTextParameter( |
@@ -690,9 +690,9 @@ discard block |
||
690 | 690 | * @throws ConstraintParameterException if the parameter is invalid |
691 | 691 | * @return string[]|null Context::TYPE_* constants |
692 | 692 | */ |
693 | - public function parseConstraintScopeParameter( array $constraintParameters, $constraintTypeItemId, array $validScopes = null ) { |
|
693 | + public function parseConstraintScopeParameter(array $constraintParameters, $constraintTypeItemId, array $validScopes = null) { |
|
694 | 694 | $contextTypes = []; |
695 | - $parameterId = $this->config->get( 'WBQualityConstraintsConstraintScopeId' ); |
|
695 | + $parameterId = $this->config->get('WBQualityConstraintsConstraintScopeId'); |
|
696 | 696 | $items = $this->parseItemsParameter( |
697 | 697 | $constraintParameters, |
698 | 698 | $constraintTypeItemId, |
@@ -700,23 +700,23 @@ discard block |
||
700 | 700 | $parameterId |
701 | 701 | ); |
702 | 702 | |
703 | - if ( $items === [] ) { |
|
703 | + if ($items === []) { |
|
704 | 704 | return null; |
705 | 705 | } |
706 | 706 | |
707 | - foreach ( $items as $item ) { |
|
708 | - $contextTypes[] = $this->parseContextTypeItem( $item, 'constraint scope', $parameterId ); |
|
707 | + foreach ($items as $item) { |
|
708 | + $contextTypes[] = $this->parseContextTypeItem($item, 'constraint scope', $parameterId); |
|
709 | 709 | } |
710 | 710 | |
711 | - if ( $validScopes !== null ) { |
|
712 | - $invalidScopes = array_diff( $contextTypes, $validScopes ); |
|
713 | - if ( $invalidScopes !== [] ) { |
|
714 | - $invalidScope = array_pop( $invalidScopes ); |
|
711 | + if ($validScopes !== null) { |
|
712 | + $invalidScopes = array_diff($contextTypes, $validScopes); |
|
713 | + if ($invalidScopes !== []) { |
|
714 | + $invalidScope = array_pop($invalidScopes); |
|
715 | 715 | throw new ConstraintParameterException( |
716 | - ( new ViolationMessage( 'wbqc-violation-message-invalid-scope' ) ) |
|
717 | - ->withConstraintScope( $invalidScope, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
718 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
719 | - ->withConstraintScopeList( $validScopes, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
716 | + (new ViolationMessage('wbqc-violation-message-invalid-scope')) |
|
717 | + ->withConstraintScope($invalidScope, Role::CONSTRAINT_PARAMETER_VALUE) |
|
718 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
719 | + ->withConstraintScopeList($validScopes, Role::CONSTRAINT_PARAMETER_VALUE) |
|
720 | 720 | ); |
721 | 721 | } |
722 | 722 | } |
@@ -730,8 +730,8 @@ discard block |
||
730 | 730 | * @param ItemId $unitId |
731 | 731 | * @return string unit |
732 | 732 | */ |
733 | - private function parseUnitParameter( ItemId $unitId ) { |
|
734 | - return $this->unitItemConceptBaseUri . $unitId->getSerialization(); |
|
733 | + private function parseUnitParameter(ItemId $unitId) { |
|
734 | + return $this->unitItemConceptBaseUri.$unitId->getSerialization(); |
|
735 | 735 | } |
736 | 736 | |
737 | 737 | /** |
@@ -741,23 +741,23 @@ discard block |
||
741 | 741 | * @return UnitsParameter |
742 | 742 | * @throws ConstraintParameterException |
743 | 743 | */ |
744 | - private function parseUnitItem( ItemIdSnakValue $item ) { |
|
745 | - switch ( true ) { |
|
744 | + private function parseUnitItem(ItemIdSnakValue $item) { |
|
745 | + switch (true) { |
|
746 | 746 | case $item->isValue(): |
747 | - $unit = $this->parseUnitParameter( $item->getItemId() ); |
|
747 | + $unit = $this->parseUnitParameter($item->getItemId()); |
|
748 | 748 | return new UnitsParameter( |
749 | - [ $item->getItemId() ], |
|
750 | - [ UnboundedQuantityValue::newFromNumber( 1, $unit ) ], |
|
749 | + [$item->getItemId()], |
|
750 | + [UnboundedQuantityValue::newFromNumber(1, $unit)], |
|
751 | 751 | false |
752 | 752 | ); |
753 | 753 | case $item->isSomeValue(): |
754 | - $qualifierId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
754 | + $qualifierId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
755 | 755 | throw new ConstraintParameterException( |
756 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value-or-novalue' ) ) |
|
757 | - ->withEntityId( new PropertyId( $qualifierId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
756 | + (new ViolationMessage('wbqc-violation-message-parameter-value-or-novalue')) |
|
757 | + ->withEntityId(new PropertyId($qualifierId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
758 | 758 | ); |
759 | 759 | case $item->isNoValue(): |
760 | - return new UnitsParameter( [], [], true ); |
|
760 | + return new UnitsParameter([], [], true); |
|
761 | 761 | } |
762 | 762 | } |
763 | 763 | |
@@ -767,26 +767,26 @@ discard block |
||
767 | 767 | * @throws ConstraintParameterException if the parameter is invalid or missing |
768 | 768 | * @return UnitsParameter |
769 | 769 | */ |
770 | - public function parseUnitsParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
771 | - $items = $this->parseItemsParameter( $constraintParameters, $constraintTypeItemId, true ); |
|
770 | + public function parseUnitsParameter(array $constraintParameters, $constraintTypeItemId) { |
|
771 | + $items = $this->parseItemsParameter($constraintParameters, $constraintTypeItemId, true); |
|
772 | 772 | $unitItems = []; |
773 | 773 | $unitQuantities = []; |
774 | 774 | $unitlessAllowed = false; |
775 | 775 | |
776 | - foreach ( $items as $item ) { |
|
777 | - $unit = $this->parseUnitItem( $item ); |
|
778 | - $unitItems = array_merge( $unitItems, $unit->getUnitItemIds() ); |
|
779 | - $unitQuantities = array_merge( $unitQuantities, $unit->getUnitQuantities() ); |
|
776 | + foreach ($items as $item) { |
|
777 | + $unit = $this->parseUnitItem($item); |
|
778 | + $unitItems = array_merge($unitItems, $unit->getUnitItemIds()); |
|
779 | + $unitQuantities = array_merge($unitQuantities, $unit->getUnitQuantities()); |
|
780 | 780 | $unitlessAllowed = $unitlessAllowed || $unit->getUnitlessAllowed(); |
781 | 781 | } |
782 | 782 | |
783 | - if ( $unitQuantities === [] && !$unitlessAllowed ) { |
|
783 | + if ($unitQuantities === [] && !$unitlessAllowed) { |
|
784 | 784 | throw new LogicException( |
785 | 785 | 'The "units" parameter is required, and yet we seem to be missing any allowed unit' |
786 | 786 | ); |
787 | 787 | } |
788 | 788 | |
789 | - return new UnitsParameter( $unitItems, $unitQuantities, $unitlessAllowed ); |
|
789 | + return new UnitsParameter($unitItems, $unitQuantities, $unitlessAllowed); |
|
790 | 790 | } |
791 | 791 | |
792 | 792 | /** |
@@ -796,53 +796,53 @@ discard block |
||
796 | 796 | * @return EntityTypesParameter |
797 | 797 | * @throws ConstraintParameterException |
798 | 798 | */ |
799 | - private function parseEntityTypeItem( ItemIdSnakValue $item ) { |
|
800 | - $parameterId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
799 | + private function parseEntityTypeItem(ItemIdSnakValue $item) { |
|
800 | + $parameterId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
801 | 801 | |
802 | - if ( !$item->isValue() ) { |
|
802 | + if (!$item->isValue()) { |
|
803 | 803 | throw new ConstraintParameterException( |
804 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) ) |
|
805 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
804 | + (new ViolationMessage('wbqc-violation-message-parameter-value')) |
|
805 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
806 | 806 | ); |
807 | 807 | } |
808 | 808 | |
809 | 809 | $itemId = $item->getItemId(); |
810 | - switch ( $itemId->getSerialization() ) { |
|
811 | - case $this->config->get( 'WBQualityConstraintsWikibaseItemId' ): |
|
810 | + switch ($itemId->getSerialization()) { |
|
811 | + case $this->config->get('WBQualityConstraintsWikibaseItemId'): |
|
812 | 812 | $entityType = 'item'; |
813 | 813 | break; |
814 | - case $this->config->get( 'WBQualityConstraintsWikibasePropertyId' ): |
|
814 | + case $this->config->get('WBQualityConstraintsWikibasePropertyId'): |
|
815 | 815 | $entityType = 'property'; |
816 | 816 | break; |
817 | - case $this->config->get( 'WBQualityConstraintsWikibaseLexemeId' ): |
|
817 | + case $this->config->get('WBQualityConstraintsWikibaseLexemeId'): |
|
818 | 818 | $entityType = 'lexeme'; |
819 | 819 | break; |
820 | - case $this->config->get( 'WBQualityConstraintsWikibaseFormId' ): |
|
820 | + case $this->config->get('WBQualityConstraintsWikibaseFormId'): |
|
821 | 821 | $entityType = 'form'; |
822 | 822 | break; |
823 | - case $this->config->get( 'WBQualityConstraintsWikibaseSenseId' ): |
|
823 | + case $this->config->get('WBQualityConstraintsWikibaseSenseId'): |
|
824 | 824 | $entityType = 'sense'; |
825 | 825 | break; |
826 | - case $this->config->get( 'WBQualityConstraintsWikibaseMediaInfoId' ): |
|
826 | + case $this->config->get('WBQualityConstraintsWikibaseMediaInfoId'): |
|
827 | 827 | $entityType = 'mediainfo'; |
828 | 828 | break; |
829 | 829 | default: |
830 | 830 | $allowed = [ |
831 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseItemId' ) ), |
|
832 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibasePropertyId' ) ), |
|
833 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseLexemeId' ) ), |
|
834 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseFormId' ) ), |
|
835 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseSenseId' ) ), |
|
836 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseMediaInfoId' ) ), |
|
831 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseItemId')), |
|
832 | + new ItemId($this->config->get('WBQualityConstraintsWikibasePropertyId')), |
|
833 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseLexemeId')), |
|
834 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseFormId')), |
|
835 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseSenseId')), |
|
836 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseMediaInfoId')), |
|
837 | 837 | ]; |
838 | 838 | throw new ConstraintParameterException( |
839 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
840 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
841 | - ->withEntityIdList( $allowed, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
839 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
840 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
841 | + ->withEntityIdList($allowed, Role::CONSTRAINT_PARAMETER_VALUE) |
|
842 | 842 | ); |
843 | 843 | } |
844 | 844 | |
845 | - return new EntityTypesParameter( [ $entityType ], [ $itemId ] ); |
|
845 | + return new EntityTypesParameter([$entityType], [$itemId]); |
|
846 | 846 | } |
847 | 847 | |
848 | 848 | /** |
@@ -851,27 +851,27 @@ discard block |
||
851 | 851 | * @throws ConstraintParameterException if the parameter is invalid or missing |
852 | 852 | * @return EntityTypesParameter |
853 | 853 | */ |
854 | - public function parseEntityTypesParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
854 | + public function parseEntityTypesParameter(array $constraintParameters, $constraintTypeItemId) { |
|
855 | 855 | $entityTypes = []; |
856 | 856 | $entityTypeItemIds = []; |
857 | - $items = $this->parseItemsParameter( $constraintParameters, $constraintTypeItemId, true ); |
|
857 | + $items = $this->parseItemsParameter($constraintParameters, $constraintTypeItemId, true); |
|
858 | 858 | |
859 | - foreach ( $items as $item ) { |
|
860 | - $entityType = $this->parseEntityTypeItem( $item ); |
|
861 | - $entityTypes = array_merge( $entityTypes, $entityType->getEntityTypes() ); |
|
862 | - $entityTypeItemIds = array_merge( $entityTypeItemIds, $entityType->getEntityTypeItemIds() ); |
|
859 | + foreach ($items as $item) { |
|
860 | + $entityType = $this->parseEntityTypeItem($item); |
|
861 | + $entityTypes = array_merge($entityTypes, $entityType->getEntityTypes()); |
|
862 | + $entityTypeItemIds = array_merge($entityTypeItemIds, $entityType->getEntityTypeItemIds()); |
|
863 | 863 | } |
864 | 864 | |
865 | - if ( empty( $entityTypes ) ) { |
|
865 | + if (empty($entityTypes)) { |
|
866 | 866 | // @codeCoverageIgnoreStart |
867 | 867 | throw new LogicException( |
868 | - 'The "entity types" parameter is required, ' . |
|
868 | + 'The "entity types" parameter is required, '. |
|
869 | 869 | 'and yet we seem to be missing any allowed entity type' |
870 | 870 | ); |
871 | 871 | // @codeCoverageIgnoreEnd |
872 | 872 | } |
873 | 873 | |
874 | - return new EntityTypesParameter( $entityTypes, $entityTypeItemIds ); |
|
874 | + return new EntityTypesParameter($entityTypes, $entityTypeItemIds); |
|
875 | 875 | } |
876 | 876 | |
877 | 877 | /** |
@@ -879,18 +879,18 @@ discard block |
||
879 | 879 | * @throws ConstraintParameterException if the parameter is invalid |
880 | 880 | * @return PropertyId[] |
881 | 881 | */ |
882 | - public function parseSeparatorsParameter( array $constraintParameters ) { |
|
883 | - $separatorId = $this->config->get( 'WBQualityConstraintsSeparatorId' ); |
|
882 | + public function parseSeparatorsParameter(array $constraintParameters) { |
|
883 | + $separatorId = $this->config->get('WBQualityConstraintsSeparatorId'); |
|
884 | 884 | |
885 | - if ( !array_key_exists( $separatorId, $constraintParameters ) ) { |
|
885 | + if (!array_key_exists($separatorId, $constraintParameters)) { |
|
886 | 886 | return []; |
887 | 887 | } |
888 | 888 | |
889 | 889 | $parameters = $constraintParameters[$separatorId]; |
890 | 890 | $separators = []; |
891 | 891 | |
892 | - foreach ( $parameters as $parameter ) { |
|
893 | - $separators[] = $this->parsePropertyIdParameter( $parameter, $separatorId ); |
|
892 | + foreach ($parameters as $parameter) { |
|
893 | + $separators[] = $this->parsePropertyIdParameter($parameter, $separatorId); |
|
894 | 894 | } |
895 | 895 | |
896 | 896 | return $separators; |
@@ -905,26 +905,26 @@ discard block |
||
905 | 905 | * @return string one of the Context::TYPE_* constants |
906 | 906 | * @throws ConstraintParameterException |
907 | 907 | */ |
908 | - private function parseContextTypeItem( ItemIdSnakValue $item, $use, $parameterId ) { |
|
909 | - if ( !$item->isValue() ) { |
|
908 | + private function parseContextTypeItem(ItemIdSnakValue $item, $use, $parameterId) { |
|
909 | + if (!$item->isValue()) { |
|
910 | 910 | throw new ConstraintParameterException( |
911 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) ) |
|
912 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
911 | + (new ViolationMessage('wbqc-violation-message-parameter-value')) |
|
912 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
913 | 913 | ); |
914 | 914 | } |
915 | 915 | |
916 | - if ( $use === 'constraint scope' ) { |
|
917 | - $mainSnakId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnMainValueId' ); |
|
918 | - $qualifiersId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnQualifiersId' ); |
|
919 | - $referencesId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnReferencesId' ); |
|
916 | + if ($use === 'constraint scope') { |
|
917 | + $mainSnakId = $this->config->get('WBQualityConstraintsConstraintCheckedOnMainValueId'); |
|
918 | + $qualifiersId = $this->config->get('WBQualityConstraintsConstraintCheckedOnQualifiersId'); |
|
919 | + $referencesId = $this->config->get('WBQualityConstraintsConstraintCheckedOnReferencesId'); |
|
920 | 920 | } else { |
921 | - $mainSnakId = $this->config->get( 'WBQualityConstraintsAsMainValueId' ); |
|
922 | - $qualifiersId = $this->config->get( 'WBQualityConstraintsAsQualifiersId' ); |
|
923 | - $referencesId = $this->config->get( 'WBQualityConstraintsAsReferencesId' ); |
|
921 | + $mainSnakId = $this->config->get('WBQualityConstraintsAsMainValueId'); |
|
922 | + $qualifiersId = $this->config->get('WBQualityConstraintsAsQualifiersId'); |
|
923 | + $referencesId = $this->config->get('WBQualityConstraintsAsReferencesId'); |
|
924 | 924 | } |
925 | 925 | |
926 | 926 | $itemId = $item->getItemId(); |
927 | - switch ( $itemId->getSerialization() ) { |
|
927 | + switch ($itemId->getSerialization()) { |
|
928 | 928 | case $mainSnakId: |
929 | 929 | return Context::TYPE_STATEMENT; |
930 | 930 | case $qualifiersId: |
@@ -932,11 +932,11 @@ discard block |
||
932 | 932 | case $referencesId: |
933 | 933 | return Context::TYPE_REFERENCE; |
934 | 934 | default: |
935 | - $allowed = [ $mainSnakId, $qualifiersId, $referencesId ]; |
|
935 | + $allowed = [$mainSnakId, $qualifiersId, $referencesId]; |
|
936 | 936 | throw new ConstraintParameterException( |
937 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
938 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
939 | - ->withEntityIdList( $allowed, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
937 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
938 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
939 | + ->withEntityIdList($allowed, Role::CONSTRAINT_PARAMETER_VALUE) |
|
940 | 940 | ); |
941 | 941 | } |
942 | 942 | } |
@@ -947,9 +947,9 @@ discard block |
||
947 | 947 | * @throws ConstraintParameterException if the parameter is invalid or missing |
948 | 948 | * @return string[] list of Context::TYPE_* constants |
949 | 949 | */ |
950 | - public function parsePropertyScopeParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
950 | + public function parsePropertyScopeParameter(array $constraintParameters, $constraintTypeItemId) { |
|
951 | 951 | $contextTypes = []; |
952 | - $parameterId = $this->config->get( 'WBQualityConstraintsPropertyScopeId' ); |
|
952 | + $parameterId = $this->config->get('WBQualityConstraintsPropertyScopeId'); |
|
953 | 953 | $items = $this->parseItemsParameter( |
954 | 954 | $constraintParameters, |
955 | 955 | $constraintTypeItemId, |
@@ -957,14 +957,14 @@ discard block |
||
957 | 957 | $parameterId |
958 | 958 | ); |
959 | 959 | |
960 | - foreach ( $items as $item ) { |
|
961 | - $contextTypes[] = $this->parseContextTypeItem( $item, 'property scope', $parameterId ); |
|
960 | + foreach ($items as $item) { |
|
961 | + $contextTypes[] = $this->parseContextTypeItem($item, 'property scope', $parameterId); |
|
962 | 962 | } |
963 | 963 | |
964 | - if ( empty( $contextTypes ) ) { |
|
964 | + if (empty($contextTypes)) { |
|
965 | 965 | // @codeCoverageIgnoreStart |
966 | 966 | throw new LogicException( |
967 | - 'The "property scope" parameter is required, ' . |
|
967 | + 'The "property scope" parameter is required, '. |
|
968 | 968 | 'and yet we seem to be missing any allowed scope' |
969 | 969 | ); |
970 | 970 | // @codeCoverageIgnoreEnd |