wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Api/CachingResultsSource.php

Spacing +77 added lines, -78 removed lines

@@ -143,14 +143,14 @@ 
 	) {
 		$results = [];
 		$metadatas = [];
-		if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
+		if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds, $statuses)) {
 			$storedEntityIds = [];
-			foreach ( $entityIds as $entityId ) {
-				$storedResults = $this->getStoredResults( $entityId );
-				if ( $storedResults !== null ) {
-					$this->loggingHelper->logCheckConstraintsCacheHit( $entityId );
-					foreach ( $storedResults->getArray() as $checkResult ) {
-						if ( $this->statusSelected( $statuses, $checkResult ) ) {
+			foreach ($entityIds as $entityId) {
+				$storedResults = $this->getStoredResults($entityId);
+				if ($storedResults !== null) {
+					$this->loggingHelper->logCheckConstraintsCacheHit($entityId);
+					foreach ($storedResults->getArray() as $checkResult) {
+						if ($this->statusSelected($statuses, $checkResult)) {
 							$results[] = $checkResult;
 						}
 					}
@@ -158,19 +158,19 @@ 
 					$storedEntityIds[] = $entityId;
 				}
 			}
-			$entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) );
+			$entityIds = array_values(array_diff($entityIds, $storedEntityIds));
 		}
-		if ( $entityIds !== [] || $claimIds !== [] ) {
-			if ( $entityIds !== [] ) {
-				$this->loggingHelper->logCheckConstraintsCacheMisses( $entityIds );
+		if ($entityIds !== [] || $claimIds !== []) {
+			if ($entityIds !== []) {
+				$this->loggingHelper->logCheckConstraintsCacheMisses($entityIds);
 			}
-			$response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds, $statuses );
-			$results = array_merge( $results, $response->getArray() );
+			$response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds, $statuses);
+			$results = array_merge($results, $response->getArray());
 			$metadatas[] = $response->getMetadata();
 		}
 		return new CachedCheckResults(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -193,13 +193,13 @@ 
 		?array $constraintIds,
 		array $statuses
 	) {
-		if ( $claimIds !== [] ) {
+		if ($claimIds !== []) {
 			return false;
 		}
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( array_diff( $statuses, self::CACHED_STATUSES ) !== [] ) {
+		if (array_diff($statuses, self::CACHED_STATUSES) !== []) {
 			return false;
 		}
 		return true;
@@ -214,8 +214,8 @@ 
 	 * @param CheckResult $result
 	 * @return bool
 	 */
-	private function statusSelected( array $statuses, CheckResult $result ) {
-		return in_array( $result->getStatus(), $statuses, true ) ||
+	private function statusSelected(array $statuses, CheckResult $result) {
+		return in_array($result->getStatus(), $statuses, true) ||
 			$result instanceof NullResult;
 	}
 
@@ -232,11 +232,11 @@ 
 		?array $constraintIds,
 		array $statuses
 	) {
-		$results = $this->resultsSource->getResults( $entityIds, $claimIds, $constraintIds, $statuses );
+		$results = $this->resultsSource->getResults($entityIds, $claimIds, $constraintIds, $statuses);
 
-		if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
-			foreach ( $entityIds as $entityId ) {
-				$this->storeResults( $entityId, $results );
+		if ($this->canStoreResults($entityIds, $claimIds, $constraintIds, $statuses)) {
+			foreach ($entityIds as $entityId) {
+				$this->storeResults($entityId, $results);
 			}
 		}
 
@@ -267,10 +267,10 @@ 
 		?array $constraintIds,
 		array $statuses
 	) {
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( array_diff( self::CACHED_STATUSES, $statuses ) !== [] ) {
+		if (array_diff(self::CACHED_STATUSES, $statuses) !== []) {
 			return false;
 		}
 		return true;
@@ -284,21 +284,21 @@ 
 	 * May include check results for other entity IDs as well,
 	 * or check results with statuses that we’re not interested in caching.
 	 */
-	private function storeResults( EntityId $entityId, CachedCheckResults $results ) {
+	private function storeResults(EntityId $entityId, CachedCheckResults $results) {
 		$latestRevisionIds = $this->getLatestRevisionIds(
 			$results->getMetadata()->getDependencyMetadata()->getEntityIds()
 		);
-		if ( $latestRevisionIds === null ) {
+		if ($latestRevisionIds === null) {
 			return;
 		}
 
 		$resultSerializations = [];
-		foreach ( $results->getArray() as $checkResult ) {
-			if ( $checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization() ) {
+		foreach ($results->getArray() as $checkResult) {
+			if ($checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization()) {
 				continue;
 			}
-			if ( $this->statusSelected( self::CACHED_STATUSES, $checkResult ) ) {
-				$resultSerializations[] = $this->checkResultSerializer->serialize( $checkResult );
+			if ($this->statusSelected(self::CACHED_STATUSES, $checkResult)) {
+				$resultSerializations[] = $this->checkResultSerializer->serialize($checkResult);
 			}
 		}
 
@@ -307,11 +307,11 @@ 
 			'latestRevisionIds' => $latestRevisionIds,
 		];
 		$futureTime = $results->getMetadata()->getDependencyMetadata()->getFutureTime();
-		if ( $futureTime !== null ) {
+		if ($futureTime !== null) {
 			$value['futureTime'] = $futureTime->getArrayValue();
 		}
 
-		$this->cache->set( $entityId, $value, $this->ttlInSeconds );
+		$this->cache->set($entityId, $value, $this->ttlInSeconds);
 	}
 
 	/**
@@ -326,33 +326,32 @@ 
 		$forRevision = 0
 	) {
 		$cacheInfo = WANObjectCache::PASS_BY_REF;
-		$value = $this->cache->get( $entityId, $curTTL, [], $cacheInfo );
-		$now = call_user_func( $this->microtime, true );
+		$value = $this->cache->get($entityId, $curTTL, [], $cacheInfo);
+		$now = call_user_func($this->microtime, true);
 
-		$dependencyMetadata = $this->checkDependencyMetadata( $value,
-			[ $entityId->getSerialization() => $forRevision ] );
-		if ( $dependencyMetadata === null ) {
+		$dependencyMetadata = $this->checkDependencyMetadata($value,
+			[$entityId->getSerialization() => $forRevision]);
+		if ($dependencyMetadata === null) {
 			return null;
 		}
 
 		// @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset False positive
 		$asOf = $cacheInfo[WANObjectCache::KEY_AS_OF];
-		$ageInSeconds = (int)ceil( $now - $asOf );
+		$ageInSeconds = (int) ceil($now - $asOf);
 		$cachingMetadata = $ageInSeconds > 0 ?
-			CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) :
-			CachingMetadata::fresh();
+			CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh();
 
 		$results = [];
-		foreach ( $value['results'] as $resultSerialization ) {
-			$results[] = $this->deserializeCheckResult( $resultSerialization, $cachingMetadata );
+		foreach ($value['results'] as $resultSerialization) {
+			$results[] = $this->deserializeCheckResult($resultSerialization, $cachingMetadata);
 		}
 
 		return new CachedCheckResults(
 			$results,
-			Metadata::merge( [
-				Metadata::ofCachingMetadata( $cachingMetadata ),
-				Metadata::ofDependencyMetadata( $dependencyMetadata ),
-			] )
+			Metadata::merge([
+				Metadata::ofCachingMetadata($cachingMetadata),
+				Metadata::ofDependencyMetadata($dependencyMetadata),
+			])
 		);
 	}
 
@@ -368,43 +367,43 @@ 
 	 * @return DependencyMetadata|null the dependency metadata,
 	 * or null if $value should no longer be used
 	 */
-	private function checkDependencyMetadata( $value, $paramRevs ) {
-		if ( $value === false ) {
+	private function checkDependencyMetadata($value, $paramRevs) {
+		if ($value === false) {
 			return null;
 		}
 
-		if ( array_key_exists( 'futureTime', $value ) ) {
-			$futureTime = TimeValue::newFromArray( $value['futureTime'] );
-			if ( !$this->timeValueComparer->isFutureTime( $futureTime ) ) {
+		if (array_key_exists('futureTime', $value)) {
+			$futureTime = TimeValue::newFromArray($value['futureTime']);
+			if (!$this->timeValueComparer->isFutureTime($futureTime)) {
 				return null;
 			}
-			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime );
+			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime);
 		} else {
 			$futureTimeDependencyMetadata = DependencyMetadata::blank();
 		}
 
-		foreach ( $paramRevs as $id => $revision ) {
-			if ( $revision > 0 ) {
-				$value['latestRevisionIds'][$id] = min( $revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX );
+		foreach ($paramRevs as $id => $revision) {
+			if ($revision > 0) {
+				$value['latestRevisionIds'][$id] = min($revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX);
 			}
 		}
 
 		$dependedEntityIds = array_map(
-			[ $this->entityIdParser, "parse" ],
-			array_keys( $value['latestRevisionIds'] )
+			[$this->entityIdParser, "parse"],
+			array_keys($value['latestRevisionIds'])
 		);
 
-		if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) {
+		if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) {
 			return null;
 		}
 
 		return array_reduce(
 			$dependedEntityIds,
-			static function ( DependencyMetadata $metadata, EntityId $entityId ) {
-				return DependencyMetadata::merge( [
+			static function(DependencyMetadata $metadata, EntityId $entityId) {
+				return DependencyMetadata::merge([
 					$metadata,
-					DependencyMetadata::ofEntityId( $entityId ),
-				] );
+					DependencyMetadata::ofEntityId($entityId),
+				]);
 			},
 			$futureTimeDependencyMetadata
 		);
@@ -424,13 +423,13 @@ 
 		array $resultSerialization,
 		CachingMetadata $cachingMetadata
 	) {
-		$result = $this->checkResultDeserializer->deserialize( $resultSerialization );
-		if ( $this->isPossiblyStaleResult( $result ) ) {
+		$result = $this->checkResultDeserializer->deserialize($resultSerialization);
+		if ($this->isPossiblyStaleResult($result)) {
 			$result->withMetadata(
-				Metadata::merge( [
+				Metadata::merge([
 					$result->getMetadata(),
-					Metadata::ofCachingMetadata( $cachingMetadata ),
-				] )
+					Metadata::ofCachingMetadata($cachingMetadata),
+				])
 			);
 		}
 		return $result;
@@ -440,8 +439,8 @@ 
 	 * @param CheckResult $result
 	 * @return bool
 	 */
-	private function isPossiblyStaleResult( CheckResult $result ) {
-		if ( $result instanceof NullResult ) {
+	private function isPossiblyStaleResult(CheckResult $result) {
+		if ($result instanceof NullResult) {
 			return false;
 		}
 
@@ -456,14 +455,14 @@ 
 	 * @return int[]|null array from entity ID serializations to revision ID,
 	 * or null to indicate that not all revision IDs could be loaded
 	 */
-	private function getLatestRevisionIds( array $entityIds ) {
-		if ( $entityIds === [] ) {
+	private function getLatestRevisionIds(array $entityIds) {
+		if ($entityIds === []) {
 			$this->loggingHelper->logEmptyDependencyMetadata();
 			return [];
 		}
-		if ( count( $entityIds ) > $this->maxRevisionIds ) {
+		if (count($entityIds) > $this->maxRevisionIds) {
 			// one of those entities will probably be edited soon, so might as well skip caching
-			$this->loggingHelper->logHugeDependencyMetadata( $entityIds, $this->maxRevisionIds );
+			$this->loggingHelper->logHugeDependencyMetadata($entityIds, $this->maxRevisionIds);
 			return null;
 		}
 
@@ -471,7 +470,7 @@ 
 			$entityIds,
 			LookupConstants::LATEST_FROM_REPLICA
 		);
-		if ( $this->hasFalseElements( $latestRevisionIds ) ) {
+		if ($this->hasFalseElements($latestRevisionIds)) {
 			return null;
 		}
 		return $latestRevisionIds;
@@ -481,8 +480,8 @@ 
 	 * @param array $array
 	 * @return bool
 	 */
-	private function hasFalseElements( array $array ) {
-		return in_array( false, $array, true );
+	private function hasFalseElements(array $array) {
+		return in_array(false, $array, true);
 	}
 
 	/**
@@ -490,7 +489,7 @@ 
 	 *
 	 * @param callable $microtime
 	 */
-	public function setMicrotimeFunction( callable $microtime ) {
+	public function setMicrotimeFunction(callable $microtime) {
 		$this->microtime = $microtime;
 	}
 

src/Api/CheckResultsRenderer.php

Spacing +20 added lines, -20 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -41,11 +41,11 @@ 
 		$this->violationMessageRenderer = $violationMessageRenderer;
 	}
 
-	public function render( CachedCheckResults $checkResults ): CachedCheckConstraintsResponse {
+	public function render(CachedCheckResults $checkResults): CachedCheckConstraintsResponse {
 		$response = [];
-		foreach ( $checkResults->getArray() as $checkResult ) {
-			$resultArray = $this->checkResultToArray( $checkResult );
-			$checkResult->getContextCursor()->storeCheckResultInArray( $resultArray, $response );
+		foreach ($checkResults->getArray() as $checkResult) {
+			$resultArray = $this->checkResultToArray($checkResult);
+			$checkResult->getContextCursor()->storeCheckResultInArray($resultArray, $response);
 		}
 		return new CachedCheckConstraintsResponse(
 			$response,
@@ -53,19 +53,19 @@ 
 		);
 	}
 
-	public function checkResultToArray( CheckResult $checkResult ): ?array {
-		if ( $checkResult instanceof NullResult ) {
+	public function checkResultToArray(CheckResult $checkResult): ?array {
+		if ($checkResult instanceof NullResult) {
 			return null;
 		}
 
 		$constraintId = $checkResult->getConstraint()->getConstraintId();
 		$typeItemId = $checkResult->getConstraint()->getConstraintTypeItemId();
-		$constraintPropertyId = new NumericPropertyId( $checkResult->getContextCursor()->getSnakPropertyId() );
+		$constraintPropertyId = new NumericPropertyId($checkResult->getContextCursor()->getSnakPropertyId());
 
-		$title = $this->entityTitleLookup->getTitleForId( $constraintPropertyId );
+		$title = $this->entityTitleLookup->getTitleForId($constraintPropertyId);
 		$talkTitle = $title->getTalkPageIfDefined();
-		$typeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $typeItemId ) );
-		$link = $title->getFullURL() . '#' . $constraintId;
+		$typeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($typeItemId));
+		$link = $title->getFullURL().'#'.$constraintId;
 
 		$constraint = [
 			'id' => $constraintId,
@@ -81,28 +81,28 @@ 
 			'constraint' => $constraint,
 		];
 		$message = $checkResult->getMessage();
-		if ( $message ) {
-			$result['message-html'] = $this->violationMessageRenderer->render( $message );
+		if ($message) {
+			$result['message-html'] = $this->violationMessageRenderer->render($message);
 		}
-		$constraintClarification = $this->renderConstraintClarification( $checkResult );
-		if ( $constraintClarification !== null ) {
+		$constraintClarification = $this->renderConstraintClarification($checkResult);
+		if ($constraintClarification !== null) {
 			$result['constraint-clarification'] = $constraintClarification;
 		}
-		if ( $checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT ) {
+		if ($checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT) {
 			$result['claim'] = $checkResult->getContextCursor()->getStatementGuid();
 		}
 		$cachingMetadataArray = $checkResult->getMetadata()->getCachingMetadata()->toArray();
-		if ( $cachingMetadataArray !== null ) {
+		if ($cachingMetadataArray !== null) {
 			$result['cached'] = $cachingMetadataArray;
 		}
 
 		return $result;
 	}
 
-	private function renderConstraintClarification( CheckResult $result ): ?string {
+	private function renderConstraintClarification(CheckResult $result): ?string {
 		$texts = $result->getConstraintClarification()->getTexts();
-		foreach ( $this->languageFallbackChain->getFetchLanguageCodes() as $languageCode ) {
-			if ( array_key_exists( $languageCode, $texts ) ) {
+		foreach ($this->languageFallbackChain->getFetchLanguageCodes() as $languageCode) {
+			if (array_key_exists($languageCode, $texts)) {
 				return $texts[$languageCode]->getText();
 			}
 		}

src/Api/CheckingResultsSource.php

Spacing +20 added lines, -21 removed lines

@@ -44,57 +44,56 @@
 	) {
 		$results = [];
 		$metadatas = [];
-		$statusesFlipped = array_flip( $statuses );
-		foreach ( $entityIds as $entityId ) {
+		$statusesFlipped = array_flip($statuses);
+		foreach ($entityIds as $entityId) {
 			$entityResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnEntityId(
 				$entityId,
 				$constraintIds,
-				[ $this, 'defaultResultsPerContext' ],
-				[ $this, 'defaultResultsPerEntity' ]
+				[$this, 'defaultResultsPerContext'],
+				[$this, 'defaultResultsPerEntity']
 			);
-			foreach ( $entityResults as $result ) {
+			foreach ($entityResults as $result) {
 				$metadatas[] = $result->getMetadata();
-				if ( $this->statusSelected( $statusesFlipped, $result ) ) {
+				if ($this->statusSelected($statusesFlipped, $result)) {
 					$results[] = $result;
 				}
 			}
 		}
-		foreach ( $claimIds as $claimId ) {
+		foreach ($claimIds as $claimId) {
 			$claimResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnClaimId(
 				$claimId,
 				$constraintIds,
-				[ $this, 'defaultResultsPerContext' ]
+				[$this, 'defaultResultsPerContext']
 			);
-			foreach ( $claimResults as $result ) {
+			foreach ($claimResults as $result) {
 				$metadatas[] = $result->getMetadata();
-				if ( $this->statusSelected( $statusesFlipped, $result ) ) {
+				if ($this->statusSelected($statusesFlipped, $result)) {
 					$results[] = $result;
 				}
 			}
 		}
 		return new CachedCheckResults(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
-	public function defaultResultsPerContext( Context $context ) {
+	public function defaultResultsPerContext(Context $context) {
 		return $context->getType() === Context::TYPE_STATEMENT ?
-			[ new NullResult( $context->getCursor() ) ] :
-			[];
+			[new NullResult($context->getCursor())] : [];
 	}
 
-	public function defaultResultsPerEntity( EntityId $entityId ) {
+	public function defaultResultsPerEntity(EntityId $entityId) {
 		return [
-			( new NullResult( new EntityContextCursor( $entityId->getSerialization() ) ) )
-				->withMetadata( Metadata::ofDependencyMetadata(
-					DependencyMetadata::ofEntityId( $entityId )
-				) ),
+			(new NullResult(new EntityContextCursor($entityId->getSerialization())))
+				->withMetadata(Metadata::ofDependencyMetadata(
+					DependencyMetadata::ofEntityId($entityId)
+				)),
 		];
 	}
 
-	public function statusSelected( array $statusesFlipped, CheckResult $result ) {
-		return array_key_exists( $result->getStatus(), $statusesFlipped ) ||
+	public function statusSelected(array $statusesFlipped, CheckResult $result) {
+		return array_key_exists($result->getStatus(), $statusesFlipped) ||
 			$result instanceof NullResult;
 	}
 

src/ConstraintCheck/Result/CheckResultDeserializer.php

Spacing +25 added lines, -25 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Result;
 
@@ -40,13 +40,13 @@ 
 		$this->entityIdParser = $entityIdParser;
 	}
 
-	public function deserialize( array $serialization ): CheckResult {
+	public function deserialize(array $serialization): CheckResult {
 		$contextCursor = $this->contextCursorDeserializer->deserialize(
 			$serialization[CheckResultSerializer::KEY_CONTEXT_CURSOR]
 		);
 
-		if ( array_key_exists( CheckResultSerializer::KEY_NULL_RESULT, $serialization ) ) {
-			$result = new NullResult( $contextCursor );
+		if (array_key_exists(CheckResultSerializer::KEY_NULL_RESULT, $serialization)) {
+			$result = new NullResult($contextCursor);
 			$cachingMetadata = CachingMetadata::fresh();
 		} else {
 			$constraint = $this->constraintDeserializer->deserialize(
@@ -57,7 +57,7 @@ 
 
 			$status = $serialization[CheckResultSerializer::KEY_CHECK_RESULT_STATUS];
 
-			$violationMessage = $this->getViolationMessageFromSerialization( $serialization );
+			$violationMessage = $this->getViolationMessageFromSerialization($serialization);
 
 			$result = new CheckResult(
 				$contextCursor,
@@ -68,7 +68,7 @@ 
 			);
 
 			$result->setConstraintClarification(
-				$this->getConstraintClarificationFromSerialization( $serialization )
+				$this->getConstraintClarificationFromSerialization($serialization)
 			);
 
 			$cachingMetadata = $this->deserializeCachingMetadata(
@@ -76,18 +76,18 @@ 
 			);
 		}
 
-		$dependencyMetadata = $this->getDependencyMetadataFromSerialization( $serialization );
+		$dependencyMetadata = $this->getDependencyMetadataFromSerialization($serialization);
 
 		return $result->withMetadata(
-			Metadata::merge( [
-				Metadata::ofCachingMetadata( $cachingMetadata ),
-				Metadata::ofDependencyMetadata( $dependencyMetadata ),
-			] )
+			Metadata::merge([
+				Metadata::ofCachingMetadata($cachingMetadata),
+				Metadata::ofDependencyMetadata($dependencyMetadata),
+			])
 		);
 	}
 
-	private function getViolationMessageFromSerialization( array $serialization ): ?ViolationMessage {
-		if ( array_key_exists( CheckResultSerializer::KEY_VIOLATION_MESSAGE, $serialization ) ) {
+	private function getViolationMessageFromSerialization(array $serialization): ?ViolationMessage {
+		if (array_key_exists(CheckResultSerializer::KEY_VIOLATION_MESSAGE, $serialization)) {
 			return $this->violationMessageDeserializer->deserialize(
 				$serialization[CheckResultSerializer::KEY_VIOLATION_MESSAGE]
 			);
@@ -99,17 +99,17 @@ 
 	private function getConstraintClarificationFromSerialization(
 		array $serialization
 	): MultilingualTextValue {
-		if ( array_key_exists( CheckResultSerializer::KEY_CONSTRAINT_CLARIFICATION, $serialization ) ) {
+		if (array_key_exists(CheckResultSerializer::KEY_CONSTRAINT_CLARIFICATION, $serialization)) {
 			return MultilingualTextValue::newFromArray(
 				$serialization[CheckResultSerializer::KEY_CONSTRAINT_CLARIFICATION]
 			);
 		} else {
-			return new MultilingualTextValue( [] );
+			return new MultilingualTextValue([]);
 		}
 	}
 
-	private function getDependencyMetadataFromSerialization( array $serialization ): DependencyMetadata {
-		if ( array_key_exists( CheckResultSerializer::KEY_DEPENDENCY_METADATA, $serialization ) ) {
+	private function getDependencyMetadataFromSerialization(array $serialization): DependencyMetadata {
+		if (array_key_exists(CheckResultSerializer::KEY_DEPENDENCY_METADATA, $serialization)) {
 			return $this->deserializeDependencyMetadata(
 				$serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA]
 			);
@@ -118,7 +118,7 @@ 
 		}
 	}
 
-	private function deserializeCachingMetadata( array $serialization ): CachingMetadata {
+	private function deserializeCachingMetadata(array $serialization): CachingMetadata {
 		if (
 			array_key_exists(
 				CheckResultSerializer::KEY_CACHING_METADATA_MAX_AGE,
@@ -133,7 +133,7 @@ 
 		}
 	}
 
-	private function deserializeDependencyMetadata( array $serialization ): DependencyMetadata {
+	private function deserializeDependencyMetadata(array $serialization): DependencyMetadata {
 		if (
 			array_key_exists(
 				CheckResultSerializer::KEY_DEPENDENCY_METADATA_FUTURE_TIME,
@@ -143,20 +143,20 @@ 
 			$futureTime = TimeValue::newFromArray(
 				$serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA_FUTURE_TIME]
 			);
-			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime );
+			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime);
 		} else {
 			$futureTimeDependencyMetadata = DependencyMetadata::blank();
 		}
 
 		$dependencyMetadata = array_reduce(
 			$serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA_ENTITY_IDS],
-			function ( DependencyMetadata $metadata, $entityIdSerialization ) {
-				$entityId = $this->entityIdParser->parse( $entityIdSerialization );
+			function(DependencyMetadata $metadata, $entityIdSerialization) {
+				$entityId = $this->entityIdParser->parse($entityIdSerialization);
 
-				return DependencyMetadata::merge( [
+				return DependencyMetadata::merge([
 					$metadata,
-					DependencyMetadata::ofEntityId( $entityId ),
-				] );
+					DependencyMetadata::ofEntityId($entityId),
+				]);
 			},
 			$futureTimeDependencyMetadata
 		);

src/Specials/SpecialConstraintReport.php

Spacing +82 added lines, -82 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Specials;
 
@@ -97,7 +97,7 @@ 
 		Config $config,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( 'ConstraintReport' );
+		parent::__construct('ConstraintReport');
 
 		$this->entityLookup = $entityLookup;
 		$this->entityTitleLookup = $entityTitleLookup;
@@ -106,7 +106,7 @@ 
 		$language = $this->getLanguage();
 
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
 		$dataValueFormatter = $valueFormatterFactory->getValueFormatter(
 			SnakFormatter::FORMAT_HTML,
 			$formatterOptions
@@ -130,7 +130,7 @@ 
 		);
 		$this->violationMessageRenderer = $violationMessageRendererFactory->getViolationMessageRenderer(
 			$language,
-			$languageFallbackChainFactory->newFromLanguage( $language ),
+			$languageFallbackChainFactory->newFromLanguage($language),
 			$this->getContext()
 		);
 
@@ -166,7 +166,7 @@ 
 	 * @return string
 	 */
 	public function getDescription() {
-		return $this->msg( 'wbqc-constraintreport' )->text();
+		return $this->msg('wbqc-constraintreport')->text();
 	}
 
 	/**
@@ -178,43 +178,43 @@ 
 	 * @throws EntityIdParsingException
 	 * @throws UnexpectedValueException
 	 */
-	public function execute( $subPage ) {
+	public function execute($subPage) {
 		$out = $this->getOutput();
 
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
-		if ( $postRequest ) {
-			$out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() );
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
+		if ($postRequest) {
+			$out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL());
 			return;
 		}
 
 		$out->enableOOUI();
-		$out->addModules( $this->getModules() );
+		$out->addModules($this->getModules());
 
 		$this->setHeaders();
 
-		$out->addHTML( $this->getExplanationText() );
+		$out->addHTML($this->getExplanationText());
 		$this->buildEntityIdForm();
 
-		if ( !$subPage ) {
+		if (!$subPage) {
 			return;
 		}
 
-		if ( !is_string( $subPage ) ) {
-			throw new InvalidArgumentException( '$subPage must be string.' );
+		if (!is_string($subPage)) {
+			throw new InvalidArgumentException('$subPage must be string.');
 		}
 
 		try {
-			$entityId = $this->entityIdParser->parse( $subPage );
-		} catch ( EntityIdParsingException $e ) {
+			$entityId = $this->entityIdParser->parse($subPage);
+		} catch (EntityIdParsingException $e) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
 			);
 			return;
 		}
 
-		if ( !$this->entityLookup->hasEntity( $entityId ) ) {
+		if (!$this->entityLookup->hasEntity($entityId)) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true )
+				$this->buildNotice('wbqc-constraintreport-not-existent-entity', true)
 			);
 			return;
 		}
@@ -222,18 +222,18 @@ 
 		$this->dataFactory->increment(
 			'wikibase.quality.constraints.specials.specialConstraintReport.executeCheck'
 		);
-		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId );
+		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId);
 
-		if ( $results !== [] ) {
+		if ($results !== []) {
 			$out->addHTML(
-				$this->buildResultHeader( $entityId )
-				. $this->buildSummary( $results )
-				. $this->buildResultTable( $entityId, $results )
+				$this->buildResultHeader($entityId)
+				. $this->buildSummary($results)
+				. $this->buildResultTable($entityId, $results)
 			);
 		} else {
 			$out->addHTML(
-				$this->buildResultHeader( $entityId )
-				. $this->buildNotice( 'wbqc-constraintreport-empty-result' )
+				$this->buildResultHeader($entityId)
+				. $this->buildNotice('wbqc-constraintreport-empty-result')
 			);
 		}
 	}
@@ -249,15 +249,15 @@ 
 				'name' => 'entityid',
 				'label-message' => 'wbqc-constraintreport-form-entityid-label',
 				'cssclass' => 'wbqc-constraintreport-form-entity-id',
-				'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->escaped(),
+				'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->escaped(),
 			],
 		];
-		$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form' );
-		$htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->escaped() );
-		$htmlForm->setSubmitCallback( static function () {
+		$htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form');
+		$htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->escaped());
+		$htmlForm->setSubmitCallback(static function() {
 			return false;
 		} );
-		$htmlForm->setMethod( 'post' );
+		$htmlForm->setMethod('post');
 		$htmlForm->show();
 	}
 
@@ -271,9 +271,9 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildNotice( string $messageKey, bool $error = false ): string {
+	private function buildNotice(string $messageKey, bool $error = false): string {
 		$cssClasses = 'wbqc-constraintreport-notice';
-		if ( $error ) {
+		if ($error) {
 			$cssClasses .= ' wbqc-constraintreport-notice-error';
 		}
 
@@ -282,7 +282,7 @@ 
 				[
 					'class' => $cssClasses,
 				],
-				$this->msg( $messageKey )->escaped()
+				$this->msg($messageKey)->escaped()
 			);
 	}
 
@@ -292,16 +292,16 @@ 
 	private function getExplanationText(): string {
 		return Html::rawElement(
 			'div',
-			[ 'class' => 'wbqc-explanation' ],
+			['class' => 'wbqc-explanation'],
 			Html::rawElement(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-one' )->escaped()
+				$this->msg('wbqc-constraintreport-explanation-part-one')->escaped()
 			)
 			. Html::rawElement(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-two' )->escaped()
+				$this->msg('wbqc-constraintreport-explanation-part-two')->escaped()
 			)
 		);
 	}
@@ -313,31 +313,31 @@ 
 	 * @return string HTML
 	 * @suppress SecurityCheck-DoubleEscaped
 	 */
-	private function buildResultTable( EntityId $entityId, array $results ): string {
+	private function buildResultTable(EntityId $entityId, array $results): string {
 		// Set table headers
 		$table = new HtmlTableBuilder(
 			[
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-status' )->escaped(),
+					$this->msg('wbqc-constraintreport-result-table-header-status')->escaped(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-property' )->escaped(),
+					$this->msg('wbqc-constraintreport-result-table-header-property')->escaped(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-message' )->escaped(),
+					$this->msg('wbqc-constraintreport-result-table-header-message')->escaped(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->escaped(),
+					$this->msg('wbqc-constraintreport-result-table-header-constraint')->escaped(),
 					true
 				),
 			]
 		);
 
-		foreach ( $results as $result ) {
-			$table = $this->appendToResultTable( $table, $entityId, $result );
+		foreach ($results as $result) {
+			$table = $this->appendToResultTable($table, $entityId, $result);
 		}
 
 		return $table->toHtml();
@@ -349,40 +349,40 @@ 
 		CheckResult $result
 	): HtmlTableBuilder {
 		$message = $result->getMessage();
-		if ( $message === null ) {
+		if ($message === null) {
 			// no row for this result
 			return $table;
 		}
 
 		// Status column
-		$statusColumn = $this->formatStatus( $result->getStatus() );
+		$statusColumn = $this->formatStatus($result->getStatus());
 
 		// Property column
-		$propertyId = new NumericPropertyId( $result->getContextCursor()->getSnakPropertyId() );
+		$propertyId = new NumericPropertyId($result->getContextCursor()->getSnakPropertyId());
 		$propertyColumn = $this->getClaimLink(
 			$entityId,
 			$propertyId,
-			$this->entityIdLabelFormatter->formatEntityId( $propertyId )
+			$this->entityIdLabelFormatter->formatEntityId($propertyId)
 		);
 
 		// Message column
-		$messageColumn = $this->violationMessageRenderer->render( $message );
+		$messageColumn = $this->violationMessageRenderer->render($message);
 
 		// Constraint column
 		$constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId();
 		try {
-			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) );
-		} catch ( InvalidArgumentException $e ) {
-			$constraintTypeLabel = htmlspecialchars( $constraintTypeItemId );
+			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId));
+		} catch (InvalidArgumentException $e) {
+			$constraintTypeLabel = htmlspecialchars($constraintTypeItemId);
 		}
 		$constraintLink = $this->getClaimLink(
 			$propertyId,
-			new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ),
+			new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')),
 			$constraintTypeLabel
 		);
 		$constraintColumn = $this->buildExpandableElement(
 			$constraintLink,
-			$this->constraintParameterRenderer->formatParameters( $result->getParameters() ),
+			$this->constraintParameterRenderer->formatParameters($result->getParameters()),
 			'[...]'
 		);
 
@@ -422,15 +422,15 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildResultHeader( EntityId $entityId ): string {
-		$entityLink = sprintf( '%s (%s)',
-							   $this->entityIdLinkFormatter->formatEntityId( $entityId ),
-							   htmlspecialchars( $entityId->getSerialization() ) );
+	protected function buildResultHeader(EntityId $entityId): string {
+		$entityLink = sprintf('%s (%s)',
+							   $this->entityIdLinkFormatter->formatEntityId($entityId),
+							   htmlspecialchars($entityId->getSerialization()));
 
 		return Html::rawElement(
 			'h3',
 			[],
-			sprintf( '%s %s', $this->msg( 'wbqc-constraintreport-result-headline' )->escaped(), $entityLink )
+			sprintf('%s %s', $this->msg('wbqc-constraintreport-result-headline')->escaped(), $entityLink)
 		);
 	}
 
@@ -441,24 +441,24 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildSummary( array $results ): string {
+	protected function buildSummary(array $results): string {
 		$statuses = [];
-		foreach ( $results as $result ) {
-			$status = strtolower( $result->getStatus() );
-			$statuses[$status] = isset( $statuses[$status] ) ? $statuses[$status] + 1 : 1;
+		foreach ($results as $result) {
+			$status = strtolower($result->getStatus());
+			$statuses[$status] = isset($statuses[$status]) ? $statuses[$status] + 1 : 1;
 		}
 
 		$statusElements = [];
-		foreach ( $statuses as $status => $count ) {
-			if ( $count > 0 ) {
+		foreach ($statuses as $status => $count) {
+			if ($count > 0) {
 				$statusElements[] =
-					$this->formatStatus( $status )
+					$this->formatStatus($status)
 					. ': '
 					. $count;
 			}
 		}
 
-		return Html::rawElement( 'p', [], implode( ', ', $statusElements ) );
+		return Html::rawElement('p', [], implode(', ', $statusElements));
 	}
 
 	/**
@@ -478,7 +478,7 @@ 
 		?string $expandableContent,
 		string $indicator
 	): string {
-		if ( empty( $expandableContent ) ) {
+		if (empty($expandableContent)) {
 			return $content;
 		}
 
@@ -498,7 +498,7 @@ 
 			$expandableContent
 		);
 
-		return sprintf( '%s %s %s', $content, $tooltipIndicator, $wrappedExpandableContent );
+		return sprintf('%s %s %s', $content, $tooltipIndicator, $wrappedExpandableContent);
 	}
 
 	/**
@@ -510,8 +510,8 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function formatStatus( string $status ): string {
-		$messageName = "wbqc-constraintreport-status-" . strtolower( $status );
+	private function formatStatus(string $status): string {
+		$messageName = "wbqc-constraintreport-status-".strtolower($status);
 		$statusIcons = [
 			CheckResult::STATUS_SUGGESTION => [
 				'icon' => 'suggestion-constraint-violation',
@@ -528,25 +528,25 @@ 
 			],
 		];
 
-		if ( array_key_exists( $status, $statusIcons ) ) {
-			$iconWidget = new IconWidget( $statusIcons[$status] );
-			$iconHtml = $iconWidget->toString() . ' ';
+		if (array_key_exists($status, $statusIcons)) {
+			$iconWidget = new IconWidget($statusIcons[$status]);
+			$iconHtml = $iconWidget->toString().' ';
 		} else {
 			$iconHtml = '';
 		}
 
-		$labelWidget = new LabelWidget( [
-			'label' => $this->msg( $messageName )->text(),
-		] );
+		$labelWidget = new LabelWidget([
+			'label' => $this->msg($messageName)->text(),
+		]);
 		$labelHtml = $labelWidget->toString();
 
 		$formattedStatus =
 			Html::rawElement(
 				'span',
 				[
-					'class' => 'wbqc-status wbqc-status-' . $status,
+					'class' => 'wbqc-status wbqc-status-'.$status,
 				],
-				$iconHtml . $labelHtml
+				$iconHtml.$labelHtml
 			);
 
 		return $formattedStatus;
@@ -569,7 +569,7 @@ 
 		return Html::rawElement(
 			'a',
 			[
-				'href' => $this->getClaimUrl( $entityId, $propertyId ),
+				'href' => $this->getClaimUrl($entityId, $propertyId),
 				'target' => '_blank',
 			],
 			$text
@@ -583,8 +583,8 @@ 
 		EntityId $entityId,
 		NumericPropertyId $propertyId
 	): string {
-		$title = $this->entityTitleLookup->getTitleForId( $entityId );
-		$entityUrl = sprintf( '%s#%s', $title->getLocalURL(), $propertyId->getSerialization() );
+		$title = $this->entityTitleLookup->getTitleForId($entityId);
+		$entityUrl = sprintf('%s#%s', $title->getLocalURL(), $propertyId->getSerialization());
 
 		return $entityUrl;
 	}

src/ConstraintRepositoryStore.php

Spacing +12 added lines, -12 removed lines

@@ -24,16 +24,16 @@ 
 	 * then using the main DBLoadBalancer service may be incorrect.
 	 * @param string|false $dbName Database name ($domain for ILoadBalancer methods).
 	 */
-	public function __construct( ILoadBalancer $lb, $dbName ) {
+	public function __construct(ILoadBalancer $lb, $dbName) {
 		$this->lb = $lb;
 		$this->dbName = $dbName;
 	}
 
-	private function encodeConstraintParameters( array $constraintParameters ) {
-		$json = json_encode( $constraintParameters, JSON_FORCE_OBJECT );
+	private function encodeConstraintParameters(array $constraintParameters) {
+		$json = json_encode($constraintParameters, JSON_FORCE_OBJECT);
 
-		if ( strlen( $json ) > 50000 ) {
-			$json = json_encode( [ '@error' => [ 'toolong' => true ] ] );
+		if (strlen($json) > 50000) {
+			$json = json_encode(['@error' => ['toolong' => true]]);
 		}
 
 		return $json;
@@ -45,21 +45,21 @@ 
 	 * @throws DBUnexpectedError
 	 * @return bool
 	 */
-	public function insertBatch( array $constraints ) {
+	public function insertBatch(array $constraints) {
 		$accumulator = array_map(
-			function ( Constraint $constraint ) {
+			function(Constraint $constraint) {
 				return [
 					'constraint_guid' => $constraint->getConstraintId(),
 					'pid' => $constraint->getPropertyId()->getNumericId(),
 					'constraint_type_qid' => $constraint->getConstraintTypeItemId(),
-					'constraint_parameters' => $this->encodeConstraintParameters( $constraint->getConstraintParameters() ),
+					'constraint_parameters' => $this->encodeConstraintParameters($constraint->getConstraintParameters()),
 				];
 			},
 			$constraints
 		);
 
-		$dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName );
-		return $dbw->insert( 'wbqc_constraints', $accumulator, __METHOD__ );
+		$dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName);
+		return $dbw->insert('wbqc_constraints', $accumulator, __METHOD__);
 	}
 
 	/**
@@ -69,8 +69,8 @@ 
 	 *
 	 * @throws DBUnexpectedError
 	 */
-	public function deleteForProperty( NumericPropertyId $propertyId ) {
-		$dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName );
+	public function deleteForProperty(NumericPropertyId $propertyId) {
+		$dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName);
 		$dbw->delete(
 			'wbqc_constraints',
 			[

maintenance/ImportConstraintEntities.php

Spacing +59 added lines, -59 removed lines

@@ -18,10 +18,10 @@ 
 use Wikibase\Repo\WikibaseRepo;
 
 // @codeCoverageIgnoreStart
-$basePath = getenv( "MW_INSTALL_PATH" ) !== false
-	? getenv( "MW_INSTALL_PATH" ) : __DIR__ . "/../../..";
+$basePath = getenv("MW_INSTALL_PATH") !== false
+	? getenv("MW_INSTALL_PATH") : __DIR__."/../../..";
 
-require_once $basePath . "/maintenance/Maintenance.php";
+require_once $basePath."/maintenance/Maintenance.php";
 // @codeCoverageIgnoreEnd
 
 /**
@@ -60,20 +60,20 @@ 
 		parent::__construct();
 
 		$this->addDescription(
-			'Import entities needed for constraint checks ' .
+			'Import entities needed for constraint checks '.
 			'from Wikidata into the local repository.'
 		);
 		$this->addOption(
 			'config-format',
-			'The format in which the resulting configuration will be omitted: ' .
-			'"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), ' .
+			'The format in which the resulting configuration will be omitted: '.
+			'"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), '.
 			'or "wgConf" for printing parts of arrays suitable for inclusion in $wgConf->settings.'
 		);
 		$this->addOption(
 			'dry-run',
 			'Don’t actually import entities, just print which ones would be imported.'
 		);
-		$this->requireExtension( 'WikibaseQualityConstraints' );
+		$this->requireExtension('WikibaseQualityConstraints');
 	}
 
 	/**
@@ -81,12 +81,12 @@ 
 	 */
 	private function setupServices() {
 		$services = MediaWikiServices::getInstance();
-		$this->entitySerializer = WikibaseRepo::getAllTypesEntitySerializer( $services );
-		$this->entityDeserializer = WikibaseRepo::getInternalFormatEntityDeserializer( $services );
-		$this->entityStore = WikibaseRepo::getEntityStore( $services );
+		$this->entitySerializer = WikibaseRepo::getAllTypesEntitySerializer($services);
+		$this->entityDeserializer = WikibaseRepo::getInternalFormatEntityDeserializer($services);
+		$this->entityStore = WikibaseRepo::getEntityStore($services);
 		$this->httpRequestFactory = $services->getHttpRequestFactory();
-		if ( !$this->getOption( 'dry-run', false ) ) {
-			$this->user = User::newSystemUser( 'WikibaseQualityConstraints importer' );
+		if (!$this->getOption('dry-run', false)) {
+			$this->user = User::newSystemUser('WikibaseQualityConstraints importer');
 		}
 	}
 
@@ -95,21 +95,21 @@ 
 
 		$configUpdates = [];
 
-		$extensionJsonFile = __DIR__ . '/../extension.json';
-		$extensionJsonText = file_get_contents( $extensionJsonFile );
-		$extensionJson = json_decode( $extensionJsonText, /* assoc = */ true );
+		$extensionJsonFile = __DIR__.'/../extension.json';
+		$extensionJsonText = file_get_contents($extensionJsonFile);
+		$extensionJson = json_decode($extensionJsonText, /* assoc = */ true);
 		// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
-		$wikidataEntityIds = $this->getEntitiesToImport( $extensionJson['config'], $this->getConfig() );
+		$wikidataEntityIds = $this->getEntitiesToImport($extensionJson['config'], $this->getConfig());
 
-		foreach ( $wikidataEntityIds as $key => $wikidataEntityId ) {
-			$localEntityId = $this->importEntityFromWikidata( $wikidataEntityId );
+		foreach ($wikidataEntityIds as $key => $wikidataEntityId) {
+			$localEntityId = $this->importEntityFromWikidata($wikidataEntityId);
 			$configUpdates[$key] = [
 				'wikidata' => $wikidataEntityId,
 				'local' => $localEntityId,
 			];
 		}
 
-		$this->outputConfigUpdates( $configUpdates );
+		$this->outputConfigUpdates($configUpdates);
 	}
 
 	/**
@@ -117,18 +117,18 @@ 
 	 * @param Config $wikiConfig
 	 * @return string[]
 	 */
-	private function getEntitiesToImport( array $extensionJsonConfig, Config $wikiConfig ) {
+	private function getEntitiesToImport(array $extensionJsonConfig, Config $wikiConfig) {
 		$wikidataEntityIds = [];
 
-		foreach ( $extensionJsonConfig as $key => $value ) {
-			if ( !preg_match( '/Id$/', $key ) ) {
+		foreach ($extensionJsonConfig as $key => $value) {
+			if (!preg_match('/Id$/', $key)) {
 				continue;
 			}
 
 			$wikidataEntityId = $value['value'];
-			$localEntityId = $wikiConfig->get( $key );
+			$localEntityId = $wikiConfig->get($key);
 
-			if ( $localEntityId === $wikidataEntityId ) {
+			if ($localEntityId === $wikidataEntityId) {
 				$wikidataEntityIds[$key] = $wikidataEntityId;
 			}
 		}
@@ -140,10 +140,10 @@ 
 	 * @param string $wikidataEntityId
 	 * @return string local entity ID
 	 */
-	private function importEntityFromWikidata( $wikidataEntityId ) {
+	private function importEntityFromWikidata($wikidataEntityId) {
 		$wikidataEntityUrl = "https://www.wikidata.org/wiki/Special:EntityData/$wikidataEntityId.json";
-		$wikidataEntitiesJson = $this->httpRequestFactory->get( $wikidataEntityUrl, [], __METHOD__ );
-		return $this->importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson );
+		$wikidataEntitiesJson = $this->httpRequestFactory->get($wikidataEntityUrl, [], __METHOD__);
+		return $this->importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson);
 	}
 
 	/**
@@ -151,24 +151,24 @@ 
 	 * @param string $wikidataEntitiesJson
 	 * @return string local entity ID
 	 */
-	private function importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson ) {
+	private function importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson) {
 		// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
-		$wikidataEntityArray = json_decode( $wikidataEntitiesJson, true )['entities'][$wikidataEntityId];
-		$wikidataEntity = $this->entityDeserializer->deserialize( $wikidataEntityArray );
+		$wikidataEntityArray = json_decode($wikidataEntitiesJson, true)['entities'][$wikidataEntityId];
+		$wikidataEntity = $this->entityDeserializer->deserialize($wikidataEntityArray);
 
-		$wikidataEntity->setId( null );
+		$wikidataEntity->setId(null);
 
-		if ( $wikidataEntity instanceof StatementListProvider ) {
+		if ($wikidataEntity instanceof StatementListProvider) {
 			$wikidataEntity->getStatements()->clear();
 		}
 
-		if ( $wikidataEntity instanceof Item ) {
-			$wikidataEntity->setSiteLinkList( new SiteLinkList() );
+		if ($wikidataEntity instanceof Item) {
+			$wikidataEntity->setSiteLinkList(new SiteLinkList());
 		}
 
-		if ( $this->getOption( 'dry-run', false ) ) {
-			$wikidataEntityJson = json_encode( $this->entitySerializer->serialize( $wikidataEntity ) );
-			$this->output( $wikidataEntityJson . "\n" );
+		if ($this->getOption('dry-run', false)) {
+			$wikidataEntityJson = json_encode($this->entitySerializer->serialize($wikidataEntity));
+			$this->output($wikidataEntityJson."\n");
 			return "-$wikidataEntityId";
 		}
 
@@ -181,12 +181,12 @@ 
 			)->getEntity();
 
 			return $localEntity->getId()->getSerialization();
-		} catch ( StorageException $storageException ) {
-			return $this->storageExceptionToEntityId( $storageException );
+		} catch (StorageException $storageException) {
+			return $this->storageExceptionToEntityId($storageException);
 		}
 	}
 
-	private function storageExceptionToEntityId( StorageException $storageException ) {
+	private function storageExceptionToEntityId(StorageException $storageException) {
 		$message = $storageException->getMessage();
 		// example messages:
 		// * Item [[Item:Q475|Q475]] already has label "as references"
@@ -196,25 +196,25 @@ 
 		// * Property [[Property:P694|P694]] already has label "instance of"
 		//   associated with language code en.
 		$pattern = '/[[|]([^][|]*)]] already has label .* associated with language code/';
-		if ( preg_match( $pattern, $message, $matches ) ) {
+		if (preg_match($pattern, $message, $matches)) {
 			return $matches[1];
 		} else {
 			throw $storageException;
 		}
 	}
 
-	private function outputConfigUpdates( array $configUpdates ) {
-		$configFormat = $this->getOption( 'config-format', 'globals' );
-		switch ( $configFormat ) {
+	private function outputConfigUpdates(array $configUpdates) {
+		$configFormat = $this->getOption('config-format', 'globals');
+		switch ($configFormat) {
 			case 'globals':
-				$this->outputConfigUpdatesGlobals( $configUpdates );
+				$this->outputConfigUpdatesGlobals($configUpdates);
 				break;
 			case 'wgConf':
-				$this->outputConfigUpdatesWgConf( $configUpdates );
+				$this->outputConfigUpdatesWgConf($configUpdates);
 				break;
 			default:
-				$this->error( "Invalid config format \"$configFormat\", using \"globals\"" );
-				$this->outputConfigUpdatesGlobals( $configUpdates );
+				$this->error("Invalid config format \"$configFormat\", using \"globals\"");
+				$this->outputConfigUpdatesGlobals($configUpdates);
 				break;
 		}
 	}
@@ -222,22 +222,22 @@ 
 	/**
 	 * @param array[] $configUpdates
 	 */
-	private function outputConfigUpdatesGlobals( array $configUpdates ) {
-		foreach ( $configUpdates as $key => $value ) {
-			$localValueCode = var_export( $value['local'], true );
-			$this->output( "\$wg$key = $localValueCode;\n" );
+	private function outputConfigUpdatesGlobals(array $configUpdates) {
+		foreach ($configUpdates as $key => $value) {
+			$localValueCode = var_export($value['local'], true);
+			$this->output("\$wg$key = $localValueCode;\n");
 		}
 	}
 
 	/**
 	 * @param array[] $configUpdates
 	 */
-	private function outputConfigUpdatesWgConf( array $configUpdates ) {
-		$wikiIdCode = var_export( WikiMap::getCurrentWikiId(), true );
-		foreach ( $configUpdates as $key => $value ) {
-			$keyCode = var_export( "wg$key", true );
-			$wikidataValueCode = var_export( $value['wikidata'], true );
-			$localValueCode = var_export( $value['local'], true );
+	private function outputConfigUpdatesWgConf(array $configUpdates) {
+		$wikiIdCode = var_export(WikiMap::getCurrentWikiId(), true);
+		foreach ($configUpdates as $key => $value) {
+			$keyCode = var_export("wg$key", true);
+			$wikidataValueCode = var_export($value['wikidata'], true);
+			$localValueCode = var_export($value['local'], true);
 			$block = <<< EOF
 $keyCode => [
 	'default' => $wikidataValueCode,
@@ -246,7 +246,7 @@ 
 
 
 EOF;
-			$this->output( $block );
+			$this->output($block);
 		}
 	}
 

src/ServiceWiring.php

Spacing +143 added lines, -143 removed lines

@@ -30,53 +30,53 @@ 
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer;
 
 return [
-	ConstraintsServices::EXPIRY_LOCK => static function ( MediaWikiServices $services ) {
-		return new ExpiryLock( ObjectCache::getInstance( CACHE_ANYTHING ) );
+	ConstraintsServices::EXPIRY_LOCK => static function(MediaWikiServices $services) {
+		return new ExpiryLock(ObjectCache::getInstance(CACHE_ANYTHING));
 	},
 
-	ConstraintsServices::LOGGING_HELPER => static function ( MediaWikiServices $services ) {
+	ConstraintsServices::LOGGING_HELPER => static function(MediaWikiServices $services) {
 		return new LoggingHelper(
 			$services->getStatsdDataFactory(),
-			LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
+			LoggerFactory::getInstance('WikibaseQualityConstraints'),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_STORE => static function ( MediaWikiServices $services ) {
-		$sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services );
-		$propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE );
-		if ( $propertySource === null ) {
-			throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' );
+	ConstraintsServices::CONSTRAINT_STORE => static function(MediaWikiServices $services) {
+		$sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services);
+		$propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE);
+		if ($propertySource === null) {
+			throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.');
 		}
 
-		$localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName();
-		if ( $propertySource->getSourceName() !== $localEntitySourceName ) {
-			throw new RuntimeException( 'Can\'t get a ConstraintStore for a non local entity source.' );
+		$localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName();
+		if ($propertySource->getSourceName() !== $localEntitySourceName) {
+			throw new RuntimeException('Can\'t get a ConstraintStore for a non local entity source.');
 		}
 
 		$dbName = $propertySource->getDatabaseName();
 		return new ConstraintRepositoryStore(
-			$services->getDBLoadBalancerFactory()->getMainLB( $dbName ),
+			$services->getDBLoadBalancerFactory()->getMainLB($dbName),
 			$dbName
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_LOOKUP => static function ( MediaWikiServices $services ) {
-		$sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services );
-		$propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE );
-		if ( $propertySource === null ) {
-			throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' );
+	ConstraintsServices::CONSTRAINT_LOOKUP => static function(MediaWikiServices $services) {
+		$sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services);
+		$propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE);
+		if ($propertySource === null) {
+			throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.');
 		}
 
 		$dbName = $propertySource->getDatabaseName();
 		$rawLookup = new ConstraintRepositoryLookup(
-			$services->getDBLoadBalancerFactory()->getMainLB( $dbName ),
+			$services->getDBLoadBalancerFactory()->getMainLB($dbName),
 			$dbName
 		);
-		return new CachingConstraintLookup( $rawLookup );
+		return new CachingConstraintLookup($rawLookup);
 	},
 
-	ConstraintsServices::CHECK_RESULT_SERIALIZER => static function ( MediaWikiServices $services ) {
+	ConstraintsServices::CHECK_RESULT_SERIALIZER => static function(MediaWikiServices $services) {
 		return new CheckResultSerializer(
 			new ConstraintSerializer(
 				false // constraint parameters are not exposed
@@ -87,9 +87,9 @@ 
 		);
 	},
 
-	ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function ( MediaWikiServices $services ) {
-		$entityIdParser = WikibaseRepo::getEntityIdParser( $services );
-		$dataValueFactory = WikibaseRepo::getDataValueFactory( $services );
+	ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function(MediaWikiServices $services) {
+		$entityIdParser = WikibaseRepo::getEntityIdParser($services);
+		$dataValueFactory = WikibaseRepo::getDataValueFactory($services);
 
 		return new CheckResultDeserializer(
 			new ConstraintDeserializer(),
@@ -102,13 +102,13 @@ 
 		);
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function ( MediaWikiServices $services ) {
+	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function(MediaWikiServices $services) {
 		return new ViolationMessageSerializer();
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function ( MediaWikiServices $services ) {
-		$entityIdParser = WikibaseRepo::getEntityIdParser( $services );
-		$dataValueFactory = WikibaseRepo::getDataValueFactory( $services );
+	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function(MediaWikiServices $services) {
+		$entityIdParser = WikibaseRepo::getEntityIdParser($services);
+		$dataValueFactory = WikibaseRepo::getDataValueFactory($services);
 
 		return new ViolationMessageDeserializer(
 			$entityIdParser,
@@ -116,37 +116,37 @@ 
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function ( MediaWikiServices $services ) {
-		$deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory( $services );
-		$entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services );
+	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function(MediaWikiServices $services) {
+		$deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory($services);
+		$entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services);
 
 		return new ConstraintParameterParser(
 			$services->getMainConfig(),
 			$deserializerFactory,
-			$entitySourceDefinitions->getDatabaseSourceForEntityType( 'item' )->getConceptBaseUri()
+			$entitySourceDefinitions->getDatabaseSourceForEntityType('item')->getConceptBaseUri()
 		);
 	},
 
-	ConstraintsServices::CONNECTION_CHECKER_HELPER => static function ( MediaWikiServices $services ) {
+	ConstraintsServices::CONNECTION_CHECKER_HELPER => static function(MediaWikiServices $services) {
 		return new ConnectionCheckerHelper();
 	},
 
-	ConstraintsServices::RANGE_CHECKER_HELPER => static function ( MediaWikiServices $services ) {
+	ConstraintsServices::RANGE_CHECKER_HELPER => static function(MediaWikiServices $services) {
 		return new RangeCheckerHelper(
 			$services->getMainConfig(),
-			WikibaseRepo::getUnitConverter( $services )
+			WikibaseRepo::getUnitConverter($services)
 		);
 	},
 
-	ConstraintsServices::SPARQL_HELPER => static function ( MediaWikiServices $services ) {
-		$endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' );
-		if ( $endpoint === '' ) {
+	ConstraintsServices::SPARQL_HELPER => static function(MediaWikiServices $services) {
+		$endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint');
+		if ($endpoint === '') {
 			return new DummySparqlHelper();
 		}
 
-		$rdfVocabulary = WikibaseRepo::getRdfVocabulary( $services );
-		$entityIdParser = WikibaseRepo::getEntityIdParser( $services );
-		$propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup( $services );
+		$rdfVocabulary = WikibaseRepo::getRdfVocabulary($services);
+		$entityIdParser = WikibaseRepo::getEntityIdParser($services);
+		$propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup($services);
 
 		return new SparqlHelper(
 			$services->getMainConfig(),
@@ -154,126 +154,126 @@ 
 			$entityIdParser,
 			$propertyDataTypeLookup,
 			$services->getMainWANObjectCache(),
-			ConstraintsServices::getViolationMessageSerializer( $services ),
-			ConstraintsServices::getViolationMessageDeserializer( $services ),
+			ConstraintsServices::getViolationMessageSerializer($services),
+			ConstraintsServices::getViolationMessageDeserializer($services),
 			$services->getStatsdDataFactory(),
-			ConstraintsServices::getExpiryLock( $services ),
-			ConstraintsServices::getLoggingHelper( $services ),
-			WikiMap::getCurrentWikiId() . ' WikibaseQualityConstraints ' . $services->getHttpRequestFactory()->getUserAgent(),
+			ConstraintsServices::getExpiryLock($services),
+			ConstraintsServices::getLoggingHelper($services),
+			WikiMap::getCurrentWikiId().' WikibaseQualityConstraints '.$services->getHttpRequestFactory()->getUserAgent(),
 			$services->getHttpRequestFactory()
 		);
 	},
 
-	ConstraintsServices::TYPE_CHECKER_HELPER => static function ( MediaWikiServices $services ) {
+	ConstraintsServices::TYPE_CHECKER_HELPER => static function(MediaWikiServices $services) {
 		return new TypeCheckerHelper(
-			WikibaseServices::getEntityLookup( $services ),
+			WikibaseServices::getEntityLookup($services),
 			$services->getMainConfig(),
-			ConstraintsServices::getSparqlHelper( $services ),
+			ConstraintsServices::getSparqlHelper($services),
 			$services->getStatsdDataFactory()
 		);
 	},
 
-	ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function ( MediaWikiServices $services ) {
-		$statementGuidParser = WikibaseRepo::getStatementGuidParser( $services );
+	ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function(MediaWikiServices $services) {
+		$statementGuidParser = WikibaseRepo::getStatementGuidParser($services);
 
 		$config = $services->getMainConfig();
 		$checkerMap = [
-			$config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
-				=> ConstraintCheckerServices::getConflictsWithChecker( $services ),
-			$config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
-				=> ConstraintCheckerServices::getItemChecker( $services ),
-			$config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
-				=> ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ),
-			$config->get( 'WBQualityConstraintsSymmetricConstraintId' )
-				=> ConstraintCheckerServices::getSymmetricChecker( $services ),
-			$config->get( 'WBQualityConstraintsInverseConstraintId' )
-				=> ConstraintCheckerServices::getInverseChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
-				=> ConstraintCheckerServices::getQualifierChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
-				=> ConstraintCheckerServices::getQualifiersChecker( $services ),
-			$config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
-				=> ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ),
-			$config->get( 'WBQualityConstraintsRangeConstraintId' )
-				=> ConstraintCheckerServices::getRangeChecker( $services ),
-			$config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
-				=> ConstraintCheckerServices::getDiffWithinRangeChecker( $services ),
-			$config->get( 'WBQualityConstraintsTypeConstraintId' )
-				=> ConstraintCheckerServices::getTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsValueTypeConstraintId' )
-				=> ConstraintCheckerServices::getValueTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsSingleValueConstraintId' )
-				=> ConstraintCheckerServices::getSingleValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsMultiValueConstraintId' )
-				=> ConstraintCheckerServices::getMultiValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
-				=> ConstraintCheckerServices::getUniqueValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsFormatConstraintId' )
-				=> ConstraintCheckerServices::getFormatChecker( $services ),
-			$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
-				=> ConstraintCheckerServices::getCommonsLinkChecker( $services ),
-			$config->get( 'WBQualityConstraintsOneOfConstraintId' )
-				=> ConstraintCheckerServices::getOneOfChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
-				=> ConstraintCheckerServices::getValueOnlyChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
-				=> ConstraintCheckerServices::getReferenceChecker( $services ),
-			$config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
-				=> ConstraintCheckerServices::getNoBoundsChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
-				=> ConstraintCheckerServices::getAllowedUnitsChecker( $services ),
-			$config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
-				=> ConstraintCheckerServices::getSingleBestValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
-				=> ConstraintCheckerServices::getEntityTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsNoneOfConstraintId' )
-				=> ConstraintCheckerServices::getNoneOfChecker( $services ),
-			$config->get( 'WBQualityConstraintsIntegerConstraintId' )
-				=> ConstraintCheckerServices::getIntegerChecker( $services ),
-			$config->get( 'WBQualityConstraintsCitationNeededConstraintId' )
-				=> ConstraintCheckerServices::getCitationNeededChecker( $services ),
-			$config->get( 'WBQualityConstraintsPropertyScopeConstraintId' )
-				=> ConstraintCheckerServices::getPropertyScopeChecker( $services ),
-			$config->get( 'WBQualityConstraintsContemporaryConstraintId' )
-				=> ConstraintCheckerServices::getContemporaryChecker( $services ),
-			$config->get( 'WBQualityConstraintsLexemeLanguageConstraintId' )
-				=> ConstraintCheckerServices::getLexemeLanguageChecker( $services ),
-			$config->get( 'WBQualityConstraintsLabelInLanguageConstraintId' )
-				=> ConstraintCheckerServices::getLabelInLanguageChecker( $services ),
+			$config->get('WBQualityConstraintsConflictsWithConstraintId')
+				=> ConstraintCheckerServices::getConflictsWithChecker($services),
+			$config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
+				=> ConstraintCheckerServices::getItemChecker($services),
+			$config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
+				=> ConstraintCheckerServices::getTargetRequiredClaimChecker($services),
+			$config->get('WBQualityConstraintsSymmetricConstraintId')
+				=> ConstraintCheckerServices::getSymmetricChecker($services),
+			$config->get('WBQualityConstraintsInverseConstraintId')
+				=> ConstraintCheckerServices::getInverseChecker($services),
+			$config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
+				=> ConstraintCheckerServices::getQualifierChecker($services),
+			$config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
+				=> ConstraintCheckerServices::getQualifiersChecker($services),
+			$config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
+				=> ConstraintCheckerServices::getMandatoryQualifiersChecker($services),
+			$config->get('WBQualityConstraintsRangeConstraintId')
+				=> ConstraintCheckerServices::getRangeChecker($services),
+			$config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
+				=> ConstraintCheckerServices::getDiffWithinRangeChecker($services),
+			$config->get('WBQualityConstraintsTypeConstraintId')
+				=> ConstraintCheckerServices::getTypeChecker($services),
+			$config->get('WBQualityConstraintsValueTypeConstraintId')
+				=> ConstraintCheckerServices::getValueTypeChecker($services),
+			$config->get('WBQualityConstraintsSingleValueConstraintId')
+				=> ConstraintCheckerServices::getSingleValueChecker($services),
+			$config->get('WBQualityConstraintsMultiValueConstraintId')
+				=> ConstraintCheckerServices::getMultiValueChecker($services),
+			$config->get('WBQualityConstraintsDistinctValuesConstraintId')
+				=> ConstraintCheckerServices::getUniqueValueChecker($services),
+			$config->get('WBQualityConstraintsFormatConstraintId')
+				=> ConstraintCheckerServices::getFormatChecker($services),
+			$config->get('WBQualityConstraintsCommonsLinkConstraintId')
+				=> ConstraintCheckerServices::getCommonsLinkChecker($services),
+			$config->get('WBQualityConstraintsOneOfConstraintId')
+				=> ConstraintCheckerServices::getOneOfChecker($services),
+			$config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
+				=> ConstraintCheckerServices::getValueOnlyChecker($services),
+			$config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
+				=> ConstraintCheckerServices::getReferenceChecker($services),
+			$config->get('WBQualityConstraintsNoBoundsConstraintId')
+				=> ConstraintCheckerServices::getNoBoundsChecker($services),
+			$config->get('WBQualityConstraintsAllowedUnitsConstraintId')
+				=> ConstraintCheckerServices::getAllowedUnitsChecker($services),
+			$config->get('WBQualityConstraintsSingleBestValueConstraintId')
+				=> ConstraintCheckerServices::getSingleBestValueChecker($services),
+			$config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
+				=> ConstraintCheckerServices::getEntityTypeChecker($services),
+			$config->get('WBQualityConstraintsNoneOfConstraintId')
+				=> ConstraintCheckerServices::getNoneOfChecker($services),
+			$config->get('WBQualityConstraintsIntegerConstraintId')
+				=> ConstraintCheckerServices::getIntegerChecker($services),
+			$config->get('WBQualityConstraintsCitationNeededConstraintId')
+				=> ConstraintCheckerServices::getCitationNeededChecker($services),
+			$config->get('WBQualityConstraintsPropertyScopeConstraintId')
+				=> ConstraintCheckerServices::getPropertyScopeChecker($services),
+			$config->get('WBQualityConstraintsContemporaryConstraintId')
+				=> ConstraintCheckerServices::getContemporaryChecker($services),
+			$config->get('WBQualityConstraintsLexemeLanguageConstraintId')
+				=> ConstraintCheckerServices::getLexemeLanguageChecker($services),
+			$config->get('WBQualityConstraintsLabelInLanguageConstraintId')
+				=> ConstraintCheckerServices::getLabelInLanguageChecker($services),
 		];
 
 		return new DelegatingConstraintChecker(
-			WikibaseServices::getEntityLookup( $services ),
+			WikibaseServices::getEntityLookup($services),
 			$checkerMap,
-			ConstraintsServices::getConstraintLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
+			ConstraintsServices::getConstraintLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
 			$statementGuidParser,
-			ConstraintsServices::getLoggingHelper( $services ),
-			$config->get( 'WBQualityConstraintsCheckQualifiers' ),
-			$config->get( 'WBQualityConstraintsCheckReferences' ),
-			$config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
+			ConstraintsServices::getLoggingHelper($services),
+			$config->get('WBQualityConstraintsCheckQualifiers'),
+			$config->get('WBQualityConstraintsCheckReferences'),
+			$config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
 		);
 	},
 
-	ConstraintsServices::RESULTS_SOURCE => static function ( MediaWikiServices $services ) {
+	ConstraintsServices::RESULTS_SOURCE => static function(MediaWikiServices $services) {
 		$config = $services->getMainConfig();
 		$resultsSource = new CheckingResultsSource(
-			ConstraintsServices::getDelegatingConstraintChecker( $services )
+			ConstraintsServices::getDelegatingConstraintChecker($services)
 		);
 
 		$cacheCheckConstraintsResults = false;
 
-		if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
+		if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
 			$cacheCheckConstraintsResults = true;
 			// check that we can use getLocalRepoWikiPageMetaDataAccessor()
 			// TODO we should always be able to cache constraint check results (T244726)
-			$entitySources = WikibaseRepo::getEntitySourceDefinitions( $services )->getSources();
-			$localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName();
+			$entitySources = WikibaseRepo::getEntitySourceDefinitions($services)->getSources();
+			$localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName();
 
-			foreach ( $entitySources as $entitySource ) {
-				if ( $entitySource->getSourceName() !== $localEntitySourceName ) {
-					LoggerFactory::getInstance( 'WikibaseQualityConstraints' )->warning(
-						'Cannot cache constraint check results for non-local source: ' .
+			foreach ($entitySources as $entitySource) {
+				if ($entitySource->getSourceName() !== $localEntitySourceName) {
+					LoggerFactory::getInstance('WikibaseQualityConstraints')->warning(
+						'Cannot cache constraint check results for non-local source: '.
 						$entitySource->getSourceName()
 					);
 					$cacheCheckConstraintsResults = false;
@@ -282,40 +282,40 @@ 
 			}
 		}
 
-		if ( $cacheCheckConstraintsResults ) {
+		if ($cacheCheckConstraintsResults) {
 			$possiblyStaleConstraintTypes = [
-				$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
-				$config->get( 'WBQualityConstraintsTypeConstraintId' ),
-				$config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
-				$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
+				$config->get('WBQualityConstraintsCommonsLinkConstraintId'),
+				$config->get('WBQualityConstraintsTypeConstraintId'),
+				$config->get('WBQualityConstraintsValueTypeConstraintId'),
+				$config->get('WBQualityConstraintsDistinctValuesConstraintId'),
 			];
-			$entityIdParser = WikibaseRepo::getEntityIdParser( $services );
+			$entityIdParser = WikibaseRepo::getEntityIdParser($services);
 			$wikiPageEntityMetaDataAccessor = WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor(
 				$services );
 
 			$resultsSource = new CachingResultsSource(
 				$resultsSource,
 				ResultsCache::getDefaultInstance(),
-				ConstraintsServices::getCheckResultSerializer( $services ),
-				ConstraintsServices::getCheckResultDeserializer( $services ),
+				ConstraintsServices::getCheckResultSerializer($services),
+				ConstraintsServices::getCheckResultDeserializer($services),
 				$wikiPageEntityMetaDataAccessor,
 				$entityIdParser,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
+				$config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
 				$possiblyStaleConstraintTypes,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ),
-				ConstraintsServices::getLoggingHelper( $services )
+				$config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'),
+				ConstraintsServices::getLoggingHelper($services)
 			);
 		}
 
 		return $resultsSource;
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_RENDERER_FACTORY => static function ( MediaWikiServices $services ) {
+	ConstraintsServices::VIOLATION_MESSAGE_RENDERER_FACTORY => static function(MediaWikiServices $services) {
 		return new ViolationMessageRendererFactory(
 			$services->getMainConfig(),
 			$services->getLanguageNameUtils(),
-			WikibaseRepo::getEntityIdHtmlLinkFormatterFactory( $services ),
-			WikibaseRepo::getValueFormatterFactory( $services )
+			WikibaseRepo::getEntityIdHtmlLinkFormatterFactory($services),
+			WikibaseRepo::getValueFormatterFactory($services)
 		);
 	},
 ];