@@ -143,14 +143,14 @@ discard block |
||
143 | 143 | ) { |
144 | 144 | $results = []; |
145 | 145 | $metadatas = []; |
146 | - if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) { |
|
146 | + if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds, $statuses)) { |
|
147 | 147 | $storedEntityIds = []; |
148 | - foreach ( $entityIds as $entityId ) { |
|
149 | - $storedResults = $this->getStoredResults( $entityId ); |
|
150 | - if ( $storedResults !== null ) { |
|
151 | - $this->loggingHelper->logCheckConstraintsCacheHit( $entityId ); |
|
152 | - foreach ( $storedResults->getArray() as $checkResult ) { |
|
153 | - if ( $this->statusSelected( $statuses, $checkResult ) ) { |
|
148 | + foreach ($entityIds as $entityId) { |
|
149 | + $storedResults = $this->getStoredResults($entityId); |
|
150 | + if ($storedResults !== null) { |
|
151 | + $this->loggingHelper->logCheckConstraintsCacheHit($entityId); |
|
152 | + foreach ($storedResults->getArray() as $checkResult) { |
|
153 | + if ($this->statusSelected($statuses, $checkResult)) { |
|
154 | 154 | $results[] = $checkResult; |
155 | 155 | } |
156 | 156 | } |
@@ -158,19 +158,19 @@ discard block |
||
158 | 158 | $storedEntityIds[] = $entityId; |
159 | 159 | } |
160 | 160 | } |
161 | - $entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) ); |
|
161 | + $entityIds = array_values(array_diff($entityIds, $storedEntityIds)); |
|
162 | 162 | } |
163 | - if ( $entityIds !== [] || $claimIds !== [] ) { |
|
164 | - if ( $entityIds !== [] ) { |
|
165 | - $this->loggingHelper->logCheckConstraintsCacheMisses( $entityIds ); |
|
163 | + if ($entityIds !== [] || $claimIds !== []) { |
|
164 | + if ($entityIds !== []) { |
|
165 | + $this->loggingHelper->logCheckConstraintsCacheMisses($entityIds); |
|
166 | 166 | } |
167 | - $response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ); |
|
168 | - $results = array_merge( $results, $response->getArray() ); |
|
167 | + $response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds, $statuses); |
|
168 | + $results = array_merge($results, $response->getArray()); |
|
169 | 169 | $metadatas[] = $response->getMetadata(); |
170 | 170 | } |
171 | 171 | return new CachedCheckResults( |
172 | 172 | $results, |
173 | - Metadata::merge( $metadatas ) |
|
173 | + Metadata::merge($metadatas) |
|
174 | 174 | ); |
175 | 175 | } |
176 | 176 | |
@@ -193,13 +193,13 @@ discard block |
||
193 | 193 | ?array $constraintIds, |
194 | 194 | array $statuses |
195 | 195 | ) { |
196 | - if ( $claimIds !== [] ) { |
|
196 | + if ($claimIds !== []) { |
|
197 | 197 | return false; |
198 | 198 | } |
199 | - if ( $constraintIds !== null ) { |
|
199 | + if ($constraintIds !== null) { |
|
200 | 200 | return false; |
201 | 201 | } |
202 | - if ( array_diff( $statuses, self::CACHED_STATUSES ) !== [] ) { |
|
202 | + if (array_diff($statuses, self::CACHED_STATUSES) !== []) { |
|
203 | 203 | return false; |
204 | 204 | } |
205 | 205 | return true; |
@@ -214,8 +214,8 @@ discard block |
||
214 | 214 | * @param CheckResult $result |
215 | 215 | * @return bool |
216 | 216 | */ |
217 | - private function statusSelected( array $statuses, CheckResult $result ) { |
|
218 | - return in_array( $result->getStatus(), $statuses, true ) || |
|
217 | + private function statusSelected(array $statuses, CheckResult $result) { |
|
218 | + return in_array($result->getStatus(), $statuses, true) || |
|
219 | 219 | $result instanceof NullResult; |
220 | 220 | } |
221 | 221 | |
@@ -232,11 +232,11 @@ discard block |
||
232 | 232 | ?array $constraintIds, |
233 | 233 | array $statuses |
234 | 234 | ) { |
235 | - $results = $this->resultsSource->getResults( $entityIds, $claimIds, $constraintIds, $statuses ); |
|
235 | + $results = $this->resultsSource->getResults($entityIds, $claimIds, $constraintIds, $statuses); |
|
236 | 236 | |
237 | - if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) { |
|
238 | - foreach ( $entityIds as $entityId ) { |
|
239 | - $this->storeResults( $entityId, $results ); |
|
237 | + if ($this->canStoreResults($entityIds, $claimIds, $constraintIds, $statuses)) { |
|
238 | + foreach ($entityIds as $entityId) { |
|
239 | + $this->storeResults($entityId, $results); |
|
240 | 240 | } |
241 | 241 | } |
242 | 242 | |
@@ -267,10 +267,10 @@ discard block |
||
267 | 267 | ?array $constraintIds, |
268 | 268 | array $statuses |
269 | 269 | ) { |
270 | - if ( $constraintIds !== null ) { |
|
270 | + if ($constraintIds !== null) { |
|
271 | 271 | return false; |
272 | 272 | } |
273 | - if ( array_diff( self::CACHED_STATUSES, $statuses ) !== [] ) { |
|
273 | + if (array_diff(self::CACHED_STATUSES, $statuses) !== []) { |
|
274 | 274 | return false; |
275 | 275 | } |
276 | 276 | return true; |
@@ -284,21 +284,21 @@ discard block |
||
284 | 284 | * May include check results for other entity IDs as well, |
285 | 285 | * or check results with statuses that we’re not interested in caching. |
286 | 286 | */ |
287 | - private function storeResults( EntityId $entityId, CachedCheckResults $results ) { |
|
287 | + private function storeResults(EntityId $entityId, CachedCheckResults $results) { |
|
288 | 288 | $latestRevisionIds = $this->getLatestRevisionIds( |
289 | 289 | $results->getMetadata()->getDependencyMetadata()->getEntityIds() |
290 | 290 | ); |
291 | - if ( $latestRevisionIds === null ) { |
|
291 | + if ($latestRevisionIds === null) { |
|
292 | 292 | return; |
293 | 293 | } |
294 | 294 | |
295 | 295 | $resultSerializations = []; |
296 | - foreach ( $results->getArray() as $checkResult ) { |
|
297 | - if ( $checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization() ) { |
|
296 | + foreach ($results->getArray() as $checkResult) { |
|
297 | + if ($checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization()) { |
|
298 | 298 | continue; |
299 | 299 | } |
300 | - if ( $this->statusSelected( self::CACHED_STATUSES, $checkResult ) ) { |
|
301 | - $resultSerializations[] = $this->checkResultSerializer->serialize( $checkResult ); |
|
300 | + if ($this->statusSelected(self::CACHED_STATUSES, $checkResult)) { |
|
301 | + $resultSerializations[] = $this->checkResultSerializer->serialize($checkResult); |
|
302 | 302 | } |
303 | 303 | } |
304 | 304 | |
@@ -307,11 +307,11 @@ discard block |
||
307 | 307 | 'latestRevisionIds' => $latestRevisionIds, |
308 | 308 | ]; |
309 | 309 | $futureTime = $results->getMetadata()->getDependencyMetadata()->getFutureTime(); |
310 | - if ( $futureTime !== null ) { |
|
310 | + if ($futureTime !== null) { |
|
311 | 311 | $value['futureTime'] = $futureTime->getArrayValue(); |
312 | 312 | } |
313 | 313 | |
314 | - $this->cache->set( $entityId, $value, $this->ttlInSeconds ); |
|
314 | + $this->cache->set($entityId, $value, $this->ttlInSeconds); |
|
315 | 315 | } |
316 | 316 | |
317 | 317 | /** |
@@ -326,33 +326,32 @@ discard block |
||
326 | 326 | $forRevision = 0 |
327 | 327 | ) { |
328 | 328 | $cacheInfo = WANObjectCache::PASS_BY_REF; |
329 | - $value = $this->cache->get( $entityId, $curTTL, [], $cacheInfo ); |
|
330 | - $now = call_user_func( $this->microtime, true ); |
|
329 | + $value = $this->cache->get($entityId, $curTTL, [], $cacheInfo); |
|
330 | + $now = call_user_func($this->microtime, true); |
|
331 | 331 | |
332 | - $dependencyMetadata = $this->checkDependencyMetadata( $value, |
|
333 | - [ $entityId->getSerialization() => $forRevision ] ); |
|
334 | - if ( $dependencyMetadata === null ) { |
|
332 | + $dependencyMetadata = $this->checkDependencyMetadata($value, |
|
333 | + [$entityId->getSerialization() => $forRevision]); |
|
334 | + if ($dependencyMetadata === null) { |
|
335 | 335 | return null; |
336 | 336 | } |
337 | 337 | |
338 | 338 | // @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset False positive |
339 | 339 | $asOf = $cacheInfo[WANObjectCache::KEY_AS_OF]; |
340 | - $ageInSeconds = (int)ceil( $now - $asOf ); |
|
340 | + $ageInSeconds = (int) ceil($now - $asOf); |
|
341 | 341 | $cachingMetadata = $ageInSeconds > 0 ? |
342 | - CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) : |
|
343 | - CachingMetadata::fresh(); |
|
342 | + CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh(); |
|
344 | 343 | |
345 | 344 | $results = []; |
346 | - foreach ( $value['results'] as $resultSerialization ) { |
|
347 | - $results[] = $this->deserializeCheckResult( $resultSerialization, $cachingMetadata ); |
|
345 | + foreach ($value['results'] as $resultSerialization) { |
|
346 | + $results[] = $this->deserializeCheckResult($resultSerialization, $cachingMetadata); |
|
348 | 347 | } |
349 | 348 | |
350 | 349 | return new CachedCheckResults( |
351 | 350 | $results, |
352 | - Metadata::merge( [ |
|
353 | - Metadata::ofCachingMetadata( $cachingMetadata ), |
|
354 | - Metadata::ofDependencyMetadata( $dependencyMetadata ), |
|
355 | - ] ) |
|
351 | + Metadata::merge([ |
|
352 | + Metadata::ofCachingMetadata($cachingMetadata), |
|
353 | + Metadata::ofDependencyMetadata($dependencyMetadata), |
|
354 | + ]) |
|
356 | 355 | ); |
357 | 356 | } |
358 | 357 | |
@@ -368,43 +367,43 @@ discard block |
||
368 | 367 | * @return DependencyMetadata|null the dependency metadata, |
369 | 368 | * or null if $value should no longer be used |
370 | 369 | */ |
371 | - private function checkDependencyMetadata( $value, $paramRevs ) { |
|
372 | - if ( $value === false ) { |
|
370 | + private function checkDependencyMetadata($value, $paramRevs) { |
|
371 | + if ($value === false) { |
|
373 | 372 | return null; |
374 | 373 | } |
375 | 374 | |
376 | - if ( array_key_exists( 'futureTime', $value ) ) { |
|
377 | - $futureTime = TimeValue::newFromArray( $value['futureTime'] ); |
|
378 | - if ( !$this->timeValueComparer->isFutureTime( $futureTime ) ) { |
|
375 | + if (array_key_exists('futureTime', $value)) { |
|
376 | + $futureTime = TimeValue::newFromArray($value['futureTime']); |
|
377 | + if (!$this->timeValueComparer->isFutureTime($futureTime)) { |
|
379 | 378 | return null; |
380 | 379 | } |
381 | - $futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime ); |
|
380 | + $futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime); |
|
382 | 381 | } else { |
383 | 382 | $futureTimeDependencyMetadata = DependencyMetadata::blank(); |
384 | 383 | } |
385 | 384 | |
386 | - foreach ( $paramRevs as $id => $revision ) { |
|
387 | - if ( $revision > 0 ) { |
|
388 | - $value['latestRevisionIds'][$id] = min( $revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX ); |
|
385 | + foreach ($paramRevs as $id => $revision) { |
|
386 | + if ($revision > 0) { |
|
387 | + $value['latestRevisionIds'][$id] = min($revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX); |
|
389 | 388 | } |
390 | 389 | } |
391 | 390 | |
392 | 391 | $dependedEntityIds = array_map( |
393 | - [ $this->entityIdParser, "parse" ], |
|
394 | - array_keys( $value['latestRevisionIds'] ) |
|
392 | + [$this->entityIdParser, "parse"], |
|
393 | + array_keys($value['latestRevisionIds']) |
|
395 | 394 | ); |
396 | 395 | |
397 | - if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) { |
|
396 | + if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) { |
|
398 | 397 | return null; |
399 | 398 | } |
400 | 399 | |
401 | 400 | return array_reduce( |
402 | 401 | $dependedEntityIds, |
403 | - static function ( DependencyMetadata $metadata, EntityId $entityId ) { |
|
404 | - return DependencyMetadata::merge( [ |
|
402 | + static function(DependencyMetadata $metadata, EntityId $entityId) { |
|
403 | + return DependencyMetadata::merge([ |
|
405 | 404 | $metadata, |
406 | - DependencyMetadata::ofEntityId( $entityId ), |
|
407 | - ] ); |
|
405 | + DependencyMetadata::ofEntityId($entityId), |
|
406 | + ]); |
|
408 | 407 | }, |
409 | 408 | $futureTimeDependencyMetadata |
410 | 409 | ); |
@@ -424,13 +423,13 @@ discard block |
||
424 | 423 | array $resultSerialization, |
425 | 424 | CachingMetadata $cachingMetadata |
426 | 425 | ) { |
427 | - $result = $this->checkResultDeserializer->deserialize( $resultSerialization ); |
|
428 | - if ( $this->isPossiblyStaleResult( $result ) ) { |
|
426 | + $result = $this->checkResultDeserializer->deserialize($resultSerialization); |
|
427 | + if ($this->isPossiblyStaleResult($result)) { |
|
429 | 428 | $result->withMetadata( |
430 | - Metadata::merge( [ |
|
429 | + Metadata::merge([ |
|
431 | 430 | $result->getMetadata(), |
432 | - Metadata::ofCachingMetadata( $cachingMetadata ), |
|
433 | - ] ) |
|
431 | + Metadata::ofCachingMetadata($cachingMetadata), |
|
432 | + ]) |
|
434 | 433 | ); |
435 | 434 | } |
436 | 435 | return $result; |
@@ -440,8 +439,8 @@ discard block |
||
440 | 439 | * @param CheckResult $result |
441 | 440 | * @return bool |
442 | 441 | */ |
443 | - private function isPossiblyStaleResult( CheckResult $result ) { |
|
444 | - if ( $result instanceof NullResult ) { |
|
442 | + private function isPossiblyStaleResult(CheckResult $result) { |
|
443 | + if ($result instanceof NullResult) { |
|
445 | 444 | return false; |
446 | 445 | } |
447 | 446 | |
@@ -456,14 +455,14 @@ discard block |
||
456 | 455 | * @return int[]|null array from entity ID serializations to revision ID, |
457 | 456 | * or null to indicate that not all revision IDs could be loaded |
458 | 457 | */ |
459 | - private function getLatestRevisionIds( array $entityIds ) { |
|
460 | - if ( $entityIds === [] ) { |
|
458 | + private function getLatestRevisionIds(array $entityIds) { |
|
459 | + if ($entityIds === []) { |
|
461 | 460 | $this->loggingHelper->logEmptyDependencyMetadata(); |
462 | 461 | return []; |
463 | 462 | } |
464 | - if ( count( $entityIds ) > $this->maxRevisionIds ) { |
|
463 | + if (count($entityIds) > $this->maxRevisionIds) { |
|
465 | 464 | // one of those entities will probably be edited soon, so might as well skip caching |
466 | - $this->loggingHelper->logHugeDependencyMetadata( $entityIds, $this->maxRevisionIds ); |
|
465 | + $this->loggingHelper->logHugeDependencyMetadata($entityIds, $this->maxRevisionIds); |
|
467 | 466 | return null; |
468 | 467 | } |
469 | 468 | |
@@ -471,7 +470,7 @@ discard block |
||
471 | 470 | $entityIds, |
472 | 471 | LookupConstants::LATEST_FROM_REPLICA |
473 | 472 | ); |
474 | - if ( $this->hasFalseElements( $latestRevisionIds ) ) { |
|
473 | + if ($this->hasFalseElements($latestRevisionIds)) { |
|
475 | 474 | return null; |
476 | 475 | } |
477 | 476 | return $latestRevisionIds; |
@@ -481,8 +480,8 @@ discard block |
||
481 | 480 | * @param array $array |
482 | 481 | * @return bool |
483 | 482 | */ |
484 | - private function hasFalseElements( array $array ) { |
|
485 | - return in_array( false, $array, true ); |
|
483 | + private function hasFalseElements(array $array) { |
|
484 | + return in_array(false, $array, true); |
|
486 | 485 | } |
487 | 486 | |
488 | 487 | /** |
@@ -490,7 +489,7 @@ discard block |
||
490 | 489 | * |
491 | 490 | * @param callable $microtime |
492 | 491 | */ |
493 | - public function setMicrotimeFunction( callable $microtime ) { |
|
492 | + public function setMicrotimeFunction(callable $microtime) { |
|
494 | 493 | $this->microtime = $microtime; |
495 | 494 | } |
496 | 495 |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport\Api; |
6 | 6 | |
@@ -41,11 +41,11 @@ discard block |
||
41 | 41 | $this->violationMessageRenderer = $violationMessageRenderer; |
42 | 42 | } |
43 | 43 | |
44 | - public function render( CachedCheckResults $checkResults ): CachedCheckConstraintsResponse { |
|
44 | + public function render(CachedCheckResults $checkResults): CachedCheckConstraintsResponse { |
|
45 | 45 | $response = []; |
46 | - foreach ( $checkResults->getArray() as $checkResult ) { |
|
47 | - $resultArray = $this->checkResultToArray( $checkResult ); |
|
48 | - $checkResult->getContextCursor()->storeCheckResultInArray( $resultArray, $response ); |
|
46 | + foreach ($checkResults->getArray() as $checkResult) { |
|
47 | + $resultArray = $this->checkResultToArray($checkResult); |
|
48 | + $checkResult->getContextCursor()->storeCheckResultInArray($resultArray, $response); |
|
49 | 49 | } |
50 | 50 | return new CachedCheckConstraintsResponse( |
51 | 51 | $response, |
@@ -53,19 +53,19 @@ discard block |
||
53 | 53 | ); |
54 | 54 | } |
55 | 55 | |
56 | - public function checkResultToArray( CheckResult $checkResult ): ?array { |
|
57 | - if ( $checkResult instanceof NullResult ) { |
|
56 | + public function checkResultToArray(CheckResult $checkResult): ?array { |
|
57 | + if ($checkResult instanceof NullResult) { |
|
58 | 58 | return null; |
59 | 59 | } |
60 | 60 | |
61 | 61 | $constraintId = $checkResult->getConstraint()->getConstraintId(); |
62 | 62 | $typeItemId = $checkResult->getConstraint()->getConstraintTypeItemId(); |
63 | - $constraintPropertyId = new NumericPropertyId( $checkResult->getContextCursor()->getSnakPropertyId() ); |
|
63 | + $constraintPropertyId = new NumericPropertyId($checkResult->getContextCursor()->getSnakPropertyId()); |
|
64 | 64 | |
65 | - $title = $this->entityTitleLookup->getTitleForId( $constraintPropertyId ); |
|
65 | + $title = $this->entityTitleLookup->getTitleForId($constraintPropertyId); |
|
66 | 66 | $talkTitle = $title->getTalkPageIfDefined(); |
67 | - $typeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $typeItemId ) ); |
|
68 | - $link = $title->getFullURL() . '#' . $constraintId; |
|
67 | + $typeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($typeItemId)); |
|
68 | + $link = $title->getFullURL().'#'.$constraintId; |
|
69 | 69 | |
70 | 70 | $constraint = [ |
71 | 71 | 'id' => $constraintId, |
@@ -81,28 +81,28 @@ discard block |
||
81 | 81 | 'constraint' => $constraint, |
82 | 82 | ]; |
83 | 83 | $message = $checkResult->getMessage(); |
84 | - if ( $message ) { |
|
85 | - $result['message-html'] = $this->violationMessageRenderer->render( $message ); |
|
84 | + if ($message) { |
|
85 | + $result['message-html'] = $this->violationMessageRenderer->render($message); |
|
86 | 86 | } |
87 | - $constraintClarification = $this->renderConstraintClarification( $checkResult ); |
|
88 | - if ( $constraintClarification !== null ) { |
|
87 | + $constraintClarification = $this->renderConstraintClarification($checkResult); |
|
88 | + if ($constraintClarification !== null) { |
|
89 | 89 | $result['constraint-clarification'] = $constraintClarification; |
90 | 90 | } |
91 | - if ( $checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT ) { |
|
91 | + if ($checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT) { |
|
92 | 92 | $result['claim'] = $checkResult->getContextCursor()->getStatementGuid(); |
93 | 93 | } |
94 | 94 | $cachingMetadataArray = $checkResult->getMetadata()->getCachingMetadata()->toArray(); |
95 | - if ( $cachingMetadataArray !== null ) { |
|
95 | + if ($cachingMetadataArray !== null) { |
|
96 | 96 | $result['cached'] = $cachingMetadataArray; |
97 | 97 | } |
98 | 98 | |
99 | 99 | return $result; |
100 | 100 | } |
101 | 101 | |
102 | - private function renderConstraintClarification( CheckResult $result ): ?string { |
|
102 | + private function renderConstraintClarification(CheckResult $result): ?string { |
|
103 | 103 | $texts = $result->getConstraintClarification()->getTexts(); |
104 | - foreach ( $this->languageFallbackChain->getFetchLanguageCodes() as $languageCode ) { |
|
105 | - if ( array_key_exists( $languageCode, $texts ) ) { |
|
104 | + foreach ($this->languageFallbackChain->getFetchLanguageCodes() as $languageCode) { |
|
105 | + if (array_key_exists($languageCode, $texts)) { |
|
106 | 106 | return $texts[$languageCode]->getText(); |
107 | 107 | } |
108 | 108 | } |
@@ -44,57 +44,56 @@ |
||
44 | 44 | ) { |
45 | 45 | $results = []; |
46 | 46 | $metadatas = []; |
47 | - $statusesFlipped = array_flip( $statuses ); |
|
48 | - foreach ( $entityIds as $entityId ) { |
|
47 | + $statusesFlipped = array_flip($statuses); |
|
48 | + foreach ($entityIds as $entityId) { |
|
49 | 49 | $entityResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnEntityId( |
50 | 50 | $entityId, |
51 | 51 | $constraintIds, |
52 | - [ $this, 'defaultResultsPerContext' ], |
|
53 | - [ $this, 'defaultResultsPerEntity' ] |
|
52 | + [$this, 'defaultResultsPerContext'], |
|
53 | + [$this, 'defaultResultsPerEntity'] |
|
54 | 54 | ); |
55 | - foreach ( $entityResults as $result ) { |
|
55 | + foreach ($entityResults as $result) { |
|
56 | 56 | $metadatas[] = $result->getMetadata(); |
57 | - if ( $this->statusSelected( $statusesFlipped, $result ) ) { |
|
57 | + if ($this->statusSelected($statusesFlipped, $result)) { |
|
58 | 58 | $results[] = $result; |
59 | 59 | } |
60 | 60 | } |
61 | 61 | } |
62 | - foreach ( $claimIds as $claimId ) { |
|
62 | + foreach ($claimIds as $claimId) { |
|
63 | 63 | $claimResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnClaimId( |
64 | 64 | $claimId, |
65 | 65 | $constraintIds, |
66 | - [ $this, 'defaultResultsPerContext' ] |
|
66 | + [$this, 'defaultResultsPerContext'] |
|
67 | 67 | ); |
68 | - foreach ( $claimResults as $result ) { |
|
68 | + foreach ($claimResults as $result) { |
|
69 | 69 | $metadatas[] = $result->getMetadata(); |
70 | - if ( $this->statusSelected( $statusesFlipped, $result ) ) { |
|
70 | + if ($this->statusSelected($statusesFlipped, $result)) { |
|
71 | 71 | $results[] = $result; |
72 | 72 | } |
73 | 73 | } |
74 | 74 | } |
75 | 75 | return new CachedCheckResults( |
76 | 76 | $results, |
77 | - Metadata::merge( $metadatas ) |
|
77 | + Metadata::merge($metadatas) |
|
78 | 78 | ); |
79 | 79 | } |
80 | 80 | |
81 | - public function defaultResultsPerContext( Context $context ) { |
|
81 | + public function defaultResultsPerContext(Context $context) { |
|
82 | 82 | return $context->getType() === Context::TYPE_STATEMENT ? |
83 | - [ new NullResult( $context->getCursor() ) ] : |
|
84 | - []; |
|
83 | + [new NullResult($context->getCursor())] : []; |
|
85 | 84 | } |
86 | 85 | |
87 | - public function defaultResultsPerEntity( EntityId $entityId ) { |
|
86 | + public function defaultResultsPerEntity(EntityId $entityId) { |
|
88 | 87 | return [ |
89 | - ( new NullResult( new EntityContextCursor( $entityId->getSerialization() ) ) ) |
|
90 | - ->withMetadata( Metadata::ofDependencyMetadata( |
|
91 | - DependencyMetadata::ofEntityId( $entityId ) |
|
92 | - ) ), |
|
88 | + (new NullResult(new EntityContextCursor($entityId->getSerialization()))) |
|
89 | + ->withMetadata(Metadata::ofDependencyMetadata( |
|
90 | + DependencyMetadata::ofEntityId($entityId) |
|
91 | + )), |
|
93 | 92 | ]; |
94 | 93 | } |
95 | 94 | |
96 | - public function statusSelected( array $statusesFlipped, CheckResult $result ) { |
|
97 | - return array_key_exists( $result->getStatus(), $statusesFlipped ) || |
|
95 | + public function statusSelected(array $statusesFlipped, CheckResult $result) { |
|
96 | + return array_key_exists($result->getStatus(), $statusesFlipped) || |
|
98 | 97 | $result instanceof NullResult; |
99 | 98 | } |
100 | 99 |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Result; |
6 | 6 | |
@@ -40,13 +40,13 @@ discard block |
||
40 | 40 | $this->entityIdParser = $entityIdParser; |
41 | 41 | } |
42 | 42 | |
43 | - public function deserialize( array $serialization ): CheckResult { |
|
43 | + public function deserialize(array $serialization): CheckResult { |
|
44 | 44 | $contextCursor = $this->contextCursorDeserializer->deserialize( |
45 | 45 | $serialization[CheckResultSerializer::KEY_CONTEXT_CURSOR] |
46 | 46 | ); |
47 | 47 | |
48 | - if ( array_key_exists( CheckResultSerializer::KEY_NULL_RESULT, $serialization ) ) { |
|
49 | - $result = new NullResult( $contextCursor ); |
|
48 | + if (array_key_exists(CheckResultSerializer::KEY_NULL_RESULT, $serialization)) { |
|
49 | + $result = new NullResult($contextCursor); |
|
50 | 50 | $cachingMetadata = CachingMetadata::fresh(); |
51 | 51 | } else { |
52 | 52 | $constraint = $this->constraintDeserializer->deserialize( |
@@ -57,7 +57,7 @@ discard block |
||
57 | 57 | |
58 | 58 | $status = $serialization[CheckResultSerializer::KEY_CHECK_RESULT_STATUS]; |
59 | 59 | |
60 | - $violationMessage = $this->getViolationMessageFromSerialization( $serialization ); |
|
60 | + $violationMessage = $this->getViolationMessageFromSerialization($serialization); |
|
61 | 61 | |
62 | 62 | $result = new CheckResult( |
63 | 63 | $contextCursor, |
@@ -68,7 +68,7 @@ discard block |
||
68 | 68 | ); |
69 | 69 | |
70 | 70 | $result->setConstraintClarification( |
71 | - $this->getConstraintClarificationFromSerialization( $serialization ) |
|
71 | + $this->getConstraintClarificationFromSerialization($serialization) |
|
72 | 72 | ); |
73 | 73 | |
74 | 74 | $cachingMetadata = $this->deserializeCachingMetadata( |
@@ -76,18 +76,18 @@ discard block |
||
76 | 76 | ); |
77 | 77 | } |
78 | 78 | |
79 | - $dependencyMetadata = $this->getDependencyMetadataFromSerialization( $serialization ); |
|
79 | + $dependencyMetadata = $this->getDependencyMetadataFromSerialization($serialization); |
|
80 | 80 | |
81 | 81 | return $result->withMetadata( |
82 | - Metadata::merge( [ |
|
83 | - Metadata::ofCachingMetadata( $cachingMetadata ), |
|
84 | - Metadata::ofDependencyMetadata( $dependencyMetadata ), |
|
85 | - ] ) |
|
82 | + Metadata::merge([ |
|
83 | + Metadata::ofCachingMetadata($cachingMetadata), |
|
84 | + Metadata::ofDependencyMetadata($dependencyMetadata), |
|
85 | + ]) |
|
86 | 86 | ); |
87 | 87 | } |
88 | 88 | |
89 | - private function getViolationMessageFromSerialization( array $serialization ): ?ViolationMessage { |
|
90 | - if ( array_key_exists( CheckResultSerializer::KEY_VIOLATION_MESSAGE, $serialization ) ) { |
|
89 | + private function getViolationMessageFromSerialization(array $serialization): ?ViolationMessage { |
|
90 | + if (array_key_exists(CheckResultSerializer::KEY_VIOLATION_MESSAGE, $serialization)) { |
|
91 | 91 | return $this->violationMessageDeserializer->deserialize( |
92 | 92 | $serialization[CheckResultSerializer::KEY_VIOLATION_MESSAGE] |
93 | 93 | ); |
@@ -99,17 +99,17 @@ discard block |
||
99 | 99 | private function getConstraintClarificationFromSerialization( |
100 | 100 | array $serialization |
101 | 101 | ): MultilingualTextValue { |
102 | - if ( array_key_exists( CheckResultSerializer::KEY_CONSTRAINT_CLARIFICATION, $serialization ) ) { |
|
102 | + if (array_key_exists(CheckResultSerializer::KEY_CONSTRAINT_CLARIFICATION, $serialization)) { |
|
103 | 103 | return MultilingualTextValue::newFromArray( |
104 | 104 | $serialization[CheckResultSerializer::KEY_CONSTRAINT_CLARIFICATION] |
105 | 105 | ); |
106 | 106 | } else { |
107 | - return new MultilingualTextValue( [] ); |
|
107 | + return new MultilingualTextValue([]); |
|
108 | 108 | } |
109 | 109 | } |
110 | 110 | |
111 | - private function getDependencyMetadataFromSerialization( array $serialization ): DependencyMetadata { |
|
112 | - if ( array_key_exists( CheckResultSerializer::KEY_DEPENDENCY_METADATA, $serialization ) ) { |
|
111 | + private function getDependencyMetadataFromSerialization(array $serialization): DependencyMetadata { |
|
112 | + if (array_key_exists(CheckResultSerializer::KEY_DEPENDENCY_METADATA, $serialization)) { |
|
113 | 113 | return $this->deserializeDependencyMetadata( |
114 | 114 | $serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA] |
115 | 115 | ); |
@@ -118,7 +118,7 @@ discard block |
||
118 | 118 | } |
119 | 119 | } |
120 | 120 | |
121 | - private function deserializeCachingMetadata( array $serialization ): CachingMetadata { |
|
121 | + private function deserializeCachingMetadata(array $serialization): CachingMetadata { |
|
122 | 122 | if ( |
123 | 123 | array_key_exists( |
124 | 124 | CheckResultSerializer::KEY_CACHING_METADATA_MAX_AGE, |
@@ -133,7 +133,7 @@ discard block |
||
133 | 133 | } |
134 | 134 | } |
135 | 135 | |
136 | - private function deserializeDependencyMetadata( array $serialization ): DependencyMetadata { |
|
136 | + private function deserializeDependencyMetadata(array $serialization): DependencyMetadata { |
|
137 | 137 | if ( |
138 | 138 | array_key_exists( |
139 | 139 | CheckResultSerializer::KEY_DEPENDENCY_METADATA_FUTURE_TIME, |
@@ -143,20 +143,20 @@ discard block |
||
143 | 143 | $futureTime = TimeValue::newFromArray( |
144 | 144 | $serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA_FUTURE_TIME] |
145 | 145 | ); |
146 | - $futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime ); |
|
146 | + $futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime); |
|
147 | 147 | } else { |
148 | 148 | $futureTimeDependencyMetadata = DependencyMetadata::blank(); |
149 | 149 | } |
150 | 150 | |
151 | 151 | $dependencyMetadata = array_reduce( |
152 | 152 | $serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA_ENTITY_IDS], |
153 | - function ( DependencyMetadata $metadata, $entityIdSerialization ) { |
|
154 | - $entityId = $this->entityIdParser->parse( $entityIdSerialization ); |
|
153 | + function(DependencyMetadata $metadata, $entityIdSerialization) { |
|
154 | + $entityId = $this->entityIdParser->parse($entityIdSerialization); |
|
155 | 155 | |
156 | - return DependencyMetadata::merge( [ |
|
156 | + return DependencyMetadata::merge([ |
|
157 | 157 | $metadata, |
158 | - DependencyMetadata::ofEntityId( $entityId ), |
|
159 | - ] ); |
|
158 | + DependencyMetadata::ofEntityId($entityId), |
|
159 | + ]); |
|
160 | 160 | }, |
161 | 161 | $futureTimeDependencyMetadata |
162 | 162 | ); |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport\Specials; |
6 | 6 | |
@@ -97,7 +97,7 @@ discard block |
||
97 | 97 | Config $config, |
98 | 98 | IBufferingStatsdDataFactory $dataFactory |
99 | 99 | ) { |
100 | - parent::__construct( 'ConstraintReport' ); |
|
100 | + parent::__construct('ConstraintReport'); |
|
101 | 101 | |
102 | 102 | $this->entityLookup = $entityLookup; |
103 | 103 | $this->entityTitleLookup = $entityTitleLookup; |
@@ -106,7 +106,7 @@ discard block |
||
106 | 106 | $language = $this->getLanguage(); |
107 | 107 | |
108 | 108 | $formatterOptions = new FormatterOptions(); |
109 | - $formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() ); |
|
109 | + $formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode()); |
|
110 | 110 | $dataValueFormatter = $valueFormatterFactory->getValueFormatter( |
111 | 111 | SnakFormatter::FORMAT_HTML, |
112 | 112 | $formatterOptions |
@@ -130,7 +130,7 @@ discard block |
||
130 | 130 | ); |
131 | 131 | $this->violationMessageRenderer = $violationMessageRendererFactory->getViolationMessageRenderer( |
132 | 132 | $language, |
133 | - $languageFallbackChainFactory->newFromLanguage( $language ), |
|
133 | + $languageFallbackChainFactory->newFromLanguage($language), |
|
134 | 134 | $this->getContext() |
135 | 135 | ); |
136 | 136 | |
@@ -166,7 +166,7 @@ discard block |
||
166 | 166 | * @return string |
167 | 167 | */ |
168 | 168 | public function getDescription() { |
169 | - return $this->msg( 'wbqc-constraintreport' )->text(); |
|
169 | + return $this->msg('wbqc-constraintreport')->text(); |
|
170 | 170 | } |
171 | 171 | |
172 | 172 | /** |
@@ -178,43 +178,43 @@ discard block |
||
178 | 178 | * @throws EntityIdParsingException |
179 | 179 | * @throws UnexpectedValueException |
180 | 180 | */ |
181 | - public function execute( $subPage ) { |
|
181 | + public function execute($subPage) { |
|
182 | 182 | $out = $this->getOutput(); |
183 | 183 | |
184 | - $postRequest = $this->getContext()->getRequest()->getVal( 'entityid' ); |
|
185 | - if ( $postRequest ) { |
|
186 | - $out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() ); |
|
184 | + $postRequest = $this->getContext()->getRequest()->getVal('entityid'); |
|
185 | + if ($postRequest) { |
|
186 | + $out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL()); |
|
187 | 187 | return; |
188 | 188 | } |
189 | 189 | |
190 | 190 | $out->enableOOUI(); |
191 | - $out->addModules( $this->getModules() ); |
|
191 | + $out->addModules($this->getModules()); |
|
192 | 192 | |
193 | 193 | $this->setHeaders(); |
194 | 194 | |
195 | - $out->addHTML( $this->getExplanationText() ); |
|
195 | + $out->addHTML($this->getExplanationText()); |
|
196 | 196 | $this->buildEntityIdForm(); |
197 | 197 | |
198 | - if ( !$subPage ) { |
|
198 | + if (!$subPage) { |
|
199 | 199 | return; |
200 | 200 | } |
201 | 201 | |
202 | - if ( !is_string( $subPage ) ) { |
|
203 | - throw new InvalidArgumentException( '$subPage must be string.' ); |
|
202 | + if (!is_string($subPage)) { |
|
203 | + throw new InvalidArgumentException('$subPage must be string.'); |
|
204 | 204 | } |
205 | 205 | |
206 | 206 | try { |
207 | - $entityId = $this->entityIdParser->parse( $subPage ); |
|
208 | - } catch ( EntityIdParsingException $e ) { |
|
207 | + $entityId = $this->entityIdParser->parse($subPage); |
|
208 | + } catch (EntityIdParsingException $e) { |
|
209 | 209 | $out->addHTML( |
210 | - $this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true ) |
|
210 | + $this->buildNotice('wbqc-constraintreport-invalid-entity-id', true) |
|
211 | 211 | ); |
212 | 212 | return; |
213 | 213 | } |
214 | 214 | |
215 | - if ( !$this->entityLookup->hasEntity( $entityId ) ) { |
|
215 | + if (!$this->entityLookup->hasEntity($entityId)) { |
|
216 | 216 | $out->addHTML( |
217 | - $this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true ) |
|
217 | + $this->buildNotice('wbqc-constraintreport-not-existent-entity', true) |
|
218 | 218 | ); |
219 | 219 | return; |
220 | 220 | } |
@@ -222,18 +222,18 @@ discard block |
||
222 | 222 | $this->dataFactory->increment( |
223 | 223 | 'wikibase.quality.constraints.specials.specialConstraintReport.executeCheck' |
224 | 224 | ); |
225 | - $results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId ); |
|
225 | + $results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId); |
|
226 | 226 | |
227 | - if ( $results !== [] ) { |
|
227 | + if ($results !== []) { |
|
228 | 228 | $out->addHTML( |
229 | - $this->buildResultHeader( $entityId ) |
|
230 | - . $this->buildSummary( $results ) |
|
231 | - . $this->buildResultTable( $entityId, $results ) |
|
229 | + $this->buildResultHeader($entityId) |
|
230 | + . $this->buildSummary($results) |
|
231 | + . $this->buildResultTable($entityId, $results) |
|
232 | 232 | ); |
233 | 233 | } else { |
234 | 234 | $out->addHTML( |
235 | - $this->buildResultHeader( $entityId ) |
|
236 | - . $this->buildNotice( 'wbqc-constraintreport-empty-result' ) |
|
235 | + $this->buildResultHeader($entityId) |
|
236 | + . $this->buildNotice('wbqc-constraintreport-empty-result') |
|
237 | 237 | ); |
238 | 238 | } |
239 | 239 | } |
@@ -249,15 +249,15 @@ discard block |
||
249 | 249 | 'name' => 'entityid', |
250 | 250 | 'label-message' => 'wbqc-constraintreport-form-entityid-label', |
251 | 251 | 'cssclass' => 'wbqc-constraintreport-form-entity-id', |
252 | - 'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->escaped(), |
|
252 | + 'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->escaped(), |
|
253 | 253 | ], |
254 | 254 | ]; |
255 | - $htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form' ); |
|
256 | - $htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->escaped() ); |
|
257 | - $htmlForm->setSubmitCallback( static function () { |
|
255 | + $htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form'); |
|
256 | + $htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->escaped()); |
|
257 | + $htmlForm->setSubmitCallback(static function() { |
|
258 | 258 | return false; |
259 | 259 | } ); |
260 | - $htmlForm->setMethod( 'post' ); |
|
260 | + $htmlForm->setMethod('post'); |
|
261 | 261 | $htmlForm->show(); |
262 | 262 | } |
263 | 263 | |
@@ -271,9 +271,9 @@ discard block |
||
271 | 271 | * |
272 | 272 | * @return string HTML |
273 | 273 | */ |
274 | - private function buildNotice( string $messageKey, bool $error = false ): string { |
|
274 | + private function buildNotice(string $messageKey, bool $error = false): string { |
|
275 | 275 | $cssClasses = 'wbqc-constraintreport-notice'; |
276 | - if ( $error ) { |
|
276 | + if ($error) { |
|
277 | 277 | $cssClasses .= ' wbqc-constraintreport-notice-error'; |
278 | 278 | } |
279 | 279 | |
@@ -282,7 +282,7 @@ discard block |
||
282 | 282 | [ |
283 | 283 | 'class' => $cssClasses, |
284 | 284 | ], |
285 | - $this->msg( $messageKey )->escaped() |
|
285 | + $this->msg($messageKey)->escaped() |
|
286 | 286 | ); |
287 | 287 | } |
288 | 288 | |
@@ -292,16 +292,16 @@ discard block |
||
292 | 292 | private function getExplanationText(): string { |
293 | 293 | return Html::rawElement( |
294 | 294 | 'div', |
295 | - [ 'class' => 'wbqc-explanation' ], |
|
295 | + ['class' => 'wbqc-explanation'], |
|
296 | 296 | Html::rawElement( |
297 | 297 | 'p', |
298 | 298 | [], |
299 | - $this->msg( 'wbqc-constraintreport-explanation-part-one' )->escaped() |
|
299 | + $this->msg('wbqc-constraintreport-explanation-part-one')->escaped() |
|
300 | 300 | ) |
301 | 301 | . Html::rawElement( |
302 | 302 | 'p', |
303 | 303 | [], |
304 | - $this->msg( 'wbqc-constraintreport-explanation-part-two' )->escaped() |
|
304 | + $this->msg('wbqc-constraintreport-explanation-part-two')->escaped() |
|
305 | 305 | ) |
306 | 306 | ); |
307 | 307 | } |
@@ -313,31 +313,31 @@ discard block |
||
313 | 313 | * @return string HTML |
314 | 314 | * @suppress SecurityCheck-DoubleEscaped |
315 | 315 | */ |
316 | - private function buildResultTable( EntityId $entityId, array $results ): string { |
|
316 | + private function buildResultTable(EntityId $entityId, array $results): string { |
|
317 | 317 | // Set table headers |
318 | 318 | $table = new HtmlTableBuilder( |
319 | 319 | [ |
320 | 320 | new HtmlTableHeaderBuilder( |
321 | - $this->msg( 'wbqc-constraintreport-result-table-header-status' )->escaped(), |
|
321 | + $this->msg('wbqc-constraintreport-result-table-header-status')->escaped(), |
|
322 | 322 | true |
323 | 323 | ), |
324 | 324 | new HtmlTableHeaderBuilder( |
325 | - $this->msg( 'wbqc-constraintreport-result-table-header-property' )->escaped(), |
|
325 | + $this->msg('wbqc-constraintreport-result-table-header-property')->escaped(), |
|
326 | 326 | true |
327 | 327 | ), |
328 | 328 | new HtmlTableHeaderBuilder( |
329 | - $this->msg( 'wbqc-constraintreport-result-table-header-message' )->escaped(), |
|
329 | + $this->msg('wbqc-constraintreport-result-table-header-message')->escaped(), |
|
330 | 330 | true |
331 | 331 | ), |
332 | 332 | new HtmlTableHeaderBuilder( |
333 | - $this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->escaped(), |
|
333 | + $this->msg('wbqc-constraintreport-result-table-header-constraint')->escaped(), |
|
334 | 334 | true |
335 | 335 | ), |
336 | 336 | ] |
337 | 337 | ); |
338 | 338 | |
339 | - foreach ( $results as $result ) { |
|
340 | - $table = $this->appendToResultTable( $table, $entityId, $result ); |
|
339 | + foreach ($results as $result) { |
|
340 | + $table = $this->appendToResultTable($table, $entityId, $result); |
|
341 | 341 | } |
342 | 342 | |
343 | 343 | return $table->toHtml(); |
@@ -349,40 +349,40 @@ discard block |
||
349 | 349 | CheckResult $result |
350 | 350 | ): HtmlTableBuilder { |
351 | 351 | $message = $result->getMessage(); |
352 | - if ( $message === null ) { |
|
352 | + if ($message === null) { |
|
353 | 353 | // no row for this result |
354 | 354 | return $table; |
355 | 355 | } |
356 | 356 | |
357 | 357 | // Status column |
358 | - $statusColumn = $this->formatStatus( $result->getStatus() ); |
|
358 | + $statusColumn = $this->formatStatus($result->getStatus()); |
|
359 | 359 | |
360 | 360 | // Property column |
361 | - $propertyId = new NumericPropertyId( $result->getContextCursor()->getSnakPropertyId() ); |
|
361 | + $propertyId = new NumericPropertyId($result->getContextCursor()->getSnakPropertyId()); |
|
362 | 362 | $propertyColumn = $this->getClaimLink( |
363 | 363 | $entityId, |
364 | 364 | $propertyId, |
365 | - $this->entityIdLabelFormatter->formatEntityId( $propertyId ) |
|
365 | + $this->entityIdLabelFormatter->formatEntityId($propertyId) |
|
366 | 366 | ); |
367 | 367 | |
368 | 368 | // Message column |
369 | - $messageColumn = $this->violationMessageRenderer->render( $message ); |
|
369 | + $messageColumn = $this->violationMessageRenderer->render($message); |
|
370 | 370 | |
371 | 371 | // Constraint column |
372 | 372 | $constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId(); |
373 | 373 | try { |
374 | - $constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) ); |
|
375 | - } catch ( InvalidArgumentException $e ) { |
|
376 | - $constraintTypeLabel = htmlspecialchars( $constraintTypeItemId ); |
|
374 | + $constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId)); |
|
375 | + } catch (InvalidArgumentException $e) { |
|
376 | + $constraintTypeLabel = htmlspecialchars($constraintTypeItemId); |
|
377 | 377 | } |
378 | 378 | $constraintLink = $this->getClaimLink( |
379 | 379 | $propertyId, |
380 | - new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ), |
|
380 | + new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')), |
|
381 | 381 | $constraintTypeLabel |
382 | 382 | ); |
383 | 383 | $constraintColumn = $this->buildExpandableElement( |
384 | 384 | $constraintLink, |
385 | - $this->constraintParameterRenderer->formatParameters( $result->getParameters() ), |
|
385 | + $this->constraintParameterRenderer->formatParameters($result->getParameters()), |
|
386 | 386 | '[...]' |
387 | 387 | ); |
388 | 388 | |
@@ -422,15 +422,15 @@ discard block |
||
422 | 422 | * |
423 | 423 | * @return string HTML |
424 | 424 | */ |
425 | - protected function buildResultHeader( EntityId $entityId ): string { |
|
426 | - $entityLink = sprintf( '%s (%s)', |
|
427 | - $this->entityIdLinkFormatter->formatEntityId( $entityId ), |
|
428 | - htmlspecialchars( $entityId->getSerialization() ) ); |
|
425 | + protected function buildResultHeader(EntityId $entityId): string { |
|
426 | + $entityLink = sprintf('%s (%s)', |
|
427 | + $this->entityIdLinkFormatter->formatEntityId($entityId), |
|
428 | + htmlspecialchars($entityId->getSerialization())); |
|
429 | 429 | |
430 | 430 | return Html::rawElement( |
431 | 431 | 'h3', |
432 | 432 | [], |
433 | - sprintf( '%s %s', $this->msg( 'wbqc-constraintreport-result-headline' )->escaped(), $entityLink ) |
|
433 | + sprintf('%s %s', $this->msg('wbqc-constraintreport-result-headline')->escaped(), $entityLink) |
|
434 | 434 | ); |
435 | 435 | } |
436 | 436 | |
@@ -441,24 +441,24 @@ discard block |
||
441 | 441 | * |
442 | 442 | * @return string HTML |
443 | 443 | */ |
444 | - protected function buildSummary( array $results ): string { |
|
444 | + protected function buildSummary(array $results): string { |
|
445 | 445 | $statuses = []; |
446 | - foreach ( $results as $result ) { |
|
447 | - $status = strtolower( $result->getStatus() ); |
|
448 | - $statuses[$status] = isset( $statuses[$status] ) ? $statuses[$status] + 1 : 1; |
|
446 | + foreach ($results as $result) { |
|
447 | + $status = strtolower($result->getStatus()); |
|
448 | + $statuses[$status] = isset($statuses[$status]) ? $statuses[$status] + 1 : 1; |
|
449 | 449 | } |
450 | 450 | |
451 | 451 | $statusElements = []; |
452 | - foreach ( $statuses as $status => $count ) { |
|
453 | - if ( $count > 0 ) { |
|
452 | + foreach ($statuses as $status => $count) { |
|
453 | + if ($count > 0) { |
|
454 | 454 | $statusElements[] = |
455 | - $this->formatStatus( $status ) |
|
455 | + $this->formatStatus($status) |
|
456 | 456 | . ': ' |
457 | 457 | . $count; |
458 | 458 | } |
459 | 459 | } |
460 | 460 | |
461 | - return Html::rawElement( 'p', [], implode( ', ', $statusElements ) ); |
|
461 | + return Html::rawElement('p', [], implode(', ', $statusElements)); |
|
462 | 462 | } |
463 | 463 | |
464 | 464 | /** |
@@ -478,7 +478,7 @@ discard block |
||
478 | 478 | ?string $expandableContent, |
479 | 479 | string $indicator |
480 | 480 | ): string { |
481 | - if ( empty( $expandableContent ) ) { |
|
481 | + if (empty($expandableContent)) { |
|
482 | 482 | return $content; |
483 | 483 | } |
484 | 484 | |
@@ -498,7 +498,7 @@ discard block |
||
498 | 498 | $expandableContent |
499 | 499 | ); |
500 | 500 | |
501 | - return sprintf( '%s %s %s', $content, $tooltipIndicator, $wrappedExpandableContent ); |
|
501 | + return sprintf('%s %s %s', $content, $tooltipIndicator, $wrappedExpandableContent); |
|
502 | 502 | } |
503 | 503 | |
504 | 504 | /** |
@@ -510,8 +510,8 @@ discard block |
||
510 | 510 | * |
511 | 511 | * @return string HTML |
512 | 512 | */ |
513 | - private function formatStatus( string $status ): string { |
|
514 | - $messageName = "wbqc-constraintreport-status-" . strtolower( $status ); |
|
513 | + private function formatStatus(string $status): string { |
|
514 | + $messageName = "wbqc-constraintreport-status-".strtolower($status); |
|
515 | 515 | $statusIcons = [ |
516 | 516 | CheckResult::STATUS_SUGGESTION => [ |
517 | 517 | 'icon' => 'suggestion-constraint-violation', |
@@ -528,25 +528,25 @@ discard block |
||
528 | 528 | ], |
529 | 529 | ]; |
530 | 530 | |
531 | - if ( array_key_exists( $status, $statusIcons ) ) { |
|
532 | - $iconWidget = new IconWidget( $statusIcons[$status] ); |
|
533 | - $iconHtml = $iconWidget->toString() . ' '; |
|
531 | + if (array_key_exists($status, $statusIcons)) { |
|
532 | + $iconWidget = new IconWidget($statusIcons[$status]); |
|
533 | + $iconHtml = $iconWidget->toString().' '; |
|
534 | 534 | } else { |
535 | 535 | $iconHtml = ''; |
536 | 536 | } |
537 | 537 | |
538 | - $labelWidget = new LabelWidget( [ |
|
539 | - 'label' => $this->msg( $messageName )->text(), |
|
540 | - ] ); |
|
538 | + $labelWidget = new LabelWidget([ |
|
539 | + 'label' => $this->msg($messageName)->text(), |
|
540 | + ]); |
|
541 | 541 | $labelHtml = $labelWidget->toString(); |
542 | 542 | |
543 | 543 | $formattedStatus = |
544 | 544 | Html::rawElement( |
545 | 545 | 'span', |
546 | 546 | [ |
547 | - 'class' => 'wbqc-status wbqc-status-' . $status, |
|
547 | + 'class' => 'wbqc-status wbqc-status-'.$status, |
|
548 | 548 | ], |
549 | - $iconHtml . $labelHtml |
|
549 | + $iconHtml.$labelHtml |
|
550 | 550 | ); |
551 | 551 | |
552 | 552 | return $formattedStatus; |
@@ -569,7 +569,7 @@ discard block |
||
569 | 569 | return Html::rawElement( |
570 | 570 | 'a', |
571 | 571 | [ |
572 | - 'href' => $this->getClaimUrl( $entityId, $propertyId ), |
|
572 | + 'href' => $this->getClaimUrl($entityId, $propertyId), |
|
573 | 573 | 'target' => '_blank', |
574 | 574 | ], |
575 | 575 | $text |
@@ -583,8 +583,8 @@ discard block |
||
583 | 583 | EntityId $entityId, |
584 | 584 | NumericPropertyId $propertyId |
585 | 585 | ): string { |
586 | - $title = $this->entityTitleLookup->getTitleForId( $entityId ); |
|
587 | - $entityUrl = sprintf( '%s#%s', $title->getLocalURL(), $propertyId->getSerialization() ); |
|
586 | + $title = $this->entityTitleLookup->getTitleForId($entityId); |
|
587 | + $entityUrl = sprintf('%s#%s', $title->getLocalURL(), $propertyId->getSerialization()); |
|
588 | 588 | |
589 | 589 | return $entityUrl; |
590 | 590 | } |
@@ -24,16 +24,16 @@ discard block |
||
24 | 24 | * then using the main DBLoadBalancer service may be incorrect. |
25 | 25 | * @param string|false $dbName Database name ($domain for ILoadBalancer methods). |
26 | 26 | */ |
27 | - public function __construct( ILoadBalancer $lb, $dbName ) { |
|
27 | + public function __construct(ILoadBalancer $lb, $dbName) { |
|
28 | 28 | $this->lb = $lb; |
29 | 29 | $this->dbName = $dbName; |
30 | 30 | } |
31 | 31 | |
32 | - private function encodeConstraintParameters( array $constraintParameters ) { |
|
33 | - $json = json_encode( $constraintParameters, JSON_FORCE_OBJECT ); |
|
32 | + private function encodeConstraintParameters(array $constraintParameters) { |
|
33 | + $json = json_encode($constraintParameters, JSON_FORCE_OBJECT); |
|
34 | 34 | |
35 | - if ( strlen( $json ) > 50000 ) { |
|
36 | - $json = json_encode( [ '@error' => [ 'toolong' => true ] ] ); |
|
35 | + if (strlen($json) > 50000) { |
|
36 | + $json = json_encode(['@error' => ['toolong' => true]]); |
|
37 | 37 | } |
38 | 38 | |
39 | 39 | return $json; |
@@ -45,21 +45,21 @@ discard block |
||
45 | 45 | * @throws DBUnexpectedError |
46 | 46 | * @return bool |
47 | 47 | */ |
48 | - public function insertBatch( array $constraints ) { |
|
48 | + public function insertBatch(array $constraints) { |
|
49 | 49 | $accumulator = array_map( |
50 | - function ( Constraint $constraint ) { |
|
50 | + function(Constraint $constraint) { |
|
51 | 51 | return [ |
52 | 52 | 'constraint_guid' => $constraint->getConstraintId(), |
53 | 53 | 'pid' => $constraint->getPropertyId()->getNumericId(), |
54 | 54 | 'constraint_type_qid' => $constraint->getConstraintTypeItemId(), |
55 | - 'constraint_parameters' => $this->encodeConstraintParameters( $constraint->getConstraintParameters() ), |
|
55 | + 'constraint_parameters' => $this->encodeConstraintParameters($constraint->getConstraintParameters()), |
|
56 | 56 | ]; |
57 | 57 | }, |
58 | 58 | $constraints |
59 | 59 | ); |
60 | 60 | |
61 | - $dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName ); |
|
62 | - return $dbw->insert( 'wbqc_constraints', $accumulator, __METHOD__ ); |
|
61 | + $dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName); |
|
62 | + return $dbw->insert('wbqc_constraints', $accumulator, __METHOD__); |
|
63 | 63 | } |
64 | 64 | |
65 | 65 | /** |
@@ -69,8 +69,8 @@ discard block |
||
69 | 69 | * |
70 | 70 | * @throws DBUnexpectedError |
71 | 71 | */ |
72 | - public function deleteForProperty( NumericPropertyId $propertyId ) { |
|
73 | - $dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName ); |
|
72 | + public function deleteForProperty(NumericPropertyId $propertyId) { |
|
73 | + $dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName); |
|
74 | 74 | $dbw->delete( |
75 | 75 | 'wbqc_constraints', |
76 | 76 | [ |
@@ -18,10 +18,10 @@ discard block |
||
18 | 18 | use Wikibase\Repo\WikibaseRepo; |
19 | 19 | |
20 | 20 | // @codeCoverageIgnoreStart |
21 | -$basePath = getenv( "MW_INSTALL_PATH" ) !== false |
|
22 | - ? getenv( "MW_INSTALL_PATH" ) : __DIR__ . "/../../.."; |
|
21 | +$basePath = getenv("MW_INSTALL_PATH") !== false |
|
22 | + ? getenv("MW_INSTALL_PATH") : __DIR__."/../../.."; |
|
23 | 23 | |
24 | -require_once $basePath . "/maintenance/Maintenance.php"; |
|
24 | +require_once $basePath."/maintenance/Maintenance.php"; |
|
25 | 25 | // @codeCoverageIgnoreEnd |
26 | 26 | |
27 | 27 | /** |
@@ -60,20 +60,20 @@ discard block |
||
60 | 60 | parent::__construct(); |
61 | 61 | |
62 | 62 | $this->addDescription( |
63 | - 'Import entities needed for constraint checks ' . |
|
63 | + 'Import entities needed for constraint checks '. |
|
64 | 64 | 'from Wikidata into the local repository.' |
65 | 65 | ); |
66 | 66 | $this->addOption( |
67 | 67 | 'config-format', |
68 | - 'The format in which the resulting configuration will be omitted: ' . |
|
69 | - '"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), ' . |
|
68 | + 'The format in which the resulting configuration will be omitted: '. |
|
69 | + '"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), '. |
|
70 | 70 | 'or "wgConf" for printing parts of arrays suitable for inclusion in $wgConf->settings.' |
71 | 71 | ); |
72 | 72 | $this->addOption( |
73 | 73 | 'dry-run', |
74 | 74 | 'Don’t actually import entities, just print which ones would be imported.' |
75 | 75 | ); |
76 | - $this->requireExtension( 'WikibaseQualityConstraints' ); |
|
76 | + $this->requireExtension('WikibaseQualityConstraints'); |
|
77 | 77 | } |
78 | 78 | |
79 | 79 | /** |
@@ -81,12 +81,12 @@ discard block |
||
81 | 81 | */ |
82 | 82 | private function setupServices() { |
83 | 83 | $services = MediaWikiServices::getInstance(); |
84 | - $this->entitySerializer = WikibaseRepo::getAllTypesEntitySerializer( $services ); |
|
85 | - $this->entityDeserializer = WikibaseRepo::getInternalFormatEntityDeserializer( $services ); |
|
86 | - $this->entityStore = WikibaseRepo::getEntityStore( $services ); |
|
84 | + $this->entitySerializer = WikibaseRepo::getAllTypesEntitySerializer($services); |
|
85 | + $this->entityDeserializer = WikibaseRepo::getInternalFormatEntityDeserializer($services); |
|
86 | + $this->entityStore = WikibaseRepo::getEntityStore($services); |
|
87 | 87 | $this->httpRequestFactory = $services->getHttpRequestFactory(); |
88 | - if ( !$this->getOption( 'dry-run', false ) ) { |
|
89 | - $this->user = User::newSystemUser( 'WikibaseQualityConstraints importer' ); |
|
88 | + if (!$this->getOption('dry-run', false)) { |
|
89 | + $this->user = User::newSystemUser('WikibaseQualityConstraints importer'); |
|
90 | 90 | } |
91 | 91 | } |
92 | 92 | |
@@ -95,21 +95,21 @@ discard block |
||
95 | 95 | |
96 | 96 | $configUpdates = []; |
97 | 97 | |
98 | - $extensionJsonFile = __DIR__ . '/../extension.json'; |
|
99 | - $extensionJsonText = file_get_contents( $extensionJsonFile ); |
|
100 | - $extensionJson = json_decode( $extensionJsonText, /* assoc = */ true ); |
|
98 | + $extensionJsonFile = __DIR__.'/../extension.json'; |
|
99 | + $extensionJsonText = file_get_contents($extensionJsonFile); |
|
100 | + $extensionJson = json_decode($extensionJsonText, /* assoc = */ true); |
|
101 | 101 | // @phan-suppress-next-line PhanTypeArraySuspiciousNullable |
102 | - $wikidataEntityIds = $this->getEntitiesToImport( $extensionJson['config'], $this->getConfig() ); |
|
102 | + $wikidataEntityIds = $this->getEntitiesToImport($extensionJson['config'], $this->getConfig()); |
|
103 | 103 | |
104 | - foreach ( $wikidataEntityIds as $key => $wikidataEntityId ) { |
|
105 | - $localEntityId = $this->importEntityFromWikidata( $wikidataEntityId ); |
|
104 | + foreach ($wikidataEntityIds as $key => $wikidataEntityId) { |
|
105 | + $localEntityId = $this->importEntityFromWikidata($wikidataEntityId); |
|
106 | 106 | $configUpdates[$key] = [ |
107 | 107 | 'wikidata' => $wikidataEntityId, |
108 | 108 | 'local' => $localEntityId, |
109 | 109 | ]; |
110 | 110 | } |
111 | 111 | |
112 | - $this->outputConfigUpdates( $configUpdates ); |
|
112 | + $this->outputConfigUpdates($configUpdates); |
|
113 | 113 | } |
114 | 114 | |
115 | 115 | /** |
@@ -117,18 +117,18 @@ discard block |
||
117 | 117 | * @param Config $wikiConfig |
118 | 118 | * @return string[] |
119 | 119 | */ |
120 | - private function getEntitiesToImport( array $extensionJsonConfig, Config $wikiConfig ) { |
|
120 | + private function getEntitiesToImport(array $extensionJsonConfig, Config $wikiConfig) { |
|
121 | 121 | $wikidataEntityIds = []; |
122 | 122 | |
123 | - foreach ( $extensionJsonConfig as $key => $value ) { |
|
124 | - if ( !preg_match( '/Id$/', $key ) ) { |
|
123 | + foreach ($extensionJsonConfig as $key => $value) { |
|
124 | + if (!preg_match('/Id$/', $key)) { |
|
125 | 125 | continue; |
126 | 126 | } |
127 | 127 | |
128 | 128 | $wikidataEntityId = $value['value']; |
129 | - $localEntityId = $wikiConfig->get( $key ); |
|
129 | + $localEntityId = $wikiConfig->get($key); |
|
130 | 130 | |
131 | - if ( $localEntityId === $wikidataEntityId ) { |
|
131 | + if ($localEntityId === $wikidataEntityId) { |
|
132 | 132 | $wikidataEntityIds[$key] = $wikidataEntityId; |
133 | 133 | } |
134 | 134 | } |
@@ -140,10 +140,10 @@ discard block |
||
140 | 140 | * @param string $wikidataEntityId |
141 | 141 | * @return string local entity ID |
142 | 142 | */ |
143 | - private function importEntityFromWikidata( $wikidataEntityId ) { |
|
143 | + private function importEntityFromWikidata($wikidataEntityId) { |
|
144 | 144 | $wikidataEntityUrl = "https://www.wikidata.org/wiki/Special:EntityData/$wikidataEntityId.json"; |
145 | - $wikidataEntitiesJson = $this->httpRequestFactory->get( $wikidataEntityUrl, [], __METHOD__ ); |
|
146 | - return $this->importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson ); |
|
145 | + $wikidataEntitiesJson = $this->httpRequestFactory->get($wikidataEntityUrl, [], __METHOD__); |
|
146 | + return $this->importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson); |
|
147 | 147 | } |
148 | 148 | |
149 | 149 | /** |
@@ -151,24 +151,24 @@ discard block |
||
151 | 151 | * @param string $wikidataEntitiesJson |
152 | 152 | * @return string local entity ID |
153 | 153 | */ |
154 | - private function importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson ) { |
|
154 | + private function importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson) { |
|
155 | 155 | // @phan-suppress-next-line PhanTypeArraySuspiciousNullable |
156 | - $wikidataEntityArray = json_decode( $wikidataEntitiesJson, true )['entities'][$wikidataEntityId]; |
|
157 | - $wikidataEntity = $this->entityDeserializer->deserialize( $wikidataEntityArray ); |
|
156 | + $wikidataEntityArray = json_decode($wikidataEntitiesJson, true)['entities'][$wikidataEntityId]; |
|
157 | + $wikidataEntity = $this->entityDeserializer->deserialize($wikidataEntityArray); |
|
158 | 158 | |
159 | - $wikidataEntity->setId( null ); |
|
159 | + $wikidataEntity->setId(null); |
|
160 | 160 | |
161 | - if ( $wikidataEntity instanceof StatementListProvider ) { |
|
161 | + if ($wikidataEntity instanceof StatementListProvider) { |
|
162 | 162 | $wikidataEntity->getStatements()->clear(); |
163 | 163 | } |
164 | 164 | |
165 | - if ( $wikidataEntity instanceof Item ) { |
|
166 | - $wikidataEntity->setSiteLinkList( new SiteLinkList() ); |
|
165 | + if ($wikidataEntity instanceof Item) { |
|
166 | + $wikidataEntity->setSiteLinkList(new SiteLinkList()); |
|
167 | 167 | } |
168 | 168 | |
169 | - if ( $this->getOption( 'dry-run', false ) ) { |
|
170 | - $wikidataEntityJson = json_encode( $this->entitySerializer->serialize( $wikidataEntity ) ); |
|
171 | - $this->output( $wikidataEntityJson . "\n" ); |
|
169 | + if ($this->getOption('dry-run', false)) { |
|
170 | + $wikidataEntityJson = json_encode($this->entitySerializer->serialize($wikidataEntity)); |
|
171 | + $this->output($wikidataEntityJson."\n"); |
|
172 | 172 | return "-$wikidataEntityId"; |
173 | 173 | } |
174 | 174 | |
@@ -181,12 +181,12 @@ discard block |
||
181 | 181 | )->getEntity(); |
182 | 182 | |
183 | 183 | return $localEntity->getId()->getSerialization(); |
184 | - } catch ( StorageException $storageException ) { |
|
185 | - return $this->storageExceptionToEntityId( $storageException ); |
|
184 | + } catch (StorageException $storageException) { |
|
185 | + return $this->storageExceptionToEntityId($storageException); |
|
186 | 186 | } |
187 | 187 | } |
188 | 188 | |
189 | - private function storageExceptionToEntityId( StorageException $storageException ) { |
|
189 | + private function storageExceptionToEntityId(StorageException $storageException) { |
|
190 | 190 | $message = $storageException->getMessage(); |
191 | 191 | // example messages: |
192 | 192 | // * Item [[Item:Q475|Q475]] already has label "as references" |
@@ -196,25 +196,25 @@ discard block |
||
196 | 196 | // * Property [[Property:P694|P694]] already has label "instance of" |
197 | 197 | // associated with language code en. |
198 | 198 | $pattern = '/[[|]([^][|]*)]] already has label .* associated with language code/'; |
199 | - if ( preg_match( $pattern, $message, $matches ) ) { |
|
199 | + if (preg_match($pattern, $message, $matches)) { |
|
200 | 200 | return $matches[1]; |
201 | 201 | } else { |
202 | 202 | throw $storageException; |
203 | 203 | } |
204 | 204 | } |
205 | 205 | |
206 | - private function outputConfigUpdates( array $configUpdates ) { |
|
207 | - $configFormat = $this->getOption( 'config-format', 'globals' ); |
|
208 | - switch ( $configFormat ) { |
|
206 | + private function outputConfigUpdates(array $configUpdates) { |
|
207 | + $configFormat = $this->getOption('config-format', 'globals'); |
|
208 | + switch ($configFormat) { |
|
209 | 209 | case 'globals': |
210 | - $this->outputConfigUpdatesGlobals( $configUpdates ); |
|
210 | + $this->outputConfigUpdatesGlobals($configUpdates); |
|
211 | 211 | break; |
212 | 212 | case 'wgConf': |
213 | - $this->outputConfigUpdatesWgConf( $configUpdates ); |
|
213 | + $this->outputConfigUpdatesWgConf($configUpdates); |
|
214 | 214 | break; |
215 | 215 | default: |
216 | - $this->error( "Invalid config format \"$configFormat\", using \"globals\"" ); |
|
217 | - $this->outputConfigUpdatesGlobals( $configUpdates ); |
|
216 | + $this->error("Invalid config format \"$configFormat\", using \"globals\""); |
|
217 | + $this->outputConfigUpdatesGlobals($configUpdates); |
|
218 | 218 | break; |
219 | 219 | } |
220 | 220 | } |
@@ -222,22 +222,22 @@ discard block |
||
222 | 222 | /** |
223 | 223 | * @param array[] $configUpdates |
224 | 224 | */ |
225 | - private function outputConfigUpdatesGlobals( array $configUpdates ) { |
|
226 | - foreach ( $configUpdates as $key => $value ) { |
|
227 | - $localValueCode = var_export( $value['local'], true ); |
|
228 | - $this->output( "\$wg$key = $localValueCode;\n" ); |
|
225 | + private function outputConfigUpdatesGlobals(array $configUpdates) { |
|
226 | + foreach ($configUpdates as $key => $value) { |
|
227 | + $localValueCode = var_export($value['local'], true); |
|
228 | + $this->output("\$wg$key = $localValueCode;\n"); |
|
229 | 229 | } |
230 | 230 | } |
231 | 231 | |
232 | 232 | /** |
233 | 233 | * @param array[] $configUpdates |
234 | 234 | */ |
235 | - private function outputConfigUpdatesWgConf( array $configUpdates ) { |
|
236 | - $wikiIdCode = var_export( WikiMap::getCurrentWikiId(), true ); |
|
237 | - foreach ( $configUpdates as $key => $value ) { |
|
238 | - $keyCode = var_export( "wg$key", true ); |
|
239 | - $wikidataValueCode = var_export( $value['wikidata'], true ); |
|
240 | - $localValueCode = var_export( $value['local'], true ); |
|
235 | + private function outputConfigUpdatesWgConf(array $configUpdates) { |
|
236 | + $wikiIdCode = var_export(WikiMap::getCurrentWikiId(), true); |
|
237 | + foreach ($configUpdates as $key => $value) { |
|
238 | + $keyCode = var_export("wg$key", true); |
|
239 | + $wikidataValueCode = var_export($value['wikidata'], true); |
|
240 | + $localValueCode = var_export($value['local'], true); |
|
241 | 241 | $block = <<< EOF |
242 | 242 | $keyCode => [ |
243 | 243 | 'default' => $wikidataValueCode, |
@@ -246,7 +246,7 @@ discard block |
||
246 | 246 | |
247 | 247 | |
248 | 248 | EOF; |
249 | - $this->output( $block ); |
|
249 | + $this->output($block); |
|
250 | 250 | } |
251 | 251 | } |
252 | 252 |
@@ -30,53 +30,53 @@ discard block |
||
30 | 30 | use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer; |
31 | 31 | |
32 | 32 | return [ |
33 | - ConstraintsServices::EXPIRY_LOCK => static function ( MediaWikiServices $services ) { |
|
34 | - return new ExpiryLock( ObjectCache::getInstance( CACHE_ANYTHING ) ); |
|
33 | + ConstraintsServices::EXPIRY_LOCK => static function(MediaWikiServices $services) { |
|
34 | + return new ExpiryLock(ObjectCache::getInstance(CACHE_ANYTHING)); |
|
35 | 35 | }, |
36 | 36 | |
37 | - ConstraintsServices::LOGGING_HELPER => static function ( MediaWikiServices $services ) { |
|
37 | + ConstraintsServices::LOGGING_HELPER => static function(MediaWikiServices $services) { |
|
38 | 38 | return new LoggingHelper( |
39 | 39 | $services->getStatsdDataFactory(), |
40 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' ), |
|
40 | + LoggerFactory::getInstance('WikibaseQualityConstraints'), |
|
41 | 41 | $services->getMainConfig() |
42 | 42 | ); |
43 | 43 | }, |
44 | 44 | |
45 | - ConstraintsServices::CONSTRAINT_STORE => static function ( MediaWikiServices $services ) { |
|
46 | - $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
47 | - $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE ); |
|
48 | - if ( $propertySource === null ) { |
|
49 | - throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' ); |
|
45 | + ConstraintsServices::CONSTRAINT_STORE => static function(MediaWikiServices $services) { |
|
46 | + $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
47 | + $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE); |
|
48 | + if ($propertySource === null) { |
|
49 | + throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.'); |
|
50 | 50 | } |
51 | 51 | |
52 | - $localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName(); |
|
53 | - if ( $propertySource->getSourceName() !== $localEntitySourceName ) { |
|
54 | - throw new RuntimeException( 'Can\'t get a ConstraintStore for a non local entity source.' ); |
|
52 | + $localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName(); |
|
53 | + if ($propertySource->getSourceName() !== $localEntitySourceName) { |
|
54 | + throw new RuntimeException('Can\'t get a ConstraintStore for a non local entity source.'); |
|
55 | 55 | } |
56 | 56 | |
57 | 57 | $dbName = $propertySource->getDatabaseName(); |
58 | 58 | return new ConstraintRepositoryStore( |
59 | - $services->getDBLoadBalancerFactory()->getMainLB( $dbName ), |
|
59 | + $services->getDBLoadBalancerFactory()->getMainLB($dbName), |
|
60 | 60 | $dbName |
61 | 61 | ); |
62 | 62 | }, |
63 | 63 | |
64 | - ConstraintsServices::CONSTRAINT_LOOKUP => static function ( MediaWikiServices $services ) { |
|
65 | - $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
66 | - $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE ); |
|
67 | - if ( $propertySource === null ) { |
|
68 | - throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' ); |
|
64 | + ConstraintsServices::CONSTRAINT_LOOKUP => static function(MediaWikiServices $services) { |
|
65 | + $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
66 | + $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE); |
|
67 | + if ($propertySource === null) { |
|
68 | + throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.'); |
|
69 | 69 | } |
70 | 70 | |
71 | 71 | $dbName = $propertySource->getDatabaseName(); |
72 | 72 | $rawLookup = new ConstraintRepositoryLookup( |
73 | - $services->getDBLoadBalancerFactory()->getMainLB( $dbName ), |
|
73 | + $services->getDBLoadBalancerFactory()->getMainLB($dbName), |
|
74 | 74 | $dbName |
75 | 75 | ); |
76 | - return new CachingConstraintLookup( $rawLookup ); |
|
76 | + return new CachingConstraintLookup($rawLookup); |
|
77 | 77 | }, |
78 | 78 | |
79 | - ConstraintsServices::CHECK_RESULT_SERIALIZER => static function ( MediaWikiServices $services ) { |
|
79 | + ConstraintsServices::CHECK_RESULT_SERIALIZER => static function(MediaWikiServices $services) { |
|
80 | 80 | return new CheckResultSerializer( |
81 | 81 | new ConstraintSerializer( |
82 | 82 | false // constraint parameters are not exposed |
@@ -87,9 +87,9 @@ discard block |
||
87 | 87 | ); |
88 | 88 | }, |
89 | 89 | |
90 | - ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function ( MediaWikiServices $services ) { |
|
91 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
92 | - $dataValueFactory = WikibaseRepo::getDataValueFactory( $services ); |
|
90 | + ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function(MediaWikiServices $services) { |
|
91 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
92 | + $dataValueFactory = WikibaseRepo::getDataValueFactory($services); |
|
93 | 93 | |
94 | 94 | return new CheckResultDeserializer( |
95 | 95 | new ConstraintDeserializer(), |
@@ -102,13 +102,13 @@ discard block |
||
102 | 102 | ); |
103 | 103 | }, |
104 | 104 | |
105 | - ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function ( MediaWikiServices $services ) { |
|
105 | + ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function(MediaWikiServices $services) { |
|
106 | 106 | return new ViolationMessageSerializer(); |
107 | 107 | }, |
108 | 108 | |
109 | - ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function ( MediaWikiServices $services ) { |
|
110 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
111 | - $dataValueFactory = WikibaseRepo::getDataValueFactory( $services ); |
|
109 | + ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function(MediaWikiServices $services) { |
|
110 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
111 | + $dataValueFactory = WikibaseRepo::getDataValueFactory($services); |
|
112 | 112 | |
113 | 113 | return new ViolationMessageDeserializer( |
114 | 114 | $entityIdParser, |
@@ -116,37 +116,37 @@ discard block |
||
116 | 116 | ); |
117 | 117 | }, |
118 | 118 | |
119 | - ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function ( MediaWikiServices $services ) { |
|
120 | - $deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory( $services ); |
|
121 | - $entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
119 | + ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function(MediaWikiServices $services) { |
|
120 | + $deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory($services); |
|
121 | + $entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
122 | 122 | |
123 | 123 | return new ConstraintParameterParser( |
124 | 124 | $services->getMainConfig(), |
125 | 125 | $deserializerFactory, |
126 | - $entitySourceDefinitions->getDatabaseSourceForEntityType( 'item' )->getConceptBaseUri() |
|
126 | + $entitySourceDefinitions->getDatabaseSourceForEntityType('item')->getConceptBaseUri() |
|
127 | 127 | ); |
128 | 128 | }, |
129 | 129 | |
130 | - ConstraintsServices::CONNECTION_CHECKER_HELPER => static function ( MediaWikiServices $services ) { |
|
130 | + ConstraintsServices::CONNECTION_CHECKER_HELPER => static function(MediaWikiServices $services) { |
|
131 | 131 | return new ConnectionCheckerHelper(); |
132 | 132 | }, |
133 | 133 | |
134 | - ConstraintsServices::RANGE_CHECKER_HELPER => static function ( MediaWikiServices $services ) { |
|
134 | + ConstraintsServices::RANGE_CHECKER_HELPER => static function(MediaWikiServices $services) { |
|
135 | 135 | return new RangeCheckerHelper( |
136 | 136 | $services->getMainConfig(), |
137 | - WikibaseRepo::getUnitConverter( $services ) |
|
137 | + WikibaseRepo::getUnitConverter($services) |
|
138 | 138 | ); |
139 | 139 | }, |
140 | 140 | |
141 | - ConstraintsServices::SPARQL_HELPER => static function ( MediaWikiServices $services ) { |
|
142 | - $endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' ); |
|
143 | - if ( $endpoint === '' ) { |
|
141 | + ConstraintsServices::SPARQL_HELPER => static function(MediaWikiServices $services) { |
|
142 | + $endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint'); |
|
143 | + if ($endpoint === '') { |
|
144 | 144 | return new DummySparqlHelper(); |
145 | 145 | } |
146 | 146 | |
147 | - $rdfVocabulary = WikibaseRepo::getRdfVocabulary( $services ); |
|
148 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
149 | - $propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup( $services ); |
|
147 | + $rdfVocabulary = WikibaseRepo::getRdfVocabulary($services); |
|
148 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
149 | + $propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup($services); |
|
150 | 150 | |
151 | 151 | return new SparqlHelper( |
152 | 152 | $services->getMainConfig(), |
@@ -154,126 +154,126 @@ discard block |
||
154 | 154 | $entityIdParser, |
155 | 155 | $propertyDataTypeLookup, |
156 | 156 | $services->getMainWANObjectCache(), |
157 | - ConstraintsServices::getViolationMessageSerializer( $services ), |
|
158 | - ConstraintsServices::getViolationMessageDeserializer( $services ), |
|
157 | + ConstraintsServices::getViolationMessageSerializer($services), |
|
158 | + ConstraintsServices::getViolationMessageDeserializer($services), |
|
159 | 159 | $services->getStatsdDataFactory(), |
160 | - ConstraintsServices::getExpiryLock( $services ), |
|
161 | - ConstraintsServices::getLoggingHelper( $services ), |
|
162 | - WikiMap::getCurrentWikiId() . ' WikibaseQualityConstraints ' . $services->getHttpRequestFactory()->getUserAgent(), |
|
160 | + ConstraintsServices::getExpiryLock($services), |
|
161 | + ConstraintsServices::getLoggingHelper($services), |
|
162 | + WikiMap::getCurrentWikiId().' WikibaseQualityConstraints '.$services->getHttpRequestFactory()->getUserAgent(), |
|
163 | 163 | $services->getHttpRequestFactory() |
164 | 164 | ); |
165 | 165 | }, |
166 | 166 | |
167 | - ConstraintsServices::TYPE_CHECKER_HELPER => static function ( MediaWikiServices $services ) { |
|
167 | + ConstraintsServices::TYPE_CHECKER_HELPER => static function(MediaWikiServices $services) { |
|
168 | 168 | return new TypeCheckerHelper( |
169 | - WikibaseServices::getEntityLookup( $services ), |
|
169 | + WikibaseServices::getEntityLookup($services), |
|
170 | 170 | $services->getMainConfig(), |
171 | - ConstraintsServices::getSparqlHelper( $services ), |
|
171 | + ConstraintsServices::getSparqlHelper($services), |
|
172 | 172 | $services->getStatsdDataFactory() |
173 | 173 | ); |
174 | 174 | }, |
175 | 175 | |
176 | - ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function ( MediaWikiServices $services ) { |
|
177 | - $statementGuidParser = WikibaseRepo::getStatementGuidParser( $services ); |
|
176 | + ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function(MediaWikiServices $services) { |
|
177 | + $statementGuidParser = WikibaseRepo::getStatementGuidParser($services); |
|
178 | 178 | |
179 | 179 | $config = $services->getMainConfig(); |
180 | 180 | $checkerMap = [ |
181 | - $config->get( 'WBQualityConstraintsConflictsWithConstraintId' ) |
|
182 | - => ConstraintCheckerServices::getConflictsWithChecker( $services ), |
|
183 | - $config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' ) |
|
184 | - => ConstraintCheckerServices::getItemChecker( $services ), |
|
185 | - $config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' ) |
|
186 | - => ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ), |
|
187 | - $config->get( 'WBQualityConstraintsSymmetricConstraintId' ) |
|
188 | - => ConstraintCheckerServices::getSymmetricChecker( $services ), |
|
189 | - $config->get( 'WBQualityConstraintsInverseConstraintId' ) |
|
190 | - => ConstraintCheckerServices::getInverseChecker( $services ), |
|
191 | - $config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' ) |
|
192 | - => ConstraintCheckerServices::getQualifierChecker( $services ), |
|
193 | - $config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' ) |
|
194 | - => ConstraintCheckerServices::getQualifiersChecker( $services ), |
|
195 | - $config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' ) |
|
196 | - => ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ), |
|
197 | - $config->get( 'WBQualityConstraintsRangeConstraintId' ) |
|
198 | - => ConstraintCheckerServices::getRangeChecker( $services ), |
|
199 | - $config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' ) |
|
200 | - => ConstraintCheckerServices::getDiffWithinRangeChecker( $services ), |
|
201 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ) |
|
202 | - => ConstraintCheckerServices::getTypeChecker( $services ), |
|
203 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ) |
|
204 | - => ConstraintCheckerServices::getValueTypeChecker( $services ), |
|
205 | - $config->get( 'WBQualityConstraintsSingleValueConstraintId' ) |
|
206 | - => ConstraintCheckerServices::getSingleValueChecker( $services ), |
|
207 | - $config->get( 'WBQualityConstraintsMultiValueConstraintId' ) |
|
208 | - => ConstraintCheckerServices::getMultiValueChecker( $services ), |
|
209 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ) |
|
210 | - => ConstraintCheckerServices::getUniqueValueChecker( $services ), |
|
211 | - $config->get( 'WBQualityConstraintsFormatConstraintId' ) |
|
212 | - => ConstraintCheckerServices::getFormatChecker( $services ), |
|
213 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ) |
|
214 | - => ConstraintCheckerServices::getCommonsLinkChecker( $services ), |
|
215 | - $config->get( 'WBQualityConstraintsOneOfConstraintId' ) |
|
216 | - => ConstraintCheckerServices::getOneOfChecker( $services ), |
|
217 | - $config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' ) |
|
218 | - => ConstraintCheckerServices::getValueOnlyChecker( $services ), |
|
219 | - $config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' ) |
|
220 | - => ConstraintCheckerServices::getReferenceChecker( $services ), |
|
221 | - $config->get( 'WBQualityConstraintsNoBoundsConstraintId' ) |
|
222 | - => ConstraintCheckerServices::getNoBoundsChecker( $services ), |
|
223 | - $config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' ) |
|
224 | - => ConstraintCheckerServices::getAllowedUnitsChecker( $services ), |
|
225 | - $config->get( 'WBQualityConstraintsSingleBestValueConstraintId' ) |
|
226 | - => ConstraintCheckerServices::getSingleBestValueChecker( $services ), |
|
227 | - $config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' ) |
|
228 | - => ConstraintCheckerServices::getEntityTypeChecker( $services ), |
|
229 | - $config->get( 'WBQualityConstraintsNoneOfConstraintId' ) |
|
230 | - => ConstraintCheckerServices::getNoneOfChecker( $services ), |
|
231 | - $config->get( 'WBQualityConstraintsIntegerConstraintId' ) |
|
232 | - => ConstraintCheckerServices::getIntegerChecker( $services ), |
|
233 | - $config->get( 'WBQualityConstraintsCitationNeededConstraintId' ) |
|
234 | - => ConstraintCheckerServices::getCitationNeededChecker( $services ), |
|
235 | - $config->get( 'WBQualityConstraintsPropertyScopeConstraintId' ) |
|
236 | - => ConstraintCheckerServices::getPropertyScopeChecker( $services ), |
|
237 | - $config->get( 'WBQualityConstraintsContemporaryConstraintId' ) |
|
238 | - => ConstraintCheckerServices::getContemporaryChecker( $services ), |
|
239 | - $config->get( 'WBQualityConstraintsLexemeLanguageConstraintId' ) |
|
240 | - => ConstraintCheckerServices::getLexemeLanguageChecker( $services ), |
|
241 | - $config->get( 'WBQualityConstraintsLabelInLanguageConstraintId' ) |
|
242 | - => ConstraintCheckerServices::getLabelInLanguageChecker( $services ), |
|
181 | + $config->get('WBQualityConstraintsConflictsWithConstraintId') |
|
182 | + => ConstraintCheckerServices::getConflictsWithChecker($services), |
|
183 | + $config->get('WBQualityConstraintsItemRequiresClaimConstraintId') |
|
184 | + => ConstraintCheckerServices::getItemChecker($services), |
|
185 | + $config->get('WBQualityConstraintsValueRequiresClaimConstraintId') |
|
186 | + => ConstraintCheckerServices::getTargetRequiredClaimChecker($services), |
|
187 | + $config->get('WBQualityConstraintsSymmetricConstraintId') |
|
188 | + => ConstraintCheckerServices::getSymmetricChecker($services), |
|
189 | + $config->get('WBQualityConstraintsInverseConstraintId') |
|
190 | + => ConstraintCheckerServices::getInverseChecker($services), |
|
191 | + $config->get('WBQualityConstraintsUsedAsQualifierConstraintId') |
|
192 | + => ConstraintCheckerServices::getQualifierChecker($services), |
|
193 | + $config->get('WBQualityConstraintsAllowedQualifiersConstraintId') |
|
194 | + => ConstraintCheckerServices::getQualifiersChecker($services), |
|
195 | + $config->get('WBQualityConstraintsMandatoryQualifierConstraintId') |
|
196 | + => ConstraintCheckerServices::getMandatoryQualifiersChecker($services), |
|
197 | + $config->get('WBQualityConstraintsRangeConstraintId') |
|
198 | + => ConstraintCheckerServices::getRangeChecker($services), |
|
199 | + $config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId') |
|
200 | + => ConstraintCheckerServices::getDiffWithinRangeChecker($services), |
|
201 | + $config->get('WBQualityConstraintsTypeConstraintId') |
|
202 | + => ConstraintCheckerServices::getTypeChecker($services), |
|
203 | + $config->get('WBQualityConstraintsValueTypeConstraintId') |
|
204 | + => ConstraintCheckerServices::getValueTypeChecker($services), |
|
205 | + $config->get('WBQualityConstraintsSingleValueConstraintId') |
|
206 | + => ConstraintCheckerServices::getSingleValueChecker($services), |
|
207 | + $config->get('WBQualityConstraintsMultiValueConstraintId') |
|
208 | + => ConstraintCheckerServices::getMultiValueChecker($services), |
|
209 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId') |
|
210 | + => ConstraintCheckerServices::getUniqueValueChecker($services), |
|
211 | + $config->get('WBQualityConstraintsFormatConstraintId') |
|
212 | + => ConstraintCheckerServices::getFormatChecker($services), |
|
213 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId') |
|
214 | + => ConstraintCheckerServices::getCommonsLinkChecker($services), |
|
215 | + $config->get('WBQualityConstraintsOneOfConstraintId') |
|
216 | + => ConstraintCheckerServices::getOneOfChecker($services), |
|
217 | + $config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId') |
|
218 | + => ConstraintCheckerServices::getValueOnlyChecker($services), |
|
219 | + $config->get('WBQualityConstraintsUsedAsReferenceConstraintId') |
|
220 | + => ConstraintCheckerServices::getReferenceChecker($services), |
|
221 | + $config->get('WBQualityConstraintsNoBoundsConstraintId') |
|
222 | + => ConstraintCheckerServices::getNoBoundsChecker($services), |
|
223 | + $config->get('WBQualityConstraintsAllowedUnitsConstraintId') |
|
224 | + => ConstraintCheckerServices::getAllowedUnitsChecker($services), |
|
225 | + $config->get('WBQualityConstraintsSingleBestValueConstraintId') |
|
226 | + => ConstraintCheckerServices::getSingleBestValueChecker($services), |
|
227 | + $config->get('WBQualityConstraintsAllowedEntityTypesConstraintId') |
|
228 | + => ConstraintCheckerServices::getEntityTypeChecker($services), |
|
229 | + $config->get('WBQualityConstraintsNoneOfConstraintId') |
|
230 | + => ConstraintCheckerServices::getNoneOfChecker($services), |
|
231 | + $config->get('WBQualityConstraintsIntegerConstraintId') |
|
232 | + => ConstraintCheckerServices::getIntegerChecker($services), |
|
233 | + $config->get('WBQualityConstraintsCitationNeededConstraintId') |
|
234 | + => ConstraintCheckerServices::getCitationNeededChecker($services), |
|
235 | + $config->get('WBQualityConstraintsPropertyScopeConstraintId') |
|
236 | + => ConstraintCheckerServices::getPropertyScopeChecker($services), |
|
237 | + $config->get('WBQualityConstraintsContemporaryConstraintId') |
|
238 | + => ConstraintCheckerServices::getContemporaryChecker($services), |
|
239 | + $config->get('WBQualityConstraintsLexemeLanguageConstraintId') |
|
240 | + => ConstraintCheckerServices::getLexemeLanguageChecker($services), |
|
241 | + $config->get('WBQualityConstraintsLabelInLanguageConstraintId') |
|
242 | + => ConstraintCheckerServices::getLabelInLanguageChecker($services), |
|
243 | 243 | ]; |
244 | 244 | |
245 | 245 | return new DelegatingConstraintChecker( |
246 | - WikibaseServices::getEntityLookup( $services ), |
|
246 | + WikibaseServices::getEntityLookup($services), |
|
247 | 247 | $checkerMap, |
248 | - ConstraintsServices::getConstraintLookup( $services ), |
|
249 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
248 | + ConstraintsServices::getConstraintLookup($services), |
|
249 | + ConstraintsServices::getConstraintParameterParser($services), |
|
250 | 250 | $statementGuidParser, |
251 | - ConstraintsServices::getLoggingHelper( $services ), |
|
252 | - $config->get( 'WBQualityConstraintsCheckQualifiers' ), |
|
253 | - $config->get( 'WBQualityConstraintsCheckReferences' ), |
|
254 | - $config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' ) |
|
251 | + ConstraintsServices::getLoggingHelper($services), |
|
252 | + $config->get('WBQualityConstraintsCheckQualifiers'), |
|
253 | + $config->get('WBQualityConstraintsCheckReferences'), |
|
254 | + $config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers') |
|
255 | 255 | ); |
256 | 256 | }, |
257 | 257 | |
258 | - ConstraintsServices::RESULTS_SOURCE => static function ( MediaWikiServices $services ) { |
|
258 | + ConstraintsServices::RESULTS_SOURCE => static function(MediaWikiServices $services) { |
|
259 | 259 | $config = $services->getMainConfig(); |
260 | 260 | $resultsSource = new CheckingResultsSource( |
261 | - ConstraintsServices::getDelegatingConstraintChecker( $services ) |
|
261 | + ConstraintsServices::getDelegatingConstraintChecker($services) |
|
262 | 262 | ); |
263 | 263 | |
264 | 264 | $cacheCheckConstraintsResults = false; |
265 | 265 | |
266 | - if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) { |
|
266 | + if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) { |
|
267 | 267 | $cacheCheckConstraintsResults = true; |
268 | 268 | // check that we can use getLocalRepoWikiPageMetaDataAccessor() |
269 | 269 | // TODO we should always be able to cache constraint check results (T244726) |
270 | - $entitySources = WikibaseRepo::getEntitySourceDefinitions( $services )->getSources(); |
|
271 | - $localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName(); |
|
270 | + $entitySources = WikibaseRepo::getEntitySourceDefinitions($services)->getSources(); |
|
271 | + $localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName(); |
|
272 | 272 | |
273 | - foreach ( $entitySources as $entitySource ) { |
|
274 | - if ( $entitySource->getSourceName() !== $localEntitySourceName ) { |
|
275 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' )->warning( |
|
276 | - 'Cannot cache constraint check results for non-local source: ' . |
|
273 | + foreach ($entitySources as $entitySource) { |
|
274 | + if ($entitySource->getSourceName() !== $localEntitySourceName) { |
|
275 | + LoggerFactory::getInstance('WikibaseQualityConstraints')->warning( |
|
276 | + 'Cannot cache constraint check results for non-local source: '. |
|
277 | 277 | $entitySource->getSourceName() |
278 | 278 | ); |
279 | 279 | $cacheCheckConstraintsResults = false; |
@@ -282,40 +282,40 @@ discard block |
||
282 | 282 | } |
283 | 283 | } |
284 | 284 | |
285 | - if ( $cacheCheckConstraintsResults ) { |
|
285 | + if ($cacheCheckConstraintsResults) { |
|
286 | 286 | $possiblyStaleConstraintTypes = [ |
287 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ), |
|
288 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ), |
|
289 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ), |
|
290 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ), |
|
287 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId'), |
|
288 | + $config->get('WBQualityConstraintsTypeConstraintId'), |
|
289 | + $config->get('WBQualityConstraintsValueTypeConstraintId'), |
|
290 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId'), |
|
291 | 291 | ]; |
292 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
292 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
293 | 293 | $wikiPageEntityMetaDataAccessor = WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor( |
294 | 294 | $services ); |
295 | 295 | |
296 | 296 | $resultsSource = new CachingResultsSource( |
297 | 297 | $resultsSource, |
298 | 298 | ResultsCache::getDefaultInstance(), |
299 | - ConstraintsServices::getCheckResultSerializer( $services ), |
|
300 | - ConstraintsServices::getCheckResultDeserializer( $services ), |
|
299 | + ConstraintsServices::getCheckResultSerializer($services), |
|
300 | + ConstraintsServices::getCheckResultDeserializer($services), |
|
301 | 301 | $wikiPageEntityMetaDataAccessor, |
302 | 302 | $entityIdParser, |
303 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ), |
|
303 | + $config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'), |
|
304 | 304 | $possiblyStaleConstraintTypes, |
305 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ), |
|
306 | - ConstraintsServices::getLoggingHelper( $services ) |
|
305 | + $config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'), |
|
306 | + ConstraintsServices::getLoggingHelper($services) |
|
307 | 307 | ); |
308 | 308 | } |
309 | 309 | |
310 | 310 | return $resultsSource; |
311 | 311 | }, |
312 | 312 | |
313 | - ConstraintsServices::VIOLATION_MESSAGE_RENDERER_FACTORY => static function ( MediaWikiServices $services ) { |
|
313 | + ConstraintsServices::VIOLATION_MESSAGE_RENDERER_FACTORY => static function(MediaWikiServices $services) { |
|
314 | 314 | return new ViolationMessageRendererFactory( |
315 | 315 | $services->getMainConfig(), |
316 | 316 | $services->getLanguageNameUtils(), |
317 | - WikibaseRepo::getEntityIdHtmlLinkFormatterFactory( $services ), |
|
318 | - WikibaseRepo::getValueFormatterFactory( $services ) |
|
317 | + WikibaseRepo::getEntityIdHtmlLinkFormatterFactory($services), |
|
318 | + WikibaseRepo::getValueFormatterFactory($services) |
|
319 | 319 | ); |
320 | 320 | }, |
321 | 321 | ]; |