wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintReportFactory.php

Spacing +51 added lines, -51 removed lines

@@ -188,7 +188,7 @@ 
 	public static function getDefaultInstance() {
 		static $instance = null;
 
-		if ( $instance === null ) {
+		if ($instance === null) {
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 			$config = MediaWikiServices::getInstance()->getMainConfig();
 			$titleParser = MediaWikiServices::getInstance()->getTitleParser();
@@ -257,17 +257,17 @@ 
 	 * @return DelegatingConstraintChecker
 	 */
 	public function getConstraintChecker() {
-		if ( $this->delegatingConstraintChecker === null ) {
+		if ($this->delegatingConstraintChecker === null) {
 			$this->delegatingConstraintChecker = new DelegatingConstraintChecker(
 				$this->lookup,
 				$this->getConstraintCheckerMap(),
-				new CachingConstraintLookup( $this->getConstraintRepository() ),
+				new CachingConstraintLookup($this->getConstraintRepository()),
 				$this->constraintParameterParser,
 				$this->statementGuidParser,
 				ConstraintsServices::getLoggingHelper(),
-				$this->config->get( 'WBQualityConstraintsCheckQualifiers' ),
-				$this->config->get( 'WBQualityConstraintsCheckReferences' ),
-				$this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
+				$this->config->get('WBQualityConstraintsCheckQualifiers'),
+				$this->config->get('WBQualityConstraintsCheckReferences'),
+				$this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
 			);
 		}
 
@@ -278,10 +278,10 @@ 
 	 * @return ConstraintChecker[]
 	 */
 	private function getConstraintCheckerMap() {
-		if ( $this->constraintCheckerMap === null ) {
+		if ($this->constraintCheckerMap === null) {
 			$connectionCheckerHelper = new ConnectionCheckerHelper();
-			$rangeCheckerHelper = new RangeCheckerHelper( $this->config, $this->unitConverter );
-			if ( $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ) !== '' ) {
+			$rangeCheckerHelper = new RangeCheckerHelper($this->config, $this->unitConverter);
+			if ($this->config->get('WBQualityConstraintsSparqlEndpoint') !== '') {
 				$sparqlHelper = new SparqlHelper(
 					$this->config,
 					$this->rdfVocabulary,
@@ -303,118 +303,118 @@ 
 			);
 
 			$this->constraintCheckerMap = [
-				$this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
+				$this->config->get('WBQualityConstraintsConflictsWithConstraintId')
 					=> new ConflictsWithChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
+				$this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
 					=> new ItemChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
+				$this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
 					=> new TargetRequiredClaimChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsSymmetricConstraintId' )
+				$this->config->get('WBQualityConstraintsSymmetricConstraintId')
 					=> new SymmetricChecker(
 						$this->lookup,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsInverseConstraintId' )
+				$this->config->get('WBQualityConstraintsInverseConstraintId')
 					=> new InverseChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
 					=> new QualifierChecker(),
-				$this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
+				$this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
 					=> new QualifiersChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
+				$this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
 					=> new MandatoryQualifiersChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsRangeConstraintId' )
+				$this->config->get('WBQualityConstraintsRangeConstraintId')
 					=> new RangeChecker(
 						$this->propertyDataTypeLookup,
 						$this->constraintParameterParser,
 						$rangeCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
+				$this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
 					=> new DiffWithinRangeChecker(
 						$this->constraintParameterParser,
 						$rangeCheckerHelper,
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsTypeConstraintId' )
+				$this->config->get('WBQualityConstraintsTypeConstraintId')
 					=> new TypeChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$typeCheckerHelper,
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' )
+				$this->config->get('WBQualityConstraintsValueTypeConstraintId')
 					=> new ValueTypeChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$typeCheckerHelper,
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsSingleValueConstraintId' )
-					=> new SingleValueChecker( $this->constraintParameterParser ),
-				$this->config->get( 'WBQualityConstraintsMultiValueConstraintId' )
-					=> new MultiValueChecker( $this->constraintParameterParser ),
-				$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
+				$this->config->get('WBQualityConstraintsSingleValueConstraintId')
+					=> new SingleValueChecker($this->constraintParameterParser),
+				$this->config->get('WBQualityConstraintsMultiValueConstraintId')
+					=> new MultiValueChecker($this->constraintParameterParser),
+				$this->config->get('WBQualityConstraintsDistinctValuesConstraintId')
 					=> new UniqueValueChecker(
 						$sparqlHelper
 					),
-				$this->config->get( 'WBQualityConstraintsFormatConstraintId' )
+				$this->config->get('WBQualityConstraintsFormatConstraintId')
 					=> new FormatChecker(
 						$this->constraintParameterParser,
 						$this->config,
 						$sparqlHelper
 					),
-				$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
+				$this->config->get('WBQualityConstraintsCommonsLinkConstraintId')
 					=> new CommonsLinkChecker(
 						$this->constraintParameterParser,
 						$this->titleParser
 					),
-				$this->config->get( 'WBQualityConstraintsOneOfConstraintId' )
+				$this->config->get('WBQualityConstraintsOneOfConstraintId')
 					=> new OneOfChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
 					=> new ValueOnlyChecker(),
-				$this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
 					=> new ReferenceChecker(),
-				$this->config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
+				$this->config->get('WBQualityConstraintsNoBoundsConstraintId')
 					=> new NoBoundsChecker(),
-				$this->config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
+				$this->config->get('WBQualityConstraintsAllowedUnitsConstraintId')
 					=> new AllowedUnitsChecker(
 						$this->constraintParameterParser,
 						$this->unitConverter
 					),
-				$this->config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
-					=> new SingleBestValueChecker( $this->constraintParameterParser ),
-				$this->config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
+				$this->config->get('WBQualityConstraintsSingleBestValueConstraintId')
+					=> new SingleBestValueChecker($this->constraintParameterParser),
+				$this->config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
 					=> new EntityTypeChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsNoneOfConstraintId' )
+				$this->config->get('WBQualityConstraintsNoneOfConstraintId')
 					=> new NoneOfChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsIntegerConstraintId' )
+				$this->config->get('WBQualityConstraintsIntegerConstraintId')
 					=> new IntegerChecker(),
-				$this->config->get( 'WBQualityConstraintsCitationNeededConstraintId' )
+				$this->config->get('WBQualityConstraintsCitationNeededConstraintId')
 					=> new CitationNeededChecker(),
 			];
 		}
@@ -426,7 +426,7 @@ 
 	 * @return ConstraintRepository
 	 */
 	public function getConstraintRepository() {
-		if ( $this->constraintRepository === null ) {
+		if ($this->constraintRepository === null) {
 			$this->constraintRepository = new ConstraintRepository();
 		}
 
@@ -437,7 +437,7 @@ 
 	 * @return CheckResultSerializer
 	 */
 	public function getCheckResultSerializer() {
-		if ( $this->checkResultSerializer === null ) {
+		if ($this->checkResultSerializer === null) {
 			$this->checkResultSerializer = new CheckResultSerializer(
 				new ConstraintSerializer(
 					false // constraint parameters are not exposed
@@ -455,7 +455,7 @@ 
 	 * @return CheckResultDeserializer
 	 */
 	public function getCheckResultDeserializer() {
-		if ( $this->checkResultDeserializer === null ) {
+		if ($this->checkResultDeserializer === null) {
 			$this->checkResultDeserializer = new CheckResultDeserializer(
 				new ConstraintDeserializer(),
 				new ContextCursorDeserializer(),
@@ -474,7 +474,7 @@ 
 	 * @return WikiPageEntityMetaDataAccessor
 	 */
 	public function getWikiPageEntityMetaDataAccessor() {
-		if ( $this->wikiPageEntityMetaDataAccessor === null ) {
+		if ($this->wikiPageEntityMetaDataAccessor === null) {
 			$this->wikiPageEntityMetaDataAccessor = new WikiPageEntityMetaDataLookup(
 				$this->entityNamespaceLookup
 			);
@@ -487,12 +487,12 @@ 
 	 * @return ResultsSource
 	 */
 	public function getResultsSource() {
-		if ( $this->resultsSource === null ) {
+		if ($this->resultsSource === null) {
 			$this->resultsSource = new CheckingResultsSource(
 				$this->getConstraintChecker()
 			);
 
-			if ( $this->config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
+			if ($this->config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
 				$this->resultsSource = new CachingResultsSource(
 					$this->resultsSource,
 					ResultsCache::getDefaultInstance(),
@@ -500,9 +500,9 @@ 
 					$this->getCheckResultDeserializer(),
 					$this->getWikiPageEntityMetaDataAccessor(),
 					$this->entityIdParser,
-					$this->config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
+					$this->config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
 					$this->getPossiblyStaleConstraintTypes(),
-					$this->config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ),
+					$this->config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'),
 					ConstraintsServices::getLoggingHelper()
 				);
 			}
@@ -516,10 +516,10 @@ 
 	 */
 	public function getPossiblyStaleConstraintTypes() {
 		return [
-			$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
-			$this->config->get( 'WBQualityConstraintsTypeConstraintId' ),
-			$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
-			$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
+			$this->config->get('WBQualityConstraintsCommonsLinkConstraintId'),
+			$this->config->get('WBQualityConstraintsTypeConstraintId'),
+			$this->config->get('WBQualityConstraintsValueTypeConstraintId'),
+			$this->config->get('WBQualityConstraintsDistinctValuesConstraintId'),
 		];
 	}
 

src/ConstraintsServices.php

Spacing +5 added lines, -5 removed lines

@@ -10,19 +10,19 @@
  */
 class ConstraintsServices {
 
-	private static function getService( MediaWikiServices $services = null, $name ) {
-		if ( $services === null ) {
+	private static function getService(MediaWikiServices $services = null, $name) {
+		if ($services === null) {
 			$services = MediaWikiServices::getInstance();
 		}
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return LoggingHelper
 	 */
-	public static function getLoggingHelper( MediaWikiServices $services = null ) {
-		return self::getService( $services, 'WBQC_LoggingHelper' );
+	public static function getLoggingHelper(MediaWikiServices $services = null) {
+		return self::getService($services, 'WBQC_LoggingHelper');
 	}
 
 }

src/ServiceWiring.php

Spacing +2 added lines, -2 removed lines

@@ -7,10 +7,10 @@
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\LoggingHelper;
 
 return [
-	'WBQC_LoggingHelper' => function( MediaWikiServices $services ) {
+	'WBQC_LoggingHelper' => function(MediaWikiServices $services) {
 		return new LoggingHelper(
 			$services->getStatsdDataFactory(),
-			LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
+			LoggerFactory::getInstance('WikibaseQualityConstraints'),
 			$services->getMainConfig()
 		);
 	},