wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Api/CachingResultsBuilder.php

Spacing +32 added lines, -33 removed lines

@@ -87,26 +87,26 @@ 
 	) {
 		$results = [];
 		$metadatas = [];
-		if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds ) ) {
+		if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds)) {
 			$storedEntityIds = [];
-			foreach ( $entityIds as $entityId ) {
-				$storedResults = $this->getStoredResults( $entityId );
-				if ( $storedResults !== null ) {
+			foreach ($entityIds as $entityId) {
+				$storedResults = $this->getStoredResults($entityId);
+				if ($storedResults !== null) {
 					$results += $storedResults->getArray();
 					$metadatas[] = $storedResults->getMetadata();
 					$storedEntityIds[] = $entityId;
 				}
 			}
-			$entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) );
+			$entityIds = array_values(array_diff($entityIds, $storedEntityIds));
 		}
-		if ( $entityIds !== [] || $claimIds !== [] ) {
-			$response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds );
+		if ($entityIds !== [] || $claimIds !== []) {
+			$response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds);
 			$results += $response->getArray();
 			$metadatas[] = $response->getMetadata();
 		}
 		return new CachedCheckConstraintsResponse(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -132,7 +132,7 @@ 
 	 * @param EntityId $entityId
 	 * @return string cache key
 	 */
-	public function getKey( EntityId $entityId ) {
+	public function getKey(EntityId $entityId) {
 		return $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'checkConstraints', // action
@@ -152,18 +152,18 @@ 
 		array $claimIds,
 		array $constraintIds = null
 	) {
-		$results = $this->resultsBuilder->getResults( $entityIds, $claimIds, $constraintIds );
+		$results = $this->resultsBuilder->getResults($entityIds, $claimIds, $constraintIds);
 
-		if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds ) ) {
-			foreach ( $entityIds as $entityId ) {
-				$key = $this->getKey( $entityId );
+		if ($this->canStoreResults($entityIds, $claimIds, $constraintIds)) {
+			foreach ($entityIds as $entityId) {
+				$key = $this->getKey($entityId);
 				$value = [
 					'results' => $results->getArray()[$entityId->getSerialization()],
 					'latestRevisionIds' => $this->getLatestRevisionIds(
 						$results->getMetadata()->getDependencyMetadata()->getEntityIds()
 					),
 				];
-				$this->cache->set( $key, $value, $this->ttlInSeconds );
+				$this->cache->set($key, $value, $this->ttlInSeconds);
 			}
 		}
 
@@ -196,41 +196,40 @@ 
 	public function getStoredResults(
 		EntityId $entityId
 	) {
-		$key = $this->getKey( $entityId );
-		$value = $this->cache->get( $key, $curTTL, [], $asOf );
-		$now = call_user_func( $this->microtime, true );
+		$key = $this->getKey($entityId);
+		$value = $this->cache->get($key, $curTTL, [], $asOf);
+		$now = call_user_func($this->microtime, true);
 
-		if ( $value === false ) {
+		if ($value === false) {
 			return null;
 		}
 
-		$ageInSeconds = (integer)ceil( $now - $asOf );
+		$ageInSeconds = (integer) ceil($now - $asOf);
 
 		$dependedEntityIds = array_map(
-			[ $this->entityIdParser, "parse" ],
-			array_keys( $value['latestRevisionIds'] )
+			[$this->entityIdParser, "parse"],
+			array_keys($value['latestRevisionIds'])
 		);
 
-		if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) {
+		if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) {
 			return null;
 		}
 
 		return new CachedCheckConstraintsResponse(
-			[ $entityId->getSerialization() => $value['results'] ],
+			[$entityId->getSerialization() => $value['results']],
 			array_reduce(
 				$dependedEntityIds,
-				function( Metadata $metadata, EntityId $entityId ) {
-					return Metadata::merge( [
+				function(Metadata $metadata, EntityId $entityId) {
+					return Metadata::merge([
 						$metadata,
 						Metadata::ofDependencyMetadata(
-							DependencyMetadata::ofEntityId( $entityId )
+							DependencyMetadata::ofEntityId($entityId)
 						)
-					] );
+					]);
 				},
 				Metadata::ofCachingMetadata(
 					$ageInSeconds > 0 ?
-						CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) :
-						CachingMetadata::fresh()
+						CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh()
 				)
 			)
 		);
@@ -240,11 +239,11 @@ 
 	 * @param EntityId[] $entityIds
 	 * @return int[]
 	 */
-	private function getLatestRevisionIds( array $entityIds ) {
+	private function getLatestRevisionIds(array $entityIds) {
 		$latestRevisionIds = [];
-		foreach ( $entityIds as $entityId ) {
+		foreach ($entityIds as $entityId) {
 			$serialization = $entityId->getSerialization();
-			$latestRevisionId = $this->entityRevisionLookup->getLatestRevisionId( $entityId );
+			$latestRevisionId = $this->entityRevisionLookup->getLatestRevisionId($entityId);
 			$latestRevisionIds[$serialization] = $latestRevisionId;
 		}
 		return $latestRevisionIds;
@@ -255,7 +254,7 @@ 
 	 *
 	 * @param callable $microtime
 	 */
-	public function setMicrotimeFunction( callable $microtime ) {
+	public function setMicrotimeFunction(callable $microtime) {
 		$this->microtime = $microtime;
 	}
 

src/Api/CheckConstraints.php

Spacing +41 added lines, -41 removed lines

@@ -69,22 +69,22 @@ 
 	 *
 	 * @return self
 	 */
-	public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) {
+	public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') {
 		$repo = WikibaseRepo::getDefaultInstance();
 
 		$language = $repo->getUserLanguage();
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
 		$valueFormatterFactory = $repo->getValueFormatterFactory();
-		$valueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions );
+		$valueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions);
 
 		$languageFallbackLabelDescriptionLookupFactory = $repo->getLanguageFallbackLabelDescriptionLookupFactory();
-		$labelDescriptionLookup = $languageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup( $language );
+		$labelDescriptionLookup = $languageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup($language);
 		$entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory();
-		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $labelDescriptionLookup );
+		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($labelDescriptionLookup);
 		$entityIdLabelFormatterFactory = new EntityIdLabelFormatterFactory();
-		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $labelDescriptionLookup );
-		$constraintParameterRenderer = new ConstraintParameterRenderer( $entityIdHtmlLinkFormatter, $valueFormatter );
+		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($labelDescriptionLookup);
+		$constraintParameterRenderer = new ConstraintParameterRenderer($entityIdHtmlLinkFormatter, $valueFormatter);
 		$config = MediaWikiServices::getInstance()->getMainConfig();
 		$titleParser = MediaWikiServices::getInstance()->getTitleParser();
 		$unitConverter = $repo->getUnitConverter();
@@ -112,7 +112,7 @@ 
 			$constraintParameterRenderer,
 			$config
 		);
-		if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
+		if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
 			$cache = MediaWikiServices::getInstance()->getMainWANObjectCache();
 			$entityRevisionLookup = $repo->getEntityRevisionLookup();
 			$entityIdParser = $repo->getEntityIdParser();
@@ -121,7 +121,7 @@ 
 				$cache,
 				$entityRevisionLookup,
 				$entityIdParser,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' )
+				$config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds')
 			);
 		}
 
@@ -131,7 +131,7 @@ 
 			$prefix,
 			$repo->getEntityIdParser(),
 			$repo->getStatementGuidValidator(),
-			$repo->getApiHelperFactory( RequestContext::getMain() ),
+			$repo->getApiHelperFactory(RequestContext::getMain()),
 			$resultsBuilder
 		);
 	}
@@ -145,16 +145,16 @@ 
 	 * @param ApiHelperFactory $apiHelperFactory
 	 * @param ResultsBuilder $resultsBuilder
 	 */
-	public function __construct( ApiMain $main, $name, $prefix = '', EntityIdParser $entityIdParser,
+	public function __construct(ApiMain $main, $name, $prefix = '', EntityIdParser $entityIdParser,
 								 StatementGuidValidator $statementGuidValidator,
 								 ApiHelperFactory $apiHelperFactory,
 								 ResultsBuilder $resultsBuilder
 	) {
-		parent::__construct( $main, $name, $prefix );
+		parent::__construct($main, $name, $prefix);
 		$this->entityIdParser = $entityIdParser;
 		$this->statementGuidValidator = $statementGuidValidator;
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->resultsBuilder = $resultsBuilder;
 	}
 
@@ -163,13 +163,13 @@ 
 	 */
 	public function execute() {
 		MediaWikiServices::getInstance()->getStatsdDataFactory()
-			->increment( 'wikibase.quality.constraints.api.checkConstraints.execute' );
+			->increment('wikibase.quality.constraints.api.checkConstraints.execute');
 
 		$params = $this->extractRequestParams();
 
-		$this->validateParameters( $params );
-		$entityIds = $this->parseEntityIds( $params );
-		$claimIds = $this->parseClaimIds( $params );
+		$this->validateParameters($params);
+		$entityIds = $this->parseEntityIds($params);
+		$claimIds = $this->parseClaimIds($params);
 		$constraintIDs = $params[self::PARAM_CONSTRAINT_ID];
 
 		$this->getResult()->addValue(
@@ -181,64 +181,64 @@ 
 			)->getArray()
 		);
 		// ensure that result contains the given entity IDs even if they have no statements
-		foreach ( $entityIds as $entityId ) {
+		foreach ($entityIds as $entityId) {
 			$this->getResult()->addArrayType(
-				[ $this->getModuleName(), $entityId->getSerialization() ],
+				[$this->getModuleName(), $entityId->getSerialization()],
 				'assoc'
 			);
 		}
-		$this->resultBuilder->markSuccess( 1 );
+		$this->resultBuilder->markSuccess(1);
 	}
 
-	private function parseEntityIds( array $params ) {
+	private function parseEntityIds(array $params) {
 		$ids = $params[self::PARAM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		return array_map( function ( $id ) {
+		return array_map(function($id) {
 			try {
-				return $this->entityIdParser->parse( $id );
-			} catch ( EntityIdParsingException $e ) {
+				return $this->entityIdParser->parse($id);
+			} catch (EntityIdParsingException $e) {
 				$this->errorReporter->dieError(
-					"Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] );
+					"Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] );
 			}
-		}, $ids );
+		}, $ids);
 	}
 
-	private function parseClaimIds( array $params ) {
+	private function parseClaimIds(array $params) {
 		$ids = $params[self::PARAM_CLAIM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		foreach ( $ids as $id ) {
-			if ( !$this->statementGuidValidator->validate( $id ) ) {
+		foreach ($ids as $id) {
+			if (!$this->statementGuidValidator->validate($id)) {
 				$this->errorReporter->dieError(
-					"Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] );
+					"Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] );
 			}
 		}
 
 		return $ids;
 	}
 
-	private function validateParameters( array $params ) {
-		if ( $params[self::PARAM_CONSTRAINT_ID] !== null
-			 && empty( $params[self::PARAM_CONSTRAINT_ID] )
+	private function validateParameters(array $params) {
+		if ($params[self::PARAM_CONSTRAINT_ID] !== null
+			 && empty($params[self::PARAM_CONSTRAINT_ID])
 		) {
 			$paramConstraintId = self::PARAM_CONSTRAINT_ID;
 			$this->errorReporter->dieError(
 				"If $paramConstraintId is specified, it must be nonempty.", 'no-data' );
 		}
-		if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) {
+		if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) {
 			$paramId = self::PARAM_ID;
 			$paramClaimId = self::PARAM_CLAIM_ID;
 			$this->errorReporter->dieError(