View GitHub Repository mediawiki-extensions-WikibaseQualityConstraints

Schedule Inspection
Subscribe
Completed
Push — master ( b00e4a...e83aa0 )
by
unknown
37s
created
Status
Category
Toggle Patches
src/Api/ExpiryLock.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch 
@@ -26,7 +26,7 @@  discard block
 
 block discarded – undo
26 26 
 	/**
27 27 
 	 * @param BagOStuff $cache
28 28 
 	 */
29 
-	public function __construct( BagOStuff $cache ) {
29 
+	public function __construct(BagOStuff $cache) {
30 30 
 		$this->cache = $cache;
31 31 
 	}
32 32 
 
@@ -37,17 +37,17 @@  discard block
 
 block discarded – undo
37 37 
 	 *
38 38 
 	 * @throws \Wikimedia\Assert\ParameterTypeException
39 39 
 	 */
40 
-	private function makeKey( $id ) {
41 
-		if ( trim( $id ) === '' ) {
42 
-			throw new ParameterTypeException( '$id', 'non-empty string' );
40 
+	private function makeKey($id) {
41 
+		if (trim($id) === '') {
42 
+			throw new ParameterTypeException('$id', 'non-empty string');
43 43 
 		}
44 44
45 
-		Assert::parameterType( 'string', $id, '$id' );
45 
+		Assert::parameterType('string', $id, '$id');
46 46
47 47 
 		return $this->cache->makeKey(
48 48 
 			'WikibaseQualityConstraints',
49 49 
 			'ExpiryLock',
50 
-			(string)$id
50 
+			(string) $id
51 51 
 		);
52 52 
 	}
53 53 
 
@@ -59,15 +59,15 @@  discard block
 
 block discarded – undo
59 59 
 	 *
60 60 
 	 * @throws \Wikimedia\Assert\ParameterTypeException
61 61 
 	 */
62 
-	public function lock( $id, ConvertibleTimestamp $expiryTimestamp ) {
62 
+	public function lock($id, ConvertibleTimestamp $expiryTimestamp) {
63 63
64 
-		$cacheId = $this->makeKey( $id );
64 
+		$cacheId = $this->makeKey($id);
65 65
66 
-		if ( !$this->isLockedInternal( $cacheId ) ) {
66 
+		if (!$this->isLockedInternal($cacheId)) {
67 67 
 			return $this->cache->set(
68 68 
 				$cacheId,
69 
-				$expiryTimestamp->getTimestamp( TS_UNIX ),
70 
-				(int)$expiryTimestamp->getTimestamp( TS_UNIX )
69 
+				$expiryTimestamp->getTimestamp(TS_UNIX),
70 
+				(int) $expiryTimestamp->getTimestamp(TS_UNIX)
71 71 
 			);
72 72 
 		} else {
73 73 
 			return false;
 
@@ -81,20 +81,20 @@  discard block
 
 block discarded – undo
81 81 
 	 *
82 82 
 	 * @throws \Wikimedia\Assert\ParameterTypeException
83 83 
 	 */
84 
-	private function isLockedInternal( $cacheId ) {
85 
-		$expiryTime = $this->cache->get( $cacheId );
86 
-		if ( !$expiryTime ) {
84 
+	private function isLockedInternal($cacheId) {
85 
+		$expiryTime = $this->cache->get($cacheId);
86 
+		if (!$expiryTime) {
87 87 
 			return false;
88 88 
 		}
89 89
90 90 
 		try {
91 
-			$lockExpiryTimeStamp = new ConvertibleTimestamp( $expiryTime );
92 
-		} catch ( TimestampException $exception ) {
91 
+			$lockExpiryTimeStamp = new ConvertibleTimestamp($expiryTime);
92 
+		} catch (TimestampException $exception) {
93 93 
 			return false;
94 94 
 		}
95 95
96 96 
 		$now = new ConvertibleTimestamp();
97 
-		if ( $now->timestamp < $lockExpiryTimeStamp->timestamp ) {
97 
+		if ($now->timestamp < $lockExpiryTimeStamp->timestamp) {
98 98 
 			return true;
99 99 
 		} else {
100 100 
 			return false;
 
@@ -108,8 +108,8 @@  discard block
 
 block discarded – undo
108 108 
 	 *
109 109 
 	 * @throws \Wikimedia\Assert\ParameterTypeException
110 110 
 	 */
111 
-	public function isLocked( $id ) {
112 
-		return $this->isLockedInternal( $this->makeKey( $id ) );
111 
+	public function isLocked($id) {
112 
+		return $this->isLockedInternal($this->makeKey($id));
113 113 
 	}
114 114
115 115 
 }
Please login to merge, or discard this patch.